In D144510#4254959, @dougpuob wrote:

Hi @amurzeau

I missed the review before landing. I have a suggestion regarding the customized prefix "cust" because it confused me when I found the Hungarian notation patterns in the output message. Perhaps using "my" instead of "cust" would improve readability.

Take some examples:

• const char *custszNamePtr = "Name"; --> myszNamePtr
• uint8_t custu8ValueU8 = 0; --> myu8ValueU8
• DWORD custdwMsDword = 0; --> mydwMsDword

Thanks ! LGTM, nothing to add.

In D144912#4204088, @carlosgalvezp wrote:

Looks great, approved! Thanks for fixing :)

In D144912#4203920, @carlosgalvezp wrote:

Looks good but I fail to understand what exactly the patch fixes, can you point me to an example in the tests?

The patch fixes these enum tests in C language mode:

enum REV_TYPE { RevValid };
// CHECK-MESSAGES: :[[@LINE-1]]:17: warning: invalid case style for enum constant 'RevValid' [readability-identifier-naming]
// CHECK-FIXES: {{^}}enum REV_TYPE { rtRevValid };

Hi, thanks PiotrZSL, the build is now passed and is green.

I see the build is still marked as failed in phabricator, but succeed in buildkite, do I need to do something, like a rebuild ?

Fix clang-format error, release notes and factorize typedefs in tests.

Update the release notes too, to notify of this changes with C files.

Rebase on main

In D144431#4146524, @carlosgalvezp wrote:

Alright, sounds good, thanks for the clarification! Then I misunderstood the change in the tests and indeed it belonged together in this patch, sorry for the confusion. I have approved both patches so we can land them now. Can you land the patch or would you like me to do it for you? If so please provide name and email (same as your Github account) for attribution.

Add a release note for this fix.

Remove test changes, I will make a different patch for that.

I don't have commit access to the repo, so please commit this for me when accepted. Thanks!

I do not have commit access to the repo, can someone commit this patch for me ? (after D144037)

I do not have commit access to the repo, can someone commit this patch for me ?

Allow use of --config and --config-file (with double dashes)