Page MenuHomePhabricator
Feed Advanced Search

Jan 28 2022

bakhtiyarneyman updated the diff for D117751: [async] Get the number of worker threads from the runtime..

Update relevant CMakeList.txt.

Jan 28 2022, 2:58 PM · Restricted Project

Jan 25 2022

bakhtiyarneyman added a comment to D117751: [async] Get the number of worker threads from the runtime..

PTAL.

Jan 25 2022, 5:00 PM · Restricted Project
bakhtiyarneyman updated the diff for D117751: [async] Get the number of worker threads from the runtime..

Address comments.

Jan 25 2022, 4:59 PM · Restricted Project

Jan 20 2022

bakhtiyarneyman added inline comments to D117751: [async] Get the number of worker threads from the runtime..
Jan 20 2022, 6:41 PM · Restricted Project
bakhtiyarneyman updated the diff for D117751: [async] Get the number of worker threads from the runtime..

Revert changes to Bazel file because it doesn't belong in this CL.

Jan 20 2022, 6:40 PM · Restricted Project
bakhtiyarneyman updated the diff for D117751: [async] Get the number of worker threads from the runtime..

Address comments.

Jan 20 2022, 6:33 PM · Restricted Project

Jan 19 2022

bakhtiyarneyman requested review of D117751: [async] Get the number of worker threads from the runtime..
Jan 19 2022, 11:03 PM · Restricted Project

Dec 16 2021

bakhtiyarneyman updated the diff for D115423: Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity..

Move minTaskSize definition earlier to avoid contaminating the analysis results with the partially executed rewrite logic.

Dec 16 2021, 6:13 PM · Restricted Project

Dec 15 2021

bakhtiyarneyman updated the diff for D115423: Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity..

Same thing for another lambda.

Dec 15 2021, 7:48 PM · Restricted Project
bakhtiyarneyman updated the diff for D115423: Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity..

Fix minor C++ compilation issue.

Dec 15 2021, 5:53 PM · Restricted Project
bakhtiyarneyman updated the diff for D115423: Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity..

Address nit.

Dec 15 2021, 5:31 PM · Restricted Project

Dec 14 2021

bakhtiyarneyman updated the diff for D115423: Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity..

Elide dynamic check if possible.

Dec 14 2021, 6:22 PM · Restricted Project
bakhtiyarneyman added inline comments to D115423: Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity..
Dec 14 2021, 5:51 PM · Restricted Project
bakhtiyarneyman updated the diff for D115423: Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity..

Address comments: lift the scf.if out of the loops.

Dec 14 2021, 5:50 PM · Restricted Project

Dec 13 2021

bakhtiyarneyman updated the diff for D115423: Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity..

Rebase. Note that this made some of the loop unrolling logic dynamic which seeped all the way into loop building.

Dec 13 2021, 8:42 PM · Restricted Project

Dec 9 2021

bakhtiyarneyman updated the diff for D115423: Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity..

Change the comment.

Dec 9 2021, 5:55 PM · Restricted Project
bakhtiyarneyman retitled D115423: Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity. from Make AsyncParallelFor pass parameterizable with a cost model which drives deciding the parallelization granularity. to Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity..
Dec 9 2021, 2:50 PM · Restricted Project
bakhtiyarneyman added a comment to D115423: Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity..

The revision title mentions "AsyncParallelFor pass" but this isn't touching the pass itself right?

Dec 9 2021, 2:49 PM · Restricted Project
bakhtiyarneyman updated the diff for D115423: Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity..

Improve docs.

Dec 9 2021, 2:47 PM · Restricted Project

Dec 8 2021

bakhtiyarneyman requested review of D115423: Make AsyncParallelForRewrite parameterizable with a cost model which drives deciding the parallelization granularity..
Dec 8 2021, 8:54 PM · Restricted Project

Nov 24 2021

bakhtiyarneyman added inline comments to D114496: Implement a cost model to drive the lowering of scf.parallel..
Nov 24 2021, 4:45 PM · Restricted Project
bakhtiyarneyman updated the diff for D114496: Implement a cost model to drive the lowering of scf.parallel..

Address comments.

Nov 24 2021, 4:43 PM · Restricted Project

Nov 23 2021

bakhtiyarneyman requested review of D114496: Implement a cost model to drive the lowering of scf.parallel..
Nov 23 2021, 7:43 PM · Restricted Project
bakhtiyarneyman updated the diff for D110680: Promote readability by factoring out creation of min/max operation. Remove unnecessary divisions..

Fix the failing test.

Nov 23 2021, 7:39 PM · Restricted Project

Oct 28 2021

bakhtiyarneyman updated the diff for D110680: Promote readability by factoring out creation of min/max operation. Remove unnecessary divisions..

Rebase to head.

Oct 28 2021, 4:30 PM · Restricted Project

Oct 18 2021

bakhtiyarneyman updated the diff for D110680: Promote readability by factoring out creation of min/max operation. Remove unnecessary divisions..

Use min/max ops.

Oct 18 2021, 7:40 PM · Restricted Project
bakhtiyarneyman requested review of D112051: Canonicalize max/min operations on integers..
Oct 18 2021, 7:39 PM · Restricted Project
bakhtiyarneyman updated the diff for D110680: Promote readability by factoring out creation of min/max operation. Remove unnecessary divisions..

Rebase.

Oct 18 2021, 3:17 PM · Restricted Project

Sep 29 2021

bakhtiyarneyman requested review of D110680: Promote readability by factoring out creation of min/max operation. Remove unnecessary divisions..
Sep 29 2021, 12:10 AM · Restricted Project

Sep 28 2021

bakhtiyarneyman updated the diff for D110605: Remove unnecessary async group creates and awaits..

Fix the test.

Sep 28 2021, 2:04 PM · Restricted Project
bakhtiyarneyman updated the diff for D110604: Rename target block size to min task size for clarity..

Appease clang.

Sep 28 2021, 2:03 PM · Restricted Project

Sep 27 2021

bakhtiyarneyman updated the summary of D110604: Rename target block size to min task size for clarity..
Sep 27 2021, 6:23 PM · Restricted Project
bakhtiyarneyman updated the summary of D110605: Remove unnecessary async group creates and awaits..
Sep 27 2021, 6:23 PM · Restricted Project
bakhtiyarneyman requested review of D110605: Remove unnecessary async group creates and awaits..
Sep 27 2021, 6:21 PM · Restricted Project
bakhtiyarneyman requested review of D110604: Rename target block size to min task size for clarity..
Sep 27 2021, 6:20 PM · Restricted Project

Aug 29 2021

bakhtiyarneyman accepted D103223: [ADT][WIP] Proof of concept impl of generic visit for PointerUnion.
Aug 29 2021, 2:00 PM · Restricted Project

Aug 9 2021

bakhtiyarneyman updated the diff for D107788: Fix a bug in algebraic simplification, and enable the tests..

Fix a typo.

Aug 9 2021, 3:42 PM · Restricted Project
bakhtiyarneyman requested review of D107788: Fix a bug in algebraic simplification, and enable the tests..
Aug 9 2021, 3:41 PM · Restricted Project

Jul 28 2021

bakhtiyarneyman updated the diff for D106731: Refactor AsyncToAsyncRuntime pass to boost understandability..

Superflous update.

Jul 28 2021, 3:29 PM · Restricted Project
bakhtiyarneyman updated the diff for D106730: Add an escape-hatch for conversion of funcs with blocking awaits to coroutines..

Address comments.

Jul 28 2021, 3:27 PM · Restricted Project
bakhtiyarneyman updated the diff for D106730: Add an escape-hatch for conversion of funcs with blocking awaits to coroutines..

Addressing comments.

Jul 28 2021, 2:58 PM · Restricted Project

Jul 27 2021

bakhtiyarneyman updated the diff for D106731: Refactor AsyncToAsyncRuntime pass to boost understandability..

Address comments.

Jul 27 2021, 4:29 PM · Restricted Project
bakhtiyarneyman updated the diff for D106730: Add an escape-hatch for conversion of funcs with blocking awaits to coroutines..

Use attributes as opposed to command line options.

Jul 27 2021, 4:28 PM · Restricted Project
bakhtiyarneyman added a comment to D106730: Add an escape-hatch for conversion of funcs with blocking awaits to coroutines..

We'll need to rewrite public functions at some point as well (after resolving all the issues with TFRT threading). Alternatively instead of passing list of function names it can be a boolean flag allow-rewriting-public-functions.

Jul 27 2021, 2:32 PM · Restricted Project
bakhtiyarneyman added inline comments to D106508: Optionally eliminate blocking runtime.await calls by converting functions to coroutines..
Jul 27 2021, 2:20 PM · Restricted Project
bakhtiyarneyman updated the diff for D106730: Add an escape-hatch for conversion of funcs with blocking awaits to coroutines..

Addressing comments.

Jul 27 2021, 2:15 PM · Restricted Project
bakhtiyarneyman updated the diff for D106508: Optionally eliminate blocking runtime.await calls by converting functions to coroutines..

Addressing comments.

Jul 27 2021, 2:14 PM · Restricted Project

Jul 26 2021

bakhtiyarneyman added inline comments to D106731: Refactor AsyncToAsyncRuntime pass to boost understandability..
Jul 26 2021, 4:38 PM · Restricted Project
bakhtiyarneyman updated the summary of D106730: Add an escape-hatch for conversion of funcs with blocking awaits to coroutines..
Jul 26 2021, 4:37 PM · Restricted Project
bakhtiyarneyman updated the summary of D106508: Optionally eliminate blocking runtime.await calls by converting functions to coroutines..
Jul 26 2021, 4:36 PM · Restricted Project
bakhtiyarneyman updated the diff for D106731: Refactor AsyncToAsyncRuntime pass to boost understandability..

Addressing comments.

Jul 26 2021, 4:14 PM · Restricted Project
bakhtiyarneyman updated the diff for D106730: Add an escape-hatch for conversion of funcs with blocking awaits to coroutines..

Addressing comments.

Jul 26 2021, 4:14 PM · Restricted Project
bakhtiyarneyman updated the diff for D106508: Optionally eliminate blocking runtime.await calls by converting functions to coroutines..

Addressing comments.

Jul 26 2021, 4:13 PM · Restricted Project

Jul 23 2021

bakhtiyarneyman requested review of D106731: Refactor AsyncToAsyncRuntime pass to boost understandability..
Jul 23 2021, 5:56 PM · Restricted Project
bakhtiyarneyman requested review of D106730: Add an escape-hatch for conversion of funcs with blocking awaits to coroutines..
Jul 23 2021, 5:55 PM · Restricted Project
bakhtiyarneyman added a reviewer for D106508: Optionally eliminate blocking runtime.await calls by converting functions to coroutines.: ezhulenev.
Jul 23 2021, 5:12 PM · Restricted Project
bakhtiyarneyman updated the diff for D106508: Optionally eliminate blocking runtime.await calls by converting functions to coroutines..

Address clang warnings.

Jul 23 2021, 4:16 PM · Restricted Project

Jul 21 2021

bakhtiyarneyman requested review of D106508: Optionally eliminate blocking runtime.await calls by converting functions to coroutines..
Jul 21 2021, 4:35 PM · Restricted Project

Apr 2 2021

bakhtiyarneyman updated the diff for D99561: Support visitor pattern by PointerUnion..

Aligned the calling convention of visit to match that of std::visit. Renamed the more convenient version of visit to match to have the best of the two worlds: better ergonomics and not clashing with std::visit. This time for real.

Apr 2 2021, 12:31 AM · Restricted Project
bakhtiyarneyman updated the diff for D99560: Utility to construct visitors from lambdas..

Include the VisitorTest.cpp into the CMakeList.txt.

Apr 2 2021, 12:29 AM · Restricted Project

Apr 1 2021

bakhtiyarneyman added a comment to D99560: Utility to construct visitors from lambdas..

Regarding deriving from using other kinds of functors: I have not yet seen a need for this. My preference is to cross that bridge when we reach it. :)

Apr 1 2021, 11:53 PM · Restricted Project
bakhtiyarneyman updated the diff for D99561: Support visitor pattern by PointerUnion..

Aligned the calling convention of visit to match that of std::visit. Renamed the more convenient version of visit to match to have the best of the two worlds: better ergonomics and not clashing with std::visit.

Apr 1 2021, 11:48 PM · Restricted Project
bakhtiyarneyman updated the diff for D99560: Utility to construct visitors from lambdas..

Added docs with usage example. Hid implementation in detail namespace.

Apr 1 2021, 11:47 PM · Restricted Project

Mar 30 2021

bakhtiyarneyman added inline comments to D99561: Support visitor pattern by PointerUnion..
Mar 30 2021, 3:57 PM · Restricted Project
bakhtiyarneyman updated the diff for D99561: Support visitor pattern by PointerUnion..

Replaced class with typename in template definition.

Mar 30 2021, 3:56 PM · Restricted Project
bakhtiyarneyman updated the diff for D99560: Utility to construct visitors from lambdas..

Replaced class with typename in template definition.

Mar 30 2021, 3:55 PM · Restricted Project
bakhtiyarneyman added a comment to D99560: Utility to construct visitors from lambdas..

Re: handleAllErrors. Maybe. It might result in better runtime performance (because there is not recursion on the handlers), but it's also a rewrite. I am not sure if you are asking me to do something. :)

Mar 30 2021, 3:45 PM · Restricted Project
bakhtiyarneyman added a comment to D99561: Support visitor pattern by PointerUnion..

Thanks for taking a look, Mehdi and David! PTAL.

Mar 30 2021, 3:36 PM · Restricted Project
bakhtiyarneyman updated the diff for D99561: Support visitor pattern by PointerUnion..

Added a unit test.

Mar 30 2021, 3:25 PM · Restricted Project
bakhtiyarneyman updated the diff for D99560: Utility to construct visitors from lambdas..

Added a unit test.

Mar 30 2021, 3:25 PM · Restricted Project

Mar 29 2021

bakhtiyarneyman added a reviewer for D99560: Utility to construct visitors from lambdas.: mehdi_amini.
Mar 29 2021, 9:17 PM · Restricted Project
bakhtiyarneyman added a reviewer for D99561: Support visitor pattern by PointerUnion.: mehdi_amini.
Mar 29 2021, 9:17 PM · Restricted Project
bakhtiyarneyman requested review of D99561: Support visitor pattern by PointerUnion..
Mar 29 2021, 9:15 PM · Restricted Project
bakhtiyarneyman requested review of D99560: Utility to construct visitors from lambdas..
Mar 29 2021, 9:13 PM · Restricted Project