LGTM. It is working as expected.
Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline
Oct 28 2022
Sep 27 2022
Sep 20 2022
Sep 9 2022
Test added as requested.
Sep 8 2022
Updated with pre-commit test and changes we discussed.
Sep 7 2022
Sep 1 2022
Aug 31 2022
Aug 30 2022
Aug 26 2022
Aug 25 2022
Aug 24 2022
LGTM, you might allow time for others though...
Aug 23 2022
May 17 2022
Jan 11 2022
Nice and its extensible too for future targets under the query function with processor model mapping the family grouping. By and large LGTM. Lets see what folks think...
Dec 18 2021
Looking at recent issues, the test/Bindings/Go failure is intermittent on premerge testing for most changes.
Dec 17 2021
Updated to use getTuneCPU in place of getCPU
Updated as per request, SiFive SubTargets are now guarded and default preferences used otherwise.
Dec 15 2021
The uploaded excel spreadsheet shows the difference between the default unroll preferences and the version presented in this review. The data is collected for Spec2k6 INT base.
Dec 8 2021
The initial checkin was reverted because a lit cfg was missing to exclude non target transform tests of RISCV loop unrolling, should be fixed shortly.
Dec 7 2021
Dec 6 2021
I altered the unrolling preferences for the indicated case, we meet the unroll criteria anyways, as the loop is small at the time of evaluation. Also the abort was motioned to the exit block by the time of the evaluation and so is never encountered as a call in the loop. So I think we are ok for this case.
Alex, we have been using these unrolling preferences in house since mid summer for RISC-V. I will have a look at the outlier case too.
Nov 18 2021
Are there any further concerns? If not can we progress towards approval?
Nov 15 2021
Removed size constraint on initialization of Operands to be consumed in getUserCost.
Updated comments as needed.
Nov 14 2021
Marked tasks as done.
Updated with simplifications and formatting.
Nov 12 2021
Missed an update...
Updated as per feedback.