Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Feed Advanced Search

Advanced Search
Use Results
Hide Query

Oct 28 2022

mcberg2021 accepted D136736: [LSR][TTI][RISCV] Add isAllowDropLSRSolution into TTI and enable it for RISC-V.
Oct 28 2022, 10:48 AM · Restricted Project, Restricted Project
mcberg2021 added a comment to D136736: [LSR][TTI][RISCV] Add isAllowDropLSRSolution into TTI and enable it for RISC-V.

LGTM. It is working as expected.

Oct 28 2022, 10:48 AM · Restricted Project, Restricted Project

Sep 27 2022

mcberg2021 added inline comments to D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer.
Sep 27 2022, 9:26 AM · Restricted Project, Restricted Project, Restricted Project

Sep 20 2022

mcberg2021 committed rG897a79f97004: [DSE] Add value type info checks for masked store candidates in Dead Store… (authored by mcberg2021).
[DSE] Add value type info checks for masked store candidates in Dead Store…
Sep 20 2022, 3:55 PM · Restricted Project, Restricted Project
mcberg2021 closed D132700: [DSE] Add value type checks for masked store candidates in Dead Store Elimination.
Sep 20 2022, 3:54 PM · Restricted Project, Restricted Project

Sep 9 2022

mcberg2021 updated the diff for D132700: [DSE] Add value type checks for masked store candidates in Dead Store Elimination.

Test added as requested.

Sep 9 2022, 3:55 PM · Restricted Project, Restricted Project

Sep 8 2022

mcberg2021 added inline comments to D132700: [DSE] Add value type checks for masked store candidates in Dead Store Elimination.
Sep 8 2022, 1:51 PM · Restricted Project, Restricted Project
mcberg2021 updated the diff for D132700: [DSE] Add value type checks for masked store candidates in Dead Store Elimination.

Updated with pre-commit test and changes we discussed.

Sep 8 2022, 11:15 AM · Restricted Project, Restricted Project

Sep 7 2022

mcberg2021 committed rGba755f79516f: [NFC][DSE] Add a masked dead store test that should rely on additional guards… (authored by mcberg2021).
[NFC][DSE] Add a masked dead store test that should rely on additional guards…
Sep 7 2022, 7:20 PM · Restricted Project, Restricted Project

Sep 1 2022

mcberg2021 added inline comments to D132700: [DSE] Add value type checks for masked store candidates in Dead Store Elimination.
Sep 1 2022, 11:45 AM · Restricted Project, Restricted Project

Aug 31 2022

mcberg2021 added inline comments to D132700: [DSE] Add value type checks for masked store candidates in Dead Store Elimination.
Aug 31 2022, 6:26 PM · Restricted Project, Restricted Project
mcberg2021 added inline comments to D132700: [DSE] Add value type checks for masked store candidates in Dead Store Elimination.
Aug 31 2022, 3:18 PM · Restricted Project, Restricted Project

Aug 30 2022

mcberg2021 added inline comments to D132700: [DSE] Add value type checks for masked store candidates in Dead Store Elimination.
Aug 30 2022, 2:23 PM · Restricted Project, Restricted Project

Aug 26 2022

mcberg2021 added a reviewer for D132700: [DSE] Add value type checks for masked store candidates in Dead Store Elimination: rui.zhang.
Aug 26 2022, 2:42 PM · Restricted Project, Restricted Project

Aug 25 2022

mcberg2021 retitled D132700: [DSE] Add value type checks for masked store candidates in Dead Store Elimination from Add value type checks for masked store candidates in DSE to [DSE] Add value type checks for masked store candidates in Dead Store Elimination.
Aug 25 2022, 8:20 PM · Restricted Project, Restricted Project
mcberg2021 requested review of D132700: [DSE] Add value type checks for masked store candidates in Dead Store Elimination.
Aug 25 2022, 12:53 PM · Restricted Project, Restricted Project

Aug 24 2022

mcberg2021 accepted D132443: [LSR] Fold terminating condition to other IV when possible.

LGTM, you might allow time for others though...

Aug 24 2022, 11:28 AM · Restricted Project, Restricted Project

Aug 23 2022

mcberg2021 added inline comments to D132443: [LSR] Fold terminating condition to other IV when possible.
Aug 23 2022, 7:47 PM · Restricted Project, Restricted Project

May 17 2022

mcberg2021 accepted D125741: [NFC][RISCV] Enable TuneNoDefaultUnroll feature to control targets which use default unroll preference.

LGTM.

May 17 2022, 1:49 PM · Restricted Project, Restricted Project

Jan 11 2022

mcberg2021 accepted D117060: [RISCV] Add RISCVProcFamilyEnum and add SiFive7..

Nice and its extensible too for future targets under the query function with processor model mapping the family grouping. By and large LGTM. Lets see what folks think...

Jan 11 2022, 4:49 PM · Restricted Project

Dec 18 2021

mcberg2021 committed rGf95ee6074aae: [RISCV] Add target specific loop unrolling and peeling preferences (authored by mcberg2021).
[RISCV] Add target specific loop unrolling and peeling preferences
Dec 18 2021, 12:55 PM
mcberg2021 closed D113798: Add loop unrolling and peeling preferences for RISCV.
Dec 18 2021, 12:55 PM · Restricted Project
mcberg2021 added a comment to D113798: Add loop unrolling and peeling preferences for RISCV.

Looking at recent issues, the test/Bindings/Go failure is intermittent on premerge testing for most changes.

Dec 18 2021, 12:54 PM · Restricted Project

Dec 17 2021

mcberg2021 updated the diff for D113798: Add loop unrolling and peeling preferences for RISCV.

Updated to use getTuneCPU in place of getCPU

Dec 17 2021, 6:17 PM · Restricted Project
mcberg2021 updated the diff for D113798: Add loop unrolling and peeling preferences for RISCV.

Updated as per request, SiFive SubTargets are now guarded and default preferences used otherwise.

Dec 17 2021, 5:44 PM · Restricted Project

Dec 15 2021

mcberg2021 added a comment to D113798: Add loop unrolling and peeling preferences for RISCV.

unrolling_pref_rollup.xlsx69 KBDownload

Dec 15 2021, 5:58 PM · Restricted Project
mcberg2021 added a comment to D113798: Add loop unrolling and peeling preferences for RISCV.

The uploaded excel spreadsheet shows the difference between the default unroll preferences and the version presented in this review. The data is collected for Spec2k6 INT base.

Dec 15 2021, 2:12 PM · Restricted Project
mcberg2021 added a comment to D113798: Add loop unrolling and peeling preferences for RISCV.
Dec 15 2021, 2:11 PM · Restricted Project

Dec 8 2021

mcberg2021 added a comment to D113798: Add loop unrolling and peeling preferences for RISCV.

The initial checkin was reverted because a lit cfg was missing to exclude non target transform tests of RISCV loop unrolling, should be fixed shortly.

Dec 8 2021, 12:04 PM · Restricted Project

Dec 7 2021

mcberg2021 added a reverting change for rG8487981a7249: [RISCV] Add target specific loop unrolling and peeling preferences: rG3e363f14e128: Revert "[RISCV] Add target specific loop unrolling and peeling preferences".
Dec 7 2021, 3:14 PM
mcberg2021 committed rG3e363f14e128: Revert "[RISCV] Add target specific loop unrolling and peeling preferences" (authored by mcberg2021).
Revert "[RISCV] Add target specific loop unrolling and peeling preferences"
Dec 7 2021, 3:14 PM
mcberg2021 added a reverting change for D113798: Add loop unrolling and peeling preferences for RISCV: rG3e363f14e128: Revert "[RISCV] Add target specific loop unrolling and peeling preferences".
Dec 7 2021, 3:14 PM · Restricted Project
mcberg2021 committed rG8487981a7249: [RISCV] Add target specific loop unrolling and peeling preferences (authored by mcberg2021).
[RISCV] Add target specific loop unrolling and peeling preferences
Dec 7 2021, 3:08 PM
mcberg2021 closed D113798: Add loop unrolling and peeling preferences for RISCV.
Dec 7 2021, 3:07 PM · Restricted Project

Dec 6 2021

mcberg2021 added a comment to D113798: Add loop unrolling and peeling preferences for RISCV.

I altered the unrolling preferences for the indicated case, we meet the unroll criteria anyways, as the loop is small at the time of evaluation. Also the abort was motioned to the exit block by the time of the evaluation and so is never encountered as a call in the loop. So I think we are ok for this case.

Dec 6 2021, 5:58 PM · Restricted Project
mcberg2021 added a comment to D113798: Add loop unrolling and peeling preferences for RISCV.

Alex, we have been using these unrolling preferences in house since mid summer for RISC-V. I will have a look at the outlier case too.

Dec 6 2021, 12:48 PM · Restricted Project

Nov 18 2021

mcberg2021 added a comment to D113798: Add loop unrolling and peeling preferences for RISCV.

Are there any further concerns? If not can we progress towards approval?

Nov 18 2021, 7:21 PM · Restricted Project

Nov 15 2021

mcberg2021 updated the diff for D113798: Add loop unrolling and peeling preferences for RISCV.
Nov 15 2021, 10:11 AM · Restricted Project
mcberg2021 updated the diff for D113798: Add loop unrolling and peeling preferences for RISCV.

Removed size constraint on initialization of Operands to be consumed in getUserCost.

Nov 15 2021, 9:36 AM · Restricted Project
mcberg2021 updated the diff for D113798: Add loop unrolling and peeling preferences for RISCV.

Updated comments as needed.

Nov 15 2021, 9:19 AM · Restricted Project
mcberg2021 added inline comments to D113798: Add loop unrolling and peeling preferences for RISCV.
Nov 15 2021, 9:10 AM · Restricted Project

Nov 14 2021

mcberg2021 added a reviewer for D113798: Add loop unrolling and peeling preferences for RISCV: jrtc27.
Nov 14 2021, 4:22 PM · Restricted Project
mcberg2021 updated the diff for D113798: Add loop unrolling and peeling preferences for RISCV.

More cleanup

Nov 14 2021, 3:43 PM · Restricted Project
mcberg2021 added a comment to D113798: Add loop unrolling and peeling preferences for RISCV.

Marked tasks as done.

Nov 14 2021, 12:19 PM · Restricted Project
mcberg2021 updated the diff for D113798: Add loop unrolling and peeling preferences for RISCV.

Updated with simplifications and formatting.

Nov 14 2021, 12:18 PM · Restricted Project

Nov 12 2021

mcberg2021 accepted D113805: [RISCV] Improve codegen for i32 udiv/urem by constant on RV64..

LGTM

Nov 12 2021, 2:46 PM · Restricted Project
mcberg2021 added inline comments to D113805: [RISCV] Improve codegen for i32 udiv/urem by constant on RV64..
Nov 12 2021, 2:09 PM · Restricted Project
mcberg2021 updated the diff for D113798: Add loop unrolling and peeling preferences for RISCV.

Missed an update...

Nov 12 2021, 1:49 PM · Restricted Project
mcberg2021 added inline comments to D113798: Add loop unrolling and peeling preferences for RISCV.
Nov 12 2021, 1:46 PM · Restricted Project
mcberg2021 updated the diff for D113798: Add loop unrolling and peeling preferences for RISCV.

Updated as per feedback.

Nov 12 2021, 1:45 PM · Restricted Project
mcberg2021 requested review of D113798: Add loop unrolling and peeling preferences for RISCV.
Nov 12 2021, 12:46 PM · Restricted Project