Page MenuHomePhabricator
Feed Advanced Search

May 9 2019

morehouse closed D61751: [MSan] Introduce __msan_unpoison_param()..
May 9 2019, 2:51 PM · Restricted Project, Restricted Project
morehouse added a parent revision for D61753: [libFuzzer] Unpoison parameters before calling user callback.: D61751: [MSan] Introduce __msan_unpoison_param()..
May 9 2019, 12:30 PM · Restricted Project, Restricted Project
morehouse added a child revision for D61751: [MSan] Introduce __msan_unpoison_param().: D61753: [libFuzzer] Unpoison parameters before calling user callback..
May 9 2019, 12:30 PM · Restricted Project, Restricted Project
morehouse created D61753: [libFuzzer] Unpoison parameters before calling user callback..
May 9 2019, 12:30 PM · Restricted Project, Restricted Project
morehouse created D61751: [MSan] Introduce __msan_unpoison_param()..
May 9 2019, 12:21 PM · Restricted Project, Restricted Project

May 8 2019

morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
May 8 2019, 9:08 AM · Restricted Project, Restricted Project, Restricted Project

May 7 2019

morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
May 7 2019, 4:50 PM · Restricted Project, Restricted Project, Restricted Project

May 6 2019

morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
May 6 2019, 6:22 PM · Restricted Project, Restricted Project, Restricted Project
morehouse accepted D61510: [SanitizerCoverage] Use different module ctor names for trace-pc-guard and inline-8bit-counters.
May 6 2019, 5:29 PM · Restricted Project
morehouse resigned from D43672: [libFuzzer] Adds experimental flag -ngram that changes the fuzzer fitness function.
May 6 2019, 12:07 PM · Restricted Project, Restricted Project
morehouse accepted D61385: [scudo][standalone] Introduce the Quarantine.
May 6 2019, 11:51 AM · Restricted Project, Restricted Project
morehouse accepted D61449: [libFuzzer] Increase timeouts on fork tests and skip one on aarch64.

LGTM

May 6 2019, 11:29 AM · Restricted Project, Restricted Project
morehouse added inline comments to D61385: [scudo][standalone] Introduce the Quarantine.
May 6 2019, 11:00 AM · Restricted Project, Restricted Project

May 2 2019

morehouse accepted D61415: [libFuzzer] Re-enable libFuzzer on i386 Linux and fix test.

LGTM

May 2 2019, 8:56 AM · Restricted Project, Restricted Project

May 1 2019

morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
May 1 2019, 2:21 PM · Restricted Project, Restricted Project, Restricted Project

Apr 30 2019

morehouse accepted D61354: [libFuzzer] Disable i386 on non-Linux platforms.

LGTM.

Apr 30 2019, 5:34 PM · Restricted Project, Restricted Project
morehouse accepted D61070: [libFuzzer] Enable on i386.

LGTM

Apr 30 2019, 9:48 AM · Restricted Project, Restricted Project

Apr 29 2019

morehouse added inline comments to D61070: [libFuzzer] Enable on i386.
Apr 29 2019, 9:48 AM · Restricted Project, Restricted Project

Apr 26 2019

morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 26 2019, 2:46 PM · Restricted Project, Restricted Project, Restricted Project
morehouse added inline comments to D61070: [libFuzzer] Enable on i386.
Apr 26 2019, 11:28 AM · Restricted Project, Restricted Project
morehouse added a comment to D61053: [compiler-rt] Build custom libc++abi without exceptions..

Related to this does anything in libFuzzer uses RTTI? If not we could also consider disabling RTTI to save extra space.

I'll look into this and mail a followup patch if possible.

Apr 26 2019, 10:08 AM · Restricted Project, Restricted Project

Apr 25 2019

morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 25 2019, 6:16 PM · Restricted Project, Restricted Project, Restricted Project
morehouse committed rG1b76063a5e02: [libFuzzer] Disable MSan interceptors in SIGINT handler. (authored by morehouse).
[libFuzzer] Disable MSan interceptors in SIGINT handler.
Apr 25 2019, 5:16 PM
morehouse committed rL359254: [libFuzzer] Disable MSan interceptors in SIGINT handler..
[libFuzzer] Disable MSan interceptors in SIGINT handler.
Apr 25 2019, 5:16 PM
morehouse committed rCRT359254: [libFuzzer] Disable MSan interceptors in SIGINT handler..
[libFuzzer] Disable MSan interceptors in SIGINT handler.
Apr 25 2019, 5:16 PM
morehouse closed D61163: [libFuzzer] Disable MSan interceptors in SIGINT handler..
Apr 25 2019, 5:15 PM · Restricted Project, Restricted Project
morehouse created D61163: [libFuzzer] Disable MSan interceptors in SIGINT handler..
Apr 25 2019, 4:43 PM · Restricted Project, Restricted Project
morehouse committed rGe9640afddd3b: [libFuzzer] Require linux for libcxx.test (authored by morehouse).
[libFuzzer] Require linux for libcxx.test
Apr 25 2019, 11:44 AM
morehouse committed rL359223: [libFuzzer] Require linux for libcxx.test.
[libFuzzer] Require linux for libcxx.test
Apr 25 2019, 11:43 AM
morehouse committed rCRT359223: [libFuzzer] Require linux for libcxx.test.
[libFuzzer] Require linux for libcxx.test
Apr 25 2019, 11:43 AM
morehouse committed rG42ef2c6d06fc: [compiler-rt] Build custom libc++abi without exceptions. (authored by morehouse).
[compiler-rt] Build custom libc++abi without exceptions.
Apr 25 2019, 11:15 AM
morehouse committed rL359218: [compiler-rt] Build custom libc++abi without exceptions..
[compiler-rt] Build custom libc++abi without exceptions.
Apr 25 2019, 11:14 AM
morehouse committed rCRT359218: [compiler-rt] Build custom libc++abi without exceptions..
[compiler-rt] Build custom libc++abi without exceptions.
Apr 25 2019, 11:14 AM
morehouse closed D61053: [compiler-rt] Build custom libc++abi without exceptions..
Apr 25 2019, 11:14 AM · Restricted Project, Restricted Project
morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 25 2019, 8:56 AM · Restricted Project, Restricted Project, Restricted Project

Apr 24 2019

morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 24 2019, 6:18 PM · Restricted Project, Restricted Project, Restricted Project
morehouse updated the diff for D61053: [compiler-rt] Build custom libc++abi without exceptions..
  • Add test.
Apr 24 2019, 10:28 AM · Restricted Project, Restricted Project
morehouse added a reviewer for D61053: [compiler-rt] Build custom libc++abi without exceptions.: kcc.

Related to this does anything in libFuzzer uses RTTI? If not we could also consider disabling RTTI to save extra space.

Apr 24 2019, 10:28 AM · Restricted Project, Restricted Project

Apr 23 2019

morehouse created D61053: [compiler-rt] Build custom libc++abi without exceptions..
Apr 23 2019, 7:06 PM · Restricted Project, Restricted Project
morehouse accepted D60787: [scudo][standalone] Introduce the Secondary allocator.

LGTM

Apr 23 2019, 10:39 AM · Restricted Project, Restricted Project

Apr 22 2019

morehouse added inline comments to D60787: [scudo][standalone] Introduce the Secondary allocator.
Apr 22 2019, 4:24 PM · Restricted Project, Restricted Project
morehouse added inline comments to D60787: [scudo][standalone] Introduce the Secondary allocator.
Apr 22 2019, 12:23 PM · Restricted Project, Restricted Project

Apr 17 2019

morehouse added inline comments to D60787: [scudo][standalone] Introduce the Secondary allocator.
Apr 17 2019, 11:57 AM · Restricted Project, Restricted Project

Apr 16 2019

morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 16 2019, 4:16 PM · Restricted Project, Restricted Project, Restricted Project
morehouse committed rCRT358510: [libFuzzer] Remove tautological compare..
[libFuzzer] Remove tautological compare.
Apr 16 2019, 10:41 AM
morehouse committed rG57213d839ac7: [libFuzzer] Remove tautological compare. (authored by morehouse).
[libFuzzer] Remove tautological compare.
Apr 16 2019, 10:41 AM
morehouse committed rL358510: [libFuzzer] Remove tautological compare..
[libFuzzer] Remove tautological compare.
Apr 16 2019, 10:41 AM

Apr 12 2019

morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 12 2019, 1:45 PM · Restricted Project, Restricted Project, Restricted Project
morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 12 2019, 1:43 PM · Restricted Project, Restricted Project, Restricted Project
morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 12 2019, 12:25 PM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2019

morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 11 2019, 6:04 PM · Restricted Project, Restricted Project, Restricted Project
morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 11 2019, 5:54 PM · Restricted Project, Restricted Project, Restricted Project
morehouse added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 11 2019, 5:51 PM · Restricted Project, Restricted Project, Restricted Project
morehouse committed rGabed4acc2c6c: Revert "tsan: Update test expectations." (authored by morehouse).
Revert "tsan: Update test expectations."
Apr 11 2019, 11:04 AM
morehouse committed rL358202: Revert "tsan: Update test expectations.".
Revert "tsan: Update test expectations."
Apr 11 2019, 11:04 AM
morehouse committed rCRT358202: Revert "tsan: Update test expectations.".
Revert "tsan: Update test expectations."
Apr 11 2019, 11:04 AM

Apr 8 2019

morehouse added a comment to D60237: [MS] Add metadata for __declspec(allocator).

This patch caused the Windows sanitizer bot to break: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/44238

Apr 8 2019, 2:45 PM · Restricted Project, Restricted Project
morehouse accepted D60334: Summary: Add close_fd_mask functionality to AFL driver..

LGTM

Apr 8 2019, 10:59 AM · Restricted Project, Restricted Project
morehouse accepted D60334: Summary: Add close_fd_mask functionality to AFL driver..
Apr 8 2019, 10:47 AM · Restricted Project, Restricted Project
morehouse accepted D59597: [scudo][standalone] Add flags & related parsers.

LGTM after addressing Vitaly's comments.

Apr 8 2019, 10:28 AM · Restricted Project, Restricted Project

Apr 5 2019

morehouse added inline comments to D60334: Summary: Add close_fd_mask functionality to AFL driver..
Apr 5 2019, 4:48 PM · Restricted Project, Restricted Project
morehouse added inline comments to D59597: [scudo][standalone] Add flags & related parsers.
Apr 5 2019, 2:59 PM · Restricted Project, Restricted Project
morehouse committed rG59df934b3a8c: [clang-fuzzer] Include ExternalProject before using it. (authored by morehouse).
[clang-fuzzer] Include ExternalProject before using it.
Apr 5 2019, 12:46 PM
morehouse committed rL357803: [clang-fuzzer] Include ExternalProject before using it..
[clang-fuzzer] Include ExternalProject before using it.
Apr 5 2019, 12:45 PM
morehouse committed rC357803: [clang-fuzzer] Include ExternalProject before using it..
[clang-fuzzer] Include ExternalProject before using it.
Apr 5 2019, 12:45 PM

Apr 4 2019

morehouse accepted D60282: [libFuzzer] Make DataFlow scripts Python3 compatible..

LGTM

Apr 4 2019, 2:07 PM · Restricted Project, Restricted Project

Mar 27 2019

morehouse accepted D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..
Mar 27 2019, 10:21 AM · Restricted Project

Mar 26 2019

morehouse added inline comments to D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options..
Mar 26 2019, 9:37 AM · Restricted Project

Mar 20 2019

morehouse added inline comments to D59597: [scudo][standalone] Add flags & related parsers.
Mar 20 2019, 11:11 AM · Restricted Project, Restricted Project

Mar 19 2019

morehouse accepted D59551: [scudo][standalone] Add error reports.

LGTM

Mar 19 2019, 11:31 AM · Restricted Project, Restricted Project
morehouse added inline comments to D59551: [scudo][standalone] Add error reports.
Mar 19 2019, 11:21 AM · Restricted Project, Restricted Project

Mar 18 2019

morehouse added inline comments to D59262: [scudo][standalone] Add string utility functions.
Mar 18 2019, 12:48 PM · Restricted Project, Restricted Project
morehouse added inline comments to D59262: [scudo][standalone] Add string utility functions.
Mar 18 2019, 12:47 PM · Restricted Project, Restricted Project
morehouse accepted D59262: [scudo][standalone] Add string utility functions.

Still want to know if we need append with a va_list.

Mar 18 2019, 12:15 PM · Restricted Project, Restricted Project

Mar 14 2019

morehouse added inline comments to D59262: [scudo][standalone] Add string utility functions.
Mar 14 2019, 10:12 AM · Restricted Project, Restricted Project

Mar 12 2019

morehouse accepted D57982: [SanitizierCoverage] Avoid splitting critical edges when destination is a basic block containing unreachable.

LGTM

Mar 12 2019, 11:21 AM · Restricted Project

Mar 8 2019

morehouse accepted D59116: [scudo][standalone] Implement checksumming functions.

LGTM

Mar 8 2019, 12:39 PM · Restricted Project, Restricted Project
morehouse added inline comments to D59116: [scudo][standalone] Implement checksumming functions.
Mar 8 2019, 11:52 AM · Restricted Project, Restricted Project

Mar 6 2019

morehouse accepted D59031: [scudo][standalone] Adding a stats class.
Mar 6 2019, 4:33 PM · Restricted Project, Restricted Project

Mar 5 2019

morehouse added inline comments to D57982: [SanitizierCoverage] Avoid splitting critical edges when destination is a basic block containing unreachable.
Mar 5 2019, 2:35 PM · Restricted Project

Mar 4 2019

morehouse accepted D58723: [scudo][standalone] Add bytemap classes.
Mar 4 2019, 1:34 PM · Restricted Project, Restricted Project

Mar 1 2019

morehouse added inline comments to D58723: [scudo][standalone] Add bytemap classes.
Mar 1 2019, 10:02 AM · Restricted Project, Restricted Project
morehouse added inline comments to D58723: [scudo][standalone] Add bytemap classes.
Mar 1 2019, 9:46 AM · Restricted Project, Restricted Project
morehouse added inline comments to D58723: [scudo][standalone] Add bytemap classes.
Mar 1 2019, 9:43 AM · Restricted Project, Restricted Project

Feb 28 2019

morehouse accepted D58740: [sancov] Instrument reachable blocks that end in unreachable.

LGTM

Feb 28 2019, 9:51 AM · Restricted Project

Feb 27 2019

morehouse added inline comments to D58723: [scudo][standalone] Add bytemap classes.
Feb 27 2019, 11:22 AM · Restricted Project, Restricted Project
morehouse added a comment to D57982: [SanitizierCoverage] Avoid splitting critical edges when destination is a basic block containing unreachable.

A block can end in unreachable, but still have reachable code at the beginning. If the block calls a function that is known not to return, the next instruction after the call will be UnreachableInst. For example https://godbolt.org/z/6AGtOf

Feb 27 2019, 10:27 AM · Restricted Project
morehouse added a comment to D57982: [SanitizierCoverage] Avoid splitting critical edges when destination is a basic block containing unreachable.

I don't know all the details of when we might have an UnreachableInst, but I think in general instrumenting blocks that end in unreachable is unhelpful for fuzzing, since we are about to crash anyway (and will therefore be saving the current input whether we "count" the new coverage or not).

Feb 27 2019, 9:58 AM · Restricted Project

Feb 26 2019

morehouse accepted D58674: [libFuzzer] Remove extra semicolons.

LGTM, thanks!

Feb 26 2019, 9:33 AM · Restricted Project, Restricted Project

Feb 25 2019

morehouse accepted D58184: [scudo][standalone] Introduce platform specific code & mutexes.

Linux-specific and common code LGTM. Will let Fuschia people comment on that part.

Feb 25 2019, 10:44 AM · Restricted Project, Restricted Project

Feb 21 2019

morehouse added a reviewer for D58413: [sanitizers] Restore internal_readlink for x32: rnk.

@rnk: Could you help out here? I am clueless with Windows.

Feb 21 2019, 9:49 AM · Restricted Project, Restricted Project
morehouse added inline comments to D58413: [sanitizers] Restore internal_readlink for x32.
Feb 21 2019, 9:08 AM · Restricted Project, Restricted Project
morehouse committed rG9b900dc7deb2: Revert "[sanitizers] Restore internal_readlink for x32" (authored by morehouse).
Revert "[sanitizers] Restore internal_readlink for x32"
Feb 21 2019, 9:07 AM
morehouse committed rCRT354601: Revert "[sanitizers] Restore internal_readlink for x32".
Revert "[sanitizers] Restore internal_readlink for x32"
Feb 21 2019, 9:06 AM
morehouse committed rL354601: Revert "[sanitizers] Restore internal_readlink for x32".
Revert "[sanitizers] Restore internal_readlink for x32"
Feb 21 2019, 9:06 AM

Feb 20 2019

morehouse added inline comments to D58413: [sanitizers] Restore internal_readlink for x32.
Feb 20 2019, 1:51 PM · Restricted Project, Restricted Project

Feb 19 2019

morehouse added inline comments to D58184: [scudo][standalone] Introduce platform specific code & mutexes.
Feb 19 2019, 1:01 PM · Restricted Project, Restricted Project

Feb 15 2019

morehouse added inline comments to D58184: [scudo][standalone] Introduce platform specific code & mutexes.
Feb 15 2019, 4:33 PM · Restricted Project, Restricted Project

Feb 4 2019

morehouse accepted D57633: [SanitizerCoverage] Clang crashes if user declares `__sancov_lowest_stack` variable.

LGTM

Feb 4 2019, 9:03 AM · Restricted Project, Restricted Project

Feb 1 2019

morehouse accepted D57563: [libFuzzer][Windows] Reenable passing tests.

LGTM

Feb 1 2019, 9:46 AM · Restricted Project