Page MenuHomePhabricator
Feed Advanced Search

Tue, Aug 13

morehouse added a reviewer for D66107: [libFuzzer] Improve -merge= process to account for REDUCED corpus units.: kcc.

A few high-level thoughts/questions:

Tue, Aug 13, 3:47 PM · Restricted Project, Restricted Project
morehouse accepted D66112: [scudo][standalone] Add more stats to mallinfo.

LGTM

Tue, Aug 13, 9:46 AM · Restricted Project, Restricted Project

Mon, Aug 12

morehouse accepted D66030: [libFuzzer] Merge: print feature coverage number as well..
Mon, Aug 12, 10:22 AM · Restricted Project, Restricted Project
morehouse added inline comments to D66030: [libFuzzer] Merge: print feature coverage number as well..
Mon, Aug 12, 10:19 AM · Restricted Project, Restricted Project

Thu, Aug 8

morehouse accepted D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
Thu, Aug 8, 12:45 PM · Restricted Project, Restricted Project

Wed, Aug 7

morehouse accepted D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
Wed, Aug 7, 4:14 PM · Restricted Project, Restricted Project

Mon, Aug 5

morehouse accepted D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..

Yep, i failed to convey the problem.
Any code that uses that header will get locked into compiler that provides said header,
unless they resort to bundling said header in the first place, which will be frowned upon.

Mon, Aug 5, 11:29 AM · Restricted Project, Restricted Project

Fri, Aug 2

morehouse accepted D65660: [scudo][standalone] Minor corrections.

LGTM

Fri, Aug 2, 10:10 AM · Restricted Project, Restricted Project

Tue, Jul 23

morehouse accepted D62875: [GWP-ASan] Add public-facing documentation [6]..
Tue, Jul 23, 9:26 AM · Restricted Project, Restricted Project

Mon, Jul 22

morehouse added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Mon, Jul 22, 5:34 PM · Restricted Project, Restricted Project

Jul 19 2019

morehouse accepted D65029: [Driver] Support for disabling sanitizer runtime linking.

LGTM

Jul 19 2019, 5:00 PM · Restricted Project, Restricted Project
morehouse committed rG2272be94f220: [RISCV] Disable tests failing on buildbots. (authored by morehouse).
[RISCV] Disable tests failing on buildbots.
Jul 19 2019, 11:06 AM
morehouse committed rL366599: [RISCV] Disable tests failing on buildbots..
[RISCV] Disable tests failing on buildbots.
Jul 19 2019, 11:06 AM

Jul 16 2019

morehouse added a comment to D63733: [IndVars] Use exit count reasoning to discharge obviously untaken exits.

The assertion assert(!ExitCount->isZero() && "Should have been folded above"); is failing during the unittest build on the UBSan bot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-ubsan/builds/13940

Jul 16 2019, 9:57 AM · Restricted Project

Jul 15 2019

morehouse committed rG8528b1951cc6: [ASan] Fix >80 character line. (authored by morehouse).
[ASan] Fix >80 character line.
Jul 15 2019, 3:10 PM
morehouse committed rL366136: [ASan] Fix >80 character line..
[ASan] Fix >80 character line.
Jul 15 2019, 3:07 PM

Jul 11 2019

morehouse accepted D64587: Use clang driver for libfuzzer tests on Windows.

LGTM

Jul 11 2019, 1:51 PM · Restricted Project, Restricted Project

Jul 9 2019

morehouse accepted D64440: [libFuzzer] Include FuzzedDataProvider.h in the test without "utils" subdir..

LGTM

Jul 9 2019, 12:25 PM · Restricted Project, Restricted Project

Jun 28 2019

morehouse accepted D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang.

LGTM

Jun 28 2019, 11:36 AM · Restricted Project, Restricted Project, Restricted Project

Jun 26 2019

morehouse accepted D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].

LGTM

Jun 26 2019, 11:48 AM · Restricted Project, Restricted Project

Jun 25 2019

morehouse accepted D63783: [scudo] Correct a behavior on the shared TSD registry.

LGTM

Jun 25 2019, 12:06 PM · Restricted Project, Restricted Project

Jun 24 2019

morehouse added a comment to D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang.

Thanks for the patch! Seems like a useful feature for targeted fuzzing.

Jun 24 2019, 2:56 PM · Restricted Project, Restricted Project, Restricted Project
morehouse accepted D63612: [scudo][standalone] Introduce the C & C++ wrappers.
Jun 24 2019, 11:17 AM · Restricted Project, Restricted Project

Jun 18 2019

morehouse accepted D63435: [scudo][standalone] Fuchsia related changes.

LGTM

Jun 18 2019, 10:30 AM · Restricted Project, Restricted Project

Jun 17 2019

morehouse accepted D63348: [libFuzzer] Improve FuzzedDataProvider helper..

LGTM

Jun 17 2019, 6:37 PM · Restricted Project, Restricted Project

Jun 14 2019

morehouse accepted D63231: [scudo][standalone] Introduce the combined allocator.

LGTM

Jun 14 2019, 3:46 PM · Restricted Project, Restricted Project
morehouse added inline comments to D63231: [scudo][standalone] Introduce the combined allocator.
Jun 14 2019, 3:46 PM · Restricted Project, Restricted Project
morehouse accepted D63231: [scudo][standalone] Introduce the combined allocator.
Jun 14 2019, 1:19 PM · Restricted Project, Restricted Project

Jun 11 2019

morehouse accepted D63146: [scudo][standalone] Unmap memory in tests.

LGTM

Jun 11 2019, 10:51 AM · Restricted Project, Restricted Project
morehouse added inline comments to D63146: [scudo][standalone] Unmap memory in tests.
Jun 11 2019, 9:50 AM · Restricted Project, Restricted Project

Jun 10 2019

morehouse accepted D62733: Add FuzzedDataProvider helper class / single header library..
Jun 10 2019, 6:23 PM · Restricted Project, Restricted Project
morehouse added inline comments to D62929: [GWP-ASan] Integration with Scudo [5]..
Jun 10 2019, 10:25 AM · Restricted Project, Restricted Project

Jun 7 2019

morehouse accepted D62258: [scudo][standalone] Introduce the thread specific data structures.
Jun 7 2019, 1:50 PM · Restricted Project, Restricted Project
morehouse added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Jun 7 2019, 1:01 PM · Restricted Project, Restricted Project

Jun 6 2019

morehouse added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Jun 6 2019, 3:39 PM · Restricted Project, Restricted Project
morehouse added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Jun 6 2019, 12:58 PM · Restricted Project, Restricted Project

Jun 4 2019

morehouse accepted D62698: [GWP-ASan] Configuration options [3]..
Jun 4 2019, 9:22 AM · Restricted Project, Restricted Project

May 31 2019

morehouse added inline comments to D62698: [GWP-ASan] Configuration options [3]..
May 31 2019, 4:02 PM · Restricted Project, Restricted Project
morehouse added inline comments to D62698: [GWP-ASan] Configuration options [3]..
May 31 2019, 3:03 PM · Restricted Project, Restricted Project

May 30 2019

morehouse accepted D61923: [GWP-ASan] Mutex implementation [2]..

LGTM

May 30 2019, 11:50 AM · Restricted Project, Restricted Project, Restricted Project

May 29 2019

morehouse added inline comments to D61923: [GWP-ASan] Mutex implementation [2]..
May 29 2019, 6:25 PM · Restricted Project, Restricted Project, Restricted Project
morehouse added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
May 29 2019, 12:54 PM · Restricted Project, Restricted Project
morehouse added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
May 29 2019, 10:41 AM · Restricted Project, Restricted Project

May 23 2019

morehouse added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
May 23 2019, 5:10 PM · Restricted Project, Restricted Project

May 22 2019

morehouse added inline comments to D61923: [GWP-ASan] Mutex implementation [2]..
May 22 2019, 11:20 AM · Restricted Project, Restricted Project, Restricted Project

May 21 2019

morehouse committed rG4d7a6142de7c: [libFuzzer] Sleep after process exits in merge-sigusr.test. (authored by morehouse).
[libFuzzer] Sleep after process exits in merge-sigusr.test.
May 21 2019, 5:40 PM
morehouse committed rL361339: [libFuzzer] Sleep after process exits in merge-sigusr.test..
[libFuzzer] Sleep after process exits in merge-sigusr.test.
May 21 2019, 5:39 PM
morehouse committed rCRT361339: [libFuzzer] Sleep after process exits in merge-sigusr.test..
[libFuzzer] Sleep after process exits in merge-sigusr.test.
May 21 2019, 5:39 PM
morehouse committed rG9e0f6cc3a379: [libFuzzer] Kill by session ID in merge-sigusr.test. (authored by morehouse).
[libFuzzer] Kill by session ID in merge-sigusr.test.
May 21 2019, 4:53 PM
morehouse committed rL361336: [libFuzzer] Kill by session ID in merge-sigusr.test..
[libFuzzer] Kill by session ID in merge-sigusr.test.
May 21 2019, 4:53 PM
morehouse committed rCRT361336: [libFuzzer] Kill by session ID in merge-sigusr.test..
[libFuzzer] Kill by session ID in merge-sigusr.test.
May 21 2019, 4:53 PM
morehouse committed rGdb62d375dc33: [libFuzzer] Ignore exit status of wait in merge-sigusr.test. (authored by morehouse).
[libFuzzer] Ignore exit status of wait in merge-sigusr.test.
May 21 2019, 3:48 PM
morehouse committed rL361326: [libFuzzer] Ignore exit status of wait in merge-sigusr.test..
[libFuzzer] Ignore exit status of wait in merge-sigusr.test.
May 21 2019, 3:48 PM
morehouse committed rCRT361326: [libFuzzer] Ignore exit status of wait in merge-sigusr.test..
[libFuzzer] Ignore exit status of wait in merge-sigusr.test.
May 21 2019, 3:48 PM
morehouse committed rGdf17ddf9fcb7: [libFuzzer] Reduce flakiness of merge-sigusr.test. (authored by morehouse).
[libFuzzer] Reduce flakiness of merge-sigusr.test.
May 21 2019, 2:14 PM
morehouse committed rCRT361313: [libFuzzer] Reduce flakiness of merge-sigusr.test..
[libFuzzer] Reduce flakiness of merge-sigusr.test.
May 21 2019, 2:13 PM
morehouse committed rL361313: [libFuzzer] Reduce flakiness of merge-sigusr.test..
[libFuzzer] Reduce flakiness of merge-sigusr.test.
May 21 2019, 2:13 PM

May 20 2019

morehouse committed rGef7e4d530c1e: [libFuzzer] Disable fork-sigusr.test on AArch64. (authored by morehouse).
[libFuzzer] Disable fork-sigusr.test on AArch64.
May 20 2019, 11:37 AM
morehouse committed rCRT361185: [libFuzzer] Disable fork-sigusr.test on AArch64..
[libFuzzer] Disable fork-sigusr.test on AArch64.
May 20 2019, 11:37 AM
morehouse committed rL361185: [libFuzzer] Disable fork-sigusr.test on AArch64..
[libFuzzer] Disable fork-sigusr.test on AArch64.
May 20 2019, 11:37 AM

May 17 2019

morehouse committed rG2fd318e54334: [libFuzzer] Dump input on failure for sigusr tests. (authored by morehouse).
[libFuzzer] Dump input on failure for sigusr tests.
May 17 2019, 12:34 PM
morehouse committed rL361070: [libFuzzer] Dump input on failure for sigusr tests..
[libFuzzer] Dump input on failure for sigusr tests.
May 17 2019, 12:34 PM
morehouse committed rCRT361070: [libFuzzer] Dump input on failure for sigusr tests..
[libFuzzer] Dump input on failure for sigusr tests.
May 17 2019, 12:34 PM
morehouse accepted D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.

LGTM

May 17 2019, 12:18 PM · Restricted Project, Restricted Project
morehouse committed rG012ef1cca7d8: [libFuzzer] Use SleepOneSecondTest.cpp for fork-sigusr.test. (authored by morehouse).
[libFuzzer] Use SleepOneSecondTest.cpp for fork-sigusr.test.
May 17 2019, 9:56 AM
morehouse committed rCRT361048: [libFuzzer] Use SleepOneSecondTest.cpp for fork-sigusr.test..
[libFuzzer] Use SleepOneSecondTest.cpp for fork-sigusr.test.
May 17 2019, 9:55 AM
morehouse committed rL361048: [libFuzzer] Use SleepOneSecondTest.cpp for fork-sigusr.test..
[libFuzzer] Use SleepOneSecondTest.cpp for fork-sigusr.test.
May 17 2019, 9:55 AM

May 16 2019

morehouse accepted D62048: [GWP-ASan] Fixed issue with c++ standard library dependency..
May 16 2019, 5:58 PM · Restricted Project, Restricted Project
morehouse added inline comments to D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.
May 16 2019, 5:03 PM · Restricted Project, Restricted Project
morehouse added a reviewer for D62039: [GWP-ASan] Add missing dependency on C++ headers: hctim.

Seems reasonable to me if we're fine with using libc++. Mitch, did you intend to introduce the libc++ dependency include <ctime> here?

May 16 2019, 3:43 PM · Restricted Project, Restricted Project
morehouse committed rG8779b74db106: [libFuzzer] Disable merge-sigusr.test on linux. (authored by morehouse).
[libFuzzer] Disable merge-sigusr.test on linux.
May 16 2019, 9:41 AM
morehouse committed rCRT360914: [libFuzzer] Disable merge-sigusr.test on linux..
[libFuzzer] Disable merge-sigusr.test on linux.
May 16 2019, 9:40 AM
morehouse committed rL360914: [libFuzzer] Disable merge-sigusr.test on linux..
[libFuzzer] Disable merge-sigusr.test on linux.
May 16 2019, 9:40 AM

May 15 2019

morehouse committed rGf2669eebd554: [libFuzzer] Increase merge-sigusr sleep after sending signal. (authored by morehouse).
[libFuzzer] Increase merge-sigusr sleep after sending signal.
May 15 2019, 8:59 PM
morehouse committed rL360848: [libFuzzer] Increase merge-sigusr sleep after sending signal..
[libFuzzer] Increase merge-sigusr sleep after sending signal.
May 15 2019, 8:58 PM
morehouse committed rCRT360848: [libFuzzer] Increase merge-sigusr sleep after sending signal..
[libFuzzer] Increase merge-sigusr sleep after sending signal.
May 15 2019, 8:58 PM
morehouse committed rGd5529629fb18: [libFuzzer] Also kill parent process in merge-siguser.test. (authored by morehouse).
[libFuzzer] Also kill parent process in merge-siguser.test.
May 15 2019, 8:03 PM
morehouse committed rL360840: [libFuzzer] Also kill parent process in merge-siguser.test..
[libFuzzer] Also kill parent process in merge-siguser.test.
May 15 2019, 8:02 PM
morehouse committed rCRT360840: [libFuzzer] Also kill parent process in merge-siguser.test..
[libFuzzer] Also kill parent process in merge-siguser.test.
May 15 2019, 8:02 PM
morehouse committed rGf9d382946f9c: [libFuzzer] Fix typo in merge-sigusr.test. (authored by morehouse).
[libFuzzer] Fix typo in merge-sigusr.test.
May 15 2019, 6:54 PM
morehouse committed rL360836: [libFuzzer] Fix typo in merge-sigusr.test..
[libFuzzer] Fix typo in merge-sigusr.test.
May 15 2019, 6:53 PM
morehouse committed rCRT360836: [libFuzzer] Fix typo in merge-sigusr.test..
[libFuzzer] Fix typo in merge-sigusr.test.
May 15 2019, 6:53 PM
morehouse committed rGab10de8bab27: [libFuzzer] Use PID to send signals rather than process name. (authored by morehouse).
[libFuzzer] Use PID to send signals rather than process name.
May 15 2019, 6:31 PM
morehouse committed rL360835: [libFuzzer] Use PID to send signals rather than process name..
[libFuzzer] Use PID to send signals rather than process name.
May 15 2019, 6:31 PM
morehouse committed rCRT360835: [libFuzzer] Use PID to send signals rather than process name..
[libFuzzer] Use PID to send signals rather than process name.
May 15 2019, 6:31 PM
morehouse committed rGa05ffdbfc7e2: [libFuzzer] Echo fuzzer output on sigusr tests. (authored by morehouse).
[libFuzzer] Echo fuzzer output on sigusr tests.
May 15 2019, 3:25 PM
morehouse committed rCRT360824: [libFuzzer] Echo fuzzer output on sigusr tests..
[libFuzzer] Echo fuzzer output on sigusr tests.
May 15 2019, 3:25 PM
morehouse committed rL360824: [libFuzzer] Echo fuzzer output on sigusr tests..
[libFuzzer] Echo fuzzer output on sigusr tests.
May 15 2019, 3:25 PM

May 14 2019

morehouse accepted D61867: [GWP-ASan] Initial build files, implementation of PRNG [1]..
May 14 2019, 2:02 PM · Restricted Project, Restricted Project
morehouse added inline comments to D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.
May 14 2019, 12:05 PM · Restricted Project, Restricted Project
morehouse added inline comments to D61867: [GWP-ASan] Initial build files, implementation of PRNG [1]..
May 14 2019, 10:30 AM · Restricted Project, Restricted Project

May 13 2019

morehouse added inline comments to D61867: [GWP-ASan] Initial build files, implementation of PRNG [1]..
May 13 2019, 12:09 PM · Restricted Project, Restricted Project

May 10 2019

morehouse added a comment to D60593: [GwpAsan] Introduce GWP-ASan..

This diff is helpful to get an overall idea of how things fit together, but it is very difficult to review thoroughly. Let's start splicing off pieces for individual review.

May 10 2019, 3:58 PM · Restricted Project, Restricted Project, Restricted Project

May 9 2019

morehouse committed rG3478494c1fdc: [libFuzzer] Unpoison parameters before calling user callback. (authored by morehouse).
[libFuzzer] Unpoison parameters before calling user callback.
May 9 2019, 3:51 PM
morehouse committed rL360390: [libFuzzer] Unpoison parameters before calling user callback..
[libFuzzer] Unpoison parameters before calling user callback.
May 9 2019, 3:46 PM
morehouse committed rCRT360390: [libFuzzer] Unpoison parameters before calling user callback..
[libFuzzer] Unpoison parameters before calling user callback.
May 9 2019, 3:46 PM
morehouse closed D61753: [libFuzzer] Unpoison parameters before calling user callback..
May 9 2019, 3:46 PM · Restricted Project, Restricted Project
morehouse committed rGa612b5adb7a6: [MSan] Introduce __msan_unpoison_param(). (authored by morehouse).
[MSan] Introduce __msan_unpoison_param().
May 9 2019, 2:52 PM
morehouse committed rL360379: [MSan] Introduce __msan_unpoison_param()..
[MSan] Introduce __msan_unpoison_param().
May 9 2019, 2:52 PM
morehouse committed rCRT360379: [MSan] Introduce __msan_unpoison_param()..
[MSan] Introduce __msan_unpoison_param().
May 9 2019, 2:52 PM