Page MenuHomePhabricator
Feed Advanced Search

Mon, Jul 6

morehouse added inline comments to D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..
Mon, Jul 6, 9:40 AM · Restricted Project

Wed, Jul 1

morehouse added inline comments to D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..
Wed, Jul 1, 5:18 PM · Restricted Project
morehouse added a comment to D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage).

So - the FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION flag is a property of the build system and not that of the compiler. There are some places (android) where enabling FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION globally changes the behaviour of large amounts of libraries in ways that break the build system.

Having this flag allows us to make targeted compile-time changes to libc based on sancov that don't require enabling FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION across the entire build system.

Wed, Jul 1, 10:48 AM · Restricted Project
morehouse added a comment to D82897: [Sanitizers] Implement interceptors for msgsnd, msgrcv.

This is causing lint errors: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/32793

Wed, Jul 1, 10:16 AM · Restricted Project
morehouse added a comment to D80330: [BitcodeReader] Fix DelayedShuffle handling for ConstantExpr shuffles..

Still memory leaks: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/43341

Wed, Jul 1, 10:15 AM · Restricted Project

Tue, Jun 30

morehouse added a comment to D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage).

Can we just use FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION instead? I'm a little wary of introducing a new way to do conditional compilation since fuzzers that don't use sancov can't rely on it.

Tue, Jun 30, 5:23 PM · Restricted Project

Mon, Jun 29

morehouse added inline comments to D82685: [libFuzzer] Rewrite Linux's ExecuteCommand to use fork-exec instead of system()..
Mon, Jun 29, 10:48 AM · Restricted Project

May 21 2020

morehouse accepted D80397: SimplifyCFG: Clean up optforfuzzing implementation.
May 21 2020, 3:11 PM · Restricted Project
morehouse committed rG353e5aa42dfe: [libFuzzer] Fix leak in unit test. (authored by morehouse).
[libFuzzer] Fix leak in unit test.
May 21 2020, 9:09 AM

May 20 2020

morehouse committed rG8817e6ab31e4: [sanitizer_symbolizer] Add __isinf to symbols list. (authored by morehouse).
[sanitizer_symbolizer] Add __isinf to symbols list.
May 20 2020, 1:11 PM

May 19 2020

morehouse added a comment to D79269: [NativeSession] Implement NativeSession::findSymbolByAddress..

@morehouse Do you happen to know what would cause undefined symbols to be added? I reproduced it and it seems like it started from implementing loadDataForEXE (in https://reviews.llvm.org/D78128)

May 19 2020, 5:39 PM · Restricted Project
morehouse committed rGe2e38fca64e4: Entropic: Boosting LibFuzzer Performance (authored by morehouse).
Entropic: Boosting LibFuzzer Performance
May 19 2020, 10:56 AM
morehouse closed D73776: Entropic: Boosting LibFuzzer Performance.
May 19 2020, 10:56 AM · Restricted Project, Restricted Project

May 18 2020

morehouse added a comment to D79269: [NativeSession] Implement NativeSession::findSymbolByAddress..

It looks like this patch added a bunch of undefined symbols to the sanitizer symbolizer, and is causing the buildbot to fail:

May 18 2020, 10:47 AM · Restricted Project

May 4 2020

morehouse accepted D79307: [llvm][dfsan][NFC] Factor out fcn initialization.

LGTM

May 4 2020, 8:32 AM · Restricted Project

Apr 30 2020

morehouse accepted D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified.

LGTM

Apr 30 2020, 9:35 AM · Restricted Project, Restricted Project
morehouse added inline comments to D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified.
Apr 30 2020, 8:29 AM · Restricted Project, Restricted Project

Apr 29 2020

morehouse added inline comments to D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified.
Apr 29 2020, 5:17 PM · Restricted Project, Restricted Project
morehouse added a comment to D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified.

Are you sure you want the remote build to succeed without the CFI system blacklist?

Apr 29 2020, 1:27 PM · Restricted Project, Restricted Project

Apr 20 2020

morehouse committed rGe5ce95c660ae: [dfsan] Fix a bug in strcasecmp() and strncasecmp(): Compare the lowercase… (authored by skerner).
[dfsan] Fix a bug in strcasecmp() and strncasecmp(): Compare the lowercase…
Apr 20 2020, 5:23 PM
morehouse closed D78490: [dfsan] Fix a bug in strcasecmp() and strncasecmp(): Compare the lowercase versions of the characters when choosing a return value..
Apr 20 2020, 5:22 PM · Restricted Project
morehouse accepted D78490: [dfsan] Fix a bug in strcasecmp() and strncasecmp(): Compare the lowercase versions of the characters when choosing a return value..

LGTM

Apr 20 2020, 5:22 PM · Restricted Project
morehouse requested changes to D78490: [dfsan] Fix a bug in strcasecmp() and strncasecmp(): Compare the lowercase versions of the characters when choosing a return value..

Looks like the diff lost the actual fix. Please add it back and I'll merge.

Apr 20 2020, 3:12 PM · Restricted Project
morehouse accepted D78490: [dfsan] Fix a bug in strcasecmp() and strncasecmp(): Compare the lowercase versions of the characters when choosing a return value..
Apr 20 2020, 9:10 AM · Restricted Project

Apr 17 2020

morehouse accepted D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER.
Apr 17 2020, 5:31 PM · Restricted Project, Restricted Project
morehouse added inline comments to D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER.
Apr 17 2020, 12:26 PM · Restricted Project, Restricted Project

Apr 15 2020

morehouse committed rG10070e31a55c: Fix DataFlowSanitizer implementation of strchr() so that strchr(..., '\0')… (authored by skerner).
Fix DataFlowSanitizer implementation of strchr() so that strchr(..., '\0')…
Apr 15 2020, 1:16 PM
morehouse closed D77996: Fix DataFlowSanitizer implementation of strchr() so that strchr(..., '\0') returns a pointer to '\0'..
Apr 15 2020, 1:15 PM · Restricted Project
morehouse accepted D77996: Fix DataFlowSanitizer implementation of strchr() so that strchr(..., '\0') returns a pointer to '\0'..

LGTM

Apr 15 2020, 1:13 PM · Restricted Project

Apr 13 2020

morehouse committed rG6cdcb9b4024b: [SanCov] Disable whitelist/blacklist test on Darwin. (authored by morehouse).
[SanCov] Disable whitelist/blacklist test on Darwin.
Apr 13 2020, 11:20 AM
morehouse added inline comments to D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.
Apr 13 2020, 8:34 AM · Restricted Project

Apr 10 2020

morehouse committed rGbef187c75090: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist`… (authored by morehouse).
Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist`…
Apr 10 2020, 10:45 AM
morehouse closed D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang.
Apr 10 2020, 10:45 AM · Restricted Project, Restricted Project, Restricted Project
morehouse accepted D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang.

LGTM

Apr 10 2020, 10:41 AM · Restricted Project, Restricted Project, Restricted Project

Apr 9 2020

morehouse requested changes to D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang.

Am I missing an additional step for test integration, after adding the test file?

Apr 9 2020, 3:48 PM · Restricted Project, Restricted Project, Restricted Project
morehouse accepted D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang.

Thanks again for the patch. Sorry about the delay in landing it; I'll work on it today.

Apr 9 2020, 12:42 PM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2020

morehouse committed rGec69bac14443: [sanitizer_common] Update global_symbols.txt. (authored by morehouse).
[sanitizer_common] Update global_symbols.txt.
Apr 6 2020, 10:20 AM
morehouse committed rGd0498faeae08: Revert "[sanitizer_common] Show new unexpected symbols." (authored by morehouse).
Revert "[sanitizer_common] Show new unexpected symbols."
Apr 6 2020, 10:20 AM
morehouse added a reverting change for rG68d73dfa1a42: [sanitizer_common] Show new unexpected symbols.: rGd0498faeae08: Revert "[sanitizer_common] Show new unexpected symbols.".
Apr 6 2020, 10:20 AM
morehouse committed rG7bea22d36ff7: Revert "[sanitizer_common] Update global_symbols.txt." (authored by morehouse).
Revert "[sanitizer_common] Update global_symbols.txt."
Apr 6 2020, 10:20 AM
morehouse added a reverting change for rG98bb7fdbe586: [sanitizer_common] Update global_symbols.txt.: rG7bea22d36ff7: Revert "[sanitizer_common] Update global_symbols.txt.".
Apr 6 2020, 10:20 AM
morehouse committed rG98bb7fdbe586: [sanitizer_common] Update global_symbols.txt. (authored by morehouse).
[sanitizer_common] Update global_symbols.txt.
Apr 6 2020, 9:46 AM
morehouse committed rG68d73dfa1a42: [sanitizer_common] Show new unexpected symbols. (authored by morehouse).
[sanitizer_common] Show new unexpected symbols.
Apr 6 2020, 9:46 AM

Mar 9 2020

morehouse committed rGd93303b783be: [ASan] Enable set_shadow_test.c on Windows. (authored by morehouse).
[ASan] Enable set_shadow_test.c on Windows.
Mar 9 2020, 4:13 PM

Mar 5 2020

morehouse accepted D75693: [GWP-ASan] Fix thread ID..

LGTM

Mar 5 2020, 10:22 AM · Restricted Project, Restricted Project

Feb 28 2020

morehouse committed rG30bb737a757e: [DFSan] Add __dfsan_cmp_callback. (authored by morehouse).
[DFSan] Add __dfsan_cmp_callback.
Feb 28 2020, 3:58 PM
morehouse closed D75389: [DFSan] Add __dfsan_cmp_callback..
Feb 28 2020, 3:57 PM · Restricted Project, Restricted Project
morehouse committed rGf668baa45926: [DFSan] Add __dfsan_mem_transfer_callback. (authored by morehouse).
[DFSan] Add __dfsan_mem_transfer_callback.
Feb 28 2020, 3:49 PM
morehouse closed D75386: [DFSan] Add __dfsan_mem_transfer_callback..
Feb 28 2020, 3:49 PM · Restricted Project, Restricted Project
morehouse created D75389: [DFSan] Add __dfsan_cmp_callback..
Feb 28 2020, 3:30 PM · Restricted Project, Restricted Project
morehouse added a parent revision for D75389: [DFSan] Add __dfsan_cmp_callback.: D75386: [DFSan] Add __dfsan_mem_transfer_callback..
Feb 28 2020, 3:30 PM · Restricted Project, Restricted Project
morehouse added a child revision for D75386: [DFSan] Add __dfsan_mem_transfer_callback.: D75389: [DFSan] Add __dfsan_cmp_callback..
Feb 28 2020, 3:30 PM · Restricted Project, Restricted Project
morehouse committed rG52f889abecc7: [DFSan] Add __dfsan_load_callback. (authored by morehouse).
[DFSan] Add __dfsan_load_callback.
Feb 28 2020, 2:27 PM
morehouse closed D75363: [DFSan] Add __dfsan_load_callback..
Feb 28 2020, 2:27 PM · Restricted Project, Restricted Project
morehouse added reviewers for D75386: [DFSan] Add __dfsan_mem_transfer_callback.: vitalybuka, kcc, pcc.
Feb 28 2020, 2:09 PM · Restricted Project, Restricted Project
morehouse added a child revision for D75363: [DFSan] Add __dfsan_load_callback.: D75386: [DFSan] Add __dfsan_mem_transfer_callback..
Feb 28 2020, 2:09 PM · Restricted Project, Restricted Project
morehouse added a parent revision for D75386: [DFSan] Add __dfsan_mem_transfer_callback.: D75363: [DFSan] Add __dfsan_load_callback..
Feb 28 2020, 2:09 PM · Restricted Project, Restricted Project
morehouse created D75386: [DFSan] Add __dfsan_mem_transfer_callback..
Feb 28 2020, 2:09 PM · Restricted Project, Restricted Project
morehouse created D75363: [DFSan] Add __dfsan_load_callback..
Feb 28 2020, 9:19 AM · Restricted Project, Restricted Project

Feb 27 2020

morehouse committed rG470db54cbdf1: [DFSan] Add flag to insert event callbacks. (authored by morehouse).
[DFSan] Add flag to insert event callbacks.
Feb 27 2020, 5:15 PM
morehouse closed D75312: [DFSan] Add flag to insert event callbacks..
Feb 27 2020, 5:14 PM · Restricted Project, Restricted Project
morehouse updated the diff for D75312: [DFSan] Add flag to insert event callbacks..
  • Fix diffbase.
Feb 27 2020, 5:14 PM · Restricted Project, Restricted Project
morehouse updated the diff for D75312: [DFSan] Add flag to insert event callbacks..
  • Add comment explaining the new flag.
Feb 27 2020, 5:14 PM · Restricted Project, Restricted Project
morehouse abandoned D75321: Add comment explaining the new flag..
Feb 27 2020, 5:14 PM · Restricted Project
morehouse added a comment to D75312: [DFSan] Add flag to insert event callbacks..

Do you want to also pass the store address to the callback?

Feb 27 2020, 5:05 PM · Restricted Project, Restricted Project
morehouse created D75321: Add comment explaining the new flag..
Feb 27 2020, 5:05 PM · Restricted Project
morehouse updated subscribers of D75312: [DFSan] Add flag to insert event callbacks..
Feb 27 2020, 4:38 PM · Restricted Project, Restricted Project
morehouse committed rG2a29617b9d15: [DFSan] Remove unused IRBuilder. NFC (authored by morehouse).
[DFSan] Remove unused IRBuilder. NFC
Feb 27 2020, 4:29 PM
morehouse closed D75190: [DFSan] Remove unused IRBuilder. NFC.
Feb 27 2020, 4:29 PM · Restricted Project
morehouse created D75312: [DFSan] Add flag to insert event callbacks..
Feb 27 2020, 4:20 PM · Restricted Project, Restricted Project

Feb 26 2020

morehouse created D75190: [DFSan] Remove unused IRBuilder. NFC.
Feb 26 2020, 8:51 AM · Restricted Project

Feb 12 2020

morehouse accepted D74364: [GWP-ASan] Update alignment on Android..
Feb 12 2020, 3:18 PM · Restricted Project, Restricted Project
morehouse added inline comments to D74364: [GWP-ASan] Update alignment on Android..
Feb 12 2020, 11:10 AM · Restricted Project, Restricted Project
morehouse added inline comments to D74364: [GWP-ASan] Update alignment on Android..
Feb 12 2020, 11:01 AM · Restricted Project, Restricted Project

Feb 10 2020

morehouse added a comment to D74364: [GWP-ASan] Update alignment on Android..

Does Bionic's malloc have the required alignment information available at the call to gwp_asan::allocate? If so, we could get tighter right alignment by adding an alignment parameter (instead of conservative 16-byte rounding). This is the approach used in both Chrome and TCMalloc.

Feb 10 2020, 5:54 PM · Restricted Project, Restricted Project

Oct 31 2019

morehouse accepted D69675: [scudo][standalone] Fix Secondary bug w/ freelist.
Oct 31 2019, 11:56 AM · Restricted Project, Restricted Project
morehouse added inline comments to D69675: [scudo][standalone] Fix Secondary bug w/ freelist.
Oct 31 2019, 11:38 AM · Restricted Project, Restricted Project

Oct 30 2019

morehouse committed rG7904bd9409b8: [sanitizer_common] Create max_allocation_size_mb flag. (authored by morehouse).
[sanitizer_common] Create max_allocation_size_mb flag.
Oct 30 2019, 11:32 AM
morehouse closed D69576: [sanitizer_common] Create max_allocation_size_mb flag..
Oct 30 2019, 11:31 AM · Restricted Project, Restricted Project

Oct 29 2019

morehouse accepted D69570: [scudo][standalone] Add a free list to the Secondary.
Oct 29 2019, 6:29 PM · Restricted Project, Restricted Project
morehouse added inline comments to D69576: [sanitizer_common] Create max_allocation_size_mb flag..
Oct 29 2019, 12:49 PM · Restricted Project, Restricted Project
morehouse created D69576: [sanitizer_common] Create max_allocation_size_mb flag..
Oct 29 2019, 11:23 AM · Restricted Project, Restricted Project

Oct 25 2019

morehouse committed rGa88591cff466: [libFuzzer] Enable extra counters for Fuchsia. (authored by morehouse).
[libFuzzer] Enable extra counters for Fuchsia.
Oct 25 2019, 4:20 PM

Oct 22 2019

morehouse added a comment to D69196: Fix lld detection in standalone compiler-rt..

This appears to have broken the standalone compiler-rt build: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/23986

Oct 22 2019, 11:43 AM · Restricted Project, Restricted Project

Oct 21 2019

morehouse accepted D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.

LGTM

Oct 21 2019, 10:27 AM · Restricted Project

Oct 18 2019

morehouse added inline comments to D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.
Oct 18 2019, 4:32 PM · Restricted Project

Oct 10 2019

morehouse committed rL374493: Add morehouse..
Add morehouse.
Oct 10 2019, 6:08 PM

Oct 9 2019

morehouse committed rGda6cb7ba4c73: [sanitizer_common] Remove OnPrint from Go build. (authored by morehouse).
[sanitizer_common] Remove OnPrint from Go build.
Oct 9 2019, 4:03 PM
morehouse committed rL374258: [sanitizer_common] Remove OnPrint from Go build..
[sanitizer_common] Remove OnPrint from Go build.
Oct 9 2019, 4:03 PM
morehouse closed D68621: [sanitizer_common] Remove OnPrint from Go build..
Oct 9 2019, 4:03 PM · Restricted Project, Restricted Project

Oct 8 2019

morehouse accepted D68653: [scudo][standalone] Get statistics in a char buffer.
Oct 8 2019, 6:37 PM · Restricted Project, Restricted Project

Oct 7 2019

morehouse created D68621: [sanitizer_common] Remove OnPrint from Go build..
Oct 7 2019, 6:28 PM · Restricted Project, Restricted Project

Oct 4 2019

morehouse accepted D68471: [scudo][standalone] Correct releaseToOS behavior.
Oct 4 2019, 4:28 PM · Restricted Project, Restricted Project
morehouse added inline comments to D68471: [scudo][standalone] Correct releaseToOS behavior.
Oct 4 2019, 3:28 PM · Restricted Project, Restricted Project

Oct 3 2019

morehouse accepted D68427: [scudo][standalone] Make malloc_info return a minimal XML.
Oct 3 2019, 3:24 PM · Restricted Project, Restricted Project

Oct 2 2019

morehouse committed rG629cad1266bd: Move SanitizerInitializeUnwinder outside anonymous namespace. (authored by morehouse).
Move SanitizerInitializeUnwinder outside anonymous namespace.
Oct 2 2019, 3:57 PM
morehouse committed rL373539: Move SanitizerInitializeUnwinder outside anonymous namespace..
Move SanitizerInitializeUnwinder outside anonymous namespace.
Oct 2 2019, 3:55 PM
morehouse committed rG4d39410b1e08: [sanitizer_common] Declare __sanitizer_on_print in Windows interception. (authored by morehouse).
[sanitizer_common] Declare __sanitizer_on_print in Windows interception.
Oct 2 2019, 3:00 PM
morehouse committed rL373532: [sanitizer_common] Declare __sanitizer_on_print in Windows interception..
[sanitizer_common] Declare __sanitizer_on_print in Windows interception.
Oct 2 2019, 2:58 PM
morehouse committed rG38ac6bdb83a9: [sanitizer_common] Disable onprint.cpp on Android. (authored by morehouse).
[sanitizer_common] Disable onprint.cpp on Android.
Oct 2 2019, 2:43 PM