Page MenuHomePhabricator
Feed Advanced Search

Yesterday

morehouse added inline comments to D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.
Fri, Oct 18, 4:32 PM · Restricted Project

Thu, Oct 10

morehouse committed rL374493: Add morehouse..
Add morehouse.
Thu, Oct 10, 6:08 PM

Wed, Oct 9

morehouse committed rGda6cb7ba4c73: [sanitizer_common] Remove OnPrint from Go build. (authored by morehouse).
[sanitizer_common] Remove OnPrint from Go build.
Wed, Oct 9, 4:03 PM
morehouse committed rL374258: [sanitizer_common] Remove OnPrint from Go build..
[sanitizer_common] Remove OnPrint from Go build.
Wed, Oct 9, 4:03 PM
morehouse closed D68621: [sanitizer_common] Remove OnPrint from Go build..
Wed, Oct 9, 4:03 PM · Restricted Project, Restricted Project

Tue, Oct 8

morehouse accepted D68653: [scudo][standalone] Get statistics in a char buffer.
Tue, Oct 8, 6:37 PM · Restricted Project, Restricted Project

Mon, Oct 7

morehouse created D68621: [sanitizer_common] Remove OnPrint from Go build..
Mon, Oct 7, 6:28 PM · Restricted Project, Restricted Project

Fri, Oct 4

morehouse accepted D68471: [scudo][standalone] Correct releaseToOS behavior.
Fri, Oct 4, 4:28 PM · Restricted Project, Restricted Project
morehouse added inline comments to D68471: [scudo][standalone] Correct releaseToOS behavior.
Fri, Oct 4, 3:28 PM · Restricted Project, Restricted Project

Thu, Oct 3

morehouse accepted D68427: [scudo][standalone] Make malloc_info return a minimal XML.
Thu, Oct 3, 3:24 PM · Restricted Project, Restricted Project

Wed, Oct 2

morehouse committed rG629cad1266bd: Move SanitizerInitializeUnwinder outside anonymous namespace. (authored by morehouse).
Move SanitizerInitializeUnwinder outside anonymous namespace.
Wed, Oct 2, 3:57 PM
morehouse committed rL373539: Move SanitizerInitializeUnwinder outside anonymous namespace..
Move SanitizerInitializeUnwinder outside anonymous namespace.
Wed, Oct 2, 3:55 PM
morehouse committed rG4d39410b1e08: [sanitizer_common] Declare __sanitizer_on_print in Windows interception. (authored by morehouse).
[sanitizer_common] Declare __sanitizer_on_print in Windows interception.
Wed, Oct 2, 3:00 PM
morehouse committed rL373532: [sanitizer_common] Declare __sanitizer_on_print in Windows interception..
[sanitizer_common] Declare __sanitizer_on_print in Windows interception.
Wed, Oct 2, 2:58 PM
morehouse committed rG38ac6bdb83a9: [sanitizer_common] Disable onprint.cpp on Android. (authored by morehouse).
[sanitizer_common] Disable onprint.cpp on Android.
Wed, Oct 2, 2:43 PM
morehouse committed rL373531: [sanitizer_common] Disable onprint.cpp on Android..
[sanitizer_common] Disable onprint.cpp on Android.
Wed, Oct 2, 2:43 PM
morehouse committed rG62f190ce9a86: [sanitizer_common] Add __sanitizer_on_print to interface list. (authored by morehouse).
[sanitizer_common] Add __sanitizer_on_print to interface list.
Wed, Oct 2, 2:25 PM
morehouse committed rL373530: [sanitizer_common] Add __sanitizer_on_print to interface list..
[sanitizer_common] Add __sanitizer_on_print to interface list.
Wed, Oct 2, 2:24 PM
morehouse committed rGe55c442b1b65: [sanitizer_common] Rename OnPrint to __sanitizer_on_print. (authored by morehouse).
[sanitizer_common] Rename OnPrint to __sanitizer_on_print.
Wed, Oct 2, 1:13 PM
morehouse committed rL373518: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..
[sanitizer_common] Rename OnPrint to __sanitizer_on_print.
Wed, Oct 2, 1:11 PM
morehouse closed D67987: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..
Wed, Oct 2, 1:11 PM · Restricted Project

Tue, Oct 1

morehouse committed rG1c8e05110c01: [libFuzzer] Remove lazy counters. (authored by morehouse).
[libFuzzer] Remove lazy counters.
Tue, Oct 1, 3:49 PM
morehouse committed rL373403: [libFuzzer] Remove lazy counters..
[libFuzzer] Remove lazy counters.
Tue, Oct 1, 3:48 PM
morehouse closed D67476: [libFuzzer] Remove lazy counters..
Tue, Oct 1, 3:48 PM · Restricted Project
morehouse added a comment to D67987: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..

For the Go version we have a non-weak declaration without definition. How are we going to roll out the change? We would need to update llvm and the hook implementation atomically. But then I am confused how it works today. We have a non-extern "C" hook definition, so build should be broken for the last year...

Tue, Oct 1, 1:12 PM · Restricted Project
morehouse updated the diff for D67987: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..
  • Keep Go's OnPrint declaration for now.
Tue, Oct 1, 1:07 PM · Restricted Project

Fri, Sep 27

morehouse accepted D68067: [libFuzzer] Dump trace and provide correct msg for overwritten input..

LGTM

Fri, Sep 27, 2:45 PM · Restricted Project, Restricted Project

Thu, Sep 26

morehouse added a comment to D67987: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..

Hmm.. Actually it is defined. I'll have to look into it more...

Thu, Sep 26, 11:04 AM · Restricted Project
morehouse added a comment to D67987: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..

I don't see TSAN_EXTERNAL_HOOKS defined anywhere internally. So presumably the non-weak definition was never used.

Thu, Sep 26, 10:39 AM · Restricted Project

Wed, Sep 25

morehouse added inline comments to D68067: [libFuzzer] Dump trace and provide correct msg for overwritten input..
Wed, Sep 25, 6:20 PM · Restricted Project, Restricted Project

Tue, Sep 24

morehouse added a comment to D28596: [compiler-rt] General definition for weak functions..
In D28596#1680946, @rnk wrote:

I see. I audited the other instances of SANITIZER_INTERFACE_WEAK_DEF, and they all seem to be properly namespaced into __asan_, __sanitizer_, etc.

Do you (or someone else from dynamic-tools) mind driving the fix for this, since you control the internal integration for this and would know where to add the missing test? Again, sorry for the breakage.

Tue, Sep 24, 2:36 PM · Restricted Project
morehouse created D67987: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..
Tue, Sep 24, 2:31 PM · Restricted Project

Fri, Sep 20

morehouse committed rG949a126438b9: [docs] Update structure-aware-fuzzing link. (authored by morehouse).
[docs] Update structure-aware-fuzzing link.
Fri, Sep 20, 12:42 PM
morehouse committed rL372423: [docs] Update structure-aware-fuzzing link..
[docs] Update structure-aware-fuzzing link.
Fri, Sep 20, 12:42 PM

Sep 11 2019

morehouse created D67476: [libFuzzer] Remove lazy counters..
Sep 11 2019, 5:40 PM · Restricted Project

Sep 10 2019

morehouse accepted D66107: [libFuzzer] Make -merge=1 to reuse coverage information from the control file..
Sep 10 2019, 3:15 PM · Restricted Project, Restricted Project
morehouse accepted D67293: [scudo][standalone] Android related improvements.

LGTM

Sep 10 2019, 2:24 PM · Restricted Project, Restricted Project

Aug 27 2019

morehouse added a comment to D65672: [compiler-rt] Expose fuzzer coverage bitmaps to the target.

My opinion is that this exposes too much implementation detail and seems too hacky/niche to be merged into libFuzzer. But I defer the ultimate decision to @kcc (who is unlikely to respond until next week when he is back in the office).

Aug 27 2019, 10:11 AM · Restricted Project, Restricted Project

Aug 20 2019

morehouse added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Aug 20 2019, 6:11 PM · Restricted Project, Restricted Project

Aug 19 2019

morehouse accepted D62875: [GWP-ASan] Add public-facing documentation [6]..
Aug 19 2019, 4:57 PM · Restricted Project, Restricted Project
morehouse added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Aug 19 2019, 9:09 AM · Restricted Project, Restricted Project

Aug 13 2019

morehouse added a reviewer for D66107: [libFuzzer] Make -merge=1 to reuse coverage information from the control file.: kcc.

A few high-level thoughts/questions:

Aug 13 2019, 3:47 PM · Restricted Project, Restricted Project
morehouse accepted D66112: [scudo][standalone] Add more stats to mallinfo.

LGTM

Aug 13 2019, 9:46 AM · Restricted Project, Restricted Project

Aug 12 2019

morehouse accepted D66030: [libFuzzer] Merge: print feature coverage number as well..
Aug 12 2019, 10:22 AM · Restricted Project, Restricted Project
morehouse added inline comments to D66030: [libFuzzer] Merge: print feature coverage number as well..
Aug 12 2019, 10:19 AM · Restricted Project, Restricted Project

Aug 8 2019

morehouse accepted D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
Aug 8 2019, 12:45 PM · Restricted Project, Restricted Project

Aug 7 2019

morehouse accepted D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
Aug 7 2019, 4:14 PM · Restricted Project, Restricted Project

Aug 5 2019

morehouse accepted D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..

Yep, i failed to convey the problem.
Any code that uses that header will get locked into compiler that provides said header,
unless they resort to bundling said header in the first place, which will be frowned upon.

Aug 5 2019, 11:29 AM · Restricted Project, Restricted Project

Aug 2 2019

morehouse accepted D65660: [scudo][standalone] Minor corrections.

LGTM

Aug 2 2019, 10:10 AM · Restricted Project, Restricted Project

Jul 23 2019

morehouse accepted D62875: [GWP-ASan] Add public-facing documentation [6]..
Jul 23 2019, 9:26 AM · Restricted Project, Restricted Project

Jul 22 2019

morehouse added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Jul 22 2019, 5:34 PM · Restricted Project, Restricted Project

Jul 19 2019

morehouse accepted D65029: [Driver] Support for disabling sanitizer runtime linking.

LGTM

Jul 19 2019, 5:00 PM · Restricted Project, Restricted Project
morehouse committed rG2272be94f220: [RISCV] Disable tests failing on buildbots. (authored by morehouse).
[RISCV] Disable tests failing on buildbots.
Jul 19 2019, 11:06 AM
morehouse committed rL366599: [RISCV] Disable tests failing on buildbots..
[RISCV] Disable tests failing on buildbots.
Jul 19 2019, 11:06 AM

Jul 16 2019

morehouse added a comment to D63733: [IndVars] Use exit count reasoning to discharge obviously untaken exits.

The assertion assert(!ExitCount->isZero() && "Should have been folded above"); is failing during the unittest build on the UBSan bot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-ubsan/builds/13940

Jul 16 2019, 9:57 AM · Restricted Project

Jul 15 2019

morehouse committed rG8528b1951cc6: [ASan] Fix >80 character line. (authored by morehouse).
[ASan] Fix >80 character line.
Jul 15 2019, 3:10 PM
morehouse committed rL366136: [ASan] Fix >80 character line..
[ASan] Fix >80 character line.
Jul 15 2019, 3:07 PM

Jul 11 2019

morehouse accepted D64587: Use clang driver for libfuzzer tests on Windows.

LGTM

Jul 11 2019, 1:51 PM · Restricted Project, Restricted Project

Jul 9 2019

morehouse accepted D64440: [libFuzzer] Include FuzzedDataProvider.h in the test without "utils" subdir..

LGTM

Jul 9 2019, 12:25 PM · Restricted Project, Restricted Project

Jun 28 2019

morehouse accepted D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang.

LGTM

Jun 28 2019, 11:36 AM · Restricted Project, Restricted Project, Restricted Project

Jun 26 2019

morehouse accepted D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].

LGTM

Jun 26 2019, 11:48 AM · Restricted Project, Restricted Project

Jun 25 2019

morehouse accepted D63783: [scudo] Correct a behavior on the shared TSD registry.

LGTM

Jun 25 2019, 12:06 PM · Restricted Project, Restricted Project

Jun 24 2019

morehouse added a comment to D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang.

Thanks for the patch! Seems like a useful feature for targeted fuzzing.

Jun 24 2019, 2:56 PM · Restricted Project, Restricted Project, Restricted Project
morehouse accepted D63612: [scudo][standalone] Introduce the C & C++ wrappers.
Jun 24 2019, 11:17 AM · Restricted Project, Restricted Project

Jun 18 2019

morehouse accepted D63435: [scudo][standalone] Fuchsia related changes.

LGTM

Jun 18 2019, 10:30 AM · Restricted Project, Restricted Project

Jun 17 2019

morehouse accepted D63348: [libFuzzer] Improve FuzzedDataProvider helper..

LGTM

Jun 17 2019, 6:37 PM · Restricted Project, Restricted Project

Jun 14 2019

morehouse accepted D63231: [scudo][standalone] Introduce the combined allocator.

LGTM

Jun 14 2019, 3:46 PM · Restricted Project, Restricted Project
morehouse added inline comments to D63231: [scudo][standalone] Introduce the combined allocator.
Jun 14 2019, 3:46 PM · Restricted Project, Restricted Project
morehouse accepted D63231: [scudo][standalone] Introduce the combined allocator.
Jun 14 2019, 1:19 PM · Restricted Project, Restricted Project

Jun 11 2019

morehouse accepted D63146: [scudo][standalone] Unmap memory in tests.

LGTM

Jun 11 2019, 10:51 AM · Restricted Project, Restricted Project
morehouse added inline comments to D63146: [scudo][standalone] Unmap memory in tests.
Jun 11 2019, 9:50 AM · Restricted Project, Restricted Project

Jun 10 2019

morehouse accepted D62733: Add FuzzedDataProvider helper class / single header library..
Jun 10 2019, 6:23 PM · Restricted Project, Restricted Project
morehouse added inline comments to D62929: [GWP-ASan] Integration with Scudo [5]..
Jun 10 2019, 10:25 AM · Restricted Project, Restricted Project

Jun 7 2019

morehouse accepted D62258: [scudo][standalone] Introduce the thread specific data structures.
Jun 7 2019, 1:50 PM · Restricted Project, Restricted Project
morehouse added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Jun 7 2019, 1:01 PM · Restricted Project, Restricted Project

Jun 6 2019

morehouse added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Jun 6 2019, 3:39 PM · Restricted Project, Restricted Project
morehouse added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Jun 6 2019, 12:58 PM · Restricted Project, Restricted Project

Jun 4 2019

morehouse accepted D62698: [GWP-ASan] Configuration options [3]..
Jun 4 2019, 9:22 AM · Restricted Project, Restricted Project

May 31 2019

morehouse added inline comments to D62698: [GWP-ASan] Configuration options [3]..
May 31 2019, 4:02 PM · Restricted Project, Restricted Project
morehouse added inline comments to D62698: [GWP-ASan] Configuration options [3]..
May 31 2019, 3:03 PM · Restricted Project, Restricted Project

May 30 2019

morehouse accepted D61923: [GWP-ASan] Mutex implementation [2]..

LGTM

May 30 2019, 11:50 AM · Restricted Project, Restricted Project, Restricted Project

May 29 2019

morehouse added inline comments to D61923: [GWP-ASan] Mutex implementation [2]..
May 29 2019, 6:25 PM · Restricted Project, Restricted Project, Restricted Project
morehouse added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
May 29 2019, 12:54 PM · Restricted Project, Restricted Project
morehouse added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
May 29 2019, 10:41 AM · Restricted Project, Restricted Project

May 23 2019

morehouse added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
May 23 2019, 5:10 PM · Restricted Project, Restricted Project

May 22 2019

morehouse added inline comments to D61923: [GWP-ASan] Mutex implementation [2]..
May 22 2019, 11:20 AM · Restricted Project, Restricted Project, Restricted Project

May 21 2019

morehouse committed rG4d7a6142de7c: [libFuzzer] Sleep after process exits in merge-sigusr.test. (authored by morehouse).
[libFuzzer] Sleep after process exits in merge-sigusr.test.
May 21 2019, 5:40 PM
morehouse committed rL361339: [libFuzzer] Sleep after process exits in merge-sigusr.test..
[libFuzzer] Sleep after process exits in merge-sigusr.test.
May 21 2019, 5:39 PM
morehouse committed rCRT361339: [libFuzzer] Sleep after process exits in merge-sigusr.test..
[libFuzzer] Sleep after process exits in merge-sigusr.test.
May 21 2019, 5:39 PM
morehouse committed rG9e0f6cc3a379: [libFuzzer] Kill by session ID in merge-sigusr.test. (authored by morehouse).
[libFuzzer] Kill by session ID in merge-sigusr.test.
May 21 2019, 4:53 PM
morehouse committed rL361336: [libFuzzer] Kill by session ID in merge-sigusr.test..
[libFuzzer] Kill by session ID in merge-sigusr.test.
May 21 2019, 4:53 PM
morehouse committed rCRT361336: [libFuzzer] Kill by session ID in merge-sigusr.test..
[libFuzzer] Kill by session ID in merge-sigusr.test.
May 21 2019, 4:53 PM
morehouse committed rGdb62d375dc33: [libFuzzer] Ignore exit status of wait in merge-sigusr.test. (authored by morehouse).
[libFuzzer] Ignore exit status of wait in merge-sigusr.test.
May 21 2019, 3:48 PM
morehouse committed rL361326: [libFuzzer] Ignore exit status of wait in merge-sigusr.test..
[libFuzzer] Ignore exit status of wait in merge-sigusr.test.
May 21 2019, 3:48 PM
morehouse committed rCRT361326: [libFuzzer] Ignore exit status of wait in merge-sigusr.test..
[libFuzzer] Ignore exit status of wait in merge-sigusr.test.
May 21 2019, 3:48 PM
morehouse committed rGdf17ddf9fcb7: [libFuzzer] Reduce flakiness of merge-sigusr.test. (authored by morehouse).
[libFuzzer] Reduce flakiness of merge-sigusr.test.
May 21 2019, 2:14 PM
morehouse committed rCRT361313: [libFuzzer] Reduce flakiness of merge-sigusr.test..
[libFuzzer] Reduce flakiness of merge-sigusr.test.
May 21 2019, 2:13 PM
morehouse committed rL361313: [libFuzzer] Reduce flakiness of merge-sigusr.test..
[libFuzzer] Reduce flakiness of merge-sigusr.test.
May 21 2019, 2:13 PM

May 20 2019

morehouse committed rGef7e4d530c1e: [libFuzzer] Disable fork-sigusr.test on AArch64. (authored by morehouse).
[libFuzzer] Disable fork-sigusr.test on AArch64.
May 20 2019, 11:37 AM
morehouse committed rCRT361185: [libFuzzer] Disable fork-sigusr.test on AArch64..
[libFuzzer] Disable fork-sigusr.test on AArch64.
May 20 2019, 11:37 AM