Page MenuHomePhabricator
Feed Advanced Search

Sep 16 2016

ldrumm committed rL281717: [RenderScript] Support tracking and dumping reduction kernels.
[RenderScript] Support tracking and dumping reduction kernels
Sep 16 2016, 4:37 AM

Aug 31 2016

ldrumm committed rL280240: [clang-format-vim] Support vim linked against py3.
[clang-format-vim] Support vim linked against py3
Aug 31 2016, 6:45 AM
ldrumm closed D23319: [vim clang-format.py] python3 support by committing rL280240: [clang-format-vim] Support vim linked against py3.
Aug 31 2016, 6:44 AM · Restricted Project

Aug 22 2016

ldrumm added a comment to D23319: [vim clang-format.py] python3 support.

@djasper, I don't seem to have commit access to cfe so awould you be willing to commit this on my behalf?

Aug 22 2016, 7:54 AM · Restricted Project

Aug 9 2016

ldrumm updated the diff for D23319: [vim clang-format.py] python3 support.

Make print output the same 2-3

Aug 9 2016, 7:46 AM · Restricted Project
ldrumm retitled D23319: [vim clang-format.py] python3 support from to [vim clang-format.py] python3 support.
Aug 9 2016, 7:31 AM · Restricted Project

Aug 3 2016

ldrumm committed rL277613: [RenderScript] Always create a new allocation ID in CaptureAllocationInit hook.
[RenderScript] Always create a new allocation ID in CaptureAllocationInit hook
Aug 3 2016, 10:39 AM
ldrumm committed rL277608: Fix an unused variable warning in release builds..
Fix an unused variable warning in release builds.
Aug 3 2016, 9:37 AM

Jul 28 2016

ldrumm committed rL277016: Cleanup some format string warnings.
Cleanup some format string warnings
Jul 28 2016, 11:27 AM
ldrumm closed D22923: cleanup some format string warnings by committing rL277016: Cleanup some format string warnings.
Jul 28 2016, 11:27 AM · Restricted Project
ldrumm added a comment to D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend.

I've got a fix to make this work in Xcode, but I'm currently stuck behind the missing Condition.cpp from r277011 to verify.

Thanks Todd. I don't really deal with XCode, so that's a real help.

My pleasure! We expect to need to do this on the Xcode side since we aren't using cmake like everyone else.

Regarding r277012, I'm a little confused about the message "Also, fixed up typos in RenderScript code that could not possibly compile." Is this code broken somehow? It build for us with GCC, and green dragon seems fine with it. Is there some particular compiler for which this is broken because everything "Works for Me"?

Nope nope you're fine. I tried to quickly fix my comment in follow ups to my commit message emails. I looked too quickly at the filenames and figured the error was introduced from the RenderScript change. It was in fact from Saleem's change. It was in files that he couldn't compile unless he was on Xcode, so the typos came in there.

Jul 28 2016, 11:20 AM
ldrumm added a comment to D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend.

I've got a fix to make this work in Xcode, but I'm currently stuck behind the missing Condition.cpp from r277011 to verify.

Jul 28 2016, 11:15 AM
ldrumm retitled D22923: cleanup some format string warnings from to cleanup some format string warnings.
Jul 28 2016, 9:18 AM · Restricted Project
ldrumm committed rL276976: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86….
Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86…
Jul 28 2016, 7:29 AM
ldrumm closed D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend by committing rL276976: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86….
Jul 28 2016, 7:28 AM
ldrumm updated the diff for D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend.
Jul 28 2016, 7:14 AM

Jul 18 2016

ldrumm added a comment to D22370: Respect LLVM_HOST_TRIPLE when manually specified.

Sorry Chris, I didn't see this one. It appeared while I was posting my last message

Jul 18 2016, 7:58 AM
ldrumm added a comment to D22370: Respect LLVM_HOST_TRIPLE when manually specified.

LLVM_HOST_TRIPLE is not intended to match the target, and it shouldn't be used in situations where it must match the target. I'm not familiar with how lldb builds the remote server in CMake, but using LLVM_HOST_TRIPLE is not the right answer.

Jul 18 2016, 6:48 AM
ldrumm added a comment to D22370: Respect LLVM_HOST_TRIPLE when manually specified.

Supporting specifying the triple manually is a completely separate issue from the bug you encountered. I'd prefer to make target detection for windows work correctly and reliably so that we don't need to support setting LLVM_HOST_TRIPLE manually. Other than the bugs in get_host_triple, is there a reason you feel the need to set the host triple manually?

Jul 18 2016, 3:39 AM

Jul 15 2016

ldrumm added a comment to D22370: Respect LLVM_HOST_TRIPLE when manually specified.

I very much believe you are doing something wrong.

Your description of the problem doesn't match the error message, and I can tell you that the solution *isn't* to make get_host_triple return anything that isn't actually the host triple.

Jul 15 2016, 9:27 AM
ldrumm added a comment to D22370: Respect LLVM_HOST_TRIPLE when manually specified.

Can you explain why this is necessary when cross-targeting? I kinda feel that the problem is more likely that the LLVM_HOST_TRIPLE is being used in places where a *target* triple should be used.

Jul 15 2016, 5:18 AM

Jul 14 2016

ldrumm added a reviewer for D22370: Respect LLVM_HOST_TRIPLE when manually specified: clayborg.
Jul 14 2016, 10:50 AM
ldrumm retitled D22370: Respect LLVM_HOST_TRIPLE when manually specified from to Respect LLVM_HOST_TRIPLE when manually specified.
Jul 14 2016, 10:49 AM

Jul 7 2016

ldrumm committed rL274776: Respect ANDROID_SERIAL environment variable used by ADB.
Respect ANDROID_SERIAL environment variable used by ADB
Jul 7 2016, 11:10 AM
ldrumm closed D22052: Respect `ANDROID_SERIAL` environment variable used by ADB by committing rL274776: Respect ANDROID_SERIAL environment variable used by ADB.
Jul 7 2016, 11:09 AM
ldrumm added inline comments to D22081: Use shell cat command as a workaround if ADB stat cannot lookup a file.
Jul 7 2016, 7:59 AM
ldrumm updated the diff for D22052: Respect `ANDROID_SERIAL` environment variable used by ADB.
  • Ensure if ANDROID_SERIAL is set, it exists in the list of connected devices (Address feedback from @ovyalov)
  • Also add a hint in the error message in case multiple devices are attached and no serial number is available.
Jul 7 2016, 5:24 AM

Jul 6 2016

ldrumm retitled D22060: [expression evaluation] Prevent invalid function declarations ending up in clang AST from to [expression evaluation] Prevent invalid function declarations ending up in clang AST.
Jul 6 2016, 11:29 AM
ldrumm retitled D22052: Respect `ANDROID_SERIAL` environment variable used by ADB from to Respect `ANDROID_SERIAL` environment variable used by ADB.
Jul 6 2016, 9:51 AM

Jun 15 2016

ldrumm abandoned D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation..

committed in http://reviews.llvm.org/rL272800

Jun 15 2016, 10:28 AM
ldrumm added a comment to rL272800: Allow runtimes to execute custom LLVM ModulePasses over the expression IR.

differential revision: http://reviews.llvm.org/D17027

Jun 15 2016, 10:26 AM
ldrumm committed rL272800: Allow runtimes to execute custom LLVM ModulePasses over the expression IR.
Allow runtimes to execute custom LLVM ModulePasses over the expression IR
Jun 15 2016, 9:26 AM

Jun 3 2016

ldrumm added a comment to D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation..

I'd like to give this another *bump*, and commit this soon assuming positive review.

Jun 3 2016, 10:15 AM
ldrumm added a comment to D20825: Don't force Python2.7.

Sorry for the delay, I wanted to run tests...

Jun 3 2016, 7:03 AM

May 31 2016

ldrumm added reviewers for D20825: Don't force Python2.7: zturner, chandlerc.
May 31 2016, 11:16 AM
ldrumm retitled D20825: Don't force Python2.7 from to Don't force Python2.7.
May 31 2016, 11:14 AM

May 20 2016

ldrumm added a comment to D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation..

gentle ping, if @spyffe or @jingham is available to take another pass at this.

May 20 2016, 8:11 AM

May 13 2016

ldrumm updated the diff for D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation..

rebased on current HEAD

May 13 2016, 8:48 AM

Apr 8 2016

ldrumm committed rL265808: Remove bad indentation introduced in 263859.
Remove bad indentation introduced in 263859
Apr 8 2016, 9:58 AM
ldrumm committed rL265799: Revert bad commit 265797..
Revert bad commit 265797.
Apr 8 2016, 9:41 AM
ldrumm committed rL265797: Fix indentation for commit 263859..
Fix indentation for commit 263859.
Apr 8 2016, 9:36 AM

Mar 29 2016

ldrumm added a comment to D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation..

Hi Sean

Mar 29 2016, 7:23 AM
ldrumm requested changes to D18383: Expose top-level expressions via the LLDB command line and public API.
Mar 29 2016, 6:46 AM
ldrumm added a comment to D18383: Expose top-level expressions via the LLDB command line and public API.

Hi Sean

Mar 29 2016, 6:46 AM

Mar 17 2016

ldrumm accepted D18165: Replace stream-based error handling in the expression parser.

I haven't had a chance to try this out (at EuroLLVM) but looks good.

Mar 17 2016, 9:44 AM

Mar 15 2016

ldrumm requested changes to D18165: Replace stream-based error handling in the expression parser.
Mar 15 2016, 1:16 PM
ldrumm added a comment to D18165: Replace stream-based error handling in the expression parser.

Overall this patch is great cleanup!

Mar 15 2016, 1:12 PM

Mar 11 2016

ldrumm added a comment to D18099: Fix expression evaluation for resolving anonymous aggregrate types with a typedefed name.

Hi Sean
I added a regression test in this diff

Mar 11 2016, 2:32 PM
ldrumm retitled D18099: Fix expression evaluation for resolving anonymous aggregrate types with a typedefed name from to Fix expression evaluation for resolving anonymous aggregrate types with a typedefed name.
Mar 11 2016, 2:01 PM

Mar 10 2016

ldrumm retitled D18059: Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend from to Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86 backend.
Mar 10 2016, 11:45 AM

Mar 9 2016

ldrumm added a comment to D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union.

Hi all

Mar 9 2016, 12:22 PM
ldrumm added a comment to D17719: Track expression language from one place in ClangExpressionParser.

Hi all

Mar 9 2016, 2:41 AM · Restricted Project

Mar 7 2016

ldrumm added a comment to D17719: Track expression language from one place in ClangExpressionParser.

Hi all

Mar 7 2016, 10:47 AM · Restricted Project

Mar 1 2016

ldrumm updated the diff for D17719: Track expression language from one place in ClangExpressionParser.

Updated diff to show full context

Mar 1 2016, 12:07 PM · Restricted Project
ldrumm retitled D17777: Add regression test for expressions calling functions taking anonymous struct typedef arguments from to Add regression test for expressions calling functions taking anonymous struct typedef arguments.
Mar 1 2016, 11:56 AM

Feb 29 2016

ldrumm retitled D17719: Track expression language from one place in ClangExpressionParser from to Track expression language from one place in ClangExpressionParser.
Feb 29 2016, 7:38 AM · Restricted Project

Feb 25 2016

ldrumm added inline comments to D17274: improve readability and performance of ClangExpressionParser::FindFunctionInModule.
Feb 25 2016, 5:14 AM

Feb 18 2016

ldrumm added a comment to D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation..

If you have the time, I'd appreciate your comments.

Feb 18 2016, 9:53 AM

Feb 16 2016

ldrumm added inline comments to D17274: improve readability and performance of ClangExpressionParser::FindFunctionInModule.
Feb 16 2016, 4:34 AM

Feb 15 2016

ldrumm updated the diff for D16412: remove unused local string in IRForTarget.cpp.

rebased on current HEAD

Feb 15 2016, 12:29 PM
ldrumm added a comment to D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation..

Hi Jim

Feb 15 2016, 12:23 PM
ldrumm retitled D17274: improve readability and performance of ClangExpressionParser::FindFunctionInModule from to improve readability and performance of ClangExpressionParser::FindFunctionInModule.
Feb 15 2016, 12:09 PM
ldrumm retitled D17273: refactor/cleanup ClangExpressionParser::Parse from to refactor/cleanup ClangExpressionParser::Parse.
Feb 15 2016, 11:37 AM
ldrumm retitled D17266: delete unused function in ClangExpressionParser` from to delete unused function in ClangExpressionParser`.
Feb 15 2016, 5:24 AM

Feb 10 2016

ldrumm added a comment to D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS.

This patch is on an out of date ClangExpressionParser.cpp. The feature added in http://reviews.llvm.org/rL259644 allows a more generic way of implementing what I believe you're trying to achieve with this patch. It's probably worth a look.

Feb 10 2016, 5:02 AM
ldrumm added a comment to D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation..

This seems fine as a generic instrumentation point. Obviously, the onus in on the passes, since they could totally ruin the expression evaluation if they don't do their job right... But I'm not sure there's any good way to make this not a sharp tool. But you should wait on Sean to weigh in as well...

Feb 10 2016, 3:45 AM

Feb 9 2016

ldrumm retitled D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation. from to [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation..
Feb 9 2016, 7:04 AM

Feb 2 2016

ldrumm added a comment to D15527: Add ability to override JIT expr compiler options. .

I'd like a final review on this patch if one of the code owners can take the time, please?

Feb 2 2016, 11:19 AM

Jan 28 2016

ldrumm added a comment to D15527: Add ability to override JIT expr compiler options. .

Hi Sean

Jan 28 2016, 9:40 AM

Jan 25 2016

ldrumm added a comment to D16107: Fix for Bug 25338.

This differential seems to have introduced a regression on x86_64 Android, where std::bad_alloc is thrown during process attach. I've reverted this locally, and filed a bug, but as this is code I'm not familiar with, I'd appreciate it if @ravitheja were able to take a look at this again.

Jan 25 2016, 6:45 AM

Jan 21 2016

ldrumm updated the diff for D15527: Add ability to override JIT expr compiler options. .

Address @spyffe's previous suggestions regarding modifying target options in place. This allows for a simpler and more maintainable solution than previously implemented, and requires no extra datatype definitions.

Jan 21 2016, 1:21 PM
ldrumm retitled D16412: remove unused local string in IRForTarget.cpp from to remove unused local string in IRForTarget.cpp.
Jan 21 2016, 9:27 AM

Jan 13 2016

ldrumm updated the diff for D15527: Add ability to override JIT expr compiler options. .

Responding to Sean Callanan's suggestions in previous differential RE accepting an existing set of TargetOptions as the basis to configure a custom set.

Jan 13 2016, 2:36 PM
ldrumm retitled D16155: possible ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext from possible ambigous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext to possible ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext.
Jan 13 2016, 2:11 PM
ldrumm retitled D16155: possible ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext from to possible ambigous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext.
Jan 13 2016, 2:10 PM

Jan 12 2016

ldrumm added a comment to D15527: Add ability to override JIT expr compiler options. .

I'm a little concerned that LanguageRuntime::GetOverrideExprOptions() appears to generate a new set of options from whole cloth rather than using the existing set as a starting point.

Specifically, since your use case is wanting to override the calling convention, I think it's heavy handed to override all the options. I could conceive of new expression parser features changing some other flags in the future, and it'd be unfortunate if we had to duplicate those features in the ActionScript code just because the options are being overridden.

Jan 12 2016, 1:41 PM
ldrumm requested review of D15527: Add ability to override JIT expr compiler options. .

bump

Jan 12 2016, 3:07 AM

Jan 7 2016

ldrumm retitled D15948: Remove duplicate header added in http://reviews.llvm.org/rL256927 from to Remove duplicate header added in http://reviews.llvm.org/rL256927.
Jan 7 2016, 5:52 AM

Jan 5 2016

ldrumm updated the diff for D15773: Add LogDump methods to lldb_private::StringList to ease printing of iterable string containers.

Addresses @clayborg's feedback in http://reviews.llvm.org/D15773

Jan 5 2016, 7:57 AM

Dec 24 2015

ldrumm updated the diff for D15527: Add ability to override JIT expr compiler options. .
Dec 24 2015, 1:10 PM
ldrumm updated the diff for D15527: Add ability to override JIT expr compiler options. .

Updated implementation as per comment on manually set user language: http://reviews.llvm.org/D15527#inline-127860 . This patch adds checking for non eLanguageTypeUnknow expression language before falling back to the language of the current stack frame.

Dec 24 2015, 1:03 PM
ldrumm updated the diff for D15773: Add LogDump methods to lldb_private::StringList to ease printing of iterable string containers.
Dec 24 2015, 12:21 PM
ldrumm abandoned D15773: Add LogDump methods to lldb_private::StringList to ease printing of iterable string containers.
Dec 24 2015, 12:17 PM
ldrumm updated the diff for D15773: Add LogDump methods to lldb_private::StringList to ease printing of iterable string containers.
Dec 24 2015, 12:03 PM
ldrumm retitled D15773: Add LogDump methods to lldb_private::StringList to ease printing of iterable string containers from to Add LogDump methods to lldb_private::StringList to ease printing of iterable string containers.
Dec 24 2015, 10:38 AM

Dec 15 2015

ldrumm added a comment to D15527: Add ability to override JIT expr compiler options. .

FYI This feature was originally discussed on the ML: http://lists.llvm.org/pipermail/lldb-dev/2015-December/009006.html

Dec 15 2015, 7:25 AM
ldrumm retitled D15527: Add ability to override JIT expr compiler options. from to Add ability to override JIT expr compiler options. .
Dec 15 2015, 7:12 AM