Page MenuHomePhabricator
Feed Advanced Search

Nov 17 2021

DaanDeMeyer committed rG5a6dac66db67: LiteralSupport: Don't assert() on invalid input (authored by DaanDeMeyer).
LiteralSupport: Don't assert() on invalid input
Nov 17 2021, 3:51 PM

Nov 16 2021

DaanDeMeyer updated the diff for D114003: LiteralSupport: Don't assert() on invalid input.

Addressed comments by adding two new errors, one for character literals and one for numeric literals.

Nov 16 2021, 11:35 AM · Restricted Project, Restricted Project
DaanDeMeyer updated the diff for D114003: LiteralSupport: Don't assert() on invalid input.

clang-format

Nov 16 2021, 8:52 AM · Restricted Project, Restricted Project
DaanDeMeyer added a comment to D114003: LiteralSupport: Don't assert() on invalid input.

Added some people that were recent reviewers of changes to this file and some clangd folks.

Nov 16 2021, 8:04 AM · Restricted Project, Restricted Project
DaanDeMeyer requested review of D114003: LiteralSupport: Don't assert() on invalid input.
Nov 16 2021, 8:02 AM · Restricted Project, Restricted Project

Feb 20 2021

DaanDeMeyer committed rG7dd42ecfa2a2: clang: Exclude efi_main from -Wmissing-prototypes (authored by DaanDeMeyer).
clang: Exclude efi_main from -Wmissing-prototypes
Feb 20 2021, 12:04 PM
DaanDeMeyer closed D95746: clang: Exclude efi_main from -Wmissing-prototypes.
Feb 20 2021, 12:04 PM · Restricted Project
DaanDeMeyer added a comment to D95746: clang: Exclude efi_main from -Wmissing-prototypes.

I should be able to commit it myself. Thanks for the review!

Feb 20 2021, 12:00 PM · Restricted Project
DaanDeMeyer updated the diff for D95746: clang: Exclude efi_main from -Wmissing-prototypes.

Moved the test into the no-warn-missing-prototype test as requested.

Feb 20 2021, 11:59 AM · Restricted Project

Feb 19 2021

DaanDeMeyer added a comment to D95746: clang: Exclude efi_main from -Wmissing-prototypes.

Added a test

Feb 19 2021, 4:37 PM · Restricted Project
DaanDeMeyer updated the diff for D95746: clang: Exclude efi_main from -Wmissing-prototypes.
Feb 19 2021, 4:37 PM · Restricted Project

Feb 2 2021

DaanDeMeyer updated the diff for D95746: clang: Exclude efi_main from -Wmissing-prototypes.
Feb 2 2021, 1:40 PM · Restricted Project

Jan 31 2021

DaanDeMeyer added a comment to D95746: clang: Exclude efi_main from -Wmissing-prototypes.

CI failures seem unrelated?

Jan 31 2021, 2:46 AM · Restricted Project

Jan 30 2021

DaanDeMeyer requested review of D95746: clang: Exclude efi_main from -Wmissing-prototypes.
Jan 30 2021, 11:31 AM · Restricted Project
DaanDeMeyer abandoned D93601: lldb-vscode: Install package.json to share/lldb-vscode.
Jan 30 2021, 11:25 AM · Restricted Project

Dec 20 2020

DaanDeMeyer requested review of D93601: lldb-vscode: Install package.json to share/lldb-vscode.
Dec 20 2020, 12:45 PM · Restricted Project

Nov 18 2020

DaanDeMeyer abandoned D91509: [clangd] Add AST config to prebuild ASTs.

Abandoning as the end result is too slow even when including a limited number of files.

Nov 18 2020, 2:57 PM · Restricted Project, Restricted Project

Nov 16 2020

DaanDeMeyer updated the diff for D91509: [clangd] Add AST config to prebuild ASTs.

Fix all the bugs after doing some proper testing.

Nov 16 2020, 5:54 AM · Restricted Project, Restricted Project
DaanDeMeyer updated the diff for D91509: [clangd] Add AST config to prebuild ASTs.

Fix tests

Nov 16 2020, 4:20 AM · Restricted Project, Restricted Project

Nov 15 2020

DaanDeMeyer updated the diff for D91509: [clangd] Add AST config to prebuild ASTs.

Fixed formatting

Nov 15 2020, 4:18 PM · Restricted Project, Restricted Project
DaanDeMeyer updated the diff for D91509: [clangd] Add AST config to prebuild ASTs.

Switched from all or nothing command line option to per file config.

Nov 15 2020, 3:56 PM · Restricted Project, Restricted Project
DaanDeMeyer requested review of D91509: [clangd] Add AST config to prebuild ASTs.
Nov 15 2020, 2:23 PM · Restricted Project, Restricted Project

May 6 2020

DaanDeMeyer committed rGf21c704553a8: clang-format: Add ControlStatementsExceptForEachMacros option to… (authored by DaanDeMeyer).
clang-format: Add ControlStatementsExceptForEachMacros option to…
May 6 2020, 12:27 PM
DaanDeMeyer closed D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens.
May 6 2020, 12:27 PM · Restricted Project, Restricted Project
DaanDeMeyer added a comment to D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens.

I pushed the commit to github. Thanks for the help!

May 6 2020, 12:25 PM · Restricted Project, Restricted Project
DaanDeMeyer added a comment to D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens.

I should have commit access now. Is there any documentation on how exactly to do a merge? Do I just add the commit to master and push? I apologize if this seems obvious, I just want to make sure I'm not inadvertently breaking something.

May 6 2020, 8:35 AM · Restricted Project, Restricted Project

May 5 2020

DaanDeMeyer added a comment to D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens.

(I don't have commit access so it'd be great if someone could merge this for me, at least that's how my other contributions have been handled)

May 5 2020, 4:16 AM · Restricted Project, Restricted Project

Apr 26 2020

DaanDeMeyer added inline comments to D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens.
Apr 26 2020, 5:50 AM · Restricted Project, Restricted Project
DaanDeMeyer updated the diff for D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens.
  • Moved docs to Format.h and re-generated rst file using dump_format_style.py
  • Expanded comment with an explanation for why you might want to not have a space before the parens of a ForEach macro
Apr 26 2020, 5:18 AM · Restricted Project, Restricted Project
DaanDeMeyer updated the diff for D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens.

Fixed formatting

Apr 26 2020, 3:42 AM · Restricted Project, Restricted Project
DaanDeMeyer abandoned D73080: Fix symlink resolution in GetCanonicalPath.

Abandoning this since clangd shouldn't be forced to deal with the outrageous build system that I'm forced to use. I'm currently just building clangd from source with these changes which works fine.

Apr 26 2020, 2:38 AM · Restricted Project
DaanDeMeyer abandoned D76197: clang-format: Use block indentation for braced initializations.

Turns out this is already possible by disabling Cpp11BracedListStyle. The proposed change introduced too many changes regardless so I'm abandoning this.

Apr 26 2020, 2:38 AM · Restricted Project, Restricted Project

Apr 25 2020

DaanDeMeyer created D78869: clang-format: Add ControlStatementsExceptForEachMacros option to SpaceBeforeParens.
Apr 25 2020, 12:44 PM · Restricted Project, Restricted Project

Mar 26 2020

DaanDeMeyer added a comment to D76197: clang-format: Use block indentation for braced initializations.

Of course, if there's interest in adding this I'll fix all the tests but I wanted to make sure there was interest in adding this since it changes clang-format's behavior. Can you confirm that this change in behavior is a good thing and might be merged if I fix all the tests? If the existing output cannot be changed in any way then this revision can be closed since it fundamentally requires changing clang-format's output.

Mar 26 2020, 8:38 AM · Restricted Project, Restricted Project

Mar 15 2020

DaanDeMeyer updated the diff for D76197: clang-format: Use block indentation for braced initializations.

New implementation that breaks fewer tests.

Mar 15 2020, 11:15 AM · Restricted Project, Restricted Project
DaanDeMeyer updated the diff for D76197: clang-format: Use block indentation for braced initializations.

Changed the implementation to simply remove the handling of l_brace in tok::equal. The state machine simply continues executing and the next case will be the l_brace case which first tries to parse the l_brace as a braced init list.

Mar 15 2020, 9:05 AM · Restricted Project, Restricted Project
DaanDeMeyer updated the diff for D76197: clang-format: Use block indentation for braced initializations.

Formatting

Mar 15 2020, 9:05 AM · Restricted Project, Restricted Project
DaanDeMeyer created D76197: clang-format: Use block indentation for braced initializations.
Mar 15 2020, 8:33 AM · Restricted Project, Restricted Project

Feb 26 2020

DaanDeMeyer added a comment to D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops..

Is there CI infra that runs for each revision? I verified all the format unit tests still pass but I haven't run the entire test suite on my machine.

Feb 26 2020, 8:04 AM · Restricted Project, Restricted Project

Feb 25 2020

DaanDeMeyer added a comment to D75019: Strip preceeding -Xclang when stripping -fcolor-diagnostics or -fdiagnostics-color.

I do not have commit access. It would be great if someone could merge this for me.

Feb 25 2020, 11:38 PM · Restricted Project
DaanDeMeyer updated the diff for D75019: Strip preceeding -Xclang when stripping -fcolor-diagnostics or -fdiagnostics-color.

Added FIXME.

Feb 25 2020, 12:04 PM · Restricted Project
DaanDeMeyer updated the diff for D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops..

Added extra unit tests

Feb 25 2020, 10:48 AM · Restricted Project, Restricted Project

Feb 24 2020

DaanDeMeyer updated the diff for D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops..

Added unit tests and fixed the case where stuff follows the do statement (like a comment).

Feb 24 2020, 10:12 AM · Restricted Project, Restricted Project
DaanDeMeyer updated the diff for D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops..
Feb 24 2020, 12:25 AM · Restricted Project, Restricted Project
DaanDeMeyer updated the diff for D75019: Strip preceeding -Xclang when stripping -fcolor-diagnostics or -fdiagnostics-color.
Feb 24 2020, 12:24 AM · Restricted Project

Feb 23 2020

DaanDeMeyer created D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops..
Feb 23 2020, 11:04 AM · Restricted Project, Restricted Project
DaanDeMeyer created D75019: Strip preceeding -Xclang when stripping -fcolor-diagnostics or -fdiagnostics-color.
Feb 23 2020, 7:10 AM · Restricted Project

Jan 21 2020

DaanDeMeyer updated the summary of D73080: Fix symlink resolution in GetCanonicalPath.
Jan 21 2020, 12:58 AM · Restricted Project
DaanDeMeyer updated the summary of D73080: Fix symlink resolution in GetCanonicalPath.
Jan 21 2020, 12:22 AM · Restricted Project

Jan 20 2020

DaanDeMeyer created D73080: Fix symlink resolution in GetCanonicalPath.
Jan 20 2020, 11:46 PM · Restricted Project

Oct 23 2018

DaanDeMeyer added a comment to D53481: [clangd] Support passing a relative path to -compile-commands-dir.

You can commit them. Thanks for all the quick responses!

Oct 23 2018, 4:18 AM · Restricted Project
DaanDeMeyer updated the diff for D53527: Fix range length comparison in DraftStore::UpdateDraft when Unicode characters are removed from the document.

Update diff according to comments.

Oct 23 2018, 4:17 AM · Restricted Project

Oct 22 2018

DaanDeMeyer created D53527: Fix range length comparison in DraftStore::UpdateDraft when Unicode characters are removed from the document.
Oct 22 2018, 1:42 PM · Restricted Project
DaanDeMeyer updated the diff for D53481: [clangd] Support passing a relative path to -compile-commands-dir.

Updated diff according to comments.

Oct 22 2018, 3:55 AM · Restricted Project

Oct 21 2018

DaanDeMeyer removed a reviewer for D53481: [clangd] Support passing a relative path to -compile-commands-dir: Restricted Project.
Oct 21 2018, 10:28 AM · Restricted Project
DaanDeMeyer created D53481: [clangd] Support passing a relative path to -compile-commands-dir.
Oct 21 2018, 10:26 AM · Restricted Project