Page MenuHomePhabricator
Feed Advanced Search

Mar 26 2020

tatyana-krasnukha committed rGa92673fe9a08: [lldb-vscode] Convert launch_info and attach_info to local variables (authored by anton.kolesov).
[lldb-vscode] Convert launch_info and attach_info to local variables
Mar 26 2020, 9:13 AM
tatyana-krasnukha closed D76593: [lldb-vscode] Convert launch_info and attach_info to local variables.
Mar 26 2020, 9:12 AM · Restricted Project
tatyana-krasnukha committed rG2bfe2b878a62: [lldb][testsuite] Check that process is launched successfully in inline tests (authored by tatyana-krasnukha).
[lldb][testsuite] Check that process is launched successfully in inline tests
Mar 26 2020, 5:23 AM
tatyana-krasnukha committed rGccf1c30cde6e: [lldb][testsuite] Add lldb-server category (authored by tatyana-krasnukha).
[lldb][testsuite] Add lldb-server category
Mar 26 2020, 5:23 AM
tatyana-krasnukha abandoned D76309: Add wait timeout to process properties.

Lit option --timeout partly solves the problem, so these changes are unnecessary.

Mar 26 2020, 5:23 AM

Mar 20 2020

tatyana-krasnukha committed rG0b18b568e91a: [lldb-vscode] Don't use SBLaunchInfo in request_attach (authored by anton.kolesov).
[lldb-vscode] Don't use SBLaunchInfo in request_attach
Mar 20 2020, 10:18 AM
tatyana-krasnukha closed D76351: [lldb-vscode] Don't use SBLaunchInfo in request_attach.
Mar 20 2020, 10:18 AM · Restricted Project

Mar 17 2020

tatyana-krasnukha created D76309: Add wait timeout to process properties.
Mar 17 2020, 11:49 AM

Mar 16 2020

tatyana-krasnukha committed rG332edcc6bd1d: [lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame (authored by tatyana-krasnukha).
[lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame
Mar 16 2020, 6:29 AM
tatyana-krasnukha committed rG0a840ef80059: [lldb] Copy m_behaves_like_zeroth_frame on stack frame update (authored by tatyana-krasnukha).
[lldb] Copy m_behaves_like_zeroth_frame on stack frame update
Mar 16 2020, 6:29 AM
tatyana-krasnukha closed D75979: [lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame.
Mar 16 2020, 6:29 AM · Restricted Project
tatyana-krasnukha closed D75975: [lldb] Copy m_behaves_like_zeroth_frame on stack frame update.
Mar 16 2020, 6:29 AM · Restricted Project

Mar 12 2020

tatyana-krasnukha added a comment to D75537: Clear all settings during a test's setUp.

platform.module-cache-directory should be fixed by rGfe74df01a909.

Mar 12 2020, 1:01 PM · Restricted Project
tatyana-krasnukha committed rGfe74df01a909: [lldb] Specify default value for platform.module-cache-directory (authored by tatyana-krasnukha).
[lldb] Specify default value for platform.module-cache-directory
Mar 12 2020, 12:29 PM
tatyana-krasnukha added a comment to D75537: Clear all settings during a test's setUp.

Thank you for details, I'm looking at these failures, however, I'm not able to debug on the macOS.

Mar 12 2020, 8:08 AM · Restricted Project
tatyana-krasnukha committed rGdf90a15b1ac9: [lldb] Clear all settings during a test's setUp (authored by tatyana-krasnukha).
[lldb] Clear all settings during a test's setUp
Mar 12 2020, 7:03 AM
tatyana-krasnukha closed D75537: Clear all settings during a test's setUp.
Mar 12 2020, 7:03 AM · Restricted Project
tatyana-krasnukha updated the diff for D75537: Clear all settings during a test's setUp.

Addressed comments

Mar 12 2020, 5:13 AM · Restricted Project

Mar 5 2020

tatyana-krasnukha committed rGef38283a0980: [lldb][test] Temporarily X-fail TestPtrRefs.py and TestPtrRefsObjC.py (authored by tatyana-krasnukha).
[lldb][test] Temporarily X-fail TestPtrRefs.py and TestPtrRefsObjC.py
Mar 5 2020, 3:52 AM
tatyana-krasnukha committed rGaafd65ad9ff0: [lldb][test] Replace HandleCommand with runCmd to check that a command succeeded (authored by tatyana-krasnukha).
[lldb][test] Replace HandleCommand with runCmd to check that a command succeeded
Mar 5 2020, 1:41 AM
tatyana-krasnukha committed rGd2e397f15616: [lldb][test] These tests don't fail on Windows anymore (authored by tatyana-krasnukha).
[lldb][test] These tests don't fail on Windows anymore
Mar 5 2020, 1:41 AM
tatyana-krasnukha committed rG7a11cc06a4fd: [lldb][test] TestFileHandle: flush the output after write (authored by tatyana-krasnukha).
[lldb][test] TestFileHandle: flush the output after write
Mar 5 2020, 1:09 AM
tatyana-krasnukha committed rGeecef3af2ca8: [lldb][test] Enable fix-its for the test case that expects them enabled (authored by tatyana-krasnukha).
[lldb][test] Enable fix-its for the test case that expects them enabled
Mar 5 2020, 12:03 AM
tatyana-krasnukha updated the diff for D75537: Clear all settings during a test's setUp.

Removed TestFixIts.py as those changes relate to the parent revision.

Mar 5 2020, 12:03 AM · Restricted Project

Mar 4 2020

tatyana-krasnukha committed rGa31130f6fcf2: [lldb][testsuite] Create a SBDebugger instance for each test (authored by tatyana-krasnukha).
[lldb][testsuite] Create a SBDebugger instance for each test
Mar 4 2020, 11:31 PM
tatyana-krasnukha closed D74903: [lldb][testsuite] Create a SBDebugger instance for each test.
Mar 4 2020, 11:31 PM · Restricted Project
tatyana-krasnukha updated the diff for D75537: Clear all settings during a test's setUp.

Added --all property to settings clear + added a test

Mar 4 2020, 9:32 AM · Restricted Project
tatyana-krasnukha committed rG6c17cc531f9f: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to… (authored by tatyana-krasnukha).
[lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to…
Mar 4 2020, 6:12 AM
tatyana-krasnukha committed rGb1324e74da26: [lldb][NFC] Move local variables near to their usage (authored by tatyana-krasnukha).
[lldb][NFC] Move local variables near to their usage
Mar 4 2020, 6:12 AM
tatyana-krasnukha closed D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint.
Mar 4 2020, 6:12 AM · Restricted Project

Mar 3 2020

tatyana-krasnukha updated the diff for D74903: [lldb][testsuite] Create a SBDebugger instance for each test.

Moved settings clearing to the separate patch D75537

Mar 3 2020, 9:39 AM · Restricted Project
tatyana-krasnukha added a parent revision for D75537: Clear all settings during a test's setUp: D74903: [lldb][testsuite] Create a SBDebugger instance for each test.
Mar 3 2020, 9:39 AM · Restricted Project
tatyana-krasnukha added a child revision for D74903: [lldb][testsuite] Create a SBDebugger instance for each test: D75537: Clear all settings during a test's setUp.
Mar 3 2020, 9:39 AM · Restricted Project
tatyana-krasnukha created D75537: Clear all settings during a test's setUp.
Mar 3 2020, 9:39 AM · Restricted Project
tatyana-krasnukha updated the diff for D74903: [lldb][testsuite] Create a SBDebugger instance for each test.

Clear all settings during a test's setUp

Mar 3 2020, 8:34 AM · Restricted Project
tatyana-krasnukha planned changes to D74903: [lldb][testsuite] Create a SBDebugger instance for each test.

As Pavel wrote, there are global properties that all debuggers share. That's why this approach doesn't work for me.
I'm going to add settings clear mode without arguments that will revert all the settings to their default values.

Mar 3 2020, 7:46 AM · Restricted Project
tatyana-krasnukha updated the diff for D74903: [lldb][testsuite] Create a SBDebugger instance for each test.
Mar 3 2020, 4:11 AM · Restricted Project
tatyana-krasnukha added a comment to D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint.

@jingham Is it Ok with you?

Mar 3 2020, 2:40 AM · Restricted Project

Feb 21 2020

tatyana-krasnukha added a comment to D74903: [lldb][testsuite] Create a SBDebugger instance for each test.

I like this idea and ready to implement, but I'm not aware of the reasons why the current implementation was chosen. Suppose that initializing the Debugger for each test will slow down the test-suite significantly.

Feb 21 2020, 12:32 AM · Restricted Project

Feb 20 2020

tatyana-krasnukha retitled D74903: [lldb][testsuite] Create a SBDebugger instance for each test from [lldb][test] Add two wrapper-functions to manage settings in test-suite to [lldb][test] Add two wrapper functions to manage settings in test-suite.
Feb 20 2020, 8:03 AM · Restricted Project
tatyana-krasnukha created D74903: [lldb][testsuite] Create a SBDebugger instance for each test.
Feb 20 2020, 7:45 AM · Restricted Project

Feb 18 2020

tatyana-krasnukha committed rGdb23825970b0: [lldb][test] Remove expected failure decorator from test_copy_from_dummy_target… (authored by tatyana-krasnukha).
[lldb][test] Remove expected failure decorator from test_copy_from_dummy_target…
Feb 18 2020, 4:05 AM
tatyana-krasnukha closed D74558: [lldb] Make shared_from_this-related code safer .

Closed by commit b624b7dfd087

Feb 18 2020, 3:26 AM · Restricted Project
tatyana-krasnukha closed D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor.

Closed by commit 185ef697ef5c

Feb 18 2020, 3:26 AM · Restricted Project
tatyana-krasnukha committed rG7fb06796abfd: [lldb][NFC] Remove unused parameter (authored by tatyana-krasnukha).
[lldb][NFC] Remove unused parameter
Feb 18 2020, 2:51 AM
tatyana-krasnukha committed rGb624b7dfd087: [lldb] Make shared_from_this-related code safer (authored by tatyana-krasnukha).
[lldb] Make shared_from_this-related code safer
Feb 18 2020, 2:50 AM
tatyana-krasnukha committed rG185ef697ef5c: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor (authored by tatyana-krasnukha).
[lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor
Feb 18 2020, 2:50 AM

Feb 14 2020

tatyana-krasnukha updated the diff for D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint.

Just realized that BreakpointResolverScripted::CreateImplementationIfNeeded should work when m_breakpoint == nullptr.
GetBreakpoint with assertion is not suitable here, so I pass the breakpoint as a parameter.

Feb 14 2020, 11:53 AM · Restricted Project
tatyana-krasnukha updated the diff for D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint.

Moved assertion into GetBreakpoint().

Feb 14 2020, 6:51 AM · Restricted Project

Feb 13 2020

tatyana-krasnukha committed rG21d09ccf268d: [lldb-vscode] Ensure that target matches the executable file (authored by tatyana-krasnukha).
[lldb-vscode] Ensure that target matches the executable file
Feb 13 2020, 8:43 AM
tatyana-krasnukha closed D70847: [lldb-vscode] Ensure that target matches the executable file.
Feb 13 2020, 8:42 AM · Restricted Project
tatyana-krasnukha created D74558: [lldb] Make shared_from_this-related code safer .
Feb 13 2020, 7:12 AM · Restricted Project
tatyana-krasnukha created D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint.
Feb 13 2020, 7:12 AM · Restricted Project
tatyana-krasnukha created D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor.
Feb 13 2020, 7:12 AM · Restricted Project

Feb 10 2020

tatyana-krasnukha added inline comments to D74244: [lldb] Delete register info definitions in the x86_64 ABI classes.
Feb 10 2020, 4:26 AM · Restricted Project

Jan 10 2020

tatyana-krasnukha committed rG3eea082535e2: [lldb][tests] Make it possible to expect failure for a whole category (authored by tatyana-krasnukha).
[lldb][tests] Make it possible to expect failure for a whole category
Jan 10 2020, 6:38 AM
tatyana-krasnukha closed D71906: [lldb][tests] Make it possible to expect failure for a whole category.
Jan 10 2020, 6:38 AM · Restricted Project
tatyana-krasnukha committed rGe20a3b9b6c02: [lldb][tests][NFC] Unify variable naming convention (authored by tatyana-krasnukha).
[lldb][tests][NFC] Unify variable naming convention
Jan 10 2020, 6:38 AM
tatyana-krasnukha committed rGb3af8ab7f83c: [lldb][tests] Cleanup '.categories' (authored by tatyana-krasnukha).
[lldb][tests] Cleanup '.categories'
Jan 10 2020, 5:47 AM
tatyana-krasnukha committed rG9ba151274869: [lldb][test] NFC, re-use _getTestPath() function (authored by tatyana-krasnukha).
[lldb][test] NFC, re-use _getTestPath() function
Jan 10 2020, 5:37 AM
tatyana-krasnukha committed rGe4d672971030: [lldb][tests] Take into account all parent's categories when traverse folders… (authored by tatyana-krasnukha).
[lldb][tests] Take into account all parent's categories when traverse folders…
Jan 10 2020, 5:37 AM
tatyana-krasnukha closed D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards.
Jan 10 2020, 5:36 AM · Restricted Project

Jan 9 2020

tatyana-krasnukha updated the diff for D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards.

Stop iterating when reach the top-level test folder

Jan 9 2020, 7:34 AM · Restricted Project

Jan 6 2020

tatyana-krasnukha updated the diff for D71906: [lldb][tests] Make it possible to expect failure for a whole category.

Increased number of lines of context.

Jan 6 2020, 8:31 AM · Restricted Project

Dec 26 2019

tatyana-krasnukha created D71906: [lldb][tests] Make it possible to expect failure for a whole category.
Dec 26 2019, 8:41 AM · Restricted Project
tatyana-krasnukha created D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards.
Dec 26 2019, 8:41 AM · Restricted Project
tatyana-krasnukha committed rGdb1fa62bf824: [lldb][test] Don't include "test_common.h" in the debug macros test (authored by tatyana-krasnukha).
[lldb][test] Don't include "test_common.h" in the debug macros test
Dec 26 2019, 7:54 AM
tatyana-krasnukha committed rGe2d3eb00ccd8: [lldb] Specify unsigned underlying type for an enumeration explicitly (authored by tatyana-krasnukha).
[lldb] Specify unsigned underlying type for an enumeration explicitly
Dec 26 2019, 7:54 AM
tatyana-krasnukha committed rGb0469eede285: [lldb][NFC] Move lock scope where it should begin (authored by tatyana-krasnukha).
[lldb][NFC] Move lock scope where it should begin
Dec 26 2019, 7:54 AM
tatyana-krasnukha committed rGb7c45ac35295: [lldb][NFC] Add "lldb-vscode" to all_categories (authored by tatyana-krasnukha).
[lldb][NFC] Add "lldb-vscode" to all_categories
Dec 26 2019, 7:54 AM
tatyana-krasnukha committed rG04359f48f021: [lldb][NFC] Simplify if-return (authored by tatyana-krasnukha).
[lldb][NFC] Simplify if-return
Dec 26 2019, 7:54 AM
tatyana-krasnukha committed rGa58bd0e42cf2: [lldb][tests] Platform triple can be None (authored by tatyana-krasnukha).
[lldb][tests] Platform triple can be None
Dec 26 2019, 7:54 AM
tatyana-krasnukha committed rGf57b35af2f00: [lldb][tests] Posix function strdup requires macro _POSIX_C_SOURCE (authored by tatyana-krasnukha).
[lldb][tests] Posix function strdup requires macro _POSIX_C_SOURCE
Dec 26 2019, 7:53 AM

Dec 9 2019

tatyana-krasnukha committed rGd32484f40cbe: [lldb][CMake] Fix build for the case of custom libedit installation (authored by tatyana-krasnukha).
[lldb][CMake] Fix build for the case of custom libedit installation
Dec 9 2019, 9:28 AM

Dec 5 2019

tatyana-krasnukha added inline comments to D69589: [lldb] Refactor all POST_BUILD commands into targets.
Dec 5 2019, 4:29 AM · Restricted Project

Nov 21 2019

tatyana-krasnukha committed rGffc4ff868fcc: [lldb][NFC] Remove test directory completely (authored by tatyana-krasnukha).
[lldb][NFC] Remove test directory completely
Nov 21 2019, 4:12 AM

Nov 12 2019

tatyana-krasnukha committed rG3130a88137dd: [lldb][test] Macros in expressions require DWARF 5 (authored by tatyana-krasnukha).
[lldb][test] Macros in expressions require DWARF 5
Nov 12 2019, 3:06 AM

Nov 1 2019

tatyana-krasnukha added a comment to D67227: [lldb] Extend and document TestIRInterpreter.py.

I mean, when a process is not able to allocate memory, it cannot JIT, but still can interpret. Should the test report failure in this case?

Nov 1 2019, 9:29 AM · Restricted Project
tatyana-krasnukha added a comment to D67227: [lldb] Extend and document TestIRInterpreter.py.

Another problem of the test_ir_interpreter is that it fails even when JIT fails despite it should test the interpreter.

Nov 1 2019, 7:25 AM · Restricted Project

Oct 17 2019

tatyana-krasnukha committed rG92e498d58cf4: [ARC] Add SystemV ABI (authored by tatyana-krasnukha).
[ARC] Add SystemV ABI
Oct 17 2019, 8:18 AM
tatyana-krasnukha committed rGfaf6b2543e47: [ARC] Basic support in gdb-remote process plugin (authored by tatyana-krasnukha).
[ARC] Basic support in gdb-remote process plugin
Oct 17 2019, 8:17 AM
tatyana-krasnukha closed D55724: [ARC] Add SystemV ABI.
Oct 17 2019, 8:17 AM · Restricted Project
tatyana-krasnukha closed D55718: [ARC] Basic support in gdb-remote process plugin.
Oct 17 2019, 8:17 AM · Restricted Project
tatyana-krasnukha updated the diff for D55724: [ARC] Add SystemV ABI.

Rebased on the current trunk.

Oct 17 2019, 7:58 AM · Restricted Project
tatyana-krasnukha updated the diff for D55718: [ARC] Basic support in gdb-remote process plugin.

Removed any ARC-specific logic from the ProcessGDBRemote.cpp.

Oct 17 2019, 7:49 AM · Restricted Project

Oct 15 2019

tatyana-krasnukha accepted D68858: [lldb] Creates _liblldb symlink from cmake.

Build and installation completed successfully! LGTM, though it would be good if anyone tests this with Xcode.

Oct 15 2019, 6:58 AM · Restricted Project

Oct 14 2019

tatyana-krasnukha added a comment to D68858: [lldb] Creates _liblldb symlink from cmake.

@hhb, please, take a look. Slightly changed your patch to make it work for Visual Studio.

Oct 14 2019, 11:58 AM · Restricted Project

Oct 12 2019

tatyana-krasnukha added inline comments to D68858: [lldb] Creates _liblldb symlink from cmake.
Oct 12 2019, 2:54 AM · Restricted Project

Oct 11 2019

tatyana-krasnukha added inline comments to D68719: Fix issue when building with Visual Studio.
Oct 11 2019, 6:59 AM · Restricted Project
tatyana-krasnukha abandoned D68719: Fix issue when building with Visual Studio.

Fixed by reverting the initial commit.

Oct 11 2019, 5:07 AM · Restricted Project

Oct 10 2019

tatyana-krasnukha retitled D68719: Fix issue when building with Visual Studio from Fix build with Visual Studio to Fix issue when building with Visual Studio.
Oct 10 2019, 9:18 AM · Restricted Project
tatyana-krasnukha added a comment to D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR.

Please see my comment D68719#1703785.

Oct 10 2019, 9:18 AM · Restricted Project
tatyana-krasnukha added inline comments to D68719: Fix issue when building with Visual Studio.
Oct 10 2019, 7:53 AM · Restricted Project
tatyana-krasnukha added a comment to D68719: Fix issue when building with Visual Studio.

Hi Haibo,

Oct 10 2019, 7:53 AM · Restricted Project

Oct 9 2019

tatyana-krasnukha created D68719: Fix issue when building with Visual Studio.
Oct 9 2019, 11:26 AM · Restricted Project

Oct 8 2019

tatyana-krasnukha accepted D68606: [test] Split LLDB tests into filecheck, unittest and dotest..

I have longed for this change, thank you!

Oct 8 2019, 8:07 AM · Restricted Project

Sep 26 2019

tatyana-krasnukha committed rGa11668e87b90: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP (authored by tatyana-krasnukha).
Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP
Sep 26 2019, 3:57 AM

Sep 25 2019

tatyana-krasnukha updated the diff for D67776: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP.

Removed using UnixSignals::ShouldSuppress, just check if a signal is either SIGINT or SIGSTOP.

Sep 25 2019, 6:39 AM · Restricted Project, Restricted Project
tatyana-krasnukha added a comment to D67776: Don't stop execution in batch mode when process stops with SIGINT or SIGSTOP.

To Pavel: this problem is not only about the behavior of process attach, but for process launch too (and possibly something else). That's why I'm trying to move this logic out of specific commands.

Sep 25 2019, 6:29 AM · Restricted Project, Restricted Project

Sep 24 2019

tatyana-krasnukha added inline comments to D67965: Have ABI plugins vend llvm MCRegisterInfo data.
Sep 24 2019, 10:17 AM · Restricted Project