Page MenuHomePhabricator
Feed Advanced Search

Jan 27 2021

ezhulenev accepted D95386: Fix namespace for MLIR Async Runtime.

Thanks for the cleanup!

Jan 27 2021, 4:07 AM · Restricted Project

Jan 26 2021

ezhulenev committed rG25f80e16d103: [mlir] Async: add a separate pass to lower from async to async.coro and async. (authored by ezhulenev).
[mlir] Async: add a separate pass to lower from async to async.coro and async.
Jan 26 2021, 3:33 AM
ezhulenev closed D95311: [mlir] Async: add a separate pass to lower from async to async.coro and async.runtime.
Jan 26 2021, 3:33 AM · Restricted Project
ezhulenev added a comment to D95386: Fix namespace for MLIR Async Runtime.

Ideally the library should only export __mlir_runner_destroy symbol (see https://reviews.llvm.org/D94312). Unfortunately I don't have an easy access to Windows build env, so I didn't properly cleanup exports for all symbols in that patch.

Jan 26 2021, 3:22 AM · Restricted Project
ezhulenev updated the diff for D95311: [mlir] Async: add a separate pass to lower from async to async.coro and async.runtime.

Rebased

Jan 26 2021, 2:54 AM · Restricted Project
ezhulenev committed rG2f7baffdc134: [mlir:async] Use ODS to define async types (authored by ezhulenev).
[mlir:async] Use ODS to define async types
Jan 26 2021, 2:38 AM
ezhulenev closed D95000: [mlir:async] Use ODS to define async types.
Jan 26 2021, 2:38 AM · Restricted Project

Jan 25 2021

ezhulenev committed rGd37b5393e891: [mlir:Async] Use LLVM coro operations in async.coro lowering (authored by ezhulenev).
[mlir:Async] Use LLVM coro operations in async.coro lowering
Jan 25 2021, 4:42 PM
ezhulenev closed D95405: [mlir:Async] Use LLVM coro operations in async.coro lowering.
Jan 25 2021, 4:42 PM · Restricted Project
ezhulenev updated the summary of D95405: [mlir:Async] Use LLVM coro operations in async.coro lowering.
Jan 25 2021, 3:57 PM · Restricted Project
ezhulenev retitled D95405: [mlir:Async] Use LLVM coro operations in async.coro lowering from [mlir:Async] Add intermediate async.coro and async.runtime to simplify Async to LLVM lowering to [mlir:Async] Use LLVM coro operations in async.coro lowering.
Jan 25 2021, 3:56 PM · Restricted Project
ezhulenev requested review of D95405: [mlir:Async] Use LLVM coro operations in async.coro lowering.
Jan 25 2021, 3:54 PM · Restricted Project
ezhulenev abandoned D95395: [mlir:Async] Use LLVM coro operations to lower from async.coro.
Jan 25 2021, 2:57 PM · Restricted Project
ezhulenev updated the diff for D95395: [mlir:Async] Use LLVM coro operations to lower from async.coro.

Rebase

Jan 25 2021, 2:35 PM · Restricted Project
ezhulenev updated the diff for D95395: [mlir:Async] Use LLVM coro operations to lower from async.coro.

Rebase

Jan 25 2021, 2:33 PM · Restricted Project
ezhulenev updated the summary of D95395: [mlir:Async] Use LLVM coro operations to lower from async.coro.
Jan 25 2021, 2:31 PM · Restricted Project
ezhulenev updated the summary of D95395: [mlir:Async] Use LLVM coro operations to lower from async.coro.
Jan 25 2021, 2:31 PM · Restricted Project
ezhulenev updated the summary of D95395: [mlir:Async] Use LLVM coro operations to lower from async.coro.
Jan 25 2021, 2:30 PM · Restricted Project
ezhulenev updated the diff for D95395: [mlir:Async] Use LLVM coro operations to lower from async.coro.

Rebased

Jan 25 2021, 2:28 PM · Restricted Project
ezhulenev requested review of D95395: [mlir:Async] Use LLVM coro operations to lower from async.coro.
Jan 25 2021, 2:24 PM · Restricted Project
ezhulenev committed rG9c53b8e52e05: [mlir:Async] Add intermediate async.coro and async.runtime operations to… (authored by ezhulenev).
[mlir:Async] Add intermediate async.coro and async.runtime operations to…
Jan 25 2021, 2:04 PM
ezhulenev closed D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.
Jan 25 2021, 2:04 PM · Restricted Project
ezhulenev added inline comments to D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.
Jan 25 2021, 1:55 PM · Restricted Project
ezhulenev updated the diff for D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.

Fix async ops doc

Jan 25 2021, 1:29 PM · Restricted Project
ezhulenev updated the summary of D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.
Jan 25 2021, 1:20 PM · Restricted Project
ezhulenev requested review of D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.
Jan 25 2021, 1:16 PM · Restricted Project

Jan 24 2021

ezhulenev updated the summary of D95311: [mlir] Async: add a separate pass to lower from async to async.coro and async.runtime.
Jan 24 2021, 9:43 AM · Restricted Project
ezhulenev requested review of D95311: [mlir] Async: add a separate pass to lower from async to async.coro and async.runtime.
Jan 24 2021, 9:41 AM · Restricted Project

Jan 23 2021

ezhulenev abandoned D94255: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Jan 23 2021, 3:45 AM · Restricted Project

Jan 22 2021

ezhulenev updated the diff for D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.

Use LLVM coro operations to lower from async.coro

Jan 22 2021, 3:08 PM · Restricted Project
ezhulenev committed rGcc77a2c7685a: [mlir] Add coro intrinsics operations to LLVM dialect (authored by ezhulenev).
[mlir] Add coro intrinsics operations to LLVM dialect
Jan 22 2021, 10:02 AM
ezhulenev closed D95143: [mlir] Add coro intrinsics operations to LLVM dialect.
Jan 22 2021, 10:02 AM · Restricted Project
ezhulenev added a comment to D95143: [mlir] Add coro intrinsics operations to LLVM dialect.

Have you considered putting these in a separate dialect that just uses LLVMOpBase.td, similarly to what we have for NVVM or AVX512? My general take on it is that intrinsics listed in https://llvm.org/docs/LangRef.html#intrinsic-functions can stay in the "main" dialect, but "target-specific" intrinsics are better off in separate dialects. I understand there are pros and cons of doing this, so I won't block this commit only because of it.

Jan 22 2021, 9:13 AM · Restricted Project
ezhulenev updated the diff for D95143: [mlir] Add coro intrinsics operations to LLVM dialect.

Add LLVM_i?Ptr type constraint

Jan 22 2021, 9:11 AM · Restricted Project

Jan 21 2021

ezhulenev updated the diff for D95143: [mlir] Add coro intrinsics operations to LLVM dialect.

remove dump input

Jan 21 2021, 8:58 AM · Restricted Project
ezhulenev updated the summary of D95143: [mlir] Add coro intrinsics operations to LLVM dialect.
Jan 21 2021, 8:57 AM · Restricted Project
ezhulenev requested review of D95143: [mlir] Add coro intrinsics operations to LLVM dialect.
Jan 21 2021, 8:56 AM · Restricted Project

Jan 20 2021

ezhulenev committed rGa2223b09b10a: [mlir:async] Fix data races in AsyncRuntime (authored by ezhulenev).
[mlir:async] Fix data races in AsyncRuntime
Jan 20 2021, 1:24 PM
ezhulenev closed D95037: [mlir:async] Fix data races in AsyncRuntime.
Jan 20 2021, 1:23 PM · Restricted Project
ezhulenev updated the summary of D95037: [mlir:async] Fix data races in AsyncRuntime.
Jan 20 2021, 5:22 AM · Restricted Project
ezhulenev requested review of D95037: [mlir:async] Fix data races in AsyncRuntime.
Jan 20 2021, 5:17 AM · Restricted Project

Jan 19 2021

ezhulenev updated the diff for D95000: [mlir:async] Use ODS to define async types.

Use ODS generated parser and printer

Jan 19 2021, 4:06 PM · Restricted Project
ezhulenev added a comment to D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.

Will do LLVM intrinsics in a separate change, this one is already pretty large.

Jan 19 2021, 1:44 PM · Restricted Project
ezhulenev added inline comments to D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.
Jan 19 2021, 1:43 PM · Restricted Project
ezhulenev updated the diff for D95000: [mlir:async] Use ODS to define async types.

Omit empty ins and outs

Jan 19 2021, 1:43 PM · Restricted Project
ezhulenev updated the diff for D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.

Omit empty ins and outs

Jan 19 2021, 1:43 PM · Restricted Project
ezhulenev retitled D95000: [mlir:async] Use ODS to define async types from [mlir:async] Use tablegen to define async types to [mlir:async] Use ODS to define async types.
Jan 19 2021, 1:39 PM · Restricted Project
ezhulenev requested review of D95000: [mlir:async] Use ODS to define async types.
Jan 19 2021, 1:38 PM · Restricted Project
ezhulenev added a comment to D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.

Do you have code pointers to intrinsic op definitions in the LLVM dialect? I like this idea, however I still would keep 2 levels of IR lowering, async specific async.coro (that omit a lot of irrelevant coro details) that are lowered to LLVM intrinsic ops.

Jan 19 2021, 4:39 AM · Restricted Project

Jan 18 2021

ezhulenev abandoned D83531: [MLIR] Add F32ElementsAttr to OpBase.td.
Jan 18 2021, 3:03 PM · Restricted Project
ezhulenev abandoned D92022: Revert "[mlir] Temporarily disable flaky mlir-cpu-runner async tests".
Jan 18 2021, 3:03 PM · Restricted Project
ezhulenev retitled D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering from [mlir:Async] Add intermediate async.coro and async.runtime to simplify Async to LLVM lowering to [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.
Jan 18 2021, 11:06 AM · Restricted Project
ezhulenev updated the summary of D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.
Jan 18 2021, 11:04 AM · Restricted Project
ezhulenev requested review of D94923: [mlir:Async] Add intermediate async.coro and async.runtime operations to simplify Async to LLVM lowering.
Jan 18 2021, 10:58 AM · Restricted Project

Jan 11 2021

ezhulenev accepted D94404: [mlir] Add structural conversion to async dialect lowering..
Jan 11 2021, 8:30 AM · Restricted Project

Jan 9 2021

ezhulenev committed rGbb0e621387f8: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks (authored by ezhulenev).
[mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks
Jan 9 2021, 2:40 AM
ezhulenev closed D94346: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Jan 9 2021, 2:40 AM · Restricted Project
ezhulenev updated the diff for D94346: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.

Rebased

Jan 9 2021, 2:09 AM · Restricted Project

Jan 8 2021

ezhulenev updated the summary of D94346: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Jan 8 2021, 3:24 PM · Restricted Project
ezhulenev requested review of D94346: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Jan 8 2021, 3:24 PM · Restricted Project
ezhulenev committed rG78b3bce23b11: [mlir] AsyncRuntime: disable mlir-runner init/disable for WIN32 (authored by ezhulenev).
[mlir] AsyncRuntime: disable mlir-runner init/disable for WIN32
Jan 8 2021, 2:03 PM
ezhulenev closed D94339: [mlir] AsyncRuntime: disable mlir-runner init/disable for WIN32.
Jan 8 2021, 2:03 PM · Restricted Project
ezhulenev requested review of D94339: [mlir] AsyncRuntime: disable mlir-runner init/disable for WIN32.
Jan 8 2021, 2:02 PM · Restricted Project
ezhulenev committed rG1fc986427ba3: [mlir:JitRunner] Use custom shared library init/destroy functions if available (authored by ezhulenev).
[mlir:JitRunner] Use custom shared library init/destroy functions if available
Jan 8 2021, 1:16 PM
ezhulenev closed D94312: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Jan 8 2021, 1:16 PM · Restricted Project
ezhulenev updated the summary of D94312: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Jan 8 2021, 8:57 AM · Restricted Project
ezhulenev updated the summary of D94312: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Jan 8 2021, 8:55 AM · Restricted Project
ezhulenev updated the summary of D94312: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Jan 8 2021, 8:20 AM · Restricted Project
ezhulenev requested review of D94312: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Jan 8 2021, 8:18 AM · Restricted Project
ezhulenev added a reverting change for D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available: rG740950cf1cda: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if….
Jan 8 2021, 7:47 AM · Restricted Project
ezhulenev committed rG740950cf1cda: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if… (authored by ezhulenev).
Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if…
Jan 8 2021, 7:47 AM
ezhulenev added a reverting change for rG84dc9b451bfd: [mlir:JitRunner] Use custom shared library init/destroy functions if available: rG740950cf1cda: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if….
Jan 8 2021, 7:47 AM
ezhulenev closed D94309: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if available".
Jan 8 2021, 7:46 AM · Restricted Project
ezhulenev updated the summary of D94309: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if available".
Jan 8 2021, 7:45 AM · Restricted Project
ezhulenev added a reverting change for rG84dc9b451bfd: [mlir:JitRunner] Use custom shared library init/destroy functions if available: D94309: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if available".
Jan 8 2021, 7:44 AM
ezhulenev added a reverting change for D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available: D94309: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if available".
Jan 8 2021, 7:44 AM · Restricted Project
ezhulenev requested review of D94309: Revert "[mlir:JitRunner] Use custom shared library init/destroy functions if available".
Jan 8 2021, 7:44 AM · Restricted Project
ezhulenev committed rG84dc9b451bfd: [mlir:JitRunner] Use custom shared library init/destroy functions if available (authored by ezhulenev).
[mlir:JitRunner] Use custom shared library init/destroy functions if available
Jan 8 2021, 7:14 AM
ezhulenev closed D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Jan 8 2021, 7:14 AM · Restricted Project
ezhulenev added inline comments to D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Jan 8 2021, 7:12 AM · Restricted Project
ezhulenev updated the diff for D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available.

Export only mlir runner API symbols

Jan 8 2021, 3:14 AM · Restricted Project

Jan 7 2021

ezhulenev updated the summary of D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Jan 7 2021, 3:33 PM · Restricted Project
ezhulenev requested review of D94270: [mlir:JitRunner] Use custom shared library init/destroy functions if available.
Jan 7 2021, 3:31 PM · Restricted Project
ezhulenev abandoned D94253: [mlir] mlir-cpu-runner: Register shutdown callbacks with the runner.

Yeah, makes sense, also weak linking does not seem to work with MSVC, will try to the dlsym approach.

Jan 7 2021, 12:53 PM · Restricted Project
ezhulenev updated the diff for D94253: [mlir] mlir-cpu-runner: Register shutdown callbacks with the runner.

Fix CMakeLists

Jan 7 2021, 12:27 PM · Restricted Project
ezhulenev updated the summary of D94255: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Jan 7 2021, 12:24 PM · Restricted Project
ezhulenev requested review of D94255: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Jan 7 2021, 12:22 PM · Restricted Project
ezhulenev updated the diff for D94253: [mlir] mlir-cpu-runner: Register shutdown callbacks with the runner.

Remove extra space

Jan 7 2021, 11:58 AM · Restricted Project
ezhulenev updated the summary of D94253: [mlir] mlir-cpu-runner: Register shutdown callbacks with the runner.
Jan 7 2021, 11:57 AM · Restricted Project
ezhulenev requested review of D94253: [mlir] mlir-cpu-runner: Register shutdown callbacks with the runner.
Jan 7 2021, 11:56 AM · Restricted Project

Jan 6 2021

ezhulenev abandoned D93905: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.

Judging by the build failures this still does not work. Will work on a "mlir-cpu-runner dylib unloading" in a separate PR.

Jan 6 2021, 1:55 AM · Restricted Project

Dec 29 2020

ezhulenev updated the summary of D93905: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Dec 29 2020, 10:23 AM · Restricted Project
ezhulenev requested review of D93905: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Dec 29 2020, 10:20 AM · Restricted Project
ezhulenev added a comment to D92368: [mlir] AsyncRuntime: disable threading until test flakiness is fixed.

Since it surfaced on our radar again, any updated on the global destructors removal?

Dec 29 2020, 8:54 AM · Restricted Project

Dec 25 2020

ezhulenev committed rG61422c8b661c: [mlir] Async: add support for lowering async value operands to LLVM (authored by ezhulenev).
[mlir] Async: add support for lowering async value operands to LLVM
Dec 25 2020, 2:25 AM
ezhulenev closed D93598: [mlir] Async: add support for lowering async value operands to LLVM.
Dec 25 2020, 2:25 AM · Restricted Project
ezhulenev committed rG621ad468d99d: [mlir] Async: lowering async.value to LLVM (authored by ezhulenev).
[mlir] Async: lowering async.value to LLVM
Dec 25 2020, 2:24 AM
ezhulenev closed D93592: [mlir] Async: lowering async.value to LLVM.
Dec 25 2020, 2:24 AM · Restricted Project
ezhulenev accepted D93808: [mlir] Fix mlir_async_runtime.lib creation for MSVC..
Dec 25 2020, 2:19 AM · Restricted Project

Dec 24 2020

ezhulenev updated the diff for D93592: [mlir] Async: lowering async.value to LLVM.

Add missing targets to CMakeLists

Dec 24 2020, 5:08 AM · Restricted Project