Page MenuHomePhabricator
Feed Advanced Search

Jun 14 2021

Herald added a reviewer for D70621: Add __default_init_tag to basic_string constructors: Restricted Project.

This change introduced an MSAN error https://bugs.llvm.org/show_bug.cgi?id=50112

Jun 14 2021, 2:42 PM · Restricted Project

Apr 9 2021

nick updated the diff for D69000: [clang-tidy] new check: modernize-deprecated-iterator-base.

Rebased. Now using native cxxBaseSpecifier and hasDirectBase.

Apr 9 2021, 11:46 AM · Restricted Project, Restricted Project

Apr 3 2021

nick added a comment to D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).

What name/email should I use for the commit?

Apr 3 2021, 12:52 PM · Restricted Project

Mar 28 2021

nick added inline comments to D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).
Mar 28 2021, 11:34 AM · Restricted Project
nick updated the diff for D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).

@nick Sorry that getting these changes merged takes so long.

@njames93 If you have an alternative way forward, please let us know what it is.

Otherwise, this LGTM too and we should merge it soon unless there are objections which haven't been addressed.

Mar 28 2021, 11:31 AM · Restricted Project

Mar 22 2021

nick added a comment to D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info.

Is this hack actually needed? I could not reproduce a problem with https://bugs.chromium.org/p/chromium/issues/detail?id=860398#c13 repro, the breakpoint fires for me and I see the variable.

Mar 22 2021, 2:32 PM · Restricted Project
nick added a comment to D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info.
In D99107#2642451, @rnk wrote:

We try to uphold the invariant that -g flags do not affect generated code, so I don't think we should do this.

Mar 22 2021, 1:57 PM · Restricted Project
nick requested review of D99107: [clang][CodeGen] Do not emit NVRO debug helper when not emitting debug info.
Mar 22 2021, 12:59 PM · Restricted Project

Mar 21 2021

nick added inline comments to D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).
Mar 21 2021, 6:18 PM · Restricted Project
nick added a comment to D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).

Could you please commit the patch for me? I do not have commit rights.

Mar 21 2021, 12:57 PM · Restricted Project
nick updated the diff for D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).

Lint fixes

Mar 21 2021, 6:47 AM · Restricted Project
nick added inline comments to D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).
Mar 21 2021, 6:39 AM · Restricted Project

Mar 19 2021

nick updated the diff for D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).

Forgot to remove a duplicated test

Mar 19 2021, 11:30 AM · Restricted Project
nick updated the diff for D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).

Rebased. Removed things reimplemented and landed in D81552 + D79063.

Mar 19 2021, 11:15 AM · Restricted Project

Aug 19 2020

nick added a comment to rG1cbdf932b41e: PR46231: Promote diagnostic for 'template<...>;' from ExtWarn to Error..

FYI: this breaks some msvc compatibility

template <class> class X {};
template X<int>;
Aug 19 2020, 10:11 AM

Jun 24 2020

nick added inline comments to D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body..
Jun 24 2020, 4:52 PM · Restricted Project
nick added a comment to D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body..

Thanks @zequanwu, much appreciated.

Jun 24 2020, 5:22 AM · Restricted Project

Jun 23 2020

nick added a comment to D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function.

We didn't see it in the code bases I work with, so is boost a special case, or an example of a common practice?

Jun 23 2020, 5:16 PM · Restricted Project
nick added a comment to D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function.

I feel like doing interprocedural analysis for this is overkill. What is the benefit of boost::ignore_unused(foo); rather than the more common (void) foo;? Any examples?

Jun 23 2020, 9:37 AM · Restricted Project

Jun 22 2020

nick added a comment to D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function.

This warning can be turned off by the flag -Wno-uninitialized-const-reference.

Jun 22 2020, 4:40 PM · Restricted Project
nick added a comment to D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function.

This diagnostic bring headaches because frequently -Wunused-variable suppression is done via no-op pseudo-consuming function like [boost::ignore_unused](https://www.boost.org/doc/libs/1_73_0/libs/core/doc/html/core/ignore_unused.html). Particularly, it fires in Boost here https://github.com/boostorg/concept_check/blob/e69c81326d5a4359ac53f9c6fe53fc2baf24df50/include/boost/concept_check.hpp#L135-L141.
Is it possible to make the diagnostic not fire for empty body consuming functions?

Jun 22 2020, 3:03 PM · Restricted Project

Jun 10 2020

nick added inline comments to D80867: [x86] form reduction intrinsics over raw IR.
Jun 10 2020, 3:39 PM · Restricted Project

May 26 2020

nick added inline comments to D79063: [ASTMatchers] Matchers related to C++ inheritance.
May 26 2020, 5:28 PM · Restricted Project

Apr 24 2020

nick added inline comments to D71214: [libc++] reduce <complex> parsing time.
Apr 24 2020, 11:20 AM · Restricted Project

Jan 29 2020

nick added a comment to D71214: [libc++] reduce <complex> parsing time.

No, I do not have commit rights.

Jan 29 2020, 5:18 PM · Restricted Project

Jan 13 2020

nick added a comment to D72643: [InstCombine] form copysign from select of FP constants (PR44153).

I cannot be a reviewer, just added some dummies questions. And, @spatel, thanks for working on this!

Jan 13 2020, 2:30 PM · Restricted Project

Dec 9 2019

nick created D71214: [libc++] reduce <complex> parsing time.
Dec 9 2019, 9:56 AM · Restricted Project

Nov 12 2019

Herald added a reviewer for D59035: [X86] Promote i8 CMOV's (PR40965): mclow.lists.
Nov 12 2019, 10:00 AM · Restricted Project, Restricted Project

Oct 20 2019

nick updated the diff for D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).

Fixed typo.

Oct 20 2019, 7:21 AM · Restricted Project

Oct 19 2019

nick updated the diff for D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).

Regenerated the docs, added more tests.

Oct 19 2019, 3:23 PM · Restricted Project
nick created D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).
Oct 19 2019, 2:00 PM · Restricted Project

Oct 15 2019

nick added inline comments to D69000: [clang-tidy] new check: modernize-deprecated-iterator-base.
Oct 15 2019, 4:50 PM · Restricted Project, Restricted Project
nick updated the diff for D69000: [clang-tidy] new check: modernize-deprecated-iterator-base.

Addressed comments.

Oct 15 2019, 4:41 PM · Restricted Project, Restricted Project
nick created D69000: [clang-tidy] new check: modernize-deprecated-iterator-base.
Oct 15 2019, 10:48 AM · Restricted Project, Restricted Project