Thanks
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Mon, Jun 20
Mon, Jun 20
Wed, Jun 15
Wed, Jun 15
Could someone push it for me, Please!
Apply suggestions from reviewer
MehdiChinoune retitled D125263: [CMake][MSVC] Compile with `/permissive-` from [CMake][MSVC] Use `/permissive-` as MSVC equivalent to `-pedantic` to [CMake][MSVC] Compile with `/permissive-`.
Address review comment
Sat, Jun 11
Sat, Jun 11
ping!
Sun, Jun 5
Sun, Jun 5
MehdiChinoune added inline comments to D127025: [flang][runtime] Use __float128 where possible & needed in runtime.
Fri, Jun 3
Fri, Jun 3
> Does LLVM build successfully with /permissive-?
Yes, It does. You could check the windows build yourself
There was a failure with flang that we fixed it.
ping!
May 25 2022
May 25 2022
May 24 2022
May 24 2022
Thanks.
May 19 2022
May 19 2022
In D125262#3525059, @Meinersbur wrote:LGTM
May 13 2022
May 13 2022
In D125262#3512790, @Meinersbur wrote:Please add a summary where you mention that CLOCK_REALTIME is POSIX defined and never available with msvc, even without /permissive-. The difference is that the template is never instantiated and the compiler ignores the undefined identifier.
May 11 2022
May 11 2022
This is the error message:
[6795/8382] Building CXX object tools\flang\runtime\CMakeFiles\obj.FortranRuntime.dir\time-intrinsic.cpp.obj FAILED: tools/flang/runtime/CMakeFiles/obj.FortranRuntime.dir/time-intrinsic.cpp.obj sccache C:\BuildTools\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x64\cl.exe /nologo /TP -DBUILD_EXAMPLES -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\flang\runtime -IC:\ws\w3\llvm-project\premerge-checks\flang\runtime -IC:\ws\w3\llvm-project\premerge-checks\flang\include -Itools\flang\include -Iinclude -IC:\ws\w3\llvm-project\premerge-checks\llvm\include -IC:\ws\w3\llvm-project\premerge-checks\llvm\..\mlir\include -Itools\mlir\include -Itools\clang\include -IC:\ws\w3\llvm-project\premerge-checks\llvm\..\clang\include /DWIN32 /D_WINDOWS /Zc:inline /Zc:__cplusplus /Zc:strictStrings /Oi /Zc:rvalueCast /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2 -UNDEBUG -std:c++17 /EHs-c- /GR- /showIncludes /Fotools\flang\runtime\CMakeFiles\obj.FortranRuntime.dir\time-intrinsic.cpp.obj /Fdtools\flang\runtime\CMakeFiles\obj.FortranRuntime.dir\ /FS -c C:\ws\w3\llvm-project\premerge-checks\flang\runtime\time-intrinsic.cpp C:\ws\w3\llvm-project\premerge-checks\flang\runtime\time-intrinsic.cpp(77): error C2065: 'CLOCK_REALTIME': undeclared identifier C:\ws\w3\llvm-project\premerge-checks\flang\runtime\time-intrinsic.cpp(77): error C3861: 'CLOCK_REALTIME': identifier not found C:\ws\w3\llvm-project\premerge-checks\flang\runtime\time-intrinsic.cpp(146): error C2065: 'CLOCK_REALTIME': undeclared identifier C:\ws\w3\llvm-project\premerge-checks\flang\runtime\time-intrinsic.cpp(146): error C3861: 'CLOCK_REALTIME': identifier not found
May 10 2022
May 10 2022
In D125262#3504589, @Meinersbur wrote:Patch summary missing. What is failing with /permissive-?
MehdiChinoune added a reviewer for D125262: [flang][MSVC] Fix building with `/permissive-` flag: Meinersbur.
May 9 2022
May 9 2022
Apr 7 2022
Apr 7 2022
In D122523#3433643, @mstorsjo wrote:@MehdiChinoune can you provide your preferred form of the git author line, Real Name <email@address>?
Apr 6 2022
Apr 6 2022
Apr 3 2022
Apr 3 2022
Could someone push it for me, Please.
Mar 25 2022
Mar 25 2022
Herald added a project to D110172: [lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO: Restricted Project.
This commit make building standalone LLDB impossible on Windows. llvm/Config/config.h file is only generated at build-time and not get installed with llvm.
Please Fix it.
Dec 13 2021
Dec 13 2021
MehdiChinoune added inline comments to D115569: [flang] Use `GNUInstallDirs` to support custom installation dirs..
MehdiChinoune added inline comments to D115569: [flang] Use `GNUInstallDirs` to support custom installation dirs..
Nov 24 2021
Nov 24 2021
Nov 24 2021, 11:00 PM · Restricted Project
Sep 15 2021
Sep 15 2021
MehdiChinoune added a project to D100897: [flang] Make 'team_number()' an intrinsic function: Restricted Project.
MehdiChinoune added a project to D108057: [Flang] Add compiled python modules to .gitignore: Restricted Project.
MehdiChinoune added a project to D109547: [flang] Add runtime interface for NUM_IMAGES: Restricted Project.
Sep 15 2021, 11:48 AM · Restricted Project
MehdiChinoune added a project to D108059: [flang] Make 'this_image()' an intrinsic function: Restricted Project.
May 7 2021
May 7 2021
In D101842#2744348, @awarzynski wrote:Address PR comments
Thank you for taking a look @Meinersbur. It sounds that instead of updating LLVM_ENABLE_PROJECTS, it will be better to generate an error when Clang is missing. What do you think?
Apr 20 2021
Apr 20 2021
In D100442#2702575, @ashermancinelli wrote:In D100442#2693549, @MehdiChinoune wrote:Could someone push this change p, please.
Do you have an email I can use for the commit author?
Apr 15 2021
Apr 15 2021
Could someone push this change p, please.
Apr 14 2021
Apr 14 2021
MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Update diff
MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
MehdiChinoune added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
MehdiChinoune added a comment to D96069: [flang][msvc] Fix compilation of external-hello-world test with MSVC..
In D96069#2687939, @Meinersbur wrote:Sorry for the wait. Patch LGTM.
Would you like me to push it top main?
Apr 13 2021
Apr 13 2021
Apr 10 2021
Apr 10 2021
MehdiChinoune added a comment to D96069: [flang][msvc] Fix compilation of external-hello-world test with MSVC..
Ping
Apr 4 2021
Apr 4 2021
MehdiChinoune added a comment to D99835: [flang][MSVC] Fix compilation of external-hello-world test with MSVC..
In D99835#2668075, @clementval wrote:In D99835#2667872, @MehdiChinoune wrote:In D99835#2667759, @Meinersbur wrote:Could you please update D96069 instead?
I lost access to my old account.
You can take control of the patch with your new account with the “Commandeer revision” action.
MehdiChinoune updated the diff for D96069: [flang][msvc] Fix compilation of external-hello-world test with MSVC..
Apr 3 2021
Apr 3 2021
MehdiChinoune added a comment to D99835: [flang][MSVC] Fix compilation of external-hello-world test with MSVC..
In D99835#2667759, @Meinersbur wrote:Could you please update D96069 instead?
Apr 2 2021
Apr 2 2021
MehdiChinoune added a comment to D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.
I don't see any other error for now.
MehdiChinoune added a comment to D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.
It works
MehdiChinoune added a comment to D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.
I get this error:
D:\dev\llvm-project\flang\runtime\reduction.cpp(95): error C2059: syntax error: 'template'
D:\dev\llvm-project\flang\runtime\reduction.cpp(404): note: see reference to function template instantiation 'signed char Fortran::runtime::GetTotalReduction<Fortran::common::TypeCategory::Integer,1,Fortran::runtime::IntegerSumAccumulator<int>>(const Fortran::runtime::Descriptor &,const char *,int,int,const Fortran::runtime::Descriptor *,ACCUMULATOR &&,const char *)' being compiled
with
[
ACCUMULATOR=Fortran::runtime::IntegerSumAccumulator<int>
]Could you fix it?
MehdiChinoune added a comment to D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.
It would be better if you exclude int128 intrinsic functions introduced in D99764
Other issues with MSVC:
1 - MSVC doesn't have __uint128 and __int128.
MSVC doesn't accept that portable Int128 type defined in uint128.h to be linked with a C function.
Maybe you should disable int128 intrinsic functions on the platforms where __unit128 and __int128 are not available
This commit breaks Building on MSVC.