Page MenuHomePhabricator
Feed Advanced Search

Fri, Oct 18

xbolva00 added a comment to D68930: [InstCombine] Shift amount reassociation in shifty sign bit test (PR43595).

I don't think the intent was to disrespect whatever code this pattern showed up in, but to ask if there are any stats for common clang benchmarks. That's the only way we can draw a line on these kinds of decisions. Every pattern is presumably showing up somewhere real for someone, so we can't distinguish where it belongs just based on existence.

Fri, Oct 18, 2:41 PM · Restricted Project
xbolva00 added a comment to D68930: [InstCombine] Shift amount reassociation in shifty sign bit test (PR43595).

sadly i'm still seeing regressions (although smaller!) in target benchmark, and analysis of IR points to *this* missing pattern

Fri, Oct 18, 10:48 AM · Restricted Project
xbolva00 added a reviewer for D68930: [InstCombine] Shift amount reassociation in shifty sign bit test (PR43595): vsk.
Fri, Oct 18, 10:48 AM · Restricted Project
xbolva00 added reviewers for D69086: [IR] Fix mayReadFromMemory() for writeonly calls: hfinkel, jdoerfert.
Fri, Oct 18, 2:40 AM · Restricted Project
xbolva00 updated subscribers of D66576: [Regalloc][WIP] Increase CSR cost in RegAllocGreedy to favour splitting/spill over CSR first use.

I can.. but next week.

Fri, Oct 18, 2:29 AM · Restricted Project

Thu, Oct 17

xbolva00 added a comment to D67502: [InstSimplify] simplifyUnsignedRangeCheck(): '(a+b) </>= c &&/|| (a+b) ==/!= 0' if we known 'c' is 'a' or 'b' and is non-zero (PR43259).

Status of this patch?

Thu, Oct 17, 2:46 PM · Restricted Project
xbolva00 added inline comments to D69139: [Types] Define a changeBitWidth for Types and make use of it..
Thu, Oct 17, 2:46 PM · Restricted Project
xbolva00 added a comment to D69127: [DAGCombiner] widen zext of popcount based on target support.

Looks good

Thu, Oct 17, 11:40 AM · Restricted Project
xbolva00 added a comment to D57779: [SLP] Add support for throttling..

This should be ready for trunk, no?

Thu, Oct 17, 5:35 AM
xbolva00 added a comment to D68377: [Builtins] Teach Clang about memccpy.

Ping @aaron.ballman

Thu, Oct 17, 5:26 AM · Restricted Project

Wed, Oct 16

xbolva00 added inline comments to rGd4346584fa35: [IndVars] Fix a miscompile in off-by-default loop predication implementation.
Wed, Oct 16, 1:19 PM

Tue, Oct 15

xbolva00 added a comment to D68089: [InstCombine] Optimize some memccpy calls to memcpy/null.

Ping

Tue, Oct 15, 4:41 PM · Restricted Project
xbolva00 added inline comments to D68956: [IndVars] Fix a miscompile in off-by-default loop predication implementation.
Tue, Oct 15, 11:07 AM · Restricted Project

Mon, Oct 14

xbolva00 added inline comments to D63382: [InstCombine] fold a shifted zext to a select.
Mon, Oct 14, 5:19 PM · Restricted Project
xbolva00 added inline comments to D68956: [IndVars] Fix a miscompile in off-by-default loop predication implementation.
Mon, Oct 14, 3:28 PM · Restricted Project
xbolva00 added inline comments to D68956: [IndVars] Fix a miscompile in off-by-default loop predication implementation.
Mon, Oct 14, 3:28 PM · Restricted Project
xbolva00 accepted D63382: [InstCombine] fold a shifted zext to a select.

LG

Mon, Oct 14, 2:31 PM · Restricted Project
xbolva00 added a comment to D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer.

Yeah, you probably want to run it multiple times.

Mon, Oct 14, 2:36 AM · Restricted Project

Sun, Oct 13

xbolva00 added a comment to D68907: [6/7/trunk] -fno-plt generates wrong relocation for std::ios_base::Init leading to segmentation fault.

Please add a test and clang-format your patch.

Sun, Oct 13, 7:52 AM · Restricted Project
xbolva00 added a comment to rG612c260ec3fe: Reland "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt….

Can you reland it? Seems like it was reverted..

Sun, Oct 13, 7:52 AM
xbolva00 added a comment to D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length.

typedef SIZE_TYPE size_t;

Sun, Oct 13, 4:09 AM · Restricted Project, Restricted Project

Sat, Oct 12

xbolva00 added inline comments to rG76cdcf25b883: [LoopIdiomRecognize] Recommit: BCmp loop idiom recognition.
Sat, Oct 12, 9:15 AM
xbolva00 added a reviewer for D68913: Adds fixit hints to the Wrange-loop-analysis: aaron.ballman.
Sat, Oct 12, 9:15 AM · Restricted Project

Fri, Oct 11

xbolva00 added a comment to D66576: [Regalloc][WIP] Increase CSR cost in RegAllocGreedy to favour splitting/spill over CSR first use.

Do you have numbers also for x86?

Fri, Oct 11, 3:22 AM · Restricted Project

Thu, Oct 10

xbolva00 added a comment to D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0.

I am fine with your suggestion to restrict it like you said.

Thu, Oct 10, 1:46 PM · Restricted Project
xbolva00 added inline comments to D68720: Support -fstack-clash-protection for x86.
Thu, Oct 10, 12:09 PM · Restricted Project, Restricted Project
xbolva00 added inline comments to D68819: [Utils] Allow update_test_checks to check function arguments.
Thu, Oct 10, 11:59 AM · Restricted Project
xbolva00 reclaimed D68377: [Builtins] Teach Clang about memccpy.

(still interested in this patch)

Thu, Oct 10, 10:43 AM · Restricted Project
xbolva00 added a comment to D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0.

BTW, we transform snprintf(d, s, "%s" , ...) into two calls - memcpy + strlen - and nobody is concerned about code size increase anyway.

Thu, Oct 10, 10:42 AM · Restricted Project
xbolva00 reclaimed D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0.
Thu, Oct 10, 10:42 AM · Restricted Project
xbolva00 added inline comments to D68814: [LV] Allow assume calls in predicated blocks..
Thu, Oct 10, 10:04 AM · Restricted Project

Wed, Oct 9

xbolva00 added inline comments to D66840: docs/DeveloperPolicy: Add instructions for requesting GitHub commit access.
Wed, Oct 9, 11:14 PM · Restricted Project
xbolva00 abandoned D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0.

This transformation seems to increase code size significantly. Is the snprintf "%s" pattern common enough? I suspect most projects have already used memccpy, stpncpy, strscpy, or strlcpy. For the few that don't, the performance probably does not matter.

Wed, Oct 9, 11:14 PM · Restricted Project
xbolva00 abandoned D68377: [Builtins] Teach Clang about memccpy.
Wed, Oct 9, 11:14 PM · Restricted Project
xbolva00 added a comment to D68720: Support -fstack-clash-protection for x86.

Please add info about this new feature to release notes

Wed, Oct 9, 5:17 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D66604: [GVN] AnalyzeLoadAvailability: Replace a load after lifetime.end with undef (PR20811).

@fhahn , is it fine for you?

Wed, Oct 9, 4:12 PM · Restricted Project
xbolva00 added a comment to D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0.

Oh, I think the proposed transformation in that paper is incorrect.

It should rather be:
memccpy(d,s,0, n-1)
d[n-1] = 0

Since "A terminating null character is automatically appended after the content written." (snprintf)

Wed, Oct 9, 4:12 PM · Restricted Project
xbolva00 added a comment to D68089: [InstCombine] Optimize some memccpy calls to memcpy/null.

ping

Wed, Oct 9, 4:12 PM · Restricted Project
xbolva00 accepted D68189: [InstCombine] recognize popcount implemented in hacker's delight..

Ok for me

Wed, Oct 9, 1:41 PM · Restricted Project
xbolva00 added a comment to D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer.
Wed, Oct 9, 1:28 PM · Restricted Project
xbolva00 added a comment to D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer.

dereferenceable attribute is not added to the arguments?

Wed, Oct 9, 8:26 AM · Restricted Project
xbolva00 added a comment to D68667: [SLP] respect target register width for GEP vectorization (PR43578).

Yes, I will do.

Wed, Oct 9, 5:25 AM · Restricted Project
xbolva00 added a comment to D68667: [SLP] respect target register width for GEP vectorization (PR43578).

Generally, I think there are more bugs for -march=haswell. Only in rare cases the perf of binaries with -march=haswell is better than plain -O3.
I tried this patch with zstd but nothing improved.

Wed, Oct 9, 3:05 AM · Restricted Project
xbolva00 added a comment to D68667: [SLP] respect target register width for GEP vectorization (PR43578).

I can confirm that h264 benchmark is now atleast as good as plain -O3.

Wed, Oct 9, 2:47 AM · Restricted Project

Tue, Oct 8

xbolva00 added a comment to D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros.

Shouldn't __GNUG__ match __GNUC__?

Tue, Oct 8, 5:14 PM · Restricted Project
xbolva00 added a comment to D57779: [SLP] Add support for throttling..

@ABataev - any comments?

Tue, Oct 8, 4:46 PM
xbolva00 added a comment to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].

Here you can find benchmarks if you want measure this new code a bit.

Tue, Oct 8, 4:52 AM · Restricted Project
xbolva00 added a comment to D68189: [InstCombine] recognize popcount implemented in hacker's delight..

Thanks, new patch looks great.

Tue, Oct 8, 4:43 AM · Restricted Project

Mon, Oct 7

xbolva00 committed rGaaea76ba0230: [Diagnostics] Emit better -Wbool-operation's warning message if we known that… (authored by xbolva00).
[Diagnostics] Emit better -Wbool-operation's warning message if we known that…
Mon, Oct 7, 10:21 PM
xbolva00 committed rL373973: [Diagnostics] Emit better -Wbool-operation's warning message if we known that….
[Diagnostics] Emit better -Wbool-operation's warning message if we known that…
Mon, Oct 7, 10:21 PM
xbolva00 added a comment to D68377: [Builtins] Teach Clang about memccpy.

Current solution does not work
/home/xbolva00/LLVM/llvm/tools/clang/include/clang/Basic/Builtins.h:50:34: error: redefinition of ‘BImemccpy’
#define BUILTIN(ID, TYPE, ATTRS) BI##ID,

^

/home/xbolva00/LLVM/llvm/tools/clang/include/clang/Basic/Builtins.h:50:34: note: in definition of macro ‘BUILTIN’
#define BUILTIN(ID, TYPE, ATTRS) BI##ID,

Mon, Oct 7, 3:25 PM · Restricted Project
xbolva00 added a comment to D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers.

@tkanis wrote in post commit review:

Mon, Oct 7, 9:06 AM · Restricted Project

Sun, Oct 6

xbolva00 added a comment to D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").

Do you plan to land it?

Sun, Oct 6, 1:51 PM · Restricted Project
xbolva00 added a comment to D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.

Could this patch solve https://bugs.llvm.org/show_bug.cgi?id=43573?

Sun, Oct 6, 1:51 PM · Restricted Project
xbolva00 updated subscribers of D68377: [Builtins] Teach Clang about memccpy.

Hm,
Maybe we have a bug in LLVM's TLI? TLI says Win32 has no memccpy.
https://llvm.org/doxygen/TargetLibraryInfo_8cpp_source.html line 333

Sun, Oct 6, 12:41 PM · Restricted Project
xbolva00 updated the diff for D68377: [Builtins] Teach Clang about memccpy.

Added it for msvc too.

Sun, Oct 6, 12:37 PM · Restricted Project
xbolva00 updated the diff for D68377: [Builtins] Teach Clang about memccpy.

Added some tests

Sun, Oct 6, 12:27 PM · Restricted Project
xbolva00 added a comment to D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers.

I think I saw some false positives with char buffers, so I am not against this patch personally.

Sun, Oct 6, 7:38 AM · Restricted Project

Sat, Oct 5

xbolva00 added a comment to D68421: Add tests for LKK algorithm.

Commited on your behalf. Now you can rebase your patch https://reviews.llvm.org/D68360.

Sat, Oct 5, 7:37 AM · Restricted Project
xbolva00 committed rG41c934acaf85: [SelectionDAG] Add tests for LKK algorithm (authored by xbolva00).
[SelectionDAG] Add tests for LKK algorithm
Sat, Oct 5, 7:29 AM
xbolva00 committed rL373830: [SelectionDAG] Add tests for LKK algorithm.
[SelectionDAG] Add tests for LKK algorithm
Sat, Oct 5, 7:28 AM
xbolva00 closed D68421: Add tests for LKK algorithm.
Sat, Oct 5, 7:28 AM · Restricted Project
xbolva00 added a comment to D68421: Add tests for LKK algorithm.

Do you have a commit access? Or should somebody land your tests?

Sat, Oct 5, 6:53 AM · Restricted Project
xbolva00 committed rG83b81c1f6ee8: [Diagnostics] Highlight expr's source range for -Wbool-operation (authored by xbolva00).
[Diagnostics] Highlight expr's source range for -Wbool-operation
Sat, Oct 5, 6:31 AM
xbolva00 committed rL373828: [Diagnostics] Highlight expr's source range for -Wbool-operation.
[Diagnostics] Highlight expr's source range for -Wbool-operation
Sat, Oct 5, 6:26 AM
xbolva00 committed rG3acc649b86fc: [NFCI] Slightly improve warning message (authored by xbolva00).
[NFCI] Slightly improve warning message
Sat, Oct 5, 1:08 AM
xbolva00 committed rL373818: [NFCI] Slightly improve warning message.
[NFCI] Slightly improve warning message
Sat, Oct 5, 1:07 AM
xbolva00 committed rG559265c8daf7: [Diagnostics] Use Expr::isKnownToHaveBooleanValue() to check bitwise negation… (authored by xbolva00).
[Diagnostics] Use Expr::isKnownToHaveBooleanValue() to check bitwise negation…
Sat, Oct 5, 1:02 AM
xbolva00 committed rL373817: [Diagnostics] Use Expr::isKnownToHaveBooleanValue() to check bitwise negation….
[Diagnostics] Use Expr::isKnownToHaveBooleanValue() to check bitwise negation…
Sat, Oct 5, 1:01 AM

Fri, Oct 4

xbolva00 accepted D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers.

I think this is reasonable change.

Fri, Oct 4, 5:55 PM · Restricted Project
xbolva00 accepted D68482: [clang] fix a typo from r372531.

Thank you

Fri, Oct 4, 1:50 PM · Restricted Project, Restricted Project
xbolva00 added inline comments to D68377: [Builtins] Teach Clang about memccpy.
Fri, Oct 4, 1:11 PM · Restricted Project
xbolva00 added inline comments to D68377: [Builtins] Teach Clang about memccpy.
Fri, Oct 4, 12:54 PM · Restricted Project
xbolva00 updated the summary of D68377: [Builtins] Teach Clang about memccpy.
Fri, Oct 4, 12:40 PM · Restricted Project
xbolva00 added inline comments to D68377: [Builtins] Teach Clang about memccpy.
Fri, Oct 4, 12:40 PM · Restricted Project
xbolva00 added inline comments to D68377: [Builtins] Teach Clang about memccpy.
Fri, Oct 4, 12:36 PM · Restricted Project
xbolva00 added inline comments to D68377: [Builtins] Teach Clang about memccpy.
Fri, Oct 4, 12:26 PM · Restricted Project
xbolva00 committed rG5e851ad6c153: [NFCI] Improve the -Wbool-operation's warning message (authored by xbolva00).
[NFCI] Improve the -Wbool-operation's warning message
Fri, Oct 4, 5:57 AM
xbolva00 committed rL373743: [NFCI] Improve the -Wbool-operation's warning message.
[NFCI] Improve the -Wbool-operation's warning message
Fri, Oct 4, 5:57 AM
xbolva00 added a comment to rL373614: [Diagnostics] Bitwise negation of a boolean expr always evaluates to true; warn….

Yeah, I need to change a wording a bit.

Fri, Oct 4, 5:05 AM
xbolva00 accepted D68421: Add tests for LKK algorithm.

Please commit tests

Fri, Oct 4, 3:23 AM · Restricted Project

Thu, Oct 3

xbolva00 added a comment to D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0.

I'm not sure this optimisation should be done for freestanding mode though.

Thu, Oct 3, 4:45 PM · Restricted Project
xbolva00 added a comment to D68089: [InstCombine] Optimize some memccpy calls to memcpy/null.

Any more comments here?

Thu, Oct 3, 3:33 PM · Restricted Project
xbolva00 added inline comments to D68377: [Builtins] Teach Clang about memccpy.
Thu, Oct 3, 3:08 PM · Restricted Project
xbolva00 added a comment to D68377: [Builtins] Teach Clang about memccpy.

It is not very obvious for me what kind of test should be done here. I would be grateful if you could show me an example in tree.

Thu, Oct 3, 12:50 PM · Restricted Project
xbolva00 committed rGe83309e02a26: [NFC] Added missing changes for rL373614 (authored by xbolva00).
[NFC] Added missing changes for rL373614
Thu, Oct 3, 8:26 AM
xbolva00 committed rL373616: [NFC] Added missing changes for rL373614.
[NFC] Added missing changes for rL373614
Thu, Oct 3, 8:26 AM
xbolva00 committed rGb4ee523ffc96: [Diagnostics] Bitwise negation of a boolean expr always evaluates to true; warn… (authored by xbolva00).
[Diagnostics] Bitwise negation of a boolean expr always evaluates to true; warn…
Thu, Oct 3, 8:18 AM
xbolva00 committed rL373614: [Diagnostics] Bitwise negation of a boolean expr always evaluates to true; warn….
[Diagnostics] Bitwise negation of a boolean expr always evaluates to true; warn…
Thu, Oct 3, 8:17 AM
xbolva00 updated the diff for D68377: [Builtins] Teach Clang about memccpy.
Thu, Oct 3, 7:43 AM · Restricted Project
xbolva00 added a comment to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].

And maybe RISC V too..

Thu, Oct 3, 7:33 AM · Restricted Project
xbolva00 added reviewers for D68231: [SLC] Allow llvm.pow(x,2.0) -> x*x etc even if no pow() lib func: efriedma, spatel.
Thu, Oct 3, 5:46 AM · Restricted Project
xbolva00 added a comment to D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0.

And yes, with D68377 -fno-builtin-memccpy works -> Ideal fix for the linux kernel.

Thu, Oct 3, 5:22 AM · Restricted Project
xbolva00 added inline comments to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].
Thu, Oct 3, 4:34 AM · Restricted Project
xbolva00 added a comment to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].

put new tests in a separate commit

Thu, Oct 3, 4:34 AM · Restricted Project
xbolva00 added inline comments to D68377: [Builtins] Teach Clang about memccpy.
Thu, Oct 3, 1:29 AM · Restricted Project
xbolva00 added a reviewer for D68377: [Builtins] Teach Clang about memccpy: rsmith.
Thu, Oct 3, 1:28 AM · Restricted Project
xbolva00 created D68377: [Builtins] Teach Clang about memccpy.
Thu, Oct 3, 1:19 AM · Restricted Project
xbolva00 added a comment to D68360: PR41162 Implement LKK remainder and divisibility algorithms [urem].

Please precommit all new tests and rebase.

Thu, Oct 3, 12:15 AM · Restricted Project

Wed, Oct 2

xbolva00 reclaimed D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0.

Missclicked, sorry.

Wed, Oct 2, 3:59 PM · Restricted Project