Page MenuHomePhabricator
Feed Advanced Search

Today

xbolva00 added a reviewer for D66439: [LibFunc] "free" captures the pointer operand: efriedma.
Mon, Aug 19, 2:14 PM · Restricted Project
xbolva00 added a comment to D66397: [Diagnostics] Improve -Wxor-used-as-pow.

suggested source-code fixit of #define ALPHA_OFFSET 0x3

Mon, Aug 19, 1:39 PM · Restricted Project
xbolva00 updated subscribers of D66397: [Diagnostics] Improve -Wxor-used-as-pow.

I think it's too soon to disable any macros.

Mon, Aug 19, 12:54 PM · Restricted Project
xbolva00 added a comment to D66397: [Diagnostics] Improve -Wxor-used-as-pow.

I think it is too soon to jump and disable all macros. We still catch all motivating cases, it found bugs in Chromium.

Mon, Aug 19, 11:45 AM · Restricted Project
xbolva00 updated the diff for D66397: [Diagnostics] Improve -Wxor-used-as-pow.

Do not warn if RHS is macro.

Mon, Aug 19, 11:29 AM · Restricted Project
xbolva00 added a comment to D66397: [Diagnostics] Improve -Wxor-used-as-pow.

From post commit discussion, Nico Weber:

Mon, Aug 19, 11:19 AM · Restricted Project
xbolva00 updated subscribers of D66397: [Diagnostics] Improve -Wxor-used-as-pow.

I agree what @tkanis suggested and be silent if RHS is macro as real world code shows it. Opinions?

Mon, Aug 19, 11:19 AM · Restricted Project
xbolva00 added a reviewer for D66397: [Diagnostics] Improve -Wxor-used-as-pow: thakis.
Mon, Aug 19, 11:19 AM · Restricted Project
xbolva00 added a comment to rL369281: Implement P1668R1.

Please update
https://clang.llvm.org/cxx_status.html

Mon, Aug 19, 10:51 AM
xbolva00 added inline comments to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Mon, Aug 19, 10:36 AM
xbolva00 added inline comments to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Mon, Aug 19, 10:27 AM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Mon, Aug 19, 8:54 AM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

annotate snprintf if N is C > 0.

Mon, Aug 19, 8:45 AM
xbolva00 added inline comments to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Mon, Aug 19, 6:29 AM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Mon, Aug 19, 6:22 AM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Do not remove nonnull from intrinsics.

Mon, Aug 19, 6:21 AM
xbolva00 added inline comments to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Mon, Aug 19, 6:21 AM
xbolva00 updated subscribers of D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Mon, Aug 19, 6:13 AM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

update

Mon, Aug 19, 6:12 AM

Yesterday

xbolva00 created D66397: [Diagnostics] Improve -Wxor-used-as-pow.
Sun, Aug 18, 1:10 PM · Restricted Project
xbolva00 committed rG920890e26812: [Diagnostics] Diagnose misused xor as pow (authored by xbolva00).
[Diagnostics] Diagnose misused xor as pow
Sun, Aug 18, 12:14 PM
xbolva00 committed rL369217: [Diagnostics] Diagnose misused xor as pow.
[Diagnostics] Diagnose misused xor as pow
Sun, Aug 18, 12:13 PM
xbolva00 closed D63423: [Diagnostics] Diagnose misused xor as pow.
Sun, Aug 18, 12:13 PM · Restricted Project, Restricted Project
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Sun, Aug 18, 10:34 AM
xbolva00 added a reviewer for D53342: [SimplifyLibCalls] Mark known arguments with nonnull: jdoerfert.
Sun, Aug 18, 10:24 AM
xbolva00 resigned from D66050: Improve division estimation of floating points..
Sun, Aug 18, 10:00 AM · Restricted Project
xbolva00 added a comment to D53666: [Tests] Updated tests for D53342.

Will be handled as NFC commit after D53342 lands.

Sun, Aug 18, 9:10 AM
xbolva00 abandoned D53666: [Tests] Updated tests for D53342.
Sun, Aug 18, 9:10 AM
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

@jdoerfert please take a look again (yea, big diff :( )

Sun, Aug 18, 9:03 AM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Updated implementation.
Updated/added tests ... uff :D

Sun, Aug 18, 9:03 AM
xbolva00 added inline comments to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Sun, Aug 18, 7:15 AM
xbolva00 added a comment to D64176: [Bugpoint redesign] Added Pass to Remove Global Variables.

Bots warn;
srv/llvm-buildbot-srcatch/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/tools/llvm-reduce/deltas/ReduceGlobalVars.cpp:17:6: warning: '@returns' command used in a comment that is attached to a function returning void [-Wdocumentation]
1 warning generated.

Sun, Aug 18, 3:54 AM · Restricted Project
xbolva00 committed rGb4806822d2d5: [Diagnostics] Improve -Wsizeof-pointer-div (authored by xbolva00).
[Diagnostics] Improve -Wsizeof-pointer-div
Sun, Aug 18, 3:11 AM
xbolva00 committed rL369206: [Diagnostics] Improve -Wsizeof-pointer-div.
[Diagnostics] Improve -Wsizeof-pointer-div
Sun, Aug 18, 3:10 AM

Sat, Aug 17

xbolva00 updated the summary of D66338: [CGP] Drop no op intrinsic calls.
Sat, Aug 17, 9:37 AM · Restricted Project
xbolva00 added inline comments to D66338: [CGP] Drop no op intrinsic calls.
Sat, Aug 17, 9:34 AM · Restricted Project
xbolva00 updated the diff for D66338: [CGP] Drop no op intrinsic calls.

Moved to optimizeCallInst.
Drop var.annotation and sideeffect intrinsics too.

Sat, Aug 17, 9:34 AM · Restricted Project
xbolva00 added a comment to D65737: [InstCombine] mempcpy(d,s,n) to memcpy(d,s,n) + n.

As side note, there are a few cases in real word code
https://codesearch.isocpp.org/cgi-bin/cgi_ppsearch?q=mempcpy&search=Search

Sat, Aug 17, 3:54 AM · Restricted Project
xbolva00 added a comment to D66338: [CGP] Drop no op intrinsic calls.

Anyway I think this fix is good and simple - does not require individual fixes for GlobalISel, FastISel, SelectionDAG.

Sat, Aug 17, 1:31 AM · Restricted Project

Fri, Aug 16

xbolva00 added inline comments to D66232: [InstCombine] Try to reuse constant from select in leading comparison.
Fri, Aug 16, 4:13 PM · Restricted Project
xbolva00 added inline comments to D66232: [InstCombine] Try to reuse constant from select in leading comparison.
Fri, Aug 16, 4:03 PM · Restricted Project
xbolva00 added inline comments to D66232: [InstCombine] Try to reuse constant from select in leading comparison.
Fri, Aug 16, 3:54 PM · Restricted Project
xbolva00 updated the diff for D63423: [Diagnostics] Diagnose misused xor as pow.

Better comparison for "xor".

Fri, Aug 16, 3:31 PM · Restricted Project, Restricted Project
xbolva00 added inline comments to D66232: [InstCombine] Try to reuse constant from select in leading comparison.
Fri, Aug 16, 1:48 PM · Restricted Project
xbolva00 added a reviewer for D66338: [CGP] Drop no op intrinsic calls: aemerson.
Fri, Aug 16, 12:08 PM · Restricted Project
xbolva00 added a comment to D66338: [CGP] Drop no op intrinsic calls.

Anyway, this patch is still valid to be reviewed.

Fri, Aug 16, 10:17 AM · Restricted Project
xbolva00 updated subscribers of D66338: [CGP] Drop no op intrinsic calls.
Fri, Aug 16, 9:07 AM · Restricted Project
xbolva00 added a reviewer for D66338: [CGP] Drop no op intrinsic calls: aaron.ballman.
Fri, Aug 16, 9:07 AM · Restricted Project
xbolva00 added a comment to D66338: [CGP] Drop no op intrinsic calls.

Oh, this is funny (or nasty) bug

Fri, Aug 16, 8:59 AM · Restricted Project
xbolva00 updated the diff for D66338: [CGP] Drop no op intrinsic calls.
Fri, Aug 16, 8:59 AM · Restricted Project
xbolva00 added a comment to D66338: [CGP] Drop no op intrinsic calls.

(As an alternative, this can be fixed in the phrase when llvm.assume is dropped in backend.. but not sure if we have "backend" version of RecursivelyDeleteTriviallyDeadInstructions)

Fri, Aug 16, 7:17 AM · Restricted Project
xbolva00 added a reviewer for D66338: [CGP] Drop no op intrinsic calls: spatel.
Fri, Aug 16, 7:17 AM · Restricted Project
xbolva00 updated the diff for D63423: [Diagnostics] Diagnose misused xor as pow.

Fixed nits.

Fri, Aug 16, 7:07 AM · Restricted Project, Restricted Project
xbolva00 requested changes to D66050: Improve division estimation of floating points..
Fri, Aug 16, 4:21 AM · Restricted Project
xbolva00 accepted D66050: Improve division estimation of floating points..

(Regressions)

Fri, Aug 16, 4:21 AM · Restricted Project
xbolva00 added a comment to D65979: [InstCombine] Simplify pow(2.0, itofp(y)) to ldexp(1.0, y).

Week passed, it was enough time to comment it.

Fri, Aug 16, 4:03 AM · Restricted Project
xbolva00 added a comment to D63423: [Diagnostics] Diagnose misused xor as pow.

Any futher comments or is it OK now @jfb ? @aaron.ballman ?

Fri, Aug 16, 3:16 AM · Restricted Project, Restricted Project
xbolva00 added a reviewer for D66338: [CGP] Drop no op intrinsic calls: RKSimon.
Fri, Aug 16, 3:16 AM · Restricted Project
xbolva00 added a reviewer for D66338: [CGP] Drop no op intrinsic calls: Carrot.
Fri, Aug 16, 3:06 AM · Restricted Project
xbolva00 created D66338: [CGP] Drop no op intrinsic calls.
Fri, Aug 16, 2:58 AM · Restricted Project

Thu, Aug 15

xbolva00 added a comment to D66096: [CodeGen/Analysis] Intrinsic llvm.assume should not block tail call optimization.

(That issue needs a separate patch anyway).

Thu, Aug 15, 4:00 PM · Restricted Project
xbolva00 added a comment to D66096: [CodeGen/Analysis] Intrinsic llvm.assume should not block tail call optimization.

Yes! There is a new PR and I just realized how big issue we have here (we may call functions which are never called in source code) :[

Thu, Aug 15, 4:00 PM · Restricted Project
xbolva00 accepted D66314: [Bugpoint redesign] Output option can now print to STDOUT.

Ok, go ahead.

Thu, Aug 15, 3:36 PM · Restricted Project
xbolva00 added inline comments to D66314: [Bugpoint redesign] Output option can now print to STDOUT.
Thu, Aug 15, 3:24 PM · Restricted Project
xbolva00 added inline comments to D64176: [Bugpoint redesign] Added Pass to Remove Global Variables.
Thu, Aug 15, 12:19 PM · Restricted Project
xbolva00 updated subscribers of D64176: [Bugpoint redesign] Added Pass to Remove Global Variables.

Surprisingly test remove-global-vars.ll fails on buildbot

Thu, Aug 15, 11:46 AM · Restricted Project
xbolva00 accepted D64838: [Attr] Support _attribute__ ((fallthrough)).
Thu, Aug 15, 11:39 AM · Restricted Project
xbolva00 added a reviewer for D66308: [InstCombine] Fold select with ctlz to cttz: dmgreen.
Thu, Aug 15, 11:39 AM · Restricted Project
xbolva00 added a comment to D66308: [InstCombine] Fold select with ctlz to cttz.

Is there a opposite pattern?

Thu, Aug 15, 11:36 AM · Restricted Project
xbolva00 updated the summary of D66308: [InstCombine] Fold select with ctlz to cttz.
Thu, Aug 15, 11:36 AM · Restricted Project
xbolva00 created D66308: [InstCombine] Fold select with ctlz to cttz.
Thu, Aug 15, 11:27 AM · Restricted Project
xbolva00 committed rG00782a4b68c7: [NFC] Added tests for 'select with ctlz to cttz' fold (authored by xbolva00).
[NFC] Added tests for 'select with ctlz to cttz' fold
Thu, Aug 15, 11:25 AM
xbolva00 committed rL369032: [NFC] Added tests for 'select with ctlz to cttz' fold.
[NFC] Added tests for 'select with ctlz to cttz' fold
Thu, Aug 15, 11:23 AM
xbolva00 added a comment to D66096: [CodeGen/Analysis] Intrinsic llvm.assume should not block tail call optimization.

https://bugs.llvm.org/show_bug.cgi?id=43007 should be fixed too

Thu, Aug 15, 10:17 AM · Restricted Project
xbolva00 added inline comments to D66244: Compiler.h: remove old GCC checks, update docs.
Thu, Aug 15, 7:07 AM · Restricted Project
xbolva00 added a comment to D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer.

Good to know, thanks for info!

Thu, Aug 15, 6:54 AM · Restricted Project
xbolva00 added a comment to D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer.

Hello folks,

Thu, Aug 15, 4:06 AM · Restricted Project

Wed, Aug 14

xbolva00 added a comment to D66079: [SimplifyLibCalls] Add dereferenceable bytes from known callsites.

Or by conserative (dont make IC much slower) and check only str(n)cpy, memcpy, memmove, memset buffers if they come from malloc/realloc/calloc?

Wed, Aug 14, 3:45 PM · Restricted Project
xbolva00 added a comment to D66079: [SimplifyLibCalls] Add dereferenceable bytes from known callsites.

I found another opportunity

Wed, Aug 14, 3:13 PM · Restricted Project
xbolva00 added a comment to D65737: [InstCombine] mempcpy(d,s,n) to memcpy(d,s,n) + n.

mempcpy is quite rare, so hard to measure it on codebases.

Wed, Aug 14, 2:50 PM · Restricted Project
xbolva00 added a comment to D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors.

Can you use utils/update_test_checks.py on this new IR file, please?

Wed, Aug 14, 11:01 AM · Restricted Project
xbolva00 committed rGf94460d4b64c: [SLC] Dereferenceable annonation - handle valid null pointers (authored by xbolva00).
[SLC] Dereferenceable annonation - handle valid null pointers
Wed, Aug 14, 10:17 AM
xbolva00 committed rL368884: [SLC] Dereferenceable annonation - handle valid null pointers.
[SLC] Dereferenceable annonation - handle valid null pointers
Wed, Aug 14, 10:17 AM
xbolva00 closed D66161: [SLC] Dereferenceable annonation - handle valid null pointers.
Wed, Aug 14, 10:17 AM · Restricted Project
xbolva00 committed rG8f5c1c014869: [NFC] Updated tests after r368875 (authored by xbolva00).
[NFC] Updated tests after r368875
Wed, Aug 14, 9:51 AM
xbolva00 committed rG0e0fbae1a432: [BuildLibCalls] Noalias annotation (authored by xbolva00).
[BuildLibCalls] Noalias annotation
Wed, Aug 14, 9:50 AM
xbolva00 added a comment to D66161: [SLC] Dereferenceable annonation - handle valid null pointers.

I have no problem with this patch (i.e. it can land if Johannes approves)

A conceptual point worth mentioning is that seems to essentially be inferring non-null for the intrinsics in question. We have a nonnull attribute on params and nonnull + deref_or_null should already be converted to deref. (If not, we should fix that.) It might be worth thinking about how to leverage the more generic code.

Wed, Aug 14, 9:50 AM · Restricted Project
xbolva00 committed rL368876: [NFC] Updated tests after r368875.
[NFC] Updated tests after r368875
Wed, Aug 14, 9:49 AM
xbolva00 committed rL368875: [BuildLibCalls] Noalias annotation.
[BuildLibCalls] Noalias annotation
Wed, Aug 14, 9:49 AM
xbolva00 closed D66217: [BuildLibCalls] Noalias annotation.
Wed, Aug 14, 9:49 AM · Restricted Project
xbolva00 added inline comments to D66195: Move to C++14.
Wed, Aug 14, 9:24 AM · Restricted Project
xbolva00 added a comment to rG3e44d961705f: [X86] Use PSADBW for v8i8 addition reductions..

https://bugs.llvm.org/show_bug.cgi?id=42410

Wed, Aug 14, 9:07 AM
xbolva00 added inline comments to D66217: [BuildLibCalls] Noalias annotation.
Wed, Aug 14, 8:41 AM · Restricted Project
xbolva00 committed rGbffa4a2b17b1: [NFC] Fix testcase for ARMs (authored by xbolva00).
[NFC] Fix testcase for ARMs
Wed, Aug 14, 8:36 AM
xbolva00 committed rL368863: [NFC] Fix testcase for ARMs.
[NFC] Fix testcase for ARMs
Wed, Aug 14, 8:36 AM
xbolva00 added inline comments to D66217: [BuildLibCalls] Noalias annotation.
Wed, Aug 14, 8:23 AM · Restricted Project
xbolva00 added inline comments to D64700: [SLPVectorizer] [NFC] Avoid repetitive calls to getSameOpcode()..
Wed, Aug 14, 7:34 AM
xbolva00 updated the diff for D66217: [BuildLibCalls] Noalias annotation.

Added support for sprint, snprintf.

Wed, Aug 14, 6:04 AM · Restricted Project
xbolva00 updated the diff for D66217: [BuildLibCalls] Noalias annotation.
Wed, Aug 14, 6:00 AM · Restricted Project
xbolva00 updated the diff for D66217: [BuildLibCalls] Noalias annotation.
Wed, Aug 14, 5:49 AM · Restricted Project