Page MenuHomePhabricator
Feed Advanced Search

Today

xbolva00 added a comment to D63423: [Diagnostics] Diagnose misused xor as pow.

Should we also emit a note how to silence it, eg. swap xor operands or add parentheses around 2/10 ?

Mon, Jun 17, 7:24 AM · Restricted Project
xbolva00 updated subscribers of D62857: [RISCV] Prevent re-ordering some adds after shifts.

In future, DAGCombine could do the check to see whether c1 fits into an add immediate, which might simplify more targets hooks than just RISC-V.

Mon, Jun 17, 6:53 AM · Restricted Project
xbolva00 added a reviewer for D63423: [Diagnostics] Diagnose misused xor as pow: regehr.
Mon, Jun 17, 6:26 AM · Restricted Project
xbolva00 updated the diff for D63423: [Diagnostics] Diagnose misused xor as pow.

More tests

Mon, Jun 17, 6:14 AM · Restricted Project
xbolva00 added inline comments to D63423: [Diagnostics] Diagnose misused xor as pow.
Mon, Jun 17, 5:40 AM · Restricted Project
xbolva00 created D63423: [Diagnostics] Diagnose misused xor as pow.
Mon, Jun 17, 5:39 AM · Restricted Project
xbolva00 added a comment to D63391: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case) (try 2).

I'm submitting a new revision since i don't understand how to reclaim/reopen/take over the existing one, D50222.
There is no such action in "Add Action" menu...
Original patch D50222 by @hermord (Dmytro Shynkevych)

Add Action | Revision Actions | Commandeer Revision

Well, yeah, that's the thing

Mon, Jun 17, 4:50 AM · Restricted Project
xbolva00 accepted D63390: [Codegen] TargetLowering::SimplifySetCC(): omit urem when possible.

Looks fine.

Mon, Jun 17, 3:22 AM · Restricted Project

Yesterday

xbolva00 added a comment to D63391: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case) (try 2).

Thanks, looks fine now (with fixed regression).

Sun, Jun 16, 3:50 PM · Restricted Project
xbolva00 added a comment to D63390: [Codegen] TargetLowering::SimplifySetCC(): omit urem when possible.

Thanks, you fixed it!

Sun, Jun 16, 3:46 PM · Restricted Project
xbolva00 added a comment to D63082: [Diagnostics] Added support for -Wint-in-bool-context.

Ping

Sun, Jun 16, 5:35 AM · Restricted Project
xbolva00 added inline comments to D63382: [InstCombine] fold a shifted zext to a select.
Sun, Jun 16, 5:22 AM · Restricted Project

Fri, Jun 14

xbolva00 abandoned D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case).
Fri, Jun 14, 3:27 PM · Restricted Project
xbolva00 planned changes to D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case).

Oh, no. Still there :((

Fri, Jun 14, 3:11 PM · Restricted Project
xbolva00 updated the summary of D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case).
Fri, Jun 14, 3:00 PM · Restricted Project
xbolva00 updated the diff for D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case).

Rebased. Moved to DAGCombiner and fixed regression in jump_sign.ll.

Fri, Jun 14, 2:50 PM · Restricted Project
xbolva00 commandeered D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case).
Fri, Jun 14, 2:47 PM · Restricted Project
xbolva00 added a comment to D63324: [clang-tidy] Replace memcpy by std::copy.

This might not be currently ideal recommendation since std::copy produces memmove with -O3.

Fri, Jun 14, 9:38 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D63299: [Clang] Parse GNU fallthrough attributes.
Fri, Jun 14, 4:44 AM · Restricted Project
xbolva00 added a comment to D63299: [Clang] Parse GNU fallthrough attributes.

isDeclarationStatement() returns true for attribute((fallthough)) ;

Fri, Jun 14, 4:39 AM · Restricted Project

Thu, Jun 13

xbolva00 updated the diff for D63260: [Attr] Support _attribute__ ((fallthrough)).
Thu, Jun 13, 3:45 PM · Restricted Project
xbolva00 updated the summary of D46262: Enable sibling-call optimization for functions returning structs.
Thu, Jun 13, 3:40 PM · Restricted Project
xbolva00 set the repository for D46262: Enable sibling-call optimization for functions returning structs to rL LLVM.
Thu, Jun 13, 3:40 PM · Restricted Project
xbolva00 added a comment to D46262: Enable sibling-call optimization for functions returning structs.

Please fix the "summary" to include the full expected commit message.

I had the following comment on the original revision:

If both the caller and callee are sret, do you need to check that the sret argument is the same? Consider something like tail call void @f(%struct.foo* noalias sret @aa) nounwind.

Did this ever get fixed?

Thu, Jun 13, 3:40 PM · Restricted Project
xbolva00 updated the diff for D63260: [Attr] Support _attribute__ ((fallthrough)).

fixed testcase

Thu, Jun 13, 3:33 PM · Restricted Project
xbolva00 added a comment to D63299: [Clang] Parse GNU fallthrough attributes.

As we see. this is not good place to parse attribute((fallthough), which blocks D63260. Maybe @aaron.ballman could help us since he knows this code better..

Thu, Jun 13, 2:49 PM · Restricted Project
xbolva00 created D63299: [Clang] Parse GNU fallthrough attributes.
Thu, Jun 13, 2:46 PM · Restricted Project
xbolva00 updated the diff for D63260: [Attr] Support _attribute__ ((fallthrough)).

Fixed EOF in test case.

Thu, Jun 13, 2:40 PM · Restricted Project
xbolva00 updated the diff for D63260: [Attr] Support _attribute__ ((fallthrough)).

Now patch only adds _attribute__ ((fallthrough)) support. Parsing will be hopefully solved in second patch.

Thu, Jun 13, 2:40 PM · Restricted Project
xbolva00 updated the diff for D46262: Enable sibling-call optimization for functions returning structs.

One more test added.

Thu, Jun 13, 1:40 PM · Restricted Project
xbolva00 added inline comments to D63260: [Attr] Support _attribute__ ((fallthrough)).
Thu, Jun 13, 11:34 AM · Restricted Project
xbolva00 added inline comments to D63260: [Attr] Support _attribute__ ((fallthrough)).
Thu, Jun 13, 11:33 AM · Restricted Project
xbolva00 committed rGa9d8388e80c2: [NFC] Updated testcase for D54411/rL363284 (authored by xbolva00).
[NFC] Updated testcase for D54411/rL363284
Thu, Jun 13, 11:11 AM
xbolva00 committed rL363285: [NFC] Updated testcase for D54411/rL363284.
[NFC] Updated testcase for D54411/rL363284
Thu, Jun 13, 11:10 AM
xbolva00 committed rG896ece41e478: [Codegen] Merge tail blocks with no successors after block placement (authored by xbolva00).
[Codegen] Merge tail blocks with no successors after block placement
Thu, Jun 13, 11:09 AM
xbolva00 committed rL363284: [Codegen] Merge tail blocks with no successors after block placement.
[Codegen] Merge tail blocks with no successors after block placement
Thu, Jun 13, 11:08 AM
xbolva00 closed D54411: [Codegen] Merge tail blocks with no successors after block placement.
Thu, Jun 13, 11:08 AM · Restricted Project
xbolva00 added inline comments to D63260: [Attr] Support _attribute__ ((fallthrough)).
Thu, Jun 13, 10:58 AM · Restricted Project
xbolva00 updated the diff for D63260: [Attr] Support _attribute__ ((fallthrough)).
Thu, Jun 13, 10:56 AM · Restricted Project
xbolva00 updated the diff for D63260: [Attr] Support _attribute__ ((fallthrough)).

Addressed some review notes. Thanks.

Thu, Jun 13, 10:56 AM · Restricted Project
xbolva00 added inline comments to D63260: [Attr] Support _attribute__ ((fallthrough)).
Thu, Jun 13, 10:53 AM · Restricted Project
xbolva00 added a comment to D63260: [Attr] Support _attribute__ ((fallthrough)).

__block y = 7;

Thu, Jun 13, 10:51 AM · Restricted Project
xbolva00 added inline comments to D63260: [Attr] Support _attribute__ ((fallthrough)).
Thu, Jun 13, 10:26 AM · Restricted Project
xbolva00 updated the diff for D46262: Enable sibling-call optimization for functions returning structs.

Revert deleted testcase.

Thu, Jun 13, 9:58 AM · Restricted Project
xbolva00 added a comment to D45653: [X86] Enable sibling-call optimization for functions returning structs.

Since this patch was abandoned, I will try to continue it here: https://reviews.llvm.org/D46262

Thu, Jun 13, 9:53 AM
xbolva00 updated the diff for D46262: Enable sibling-call optimization for functions returning structs.

Reopened, since original D45653 was abandoned.

Thu, Jun 13, 9:52 AM · Restricted Project
xbolva00 added reviewers for D63260: [Attr] Support _attribute__ ((fallthrough)): riccibruno, dexonsmith.
Thu, Jun 13, 6:42 AM · Restricted Project
xbolva00 added a reviewer for D63260: [Attr] Support _attribute__ ((fallthrough)): erik.pilkington.
Thu, Jun 13, 6:42 AM · Restricted Project
xbolva00 added reviewers for D63260: [Attr] Support _attribute__ ((fallthrough)): rnk, rjmccall, efriedma.
Thu, Jun 13, 6:33 AM · Restricted Project
xbolva00 updated the summary of D63260: [Attr] Support _attribute__ ((fallthrough)).
Thu, Jun 13, 6:33 AM · Restricted Project
xbolva00 added inline comments to D63260: [Attr] Support _attribute__ ((fallthrough)).
Thu, Jun 13, 6:24 AM · Restricted Project
xbolva00 added a reviewer for D63260: [Attr] Support _attribute__ ((fallthrough)): nickdesaulniers.
Thu, Jun 13, 6:23 AM · Restricted Project
xbolva00 created D63260: [Attr] Support _attribute__ ((fallthrough)).
Thu, Jun 13, 6:21 AM · Restricted Project
xbolva00 added a comment to D54411: [Codegen] Merge tail blocks with no successors after block placement.

@rnk, @RKSimon fine for you too?

Thu, Jun 13, 4:56 AM · Restricted Project
xbolva00 updated the diff for D54411: [Codegen] Merge tail blocks with no successors after block placement.

Updated tail opts with testcase from @Jim. Thanks.

Thu, Jun 13, 2:10 AM · Restricted Project
xbolva00 added inline comments to D54411: [Codegen] Merge tail blocks with no successors after block placement.
Thu, Jun 13, 1:52 AM · Restricted Project

Wed, Jun 12

xbolva00 added reviewers for D63034: Slightly increase LastCallToStaticBonus for cold callsites: tejohnson, yrouban.
Wed, Jun 12, 4:57 PM · Restricted Project
xbolva00 updated the diff for D63038: [SimplifyLibCalls] powf(x, sitofp(n)) -> powi(x, n).

Handle uitofp better.

Wed, Jun 12, 4:51 PM · Restricted Project
xbolva00 added inline comments to D63038: [SimplifyLibCalls] powf(x, sitofp(n)) -> powi(x, n).
Wed, Jun 12, 4:18 PM · Restricted Project
xbolva00 updated the diff for D54411: [Codegen] Merge tail blocks with no successors after block placement.

Preserve test logic in tail opts.

Wed, Jun 12, 4:10 PM · Restricted Project
xbolva00 updated the diff for D54411: [Codegen] Merge tail blocks with no successors after block placement.

Fixed all undefs.

Wed, Jun 12, 3:49 PM · Restricted Project
xbolva00 updated the diff for D54411: [Codegen] Merge tail blocks with no successors after block placement.

FIxed review notes by @rnk. Thanks.

Wed, Jun 12, 3:48 PM · Restricted Project
xbolva00 added inline comments to D63038: [SimplifyLibCalls] powf(x, sitofp(n)) -> powi(x, n).
Wed, Jun 12, 3:40 PM · Restricted Project
xbolva00 added inline comments to D63038: [SimplifyLibCalls] powf(x, sitofp(n)) -> powi(x, n).
Wed, Jun 12, 3:40 PM · Restricted Project
xbolva00 updated the diff for D63038: [SimplifyLibCalls] powf(x, sitofp(n)) -> powi(x, n).

Revert unneeded formating changes.

Wed, Jun 12, 3:21 PM · Restricted Project
xbolva00 added inline comments to D63038: [SimplifyLibCalls] powf(x, sitofp(n)) -> powi(x, n).
Wed, Jun 12, 3:21 PM · Restricted Project
xbolva00 updated the diff for D63038: [SimplifyLibCalls] powf(x, sitofp(n)) -> powi(x, n).

More check for exponent int bitwidth.
Added more tests.

Wed, Jun 12, 3:19 PM · Restricted Project
xbolva00 updated the summary of D54411: [Codegen] Merge tail blocks with no successors after block placement.
Wed, Jun 12, 8:26 AM · Restricted Project
xbolva00 added a comment to D54411: [Codegen] Merge tail blocks with no successors after block placement.

@craig.topper , @dmgreen if patch is ok now, please approve it formally. Thanks.

Wed, Jun 12, 8:26 AM · Restricted Project
xbolva00 updated the diff for D54411: [Codegen] Merge tail blocks with no successors after block placement.

Updated

Wed, Jun 12, 8:23 AM · Restricted Project
xbolva00 committed rG48365ec3e14a: [NFC[ Updated tests for D54411 (authored by xbolva00).
[NFC[ Updated tests for D54411
Wed, Jun 12, 7:59 AM
xbolva00 committed rL363173: [NFC[ Updated tests for D54411.
[NFC[ Updated tests for D54411
Wed, Jun 12, 7:58 AM
xbolva00 updated the diff for D54411: [Codegen] Merge tail blocks with no successors after block placement.

Rebased to master.

Wed, Jun 12, 7:46 AM · Restricted Project
xbolva00 commandeered D54411: [Codegen] Merge tail blocks with no successors after block placement.
Wed, Jun 12, 7:35 AM · Restricted Project
xbolva00 added inline comments to D63192: [Diagnostics] Implement -Wswitch-default.
Wed, Jun 12, 4:05 AM · Restricted Project
xbolva00 added a comment to D63038: [SimplifyLibCalls] powf(x, sitofp(n)) -> powi(x, n).

Some more things to do, or is it fine now? :)

Wed, Jun 12, 4:05 AM · Restricted Project
xbolva00 updated the diff for D63139: [Diagnostics] Implement -Wswitch-unreachable.

Attached forgotten tests

Wed, Jun 12, 3:59 AM · Restricted Project
xbolva00 updated the diff for D63139: [Diagnostics] Implement -Wswitch-unreachable.

Warn in more cases. Added many new tests.

Wed, Jun 12, 3:58 AM · Restricted Project
xbolva00 planned changes to D63192: [Diagnostics] Implement -Wswitch-default.

I will work on this after we land https://reviews.llvm.org/D63139.

Wed, Jun 12, 3:52 AM · Restricted Project
xbolva00 created D63192: [Diagnostics] Implement -Wswitch-default.
Wed, Jun 12, 3:25 AM · Restricted Project

Tue, Jun 11

xbolva00 created D63139: [Diagnostics] Implement -Wswitch-unreachable.
Tue, Jun 11, 7:14 AM · Restricted Project
xbolva00 added a comment to rL290920: Extend -Wtautological-overlap-compare to more cases..

Thanks. Are you still working at this?

Tue, Jun 11, 4:50 AM
xbolva00 committed rGbc888f059d91: [NFC] Fixed arm/aarch64 test (authored by xbolva00).
[NFC] Fixed arm/aarch64 test
Tue, Jun 11, 4:07 AM
xbolva00 committed rL363049: [NFC] Fixed arm/aarch64 test.
[NFC] Fixed arm/aarch64 test
Tue, Jun 11, 4:07 AM
xbolva00 added a comment to D63004: [TargetLowering] Simplify (ctpop x) == 1.

I know this is a little late, but is the second run line of test/CodeGen/AArch64/arm64-popcnt.ll correct? If I build with -DLLVM_TARGETS_TO_BUILD=AArch64;X86 I get an error. As far as I can tell, using grep -l 'RUN.*triple=armv8' -R ../test/ armv8a is dealt with as an ARM target, not an AArch64 one, which is weird in and of itself.

Tue, Jun 11, 3:44 AM · Restricted Project

Mon, Jun 10

xbolva00 added a comment to rL290920: Extend -Wtautological-overlap-compare to more cases..

do you know why this warning is not on by default? :/

Mon, Jun 10, 4:32 PM
xbolva00 updated the summary of D63082: [Diagnostics] Added support for -Wint-in-bool-context.
Mon, Jun 10, 4:21 PM · Restricted Project
xbolva00 added a comment to D63058: [InlineCost] Fix bug 42084: return the first negative result.

2 questions, since i've read through the diff:

  1. will this pick the smallest cost, or the first negative cost?
  2. is this missing some abstraction? maybe InlineResult Result should be some wrapper that should be assigned-to, that will internally only accept the new value if it's better than what it currently has,
  1. Not the smallest cost, but the first negative result with its message.
  2. I think such an abstraction would not be much shorter: Result = InlineResult::FirstNegative(Result, expression)
Mon, Jun 10, 3:01 PM · Restricted Project
xbolva00 closed D50435: [Inliner] Attribute callsites with inline remarks.
Mon, Jun 10, 2:58 PM
xbolva00 added a comment to D63063: Bug 42208: speeding up std::merge.

If you take libcxx code for std::merge and compile it with GCC, is it faster? If not much, or even worse than Clang, I see no reason why not to improve it in libcxx's codebase.

Mon, Jun 10, 1:58 PM
xbolva00 added inline comments to D63038: [SimplifyLibCalls] powf(x, sitofp(n)) -> powi(x, n).
Mon, Jun 10, 1:52 PM · Restricted Project
xbolva00 updated the diff for D63038: [SimplifyLibCalls] powf(x, sitofp(n)) -> powi(x, n).

Transform only when full fast math mode.

Mon, Jun 10, 1:47 PM · Restricted Project
xbolva00 added a comment to D63089: [clang] Warn on implicit boolean casts in more contexts (PR34180).

You can check and take tests from my older patch https://reviews.llvm.org/D58878

Mon, Jun 10, 12:44 PM · Restricted Project
xbolva00 updated the diff for D63082: [Diagnostics] Added support for -Wint-in-bool-context.

Removed unrelated change

Mon, Jun 10, 9:04 AM · Restricted Project
xbolva00 added a reviewer for D63082: [Diagnostics] Added support for -Wint-in-bool-context: aaron.ballman.
Mon, Jun 10, 8:59 AM · Restricted Project
xbolva00 added a reviewer for D63082: [Diagnostics] Added support for -Wint-in-bool-context: RKSimon.
Mon, Jun 10, 8:57 AM · Restricted Project
xbolva00 updated subscribers of D63082: [Diagnostics] Added support for -Wint-in-bool-context.

Adding @RKSimon as a reviewer since he recently fixed some bugs which GCC's -Wint-in-bool-context caught.

Mon, Jun 10, 8:57 AM · Restricted Project
xbolva00 created D63082: [Diagnostics] Added support for -Wint-in-bool-context.
Mon, Jun 10, 8:54 AM · Restricted Project

Sun, Jun 9

xbolva00 added reviewers for D63038: [SimplifyLibCalls] powf(x, sitofp(n)) -> powi(x, n): nikic, efriedma.
Sun, Jun 9, 4:04 PM · Restricted Project
xbolva00 added a comment to D63060: [InstCombine] usub.sat(a, b) + b => umax(a, b) (PR42178).

There were discussions about integer min/max intrinsics some years ago but stalled .. old motivation cases + our new motivation cases should indicate that integer version of max/min intrinsics are worth.

Sun, Jun 9, 1:17 PM · Restricted Project