Page MenuHomePhabricator
Feed Advanced Search

Fri, Feb 21

kwk added inline comments to rG7fb06796abfd: [lldb][NFC] Remove unused parameter.
Fri, Feb 21, 2:29 AM

Thu, Feb 20

kwk committed rGc7b7f76ae6ae: [lldb]: fix typo in lldb-gdb-remote.txt (authored by kwk).
[lldb]: fix typo in lldb-gdb-remote.txt
Thu, Feb 20, 5:37 AM
kwk closed D74895: [lldb]: fix typo in lldb-gdb-remote.txt.
Thu, Feb 20, 5:37 AM · Unknown Object (Project)
kwk created D74895: [lldb]: fix typo in lldb-gdb-remote.txt.
Thu, Feb 20, 5:28 AM · Unknown Object (Project)

Fri, Feb 14

kwk created D74650: [lldb] WIP: idea for keeping filenames in raw form when coming from DWARF.
Fri, Feb 14, 2:02 PM · Unknown Object (Project)

Tue, Feb 11

kwk requested review of D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint.
Tue, Feb 11, 7:32 AM · Unknown Object (Project)
kwk added a comment to D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint.

@labath @jingham to summarize from what I read here and what I chatted about with @labath , the following is a possible way to go for now, right?

Tue, Feb 11, 7:32 AM · Unknown Object (Project)

Fri, Feb 7

kwk committed rGb89131cdda58: [lldb] removed no longer needed CMakeDependentOption (authored by kwk).
[lldb] removed no longer needed CMakeDependentOption
Fri, Feb 7, 12:28 AM
kwk closed D74160: [lldb] removed no longer needed CMakeDependentOption.
Fri, Feb 7, 12:28 AM · Unknown Object (Project)

Thu, Feb 6

kwk updated the summary of D74160: [lldb] removed no longer needed CMakeDependentOption.
Thu, Feb 6, 1:29 PM · Unknown Object (Project)
kwk updated the diff for D74160: [lldb] removed no longer needed CMakeDependentOption.

Removed typo in commit message

Thu, Feb 6, 1:29 PM · Unknown Object (Project)
kwk updated the summary of D74160: [lldb] removed no longer needed CMakeDependentOption.
Thu, Feb 6, 1:29 PM · Unknown Object (Project)
kwk created D74160: [lldb] removed no longer needed CMakeDependentOption.
Thu, Feb 6, 1:29 PM · Unknown Object (Project)
kwk created D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint.
Thu, Feb 6, 8:50 AM · Unknown Object (Project)
kwk planned changes to D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint.

I plan to refactor some of this patch.

Thu, Feb 6, 8:50 AM · Unknown Object (Project)

Jan 7 2020

kwk added inline comments to D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2.
Jan 7 2020, 1:41 AM · Unknown Object (Project)

Jan 5 2020

kwk added a comment to D67906: [lldb] Provide tab completion for target select/delete.

Why don't we always print the target index? Wouldn't that be much simpler?

Jan 5 2020, 11:21 PM · Unknown Object (Project)

Dec 5 2019

kwk committed rG51ce067a442e: [lldb] NFC: less nesting in SearchFilter.cpp (authored by kwk).
[lldb] NFC: less nesting in SearchFilter.cpp
Dec 5 2019, 11:40 PM
kwk closed D71022: [lldb] NFC: less nesting in SearchFilter.cpp.
Dec 5 2019, 11:40 PM · Unknown Object (Project)
kwk requested review of D71022: [lldb] NFC: less nesting in SearchFilter.cpp.

Addressed all review comments.

Dec 5 2019, 11:11 PM · Unknown Object (Project)
kwk updated the diff for D71022: [lldb] NFC: less nesting in SearchFilter.cpp.
  • Review comments
Dec 5 2019, 11:11 PM · Unknown Object (Project)

Dec 4 2019

kwk updated the summary of D71022: [lldb] NFC: less nesting in SearchFilter.cpp.
Dec 4 2019, 8:36 AM · Unknown Object (Project)
kwk created D71022: [lldb] NFC: less nesting in SearchFilter.cpp.
Dec 4 2019, 8:36 AM · Unknown Object (Project)

Nov 28 2019

kwk committed rGc671639af6a9: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext (authored by kwk).
[lldb] NFC: refactor CompileUnit::ResolveSymbolContext
Nov 28 2019, 12:46 PM
kwk closed D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext.
Nov 28 2019, 12:45 PM · Unknown Object (Project)
kwk requested review of D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext.
Nov 28 2019, 8:05 AM · Unknown Object (Project)
kwk updated the diff for D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext.
  • Fixed logic error
Nov 28 2019, 7:56 AM · Unknown Object (Project)
kwk planned changes to D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext.

Running tests locally.

Nov 28 2019, 7:56 AM · Unknown Object (Project)
kwk reopened D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext.

Reopening because I did find the logic error.

Nov 28 2019, 7:52 AM · Unknown Object (Project)
kwk committed rG373e2a4f69d6: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext (authored by kwk).
[lldb] NFC: refactor CompileUnit::ResolveSymbolContext
Nov 28 2019, 5:05 AM
kwk closed D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext.
Nov 28 2019, 5:04 AM · Unknown Object (Project)
kwk updated the diff for D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext.
  • Have ResolveSymbolContext not return anything
Nov 28 2019, 4:26 AM · Unknown Object (Project)

Nov 27 2019

kwk planned changes to D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext.
Nov 27 2019, 2:13 AM · Unknown Object (Project)
kwk added a comment to D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext.

Let's just remove that return value. It's anyway only used in one place or so where we can just call GetSize() manually. Then we also don't need the lambda. Otherwise this LGTM, thanks!

Nov 27 2019, 2:04 AM · Unknown Object (Project)
kwk updated the summary of D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext.
Nov 27 2019, 2:04 AM · Unknown Object (Project)
kwk updated the diff for D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext.

Small changes

Nov 27 2019, 2:04 AM · Unknown Object (Project)
kwk created D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext.
Nov 27 2019, 1:55 AM · Unknown Object (Project)
kwk planned changes to D70774: [lldb] NFC: refactor CompileUnit::ResolveSymbolContext.
Nov 27 2019, 1:55 AM · Unknown Object (Project)

Nov 13 2019

kwk added inline comments to D51830: Add a way to make scripted breakpoints.
Nov 13 2019, 8:11 AM · Unknown Object (Project)

Nov 7 2019

kwk added a comment to D68909: change shortcut for 'step out' from 'o' to 'f'.

Are there no tests for this code?

Nov 7 2019, 5:32 AM · Unknown Object (Project)
kwk added inline comments to D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling.
Nov 7 2019, 5:23 AM · Restricted Project, Unknown Object (Project)
kwk accepted D69944: [lldb] Add -m option to 'target modules dump symtab' to disable demangling.

LGTM with the exception of a local variable name.

Nov 7 2019, 5:23 AM · Restricted Project, Unknown Object (Project)

Oct 21 2019

kwk committed rG9129a281cd5b: [lldb] drop .symtab removal in minidebuginfo tests (authored by kwk).
[lldb] drop .symtab removal in minidebuginfo tests
Oct 21 2019, 7:11 AM
kwk closed D69254: [lldb] drop .symtab removal in minidebuginfo tests.
Oct 21 2019, 7:11 AM · Unknown Object (Project)
kwk committed rL375415: [lldb] drop .symtab removal in minidebuginfo tests.
[lldb] drop .symtab removal in minidebuginfo tests
Oct 21 2019, 7:11 AM
kwk requested review of D69254: [lldb] drop .symtab removal in minidebuginfo tests.

@grimar @labath tests did pass locally. Are you fine with this change then?

Oct 21 2019, 6:25 AM · Unknown Object (Project)
kwk created D69254: [lldb] drop .symtab removal in minidebuginfo tests.
Oct 21 2019, 6:16 AM · Unknown Object (Project)
kwk planned changes to D69254: [lldb] drop .symtab removal in minidebuginfo tests.

Still tests are running locally...

Oct 21 2019, 6:16 AM · Unknown Object (Project)

Oct 17 2019

kwk added a comment to D69041: [yaml2obj][obj2yaml] - Do not create a symbol table by default..
In D69041#1711707, @kwk wrote:

@grimar I don't understand why you created this patch, when I'm working on it already.

@kwk Sorry if you feel your work is commandeered. On D68943, it was me who said

Nice! Can you post a differential for the yaml2obj change? I believe the differential can focus on lldb and remove yaml2obj changes (kwk will still get credited for the test cleanups).

I skimmed through your yaml2obj changes in D68943 and I believed a complete fix needs more work than your change. check-llvm-tools check-llvm-object should expose more tests that you missed.

Oct 17 2019, 2:54 AM · Restricted Project
kwk abandoned D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.

Abandoning for D69041

Oct 17 2019, 2:25 AM · Restricted Project, Unknown Object (Project)
kwk added a comment to D69041: [yaml2obj][obj2yaml] - Do not create a symbol table by default..
In D69041#1711707, @kwk wrote:

@grimar I don't understand why you created this patch, when I'm working on it already.

I only wanted to help, because supposed that the correct direction is not clear for you (since your version did not fix any of existent test cases that were failing,
obj2yaml tool did not compile and there was at least one obliously wrong place in 'initSymtabSectionHeader' that broke the normal logic).
And it was also not fully clear to me what is exactly needed until I run check-llvm with the first more or less stable version of the patch at least.

Now when the whole picture is revealed, feel free to commandeer this revision or use it as a reference for your patch if you would like to continue it.
Or let me continue. Please let me know about your decision, I'll put this on hold until that.

Oct 17 2019, 2:25 AM · Restricted Project

Oct 16 2019

kwk added a comment to D69041: [yaml2obj][obj2yaml] - Do not create a symbol table by default..

@grimar I don't understand why you created this patch, when I'm working on it already. That's a waste of my time.

Oct 16 2019, 12:40 PM · Restricted Project

Oct 15 2019

kwk added a comment to D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.

I noticed that the order of sections does matter to some tests. Before the .symtab section was always the first one and now it is the last of the implicit sections being created. Some Link: X checks break because X points to a different section. In order to compensate for this I will make .symtab the first of the implicit sections again. In my local testing this already helps a bit. In cases where we refer to a section by number and expect .symtab to be the section being referenced, I have two options: 1st) create a symbol to force .symtab to be implicitly created or 2nd) change the name of the expected section. Just tell me what you want.

Oct 15 2019, 4:55 AM · Restricted Project, Unknown Object (Project)
kwk updated the diff for D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.
  • Remove unnecessary section
  • Have consitent ordering of run, check and YAML lines
  • use ## for comments in YAML
  • Remove not needed Entry and Sections
  • Only have Name for a symbol
  • Moved test files from llvm/test/ObjectYAML/ELF/ to llvm/test/tools/yaml2obj/
  • Fixup for test files
Oct 15 2019, 1:58 AM · Restricted Project, Unknown Object (Project)
kwk added a comment to D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.

@grimar I've tackled the most obvious of your comments. I will now see what fails in llvm/test/tools/yaml2obj.

Oct 15 2019, 1:58 AM · Restricted Project, Unknown Object (Project)

Oct 14 2019

kwk added a comment to D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.

This is not correct. A lot of yaml2obj tests fail with:

yaml2obj: error: unknown section referenced: '.symtab' by YAML section '.rela.text'

Oct 14 2019, 8:43 AM · Restricted Project, Unknown Object (Project)
kwk added a comment to D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.

Moved yaml2obj tests under llvm subtree.

Oct 14 2019, 6:52 AM · Restricted Project, Unknown Object (Project)
kwk updated the diff for D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.
  • moved test files over to llvm subtree
Oct 14 2019, 6:52 AM · Restricted Project, Unknown Object (Project)
kwk planned changes to D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.

Move tests over to llvm/llvm/test/ObjectYAML/ELF/.

Oct 14 2019, 6:06 AM · Restricted Project, Unknown Object (Project)
kwk added inline comments to D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.
Oct 14 2019, 6:06 AM · Restricted Project, Unknown Object (Project)
kwk updated the diff for D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.
  • restore formatting
Oct 14 2019, 5:56 AM · Restricted Project, Unknown Object (Project)
kwk updated the diff for D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.
  • Silence FileCheck in test
Oct 14 2019, 5:47 AM · Restricted Project, Unknown Object (Project)
kwk created D68943: [llvm][yaml2obj] no more implicit ELF .symtab section.
Oct 14 2019, 5:47 AM · Restricted Project, Unknown Object (Project)

Oct 12 2019

kwk committed rL374645: Added Konrad Kleine's usernames for svn and github.
Added Konrad Kleine's usernames for svn and github
Oct 12 2019, 1:32 AM

Oct 8 2019

kwk committed rG6d7fb29914e3: [lldb] Avoid resource leak (authored by kwk).
[lldb] Avoid resource leak
Oct 8 2019, 9:04 AM
kwk closed D68638: [lldb] Avoid resource leak.
Oct 8 2019, 9:04 AM · Unknown Object (Project)
kwk committed rL374071: [lldb] Avoid resource leak.
[lldb] Avoid resource leak
Oct 8 2019, 8:54 AM
kwk committed rG8970d88b65f0: Simplify LZMA decoding by using ArrayRef::take_back (authored by kwk).
Simplify LZMA decoding by using ArrayRef::take_back
Oct 8 2019, 8:45 AM
kwk closed D68647: Simplify LZMA decoding by using ArrayRef::take_back.
Oct 8 2019, 8:45 AM · Unknown Object (Project)
kwk committed rL374069: Simplify LZMA decoding by using ArrayRef::take_back.
Simplify LZMA decoding by using ArrayRef::take_back
Oct 8 2019, 8:45 AM
kwk added inline comments to D68647: Simplify LZMA decoding by using ArrayRef::take_back.
Oct 8 2019, 7:57 AM · Unknown Object (Project)
kwk updated the diff for D68647: Simplify LZMA decoding by using ArrayRef::take_back.

Fixup

Oct 8 2019, 7:57 AM · Unknown Object (Project)
kwk created D68647: Simplify LZMA decoding by using ArrayRef::take_back.
Oct 8 2019, 7:48 AM · Unknown Object (Project)
kwk created D68638: [lldb] Avoid resource leak.
Oct 8 2019, 6:51 AM · Unknown Object (Project)
kwk added a comment to D68614: [LLDB] Remove standalone build dep on llvm-strip.

I think I'm guilty for adding llvm-strip to LLDB_TEST_DEPS I wasn't aware that it might cause problems.

Oct 8 2019, 5:46 AM · Unknown Object (Project)

Oct 7 2019

kwk committed rG2c082b48274f: [lldb][ELF] Read symbols from .gnu_debugdata sect. (authored by kwk).
[lldb][ELF] Read symbols from .gnu_debugdata sect.
Oct 7 2019, 10:09 PM
kwk committed rL373891: [lldb][ELF] Read symbols from .gnu_debugdata sect..
[lldb][ELF] Read symbols from .gnu_debugdata sect.
Oct 7 2019, 10:08 PM
kwk closed D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

Closed by 2c082b48274fcba62bf9b3acb63075aedcc7a976.

Oct 7 2019, 3:49 AM · Restricted Project, Unknown Object (Project)
kwk updated the diff for D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

rebased

Oct 7 2019, 3:46 AM · Restricted Project, Unknown Object (Project)

Oct 5 2019

kwk added a comment to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

@labath as much as I would love to merge this patch I get errors from these tests that I didn't see before. They only appear after rebasing onto master:

Oct 5 2019, 2:07 PM · Restricted Project, Unknown Object (Project)
kwk updated the diff for D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

Rebased onto current master

Oct 5 2019, 12:38 PM · Restricted Project, Unknown Object (Project)
kwk added a comment to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

@labath ah, I've just seen that you did accept the revision already. Will merge it then after running tests once more.

Oct 5 2019, 12:32 PM · Restricted Project, Unknown Object (Project)
kwk added a comment to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

@labath I've addressed all you comments. Thank you for answering @jankratochvil's question as well. If this patch is good to go now, please give a thumbs up.

Oct 5 2019, 12:32 PM · Restricted Project, Unknown Object (Project)
kwk updated the diff for D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
  • Fix typo: s/a. /a ./
  • Fix comment header
  • Remove redundant input buffer check
  • Remove another redundant input buffer check
  • Change variable initialization to assign
  • added comment about minidebuginfo
Oct 5 2019, 12:32 PM · Restricted Project, Unknown Object (Project)

Oct 2 2019

kwk updated the summary of D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
Oct 2 2019, 9:40 AM · Restricted Project, Unknown Object (Project)
kwk requested review of D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..

Tests did pass so this change is ready for review @labath @jankratochvil .

Oct 2 2019, 9:06 AM · Restricted Project, Unknown Object (Project)
kwk updated the diff for D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
  • Change logic and comment for when .dynsym is parsed
  • Use different pattern for error checking
  • use less auto
  • Remove required system-linux test feature from LZMA tests
Oct 2 2019, 9:03 AM · Restricted Project, Unknown Object (Project)
kwk planned changes to D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect..
Oct 2 2019, 9:03 AM · Restricted Project, Unknown Object (Project)
kwk abandoned D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

Here's the relevant transcript from #lldb@otfc for why this change is abandoned.

Oct 2 2019, 8:00 AM · Restricted Project, Unknown Object (Project)
kwk planned changes to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

LLVM reasoning for why to go with std::vector: http://llvm.org/docs/ProgrammersManual.html#set-like-containers-std-set-smallset-setvector-etc.

Oct 2 2019, 2:38 AM · Restricted Project, Unknown Object (Project)

Oct 1 2019

kwk added inline comments to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
Oct 1 2019, 8:47 AM · Restricted Project, Unknown Object (Project)
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Check that no additional symbols follow after the expected ones
  • Use compiler-generated copy-ctor
  • Cleanup from experiment
  • Simplify NamedELFSymbol::hash()
  • Cleanup
Oct 1 2019, 8:47 AM · Restricted Project, Unknown Object (Project)
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Simplify NamedELFSymbol::hash()
Oct 1 2019, 3:56 AM · Restricted Project, Unknown Object (Project)
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Fix comment
Oct 1 2019, 3:22 AM · Restricted Project, Unknown Object (Project)
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Correct comment of test
Oct 1 2019, 3:21 AM · Restricted Project, Unknown Object (Project)
kwk added a comment to D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.

@labath can you please check this patch one last time (hopefully)?

Oct 1 2019, 2:40 AM · Restricted Project, Unknown Object (Project)
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Remove verbose output in test
  • Fix typo: smymtab -> symtab
  • Move compare and hash logic out of base class into derived class as requested
Oct 1 2019, 2:38 AM · Restricted Project, Restricted Project

Sep 30 2019

kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Fix comment
Sep 30 2019, 12:52 PM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • include test code in .c test file
Sep 30 2019, 8:31 AM · Restricted Project, Restricted Project
kwk updated the diff for D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections.
  • Added YAML test to merge symbols
Sep 30 2019, 7:33 AM · Restricted Project, Restricted Project