Thank you!

Thanks!

Remove __USING_SJLJ_OR_WASM_EXCEPTIONS__

Gentle ping 😀

In D159383#4635703, @dschuff wrote:

Suggested edit to the commit description:
"use musl and stddef.h at the same time" -> "use musl and clang's stddef.h at the same time"

I uploaded D159383, which removes the comments.

In D159312#4634617, @dalias wrote:

Please report what you're actually trying to do that's breaking rather than sending patches to align definitions that are not intended to be aligned.

I also think this is better solved downstream, i.e., in musl. We not a musl developer but a user, but we can consider contributing a patch there. I'd like to remove the whitespace for now because it is currently breaking us and it had been that way for a long time anyway, but I don't mind removing the comments, given that it sounds like we cannot change this forever.

Gentle ping 😀

Done. Btw musl defines NULL in several places, not only stdio.h. It defines NULL in local.h, stddef.h, stdio.h, stdlib.h, string.h, time.h, unistd.h, and wchar.h. Not sure why.

Add comment

The added space in ((void *)0) in __stddef_null.h broke Emscripten CI, which uses musl (https://www.musl-libc.org/). I added the space back in D159312.

The added space actually caused emscripten's CI to break: https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8771230198259238865/+/u/Build_Emscripten__upstream_/stdout

Fix bug in defining __USING_SJLJ_OR_WASM_EXCEPTIONS__

Address comments

Yeah we can do it, but that can be a different patch.

@dschuff

I notice there are no changes to the build system for this; presumably that's just because we don't have CMake support for building LLVM libraries for wasm in general. I wonder whether LLVM or the libunwind maintainers have any policies about that.

@dschuff

I notice there are no changes to the build system for this; presumably that's just because we don't have CMake support for building LLVM libraries for wasm in general. I wonder whether LLVM or the libc++abi maintainers have any policies about that.
Also, regarding the __USING_WASM_EXCEPTIONS__ macro: this is not predefined by the compiler but needs to be defined by the builder/build system, right? I wonder if that's something that belongs in <__cxxabi_config.h>

LGTM % nit and the name resolution (multimemory vs. multi-memory)

Thanks!

Thanks! This is much clearer. About WasmAddressSpaces.h, I have no idea why it was put into that common lib/CodeGen directory; I haven't reviewed D139010 myself. But it looks it is currently only used in lib/Target/WebAssembly/Utils/WebAssemblyTypeUtilities.h, so I guess it makes sense to move it to lib/Target/WebAssembly/Utils/ too? If we move it to lib/Target/WebAssembly/, we again end up creating dependency on WebAssemblyCodeGen library, which I think is what you are trying to remove. cc @pmatos in case he has other suggestions.

Address comments

Address comments

again

I think I messed up diff.. Attempt to recover

Remove newline

Address comments + fix errors

@dschuff is gonna be OOO for a while and we need to make this available to our users sooner, so I'm taking this over to address the remaining issues.

Wow the codegen is indeed impressive... 😂

Gentle ping 😀

Use different variables for different regs

Make LLVM_ENABLE_EXPENSIVE_CHECKS work

Fix tests

Nice! Just some drive-by nitpicking, sorry 😅

Typo fix

Thanks for the simplified version!

D147852 landed, so please rebase onto main and resolve conflicts.

Rename a function