Page MenuHomePhabricator
Feed Advanced Search

Today

erichkeane committed rGf124ab9fe115: Recommit -r372180 (authored by erichkeane).
Recommit -r372180
Wed, Sep 18, 8:16 AM
erichkeane committed rL372229: Recommit -r372180.
Recommit -r372180
Wed, Sep 18, 8:08 AM
erichkeane closed D67517: Create UsersManual section entitled 'Controlling Floating Point Behavior'.
Wed, Sep 18, 8:08 AM · Restricted Project

Yesterday

erichkeane committed rGf478c8bf9265: Revert "Create UsersManual section entitled 'Controlling Floating Point" (authored by erichkeane).
Revert "Create UsersManual section entitled 'Controlling Floating Point"
Tue, Sep 17, 2:28 PM
erichkeane added a reverting change for rGa08d5a4b0ebd: Create UsersManual section entitled 'Controlling Floating Point Behavior': rGf478c8bf9265: Revert "Create UsersManual section entitled 'Controlling Floating Point".
Tue, Sep 17, 2:28 PM
erichkeane committed rL372185: Revert "Create UsersManual section entitled 'Controlling Floating Point".
Revert "Create UsersManual section entitled 'Controlling Floating Point"
Tue, Sep 17, 2:27 PM
erichkeane committed rGa08d5a4b0ebd: Create UsersManual section entitled 'Controlling Floating Point Behavior' (authored by erichkeane).
Create UsersManual section entitled 'Controlling Floating Point Behavior'
Tue, Sep 17, 1:46 PM
erichkeane committed rL372180: Create UsersManual section entitled 'Controlling Floating Point.
Create UsersManual section entitled 'Controlling Floating Point
Tue, Sep 17, 1:44 PM
erichkeane closed D67517: Create UsersManual section entitled 'Controlling Floating Point Behavior'.
Tue, Sep 17, 1:44 PM · Restricted Project
erichkeane committed rG68b0977e646a: Add SpellingNotCalculated to Attribute Enums to suppress UBSan warnings (authored by erichkeane).
Add SpellingNotCalculated to Attribute Enums to suppress UBSan warnings
Tue, Sep 17, 7:20 AM
erichkeane committed rL372124: Add SpellingNotCalculated to Attribute Enums to suppress UBSan warnings.
Add SpellingNotCalculated to Attribute Enums to suppress UBSan warnings
Tue, Sep 17, 7:10 AM

Mon, Sep 16

erichkeane committed rGb79f3319584c: Move some definitions from Sema to Basic to fix shared libs build (authored by erichkeane).
Move some definitions from Sema to Basic to fix shared libs build
Mon, Sep 16, 6:59 AM
erichkeane committed rL371985: Move some definitions from Sema to Basic to fix shared libs build.
Move some definitions from Sema to Basic to fix shared libs build
Mon, Sep 16, 6:58 AM
erichkeane added a comment to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..

Fixed in r371985.

Mon, Sep 16, 6:58 AM · Restricted Project
erichkeane added inline comments to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Mon, Sep 16, 6:18 AM · Restricted Project

Sun, Sep 15

erichkeane added inline comments to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Sun, Sep 15, 5:31 PM · Restricted Project

Fri, Sep 13

erichkeane added a comment to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Fri, Sep 13, 11:17 AM · Restricted Project
erichkeane committed rGf9cd381fdfe5: Fix build error in 371875 (authored by erichkeane).
Fix build error in 371875
Fri, Sep 13, 10:59 AM
erichkeane committed rL371876: Fix build error in 371875.
Fix build error in 371875
Fri, Sep 13, 10:59 AM
erichkeane committed rG6a24e8068052: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr. (authored by erichkeane).
[NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.
Fri, Sep 13, 10:43 AM
erichkeane committed rL371875: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
[NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.
Fri, Sep 13, 10:43 AM
erichkeane closed D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Fri, Sep 13, 10:42 AM · Restricted Project

Thu, Sep 12

erichkeane added inline comments to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Thu, Sep 12, 10:02 AM · Restricted Project
erichkeane updated the diff for D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..

I think I've changed everything @aaron.ballman suggested. Despite the size of this patch, it actually removes ~1020 lines of code!

Thu, Sep 12, 10:02 AM · Restricted Project

Tue, Sep 10

erichkeane accepted D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Tue, Sep 10, 10:55 AM · Restricted Project, Restricted Project
erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Tue, Sep 10, 9:22 AM · Restricted Project, Restricted Project
erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Tue, Sep 10, 8:50 AM · Restricted Project, Restricted Project
erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Tue, Sep 10, 6:15 AM · Restricted Project, Restricted Project

Mon, Sep 9

erichkeane created D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Mon, Sep 9, 1:25 PM · Restricted Project
erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Mon, Sep 9, 1:16 PM · Restricted Project, Restricted Project

Fri, Sep 6

erichkeane committed rL371239: Add myself to list.
Add myself to list
Fri, Sep 6, 12:10 PM
erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Fri, Sep 6, 6:41 AM · Restricted Project, Restricted Project

Thu, Sep 5

erichkeane added a comment to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.

Actually... I think it might need to be weak_odr based on https://llvm.org/docs/LangRef.html#linkage-types

Thu, Sep 5, 6:29 AM · Restricted Project, Restricted Project
erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Thu, Sep 5, 6:26 AM · Restricted Project, Restricted Project

Wed, Sep 4

erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Wed, Sep 4, 6:25 AM · Restricted Project, Restricted Project
erichkeane updated subscribers of D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Wed, Sep 4, 6:18 AM · Restricted Project, Restricted Project

Tue, Sep 3

erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Tue, Sep 3, 9:18 AM · Restricted Project, Restricted Project
erichkeane added a comment to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.

I prefer this to be in the place where the ifunc gets created, otherwise we definitely need tests. There are sufficient tests for this that show the ifunc having been created, so I'd suggest just adding to them.

Tue, Sep 3, 6:31 AM · Restricted Project, Restricted Project
erichkeane added a reviewer for D63061: [builtins] Fix overflow issue for complex division with big numbers: craig.topper.
Tue, Sep 3, 6:19 AM · Restricted Project, Restricted Project

Mon, Sep 2

erichkeane added a comment to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.

Tests missing.
Is that what gcc does? I'd personally thought those should be internalized.

Mon, Sep 2, 11:12 AM · Restricted Project, Restricted Project

Thu, Aug 29

erichkeane requested changes to D66862: Make lround builtin constexpr (and others).

Craig topper pointed out to me that constexpr cannot throw exceptions, and at least the rints can raise some exceptions, which aren't allowed in Constexpr. The round functions similarly hit unspecified behavior, so we need to match that behavior.

Thu, Aug 29, 10:16 AM · Restricted Project
erichkeane accepted D66862: Make lround builtin constexpr (and others).

Small nit, just default construct the APFloats.

Thu, Aug 29, 10:07 AM · Restricted Project

Wed, Aug 28

erichkeane committed rG856f3fe5bbd6: Fix always_inline 'target' compatibility check code for Lambdas (authored by erichkeane).
Fix always_inline 'target' compatibility check code for Lambdas
Wed, Aug 28, 2:01 PM
erichkeane committed rL370261: Fix always_inline 'target' compatibility check code for Lambdas.
Fix always_inline 'target' compatibility check code for Lambdas
Wed, Aug 28, 2:01 PM

Tue, Aug 27

erichkeane added a comment to D66800: Some notes in `LLVM_ENABLE_LIBCXX`.

If your system only has libc++ available but the compiler shipped with it doesn't work out of the box (i.e. without passing -stdlib=libc++), isn't your compiler broken? In other words, it seems to me that your system compiler should always work out of the box without having to pass -stdlib=XXX -- do we agree? If so, I think the bug should be reported to whoever vends the compiler on the platform where you encountered this issue.

Tue, Aug 27, 8:31 AM · Restricted Project, Restricted Project
erichkeane added a comment to D66800: Some notes in `LLVM_ENABLE_LIBCXX`.

I would MUCH prefer that the compiler checker actually use the right library. Also, this isn't completely correct, MacOS Clang doesn't have libstdc++ available at all, yet works fine.

Tue, Aug 27, 6:49 AM · Restricted Project, Restricted Project

Mon, Aug 26

erichkeane committed rGe30b71f9dc0f: Fix -dA flag, it is not a preprocessor flag. (authored by erichkeane).
Fix -dA flag, it is not a preprocessor flag.
Mon, Aug 26, 10:13 AM
erichkeane committed rL369926: Fix -dA flag, it is not a preprocessor flag..
Fix -dA flag, it is not a preprocessor flag.
Mon, Aug 26, 10:13 AM

Fri, Aug 23

erichkeane committed rG23384a1c8dc8: [NFC] Move some variable declarations into their 'if' conditions. (authored by erichkeane).
[NFC] Move some variable declarations into their 'if' conditions.
Fri, Aug 23, 8:58 AM
erichkeane committed rL369773: [NFC] Move some variable declarations into their 'if' conditions..
[NFC] Move some variable declarations into their 'if' conditions.
Fri, Aug 23, 8:58 AM
erichkeane added a comment to D66597: [preprocessor] Add an opportunity to retain excluded conditional blocks.

I don't have a good idea of the intent of this patch. It seems to me that this could do some pretty nasty damage to C code, right?

Fri, Aug 23, 8:51 AM · Restricted Project, Restricted Project

Aug 19 2019

erichkeane committed rGa8abe1f82899: Fix poorly formatted HTML in the cxx_status.html file caused by adding 1668. (authored by erichkeane).
Fix poorly formatted HTML in the cxx_status.html file caused by adding 1668.
Aug 19 2019, 11:19 AM
erichkeane committed rL369286: Fix poorly formatted HTML in the cxx_status.html file caused by adding.
Fix poorly formatted HTML in the cxx_status.html file caused by adding
Aug 19 2019, 11:19 AM
erichkeane committed rGf04d246d7d13: Fix test where diagnostics changed in P1668 implementation (authored by erichkeane).
Fix test where diagnostics changed in P1668 implementation
Aug 19 2019, 11:10 AM
erichkeane committed rL369284: Fix test where diagnostics changed in P1668 implementation.
Fix test where diagnostics changed in P1668 implementation
Aug 19 2019, 11:09 AM
erichkeane committed rGab00f237ac9d: Update cxx_status.html with P1668 status. (authored by erichkeane).
Update cxx_status.html with P1668 status.
Aug 19 2019, 11:00 AM
erichkeane committed rL369282: Update cxx_status.html with P1668 status..
Update cxx_status.html with P1668 status.
Aug 19 2019, 10:59 AM
erichkeane committed rG62b072d413ee: Implement P1668R1 (authored by erichkeane).
Implement P1668R1
Aug 19 2019, 10:42 AM
erichkeane committed rL369281: Implement P1668R1.
Implement P1668R1
Aug 19 2019, 10:42 AM

Aug 14 2019

erichkeane committed rG0e85f18ded9c: Add support in CMake to statically link the C++ standard library. (authored by erichkeane).
Add support in CMake to statically link the C++ standard library.
Aug 14 2019, 12:56 PM
erichkeane committed rL368907: Add support in CMake to statically link the C++ standard library..
Add support in CMake to statically link the C++ standard library.
Aug 14 2019, 12:55 PM
erichkeane closed D65603: Add support in CMake to statically link the C++ standard library..
Aug 14 2019, 12:55 PM · Restricted Project

Aug 12 2019

erichkeane added a comment to D65603: Add support in CMake to statically link the C++ standard library..

Does anyone have issues with this? Can I commit it?

Aug 12 2019, 2:52 PM · Restricted Project

Aug 2 2019

erichkeane added a comment to D65603: Add support in CMake to statically link the C++ standard library..

Unfortunately, this ends up adding a warning or two to the build if you enable this, since we have a couple of things built in "C" (flag not used...). In the 'clang' test I did, ./bin/count was the only one. Unfortunately, we don't have separate C vs C++ linking flags, so I think this is just something that someone using this flag needs to deal with.

Aug 2 2019, 7:08 AM · Restricted Project

Aug 1 2019

erichkeane created D65603: Add support in CMake to statically link the C++ standard library..
Aug 1 2019, 1:04 PM · Restricted Project
erichkeane committed rG441f119789da: Fix spacing of LLVM_USE_PERF in CMake.rst that caused it to be tabbed in funny (authored by erichkeane).
Fix spacing of LLVM_USE_PERF in CMake.rst that caused it to be tabbed in funny
Aug 1 2019, 10:31 AM
erichkeane committed rG1328cd0e3752: Document LLVM_ENABLE_LIBCXX in CMake.rst (authored by erichkeane).
Document LLVM_ENABLE_LIBCXX in CMake.rst
Aug 1 2019, 10:31 AM
erichkeane committed rL367585: Fix spacing of LLVM_USE_PERF in CMake.rst that caused it to be tabbed in funny.
Fix spacing of LLVM_USE_PERF in CMake.rst that caused it to be tabbed in funny
Aug 1 2019, 10:29 AM
erichkeane committed rL367584: Document LLVM_ENABLE_LIBCXX in CMake.rst.
Document LLVM_ENABLE_LIBCXX in CMake.rst
Aug 1 2019, 10:29 AM

Jul 26 2019

erichkeane added 3 commit(s) for D65294: Make the CXXABIs respect the target's default calling convention.: rG61478ec6ac9f: Make the CXXABIs respect the target's default calling convention., rC367103: Make the CXXABIs respect the target's default calling convention., rL367103: Make the CXXABIs respect the target's default calling convention..
Jul 26 2019, 5:45 AM
erichkeane closed D65294: Make the CXXABIs respect the target's default calling convention..
Jul 26 2019, 5:45 AM
erichkeane added an edge to rL367103: Make the CXXABIs respect the target's default calling convention.: D65294: Make the CXXABIs respect the target's default calling convention..
Jul 26 2019, 5:45 AM
erichkeane added an edge to rG61478ec6ac9f: Make the CXXABIs respect the target's default calling convention.: D65294: Make the CXXABIs respect the target's default calling convention..
Jul 26 2019, 5:45 AM
erichkeane added a comment to D65294: Make the CXXABIs respect the target's default calling convention..

Committed, 9.0 release request here: https://bugs.llvm.org/show_bug.cgi?id=42774

Jul 26 2019, 5:40 AM
erichkeane committed rG61478ec6ac9f: Make the CXXABIs respect the target's default calling convention. (authored by erichkeane).
Make the CXXABIs respect the target's default calling convention.
Jul 26 2019, 5:39 AM
erichkeane committed rL367103: Make the CXXABIs respect the target's default calling convention..
Make the CXXABIs respect the target's default calling convention.
Jul 26 2019, 5:36 AM

Jul 25 2019

erichkeane created D65294: Make the CXXABIs respect the target's default calling convention..
Jul 25 2019, 11:28 AM
erichkeane committed rG393094859e45: Remove CallingConvMethodType (authored by erichkeane).
Remove CallingConvMethodType
Jul 25 2019, 10:17 AM
erichkeane committed rGad137fa78863: Fix cxx_status html for r367027 (authored by erichkeane).
Fix cxx_status html for r367027
Jul 25 2019, 10:17 AM
erichkeane committed rL367039: Remove CallingConvMethodType.
Remove CallingConvMethodType
Jul 25 2019, 10:16 AM
erichkeane committed rL367038: Fix cxx_status html for r367027.
Fix cxx_status html for r367027
Jul 25 2019, 10:16 AM
erichkeane committed rG46441fdb3c1d: Implement P1771 (authored by erichkeane).
Implement P1771
Jul 25 2019, 8:13 AM
erichkeane committed rL367027: Implement P1771.
Implement P1771
Jul 25 2019, 8:12 AM
erichkeane closed D64914: Implement P1771.
Jul 25 2019, 8:12 AM · Restricted Project, Restricted Project
erichkeane updated the diff for D64914: Implement P1771.
Jul 25 2019, 6:55 AM · Restricted Project, Restricted Project

Jul 24 2019

erichkeane updated the diff for D64914: Implement P1771.

Casting implementation had to happen in SemaStmt, because other 'warn unused result' stuff depends on them being the way they are.

Jul 24 2019, 7:37 AM · Restricted Project, Restricted Project
erichkeane added a comment to D64914: Implement P1771.

Disregard that last commit... i ended up breaking stuff apparently.

Jul 24 2019, 6:19 AM · Restricted Project, Restricted Project
erichkeane updated the diff for D64914: Implement P1771.
Jul 24 2019, 6:02 AM · Restricted Project, Restricted Project

Jul 23 2019

erichkeane added a comment to D64914: Implement P1771.

Ugg... well conversion functions are an interesting bit, as well as Type{}; with no constructors. It ends up being a function style cast to an init-list-expr, so its going to require a bit more work. Stay tuned :)

Jul 23 2019, 1:55 PM · Restricted Project, Restricted Project

Jul 22 2019

erichkeane updated the diff for D64914: Implement P1771.

Rebased and did all the comments (including the www_status). @aaron.ballman : Wasn't positive what you meant about the conversion functions, but I think I got one? I would also love some bikeshedding on the documentation.

Jul 22 2019, 7:17 AM · Restricted Project, Restricted Project

Jul 19 2019

erichkeane added a comment to D64914: Implement P1771.

I'll need to rebase this on another patch soon anyway, so I'll hold off until next week to update this particularly since we have some open questions. The additional TableGen work is tempting to do, though I'm not completely sure it'll get more than just this use.

Jul 19 2019, 5:24 AM · Restricted Project, Restricted Project
erichkeane updated the diff for D64914: Implement P1771.

Removes pure/const, limits change to just CXX11 spelling, and changes docs/FeatureTestMacro.

Jul 19 2019, 12:26 AM · Restricted Project, Restricted Project

Jul 18 2019

erichkeane added a comment to D64914: Implement P1771.

There seems to be some separable concerns in this patch. I'd rather real with warn_unused_result, const, and pure attributes separately only because those are under the gnu attribute namespace and I'd prefer to match GNU's semantics for those attributes (or at least understand better where the inconsistencies are).

This is also missing documentation changes and the updated feature test macro value.

Jul 18 2019, 11:30 PM · Restricted Project, Restricted Project
erichkeane created D64914: Implement P1771.
Jul 18 2019, 5:57 AM · Restricted Project, Restricted Project

Jul 8 2019

erichkeane added a comment to D63846: [clang] Preserve names of addrspacecast'ed values..

The change itself doesn't really bother me at all, however the test will fail if we build without preserving names. In order to validate this you'll have to do fno-discard-value-names on a test.

Jul 8 2019, 11:00 AM · Restricted Project, Restricted Project
erichkeane accepted D64276: [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code.

I think the function names are awkward, but otherwise I think this should be acceptable. I'll accept, but give 24 hrs for the other reviewers to get through their mondays.

Jul 8 2019, 6:36 AM · Restricted Project, Restricted Project

Jul 1 2019

erichkeane added a reviewer for D63846: [clang] Preserve names of addrspacecast'ed values.: yaxunl.
Jul 1 2019, 11:35 AM · Restricted Project, Restricted Project
erichkeane added a comment to D64015: [WIP][CUDA] Use shared MangleContext for CUDA and CXX CG.

I don't know of any problems that the shared mangle context would cause, though I'm not sure about using the shared_ptr. It seems to me that SOMEONE should own this, and the other should use a reference. IMO, the SharedMangleContexts should be a unique_ptr and CGCXXABI/CGCUDANV should have a reference to the proper implementation.

Jul 1 2019, 10:10 AM · Restricted Project

Jun 25 2019

erichkeane committed rGad28befcf49c: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty> (authored by erichkeane).
Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>
Jun 25 2019, 5:10 PM
erichkeane committed rL364364: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.
Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>
Jun 25 2019, 5:09 PM