Duplicated by https://reviews.llvm.org/D79474
Fri, May 22
Tue, May 19
Mon, May 18
LGTM. Anyone else have comments?
May 6 2020
really happy for native bfloat support!
Apr 30 2020
Thanks for all the comments! Does this look good? Or other considerations?
Apr 29 2020
Enable for C#
The is done unless there are other comments.
Apr 28 2020
- This needs unit tests in clang/unittests/Format to demonstrate the problem and test this fixing it
Add test case
Only apply to Microsoft CPP style
Fix line breaks like this:
Apr 27 2020
This change tries to fix this bug.
Apr 15 2020
Use the unique filenames that are used when /lldsavetemps is passed.
Is this for debug convenience? (llvm-pdbutil dump output) Or required by some tools?
Apr 10 2020
Nit - update comment
Mar 31 2020
Mar 29 2020
Mar 26 2020
Adding a test
Mar 21 2020
Curious what the status of this is? Looks like its been ready for almost one year :)
Mar 20 2020
Nov 18 2019
Oct 14 2019
Sep 23 2019
Address comments on comment character #, auto and rst file.
Thinks for the patch! I haven't had time to review the meat of it yet, but will try to get back to it in the next couple of days. One quick question in the meantime: what's the motivation behind this? Is it to improve GNU compatibility?
Sep 22 2019
Add new options to objcopy documentation
Address reviewers comments about auto
Sep 19 2019
Any comments from the llvm-objcopy community?
Sep 17 2019
Aug 15 2019
Aug 14 2019
This was split into separate patches and committed. No longer need this review.
Aug 13 2019
Any more comments on the tests for Windows?
This is done.
Aug 11 2019
Any last comments before this is committed?
Aug 6 2019
Do you need some help fixing the build?
Aug 2 2019
I can make the one simplification but Im not sure what you are asking as far as the refactoring. Provide an example and I will try to accommodate your request. I'm not going to be able to spend much more time on lldb patches though.
Jul 30 2019
I don't see anything else to address in this review. Comments?
Jul 29 2019
I can confirm this is reproducible with the master branch of llvm-project cloned from GitHub.
- Undo the change to the test client
- Remove changes for threads
- Invalidate module cache on loading/unloading DLLs
I think this change has introduced a dependence on x64.
Jul 17 2019
I believe this address all the comments.
Jul 9 2019
Jul 2 2019
removed the redundant null checks
added GetThreadHandle to simplify code
Jun 30 2019
Add a define for STATUS_WX86_BREAKPOINT.
Jun 28 2019
removed the "clang-format off" in a few places