Page MenuHomePhabricator
Feed Advanced Search

Today

courbet accepted D83119: [Alignment][NFC] Use 5 bits to store Instructions Alignment.

Cool ! Only minor comments.

Fri, Jul 3, 1:35 AM · Restricted Project
courbet accepted D83082: [Alignment][NFC] Use proper getter to retrieve alignment from ConstantInt and ConstantSDNode.
Fri, Jul 3, 1:03 AM · Restricted Project

Yesterday

courbet accepted D82981: [Alignment][NFC] VectorLayout now uses Align internally.
Thu, Jul 2, 4:15 AM · Restricted Project
courbet added inline comments to D83027: Add benchmarks for 128 bit division and create a directory for all builtins benchmarks.
Thu, Jul 2, 3:10 AM
courbet accepted D82977: [Alignment][NFC] Transition and simplify calls to DL::getABITypeAlignment.
Thu, Jul 2, 3:10 AM · Restricted Project

Wed, Jul 1

courbet accepted D82962: [Alignment][NFC] Use Align for BPFAbstractMemberAccess::RecordAlignment.
Wed, Jul 1, 8:05 AM · Restricted Project
courbet accepted D82958: [Alignment] TargetLowering::hasPairedLoad must use Align for RequiredAlignment.
Wed, Jul 1, 7:32 AM · Restricted Project
courbet accepted D82956: [Alignment][NFC] Transition and simplify calls to DL::getABITypeAlignment.
Wed, Jul 1, 7:00 AM · Restricted Project
courbet accepted D82939: [Alignment][NFC] Migrate TargetTransformInfo::CreateVariableSizedObject to Align.
Wed, Jul 1, 4:17 AM · Restricted Project
courbet accepted D82934: [Alignment][NFC] Migrate MachineFrameInfo::CreateSpillStackObject to Align.
Wed, Jul 1, 1:02 AM · Restricted Project

Tue, Jun 30

courbet accepted D82894: [Alignment][NFC] Migrate MachineFrameInfo::CreateStackObject to Align.
Tue, Jun 30, 11:57 PM · Restricted Project
courbet added inline comments to D82876: [Alignment][NFC] Migrate TargetTransformInfo::allowsMisalignedMemoryAccesses to Align.
Tue, Jun 30, 11:57 PM · Restricted Project
courbet accepted D81372: [Alignment][NFC] TargetLowering::allowsMemoryAccessForAlignment.
Tue, Jun 30, 8:06 AM · Restricted Project
courbet added inline comments to D82876: [Alignment][NFC] Migrate TargetTransformInfo::allowsMisalignedMemoryAccesses to Align.
Tue, Jun 30, 8:06 AM · Restricted Project
courbet accepted D82850: [Alignment][NFC] Migrate SelectionDAGTargetInfo::EmitTargetCodeForMemmove to Align.
Tue, Jun 30, 3:14 AM · Restricted Project
courbet accepted D82851: [Alignment][NFC] Migrate SelectionDAGTargetInfo::EmitTargetCodeForMemset to Align.
Tue, Jun 30, 3:14 AM · Restricted Project
courbet accepted D82849: [Alignment][NFC] Migrate SelectionDAGTargetInfo::EmitTargetCodeForMemcpy to Align.
Tue, Jun 30, 3:14 AM · Restricted Project
courbet accepted D82749: [Alignment][NFC] Migrate AArch64, ARM, Hexagon, MSP and NVPTX backends to Align.
Tue, Jun 30, 12:30 AM · Restricted Project
courbet accepted D82779: [Alignment][NFC] Migrate PPC, X86 and XCore backends to Align.
Tue, Jun 30, 12:30 AM · Restricted Project
courbet accepted D82785: [Alignment][NFC] TargetLowering::allowsMemoryAccess.
Tue, Jun 30, 12:30 AM · Restricted Project

Mon, Jun 29

courbet accepted D82454: [ADT] Add Bitfield utilities - design #3.
Mon, Jun 29, 5:54 AM · Restricted Project
courbet accepted D82648: [NFC] Introduce a helper in BasicTTIImpl.h to cast to T.
Mon, Jun 29, 5:21 AM · Restricted Project
courbet added inline comments to D82749: [Alignment][NFC] Migrate AArch64, ARM, Hexagon, MSP and NVPTX backends to Align.
Mon, Jun 29, 4:49 AM · Restricted Project
courbet accepted D82743: [Alignment][NFC] Migrate AMDGPU backend to Align.
Mon, Jun 29, 4:49 AM · Restricted Project
courbet accepted D82752: [Alignment][NFC] migrate DataLayout::getPreferredAlignment.
Mon, Jun 29, 4:17 AM · Restricted Project

Fri, Jun 26

courbet accepted D82653: [Alignment][NFC] Migrate TTI::isLegalToVectorize{Load,Store}Chain to Align.
Fri, Jun 26, 7:03 AM · Restricted Project
courbet accepted D82573: [Alignment][NFC] Migrate TTI::getInterleavedMemoryOpCost to Align.
Fri, Jun 26, 3:13 AM · Restricted Project
courbet accepted D82577: [Alignment][NFC] Migrate TTI::getGatherScatterOpCost to Align.
Fri, Jun 26, 3:13 AM · Restricted Project
courbet accepted D82569: [Alignment][NFC] Migrate TTI::getMaskedMemoryOpCost to Align.
Fri, Jun 26, 3:13 AM · Restricted Project
courbet accepted D81050: [llvm-exegesis] Let Counter returns up to 16 entries..
Fri, Jun 26, 12:31 AM · Restricted Project

Thu, Jun 25

courbet accepted D82307: [Alignment][NFC] Use Align for TargetCallingConv::OrigAlign.
Thu, Jun 25, 6:20 AM · Restricted Project
courbet added inline comments to D82454: [ADT] Add Bitfield utilities - design #3.
Thu, Jun 25, 2:30 AM · Restricted Project
courbet added a comment to D82307: [Alignment][NFC] Use Align for TargetCallingConv::OrigAlign.

OK but this changes the meaning of getOrigAlign(), which some downstream targets might depend on. What about doing this dynamically in getNonZeroOrigAlign() until getOrigAlign() is fully removed ?

Thu, Jun 25, 1:35 AM · Restricted Project
courbet added inline comments to D81050: [llvm-exegesis] Let Counter returns up to 16 entries..
Thu, Jun 25, 12:29 AM · Restricted Project

Mon, Jun 22

courbet added a comment to D82307: [Alignment][NFC] Use Align for TargetCallingConv::OrigAlign.

I see several places that never call setOrigAlign(), e.g. in GlobalISel CallLowering:

Mon, Jun 22, 11:25 PM · Restricted Project

Fri, Jun 19

courbet added inline comments to D81050: [llvm-exegesis] Let Counter returns up to 16 entries..
Fri, Jun 19, 5:53 AM · Restricted Project

Thu, Jun 18

courbet added inline comments to D82058: [ADT] Add Bitfield utilities - design #2.
Thu, Jun 18, 5:24 AM · Restricted Project
courbet added inline comments to D82058: [ADT] Add Bitfield utilities - design #2.
Thu, Jun 18, 2:41 AM · Restricted Project

Wed, Jun 17

courbet added inline comments to D81580: [ADT] Add Bitfield utilities - design #1.
Wed, Jun 17, 7:31 AM · Restricted Project

Tue, Jun 16

courbet accepted D81580: [ADT] Add Bitfield utilities - design #1.

I have not seen any concerns raised on the mailing lists after your proposal. Let's give it a couple more days before submitting.

Tue, Jun 16, 10:58 PM · Restricted Project
courbet accepted D81922: [llvm] Disable linking llvm-exegesis to dylib.
Tue, Jun 16, 4:23 AM · Restricted Project

Sun, Jun 14

courbet added a comment to D81809: [builtins] Optimize udivmodti4 for many platforms..

Nice. I have not looked at the code yet, but I think it would make sense to add your benchmark to the compiler-rt unit tests.

Sun, Jun 14, 11:58 PM · Restricted Project

Thu, Jun 11

courbet added a comment to D81580: [ADT] Add Bitfield utilities - design #1.

Can you create an example patch rebased on this to show how this changes the bit twiddling code for an example instruction ? Maybe this could go through an RFC ? I'm personally, this would make the code much cleaner.

Thu, Jun 11, 1:50 AM · Restricted Project

Tue, Jun 9

courbet added inline comments to D81372: [Alignment][NFC] TargetLowering::allowsMemoryAccessForAlignment.
Tue, Jun 9, 2:09 AM · Restricted Project
courbet accepted D81374: [Alignment][NFC] TargetLowering::allowsMisalignedMemoryAccesses.
Tue, Jun 9, 2:09 AM · Restricted Project
courbet accepted D81379: [Alignment][NFC] Migrate TargetLowering::allowsMemoryAccess.
Tue, Jun 9, 2:09 AM · Restricted Project

Mon, Jun 8

courbet accepted D81362: [Alignment][NFC] Deprecate dead code from CallingConvLower.h.
Mon, Jun 8, 5:57 AM · Restricted Project
courbet added a comment to D81362: [Alignment][NFC] Deprecate dead code from CallingConvLower.h.

Shouldn't this undergo a deprecation cycle ? This is a public header.

Mon, Jun 8, 3:46 AM · Restricted Project
courbet accepted D81365: [Alignment][NFC] Migrate HandleByVal to Align.
Mon, Jun 8, 2:40 AM · Restricted Project

Sun, Jun 7

courbet accepted D81278: [Alignment][NFC] Migrate the rest of backends.
Sun, Jun 7, 11:57 PM · Restricted Project
courbet accepted D81268: [Alignment][NFC] Migrate CallingConv tablegen code.
Sun, Jun 7, 11:57 PM · Restricted Project
courbet accepted D81274: [Alignment][NFC] Migrate part of Arm/AArch64 backend.
Sun, Jun 7, 11:57 PM · Restricted Project

Fri, Jun 5

courbet accepted D81196: [Alignment][NFC] Migrate CallingConv tablegen code.
Fri, Jun 5, 5:27 AM · Restricted Project

Jun 2 2020

courbet added inline comments to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
Jun 2 2020, 11:58 PM · Restricted Project
courbet added inline comments to D81050: [llvm-exegesis] Let Counter returns up to 16 entries..
Jun 2 2020, 11:58 PM · Restricted Project
courbet committed rG5b8c1ed2c802: [llvm-exegesis] Fix D80610. (authored by courbet).
[llvm-exegesis] Fix D80610.
Jun 2 2020, 1:39 AM
courbet closed D80982: [llvm-exegesis] Fix D80610..
Jun 2 2020, 1:38 AM · Restricted Project
courbet added a comment to D80982: [llvm-exegesis] Fix D80610..

Thanks

Jun 2 2020, 1:38 AM · Restricted Project
courbet created D80982: [llvm-exegesis] Fix D80610..
Jun 2 2020, 1:04 AM · Restricted Project

May 29 2020

courbet closed D76056: [MemFunctions] Add validity check..

Actually this was submitted but did not get updated for some reason.

May 29 2020, 5:23 AM · Restricted Project
courbet added a comment to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

OK, I think this is in good shape now, but we still need a test for it. The only issue is that not all buildbots support LBR, so we need a mechanism for skipping the test when not available. You can create a subdir llvm-project/llvm/test/tools/llvm-exegesis/X86/lbr with a custom lit similar to llvm-project/llvm/test/tools/llvm-exegesis/X86/lit.local.cfg to check lbr support before running the test.

May 29 2020, 4:50 AM · Restricted Project

May 28 2020

courbet accepted D80610: [llvm-exegesis] Make createCounter a virtual method on Target to allow targets to create target-specific counters.

LGTM modulo one comment.

May 28 2020, 1:02 AM · Restricted Project

May 26 2020

courbet added inline comments to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
May 26 2020, 11:22 PM · Restricted Project
courbet added a comment to D80610: [llvm-exegesis] Make createCounter a virtual method on Target to allow targets to create target-specific counters.

Can you also include making the Counter virtual, and the use of this new function in FunctionExecutorImpl::runAndMeasure ? This would remove more unrelated changes from the other patch.

May 26 2020, 11:22 PM · Restricted Project

May 25 2020

courbet added inline comments to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
May 25 2020, 11:57 PM · Restricted Project

May 18 2020

courbet committed rG521b21609434: [TargetLibraryInfo] memcpy and memset have optimized codegen. (authored by courbet).
[TargetLibraryInfo] memcpy and memset have optimized codegen.
May 18 2020, 1:02 AM
courbet closed D78991: [TargetLibraryInfo] memcpy and memset have optimized codegen..
May 18 2020, 1:02 AM · Restricted Project

May 5 2020

courbet added a reviewer for D78991: [TargetLibraryInfo] memcpy and memset have optimized codegen.: xbolva00.
May 5 2020, 11:09 PM · Restricted Project

Apr 28 2020

courbet updated the diff for D78991: [TargetLibraryInfo] memcpy and memset have optimized codegen..

Add memmove

Apr 28 2020, 4:47 AM · Restricted Project
courbet created D78991: [TargetLibraryInfo] memcpy and memset have optimized codegen..
Apr 28 2020, 3:43 AM · Restricted Project

Apr 10 2020

courbet added inline comments to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
Apr 10 2020, 6:25 AM · Restricted Project

Apr 8 2020

courbet added inline comments to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
Apr 8 2020, 11:57 PM · Restricted Project
courbet committed rG7c6514bc22c4: [llvm-exegesis] Fix build with !HAS_LIBPFM. (authored by courbet).
[llvm-exegesis] Fix build with !HAS_LIBPFM.
Apr 8 2020, 7:03 AM
courbet committed rG9fb871866e2b: [llvm-exegesis][NFC] Let the pfm::Counter own the PerfHelper. (authored by courbet).
[llvm-exegesis][NFC] Let the pfm::Counter own the PerfHelper.
Apr 8 2020, 7:02 AM
courbet added inline comments to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
Apr 8 2020, 7:02 AM · Restricted Project
courbet committed rGd2d808d2efa4: [llvm-exegesis][NFC] Remove dead code. (authored by courbet).
[llvm-exegesis][NFC] Remove dead code.
Apr 8 2020, 5:57 AM

Apr 6 2020

courbet accepted D77599: [AArch64] Don't expand memcmp in strict align mode..
Apr 6 2020, 11:25 PM · Restricted Project
courbet accepted D77538: [Alignment][NFC] Assume AlignmentFromAssumptions::getNewAlignment is always set..
Apr 6 2020, 8:06 AM · Restricted Project
courbet added inline comments to D77538: [Alignment][NFC] Assume AlignmentFromAssumptions::getNewAlignment is always set..
Apr 6 2020, 6:27 AM · Restricted Project
courbet added a comment to D77538: [Alignment][NFC] Assume AlignmentFromAssumptions::getNewAlignment is always set..

why not change the single return 0 in getNewAlignment() with return Align(1), and modify that type ?

Apr 6 2020, 4:50 AM · Restricted Project
courbet added a comment to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

And thanks for the contribution.

Apr 6 2020, 4:50 AM · Restricted Project
courbet added a comment to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

This isn't a new mode, it's still for measuring latency.

Apr 6 2020, 4:50 AM · Restricted Project
courbet accepted D77537: [Alignment][NFC] Add DebugStr and operator*.
Apr 6 2020, 4:17 AM · Restricted Project
courbet accepted D77409: [Alignment][NFC] Remove deprecated functions introduced in 10.0.0.
Apr 6 2020, 4:17 AM · Restricted Project
courbet added inline comments to D77454: LoadInst should store Align, not MaybeAlign..
Apr 6 2020, 12:30 AM · Restricted Project

Apr 5 2020

courbet accepted D77394: [Alignment][NFC] Add DebugStr and operator*.
Apr 5 2020, 11:57 PM · Restricted Project

Apr 3 2020

courbet added inline comments to D77394: [Alignment][NFC] Add DebugStr and operator*.
Apr 3 2020, 7:29 AM · Restricted Project
courbet added inline comments to D77394: [Alignment][NFC] Add DebugStr and operator*.
Apr 3 2020, 7:29 AM · Restricted Project
courbet added a comment to D77386: [Alignment][NFC] Allow to print alignment to raw_ostream.

I'd rather have every user forced to think whether they want to use the value or its internal (log) representation, e.g. .p2align vs MIR format. If only for debug, then:

Apr 3 2020, 6:24 AM · Restricted Project
courbet accepted D77312: [Alignment][NFC] Deprecate InstrTypes getRetAlignment/getParamAlignment.
Apr 3 2020, 2:39 AM · Restricted Project
courbet accepted D77297: [Alignment][NFC] Remove unused private functions.
Apr 3 2020, 2:08 AM · Restricted Project
courbet accepted D77292: [Alignment][NFC] Convert MachineIRBuilder::buildDynStackAlloc to Align.
Apr 3 2020, 2:07 AM · Restricted Project
courbet requested changes to D77292: [Alignment][NFC] Convert MachineIRBuilder::buildDynStackAlloc to Align.
Apr 3 2020, 2:07 AM · Restricted Project
courbet accepted D77372: [NFC] G_DYN_STACKALLOC realign iff align > 1, update documentation.
Apr 3 2020, 1:34 AM · Restricted Project

Apr 2 2020

courbet added inline comments to D77292: [Alignment][NFC] Convert MachineIRBuilder::buildDynStackAlloc to Align.
Apr 2 2020, 4:18 AM · Restricted Project
courbet committed rGfb4aa30f272b: [ExpandMemCmp] Allow overlaping loads in the zero-relational case. (authored by courbet).
[ExpandMemCmp] Allow overlaping loads in the zero-relational case.
Apr 2 2020, 2:41 AM
courbet closed D76133: [ExpandMemCmp] Allow overlaping loads in the zero-relational case..
Apr 2 2020, 2:41 AM · Restricted Project
courbet accepted D77291: [Alignment][NFC] Use more Align versions of various functions.
Apr 2 2020, 2:08 AM · Restricted Project
courbet added a comment to D77291: [Alignment][NFC] Use more Align versions of various functions.

Please rephrase the commit header to something more informative.

Apr 2 2020, 2:08 AM · Restricted Project
courbet added a comment to D76133: [ExpandMemCmp] Allow overlaping loads in the zero-relational case..

Thanks.

Apr 2 2020, 12:30 AM · Restricted Project