Page MenuHomePhabricator
Feed Advanced Search

Wed, Apr 17

courbet added a comment to D60719: Demonstrate how to fix freestanding for memcpy.

As discussed offline, I think this should go through an RFC process.

Wed, Apr 17, 1:37 AM · Restricted Project, Restricted Project

Thu, Apr 11

courbet retitled D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline. from [ExpandMemCmp] Improve generated code for simple non-equality compares. to [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
Thu, Apr 11, 8:38 AM · Restricted Project
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Benchmark fixture:

Thu, Apr 11, 8:31 AM · Restricted Project
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Benchmark results:

Thu, Apr 11, 8:29 AM · Restricted Project
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

There is still some test fixing to do for Power, but before I do that I'd like to get your opinion on the approach, in particular regarding the pass placement (I pretty much placed it randomly here).

Thu, Apr 11, 8:29 AM · Restricted Project
courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

[ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline.

Thu, Apr 11, 8:20 AM · Restricted Project

Wed, Apr 10

courbet accepted D60517: [llvm-exegesis] Fix serialization/deserialization of special NoRegister register (PR41448).

Thanks Roman.

Wed, Apr 10, 11:56 PM · Restricted Project
courbet committed rG48e2eb0b2718: [NFC] Fix unused variable warning. (authored by courbet).
[NFC] Fix unused variable warning.
Wed, Apr 10, 6:17 AM
courbet committed rL358080: [NFC] Fix unused variable warning..
[NFC] Fix unused variable warning.
Wed, Apr 10, 6:16 AM
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Alternatively, what do you think about making ExpandMemCmp a late IR optimization pass like the vectorizer passes?

Wed, Apr 10, 1:43 AM · Restricted Project

Fri, Apr 5

courbet updated the summary of D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
Fri, Apr 5, 8:08 AM · Restricted Project
courbet created D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
Fri, Apr 5, 8:07 AM · Restricted Project
courbet committed rG1d8c9dfe03d4: [ExpandMemCmp][NFC] Add tests for `memcmp(p, q, n) < 0` case. (authored by courbet).
[ExpandMemCmp][NFC] Add tests for `memcmp(p, q, n) < 0` case.
Fri, Apr 5, 8:02 AM
courbet committed rL357767: [ExpandMemCmp][NFC] Add tests for `memcmp(p, q, n) < 0` case..
[ExpandMemCmp][NFC] Add tests for `memcmp(p, q, n) < 0` case.
Fri, Apr 5, 8:02 AM
courbet accepted D60317: Add an option do not dump the generated object on disk.
Fri, Apr 5, 8:01 AM · Restricted Project

Wed, Apr 3

courbet added a comment to D60185: [X86] Make the post machine scheduler macrofusion-aware..

Are you sure ?

Wed, Apr 3, 4:14 AM · Restricted Project
courbet updated subscribers of D60041: [X86] Merge the different CMOV instructions for each condition code into single instructions that store the condition code as an immediate..

@lebedev.ri and @courbet Are you happy with this and D60138?

Wed, Apr 3, 2:51 AM · Restricted Project
courbet committed rG26a8ed3ac98a: [X86] Make the post machine scheduler macrofusion-aware. (authored by courbet).
[X86] Make the post machine scheduler macrofusion-aware.
Wed, Apr 3, 2:38 AM
courbet committed rL357568: [X86] Make the post machine scheduler macrofusion-aware..
[X86] Make the post machine scheduler macrofusion-aware.
Wed, Apr 3, 2:38 AM
courbet closed D60185: [X86] Make the post machine scheduler macrofusion-aware..
Wed, Apr 3, 2:37 AM · Restricted Project
courbet added a comment to D60185: [X86] Make the post machine scheduler macrofusion-aware..

Thanks Andrea.

Wed, Apr 3, 2:37 AM · Restricted Project
courbet created D60185: [X86] Make the post machine scheduler macrofusion-aware..
Wed, Apr 3, 1:42 AM · Restricted Project
courbet committed rG5bfa946d6940: [X86][NFC] Add tests for misched macro-fusion. (authored by courbet).
[X86][NFC] Add tests for misched macro-fusion.
Wed, Apr 3, 1:21 AM
courbet committed rL357565: [X86][NFC] Add tests for misched macro-fusion..
[X86][NFC] Add tests for misched macro-fusion.
Wed, Apr 3, 1:21 AM

Mon, Apr 1

courbet committed rG7e062c9b1f9a: [X86] Make post-ra scheduling macrofusion-aware. (authored by courbet).
[X86] Make post-ra scheduling macrofusion-aware.
Mon, Apr 1, 6:48 AM
courbet committed rL357384: [X86] Make post-ra scheduling macrofusion-aware..
[X86] Make post-ra scheduling macrofusion-aware.
Mon, Apr 1, 6:47 AM
courbet closed D59688: [X86] Make post-ra scheduling macrofusion-aware..
Mon, Apr 1, 6:47 AM · Restricted Project
courbet updated the diff for D59688: [X86] Make post-ra scheduling macrofusion-aware..

Add tests.

Mon, Apr 1, 6:39 AM · Restricted Project
courbet committed rGd9f6ee1c3cc6: [X86MacroFusion][NFC] Add more tests. (authored by courbet).
[X86MacroFusion][NFC] Add more tests.
Mon, Apr 1, 6:18 AM
courbet committed rL357381: [X86MacroFusion][NFC] Add more tests..
[X86MacroFusion][NFC] Add more tests.
Mon, Apr 1, 6:18 AM
courbet added inline comments to D60057: [llvm-exegesis] Handle CMOV's OPERAND_COND_CODE OperandType.
Mon, Apr 1, 5:23 AM · Restricted Project
courbet added a comment to D60057: [llvm-exegesis] Handle CMOV's OPERAND_COND_CODE OperandType.

Thanks Roman. I only have a comment regarding documentation.

Mon, Apr 1, 4:36 AM · Restricted Project
courbet added a comment to D60000: [llvm-exegesis] Post-processing for chained instrs in latency mode (PR41275).

I'll let gchatelet@ review that one as he started looking at doing that some time ago.

Mon, Apr 1, 4:24 AM · Restricted Project
courbet added a comment to D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..

OK, I succeeded in profiling this using pprof instead of callgrind.

Mon, Apr 1, 2:18 AM · Restricted Project
courbet added a comment to D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..

Could that be the reason for the regression ?

Mon, Apr 1, 2:11 AM · Restricted Project
courbet added a comment to D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..

This made pdfium use 6.8% more cpu, https://bugs.chromium.org/p/chromium/issues/detail?id=947611

Since the intent here was to make things faster, any ideas how this could happen?

Mon, Apr 1, 1:17 AM · Restricted Project

Fri, Mar 29

courbet accepted D59994: [NFC][llvm-exegesis] Also promote getSchedClassPoint() into ResolvedSchedClass..
Fri, Mar 29, 7:53 AM · Restricted Project
courbet accepted D59993: [NFC][llvm-exegesis] Refactor ResolvedSchedClass & friends.
Fri, Mar 29, 7:16 AM · Restricted Project
courbet closed D59689: [ScheduleDAG] Move `Topo` and `addEdge` to base class..

Submitted as 357239.

Fri, Mar 29, 6:56 AM · Restricted Project
courbet accepted D59951: [NFC][llvm-exegesis] Refactor Analysis::SchedClassCluster::measurementsMatch().

Thanks Roman.

Fri, Mar 29, 3:53 AM · Restricted Project
courbet accepted D59795: [DAGCombine] Improve Lifetime node chains..

Thanks, just one nit.

Fri, Mar 29, 1:41 AM · Restricted Project
courbet committed rGb70355f0b49c: [ScheduleDAG] Move `Topo` and `addEdge` to base class. (authored by courbet).
[ScheduleDAG] Move `Topo` and `addEdge` to base class.
Fri, Mar 29, 1:33 AM
courbet committed rL357239: [ScheduleDAG] Move `Topo` and `addEdge` to base class..
[ScheduleDAG] Move `Topo` and `addEdge` to base class.
Fri, Mar 29, 1:32 AM

Thu, Mar 28

courbet planned changes to D59688: [X86] Make post-ra scheduling macrofusion-aware..

What about CPU's that specify let PostRAScheduler = 1; ?

Thu, Mar 28, 9:35 AM · Restricted Project
courbet added a comment to D59688: [X86] Make post-ra scheduling macrofusion-aware..

This could use test coverage i guess?

Thu, Mar 28, 8:47 AM · Restricted Project
courbet added a comment to D59688: [X86] Make post-ra scheduling macrofusion-aware..

I don't think is a blocking issue, but in future we should revisit the logic in X86MacroFusion.

Thu, Mar 28, 8:09 AM · Restricted Project
courbet added a comment to D59928: [MCA] Add an experimental MicroOpQueue stage..

Only cosmetic comments, this looks good !

Thu, Mar 28, 7:41 AM · Restricted Project
courbet committed rG699dc025a625: [X86MacroFusion] Handle branch fusion (AMD CPUs). (authored by courbet).
[X86MacroFusion] Handle branch fusion (AMD CPUs).
Thu, Mar 28, 7:12 AM
courbet committed rL357171: [X86MacroFusion] Handle branch fusion (AMD CPUs)..
[X86MacroFusion] Handle branch fusion (AMD CPUs).
Thu, Mar 28, 7:12 AM
courbet closed D59872: [X86MacroFusion] Handle branch fusion (AMD CPUs)..
Thu, Mar 28, 7:12 AM · Restricted Project
courbet added a comment to D59872: [X86MacroFusion] Handle branch fusion (AMD CPUs)..

Thanks for the review.

Thu, Mar 28, 7:12 AM · Restricted Project
courbet added inline comments to D59872: [X86MacroFusion] Handle branch fusion (AMD CPUs)..
Thu, Mar 28, 6:44 AM · Restricted Project
courbet updated the diff for D59872: [X86MacroFusion] Handle branch fusion (AMD CPUs)..

Address review comments, rebase.

Thu, Mar 28, 6:44 AM · Restricted Project
courbet committed rG54c95e5172fb: [NFC] Format InlineFeatureIgnoreList. (authored by courbet).
[NFC] Format InlineFeatureIgnoreList.
Thu, Mar 28, 6:38 AM
courbet committed rL357168: [NFC] Format InlineFeatureIgnoreList..
[NFC] Format InlineFeatureIgnoreList.
Thu, Mar 28, 6:38 AM
courbet accepted D59820: [llvm-exegesis] Introduce a 'naive' clustering algorithm (PR40880).
Thu, Mar 28, 12:48 AM · Restricted Project

Wed, Mar 27

courbet added inline comments to D59872: [X86MacroFusion] Handle branch fusion (AMD CPUs)..
Wed, Mar 27, 10:50 AM · Restricted Project
courbet updated the diff for D59872: [X86MacroFusion] Handle branch fusion (AMD CPUs)..

Add tests.

Wed, Mar 27, 10:50 AM · Restricted Project
courbet updated the diff for D59872: [X86MacroFusion] Handle branch fusion (AMD CPUs)..

Update comment, swap features.

Wed, Mar 27, 10:50 AM · Restricted Project
courbet committed rGf8666b0649f8: [X86MacroFusion][NFC] Add a bulldozer test. (authored by courbet).
[X86MacroFusion][NFC] Add a bulldozer test.
Wed, Mar 27, 10:44 AM
courbet committed rL357099: [X86MacroFusion][NFC] Add a bulldozer test..
[X86MacroFusion][NFC] Add a bulldozer test.
Wed, Mar 27, 10:43 AM
courbet committed rG678d128b5ab6: [X86MacroFusion][NFC] Improve macrofusion testing. (authored by courbet).
[X86MacroFusion][NFC] Improve macrofusion testing.
Wed, Mar 27, 8:43 AM
courbet committed rL357076: [X86MacroFusion][NFC] Improve macrofusion testing..
[X86MacroFusion][NFC] Improve macrofusion testing.
Wed, Mar 27, 8:43 AM
courbet added a comment to D59821: [llvm-exegesis] Allow the target to disable the selection of some registers..

OK cool thanks for having a look.

Wed, Mar 27, 8:16 AM · Restricted Project
courbet added inline comments to D59820: [llvm-exegesis] Introduce a 'naive' clustering algorithm (PR40880).
Wed, Mar 27, 7:30 AM · Restricted Project
courbet added inline comments to D59795: [DAGCombine] Improve Lifetime node chains..
Wed, Mar 27, 5:01 AM · Restricted Project
courbet accepted D59794: [DAGCombiner] Unify Lifetime and memory Op aliasing..
Wed, Mar 27, 5:00 AM · Restricted Project
courbet updated the diff for D59872: [X86MacroFusion] Handle branch fusion (AMD CPUs)..

clang-format

Wed, Mar 27, 4:46 AM · Restricted Project
courbet created D59872: [X86MacroFusion] Handle branch fusion (AMD CPUs)..
Wed, Mar 27, 4:46 AM · Restricted Project
courbet added inline comments to D59820: [llvm-exegesis] Introduce a 'naive' clustering algorithm (PR40880).
Wed, Mar 27, 3:10 AM · Restricted Project
courbet added inline comments to D59820: [llvm-exegesis] Introduce a 'naive' clustering algorithm (PR40880).
Wed, Mar 27, 2:57 AM · Restricted Project
courbet added inline comments to D59820: [llvm-exegesis] Introduce a 'naive' clustering algorithm (PR40880).
Wed, Mar 27, 2:14 AM · Restricted Project
courbet added a comment to D59821: [llvm-exegesis] Allow the target to disable the selection of some registers..

What protects R8-R15 in 32-bit mode or SIL/DIL/BPL/SPL?

Wed, Mar 27, 1:33 AM · Restricted Project

Tue, Mar 26

courbet committed rG52da938cd0e1: [llvm-exegesis] Allow the target to disable the selection of some registers. (authored by courbet).
[llvm-exegesis] Allow the target to disable the selection of some registers.
Tue, Mar 26, 8:46 AM
courbet committed rL357003: [llvm-exegesis] Allow the target to disable the selection of some registers..
[llvm-exegesis] Allow the target to disable the selection of some registers.
Tue, Mar 26, 8:43 AM
courbet closed D59821: [llvm-exegesis] Allow the target to disable the selection of some registers..
Tue, Mar 26, 8:43 AM · Restricted Project
courbet updated the diff for D59821: [llvm-exegesis] Allow the target to disable the selection of some registers..

Add unit test.

Tue, Mar 26, 8:34 AM · Restricted Project
courbet added a comment to D59821: [llvm-exegesis] Allow the target to disable the selection of some registers..

The issue is that such a test would have failed in a non-deterministic manner, which is why I've only added a unit test. But now that this should not longer fail, let's add one.

Tue, Mar 26, 8:30 AM · Restricted Project
courbet added inline comments to D59820: [llvm-exegesis] Introduce a 'naive' clustering algorithm (PR40880).
Tue, Mar 26, 8:29 AM · Restricted Project
courbet created D59821: [llvm-exegesis] Allow the target to disable the selection of some registers..
Tue, Mar 26, 7:44 AM · Restricted Project
courbet added a comment to D59539: [llvm-exegesis] Option to lobotomize dbscan (PR40880).

To reword: because if i do simple clustering by opcode, i will then need to add yet another
"stabilization" step - for each cluster, check that every measurement is neighbor of all
the other points in that cluster, and if they are not, mark cluster as noise.
(well, not every vs. every, just the lower/upper triangle excluding diagonal)

Tue, Mar 26, 2:31 AM · Restricted Project
courbet added a comment to D59795: [DAGCombine] Improve Lifetime node chains..

Nice !

Tue, Mar 26, 12:59 AM · Restricted Project
courbet added inline comments to D59794: [DAGCombiner] Unify Lifetime and memory Op aliasing..
Tue, Mar 26, 12:52 AM · Restricted Project

Mon, Mar 25

courbet committed rCTE356871: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment.
[clang-tidy] Fix more false positives for bugprone-string-integer-assignment
Mon, Mar 25, 1:17 AM
courbet committed rGd8e78022c63b: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment (authored by courbet).
[clang-tidy] Fix more false positives for bugprone-string-integer-assignment
Mon, Mar 25, 1:17 AM
courbet committed rL356871: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment.
[clang-tidy] Fix more false positives for bugprone-string-integer-assignment
Mon, Mar 25, 1:16 AM
courbet closed D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment.
Mon, Mar 25, 1:16 AM · Restricted Project, Restricted Project

Mar 22 2019

courbet added inline comments to D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment.
Mar 22 2019, 8:27 AM · Restricted Project, Restricted Project
courbet updated the diff for D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment.

Ignore template contexts and add a test.

Mar 22 2019, 8:27 AM · Restricted Project, Restricted Project
courbet committed rGc08b26edb8eb: [llvm-exegesis] Fix compilation before c++17. (authored by courbet).
[llvm-exegesis] Fix compilation before c++17.
Mar 22 2019, 6:38 AM
courbet committed rL356748: [llvm-exegesis] Fix compilation before c++17..
[llvm-exegesis] Fix compilation before c++17.
Mar 22 2019, 6:38 AM
courbet added a comment to D59688: [X86] Make post-ra scheduling macrofusion-aware..

I plan to run some experiments today using your patch.

Mar 22 2019, 6:28 AM · Restricted Project
courbet committed rG28550779638d: [llvm-exegesis] Add clustering test. (authored by courbet).
[llvm-exegesis] Add clustering test.
Mar 22 2019, 6:13 AM
courbet committed rL356747: [llvm-exegesis] Add clustering test..
[llvm-exegesis] Add clustering test.
Mar 22 2019, 6:13 AM
courbet closed D59693: [llvm-exegesis] Add clustering test..
Mar 22 2019, 6:13 AM · Restricted Project
courbet added a comment to D59693: [llvm-exegesis] Add clustering test..

Thanks.

Mar 22 2019, 6:11 AM · Restricted Project
courbet added a comment to D59539: [llvm-exegesis] Option to lobotomize dbscan (PR40880).

To make my suggestion clearer: if you just want to compare measured instruction data to its checked-in data, why not cluster by instruction opcode (to merge the several measurements for a given instruction) and run the analysis on that ?

Mar 22 2019, 6:11 AM · Restricted Project
courbet created D59693: [llvm-exegesis] Add clustering test..
Mar 22 2019, 6:07 AM · Restricted Project
courbet added a reviewer for D59693: [llvm-exegesis] Add clustering test.: gchatelet.
Mar 22 2019, 6:07 AM · Restricted Project
courbet added a comment to D59539: [llvm-exegesis] Option to lobotomize dbscan (PR40880).

I'm not saying that this *is* The solution, but i do believe the problem exists,
and i'm not sure what other approaches are there to solve it..

There is another bug there, i suppose, we really should sort the measurements we loaded.

Mar 22 2019, 6:07 AM · Restricted Project