Page MenuHomePhabricator
Feed Advanced Search

Tue, Jun 11

courbet committed rGf63feaf3c2ff: [clang-tidy] Fix typo in bugprone-string-constructor. (authored by courbet).
[clang-tidy] Fix typo in bugprone-string-constructor.
Tue, Jun 11, 5:09 AM
courbet committed rL363053: [clang-tidy] Fix typo in bugprone-string-constructor..
[clang-tidy] Fix typo in bugprone-string-constructor.
Tue, Jun 11, 5:09 AM

Thu, Jun 6

courbet updated the diff for D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.

Fix formatting

Thu, Jun 6, 6:37 AM · Restricted Project
courbet updated the diff for D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.
  • Mark ldmxscr as writing to memory. Unfortunately the DAG relies on intrinsics writing to memory to determine side-effet-ness.
  • Mark stmxscr as having side effects, as discusse din the review.
  • Update tests.
Thu, Jun 6, 6:37 AM · Restricted Project
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Ping

Thu, Jun 6, 5:58 AM · Restricted Project

Wed, Jun 5

courbet added a comment to D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.

A side effecting instruction doesn't prevent other non-side effecting instructions from moving across it.

Wed, Jun 5, 9:12 AM · Restricted Project
courbet added a comment to D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.

Don’t we need stmxcsr to have side effects to keep it from reordering relative to ldmxcsr?

Wed, Jun 5, 8:59 AM · Restricted Project
courbet added a comment to D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.

There are a bunch of tests to update, but I'd like to get opinions on this before going further. I'm not sure why the properties were not already there. Did I miss something ?

Wed, Jun 5, 3:59 AM · Restricted Project
courbet created D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.
Wed, Jun 5, 3:04 AM · Restricted Project

Mon, Jun 3

courbet added a comment to D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional..

Thanks.

Mon, Jun 3, 6:40 AM · Restricted Project
courbet added inline comments to D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional..
Mon, Jun 3, 6:21 AM · Restricted Project
courbet added a reviewer for D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional.: probinson.
Mon, Jun 3, 5:29 AM · Restricted Project
courbet added inline comments to D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional..
Mon, Jun 3, 5:28 AM · Restricted Project
courbet added a reviewer for D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional.: aprantl.
Mon, Jun 3, 2:05 AM · Restricted Project
courbet created D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional..
Mon, Jun 3, 2:02 AM · Restricted Project

Tue, May 28

courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Make ExpandMemCmp preserve the DomTree.

Tue, May 28, 9:09 AM · Restricted Project

Fri, May 24

courbet accepted D62360: [X86] Add zero idioms to the haswell, broadwell, and skylake schedule models. Add 256-bit fp xor to sandybridge zero idioms.

Thanks.

Fri, May 24, 2:38 AM · Restricted Project

Thu, May 23

courbet committed rG43882b16a343: [MergeICmps] Make the pass compatible with the new pass manager. (authored by courbet).
[MergeICmps] Make the pass compatible with the new pass manager.
Thu, May 23, 5:34 AM
courbet committed rL361490: [MergeICmps] Make the pass compatible with the new pass manager..
[MergeICmps] Make the pass compatible with the new pass manager.
Thu, May 23, 5:32 AM
courbet closed D62287: [MergeICmps] Make the pass compatible with the new pass manager..
Thu, May 23, 5:32 AM · Restricted Project
courbet added a comment to D62287: [MergeICmps] Make the pass compatible with the new pass manager..

Thanks.

Thu, May 23, 5:32 AM · Restricted Project

Wed, May 22

courbet created D62287: [MergeICmps] Make the pass compatible with the new pass manager..
Wed, May 22, 11:57 PM · Restricted Project
courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Rebase

Wed, May 22, 7:12 AM · Restricted Project
courbet committed rGb9274f269498: [llvm-exegesis] Move native target initialization code to a separate file. (authored by courbet).
[llvm-exegesis] Move native target initialization code to a separate file.
Wed, May 22, 6:51 AM
courbet committed rL361385: [llvm-exegesis] Move native target initialization code to a separate file..
[llvm-exegesis] Move native target initialization code to a separate file.
Wed, May 22, 6:51 AM
courbet closed D62239: [llvm-exegesis] Move native target initialization code to a separate file..
Wed, May 22, 6:51 AM · Restricted Project
courbet updated the diff for D62239: [llvm-exegesis] Move native target initialization code to a separate file..

add missing inline

Wed, May 22, 6:42 AM · Restricted Project
courbet created D62239: [llvm-exegesis] Move native target initialization code to a separate file..
Wed, May 22, 2:52 AM · Restricted Project
courbet committed rGf8f93ba90d26: Re-land r361257 "[MergeICmps][NFC] Make BCEAtom move-only."" (authored by courbet).
Re-land r361257 "[MergeICmps][NFC] Make BCEAtom move-only.""
Wed, May 22, 2:44 AM
courbet committed rL361366: Re-land r361257 "[MergeICmps][NFC] Make BCEAtom move-only."".
Re-land r361257 "[MergeICmps][NFC] Make BCEAtom move-only.""
Wed, May 22, 2:43 AM

Tue, May 21

courbet committed rG122c6e6f3689: [MergeICmps] Make sorting strongly stable on the rhs. (authored by courbet).
[MergeICmps] Make sorting strongly stable on the rhs.
Tue, May 21, 10:57 AM
courbet committed rL361281: [MergeICmps] Make sorting strongly stable on the rhs..
[MergeICmps] Make sorting strongly stable on the rhs.
Tue, May 21, 10:56 AM
courbet closed D62193: [MergeICmps] Make sorting strongly stable on the rhs..
Tue, May 21, 10:56 AM · Restricted Project
courbet committed rG8361a10493c5: Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only." (authored by courbet).
Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only."
Tue, May 21, 7:24 AM
courbet committed rL361263: Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only.".
Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only."
Tue, May 21, 7:24 AM
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

@courbet Please can you ensure you have EXPENSIVE_CHECKS enabled in all your builds before going any further - you've been breaking the buildbots for well over a week now and you still haven't fixed the underlying issue.

Tue, May 21, 7:11 AM · Restricted Project
courbet created D62193: [MergeICmps] Make sorting strongly stable on the rhs..
Tue, May 21, 6:45 AM · Restricted Project
courbet committed rG8fa970c2d871: [MergeICmps][NFC] Make BCEAtom move-only. (authored by courbet).
[MergeICmps][NFC] Make BCEAtom move-only.
Tue, May 21, 6:33 AM
courbet committed rL361257: [MergeICmps][NFC] Make BCEAtom move-only..
[MergeICmps][NFC] Make BCEAtom move-only.
Tue, May 21, 6:31 AM
courbet committed rGa95d95d3922e: [MergeICmps] Preserve the dominator tree. (authored by courbet).
[MergeICmps] Preserve the dominator tree.
Tue, May 21, 4:02 AM
courbet committed rL361239: [MergeICmps] Preserve the dominator tree..
[MergeICmps] Preserve the dominator tree.
Tue, May 21, 4:01 AM
courbet closed D62068: [MergeICmps] Preserve the dominator tree..
Tue, May 21, 4:01 AM · Restricted Project
courbet added a comment to D62068: [MergeICmps] Preserve the dominator tree..

Thanks.

Tue, May 21, 2:25 AM · Restricted Project
courbet updated the diff for D62068: [MergeICmps] Preserve the dominator tree..

Address comments.

Tue, May 21, 2:25 AM · Restricted Project

May 17 2019

courbet updated the diff for D62068: [MergeICmps] Preserve the dominator tree..

remove debug

May 17 2019, 8:29 AM · Restricted Project
courbet created D62068: [MergeICmps] Preserve the dominator tree..
May 17 2019, 8:27 AM · Restricted Project
courbet committed rG90900fbc9fdf: [MergeICmps][NFC] Add more debug. (authored by courbet).
[MergeICmps][NFC] Add more debug.
May 17 2019, 5:06 AM
courbet committed rL361024: [MergeICmps][NFC] Add more debug..
[MergeICmps][NFC] Add more debug.
May 17 2019, 5:05 AM
courbet committed rG632dfdda16bb: Re-land r360859: "[MergeICmps] Simplify the code." (authored by courbet).
Re-land r360859: "[MergeICmps] Simplify the code."
May 17 2019, 2:42 AM
courbet committed rL361009: Re-land r360859: "[MergeICmps] Simplify the code.".
Re-land r360859: "[MergeICmps] Simplify the code."
May 17 2019, 2:41 AM
courbet committed rG580ff1e72a14: [MergeICmps] Add test from PR41917. (authored by courbet).
[MergeICmps] Add test from PR41917.
May 17 2019, 1:54 AM
courbet committed rL361001: [MergeICmps] Add test from PR41917..
[MergeICmps] Add test from PR41917.
May 17 2019, 1:49 AM

May 16 2019

courbet committed rG3a0e6e1c6c96: [DominatorTree] Print roots unconditionally in `print()`. (authored by courbet).
[DominatorTree] Print roots unconditionally in `print()`.
May 16 2019, 5:48 AM
courbet committed rL360886: [DominatorTree] Print roots unconditionally in `print()`..
[DominatorTree] Print roots unconditionally in `print()`.
May 16 2019, 5:47 AM
courbet closed D61999: [DominatorTree] Print roots unconditionally in `print()`..
May 16 2019, 5:47 AM · Restricted Project
courbet added a comment to D61999: [DominatorTree] Print roots unconditionally in `print()`..

Thanks.

May 16 2019, 5:47 AM · Restricted Project
courbet added a comment to D61999: [DominatorTree] Print roots unconditionally in `print()`..

Do we have a test for this? I don't think it is a problem but if we do we could update it. Otherwise, LGTM.

May 16 2019, 5:47 AM · Restricted Project
courbet created D61999: [DominatorTree] Print roots unconditionally in `print()`..
May 16 2019, 3:43 AM · Restricted Project

May 15 2019

courbet committed rGc4fdd717efa4: Reland r360771 "[MergeICmps] Simplify the code." (authored by courbet).
Reland r360771 "[MergeICmps] Simplify the code."
May 15 2019, 11:16 PM
courbet committed rL360859: Reland r360771 "[MergeICmps] Simplify the code.".
Reland r360771 "[MergeICmps] Simplify the code."
May 15 2019, 11:16 PM
courbet committed rGeaf4413d2d9d: Revert r360771 "[MergeICmps] Simplify the code." (authored by courbet).
Revert r360771 "[MergeICmps] Simplify the code."
May 15 2019, 7:21 AM
courbet committed rL360776: Revert r360771 "[MergeICmps] Simplify the code.".
Revert r360771 "[MergeICmps] Simplify the code."
May 15 2019, 7:21 AM
courbet committed rG0d071be47486: [MergeICmps] Fix r360771. (authored by courbet).
[MergeICmps] Fix r360771.
May 15 2019, 6:59 AM
courbet committed rL360775: [MergeICmps] Fix r360771..
[MergeICmps] Fix r360771.
May 15 2019, 6:59 AM
courbet committed rG157ae639fa64: [MergeICmps] Simplify the code. (authored by courbet).
[MergeICmps] Simplify the code.
May 15 2019, 6:05 AM
courbet committed rL360771: [MergeICmps] Simplify the code..
[MergeICmps] Simplify the code.
May 15 2019, 6:04 AM
courbet closed D61736: [MergeICmps] Simplify the code..
May 15 2019, 6:04 AM · Restricted Project
courbet added a comment to D61736: [MergeICmps] Simplify the code..

Thanks.

May 15 2019, 5:58 AM · Restricted Project
courbet updated the diff for D61736: [MergeICmps] Simplify the code..

Cosmetics.

May 15 2019, 5:58 AM · Restricted Project
courbet updated the diff for D61736: [MergeICmps] Simplify the code..
  • address comments
  • update tests with named blocks.
May 15 2019, 5:16 AM · Restricted Project
courbet added a comment to D61736: [MergeICmps] Simplify the code..

Thanks, PTAL.

May 15 2019, 5:16 AM · Restricted Project
courbet closed D58379: [compiler-rt] Intercept the bcmp() function..
May 15 2019, 1:40 AM · Restricted Project, Restricted Project
courbet committed rGd9d0665d1c6b: [[DAGCombiner][NFC] Add a comment. (authored by courbet).
[[DAGCombiner][NFC] Add a comment.
May 15 2019, 1:19 AM
courbet committed rL360755: [[DAGCombiner][NFC] Add a comment..
[[DAGCombiner][NFC] Add a comment.
May 15 2019, 1:19 AM
courbet added inline comments to D61846: [DAGCombiner] Fix invalid alias analysis..
May 15 2019, 1:19 AM · Restricted Project

May 13 2019

courbet committed rG9afc4764dd24: [DAGCombiner] Fix invalid alias analysis. (authored by courbet).
[DAGCombiner] Fix invalid alias analysis.
May 13 2019, 2:09 AM
courbet committed rL360566: [DAGCombiner] Fix invalid alias analysis..
[DAGCombiner] Fix invalid alias analysis.
May 13 2019, 2:09 AM
courbet closed D61846: [DAGCombiner] Fix invalid alias analysis..
May 13 2019, 2:09 AM · Restricted Project
courbet added a comment to D61846: [DAGCombiner] Fix invalid alias analysis..

Thanks.

May 13 2019, 2:04 AM · Restricted Project
courbet added inline comments to D61846: [DAGCombiner] Fix invalid alias analysis..
May 13 2019, 1:54 AM · Restricted Project
courbet updated the diff for D61846: [DAGCombiner] Fix invalid alias analysis..

Rebase.

May 13 2019, 1:52 AM · Restricted Project
courbet committed rGc4e37fd9b298: [DAGCombiner][NFC] Commit test to show fix in D61846. (authored by courbet).
[DAGCombiner][NFC] Commit test to show fix in D61846.
May 13 2019, 1:14 AM
courbet committed rL360561: [DAGCombiner][NFC] Commit test to show fix in D61846..
[DAGCombiner][NFC] Commit test to show fix in D61846.
May 13 2019, 1:13 AM
courbet created D61846: [DAGCombiner] Fix invalid alias analysis..
May 13 2019, 1:10 AM · Restricted Project

May 9 2019

courbet updated the diff for D61736: [MergeICmps] Simplify the code..

Forgot two test files.

May 9 2019, 8:42 AM · Restricted Project
courbet created D61736: [MergeICmps] Simplify the code..
May 9 2019, 8:39 AM · Restricted Project
courbet retitled D61736: [MergeICmps] Simplify the code. from [MergeICmps][NFC] Re-generate tests with update_test_checks. to [MergeICmps][NFCI] Simplify the code..
May 9 2019, 8:39 AM · Restricted Project
courbet retitled D61736: [MergeICmps] Simplify the code. from [MergeICmps][NFCI] Simplify the code. to [MergeICmps] Simplify the code..
May 9 2019, 8:39 AM · Restricted Project
courbet committed rGfa18e6b080b8: [MergeICmps][NFC] Re-generate tests with update_test_checks. (authored by courbet).
[MergeICmps][NFC] Re-generate tests with update_test_checks.
May 9 2019, 1:36 AM
courbet committed rL360319: [MergeICmps][NFC] Re-generate tests with update_test_checks..
[MergeICmps][NFC] Re-generate tests with update_test_checks.
May 9 2019, 1:35 AM
courbet committed rGfb0f66ddb33d: [NFC] Fix typo. (authored by courbet).
[NFC] Fix typo.
May 9 2019, 12:11 AM
courbet committed rL360314: [NFC] Fix typo..
[NFC] Fix typo.
May 9 2019, 12:10 AM

May 6 2019

courbet planned changes to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Thanks Eli.

May 6 2019, 11:38 PM · Restricted Project
courbet added inline comments to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
May 6 2019, 8:09 AM · Restricted Project
courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Fixing RUN lines for PowerPC opt tests.

May 6 2019, 8:04 AM · Restricted Project
courbet accepted D61593: [NFC] Modernize repmovsb implementation of x86 memcpy..

Only nits.

May 6 2019, 7:44 AM · Restricted Project
courbet added inline comments to D61593: [NFC] Modernize repmovsb implementation of x86 memcpy..
May 6 2019, 7:16 AM · Restricted Project
courbet committed rG9e1f2a7fe758: [SimplifyLibCalls] Simplify bcmp too. (authored by courbet).
[SimplifyLibCalls] Simplify bcmp too.
May 6 2019, 2:14 AM
courbet committed rL360021: [SimplifyLibCalls] Simplify bcmp too..
[SimplifyLibCalls] Simplify bcmp too.
May 6 2019, 2:14 AM
courbet closed D61585: [SimplifyLibCalls] Simplify bcmp too..
May 6 2019, 2:14 AM · Restricted Project