Page MenuHomePhabricator
Feed Advanced Search

Jul 18 2019

courbet added a comment to D64805: [AArch64] Expand bcmp() for small comparisons.

FYI there are some benchmarks in https://reviews.llvm.org/D64082 that are not submitted but could be used as basis for making decisions for this patch.

Jul 18 2019, 6:19 AM · Restricted Project

Jul 3 2019

courbet added inline comments to D64082: [MemFunctions] Add microbenchmarks for memory functions..
Jul 3 2019, 5:29 AM · Restricted Project
courbet updated the diff for D64082: [MemFunctions] Add microbenchmarks for memory functions..

Clarify top comment.

Jul 3 2019, 5:29 AM · Restricted Project
courbet added inline comments to D64082: [MemFunctions] Add microbenchmarks for memory functions..
Jul 3 2019, 5:15 AM · Restricted Project
courbet updated the diff for D64082: [MemFunctions] Add microbenchmarks for memory functions..

Add comment for buffer size.

Jul 3 2019, 5:12 AM · Restricted Project
courbet updated the diff for D64082: [MemFunctions] Add microbenchmarks for memory functions..

Name magical constant.

Jul 3 2019, 5:10 AM · Restricted Project
courbet updated the diff for D64082: [MemFunctions] Add microbenchmarks for memory functions..

Be evel less permissive as to what we allow the compiler to see.

Jul 3 2019, 3:50 AM · Restricted Project
courbet added inline comments to D64082: [MemFunctions] Add microbenchmarks for memory functions..
Jul 3 2019, 3:50 AM · Restricted Project
courbet added a reviewer for D64082: [MemFunctions] Add microbenchmarks for memory functions.: lebedev.ri.
Jul 3 2019, 2:36 AM · Restricted Project
courbet added a comment to D64082: [MemFunctions] Add microbenchmarks for memory functions..

Thanks for working on this! I'm not familiar with how the benchmarking framework works, so someone else should definitely have a look.

Does the framework automatically account for and filter out noisy results? I'm guessing that tiny memcmp() will have a lot of run-to-run variation.

Jul 3 2019, 2:36 AM · Restricted Project
courbet updated the diff for D64082: [MemFunctions] Add microbenchmarks for memory functions..

Address review comments.

Jul 3 2019, 2:36 AM · Restricted Project
courbet added a comment to D64082: [MemFunctions] Add microbenchmarks for memory functions..

Thanks Roman.

Jul 3 2019, 2:36 AM · Restricted Project

Jul 2 2019

courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

test-suite benchmarks: https://reviews.llvm.org/D64082

Jul 2 2019, 9:05 AM · Restricted Project
courbet created D64082: [MemFunctions] Add microbenchmarks for memory functions..
Jul 2 2019, 8:53 AM · Restricted Project

Jun 27 2019

courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

For information, I had to roll this back at it breaks sanitizers. Sanitizer passes insert some nobuiltin attributes on all memcmp calls to prevent expansion and still be able to intercept them (maybeMarkSanitizerLibraryCallNoBuiltin), and these passes are added last in opt:

Jun 27 2019, 5:39 AM · Restricted Project

Jun 26 2019

courbet committed rG2851248fa141: Revert "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt… (authored by courbet).
Revert "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt…
Jun 26 2019, 5:14 AM
courbet committed rL364416: Revert "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt….
Revert "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt…
Jun 26 2019, 5:14 AM
courbet committed rL364412: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
[ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline.
Jun 26 2019, 4:52 AM
courbet committed rG7b3a5f0e6da8: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline. (authored by courbet).
[ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline.
Jun 26 2019, 4:52 AM
courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

clang-format

Jun 26 2019, 4:45 AM · Restricted Project
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

I encourage adding small memcmp tests to test-suite as a follow-up, so we know that things won't break going forward.

Jun 26 2019, 2:20 AM · Restricted Project
courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Rebase on r364384.

Jun 26 2019, 2:14 AM · Restricted Project
courbet committed rGbe98e0ab7895: [ExpandMemCmp] Honor prefer-vector-width. (authored by courbet).
[ExpandMemCmp] Honor prefer-vector-width.
Jun 26 2019, 12:10 AM
courbet committed rL364384: [ExpandMemCmp] Honor prefer-vector-width..
[ExpandMemCmp] Honor prefer-vector-width.
Jun 26 2019, 12:09 AM
courbet closed D63769: [ExpandMemCmp] Honor prefer-vector-width..
Jun 26 2019, 12:09 AM · Restricted Project
courbet added a comment to D63769: [ExpandMemCmp] Honor prefer-vector-width..

Thanks.

Jun 26 2019, 12:09 AM · Restricted Project

Jun 25 2019

courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Remove asm testing.

Jun 25 2019, 7:48 AM · Restricted Project
courbet added inline comments to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
Jun 25 2019, 7:21 AM · Restricted Project
courbet created D63769: [ExpandMemCmp] Honor prefer-vector-width..
Jun 25 2019, 7:21 AM · Restricted Project
courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Split off options refactoring to r364281, rebase.

Jun 25 2019, 1:51 AM · Restricted Project
courbet committed rL364281: [ExpandMemCmp] Move all options to TargetTransformInfo..
[ExpandMemCmp] Move all options to TargetTransformInfo.
Jun 25 2019, 1:10 AM
courbet committed rG3bc5ad551a4f: [ExpandMemCmp] Move all options to TargetTransformInfo. (authored by courbet).
[ExpandMemCmp] Move all options to TargetTransformInfo.
Jun 25 2019, 1:08 AM

Jun 21 2019

courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Ping. Any other concerns ?

Jun 21 2019, 6:18 AM · Restricted Project
courbet added a comment to D63628: AMD K10 (Barcelona) Initial Scheduler model.

Amazing work Roman ! A few nits on the form, I'll let others more knowledgeable about AMD architectures comment on the model itself.

Jun 21 2019, 1:25 AM · Restricted Project

Jun 19 2019

courbet committed rGf7a6fb9f2c1d: Fix r363773: Update Barcelona MCA tests. (authored by courbet).
Fix r363773: Update Barcelona MCA tests.
Jun 19 2019, 3:00 AM
courbet committed rL363781: Fix r363773: Update Barcelona MCA tests..
Fix r363773: Update Barcelona MCA tests.
Jun 19 2019, 2:57 AM
courbet committed rG4ef7c2868a58: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr (authored by courbet).
[X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr
Jun 19 2019, 1:42 AM
courbet committed rL363773: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.
[X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr
Jun 19 2019, 1:42 AM
courbet closed D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.
Jun 19 2019, 1:42 AM · Restricted Project
courbet added a comment to D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.

Thanks for the review.

Jun 19 2019, 12:46 AM · Restricted Project

Jun 17 2019

courbet added inline comments to D63243: [WIP] Adjust the users of dereferenceable wrt. dereferenceable_globally.
Jun 17 2019, 2:19 AM · Restricted Project

Jun 11 2019

courbet committed rGf63feaf3c2ff: [clang-tidy] Fix typo in bugprone-string-constructor. (authored by courbet).
[clang-tidy] Fix typo in bugprone-string-constructor.
Jun 11 2019, 5:09 AM
courbet committed rL363053: [clang-tidy] Fix typo in bugprone-string-constructor..
[clang-tidy] Fix typo in bugprone-string-constructor.
Jun 11 2019, 5:09 AM

Jun 6 2019

courbet updated the diff for D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.

Fix formatting

Jun 6 2019, 6:37 AM · Restricted Project
courbet updated the diff for D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.
  • Mark ldmxscr as writing to memory. Unfortunately the DAG relies on intrinsics writing to memory to determine side-effet-ness.
  • Mark stmxscr as having side effects, as discusse din the review.
  • Update tests.
Jun 6 2019, 6:37 AM · Restricted Project
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Ping

Jun 6 2019, 5:58 AM · Restricted Project

Jun 5 2019

courbet added a comment to D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.

A side effecting instruction doesn't prevent other non-side effecting instructions from moving across it.

Jun 5 2019, 9:12 AM · Restricted Project
courbet added a comment to D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.

Don’t we need stmxcsr to have side effects to keep it from reordering relative to ldmxcsr?

Jun 5 2019, 8:59 AM · Restricted Project
courbet added a comment to D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.

There are a bunch of tests to update, but I'd like to get opinions on this before going further. I'm not sure why the properties were not already there. Did I miss something ?

Jun 5 2019, 3:59 AM · Restricted Project
courbet created D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.
Jun 5 2019, 3:04 AM · Restricted Project

Jun 3 2019

courbet added a comment to D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional..

Thanks.

Jun 3 2019, 6:40 AM · Restricted Project
courbet added inline comments to D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional..
Jun 3 2019, 6:21 AM · Restricted Project
courbet added a reviewer for D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional.: probinson.
Jun 3 2019, 5:29 AM · Restricted Project
courbet added inline comments to D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional..
Jun 3 2019, 5:28 AM · Restricted Project
courbet added a reviewer for D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional.: aprantl.
Jun 3 2019, 2:05 AM · Restricted Project
courbet created D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional..
Jun 3 2019, 2:02 AM · Restricted Project

May 28 2019

courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Make ExpandMemCmp preserve the DomTree.

May 28 2019, 9:09 AM · Restricted Project

May 24 2019

courbet accepted D62360: [X86] Add zero idioms to the haswell, broadwell, and skylake schedule models. Add 256-bit fp xor to sandybridge zero idioms.

Thanks.

May 24 2019, 2:38 AM · Restricted Project

May 23 2019

courbet committed rG43882b16a343: [MergeICmps] Make the pass compatible with the new pass manager. (authored by courbet).
[MergeICmps] Make the pass compatible with the new pass manager.
May 23 2019, 5:34 AM
courbet committed rL361490: [MergeICmps] Make the pass compatible with the new pass manager..
[MergeICmps] Make the pass compatible with the new pass manager.
May 23 2019, 5:32 AM
courbet closed D62287: [MergeICmps] Make the pass compatible with the new pass manager..
May 23 2019, 5:32 AM · Restricted Project
courbet added a comment to D62287: [MergeICmps] Make the pass compatible with the new pass manager..

Thanks.

May 23 2019, 5:32 AM · Restricted Project

May 22 2019

courbet created D62287: [MergeICmps] Make the pass compatible with the new pass manager..
May 22 2019, 11:57 PM · Restricted Project
courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Rebase

May 22 2019, 7:12 AM · Restricted Project
courbet committed rGb9274f269498: [llvm-exegesis] Move native target initialization code to a separate file. (authored by courbet).
[llvm-exegesis] Move native target initialization code to a separate file.
May 22 2019, 6:51 AM
courbet committed rL361385: [llvm-exegesis] Move native target initialization code to a separate file..
[llvm-exegesis] Move native target initialization code to a separate file.
May 22 2019, 6:51 AM
courbet closed D62239: [llvm-exegesis] Move native target initialization code to a separate file..
May 22 2019, 6:51 AM · Restricted Project
courbet updated the diff for D62239: [llvm-exegesis] Move native target initialization code to a separate file..

add missing inline

May 22 2019, 6:42 AM · Restricted Project
courbet created D62239: [llvm-exegesis] Move native target initialization code to a separate file..
May 22 2019, 2:52 AM · Restricted Project
courbet committed rGf8f93ba90d26: Re-land r361257 "[MergeICmps][NFC] Make BCEAtom move-only."" (authored by courbet).
Re-land r361257 "[MergeICmps][NFC] Make BCEAtom move-only.""
May 22 2019, 2:44 AM
courbet committed rL361366: Re-land r361257 "[MergeICmps][NFC] Make BCEAtom move-only."".
Re-land r361257 "[MergeICmps][NFC] Make BCEAtom move-only.""
May 22 2019, 2:43 AM

May 21 2019

courbet committed rG122c6e6f3689: [MergeICmps] Make sorting strongly stable on the rhs. (authored by courbet).
[MergeICmps] Make sorting strongly stable on the rhs.
May 21 2019, 10:57 AM
courbet committed rL361281: [MergeICmps] Make sorting strongly stable on the rhs..
[MergeICmps] Make sorting strongly stable on the rhs.
May 21 2019, 10:56 AM
courbet closed D62193: [MergeICmps] Make sorting strongly stable on the rhs..
May 21 2019, 10:56 AM · Restricted Project
courbet committed rG8361a10493c5: Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only." (authored by courbet).
Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only."
May 21 2019, 7:24 AM
courbet committed rL361263: Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only.".
Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only."
May 21 2019, 7:24 AM
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

@courbet Please can you ensure you have EXPENSIVE_CHECKS enabled in all your builds before going any further - you've been breaking the buildbots for well over a week now and you still haven't fixed the underlying issue.

May 21 2019, 7:11 AM · Restricted Project
courbet created D62193: [MergeICmps] Make sorting strongly stable on the rhs..
May 21 2019, 6:45 AM · Restricted Project
courbet committed rG8fa970c2d871: [MergeICmps][NFC] Make BCEAtom move-only. (authored by courbet).
[MergeICmps][NFC] Make BCEAtom move-only.
May 21 2019, 6:33 AM
courbet committed rL361257: [MergeICmps][NFC] Make BCEAtom move-only..
[MergeICmps][NFC] Make BCEAtom move-only.
May 21 2019, 6:31 AM
courbet committed rGa95d95d3922e: [MergeICmps] Preserve the dominator tree. (authored by courbet).
[MergeICmps] Preserve the dominator tree.
May 21 2019, 4:02 AM
courbet committed rL361239: [MergeICmps] Preserve the dominator tree..
[MergeICmps] Preserve the dominator tree.
May 21 2019, 4:01 AM
courbet closed D62068: [MergeICmps] Preserve the dominator tree..
May 21 2019, 4:01 AM · Restricted Project
courbet added a comment to D62068: [MergeICmps] Preserve the dominator tree..

Thanks.

May 21 2019, 2:25 AM · Restricted Project
courbet updated the diff for D62068: [MergeICmps] Preserve the dominator tree..

Address comments.

May 21 2019, 2:25 AM · Restricted Project

May 17 2019

courbet updated the diff for D62068: [MergeICmps] Preserve the dominator tree..

remove debug

May 17 2019, 8:29 AM · Restricted Project
courbet created D62068: [MergeICmps] Preserve the dominator tree..
May 17 2019, 8:27 AM · Restricted Project
courbet committed rG90900fbc9fdf: [MergeICmps][NFC] Add more debug. (authored by courbet).
[MergeICmps][NFC] Add more debug.
May 17 2019, 5:06 AM
courbet committed rL361024: [MergeICmps][NFC] Add more debug..
[MergeICmps][NFC] Add more debug.
May 17 2019, 5:05 AM
courbet committed rG632dfdda16bb: Re-land r360859: "[MergeICmps] Simplify the code." (authored by courbet).
Re-land r360859: "[MergeICmps] Simplify the code."
May 17 2019, 2:42 AM
courbet committed rL361009: Re-land r360859: "[MergeICmps] Simplify the code.".
Re-land r360859: "[MergeICmps] Simplify the code."
May 17 2019, 2:41 AM
courbet committed rG580ff1e72a14: [MergeICmps] Add test from PR41917. (authored by courbet).
[MergeICmps] Add test from PR41917.
May 17 2019, 1:54 AM
courbet committed rL361001: [MergeICmps] Add test from PR41917..
[MergeICmps] Add test from PR41917.
May 17 2019, 1:49 AM

May 16 2019

courbet committed rG3a0e6e1c6c96: [DominatorTree] Print roots unconditionally in `print()`. (authored by courbet).
[DominatorTree] Print roots unconditionally in `print()`.
May 16 2019, 5:48 AM
courbet committed rL360886: [DominatorTree] Print roots unconditionally in `print()`..
[DominatorTree] Print roots unconditionally in `print()`.
May 16 2019, 5:47 AM
courbet closed D61999: [DominatorTree] Print roots unconditionally in `print()`..
May 16 2019, 5:47 AM · Restricted Project
courbet added a comment to D61999: [DominatorTree] Print roots unconditionally in `print()`..

Thanks.

May 16 2019, 5:47 AM · Restricted Project
courbet added a comment to D61999: [DominatorTree] Print roots unconditionally in `print()`..

Do we have a test for this? I don't think it is a problem but if we do we could update it. Otherwise, LGTM.

May 16 2019, 5:47 AM · Restricted Project
courbet created D61999: [DominatorTree] Print roots unconditionally in `print()`..
May 16 2019, 3:43 AM · Restricted Project

May 15 2019

courbet committed rGc4fdd717efa4: Reland r360771 "[MergeICmps] Simplify the code." (authored by courbet).
Reland r360771 "[MergeICmps] Simplify the code."
May 15 2019, 11:16 PM