Page MenuHomePhabricator
Feed Advanced Search

Yesterday

aaronpuchert retitled D75319: Remove unused parameter from CXXRecordDecl::forallBases [NFC] from Remove unused parameter from CXXRecordDecl::forallBases to Remove unused parameter from CXXRecordDecl::forallBases [NFC].
Thu, Feb 27, 5:14 PM · Restricted Project
aaronpuchert created D75319: Remove unused parameter from CXXRecordDecl::forallBases [NFC].
Thu, Feb 27, 4:47 PM · Restricted Project

Wed, Feb 26

aaronpuchert retitled D67112: [Sema] Introduce function reference conversion from [Sema] Add implicit cast for conversion of function references to [Sema] Introduce function reference conversion.
Wed, Feb 26, 5:57 PM · Restricted Project
aaronpuchert updated the diff for D67112: [Sema] Introduce function reference conversion.

Rebase on top of D66437.

Wed, Feb 26, 5:13 PM · Restricted Project
aaronpuchert reclaimed D67112: [Sema] Introduce function reference conversion.

The diff between both changes might still be interesting.

Wed, Feb 26, 5:13 PM · Restricted Project
aaronpuchert added a comment to D70991: [libc++][test] Replace platform.linux_distribution by distro.linux_distribution.

On openSUSE we're running the llvm, clang, and libc++ test suite with just python3-base as dependency. This doesn't include the distro package, so it would be the first dependency outside of the Python standard library.

Wed, Feb 26, 4:36 PM · Restricted Project

Tue, Feb 25

aaronpuchert added a comment to D74588: Use DISABLE_LLVM_LINK_LLVM_DYLIB for TableGenTests.

Ping. This is similar to the fix in rL373651 over the original commit rL373551.

Tue, Feb 25, 9:02 AM · Restricted Project

Mon, Feb 17

aaronpuchert added a comment to D70991: [libc++][test] Replace platform.linux_distribution by distro.linux_distribution.

An alternative to this change would be to assume that distributions recent enough to have Python 3.8 also have /etc/os-release, which has become somewhat of a standard. So we could check if that file exists, then use it if it does and fallback to platform.linux_distribution() if it doesn't. Then we wouldn't need an additional dependency.

Mon, Feb 17, 4:07 PM · Restricted Project
aaronpuchert closed D74586: Drop git version suffix.

Committed in rG4f53867ec27bde33479c7891c256225f2075945a.

Mon, Feb 17, 3:58 PM · Restricted Project, Restricted Project
aaronpuchert committed rG4f53867ec27b: Drop git version suffix (authored by aaronpuchert).
Drop git version suffix
Mon, Feb 17, 2:54 PM

Fri, Feb 14

aaronpuchert added a comment to D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.

Just FYI, I had to fix some tests after this in rG705306526b5ca7eed2fa28ebf832873cbb5085ec.

Fri, Feb 14, 10:57 AM · Restricted Project
aaronpuchert committed rG705306526b5c: Fix tests after previous commit (authored by aaronpuchert).
Fix tests after previous commit
Fri, Feb 14, 10:49 AM
aaronpuchert committed rG2f26bc554270: Warn about zero-parameter K&R definitions in -Wstrict-prototypes (authored by aaronpuchert).
Warn about zero-parameter K&R definitions in -Wstrict-prototypes
Fri, Feb 14, 10:30 AM
aaronpuchert closed D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.
Fri, Feb 14, 10:30 AM · Restricted Project
aaronpuchert added a comment to D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.

Thanks!

Fri, Feb 14, 10:21 AM · Restricted Project
aaronpuchert added inline comments to D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.
Fri, Feb 14, 10:03 AM · Restricted Project
aaronpuchert added inline comments to D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.
Fri, Feb 14, 10:03 AM · Restricted Project
aaronpuchert added inline comments to D45890: [OMPT] Add implementation and tests of Archer tool.
Fri, Feb 14, 9:08 AM · Restricted Project

Thu, Feb 13

aaronpuchert created D74588: Use DISABLE_LLVM_LINK_LLVM_DYLIB for TableGenTests.
Thu, Feb 13, 7:13 PM · Restricted Project
aaronpuchert added a reviewer for D74586: Drop git version suffix: hansw.
Thu, Feb 13, 6:55 PM · Restricted Project, Restricted Project
aaronpuchert created D74586: Drop git version suffix.
Thu, Feb 13, 6:46 PM · Restricted Project, Restricted Project
Herald added a reviewer for D74586: Drop git version suffix: mclow.lists.

This is for the release/10.x branch, not master. It mirrors rG24c2e53e770f5fe98d853ff04f035e3696b2cf60 and predecessors.

Thu, Feb 13, 6:46 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.

Ping @aaron.ballman.

Thu, Feb 13, 12:24 PM · Restricted Project

Tue, Feb 4

aaronpuchert updated subscribers of D68923: Don't warn about missing declarations for partial template specializations.

@hans, could you cherry-pick this on the version 10 branch? As I wrote in D68923#1857046, this is a regression from Clang 8.

Tue, Feb 4, 9:53 AM · Restricted Project
aaronpuchert added a comment to D68923: Don't warn about missing declarations for partial template specializations.

I think it's a simple enough fix that it may be worth it, but it isn't fixing a regression in behavior so it's not critical.

Exactly, it would just be a bug fix.

Tue, Feb 4, 7:27 AM · Restricted Project

Sun, Feb 2

aaronpuchert committed rGa9ab01a330f4: Remove superfluous space from -Wrange-loop-construct message (authored by aaronpuchert).
Remove superfluous space from -Wrange-loop-construct message
Sun, Feb 2, 7:28 AM
aaronpuchert added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

I've been thinking about the warning messages, which seem to a bit inaccurate. Sorry for piggy-backing this onto the change, I hope you don't mind.

Sun, Feb 2, 7:10 AM · Restricted Project
aaronpuchert added a comment to D68923: Don't warn about missing declarations for partial template specializations.

Thanks for the reviews! Do you think it makes sense to bring this to Clang 10?

I think it's a simple enough fix that it may be worth it, but it isn't fixing a regression in behavior so it's not critical.

Exactly, it would just be a bug fix.

Sun, Feb 2, 5:13 AM · Restricted Project

Sat, Feb 1

aaronpuchert added a comment to D67113: ICK_Function_Conversion is a third kind conversion.

@rsmith Could you have a look at this?

Sat, Feb 1, 12:23 PM · Restricted Project
aaronpuchert added a comment to D68923: Don't warn about missing declarations for partial template specializations.

Thanks for the reviews! Do you think it makes sense to bring this to Clang 10?

Sat, Feb 1, 11:47 AM · Restricted Project

Fri, Jan 31

aaronpuchert committed rG27684ae66d55: Don't warn about missing declarations for partial template specializations (authored by aaronpuchert).
Don't warn about missing declarations for partial template specializations
Fri, Jan 31, 3:13 PM
aaronpuchert closed D68923: Don't warn about missing declarations for partial template specializations.
Fri, Jan 31, 3:13 PM · Restricted Project
aaronpuchert added a comment to D68923: Don't warn about missing declarations for partial template specializations.

Another ping.

Fri, Jan 31, 3:26 AM · Restricted Project

Jan 26 2020

aaronpuchert added a comment to D73434: [Sema] Remove a -Wrange warning from -Wall.

Looks right to me, but someone else should approve.

Jan 26 2020, 3:03 PM · Restricted Project

Jan 24 2020

aaronpuchert added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

Here is a proposal: we add two children to -Wrange-loop-analysis.

Jan 24 2020, 1:59 PM · Restricted Project

Jan 23 2020

aaronpuchert added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

one could also argue that this is a bit harder to follow in a range-based for loop.

This seems to be the argumentation of https://bugs.llvm.org/show_bug.cgi?id=32823#c0, so I guess it's Ok.

Jan 23 2020, 4:02 PM · Restricted Project
aaronpuchert added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

I think we can actually view this in more general terms, unrelated to range-based for loops.

Jan 23 2020, 2:42 PM · Restricted Project

Jan 21 2020

aaronpuchert added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

I also still think that warn_for_range_copy should be emitted even in templates.

Jan 21 2020, 12:23 PM · Restricted Project

Jan 20 2020

aaronpuchert added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

Yes, but minimal fix is better for release branch, so @hans should merge it.

Jan 20 2020, 9:39 AM · Restricted Project
aaronpuchert added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

As I wrote on the bug, I think we should only suppress one of the warnings in templates (and maybe always):

Jan 20 2020, 8:13 AM · Restricted Project

Jan 16 2020

aaronpuchert added a comment to D72635: Allow arbitrary capability name in Thread Safety Analysis.

Hmm, I have been wondering about this as well. The way I see it, all of these things are what we call capabilities, and we treat them all the same. The names are just meant to make warning messages more readable, because what the analysis considers a capability, the user might know as a mutex, or role, or sequence.

Jan 16 2020, 2:43 PM · Restricted Project

Jan 13 2020

aaronpuchert requested changes to D65184: [Sema] Thread Safety Analysis: Make negative capability typeless..

A fix would be to let all three produce exclusive negative capability, which essentially means there is no type associated with negative capability. This fix could also fix my bug.

Jan 13 2020, 11:32 AM · Restricted Project

Jan 12 2020

aaronpuchert added a comment to D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.

@aaron.ballman We could make the warning even stricter, but that should be a separate discussion. Is this change Ok for now?

Jan 12 2020, 4:08 PM · Restricted Project

Jan 10 2020

aaronpuchert added a comment to D68923: Don't warn about missing declarations for partial template specializations.

Ping.

Jan 10 2020, 10:03 AM · Restricted Project

Jan 9 2020

aaronpuchert added a comment to D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..

Without this patch, any project that wants to use this header needs to add a vendored copy of FDP to their source repository. With this patch, non-clang will still have to do this, though projects that build with clang will not.

Jan 9 2020, 6:18 AM · Restricted Project, Restricted Project

Dec 10 2019

aaronpuchert added a comment to D70991: [libc++][test] Replace platform.linux_distribution by distro.linux_distribution.

Is import distro supported in Python 2.x?

Dec 10 2019, 4:55 PM · Restricted Project

Dec 5 2019

aaronpuchert added inline comments to D66437: Sema: Create a no-op implicit cast for lvalue function conversions..
Dec 5 2019, 6:35 PM · Restricted Project
aaronpuchert abandoned D67112: [Sema] Introduce function reference conversion.

Already fixed via D66437.

Dec 5 2019, 6:26 PM · Restricted Project

Dec 3 2019

aaronpuchert added a comment to D70991: [libc++][test] Replace platform.linux_distribution by distro.linux_distribution.

An alternative would be to assume that any distribution new enough to have Python 3.8 also has /etc/os-release, so we fall back to parsing that if platform.linux_distribution isn't there. Or the other way around: we check for /etc/os-release and fall back to platform.linux_distribution.

Dec 3 2019, 4:37 PM · Restricted Project
aaronpuchert created D70991: [libc++][test] Replace platform.linux_distribution by distro.linux_distribution.
Dec 3 2019, 4:00 PM · Restricted Project

Dec 1 2019

aaronpuchert added a comment to D68923: Don't warn about missing declarations for partial template specializations.

@rsmith, could you please have a look?

Dec 1 2019, 10:01 AM · Restricted Project

Nov 23 2019

aaronpuchert committed rG0010ea4224c7: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux (authored by aaronpuchert).
[Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux
Nov 23 2019, 7:11 AM
aaronpuchert closed D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.
Nov 23 2019, 7:11 AM · Restricted Project

Nov 18 2019

aaronpuchert committed rGb29c7fdb617c: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini (authored by aaronpuchert).
[OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini
Nov 18 2019, 4:00 PM
aaronpuchert closed D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.
Nov 18 2019, 4:00 PM · Restricted Project
aaronpuchert added a comment to D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

The current change (without the racy test) looks good to me.

Nov 18 2019, 2:02 PM · Restricted Project

Nov 15 2019

aaronpuchert added a comment to D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

The function I was suggesting marking used is the one passed to the linker as -fini, not the one marked destructor.

Nov 15 2019, 7:52 AM · Restricted Project

Nov 14 2019

aaronpuchert updated the diff for D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

Remove __kmp_internal_end_fini instead of exporting it: it shouldn't be needed.

Nov 14 2019, 7:38 PM · Restricted Project
aaronpuchert retitled D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini from [libomptarget] Export __kmp_internal_end_fini to fix [Thin]LTO build to [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.
Nov 14 2019, 7:38 PM · Restricted Project
aaronpuchert added a comment to D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

There's probably an existing test for them.

Nov 14 2019, 7:20 PM · Restricted Project

Nov 13 2019

aaronpuchert added a comment to D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

foreign thread should crash if library closed w/o shutdown

Nov 13 2019, 7:24 PM · Restricted Project

Nov 12 2019

aaronpuchert planned changes to D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

I will try removing __kmp_internal_end_fini with a test that __kmp_internal_end_atexit is still called.

Nov 12 2019, 6:26 PM · Restricted Project
aaronpuchert added a comment to D65184: [Sema] Thread Safety Analysis: Make negative capability typeless..

This is a larger effort so it will take a little bit more time on me.

Nov 12 2019, 6:17 PM · Restricted Project

Nov 7 2019

aaronpuchert added a comment to D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

Let's say we remove __kmp_internal_end_fini and rely on __kmp_internal_end_dtor, can we write a test case ensuring that __kmp_internal_end_atexit is called? That calls into __kmp_task_team_wait, so maybe we can exit while some tasks are still running, and get a different observable result depending on whether we wait or not?

Nov 7 2019, 6:38 PM · Restricted Project
aaronpuchert added a comment to D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

As well as removing the __kmp_internal_end_fini symbol at all, as it duplicates the functionality of __kmp_internal_end_dtor which has attribute "destructor". I am OK with either solution, would be good to hear others opinion.

Nov 7 2019, 10:19 AM · Restricted Project

Nov 6 2019

aaronpuchert added a comment to D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

Belatedly filed bug 43927. Feel free to comment there if you think this isn't the proper fix.

Nov 6 2019, 5:56 PM · Restricted Project
aaronpuchert updated the summary of D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.
Nov 6 2019, 5:56 PM · Restricted Project
aaronpuchert created D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.
Nov 6 2019, 5:41 PM · Restricted Project
aaronpuchert updated the summary of D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.
Nov 6 2019, 5:41 PM · Restricted Project

Nov 3 2019

aaronpuchert added a comment to D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

@jrtc27, @nemanjai: Could you have a look again? I think I answered all your questions and wrote a test.

Nov 3 2019, 9:17 AM · Restricted Project
aaronpuchert committed rGc96428d2184f: Drop spurious self-include [NFC] (authored by aaronpuchert).
Drop spurious self-include [NFC]
Nov 3 2019, 5:38 AM

Oct 31 2019

aaronpuchert added a comment to D68923: Don't warn about missing declarations for partial template specializations.

Gentle ping.

Oct 31 2019, 10:31 AM · Restricted Project

Oct 30 2019

aaronpuchert added inline comments to D68845: Don't emit unwanted constructor calls in co_return statements.
Oct 30 2019, 1:45 PM · Restricted Project
aaronpuchert added a comment to D68845: Don't emit unwanted constructor calls in co_return statements.

Not answering inline because comments are getting longer.

Oct 30 2019, 1:06 PM · Restricted Project

Oct 29 2019

aaronpuchert committed rGae3159e49793: Thread safety analysis: Peel away NoOp implicit casts in initializers (authored by aaronpuchert).
Thread safety analysis: Peel away NoOp implicit casts in initializers
Oct 29 2019, 5:45 PM
aaronpuchert closed D69533: Thread safety analysis: Peel away NoOp implicit casts in initializers.
Oct 29 2019, 5:45 PM · Restricted Project
aaronpuchert updated the diff for D68845: Don't emit unwanted constructor calls in co_return statements.

Add test case where check for non-deduced parameter conversions is necessary.

Oct 29 2019, 3:32 PM · Restricted Project
aaronpuchert added inline comments to D68845: Don't emit unwanted constructor calls in co_return statements.
Oct 29 2019, 3:30 PM · Restricted Project

Oct 28 2019

aaronpuchert created D69533: Thread safety analysis: Peel away NoOp implicit casts in initializers.
Oct 28 2019, 2:29 PM · Restricted Project

Oct 19 2019

aaronpuchert committed rL375351: Request commit access for aaronpuchert.
Request commit access for aaronpuchert
Oct 19 2019, 12:37 PM

Oct 16 2019

aaronpuchert added a comment to D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test.

@beanz Could you have a look again?

Oct 16 2019, 5:13 PM · Restricted Project

Oct 15 2019

aaronpuchert updated the diff for D68845: Don't emit unwanted constructor calls in co_return statements.

Apply clang-format.

Oct 15 2019, 7:19 PM · Restricted Project
aaronpuchert added a comment to D68845: Don't emit unwanted constructor calls in co_return statements.

Given the complexities of this implementation, I'm beginning to doubt whether implicit moves make sense for co_return at all. Since there can never be any kind of RVO, why not always require an explicit std::move? Implicit moves on return were introduced because an explicit move would inhibit NRVO, and without move there wouldn't be a graceful fallback for implementations that don't have NRVO.

Oct 15 2019, 7:19 PM · Restricted Project
aaronpuchert updated the diff for D68845: Don't emit unwanted constructor calls in co_return statements.

Add tests suggested by @Quuxplusone and add fallback to call by lvalue reference.

Oct 15 2019, 7:10 PM · Restricted Project

Oct 12 2019

aaronpuchert created D68923: Don't warn about missing declarations for partial template specializations.
Oct 12 2019, 5:08 PM · Restricted Project
aaronpuchert added a comment to D68845: Don't emit unwanted constructor calls in co_return statements.

@GorNishanov Do I read the standard correctly that there are no constraints on what return_value is? That is, could it also be a function pointer or function object?

Oct 12 2019, 4:41 PM · Restricted Project
aaronpuchert added a comment to D68845: Don't emit unwanted constructor calls in co_return statements.

I'll add your test case, but I'll probably reuse the existing data structures.

Oct 12 2019, 7:51 AM · Restricted Project

Oct 11 2019

aaronpuchert planned changes to D68845: Don't emit unwanted constructor calls in co_return statements.

Both of these should first do overload resolution for one parameter of type MoveOnly&&, and then, only if that overload resolution fails, should they fall back to overload resolution for one parameter of type MoveOnly&.

Oct 11 2019, 4:09 AM · Restricted Project

Oct 10 2019

aaronpuchert added inline comments to D68845: Don't emit unwanted constructor calls in co_return statements.
Oct 10 2019, 6:08 PM · Restricted Project
aaronpuchert updated the diff for D68845: Don't emit unwanted constructor calls in co_return statements.

Also remove FIXME comment.

Oct 10 2019, 5:59 PM · Restricted Project
aaronpuchert created D68845: Don't emit unwanted constructor calls in co_return statements.
Oct 10 2019, 5:58 PM · Restricted Project
aaronpuchert added a comment to D51741: [coro]Pass rvalue reference for named local variable to return_value.

Please have a look at D68845. This should address the issues that we discussed.

Oct 10 2019, 5:58 PM · Restricted Project
aaronpuchert added a comment to D51741: [coro]Pass rvalue reference for named local variable to return_value.

@Quuxplusone Thanks for your very helpful comments!

Oct 10 2019, 2:34 PM · Restricted Project

Oct 9 2019

aaronpuchert added a comment to D51741: [coro]Pass rvalue reference for named local variable to return_value.

This patch is heavily heavily merge-conflicted by P1825.

Oct 9 2019, 1:32 PM · Restricted Project
Herald added a project to D51741: [coro]Pass rvalue reference for named local variable to return_value: Restricted Project.

This change breaks the following code that worked before:

Oct 9 2019, 10:09 AM · Restricted Project

Oct 8 2019

aaronpuchert added a comment to D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

Gentle ping.

Oct 8 2019, 1:15 PM · Restricted Project
aaronpuchert planned changes to D67112: [Sema] Introduce function reference conversion.

If anyone shares my feeling that the boolean output parameters of CompareReferenceRelationship should rather move to the return value, I would be happy to do that.

Oct 8 2019, 12:59 PM · Restricted Project

Sep 30 2019

aaronpuchert added a comment to D67113: ICK_Function_Conversion is a third kind conversion.

Ping?

Sep 30 2019, 2:44 PM · Restricted Project
aaronpuchert abandoned D68187: [libclang] Use strict prototypes in header.

Fixed by @aaron.ballman in rC373213 along with another issue.

Sep 30 2019, 2:37 PM · Restricted Project

Sep 28 2019

aaronpuchert added a comment to D68187: [libclang] Use strict prototypes in header.

Can be "reproduced" with clang -fsyntax-only -Wstrict-prototypes clang/include/clang-c/*.h.

Sep 28 2019, 4:12 PM · Restricted Project