Page MenuHomePhabricator
Feed Advanced Search

Today

ahatanak created D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Tue, Jun 25, 12:00 AM · Restricted Project

Fri, Jun 14

ahatanak added inline comments to D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings .
Fri, Jun 14, 6:02 PM · Restricted Project
ahatanak updated the diff for D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings .

Address review comments.

Fri, Jun 14, 6:02 PM · Restricted Project
ahatanak added a reviewer for D58164: Block+lambda: allow reference capture: rsmith.

Richard, could you shed light on why it's done this way?

Fri, Jun 14, 5:26 PM · Restricted Project
ahatanak added a comment to D58164: Block+lambda: allow reference capture.

I think I now have a better idea of what's causing the crash in IRGen.

Fri, Jun 14, 5:23 PM · Restricted Project
ahatanak updated the diff for D58164: Block+lambda: allow reference capture.
  • Add another test case which has a block nested inside a lambda and causes clang to crash.
  • Fix the capture type passed to addCapture in RebuildLambdaScopeInfo.
Fri, Jun 14, 4:51 PM · Restricted Project
ahatanak commandeered D58164: Block+lambda: allow reference capture.
Fri, Jun 14, 4:49 PM · Restricted Project
ahatanak committed rGa704a8f28c4f: [ObjC][ARC] Delete ObjC runtime calls on global variables annotated with… (authored by ahatanak).
[ObjC][ARC] Delete ObjC runtime calls on global variables annotated with…
Fri, Jun 14, 3:05 PM
ahatanak committed rG6cb2d9dbd2d4: [CodeGen][ObjC] Annotate retain-agnostic ObjC globals with attribute… (authored by ahatanak).
[CodeGen][ObjC] Annotate retain-agnostic ObjC globals with attribute…
Fri, Jun 14, 3:05 PM
ahatanak committed rL363468: [ObjC][ARC] Delete ObjC runtime calls on global variables annotated.
[ObjC][ARC] Delete ObjC runtime calls on global variables annotated
Fri, Jun 14, 3:05 PM
ahatanak closed D62433: [ObjC][ARC] Delete ObjC runtime calls if the argument is a global variable.
Fri, Jun 14, 3:05 PM · Restricted Project
ahatanak committed rL363467: [CodeGen][ObjC] Annotate retain-agnostic ObjC globals with attribute.
[CodeGen][ObjC] Annotate retain-agnostic ObjC globals with attribute
Fri, Jun 14, 3:05 PM
ahatanak closed D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.
Fri, Jun 14, 3:04 PM · Restricted Project, Restricted Project

Thu, Jun 13

ahatanak added a comment to D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.

There are many attributes that start with objc_ including objc_arc_weak_reference_unavailable.

Thu, Jun 13, 11:03 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.
Thu, Jun 13, 11:01 PM · Restricted Project, Restricted Project

Wed, Jun 12

ahatanak abandoned D62988: Add an attribute to allow fields of non-trivial types in C unions.
Wed, Jun 12, 5:15 PM · Restricted Project
ahatanak added a comment to D62988: Add an attribute to allow fields of non-trivial types in C unions.

John and I had a discussion offline and decided that we should not pursue the approach taken in this patch. I'll try to work on a patch that follows the C++11 approach when I have time later.

Wed, Jun 12, 3:40 PM · Restricted Project

Tue, Jun 11

ahatanak added a comment to D62988: Add an attribute to allow fields of non-trivial types in C unions.

How do you write correct (non-leaking, non-double-freeing, non-releasing-invalid-pointers) code with this attribute? For example, suppose I have a __strong union member: does storing to it release the old value (which might be a different union member)? If so, how do you work around that? https://clang.llvm.org/docs/AutomaticReferenceCounting.html#ownership-qualified-fields-of-structs-and-unions should be updated to say what happens. If manual reference counting code is required to make any use of this feature correct (which seems superficially likely), is this a better programming model than __unsafe_unretained?

Tue, Jun 11, 6:42 PM · Restricted Project

Mon, Jun 10

ahatanak added a comment to D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.

I agree. Something like arc_inert is probably a better name in this case for the reason you mentioned.

Mon, Jun 10, 9:39 PM · Restricted Project, Restricted Project
ahatanak added a comment to D62988: Add an attribute to allow fields of non-trivial types in C unions.

Does this lead to C/C++ ABI mismatches? Should we just honor this in C++ as well by ignoring it when deciding to delete special members? Is taking such a general name a good idea if it's language-specific? Richard, thoughts?

Mon, Jun 10, 8:25 PM · Restricted Project

Thu, Jun 6

ahatanak created D62988: Add an attribute to allow fields of non-trivial types in C unions.
Thu, Jun 6, 3:45 PM · Restricted Project

Wed, Jun 5

ahatanak added inline comments to D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.
Wed, Jun 5, 2:18 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.

Address review comments.

Wed, Jun 5, 2:18 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.
Wed, Jun 5, 2:09 PM · Restricted Project, Restricted Project
ahatanak committed rG9423f5ef56d2: Fix FileCheck prefixes in test case. (authored by ahatanak).
Fix FileCheck prefixes in test case.
Wed, Jun 5, 2:09 PM
ahatanak committed rL362651: Fix FileCheck prefixes in test case..
Fix FileCheck prefixes in test case.
Wed, Jun 5, 2:09 PM

Tue, Jun 4

ahatanak committed rG48566aaab461: [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to… (authored by ahatanak).
[CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to…
Tue, Jun 4, 9:29 AM
ahatanak committed rL362521: [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to.
[CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to
Tue, Jun 4, 9:29 AM
ahatanak closed D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'.
Tue, Jun 4, 9:29 AM · Restricted Project, Restricted Project

Mon, Jun 3

ahatanak committed rG59839124f49d: Add a release note entry for the change made in r362034. (authored by ahatanak).
Add a release note entry for the change made in r362034.
Mon, Jun 3, 4:48 PM
ahatanak committed rL362464: Add a release note entry for the change made in r362034..
Add a release note entry for the change made in r362034.
Mon, Jun 3, 4:48 PM
ahatanak updated the diff for D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'.

Just set isClassMessage instead of passing a separate flag to tryGenerateSpecializedMessageSend.

Mon, Jun 3, 4:32 PM · Restricted Project, Restricted Project
ahatanak created D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.
Mon, Jun 3, 4:18 PM · Restricted Project, Restricted Project
ahatanak added a comment to D62433: [ObjC][ARC] Delete ObjC runtime calls if the argument is a global variable.

I don't remember. That being said, this should be a conservative optimization. What if someone adds in the future a different global where this isn't a no-op. Is it possible if you know what the global is to add a whitelist that you only care about those 2 things.

Mon, Jun 3, 4:15 PM · Restricted Project
ahatanak updated the diff for D62433: [ObjC][ARC] Delete ObjC runtime calls if the argument is a global variable.

Check the presence of attribute "arc_retain_agnostic" on the global variable before deleting the ARC calls.

Mon, Jun 3, 4:15 PM · Restricted Project

Wed, May 29

ahatanak created D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings .
Wed, May 29, 9:58 PM · Restricted Project
ahatanak created D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'.
Wed, May 29, 9:39 PM · Restricted Project, Restricted Project
ahatanak added a comment to D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs.

LGTM. I wonder if we have any other ugly GCC bug compatibility parts in clang's Objective-C implementation...

Wed, May 29, 2:29 PM · Restricted Project
ahatanak committed rGf3c89b1a6be0: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs (authored by ahatanak).
[ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs
Wed, May 29, 2:23 PM
ahatanak committed rL362034: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs.
[ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs
Wed, May 29, 2:22 PM
ahatanak committed rC362034: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs.
[ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs
Wed, May 29, 2:22 PM
ahatanak closed D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs.
Wed, May 29, 2:22 PM · Restricted Project

Tue, May 28

ahatanak updated subscribers of D62433: [ObjC][ARC] Delete ObjC runtime calls if the argument is a global variable.

I didn't find anything in the past commit log that mentions this optimization . Dan/Michael, do you know the reason ARC optimizer hasn't tried to remove these no-op calls?

Tue, May 28, 2:23 PM · Restricted Project
ahatanak updated the diff for D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs.

Remove flag EncodePointerToObjCTypedef, which is no longer needed.

Tue, May 28, 2:04 PM · Restricted Project
ahatanak added a comment to D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs.

ping

Tue, May 28, 11:04 AM · Restricted Project

May 24 2019

ahatanak committed rGa846427ad0ac: Revert "[Analysis] Link library dependencies to Analysis plugins" (authored by ahatanak).
Revert "[Analysis] Link library dependencies to Analysis plugins"
May 24 2019, 5:49 PM
ahatanak committed rL361685: Revert "[Analysis] Link library dependencies to Analysis plugins".
Revert "[Analysis] Link library dependencies to Analysis plugins"
May 24 2019, 5:49 PM
ahatanak committed rC361685: Revert "[Analysis] Link library dependencies to Analysis plugins".
Revert "[Analysis] Link library dependencies to Analysis plugins"
May 24 2019, 5:49 PM
ahatanak created D62433: [ObjC][ARC] Delete ObjC runtime calls if the argument is a global variable.
May 24 2019, 3:48 PM · Restricted Project
ahatanak abandoned D61808: [ObjC] Replace uses of the argument of a call to objc_autorelease with the result in MRR.

This patch is based on the assumption that the argument and the return value of objc_autorelease are equal, which isn't always true in MRR.

May 24 2019, 1:29 PM · Restricted Project
ahatanak abandoned D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR.

This isn't the right way to make a call to objc_autorelease a tail call, so I'm closing this for now. If we decide to convert calls to objc_autorelease and objc_retain to calls to objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue for other reasons in the future, I can reopen this.

May 24 2019, 1:23 PM · Restricted Project

May 20 2019

ahatanak added a comment to D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs.

Yes, I think we can add something to the release note.

May 20 2019, 3:22 PM · Restricted Project
ahatanak added a comment to D61808: [ObjC] Replace uses of the argument of a call to objc_autorelease with the result in MRR.

Okay, I see. The result of calling rootAutorelease when !ISA()->hasCustomRR() is true is the same as a message send, so it doesn't break the basic rules.

May 20 2019, 1:32 PM · Restricted Project
ahatanak added a comment to D61808: [ObjC] Replace uses of the argument of a call to objc_autorelease with the result in MRR.

IIUC, this is what happens when there is an autorelease message send in the source code:

May 20 2019, 1:07 PM · Restricted Project
ahatanak updated the diff for D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs.

Delete the entire code path that tries to work around a bug in gcc.

May 20 2019, 1:17 AM · Restricted Project

May 16 2019

ahatanak added a comment to D61808: [ObjC] Replace uses of the argument of a call to objc_autorelease with the result in MRR.

We discussed this before, but we already break the base ObjC rules since the runtime elides the autorelease message send in MRR when it's possible to perform the retainRV/autoreleaseRV optimization, which only happens when the caller (or a caller higher up in the call-chain if it's tail-called) is compiled with ARC. IIUC, the only semantic change we''ll be making if we emit an objc_autoreleaseReturnValue call instead of an objc_autorelease call is that we no longer guarantee that the message send will happen when the class overrides the autorelease method, which we do guarantee with calls to objc_autorelease (see objc_object::autorelease and objc_object::rootAutorelease in the link below).

May 16 2019, 5:40 PM · Restricted Project
ahatanak added inline comments to D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs.
May 16 2019, 4:01 PM · Restricted Project
ahatanak added a comment to D61808: [ObjC] Replace uses of the argument of a call to objc_autorelease with the result in MRR.

The assumption that these methods return the receiver is not true without additional semantic assumptions about these methods, so the current behavior of unconditionally turning [x autorelease] into objc_autorelease(x), x seems quite broken.

Because it's possible to override an autorelease method and make the method return something other than the passed argument, for example?

If it's not possible to assume that the method returns the passed argument in MRR, the direction of this patch and https://reviews.llvm.org/D61970 is completely wrong.

Well, objc_retain and objc_autorelease (and objc_release, trivially) do return the normal return value of the message send in MRR, so assuming that's preserved in the IR, you just need to use that as the expression result. But if the backend's going to unconditionally optimize the intrinsics based on the assumption that those values are the same, that's problematic, just as it would be problematic for it to do ARC-approved reordering on intrinsics emitted for MRR.

May 16 2019, 3:35 PM · Restricted Project
ahatanak added inline comments to D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR.
May 16 2019, 3:10 PM · Restricted Project
ahatanak added inline comments to D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR.
May 16 2019, 3:06 PM · Restricted Project
ahatanak added a comment to D61808: [ObjC] Replace uses of the argument of a call to objc_autorelease with the result in MRR.

The assumption that these methods return the receiver is not true without additional semantic assumptions about these methods, so the current behavior of unconditionally turning [x autorelease] into objc_autorelease(x), x seems quite broken.

May 16 2019, 2:49 PM · Restricted Project

May 15 2019

ahatanak added inline comments to D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR.
May 15 2019, 11:57 PM · Restricted Project
ahatanak updated the diff for D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR.

Run the main ARC optimization passes when ObjCNoBuiltinRetainRelease is not set.

May 15 2019, 11:57 PM · Restricted Project
ahatanak created D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs.
May 15 2019, 6:48 PM · Restricted Project
ahatanak created D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR.
May 15 2019, 5:03 PM · Restricted Project
ahatanak accepted D61957: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary.

LGTM

May 15 2019, 12:01 PM · Restricted Project

May 11 2019

ahatanak planned changes to D61808: [ObjC] Replace uses of the argument of a call to objc_autorelease with the result in MRR.

Someone reminded me that I could replace the MRR call to objc_autorelease with the ARC call to objc_autoreleaseReturnValue in the front-end. I'm going to try that idea.

May 11 2019, 12:39 AM · Restricted Project

May 10 2019

ahatanak created D61808: [ObjC] Replace uses of the argument of a call to objc_autorelease with the result in MRR.
May 10 2019, 3:30 PM · Restricted Project
ahatanak committed rG34d28cf25f38: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when… (authored by ahatanak).
[CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when…
May 10 2019, 2:53 PM
ahatanak committed rL360474: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when.
[CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when
May 10 2019, 2:52 PM
ahatanak committed rC360474: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when.
[CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when
May 10 2019, 2:51 PM
ahatanak closed D61803: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when necessary..
May 10 2019, 2:51 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D61803: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when necessary..

Just call EmitCallOrInvoke.

May 10 2019, 2:10 PM · Restricted Project, Restricted Project
ahatanak created D61803: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when necessary..
May 10 2019, 1:31 PM · Restricted Project, Restricted Project

May 9 2019

ahatanak committed rGc39a243da651: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if… (authored by ahatanak).
Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if…
May 9 2019, 7:15 PM
ahatanak committed rL360404: Assume `__cxa_allocate_exception` returns an under-aligned memory on.
Assume `__cxa_allocate_exception` returns an under-aligned memory on
May 9 2019, 7:14 PM
ahatanak committed rC360404: Assume `__cxa_allocate_exception` returns an under-aligned memory on.
Assume `__cxa_allocate_exception` returns an under-aligned memory on
May 9 2019, 7:14 PM
ahatanak closed D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123.
May 9 2019, 7:14 PM · Restricted Project
ahatanak updated the diff for D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123.

Update the comment in CheckCXXThrowOperand.

May 9 2019, 5:22 PM · Restricted Project
ahatanak updated the diff for D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123.

Address review comments.

May 9 2019, 4:29 PM · Restricted Project
ahatanak added inline comments to D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123.
May 9 2019, 4:29 PM · Restricted Project
ahatanak committed rGb1271cceca7a: Specify target triple to fix the tests I committed in r360359 that are still… (authored by ahatanak).
Specify target triple to fix the tests I committed in r360359 that are still…
May 9 2019, 11:30 AM
ahatanak committed rL360363: Specify target triple to fix the tests I committed in r360359 that are.
Specify target triple to fix the tests I committed in r360359 that are
May 9 2019, 11:30 AM
ahatanak committed rC360363: Specify target triple to fix the tests I committed in r360359 that are.
Specify target triple to fix the tests I committed in r360359 that are
May 9 2019, 11:30 AM
ahatanak committed rGe406f0eec64f: Specify ObjC runtime to fix the tests I committed in r360359 that are failing. (authored by ahatanak).
Specify ObjC runtime to fix the tests I committed in r360359 that are failing.
May 9 2019, 11:06 AM
ahatanak committed rC360361: Specify ObjC runtime to fix the tests I committed in r360359 that are.
Specify ObjC runtime to fix the tests I committed in r360359 that are
May 9 2019, 11:03 AM
ahatanak committed rL360361: Specify ObjC runtime to fix the tests I committed in r360359 that are.
Specify ObjC runtime to fix the tests I committed in r360359 that are
May 9 2019, 11:03 AM
ahatanak committed rG187770dc7498: [CodeGen][ObjC] Remove the leading `l_` from ObjC symbols and make private… (authored by ahatanak).
[CodeGen][ObjC] Remove the leading `l_` from ObjC symbols and make private…
May 9 2019, 10:45 AM
ahatanak committed rC360359: [CodeGen][ObjC] Remove the leading `l_` from ObjC symbols and make.
[CodeGen][ObjC] Remove the leading `l_` from ObjC symbols and make
May 9 2019, 10:45 AM
ahatanak committed rL360359: [CodeGen][ObjC] Remove the leading `l_` from ObjC symbols and make.
[CodeGen][ObjC] Remove the leading `l_` from ObjC symbols and make
May 9 2019, 10:45 AM
ahatanak closed D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal..
May 9 2019, 10:45 AM · Restricted Project

May 8 2019

ahatanak updated the diff for D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123.

Move the code that was in AlignedExceptionObject.h to getExnObjectAlignment and remove the header.

May 8 2019, 1:40 PM · Restricted Project
ahatanak added inline comments to D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123.
May 8 2019, 1:40 PM · Restricted Project
ahatanak created D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123.
May 8 2019, 2:22 AM · Restricted Project

May 7 2019

ahatanak updated the diff for D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal..

Define helper function getLinkageTypeForObjCMetadata.

May 7 2019, 8:28 PM · Restricted Project

May 3 2019

ahatanak updated the diff for D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal..

Make sure private linkage is replaced with internal linkage only when the object file format is MachO.

May 3 2019, 6:04 PM · Restricted Project
ahatanak added inline comments to D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal..
May 3 2019, 1:05 AM · Restricted Project
ahatanak added inline comments to D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal..
May 3 2019, 12:49 AM · Restricted Project
ahatanak committed rG8cd01e69d8ee: [Sema][ObjC] Disable -Wunused-parameter for ObjC methods (authored by ahatanak).
[Sema][ObjC] Disable -Wunused-parameter for ObjC methods
May 3 2019, 12:21 AM
ahatanak committed rC359864: [Sema][ObjC] Disable -Wunused-parameter for ObjC methods.
[Sema][ObjC] Disable -Wunused-parameter for ObjC methods
May 3 2019, 12:21 AM