Page MenuHomePhabricator
Feed Advanced Search

Mon, Aug 12

ahatanak committed rG3c7c053145fa: Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions to… (authored by ahatanak).
Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions to…
Mon, Aug 12, 6:23 PM
ahatanak committed rL368646: Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions.
Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions
Mon, Aug 12, 6:22 PM
ahatanak committed rGc10980898256: Revert "Do not call replaceAllUsesWith to upgrade calls to ARC runtime… (authored by ahatanak).
Revert "Do not call replaceAllUsesWith to upgrade calls to ARC runtime…
Mon, Aug 12, 5:21 PM
ahatanak committed rL368637: Revert "Do not call replaceAllUsesWith to upgrade calls to ARC runtime….
Revert "Do not call replaceAllUsesWith to upgrade calls to ARC runtime…
Mon, Aug 12, 5:21 PM
ahatanak committed rG6817ce24c172: Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions to… (authored by ahatanak).
Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions to…
Mon, Aug 12, 4:56 PM
ahatanak closed D66047: Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions to intrinsic calls.

Thanks, committed in r368634.

Mon, Aug 12, 4:56 PM · Restricted Project
ahatanak committed rL368634: Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions.
Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions
Mon, Aug 12, 4:52 PM
ahatanak added inline comments to D66047: Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions to intrinsic calls.
Mon, Aug 12, 11:23 AM · Restricted Project
ahatanak updated the diff for D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects.

Revert changes I made to llvm that are unrelated to this patch.

Mon, Aug 12, 10:27 AM · Restricted Project, Restricted Project
ahatanak created D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects.
Mon, Aug 12, 10:15 AM · Restricted Project, Restricted Project
ahatanak added inline comments to D64464: [CodeGen] Emit destructor calls for non-trivial C structs.
Mon, Aug 12, 10:01 AM · Restricted Project

Fri, Aug 9

ahatanak created D66047: Do not call replaceAllUsesWith to upgrade calls to ARC runtime functions to intrinsic calls.
Fri, Aug 9, 6:58 PM · Restricted Project

Thu, Aug 8

ahatanak committed rG3e61ed02993e: Change the return type of UpgradeARCRuntimeCalls to void (authored by ahatanak).
Change the return type of UpgradeARCRuntimeCalls to void
Thu, Aug 8, 4:33 PM
ahatanak committed rL368367: Change the return type of UpgradeARCRuntimeCalls to void.
Change the return type of UpgradeARCRuntimeCalls to void
Thu, Aug 8, 4:32 PM
ahatanak committed rGecde8c7ad474: [ObjC][ARC] Upgrade calls to ARC runtime functions to intrinsic calls if the… (authored by ahatanak).
[ObjC][ARC] Upgrade calls to ARC runtime functions to intrinsic calls if the…
Thu, Aug 8, 10:03 AM
ahatanak committed rL368311: [ObjC][ARC] Upgrade calls to ARC runtime functions to intrinsic calls if.
[ObjC][ARC] Upgrade calls to ARC runtime functions to intrinsic calls if
Thu, Aug 8, 10:03 AM
ahatanak closed D65902: [ObjC][ARC] Upgrade calls to ARC runtime functions to intrinsic calls if the bitcode has the arm64 retainAutoreleasedReturnValue marker .
Thu, Aug 8, 10:03 AM · Restricted Project

Wed, Aug 7

ahatanak updated the diff for D65902: [ObjC][ARC] Upgrade calls to ARC runtime functions to intrinsic calls if the bitcode has the arm64 retainAutoreleasedReturnValue marker .

Initialize variable Changed with the return value of the call to UpgradeToIntrinsic.

Wed, Aug 7, 4:21 PM · Restricted Project
ahatanak updated the diff for D65902: [ObjC][ARC] Upgrade calls to ARC runtime functions to intrinsic calls if the bitcode has the arm64 retainAutoreleasedReturnValue marker .

Upgrade clang.arc.use to llvm.objc.clang.arc.use.

Wed, Aug 7, 4:19 PM · Restricted Project
ahatanak added a comment to D65902: [ObjC][ARC] Upgrade calls to ARC runtime functions to intrinsic calls if the bitcode has the arm64 retainAutoreleasedReturnValue marker .

Since ARC optimizer needs clang.arc.use to correctly move or remove retain/release pairs (see the comment in TopDownPtrState::HandlePotentialAlterRefCount), I think we should unconditionally upgrade the intrinsic calls instead of removing them even when the bitcode doesn't have the arm64 marker. I'll update the patch to convert clang.arc.use to llvm.objc.clang.arc.use.

Wed, Aug 7, 3:45 PM · Restricted Project
ahatanak created D65902: [ObjC][ARC] Upgrade calls to ARC runtime functions to intrinsic calls if the bitcode has the arm64 retainAutoreleasedReturnValue marker .
Wed, Aug 7, 1:48 PM · Restricted Project

Thu, Aug 1

ahatanak updated the diff for D64464: [CodeGen] Emit destructor calls for non-trivial C structs.
  • Emit member access, compound literal, and call expressions as subexpressions of ExprWithCleanups if the expressions are of C struct types that require non-trivial destruction. This fixes the bug in IRGen where it was destructing the function return at the end of the enclosing scope rather than at the end of the full expression (see the changes made in test/CodeGenObjC/arc.m).
  • Add compound literal expressions with automatic storage duration to the list of cleanup objects of ExprWithCleanups if the expressions have C struct types requiring non-trivial destruction. This enables IRGen to destruct the compound literals at the end of their enclosing scopes.
Thu, Aug 1, 5:56 PM · Restricted Project

Mon, Jul 29

ahatanak created D65407: Don't parse elements of extended vectors as template names.
Mon, Jul 29, 10:27 AM · Restricted Project

Fri, Jul 26

ahatanak updated the diff for D58164: Block+lambda: allow reference capture.

I think the fix is correct. When the lambda expression for the generic lambda is built, BuildLambdaExpr passes a Capture object in LambdaScopeInfo::Captures to BuildCaptureField to build the closure class field for the capture, so it should be okay to read the type of the field and pass it to LambdaScopeInfo::addCapture when rebuilding the lambda scope info.

Fri, Jul 26, 3:37 PM · Restricted Project

Thu, Jul 25

ahatanak committed rG6f6156b9fc81: Revert "[Sema] Diagnose default-initialization, destruction, and copying of" (authored by ahatanak).
Revert "[Sema] Diagnose default-initialization, destruction, and copying of"
Thu, Jul 25, 5:04 PM
ahatanak committed rL367076: Revert "[Sema] Diagnose default-initialization, destruction, and copying of".
Revert "[Sema] Diagnose default-initialization, destruction, and copying of"
Thu, Jul 25, 5:04 PM
ahatanak added inline comments to D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.
Thu, Jul 25, 9:41 AM · Restricted Project
ahatanak updated the diff for D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.

Mark fields that don't have an explicit __strong qualifier as unavailable.

Thu, Jul 25, 9:20 AM · Restricted Project

Wed, Jul 24

ahatanak updated the diff for D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.

Check that the attributed type is an ObjC qualified type. Do not diagnose fields that are unavailable.

Wed, Jul 24, 8:02 PM · Restricted Project
ahatanak added inline comments to D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.
Wed, Jul 24, 7:08 PM · Restricted Project
ahatanak updated the summary of D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.
Wed, Jul 24, 4:44 PM · Restricted Project
ahatanak updated the summary of D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.
Wed, Jul 24, 4:37 PM · Restricted Project
ahatanak created D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.
Wed, Jul 24, 4:36 PM · Restricted Project

Jul 12 2019

ahatanak committed rG118ee5f2e06a: Initialize the non-trivial C union bits I added to RecordDeclBitfields in… (authored by ahatanak).
Initialize the non-trivial C union bits I added to RecordDeclBitfields in…
Jul 12 2019, 9:01 PM
ahatanak committed rL365989: Initialize the non-trivial C union bits I added to RecordDeclBitfields.
Initialize the non-trivial C union bits I added to RecordDeclBitfields
Jul 12 2019, 9:00 PM
ahatanak committed rG81b03d4a08b1: [Sema] Diagnose default-initialization, destruction, and copying of non-trivial… (authored by ahatanak).
[Sema] Diagnose default-initialization, destruction, and copying of non-trivial…
Jul 12 2019, 6:51 PM
ahatanak committed rL365985: [Sema] Diagnose default-initialization, destruction, and copying of.
[Sema] Diagnose default-initialization, destruction, and copying of
Jul 12 2019, 6:50 PM
ahatanak closed D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Jul 12 2019, 6:50 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..

In Type.h, move method declarations down and mention that the predicates imply the associated basic non-triviality predicates.

Jul 12 2019, 3:49 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..

Improve comments.

Jul 12 2019, 3:37 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Jul 12 2019, 12:43 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..

Diagnose C union globals that are non-trivial to default-initialize. Add 3 bits to RecordDeclBitfields for default-initialize, destruct, and copy to fast-path checking.

Jul 12 2019, 12:43 PM · Restricted Project, Restricted Project

Jul 10 2019

ahatanak added a comment to D64526: [NFC] Unforget a colon in a few CHECK: directives..

I didn't know spaces are not allowed between "CHECK" and ":". CodeGen tests LGTM.

Jul 10 2019, 7:02 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Jul 10 2019, 6:48 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..

Address review comments.

Jul 10 2019, 6:16 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Jul 10 2019, 3:19 PM · Restricted Project, Restricted Project

Jul 9 2019

ahatanak added inline comments to D64464: [CodeGen] Emit destructor calls for non-trivial C structs.
Jul 9 2019, 6:45 PM · Restricted Project
ahatanak created D64464: [CodeGen] Emit destructor calls for non-trivial C structs.
Jul 9 2019, 6:40 PM · Restricted Project
ahatanak updated the diff for D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..

Add a bit to RecordDeclBitfields that indicates whether the record has a non-trivial C union member.

Jul 9 2019, 6:32 PM · Restricted Project, Restricted Project

Jul 8 2019

ahatanak committed rG8b1becf2e31d: [Sema] Resolve placeholder types before type deduction to silence spurious `… (authored by ahatanak).
[Sema] Resolve placeholder types before type deduction to silence spurious `…
Jul 8 2019, 1:05 PM
ahatanak committed rL365382: [Sema] Resolve placeholder types before type deduction to silence.
[Sema] Resolve placeholder types before type deduction to silence
Jul 8 2019, 1:04 PM
ahatanak closed D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings .
Jul 8 2019, 1:04 PM · Restricted Project, Restricted Project

Jul 3 2019

ahatanak updated the diff for D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings .

Add an implicit-only attribute ObjCDefaultedAnyToId to avoid passing the flag down.

Jul 3 2019, 5:20 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Jul 3 2019, 1:11 PM · Restricted Project, Restricted Project

Jul 2 2019

ahatanak added inline comments to D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Jul 2 2019, 12:31 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Jul 2 2019, 12:23 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..

Call hasNonTrivialPrimitiveCStruct to check whether the type is a non-trivial C struct/union before calling checkNonTrivialCUnion. Fix comments.

Jul 2 2019, 12:13 PM · Restricted Project, Restricted Project

Jul 1 2019

ahatanak added inline comments to D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Jul 1 2019, 12:44 PM · Restricted Project, Restricted Project

Jun 28 2019

ahatanak updated the diff for D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings .

Add function Expr::hasNonOverloadPlaceholderType.

Jun 28 2019, 4:01 PM · Restricted Project, Restricted Project
ahatanak added a comment to D58164: Block+lambda: allow reference capture.

Currently a block captures a variable (POD or non-POD) by reference if the enclosing lambda captures it by reference and captures by copy if the enclosing lambda captures by copy.

Jun 28 2019, 3:45 PM · Restricted Project
ahatanak added inline comments to D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Jun 28 2019, 3:34 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Jun 28 2019, 9:44 AM · Restricted Project, Restricted Project

Jun 27 2019

ahatanak added inline comments to D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Jun 27 2019, 11:34 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..

Address review comments. Diagnose lvalue-to-rvalue conversion of volatile non-trivial C types.

Jun 27 2019, 11:30 PM · Restricted Project, Restricted Project
ahatanak committed rG3b56e390dd12: Pattern match struct types in test case. (authored by ahatanak).
Pattern match struct types in test case.
Jun 27 2019, 2:17 PM
ahatanak committed rL364595: Pattern match struct types in test case..
Pattern match struct types in test case.
Jun 27 2019, 2:16 PM

Jun 26 2019

ahatanak added inline comments to D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Jun 26 2019, 6:01 PM · Restricted Project, Restricted Project
ahatanak planned changes to D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..

This patch should diagnose lvalue-to-rvalue conversion of volatile non-trivial C unions too, but it currently doesn't.

Jun 26 2019, 1:16 PM · Restricted Project, Restricted Project

Jun 25 2019

ahatanak created D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them..
Jun 25 2019, 12:00 AM · Restricted Project, Restricted Project

Jun 14 2019

ahatanak added inline comments to D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings .
Jun 14 2019, 6:02 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings .

Address review comments.

Jun 14 2019, 6:02 PM · Restricted Project, Restricted Project
ahatanak added a reviewer for D58164: Block+lambda: allow reference capture: rsmith.

Richard, could you shed light on why it's done this way?

Jun 14 2019, 5:26 PM · Restricted Project
ahatanak added a comment to D58164: Block+lambda: allow reference capture.

I think I now have a better idea of what's causing the crash in IRGen.

Jun 14 2019, 5:23 PM · Restricted Project
ahatanak updated the diff for D58164: Block+lambda: allow reference capture.
  • Add another test case which has a block nested inside a lambda and causes clang to crash.
  • Fix the capture type passed to addCapture in RebuildLambdaScopeInfo.
Jun 14 2019, 4:51 PM · Restricted Project
ahatanak commandeered D58164: Block+lambda: allow reference capture.
Jun 14 2019, 4:49 PM · Restricted Project
ahatanak committed rGa704a8f28c4f: [ObjC][ARC] Delete ObjC runtime calls on global variables annotated with… (authored by ahatanak).
[ObjC][ARC] Delete ObjC runtime calls on global variables annotated with…
Jun 14 2019, 3:05 PM
ahatanak committed rG6cb2d9dbd2d4: [CodeGen][ObjC] Annotate retain-agnostic ObjC globals with attribute… (authored by ahatanak).
[CodeGen][ObjC] Annotate retain-agnostic ObjC globals with attribute…
Jun 14 2019, 3:05 PM
ahatanak committed rL363468: [ObjC][ARC] Delete ObjC runtime calls on global variables annotated.
[ObjC][ARC] Delete ObjC runtime calls on global variables annotated
Jun 14 2019, 3:05 PM
ahatanak closed D62433: [ObjC][ARC] Delete ObjC runtime calls if the argument is a global variable.
Jun 14 2019, 3:05 PM · Restricted Project
ahatanak committed rL363467: [CodeGen][ObjC] Annotate retain-agnostic ObjC globals with attribute.
[CodeGen][ObjC] Annotate retain-agnostic ObjC globals with attribute
Jun 14 2019, 3:05 PM
ahatanak closed D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.
Jun 14 2019, 3:04 PM · Restricted Project, Restricted Project

Jun 13 2019

ahatanak added a comment to D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.

There are many attributes that start with objc_ including objc_arc_weak_reference_unavailable.

Jun 13 2019, 11:03 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.
Jun 13 2019, 11:01 PM · Restricted Project, Restricted Project

Jun 12 2019

ahatanak abandoned D62988: Add an attribute to allow fields of non-trivial types in C unions.
Jun 12 2019, 5:15 PM · Restricted Project
ahatanak added a comment to D62988: Add an attribute to allow fields of non-trivial types in C unions.

John and I had a discussion offline and decided that we should not pursue the approach taken in this patch. I'll try to work on a patch that follows the C++11 approach when I have time later.

Jun 12 2019, 3:40 PM · Restricted Project

Jun 11 2019

ahatanak added a comment to D62988: Add an attribute to allow fields of non-trivial types in C unions.

How do you write correct (non-leaking, non-double-freeing, non-releasing-invalid-pointers) code with this attribute? For example, suppose I have a __strong union member: does storing to it release the old value (which might be a different union member)? If so, how do you work around that? https://clang.llvm.org/docs/AutomaticReferenceCounting.html#ownership-qualified-fields-of-structs-and-unions should be updated to say what happens. If manual reference counting code is required to make any use of this feature correct (which seems superficially likely), is this a better programming model than __unsafe_unretained?

Jun 11 2019, 6:42 PM · Restricted Project

Jun 10 2019

ahatanak added a comment to D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.

I agree. Something like arc_inert is probably a better name in this case for the reason you mentioned.

Jun 10 2019, 9:39 PM · Restricted Project, Restricted Project
ahatanak added a comment to D62988: Add an attribute to allow fields of non-trivial types in C unions.

Does this lead to C/C++ ABI mismatches? Should we just honor this in C++ as well by ignoring it when deciding to delete special members? Is taking such a general name a good idea if it's language-specific? Richard, thoughts?

Jun 10 2019, 8:25 PM · Restricted Project

Jun 6 2019

ahatanak created D62988: Add an attribute to allow fields of non-trivial types in C unions.
Jun 6 2019, 3:45 PM · Restricted Project

Jun 5 2019

ahatanak added inline comments to D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.
Jun 5 2019, 2:18 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.

Address review comments.

Jun 5 2019, 2:18 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.
Jun 5 2019, 2:09 PM · Restricted Project, Restricted Project
ahatanak committed rG9423f5ef56d2: Fix FileCheck prefixes in test case. (authored by ahatanak).
Fix FileCheck prefixes in test case.
Jun 5 2019, 2:09 PM
ahatanak committed rL362651: Fix FileCheck prefixes in test case..
Fix FileCheck prefixes in test case.
Jun 5 2019, 2:09 PM

Jun 4 2019

ahatanak committed rG48566aaab461: [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to… (authored by ahatanak).
[CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to…
Jun 4 2019, 9:29 AM
ahatanak committed rL362521: [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to.
[CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to
Jun 4 2019, 9:29 AM
ahatanak closed D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'.
Jun 4 2019, 9:29 AM · Restricted Project, Restricted Project

Jun 3 2019

ahatanak committed rG59839124f49d: Add a release note entry for the change made in r362034. (authored by ahatanak).
Add a release note entry for the change made in r362034.
Jun 3 2019, 4:48 PM
ahatanak committed rL362464: Add a release note entry for the change made in r362034..
Add a release note entry for the change made in r362034.
Jun 3 2019, 4:48 PM
ahatanak updated the diff for D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'.

Just set isClassMessage instead of passing a separate flag to tryGenerateSpecializedMessageSend.

Jun 3 2019, 4:32 PM · Restricted Project, Restricted Project