Page MenuHomePhabricator
Feed Advanced Search

Sat, Feb 22

jpienaar accepted D74439: [mlir][SideEffects] Define a set of interfaces and traits for defining side effects.

Nice, looking forward to using (whatever we end up calling) "dynamic" op side effects :)

Sat, Feb 22, 11:16 AM · Restricted Project

Fri, Feb 21

jpienaar accepted D74682: [mlir][DeclarativeParser] Add an 'attr-dict-with-keyword' directive.

LGTM, Seems a bit too specialized but OK matches current behavior and not too invasive.

Fri, Feb 21, 9:55 AM · Restricted Project

Wed, Feb 19

jpienaar accepted D74818: [mlir][Parser] Use APFloat instead of FloatAttr when parsing DenseElementsAttrs..

A benchmark showing impact would be nice ;-)

Wed, Feb 19, 7:46 AM · Restricted Project
jpienaar accepted D74647: [mlir][ODS] Add a new trait `TypesMatchWith`.

Nice, thanks!

Wed, Feb 19, 7:46 AM · Restricted Project

Tue, Feb 18

jpienaar added inline comments to D74682: [mlir][DeclarativeParser] Add an 'attr-dict-with-keyword' directive.
Tue, Feb 18, 2:44 PM · Restricted Project
jpienaar accepted D74783: [mlir][ODS] Add support for specifying the successors of an operation..

NIce

Tue, Feb 18, 2:37 PM · Restricted Project
jpienaar committed rGfa7d04a0d3f4: [mlir] Add short readme.txt to docs directory (authored by jpienaar).
[mlir] Add short readme.txt to docs directory
Tue, Feb 18, 8:44 AM
jpienaar closed D74739: [mlir] Add short readme.txt to docs directory.
Tue, Feb 18, 8:44 AM · Restricted Project

Mon, Feb 17

jpienaar committed rG1842fd50d2ff: [mlir] Fix multiple titles (authored by jpienaar).
[mlir] Fix multiple titles
Mon, Feb 17, 2:00 PM
jpienaar created D74739: [mlir] Add short readme.txt to docs directory.
Mon, Feb 17, 1:25 PM · Restricted Project
jpienaar added a comment to D74143: [MLIR] Adding attribute setters generation for table gen.

I'm concerned about the method name here. Although we can rely on compiler symbol resolution, it's still quite confusing to see two attributes with the same name but one for getters and one for setters.

Mon, Feb 17, 12:21 PM · Restricted Project
jpienaar added a comment to D74647: [mlir][ODS] Add a new trait `TypesMatchWith`.

Just brief scan :)

Mon, Feb 17, 11:35 AM · Restricted Project
jpienaar added a comment to D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese.

This seems to result in triggering clang/lib/CodeGen/CGExpr.cpp:2626 when compiling mlir/lib/Transforms/AffineDataCopyGeneration.cpp with clang build with assertions on (clean build at e8e078c just before this change, broken at this, assert triggering at build fix commit).

Mon, Feb 17, 10:58 AM · Restricted Project

Fri, Feb 14

jpienaar requested changes to D73826: [mlir][Linalg] Provide a Tablegen backend to specify named Linalg ops declaratively.

The main value I see with the OpDefinitionGen hook is that it allows one to automatically insert traits and methods into the generated C++ op classes. This is preferable when a dialect's ops have a large variation of potential traits and methods, and that information is already encoded with other fields in the op definitions

There is no disagreement that this may be useful for some cases: but we should strive to improve ODS itself to provide this facilities. I don't think we want dialect author to write Tablegen backends: this defeats the whole point of ODS in my opinion!

Well actually the new impl indeed changes to write a new TableGen backends. :) But I get your idea here. Yup I agree that we should strive to improve ODS itself and avoid dialect author to write TableGen expansion logic as much as possible. So features that apply to any dialect should be factored out and landed into main OpDefinitionGen. But there are cases it's inevitable like the Linalg case showed here: we have custom syntax defined for op definitions only reasonable to Linalg dialect. One can either completely roll its own TableGen backend or hook into OpDefinitionGen to avoid some boilerplate. I would argue the later saves developers' efforts and it's enhancing the functionality of ODS for dialect-specific use cases. :)

Fri, Feb 14, 11:35 AM · Restricted Project
jpienaar added inline comments to D73826: [mlir][Linalg] Provide a Tablegen backend to specify named Linalg ops declaratively.
Fri, Feb 14, 10:03 AM · Restricted Project

Wed, Feb 12

jpienaar added a comment to D74491: [mlir][Linalg] NFC - Refactor in preparation for automatic Linalg "named" ops..

Wanted to give some feedback before next meeting, but I didn't review the C++ code changes in depth.

Wed, Feb 12, 11:01 AM · Restricted Project

Tue, Feb 11

jpienaar accepted D74461: Remove static registration for dialects, and the "alwayslink" hack for passes.

Yay, thanks good step in the right direction.

Tue, Feb 11, 9:26 PM · Restricted Project
jpienaar added a comment to D74439: [mlir][SideEffects] Define a set of interfaces and traits for defining side effects.

Just very quick skim, but could you add tests here already?

Tue, Feb 11, 3:08 PM · Restricted Project
jpienaar accepted D74438: [mlir] Allow adding extra class declarations to interfaces..
Tue, Feb 11, 3:08 PM · Restricted Project
jpienaar committed rG7baf2a434c86: [mlir] Start Shape dialect (authored by jpienaar).
[mlir] Start Shape dialect
Tue, Feb 11, 2:50 PM
jpienaar closed D73944: [mlir][wip] Start Shape dialect.
Tue, Feb 11, 2:49 PM · Restricted Project
jpienaar added a comment to D73944: [mlir][wip] Start Shape dialect.

Updated typo, thanks

Tue, Feb 11, 2:40 PM · Restricted Project
jpienaar updated the diff for D73944: [mlir][wip] Start Shape dialect.

Fix incorrectly named si.dim to shape.size

Tue, Feb 11, 2:40 PM · Restricted Project
jpienaar accepted D74363: [mlir] Allow constructing a ValueRange from an ArrayRef<BlockArgument>.
Tue, Feb 11, 9:35 AM · Restricted Project

Mon, Feb 10

jpienaar updated the summary of D74360: [llvm][TableGen] Define FieldInit::isConcrete overload.
Mon, Feb 10, 2:51 PM · Restricted Project
jpienaar accepted D74360: [llvm][TableGen] Define FieldInit::isConcrete overload.

Looks good thanks

Mon, Feb 10, 2:51 PM · Restricted Project

Sun, Feb 9

jpienaar updated the diff for D73944: [mlir][wip] Start Shape dialect.

Reduce with mul should be init with 1 instead of 0

Sun, Feb 9, 1:08 PM · Restricted Project
jpienaar added a comment to D73944: [mlir][wip] Start Shape dialect.

I question the relevance of carrying implicit broadcasting concepts from HLO and other frontends into MLIR core.

Sun, Feb 9, 12:50 PM · Restricted Project
jpienaar updated the diff for D73944: [mlir][wip] Start Shape dialect.

Updating to address review comments (sorting ops, types, making type names uniform, renaming broadcastable op, renaming dim type, fixing example).

Sun, Feb 9, 12:50 PM · Restricted Project
jpienaar added a comment to D74143: [MLIR] Adding attribute setters generation for table gen.

Can this be tested in-tree?

Sun, Feb 9, 9:32 AM · Restricted Project
jpienaar updated the summary of D74200: config for mlir-nvidia buildbot.
Sun, Feb 9, 9:32 AM
jpienaar accepted D74200: config for mlir-nvidia buildbot.

Thanks!

Sun, Feb 9, 9:32 AM
jpienaar added a comment to D74276: [mlir][DeclarativeParser] Add support for attributes with buildable types..

Nice, thanks

Sun, Feb 9, 8:56 AM · Restricted Project

Fri, Feb 7

jpienaar accepted D74246: [mlir][Pass] Enable printing pass options as part of `-help`..

Nice, looks much cleaner. Mostly small nits.

Fri, Feb 7, 1:12 PM · Restricted Project

Wed, Feb 5

jpienaar committed rG2697e8bc1e63: [mlir] Update generic op ebnf to include region (authored by jpienaar).
[mlir] Update generic op ebnf to include region
Wed, Feb 5, 1:21 PM
jpienaar closed D74061: [mlir] Update generic op ebnf to include region.
Wed, Feb 5, 1:21 PM · Restricted Project
jpienaar created D74061: [mlir] Update generic op ebnf to include region.
Wed, Feb 5, 8:40 AM · Restricted Project

Tue, Feb 4

jpienaar accepted D73983: [mlir][ODS] Add documentation for the declarative assembly format..

Looks good thanks

Tue, Feb 4, 4:23 PM · Restricted Project
jpienaar added a comment to D73944: [mlir][wip] Start Shape dialect.

Updated, thanks

Tue, Feb 4, 4:14 PM · Restricted Project
jpienaar updated the diff for D73944: [mlir][wip] Start Shape dialect.

Ran clang-format

Tue, Feb 4, 4:14 PM · Restricted Project
jpienaar updated the diff for D73944: [mlir][wip] Start Shape dialect.

Addresses review comments.

Tue, Feb 4, 4:14 PM · Restricted Project
jpienaar accepted D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.

This gets us closer to matching the bazel side and works for me, thanks

Tue, Feb 4, 3:37 PM · Restricted Project
jpienaar committed rG28cd54cdbba6: [mlir] Fix clang 5 warning for missing braces (authored by jpienaar).
[mlir] Fix clang 5 warning for missing braces
Tue, Feb 4, 10:40 AM

Mon, Feb 3

jpienaar created D73944: [mlir][wip] Start Shape dialect.
Mon, Feb 3, 10:22 PM · Restricted Project

Sun, Feb 2

jpienaar added a comment to D73826: [mlir][Linalg] Provide a Tablegen backend to specify named Linalg ops declaratively.

The previous rev was reverted as during discussion this feature was seen as unclear if we wanted to support, was changing the functionality & contract of the tool. Opening a new rev while rolling in the previous change does not resolve that discussion.

At least now there is a motivation / example of uses to support the discussion!

I'm still not convinced that hooking into Tablegen C++ is something we want Dialect author to do, so I'd like to look closer into what you're trying to do here and see how we could achieve this without injecting code into TableGen emitters.

I am not either and I am looking forward to getting better suggestions and moving the needle on this longstanding issue in Linalg.

Sun, Feb 2, 11:28 AM · Restricted Project

Sat, Feb 1

jpienaar committed rGc4b4c0c47c99: [mlir] Expand shape functions in ShapeInference doc (authored by jpienaar).
[mlir] Expand shape functions in ShapeInference doc
Sat, Feb 1, 2:50 PM
jpienaar closed D73572: [mlir] Expand shape functions in ShapeInference doc.
Sat, Feb 1, 2:49 PM · Restricted Project
jpienaar updated the diff for D73572: [mlir] Expand shape functions in ShapeInference doc.

Fixing typos identified in review

Sat, Feb 1, 2:49 PM · Restricted Project
jpienaar added a comment to D73572: [mlir] Expand shape functions in ShapeInference doc.

Updated thanks

Sat, Feb 1, 2:49 PM · Restricted Project
jpienaar committed rG1544cf2d7cec: [mlir] Fix errors in release & no-assert (authored by jpienaar).
[mlir] Fix errors in release & no-assert
Sat, Feb 1, 9:06 AM
jpienaar added a comment to D73826: [mlir][Linalg] Provide a Tablegen backend to specify named Linalg ops declaratively.

The previous rev was reverted as during discussion this feature was seen as unclear if we wanted to support, was changing the functionality & contract of the tool. Opening a new rev while rolling in the previous change does not resolve that discussion.

Sat, Feb 1, 8:33 AM · Restricted Project

Fri, Jan 31

jpienaar accepted D73770: [mlir] Fix link to 'Getting started with MLIR'.
Fri, Jan 31, 8:20 AM · Restricted Project
jpienaar added inline comments to D73778: [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib.
Fri, Jan 31, 8:20 AM · Restricted Project

Tue, Jan 28

jpienaar created D73572: [mlir] Expand shape functions in ShapeInference doc.
Tue, Jan 28, 12:11 PM · Restricted Project
jpienaar added inline comments to D73429: [mlir][NFC] Update Operation::getResultTypes to use ArrayRef<Type> instead of iterator_range..
Tue, Jan 28, 8:16 AM · Restricted Project

Mon, Jan 27

jpienaar added a comment to D73405: [mlir] Add initial support for parsing a declarative operation assembly format.

One clang-format failure

Mon, Jan 27, 9:32 PM · Restricted Project

Jan 25 2020

jpienaar committed rGe47b56139885: [mlir] Revert MSVC specific part of whole_archive_link (authored by jpienaar).
[mlir] Revert MSVC specific part of whole_archive_link
Jan 25 2020, 9:59 AM
jpienaar added a comment to D72418: [Flang] add some cmake code to allow for out-of-tree building of MLIR and LLVM.

This patch breaks Windows MSVC build, former correct ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib/${LIB}.lib now suddenly becomes wrong ${LIB}.

Jan 25 2020, 9:54 AM · Restricted Project, Restricted Project
jpienaar committed rGe298e216501a: [mlir] Bootstrap doxygen config (authored by jpienaar).
[mlir] Bootstrap doxygen config
Jan 25 2020, 9:36 AM
jpienaar added inline comments to D72533: [mlir] Add a signedness semantics bit to IntegerType.
Jan 25 2020, 9:04 AM · Restricted Project

Jan 22 2020

jpienaar committed rG178562fb352d: [mlir] Enable specifying verify on OpInterface (authored by jpienaar).
[mlir] Enable specifying verify on OpInterface
Jan 22 2020, 4:44 AM
jpienaar closed D73122: [mlir] Enable specifying verify on OpInterface.
Jan 22 2020, 4:43 AM · Restricted Project
jpienaar updated the diff for D73122: [mlir] Enable specifying verify on OpInterface.

Quoted 'verify', removed spurious newlines.

Jan 22 2020, 4:43 AM · Restricted Project
jpienaar added a comment to D73122: [mlir] Enable specifying verify on OpInterface.

Updated thanks

Jan 22 2020, 4:43 AM · Restricted Project

Jan 21 2020

jpienaar created D73122: [mlir] Enable specifying verify on OpInterface.
Jan 21 2020, 10:10 AM · Restricted Project

Jan 20 2020

jpienaar committed rGb70e4efb75bf: [mlir] Generalize broadcastable trait operands (authored by jpienaar).
[mlir] Generalize broadcastable trait operands
Jan 20 2020, 1:04 PM
jpienaar closed D72559: [mlir] Generalize broadcastable trait operands.
Jan 20 2020, 1:04 PM · Restricted Project

Jan 19 2020

jpienaar added inline comments to D72559: [mlir] Generalize broadcastable trait operands.
Jan 19 2020, 7:54 AM · Restricted Project
jpienaar retitled D72559: [mlir] Generalize broadcastable trait operands from [mlir] Add trait for staging update of broadcastable trait to [mlir] Generalize broadcastable trait operands.
Jan 19 2020, 7:44 AM · Restricted Project
jpienaar updated the diff for D72559: [mlir] Generalize broadcastable trait operands.

Update summary as I realized the doc was out of date but we had already fixed the bug about element type. Instead generalized broadcastable to variadic operands, rename trait and addressed comments.

Jan 19 2020, 7:44 AM · Restricted Project

Jan 17 2020

jpienaar accepted D72418: [Flang] add some cmake code to allow for out-of-tree building of MLIR and LLVM.

Looks good thanks

Jan 17 2020, 5:23 PM · Restricted Project, Restricted Project

Jan 16 2020

Herald added a reviewer for D72418: [Flang] add some cmake code to allow for out-of-tree building of MLIR and LLVM: nicolasvasilache.

I think you may have forgotten to upload the changed diff :) In general I think this looks good, I'd like to remove the duplicate functions but beyond that this should be good.

Jan 16 2020, 7:01 AM · Restricted Project, Restricted Project

Jan 15 2020

jpienaar committed rGfa26a37d3699: [mlir] Add shaped container component type interface (authored by jpienaar).
[mlir] Add shaped container component type interface
Jan 15 2020, 1:30 PM
jpienaar closed D72432: [mlir] Add shaped container component type interface.
Jan 15 2020, 1:30 PM · Restricted Project

Jan 14 2020

jpienaar accepted D72294: [mlir] Refactor ModuleState into AsmState and expose it to users..

Looks good thanks

Jan 14 2020, 8:22 AM · Restricted Project
jpienaar accepted D72672: [mlir] NFC: Fix trivial typos.
Jan 14 2020, 8:22 AM · Restricted Project
jpienaar accepted D72642: [mlir] Enable printing of FuncOp in the generic form..
Jan 14 2020, 8:22 AM · Restricted Project
jpienaar added a comment to D72697: [mlir] fix broken link to Glossary.

Yes the missing docs are considered static and supposed to be in mlir-www and the links to them work on mlir.llvm.org via relative, but could be made explicit to the website here..

Jan 14 2020, 8:22 AM · Restricted Project
jpienaar added a comment to D72418: [Flang] add some cmake code to allow for out-of-tree building of MLIR and LLVM.

Nice, seems to match what clang does here too so that's good to keep it in sync

Jan 14 2020, 8:21 AM · Restricted Project, Restricted Project

Jan 13 2020

jpienaar added a comment to D72294: [mlir] Refactor ModuleState into AsmState and expose it to users..

Looks good on first walk through

Jan 13 2020, 8:12 AM · Restricted Project
jpienaar added a comment to D72432: [mlir] Add shaped container component type interface.

Apparently I forgot to hit submit (seeing unsubmitted comments below).

Jan 13 2020, 8:03 AM · Restricted Project
jpienaar added inline comments to D72559: [mlir] Generalize broadcastable trait operands.
Jan 13 2020, 7:54 AM · Restricted Project

Jan 11 2020

jpienaar created D72559: [mlir] Generalize broadcastable trait operands.
Jan 11 2020, 10:08 AM · Restricted Project
jpienaar updated the diff for D72432: [mlir] Add shaped container component type interface.

Updated docs & switched to function_ref.

Jan 11 2020, 9:15 AM · Restricted Project

Jan 10 2020

jpienaar added a comment to D72481: [mlir][EDSC] Refactor dependencies involving EDSCs..

This is mostly a mechanical move or is there anything new to look at, correct?

Jan 10 2020, 9:43 AM · Restricted Project

Jan 8 2020

jpienaar created D72432: [mlir] Add shaped container component type interface.
Jan 8 2020, 7:57 PM · Restricted Project
jpienaar added a reviewer for D72384: [mlir] mlir-cpu-runner test's cblas_interface should export functions on Windows: nicolasvasilache.
Jan 8 2020, 2:04 PM · Restricted Project
jpienaar accepted D72043: [mlir] Update the CallGraph for nested symbol references, and simplify CallableOpInterface.

LG, thanks

Jan 8 2020, 1:55 PM · Restricted Project
jpienaar added a comment to D71655: [MachineScheduler] Allow clustering mem ops with complex addresses.

LG for Lanai changes too

Jan 8 2020, 1:55 PM · Restricted Project
jpienaar accepted D72403: [MLIR] Fix ML IR build on Windows with Visual Studio.

Thanks!

Jan 8 2020, 10:30 AM · Restricted Project

Jan 6 2020

jpienaar accepted D72042: [mlir] Update the use-list algorithms in SymbolTable to support nested references..

I don't know this part as well as Mehdi does, but it looks good.

Jan 6 2020, 1:01 PM · Restricted Project

Jan 3 2020

jpienaar added a comment to D72094: [mlir][linalg] Lower linalg to affine loops.

This seems to break on GCC 5.5:

Jan 3 2020, 11:31 AM · Restricted Project
jpienaar accepted D72127: [mlir] Fix indexed_accessor_range to properly forward the derived class..

Could we add a test that this would have hit? (I'm thinking of one just assigning the sliced/drop_front one).

Jan 3 2020, 8:12 AM · Restricted Project

Jan 2 2020

jpienaar accepted D72020: [mlir] Rewrite the internal representation of OpResult to be optimized for memory..

Thanks

Jan 2 2020, 1:27 PM · Restricted Project
jpienaar committed rG8f1caf518f37: [mlir] Only generate default for uncovered cases (authored by jpienaar).
[mlir] Only generate default for uncovered cases
Jan 2 2020, 12:59 PM
jpienaar committed rGf533fa3af5ef: [mlir] Revert default case that was needed (authored by jpienaar).
[mlir] Revert default case that was needed
Jan 2 2020, 12:40 PM
jpienaar committed rG98a88c1beec5: [mlir] Add parenthesis to avoid -Wparentheses (authored by jpienaar).
[mlir] Add parenthesis to avoid -Wparentheses
Jan 2 2020, 12:31 PM
jpienaar committed rG3d83d8259c1b: [mlir] Remove redudant default cases (authored by jpienaar).
[mlir] Remove redudant default cases
Jan 2 2020, 12:31 PM
jpienaar accepted D72045: Add missing mlir-headers target and add tablegen'd deps to it..

Thanks!

Jan 2 2020, 10:17 AM · Restricted Project
jpienaar accepted D72020: [mlir] Rewrite the internal representation of OpResult to be optimized for memory..

Looks good in general, thanks

Jan 2 2020, 10:08 AM · Restricted Project