Page MenuHomePhabricator
Feed Advanced Search

Yesterday

Esme updated the diff for D106643: [llvm-readobj][XCOFF] Add support for `--needed-libs` option..
Fri, Jul 23, 3:11 AM · Restricted Project
Esme updated the diff for D106643: [llvm-readobj][XCOFF] Add support for `--needed-libs` option..
Fri, Jul 23, 3:03 AM · Restricted Project
Esme requested review of D106643: [llvm-readobj][XCOFF] Add support for `--needed-libs` option..
Fri, Jul 23, 3:01 AM · Restricted Project

Thu, Jul 22

Esme updated the diff for D105613: [Debug-Info] [llvm-dwarfdump] Don't try to dump location list for attributes that don't have the loclist class..
Thu, Jul 22, 9:36 PM · Restricted Project
Esme updated the diff for D105613: [Debug-Info] [llvm-dwarfdump] Don't try to dump location list for attributes that don't have the loclist class..

Address comments.

Thu, Jul 22, 9:35 PM · Restricted Project
Esme added inline comments to D105613: [Debug-Info] [llvm-dwarfdump] Don't try to dump location list for attributes that don't have the loclist class..
Thu, Jul 22, 3:10 AM · Restricted Project
Esme updated the diff for D105613: [Debug-Info] [llvm-dwarfdump] Don't try to dump location list for attributes that don't have the loclist class..

Thank you Paul!
Address comments.

Thu, Jul 22, 3:10 AM · Restricted Project
Esme updated the diff for D105687: [Debug-Info] [llvm-dwarfdump] Don't use DW_FORM_data4/8 to encode the constants for DW_AT_data_member_location..

Address comments.

Thu, Jul 22, 2:16 AM · Restricted Project

Tue, Jul 20

Esme updated the diff for D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable..

Updated test.
Thanks James!
I have post the patch D106420 to solve the issue we mentioned and will post a following patch to add the feature of customizing the string table directly in yaml2obj.

Tue, Jul 20, 10:21 PM · Restricted Project
Esme requested review of D106420: [yaml2obj] Do not write the string table if there is no string entry..
Tue, Jul 20, 10:08 PM · Restricted Project

Sun, Jul 18

Esme added a comment to D105613: [Debug-Info] [llvm-dwarfdump] Don't try to dump location list for attributes that don't have the loclist class..

ping

Sun, Jul 18, 10:24 PM · Restricted Project
Esme added a comment to D105687: [Debug-Info] [llvm-dwarfdump] Don't use DW_FORM_data4/8 to encode the constants for DW_AT_data_member_location..

ping

Sun, Jul 18, 10:24 PM · Restricted Project

Thu, Jul 15

Esme added inline comments to D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable..
Thu, Jul 15, 11:44 PM · Restricted Project
Esme updated the diff for D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable..

Addressed comments.

Thu, Jul 15, 11:44 PM · Restricted Project

Tue, Jul 13

Esme added inline comments to D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable..
Tue, Jul 13, 1:29 AM · Restricted Project
Esme updated the diff for D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable..

Address comments.

Tue, Jul 13, 1:29 AM · Restricted Project

Mon, Jul 12

Esme updated the diff for D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable..

Added tests.

  1. A single-byte sized string entry.
  2. Empty string table with just the length field.
Mon, Jul 12, 11:54 PM · Restricted Project
Esme added inline comments to D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable..
Mon, Jul 12, 12:48 AM · Restricted Project
Esme updated the diff for D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable..

Addressed comments.

Mon, Jul 12, 12:48 AM · Restricted Project

Sun, Jul 11

Esme abandoned D105469: [Debug-Info] [llvm-dwarfdump] Don't treat DW_FORM_data4/8 to be section offsets in DWARF3..

@probinson @shchenz Thanks for your review.
This patch has been split into D105613 and D105687.
Looking forward to your more comments on new patches.

Sun, Jul 11, 7:15 PM · Restricted Project

Fri, Jul 9

Esme requested review of D105687: [Debug-Info] [llvm-dwarfdump] Don't use DW_FORM_data4/8 to encode the constants for DW_AT_data_member_location..
Fri, Jul 9, 2:35 AM · Restricted Project

Thu, Jul 8

Esme updated the diff for D105613: [Debug-Info] [llvm-dwarfdump] Don't try to dump location list for attributes that don't have the loclist class..
Thu, Jul 8, 2:19 AM · Restricted Project
Esme updated the summary of D105613: [Debug-Info] [llvm-dwarfdump] Don't try to dump location list for attributes that don't have the loclist class..
Thu, Jul 8, 2:09 AM · Restricted Project
Esme added a comment to D105469: [Debug-Info] [llvm-dwarfdump] Don't treat DW_FORM_data4/8 to be section offsets in DWARF3..

This means that DW_AT_byte_size can never point to a location list, and it was a bug to have it say it could (similarly for at least DW_AT_bit_size, and we probably should re-review the entire list). I suppose as an extension it could point to a location list, which would allow different size values based on the current execution address, although the only case I'm familiar with would derive the size from a variable, and so not have to have an actual location list.

Similarly, DW_AT_count can never point to a location list, with the same caveat as for DW_AT_byte_size.

Thu, Jul 8, 2:04 AM · Restricted Project
Esme requested review of D105613: [Debug-Info] [llvm-dwarfdump] Don't try to dump location list for attributes that don't have the loclist class..
Thu, Jul 8, 1:38 AM · Restricted Project

Wed, Jul 7

Esme added inline comments to D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable..
Wed, Jul 7, 9:41 PM · Restricted Project
Esme updated the diff for D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable..

Address comments.

Wed, Jul 7, 9:40 PM · Restricted Project
Esme added inline comments to D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable..
Wed, Jul 7, 8:15 PM · Restricted Project
Esme added a comment to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..

Thanks! @jhenderson
Hi, @sfertile, could you help to review the patch? thx.

Wed, Jul 7, 12:46 AM · Restricted Project
Esme updated the diff for D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable..
Wed, Jul 7, 12:26 AM · Restricted Project

Tue, Jul 6

Esme updated the diff for D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..
Tue, Jul 6, 9:45 PM · Restricted Project
Esme updated Esme.
Tue, Jul 6, 8:35 PM
Esme added a reviewer for D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable.: Higuoxing.
Tue, Jul 6, 7:52 PM · Restricted Project
Esme requested review of D105522: [llvm-readobj][XCOFF] Fix the error dumping for the first item of StringTable..
Tue, Jul 6, 7:38 PM · Restricted Project
Esme requested review of D105469: [Debug-Info] [llvm-dwarfdump] Don't treat DW_FORM_data4/8 to be section offsets in DWARF3..
Tue, Jul 6, 3:06 AM · Restricted Project

Sun, Jul 4

Herald added a reviewer for D58698: [DWARFFormValue] Don't consider DW_FORM_data4/8 to be section offsets.: jdoerfert.

Have you tested for DWARF3? It appears that you only added tests for DWARF2 and DWARF4.
And I noticed an error under DWARF3, where the C code source is the same as formclass4.s and formclass2.s.

Sun, Jul 4, 10:21 PM · Restricted Project
Esme committed rG0dad3f6ee2bb: [llvm-readobj][XCOFF] Add support for printing the String Table. (authored by Esme).
[llvm-readobj][XCOFF] Add support for printing the String Table.
Sun, Jul 4, 9:18 PM
Esme closed D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..
Sun, Jul 4, 9:17 PM · Restricted Project

Thu, Jul 1

Esme added a comment to D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..
Thu, Jul 1, 3:41 AM · Restricted Project

Wed, Jun 30

Esme updated the diff for D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..

Address comment.

Wed, Jun 30, 11:29 PM · Restricted Project

Sun, Jun 27

Esme updated the diff for D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..
  1. Address comments.
  2. Use MapVector instead of DenseMap to make string table in order.
Sun, Jun 27, 2:39 AM · Restricted Project

Jun 23 2021

Esme added inline comments to D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..
Jun 23 2021, 3:04 AM · Restricted Project
Esme updated the diff for D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..
Jun 23 2021, 3:04 AM · Restricted Project
Esme updated the diff for D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..

Addressed comments.

Jun 23 2021, 1:56 AM · Restricted Project

Jun 21 2021

Esme updated the diff for D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..
Jun 21 2021, 3:39 AM · Restricted Project
Esme updated the diff for D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..

Addressed comments.

Jun 21 2021, 3:36 AM · Restricted Project

Jun 20 2021

Esme committed rG657aa3a7631b: [yaml2obj] Add support for writing the long symbol name. (authored by Esme).
[yaml2obj] Add support for writing the long symbol name.
Jun 20 2021, 10:11 PM
Esme closed D103455: [yaml2obj] Add support for writing the long symbol name..
Jun 20 2021, 10:11 PM · Restricted Project
Esme requested review of D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..
Jun 20 2021, 8:25 PM · Restricted Project

Jun 15 2021

Esme added inline comments to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..
Jun 15 2021, 8:33 PM · Restricted Project
Esme added inline comments to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..
Jun 15 2021, 8:26 PM · Restricted Project
Esme added inline comments to D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.
Jun 15 2021, 7:48 PM · Restricted Project

Jun 10 2021

Esme committed rGec43c1213a16: [NFC][XCOFF] Replace structs FileHeader32/SectionHeader32 with constants. (authored by Esme).
[NFC][XCOFF] Replace structs FileHeader32/SectionHeader32 with constants.
Jun 10 2021, 4:11 AM
Esme closed D103901: [NFC][XCOFF] Replace structs FileHeader32/SectionHeader32 with constants..
Jun 10 2021, 4:11 AM · Restricted Project
Esme committed rGc8e980ab4acc: [XCOFF][llvm-objdump] Dump the debug type in `--section-headers` option. (authored by Esme).
[XCOFF][llvm-objdump] Dump the debug type in `--section-headers` option.
Jun 10 2021, 12:09 AM
Esme closed D103079: [XCOFF] [llvm-objdump] Add XCOFF recognition of debug section types under `--section-headers` option..
Jun 10 2021, 12:09 AM · Restricted Project

Jun 9 2021

Esme committed rG8a23f74eb79f: [llvm-objdump][XCOFF] Enable the -l (--line-numbers) option. (authored by Esme).
[llvm-objdump][XCOFF] Enable the -l (--line-numbers) option.
Jun 9 2021, 9:38 PM
Esme closed D101272: [llvm-objdump][XCOFF][AIX] Enable the -l (--line-numbers) option..
Jun 9 2021, 9:38 PM · Restricted Project
Esme added a comment to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..

As for the need of testing the string table, I will add such test after llvm-readobj --string-table is implemented.
For now, I can use the system tool dump under AIX to verify the results.

Jun 9 2021, 1:48 AM · Restricted Project
Esme added a comment to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

This patch introduce https://lab.llvm.org/buildbot/#/builders/85/builds/4886

llvm-project/llvm/lib/ObjectYAML/XCOFFEmitter.cpp:67:16: runtime error: null pointer passed as argument 2, which is declared to never be null
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../x86_64-linux-gnu/include/string.h:43:28: note: nonnull attribute specified here
    #0 0x45c3df in (anonymous namespace)::XCOFFWriter::writeXCOFF() /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/ObjectYAML/XCOFFEmitter.cpp
    #1 0x45b0b1 in llvm::yaml::yaml2xcoff(llvm::XCOFFYAML::Object&, llvm::raw_ostream&, llvm::function_ref<void (llvm::Twine const&)>) /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/ObjectYAML/XCOFFEmitter.cpp:311:17
    #2 0x30a181 in llvm::yaml::convertYAML(llvm::yaml::Input&, llvm::raw_ostream&, llvm::function_ref<void (llvm::Twine const&)>, unsigned int, unsigned long) /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/ObjectYAML/yaml2obj.cpp:48:14
    #3 0x306322 in main /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm-project/llvm/tools/yaml2obj/yaml2obj.cpp:136:8
    #4 0x7f38e52b709a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2409a)
    #5 0x2eafd9 in _start (/b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/yaml2obj+0x2eafd9)

CC @eugenis

Jun 9 2021, 1:45 AM · Restricted Project
Esme added a comment to D103455: [yaml2obj] Add support for writing the long symbol name..

Addressed comments except dumping the raw string table.
It seems llvm-readobj can't dump the raw string table for XCOFF, I have to find another tool to do this.

I think it would make a lot of sense to add string table dumping to llvm-readobj. It's generic enough that you could probably get away with implementing it for multiple file formats too (e.g. for ELF it would dump all SHT_STRTAB sections), but initially, you can just implement it for XCOFF. I'd use a switch name as simple as --string-table or possibly --string-tables.

Jun 9 2021, 1:29 AM · Restricted Project
Esme updated the diff for D103455: [yaml2obj] Add support for writing the long symbol name..
Jun 9 2021, 1:29 AM · Restricted Project
Esme committed rG699231ab3c7d: Fix the 4203-Buildbot failure in LLVM Buildbot on llvm-clang-win-x-aarch64 (authored by Esme).
Fix the 4203-Buildbot failure in LLVM Buildbot on llvm-clang-win-x-aarch64
Jun 9 2021, 12:24 AM

Jun 8 2021

Esme updated the diff for D103455: [yaml2obj] Add support for writing the long symbol name..

Rebase.

Jun 8 2021, 11:39 PM · Restricted Project
Esme committed rG955bc5950b45: Remove white space in llvm-objdump/XCOFF/section-headers.test (authored by Esme).
Remove white space in llvm-objdump/XCOFF/section-headers.test
Jun 8 2021, 10:39 PM
Esme added inline comments to D98003: [obj2yaml] Implement parsing sections and auxiliary entries of XCOFF..
Jun 8 2021, 8:27 PM · Restricted Project
Esme updated the diff for D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..

Rebase.

Jun 8 2021, 8:16 PM · Restricted Project
Esme updated the diff for D103901: [NFC][XCOFF] Replace structs FileHeader32/SectionHeader32 with constants..

Addressed comments.

Jun 8 2021, 8:14 PM · Restricted Project
Esme committed rGdb4ac5a63e11: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of… (authored by Esme).
[NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of…
Jun 8 2021, 8:12 PM
Esme closed D103146: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of binary files..
Jun 8 2021, 8:12 PM · Restricted Project
Esme updated the diff for D103455: [yaml2obj] Add support for writing the long symbol name..

Addressed comments except dumping the raw string table.
It seems llvm-readobj can't dump the raw string table for XCOFF, I have to find another tool to do this.

Jun 8 2021, 8:46 AM · Restricted Project
Esme requested review of D103901: [NFC][XCOFF] Replace structs FileHeader32/SectionHeader32 with constants..
Jun 8 2021, 8:37 AM · Restricted Project
Esme updated the diff for D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..

Rebase.

Jun 8 2021, 8:25 AM · Restricted Project

Jun 7 2021

Esme committed rG310d2b4957c8: [yaml2obj] Fix buildbot-issue-4886 (authored by Esme).
[yaml2obj] Fix buildbot-issue-4886
Jun 7 2021, 8:04 PM

Jun 6 2021

Esme committed rGbcb20aa7701d: Fixed the build failure of yaml2obj in XCOFFEmitter.cpp: (authored by Esme).
Fixed the build failure of yaml2obj in XCOFFEmitter.cpp:
Jun 6 2021, 10:49 PM
Esme committed rG50bb1b930dbc: [yaml2obj] Initial the support of yaml2obj for 32-bit XCOFF. (authored by Esme).
[yaml2obj] Initial the support of yaml2obj for 32-bit XCOFF.
Jun 6 2021, 9:15 PM
Esme closed D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Jun 6 2021, 9:15 PM · Restricted Project

Jun 4 2021

Esme committed rGfbfd71719767: [Debug-Info] handle DW_CC_pass_by_value/DW_CC_pass_by_reference under strict… (authored by Esme).
[Debug-Info] handle DW_CC_pass_by_value/DW_CC_pass_by_reference under strict…
Jun 4 2021, 1:16 AM
Esme closed D103300: [Debug-Info] handle DW_CC_pass_by_value/DW_CC_pass_by_reference under strict DWARF..
Jun 4 2021, 1:15 AM · Restricted Project

Jun 2 2021

Esme updated the diff for D103300: [Debug-Info] handle DW_CC_pass_by_value/DW_CC_pass_by_reference under strict DWARF..

Address comments

Jun 2 2021, 11:19 PM · Restricted Project

Jun 1 2021

Esme requested review of D103455: [yaml2obj] Add support for writing the long symbol name..
Jun 1 2021, 6:00 AM · Restricted Project

May 31 2021

Esme added inline comments to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
May 31 2021, 2:37 AM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Address comment.

May 31 2021, 2:37 AM · Restricted Project
Esme added inline comments to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
May 31 2021, 12:59 AM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
  1. Addressed Zheng's comments.
  2. Set more fields optional and modified the correspond testing.
May 31 2021, 12:58 AM · Restricted Project

May 30 2021

Esme added inline comments to D98003: [obj2yaml] Implement parsing sections and auxiliary entries of XCOFF..
May 30 2021, 7:58 PM · Restricted Project
Esme updated the diff for D98003: [obj2yaml] Implement parsing sections and auxiliary entries of XCOFF..
  1. Address comment.
  2. Rebase on D85774 and D95505.
May 30 2021, 7:58 PM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
  1. Drop the useless Symbol test.
  2. Add normalization/denormalization for the Section Flags set.
May 30 2021, 7:25 PM · Restricted Project

May 27 2021

Esme requested review of D103300: [Debug-Info] handle DW_CC_pass_by_value/DW_CC_pass_by_reference under strict DWARF..
May 27 2021, 10:12 PM · Restricted Project
Esme added a comment to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Hi @jasonliu @DiggerLin @sfertile @shchenz @hubert.reinterpretcast, I would appreciate it if you could review this patch and check if the file format is written properly in your opinion. Thanks in advance!

May 27 2021, 8:27 PM · Restricted Project

May 26 2021

Esme committed rGd82f2a123f9c: [llvm-objdump] Print the DEBUG type under `--section-headers`. (authored by Esme).
[llvm-objdump] Print the DEBUG type under `--section-headers`.
May 26 2021, 9:54 PM
Esme closed D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`..
May 26 2021, 9:54 PM · Restricted Project
Esme added inline comments to D103146: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of binary files..
May 26 2021, 3:28 AM · Restricted Project
Esme updated the diff for D103146: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of binary files..

Address comment.

May 26 2021, 3:28 AM · Restricted Project
Esme updated the diff for D103079: [XCOFF] [llvm-objdump] Add XCOFF recognition of debug section types under `--section-headers` option..
May 26 2021, 2:57 AM · Restricted Project
Esme updated the diff for D103079: [XCOFF] [llvm-objdump] Add XCOFF recognition of debug section types under `--section-headers` option..

Address comment.

May 26 2021, 2:56 AM · Restricted Project
Esme requested review of D103146: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of binary files..
May 26 2021, 2:54 AM · Restricted Project
Esme committed rGbf809cd165f4: [NFC][object] Change the input parameter of the method isDebugSection. (authored by Esme).
[NFC][object] Change the input parameter of the method isDebugSection.
May 26 2021, 1:48 AM
Esme closed D102601: [NFC][object] Change the input parameter of the method isDebugSection..
May 26 2021, 1:48 AM · Restricted Project
Esme added a comment to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Could you at least test manually the max section limit case.

May 26 2021, 12:06 AM · Restricted Project