Page MenuHomePhabricator
Feed Advanced Search

May 14 2021

mceier updated the diff for D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Added LLVM_ prefix to all occurrences of HAVE_LIBXAR; fixed one missing char.

May 14 2021, 2:12 PM · Restricted Project, Restricted Project
mceier added a comment to D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Sorry about the delay here.

May 14 2021, 10:57 AM · Restricted Project, Restricted Project

May 10 2021

mceier requested review of D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Looks great. Do you need me to land this for you, or can you commit yourself?

May 10 2021, 8:30 AM · Restricted Project, Restricted Project

May 8 2021

mceier updated the diff for D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Verified that standalone lld builds with HAVE_LIBXAR set and unset.
Added HAVE_LIBXAR to LLVMConfig.cmake and linking liblldMachO2.so with XAR_LIB if HAVE_LIBXAR is set.

May 8 2021, 12:53 AM · Restricted Project, Restricted Project
mceier updated the diff for D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Added missing word in a comment for HAVE_LIBXAR define

May 8 2021, 12:01 AM · Restricted Project, Restricted Project

May 7 2021

mceier updated the diff for D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Moved HAVE_LIBXAR from config.h to llvm-config.h

May 7 2021, 11:45 AM · Restricted Project, Restricted Project
mceier added a comment to D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Wait, this isn't right, is it? We need this for #ifndef HAVE_LIBXAR and HAVE_LIBXAR is in config.h but not in llvm-config.h. This will silently break HAVE_LIBXAR checks.

May 7 2021, 11:11 AM · Restricted Project, Restricted Project
mceier requested review of D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.
May 7 2021, 10:41 AM · Restricted Project, Restricted Project

Nov 26 2020

mceier updated the diff for D92158: Also include component groups in llvm-config --components list.

Renamed llvm_target_to_build to llvm_component

Nov 26 2020, 1:03 AM · Restricted Project
mceier requested review of D92158: Also include component groups in llvm-config --components list.
Nov 26 2020, 12:47 AM · Restricted Project

Nov 24 2020

mceier added inline comments to D86495: [CSSPGO] MIR target-independent pseudo instruction for pseudo-probe intrinsic.
Nov 24 2020, 3:28 PM · Restricted Project
mceier added inline comments to D86495: [CSSPGO] MIR target-independent pseudo instruction for pseudo-probe intrinsic.
Nov 24 2020, 1:04 PM · Restricted Project
mceier added inline comments to D86495: [CSSPGO] MIR target-independent pseudo instruction for pseudo-probe intrinsic.
Nov 24 2020, 12:10 AM · Restricted Project

Nov 7 2020

mceier accepted D90997: [AMDGPU] SIWholeQuadMode fix mode insertion when SCC always defined.

I confirm this fixes the llc and CS:GO crash from D88081

Nov 7 2020, 1:05 AM · Restricted Project

Nov 6 2020

mceier added inline comments to D88081: [AMDGPU] Move WQM Pass after MI Scheduler.
Nov 6 2020, 6:07 AM · Restricted Project
mceier added inline comments to D88081: [AMDGPU] Move WQM Pass after MI Scheduler.
Nov 6 2020, 5:25 AM · Restricted Project

Nov 5 2020

mceier added inline comments to D88081: [AMDGPU] Move WQM Pass after MI Scheduler.
Nov 5 2020, 11:53 AM · Restricted Project
mceier added inline comments to D88081: [AMDGPU] Move WQM Pass after MI Scheduler.
Nov 5 2020, 11:49 AM · Restricted Project
mceier added inline comments to D88081: [AMDGPU] Move WQM Pass after MI Scheduler.
Nov 5 2020, 6:02 AM · Restricted Project

Oct 30 2020

mceier added inline comments to D88081: [AMDGPU] Move WQM Pass after MI Scheduler.
Oct 30 2020, 1:18 PM · Restricted Project