Page MenuHomePhabricator
Feed Advanced Search

Tue, Jul 20

zequanwu committed rG8773822c578a: [Utils] Add -compilation-dir flag to prepare-code-coverage-artifact.py (authored by zequanwu).
[Utils] Add -compilation-dir flag to prepare-code-coverage-artifact.py
Tue, Jul 20, 10:56 AM
zequanwu closed D106314: [Utils] Add -compilation-dir flag to prepare-code-coverage-artifact.py.
Tue, Jul 20, 10:56 AM · Restricted Project
zequanwu updated the diff for D106314: [Utils] Add -compilation-dir flag to prepare-code-coverage-artifact.py.

Add short flag "-C".

Tue, Jul 20, 10:55 AM · Restricted Project

Mon, Jul 19

zequanwu updated the diff for D106314: [Utils] Add -compilation-dir flag to prepare-code-coverage-artifact.py.

Add the flag only if it's non-empty.

Mon, Jul 19, 2:40 PM · Restricted Project
zequanwu requested review of D106314: [Utils] Add -compilation-dir flag to prepare-code-coverage-artifact.py.
Mon, Jul 19, 2:27 PM · Restricted Project

Fri, Jul 16

zequanwu added a comment to D105321: [Bitcode][OpaquePtr] Remove usages of PointerType's getElementType().

I don't really get how this is supposed to work. If opaque pointers are enabled, all PointerTypes (in the same address space) are going to be the same, so you can't create a meaningful map from PointerType to element type. The map will effectively store the last element type it has seen on any pointer.

This is to be compatible with llvm bitcode file with opaque pointer disabled. Those files have pointers' pointee types encoded. So, we need the map to keep track of pointers' pointee types.

the issue is what nikic said, that if we ignore address spaces, there will only be one singleton PointerType. We can't map the same PointerType to multiple pointee types, that doesn't do anything.
Rather, we need to map each Value to a potential pointee type.

Fri, Jul 16, 3:49 PM · Restricted Project

Mon, Jul 12

zequanwu added inline comments to D105826: [docs/llvm-cov] Document -compilation-dir.
Mon, Jul 12, 10:43 AM · Restricted Project

Fri, Jul 2

zequanwu added a comment to D105321: [Bitcode][OpaquePtr] Remove usages of PointerType's getElementType().

I don't really get how this is supposed to work. If opaque pointers are enabled, all PointerTypes (in the same address space) are going to be the same, so you can't create a meaningful map from PointerType to element type. The map will effectively store the last element type it has seen on any pointer.

This is to be compatible with llvm bitcode file with opaque pointer disabled. Those files have pointers' pointee types encoded. So, we need the map to keep track of pointers' pointee types.

Fri, Jul 2, 11:48 AM · Restricted Project

Thu, Jul 1

zequanwu requested review of D105321: [Bitcode][OpaquePtr] Remove usages of PointerType's getElementType().
Thu, Jul 1, 4:18 PM · Restricted Project

Wed, Jun 30

zequanwu updated the diff for D104871: [Docs] use -fprofile-generate for IR PGO and -fprofile-instr-generate for code coverage.

Address comments.

Wed, Jun 30, 4:16 PM · Restricted Project

Jun 28 2021

zequanwu added a comment to rG5cb20ef8a235: [InstCombine] Make indexed compare fold opaque ptr compatible.

Jun 28 2021, 2:30 PM

Jun 25 2021

zequanwu updated the diff for D104871: [Docs] use -fprofile-generate for IR PGO and -fprofile-instr-generate for code coverage.

Update wording.

Jun 25 2021, 3:18 PM · Restricted Project
zequanwu added a comment to rG5cb20ef8a235: [InstCombine] Make indexed compare fold opaque ptr compatible.

Hi, this caused chromium windows bots fail https://crbug.com/1223951: llvm::GetElementPtrInst *llvm::GetElementPtrInst::Create(llvm::Type *, llvm::Value *, ArrayRef<llvm::Value *>, const llvm::Twine &, llvm::Instruction *): Assertion cast<PointerType>(Ptr->getType()->getScalarType()) ->isOpaqueOrPointeeTypeMatches(PointeeType)' failed.

Jun 25 2021, 3:11 PM

Jun 24 2021

zequanwu requested review of D104871: [Docs] use -fprofile-generate for IR PGO and -fprofile-instr-generate for code coverage.
Jun 24 2021, 12:35 PM · Restricted Project

Jun 23 2021

zequanwu added a reverting change for rGe3d24b45b8f8: ThinLTO: Fix inline assembly references to static functions with CFI: rG9393894331e9: Revert "ThinLTO: Fix inline assembly references to static functions with CFI".
Jun 23 2021, 7:25 PM
zequanwu committed rG9393894331e9: Revert "ThinLTO: Fix inline assembly references to static functions with CFI" (authored by zequanwu).
Revert "ThinLTO: Fix inline assembly references to static functions with CFI"
Jun 23 2021, 7:25 PM
zequanwu added a reverting change for D104058: ThinLTO: Fix inline assembly references to static functions with CFI: rG9393894331e9: Revert "ThinLTO: Fix inline assembly references to static functions with CFI".
Jun 23 2021, 7:25 PM · Restricted Project, Restricted Project
zequanwu added a comment to D104058: ThinLTO: Fix inline assembly references to static functions with CFI.

Hi, this caused compiler crash: "Assertion `materialized_use_empty() && "Uses remain when a value is destroyed!"'" on chromium build https://ci.chromium.org/ui/p/chromium/builders/try/linux-official/151/overview.
Here is the error message:

While deleting: void ()* %
Use still stuck around after Def is destroyed:i8* bitcast (void ()* <badref> to i8*)
While deleting: void ()* %
Use still stuck around after Def is destroyed:i8* bitcast (voidld.lld: /usr/local/google/home/zequanwu/llvm-project/llvm/lib/IR/Value.cpp:103: llvm::Value::~Value(): Assertion `materialized_use_empty() && "Uses remain when a value is destroyed!"' failed.
 ()* <badref> to i8*)
Jun 23 2021, 7:17 PM · Restricted Project, Restricted Project
zequanwu added a comment to D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions.

Hi, this caused compiler crash with error "Assertion `cast<DISubprogram>(Scope)->describes(&MF->getFunction())' failed." on iOS platforms. So, I reverted it.
I'm working on a reduced repro.

FYI this also caused a failure on GreenDragon, with -verify-machineinstrs: https://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O0-g/9663/consoleFull#-134330334249ba4694-19c4-4d7e-bec5-911270d8a58c

The failure should be re-producible by building the following C++ file from llvm-test-suite:

bin/clang++  -DNDEBUG  -B /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin    -Wno-unused-command-line-argument -mllvm -verify-machineinstrs -O0 -g -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.5.sdk   -w -Werror=date-time -MD -MT SingleSource/UnitTests/CMakeFiles/block-byref-cxxobj-test.dir/block-byref-cxxobj-test.cpp.o -MF SingleSource/UnitTests/CMakeFiles/block-byref-cxxobj-test.dir/block-byref-cxxobj-test.cpp.o.d -o SingleSource/UnitTests/CMakeFiles/block-byref-cxxobj-test.dir/block-byref-cxxobj-test.cpp.o -c /Users/buildslave/jenkins/workspace/test-suite-verify-machineinstrs-aarch64-O0-g/test-suite/SingleSource/UnitTests/block-byref-cxxobj-test.cpp
Jun 23 2021, 11:23 AM · Restricted Project
zequanwu committed rGec08f03be394: [OpaquePtr] Mangle intrinsics with opaque pointers arguments (authored by zequanwu).
[OpaquePtr] Mangle intrinsics with opaque pointers arguments
Jun 23 2021, 10:52 AM
zequanwu closed D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.
Jun 23 2021, 10:52 AM · Restricted Project

Jun 22 2021

zequanwu added a comment to D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions.

Hi, this caused compiler crash with error "Assertion `cast<DISubprogram>(Scope)->describes(&MF->getFunction())' failed." on iOS platforms. So, I reverted it.
I'm working on a reduced repro.

Jun 22 2021, 9:51 PM · Restricted Project
zequanwu added a reverting change for rGf4c06bcb67a1: [CodeGen] Don't create fake FunctionDecls when generating block/byref: rGf681fd927e88: Revert "[CodeGen] Don't create fake FunctionDecls when generating block/byref".
Jun 22 2021, 9:48 PM
zequanwu committed rGf681fd927e88: Revert "[CodeGen] Don't create fake FunctionDecls when generating block/byref" (authored by zequanwu).
Revert "[CodeGen] Don't create fake FunctionDecls when generating block/byref"
Jun 22 2021, 9:48 PM
zequanwu added a reverting change for D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions: rGf681fd927e88: Revert "[CodeGen] Don't create fake FunctionDecls when generating block/byref".
Jun 22 2021, 9:48 PM · Restricted Project

Jun 16 2021

zequanwu added a comment to D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.

I couldn't parse your comment, could you rephrase?

Oh, I just went and looked more - and now I see that the mangled parameter types are . separated, so the ambiguities I thought could occur (is p0i8 an opaque pointer followed by an i8 or a typed pointer-to-i8? Not actually ambiguous, because opaque pointer followed by i8 would be p0.i8 instead).

Carry on!

Jun 16 2021, 1:56 PM · Restricted Project

Jun 15 2021

zequanwu added a comment to D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.

The patch looks mostly good, but I'm not sold on "op". Can we just use "p"?

Presumably then we wouldn't know whether to parse a type after the address space or not? Unless we only support this when everything is opaque pointers? (so there can be no confusion between opaque pointers or not)

Jun 15 2021, 4:20 PM · Restricted Project
zequanwu updated the diff for D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.

update.

Jun 15 2021, 4:06 PM · Restricted Project
zequanwu updated the diff for D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.

Address comment.

Jun 15 2021, 4:05 PM · Restricted Project
zequanwu updated the diff for D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.

Rebase.

Jun 15 2021, 3:00 PM · Restricted Project
zequanwu committed rGfad8d4230ff7: [OpaquePtr] Verify Opaque pointer in function parameter (authored by zequanwu).
[OpaquePtr] Verify Opaque pointer in function parameter
Jun 15 2021, 2:58 PM
zequanwu closed D104309: [OpaquePtr] Verify Opaque pointer in function parameter.
Jun 15 2021, 2:57 PM · Restricted Project
zequanwu updated the diff for D104309: [OpaquePtr] Verify Opaque pointer in function parameter.

Update.

Jun 15 2021, 2:44 PM · Restricted Project
zequanwu updated the diff for D104309: [OpaquePtr] Verify Opaque pointer in function parameter.

Update.

Jun 15 2021, 11:55 AM · Restricted Project
zequanwu requested review of D104309: [OpaquePtr] Verify Opaque pointer in function parameter.
Jun 15 2021, 10:01 AM · Restricted Project

Jun 14 2021

zequanwu updated the summary of D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.
Jun 14 2021, 4:00 PM · Restricted Project
zequanwu updated the diff for D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.

Add a test case.

Jun 14 2021, 3:59 PM · Restricted Project
zequanwu requested review of D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments.
Jun 14 2021, 3:05 PM · Restricted Project

Jun 11 2021

zequanwu abandoned D99695: [llvm-cov] Use -path-equivalence to support relative path..
Jun 11 2021, 1:45 PM · Restricted Project

May 27 2021

zequanwu committed rG59b8afe50274: [clang-cl] Bump default -fms-compatibility-version to 19.14 (authored by zequanwu).
[clang-cl] Bump default -fms-compatibility-version to 19.14
May 27 2021, 8:41 PM
zequanwu closed D103293: [clang-cl] Bump default -fms-compatibility-version to 19.14.
May 27 2021, 8:41 PM · Restricted Project
zequanwu updated the diff for D103293: [clang-cl] Bump default -fms-compatibility-version to 19.14.

address comment

May 27 2021, 8:40 PM · Restricted Project
zequanwu requested review of D103293: [clang-cl] Bump default -fms-compatibility-version to 19.14.
May 27 2021, 4:39 PM · Restricted Project

May 11 2021

zequanwu added a comment to D100232: [Coverage] Support overriding compilation directory.

Any update? Do you plan to land those two patches?

May 11 2021, 11:45 AM · Restricted Project

Apr 29 2021

zequanwu added a reverting change for rGa78fa73bcf98: Revert "[lld-link] Enable addrsig table in COFF lto": rG6b30240288fc: Reland "[lld-link] Enable addrsig table in COFF lto".
Apr 29 2021, 3:54 PM
zequanwu committed rG6b30240288fc: Reland "[lld-link] Enable addrsig table in COFF lto" (authored by zequanwu).
Reland "[lld-link] Enable addrsig table in COFF lto"
Apr 29 2021, 3:54 PM
zequanwu committed rGcab48e2f0e00: [CodeGen] don't emit addrsig symbol if it's used only by metadata (authored by zequanwu).
[CodeGen] don't emit addrsig symbol if it's used only by metadata
Apr 29 2021, 3:40 PM
zequanwu closed D101512: [CodeGen] don't emit addrsig symbol if it's used only by metadata.
Apr 29 2021, 3:40 PM · Restricted Project
zequanwu updated the diff for D101512: [CodeGen] don't emit addrsig symbol if it's used only by metadata.

Refactor.

Apr 29 2021, 3:39 PM · Restricted Project
zequanwu updated the diff for D101512: [CodeGen] don't emit addrsig symbol if it's used only by metadata.

Address comment.

Apr 29 2021, 2:44 PM · Restricted Project
zequanwu added inline comments to D101512: [CodeGen] don't emit addrsig symbol if it's used only by metadata.
Apr 29 2021, 2:20 PM · Restricted Project

Apr 28 2021

zequanwu abandoned D100994: [MC] Set addrsig symbol as weak/weakExternal.
Apr 28 2021, 9:42 PM · Restricted Project
zequanwu requested review of D101512: [CodeGen] don't emit addrsig symbol if it's used only by metadata.
Apr 28 2021, 9:42 PM · Restricted Project

Apr 22 2021

zequanwu accepted D100232: [Coverage] Support overriding compilation directory.

lgtm.

Apr 22 2021, 3:16 PM · Restricted Project

Apr 21 2021

zequanwu abandoned D100966: [lld-link] Ignore undefined symbols in .addrsig table.

This is not correct. A symbol marked by .addrsig_sym can be referenced via normal means. With this patch, the diagnostic may change from error: undefined symbol: bar to error: relocation against symbol in discarded section: bar

Apr 21 2021, 1:13 PM · Restricted Project
zequanwu requested review of D100994: [MC] Set addrsig symbol as weak/weakExternal.
Apr 21 2021, 1:13 PM · Restricted Project
zequanwu requested review of D100966: [lld-link] Ignore undefined symbols in .addrsig table.
Apr 21 2021, 9:17 AM · Restricted Project

Apr 20 2021

zequanwu committed rGaa80955f638f: [lld-link] Warn on exported deleting dtor (authored by zequanwu).
[lld-link] Warn on exported deleting dtor
Apr 20 2021, 2:07 PM
zequanwu closed D100606: [lld-link] Warn on exported deleting dtor.
Apr 20 2021, 2:06 PM · Restricted Project
zequanwu removed a reviewer for D100535: [llvm-cov] Support for v4 format in convert-for-testing: zequanwu.

Sorry, I'm not familiar with the format of coverage mapping.

Apr 20 2021, 10:24 AM · Restricted Project

Apr 19 2021

zequanwu updated the diff for D100606: [lld-link] Warn on exported deleting dtor.
  • Check e.sym for null. If the flag /export=foo is provided and foo is not in the object file. e.sym will be null.
  • Remove $ in exported name to have same name on windows and linux.
Apr 19 2021, 3:27 PM · Restricted Project
zequanwu committed rGe28435caf63b: [ThinLTO] Copy UnnamedAddr when spliting module. (authored by zequanwu).
[ThinLTO] Copy UnnamedAddr when spliting module.
Apr 19 2021, 2:05 PM
zequanwu closed D100498: [ThinLTO] Copy UnnamedAddr when spliting module..
Apr 19 2021, 2:05 PM · Restricted Project
zequanwu updated the diff for D100498: [ThinLTO] Copy UnnamedAddr when spliting module..

update and tested to build chrome.

Apr 19 2021, 2:03 PM · Restricted Project

Apr 16 2021

zequanwu updated the diff for D100606: [lld-link] Warn on exported deleting dtor.

Update testcase.

Apr 16 2021, 7:05 PM · Restricted Project

Apr 15 2021

zequanwu requested review of D100606: [lld-link] Warn on exported deleting dtor.
Apr 15 2021, 4:25 PM · Restricted Project

Apr 14 2021

zequanwu updated the diff for D100498: [ThinLTO] Copy UnnamedAddr when spliting module..
  • Copy function attributes and remove ret/param attributes.
  • Add a test case.
Apr 14 2021, 6:29 PM · Restricted Project
zequanwu added a comment to D100498: [ThinLTO] Copy UnnamedAddr when spliting module..
Apr 14 2021, 3:51 PM · Restricted Project
zequanwu updated the summary of D100498: [ThinLTO] Copy UnnamedAddr when spliting module..
Apr 14 2021, 11:30 AM · Restricted Project
zequanwu requested review of D100498: [ThinLTO] Copy UnnamedAddr when spliting module..
Apr 14 2021, 11:27 AM · Restricted Project

Apr 9 2021

zequanwu added a comment to D100232: [Coverage] Support overriding compilation directory.

Can you add a test case for the llvm-cov new flag? Otherwise looks good to me.

Apr 9 2021, 3:46 PM · Restricted Project

Apr 2 2021

zequanwu added a comment to D99695: [llvm-cov] Use -path-equivalence to support relative path..
In D99695#2664701, @vsk wrote:

I think then you would somehow need multiple -compilation-dir options if e.g. you have paths with different levels of ../ nesting, e.g. ../../foo.c and ../../../../bar.c. That sounds like it could become hard to manage.

In RawCoverageFilenamesReader::readUncompressed, we do:

SmallString<256> P(CWD);
llvm::sys::path::append(P, Filename);

Can this just be turned into an absolute path?

The flag would override the compilation dir that's stored inside the profile (the 0th path entry) so there should be just one. In that code snippet, it means overriding CWD.

Apr 2 2021, 5:28 PM · Restricted Project

Apr 1 2021

zequanwu added a comment to D99695: [llvm-cov] Use -path-equivalence to support relative path..
In D99695#2664701, @vsk wrote:

I think then you would somehow need multiple -compilation-dir options if e.g. you have paths with different levels of ../ nesting, e.g. ../../foo.c and ../../../../bar.c. That sounds like it could become hard to manage.

This case is hard to manage. This patch would only handle case that all paths have same level of ../.

Apr 1 2021, 12:30 PM · Restricted Project
zequanwu added a comment to D99695: [llvm-cov] Use -path-equivalence to support relative path..
In D99695#2664545, @vsk wrote:

For example, if we have /tmp/src/a.cpp embedded in the binary, llvm-cov show -path-equivalence=/tmp/src/,/cov ... will generate output direcotry like this: coverage/cov/a.cpp.

What happens if the binary has a relative path '../../a.cpp' embedded and the user passes -path-equivalence=/tmp/src/,/cov to llvm-cov? Is a.cpp written to <coverage-dir>/cov/../../a.cpp?

In this case, ../../ is not matching /tmp/src. So, it's like -path-equivalence is not given. llvm-cov will lookup a.cpp in ../../ relative to current working directory.

Apr 1 2021, 11:51 AM · Restricted Project

Mar 31 2021

zequanwu requested review of D99695: [llvm-cov] Use -path-equivalence to support relative path..
Mar 31 2021, 5:20 PM · Restricted Project

Mar 30 2021

zequanwu committed rGeabd55b1b2c5: [lld-link] Enable addrsig table in COFF lto (authored by zequanwu).
[lld-link] Enable addrsig table in COFF lto
Mar 30 2021, 4:02 PM
zequanwu closed D99613: [lld-link] Enable addrsig table in COFF lto.
Mar 30 2021, 4:02 PM · Restricted Project
zequanwu abandoned D98463: [IR] Add significant_addr property..
Mar 30 2021, 11:04 AM · Restricted Project
zequanwu requested review of D99613: [lld-link] Enable addrsig table in COFF lto.
Mar 30 2021, 11:04 AM · Restricted Project

Mar 24 2021

zequanwu committed rGdd388ba3e0b0: [llvm-cov] Check path emptyness in path-equivalence after removing dots. (authored by zequanwu).
[llvm-cov] Check path emptyness in path-equivalence after removing dots.
Mar 24 2021, 5:55 PM

Mar 23 2021

zequanwu added a reverting change for rG424bf5d8918f: [Driver] Bring back "Clean up Debian multiarch /usr/include/<triplet> madness"…: rGaae84b8e3939: Revert "[Driver] Bring back "Clean up Debian multiarch /usr/include/<triplet>….
Mar 23 2021, 8:14 PM
zequanwu committed rGaae84b8e3939: Revert "[Driver] Bring back "Clean up Debian multiarch /usr/include/<triplet>… (authored by zequanwu).
Revert "[Driver] Bring back "Clean up Debian multiarch /usr/include/<triplet>…
Mar 23 2021, 8:14 PM

Mar 22 2021

zequanwu abandoned D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant..

This overlaps with the functionality of attribute used.

Mar 22 2021, 2:39 PM · Restricted Project, Restricted Project

Mar 18 2021

zequanwu committed rG1c740b29fae3: [clang-cl] make -ffile-compilation-dir a CoreOption. (authored by zequanwu).
[clang-cl] make -ffile-compilation-dir a CoreOption.
Mar 18 2021, 1:29 PM
zequanwu closed D98887: [clang-cl] make -ffile-compilation-dir a CoreOption..
Mar 18 2021, 1:29 PM · Restricted Project
zequanwu requested review of D98887: [clang-cl] make -ffile-compilation-dir a CoreOption..
Mar 18 2021, 12:30 PM · Restricted Project

Mar 16 2021

zequanwu added a reverting change for rGedf700485151: [ConstantFold] Handle vectors in ConstantFoldLoadThroughBitcast(): rGcbd7eabea88e: Revert "[ConstantFold] Handle vectors in ConstantFoldLoadThroughBitcast()".
Mar 16 2021, 2:37 PM
zequanwu committed rGcbd7eabea88e: Revert "[ConstantFold] Handle vectors in ConstantFoldLoadThroughBitcast()" (authored by zequanwu).
Revert "[ConstantFold] Handle vectors in ConstantFoldLoadThroughBitcast()"
Mar 16 2021, 2:37 PM

Mar 12 2021

zequanwu updated the diff for D98463: [IR] Add significant_addr property..

Update LangRef.

Mar 12 2021, 3:14 PM · Restricted Project

Mar 11 2021

zequanwu updated the diff for D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant..

Split clang change and IR change.

Mar 11 2021, 4:19 PM · Restricted Project, Restricted Project
zequanwu requested review of D98463: [IR] Add significant_addr property..
Mar 11 2021, 3:45 PM · Restricted Project
zequanwu accepted D98444: [FIX] Allow non-constant assume operand bundle operands..
Mar 11 2021, 12:54 PM · Restricted Project
zequanwu added a comment to D98444: [FIX] Allow non-constant assume operand bundle operands..

LGTM.

Mar 11 2021, 12:54 PM · Restricted Project

Mar 9 2021

zequanwu committed rG8d5c3ae357b5: Revert "[llvm-cov] reset executation count to 0 after wrapped segment" (authored by zequanwu).
Revert "[llvm-cov] reset executation count to 0 after wrapped segment"
Mar 9 2021, 2:48 PM
zequanwu added a reverting change for D85036: [llvm-cov] reset executation count to 0 after wrapped segment: rG8d5c3ae357b5: Revert "[llvm-cov] reset executation count to 0 after wrapped segment".
Mar 9 2021, 2:48 PM · Restricted Project
zequanwu closed D98084: Revert "[llvm-cov] reset executation count to 0 after wrapped segment".
Mar 9 2021, 2:48 PM · Restricted Project
zequanwu requested review of D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant..
Mar 9 2021, 2:44 PM · Restricted Project, Restricted Project

Mar 5 2021

zequanwu updated the diff for D98084: Revert "[llvm-cov] reset executation count to 0 after wrapped segment".

Update test.

Mar 5 2021, 3:27 PM · Restricted Project
zequanwu requested review of D98084: Revert "[llvm-cov] reset executation count to 0 after wrapped segment".
Mar 5 2021, 3:26 PM · Restricted Project
zequanwu added a reverting change for D85036: [llvm-cov] reset executation count to 0 after wrapped segment: D98084: Revert "[llvm-cov] reset executation count to 0 after wrapped segment".
Mar 5 2021, 3:26 PM · Restricted Project