I think this fix is simple and straightforward and resolved the problem mentioned on GH. However, please wait for #clang-language-wg member's comments.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 6 2023
May 6 2023
Mar 23 2023
Mar 23 2023
inclyc added a comment to D143720: [InstCombine] extend "simplifyUsingControlFlow" supporting zext/sext/trunc for different sizes.
ping :)
Mar 14 2023
Mar 14 2023
inclyc added a comment to D143720: [InstCombine] extend "simplifyUsingControlFlow" supporting zext/sext/trunc for different sizes.
ping :)
Mar 7 2023
Mar 7 2023
Feb 26 2023
Feb 26 2023
inclyc added a comment to D143720: [InstCombine] extend "simplifyUsingControlFlow" supporting zext/sext/trunc for different sizes.
ping :) @nikic can you please review this revision to make sure it is what you want in https://github.com/llvm/llvm-project/issues/54561#issuecomment-1079460876 ?
Feb 17 2023
Feb 17 2023
Feb 13 2023
Feb 13 2023
inclyc added inline comments to D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension.
inclyc added inline comments to D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension.
Feb 10 2023
Feb 10 2023
inclyc updated the diff for D143720: [InstCombine] extend "simplifyUsingControlFlow" supporting zext/sext/trunc for different sizes.
- Update comments
inclyc committed rG68adc028b42d: [InstCombine][NFC] regenerate tests for simple_phi_condition.ll (authored by inclyc).
[InstCombine][NFC] regenerate tests for simple_phi_condition.ll
drop irrelevent changes
Feb 9 2023
Feb 9 2023
inclyc committed rGf9e2fb9d8e59: [InstCombine] combine intersection for inequality icmps (authored by inclyc).
[InstCombine] combine intersection for inequality icmps
[InstCombine] precommit tests for D140666
Feb 8 2023
Feb 8 2023
Feb 5 2023
Feb 5 2023
Feb 1 2023
Feb 1 2023
- vector tests
- add splat vector tests
Jan 31 2023
Jan 31 2023
But we may need some more negative tests. At least one more for
Address comments form @bcl5980
Jan 29 2023
Jan 29 2023
I don't think BMask_Mixed and BMask_NotMixed will happen at the same time.
Jan 25 2023
Jan 25 2023
add test masked_and_expected_false
1
- use "ConstT" instead of creating new instruction
Jan 24 2023
Jan 24 2023
unmerge instcombine
Can we merge the code into here? It looks the logic is almost the same.
Jan 22 2023
Jan 22 2023
In D140666#4069648, @spatel wrote:In D140666#4065425, @inclyc wrote:Looks like the test LLVM.Transforms/InstCombine::sign-test-and-or.ll is failed due to recent changes on this patch. I'd like to inspect it first. :)
Those diffs are miscompiles if I'm seeing it correctly, so something is not right with this patch.
Jan 19 2023
Jan 19 2023
Looks like the test LLVM.Transforms/InstCombine::sign-test-and-or.ll is failed due to recent changes on this patch. I'd like to inspect it first. :)
Address comments
inclyc committed rG9ef43ad7bfff: [InstCombine] regenerete icmp-logical tests (NFC) (authored by inclyc).
[InstCombine] regenerete icmp-logical tests (NFC)
Jan 16 2023
Jan 16 2023
On Mon, Jan 16, 2023 Roman Lebedev <lebedev.ri@gmail.com> wrote:
inclyc added a reverting change for rGe327b52766ed: [C2x] reject type definitions in offsetof: rG596f76a799c9: Revert "[C2x] reject type definitions in offsetof".
inclyc committed rG596f76a799c9: Revert "[C2x] reject type definitions in offsetof" (authored by inclyc).
Revert "[C2x] reject type definitions in offsetof"
inclyc added a reverting change for D133574: [C2x] reject type definitions in offsetof: rG596f76a799c9: Revert "[C2x] reject type definitions in offsetof".
Jan 12 2023
Jan 12 2023
[C2x] reject type definitions in offsetof
inclyc committed rG6c09a4e5ba2e: [RISCV][VP] expand vp intrinsics if no +zve32x feature (authored by inclyc).
[RISCV][VP] expand vp intrinsics if no +zve32x feature
inclyc retitled D139706: [RISCV][VP] expand vp intrinsics if no +zve32x feature from [RISCV][VP] expand vp intrinsics if no +v feature to [RISCV][VP] expand vp intrinsics if no +zve32x feature.
ping :)
ping :)
ping :)
Jan 3 2023
Jan 3 2023
We should write proof with variables(not constant like 3, 15 in current alive2 link) also.
Jan 1 2023
Jan 1 2023
ping :)
ping :)
Dec 26 2022
Dec 26 2022
Handle (icmp ne (A & B), B) & (icmp eq (A & D), D), B & D having a single bit set
Assume that (B & D) & (C ^ E) == 0, and (B & D) == D || (B & D) == B,
transforms:
Dec 25 2022
Dec 25 2022
Dec 21 2022
Dec 21 2022
Re-generate llc assertions
inclyc committed rG84733b0f179e: [JT] check xor operand is exactly the same in processBranchOnXOR (authored by inclyc).
[JT] check xor operand is exactly the same in processBranchOnXOR
inclyc added a comment to D139783: [JT] check xor operand is exactly the same in processBranchOnXOR.
ping :)
Dec 20 2022
Dec 20 2022
Can you use vp.load and vp.store instead of using scalable vector arguments and returns?
Dec 16 2022
Dec 16 2022
rebase
inclyc committed rG0359c19e8f14: [RISCV][VP] support vp.reduce.mul by ExpandVectorPredication (authored by inclyc).
[RISCV][VP] support vp.reduce.mul by ExpandVectorPredication
Dec 13 2022
Dec 13 2022
Hi @aaron.ballman! seems we are failing tests on recent change 2fc5a3410087c209567c7e4a2c457b6896c127a3
rebase
Hoist tests to fixed-vectors-reduction-int-vp.ll.
In D139721#3992238, @craig.topper wrote:Does this work for scalable vectors?
In D139706#3987299, @craig.topper wrote:Can we test scalable vectors too?
Dec 10 2022
Dec 10 2022
inclyc added a reviewer for D139783: [JT] check xor operand is exactly the same in processBranchOnXOR: nikic.
inclyc requested review of D139783: [JT] check xor operand is exactly the same in processBranchOnXOR.
Dec 9 2022
Dec 9 2022
hasVInstructions()
inclyc retitled D139706: [RISCV][VP] expand vp intrinsics if no +zve32x feature from [RISCV][VP] expand vp instrinscs if no +v feature to [RISCV][VP] expand vp intrinscs if no +v feature.
Dec 7 2022
Dec 7 2022
ping :)
Nov 24 2022
Nov 24 2022
Nov 22 2022
Nov 22 2022
We may need a release note here so users know about the new changes to -Wvla. See clang/docs/ReleaseNotes.rst!
inclyc committed rG2ec79afd8993: [Sema] check InitListExpr format strings like {"foo"} (authored by inclyc).
[Sema] check InitListExpr format strings like {"foo"}
Address comments
- add a test to coverage warnings if appropriate
Do we need release notes here? This patch is just an improvement to https://reviews.llvm.org/D130906
Nov 18 2022
Nov 18 2022
inclyc committed rG96484553d96e: [docs] remove extra slash from llvm github url (authored by sloorush).
[docs] remove extra slash from llvm github url
In D137418#3913963, @sloorush wrote:@tstellar I do not have merge access, could you please commit on my behalf?
Aarush Bhat <aarush.bhatt@gmail.com>
This is my name and email address in the required format.
Nov 17 2022
Nov 17 2022
ping :)
inclyc committed rG7a715bf317d0: [VP] Add support for vp.inttoptr & vp.ptrtoint (authored by inclyc).
[VP] Add support for vp.inttoptr & vp.ptrtoint
drop extra whitespace in comments
Address comments
ping :)