Page MenuHomePhabricator
Feed Advanced Search

Sep 12 2020

bcain added a comment to D84896: [MC] Fix memory leak when allocating MCInst with bump allocator.

Tending to push this rel. small fix w/o an explicit Hexagon sign-off. Objections?

Sep 12 2020, 6:39 PM · Restricted Project

Aug 19 2020

bcain added a comment to D82702: [libc++] Use a proper CMake target to represent libc++ headers.

I'm troubleshooting a build failure that happens when this commit lands on a downstream builder. The symptom looks similar to the one reported by @aeubanks where the includes aren't present but I've ruled out the EXPERIMENTAL_LIBRARY (explicitly set OFF in the failing build).

Aug 19 2020, 8:25 AM · Restricted Project

Jul 20 2020

bcain updated the diff for D83990: [test-release] fallback to py3's venv module.
Jul 20 2020, 9:12 AM · Restricted Project

Jul 17 2020

bcain updated the diff for D83990: [test-release] fallback to py3's venv module.
Jul 17 2020, 8:30 AM · Restricted Project
bcain added inline comments to D83990: [test-release] fallback to py3's venv module.
Jul 17 2020, 7:28 AM · Restricted Project

Jul 16 2020

bcain added reviewers for D83990: [test-release] fallback to py3's venv module: rovka, dim, ro.
Jul 16 2020, 3:07 PM · Restricted Project
bcain abandoned D68741: test-release.sh s/http/https/.
Jul 16 2020, 3:06 PM · Restricted Project
bcain updated the diff for D83990: [test-release] fallback to py3's venv module.

updated diff w/context

Jul 16 2020, 3:05 PM · Restricted Project
bcain added a comment to D83990: [test-release] fallback to py3's venv module.

I created this to make it easier to run builds on systems that have python3 but don't have virtualenv installed. python3 comes with venv.

Jul 16 2020, 3:04 PM · Restricted Project
bcain created D83990: [test-release] fallback to py3's venv module.
Jul 16 2020, 3:02 PM · Restricted Project

Jun 30 2020

bcain accepted D82263: [Hexagon] Cleanup compiler-rt.builtins remove code that belongs in the c-library.

These tests all seem to fail with

clang-11: error: invalid linker name in argument '-fuse-ld=lld'

AFAICT these tests are all using x86_64 and shouldn't be in scope for this change.

Jun 30 2020, 10:49 AM · Restricted Project
bcain added a comment to D82263: [Hexagon] Cleanup compiler-rt.builtins remove code that belongs in the c-library.

These tests all seem to fail with

Jun 30 2020, 7:35 AM · Restricted Project

Jun 24 2020

bcain planned changes to D61130: [llvm-mc] Add reportWarning() to MCContext.
Jun 24 2020, 7:31 AM · Restricted Project, Restricted Project

Jun 3 2020

bcain closed D75085: Fix unused-variable warning.
Jun 3 2020, 8:12 AM · Restricted Project
bcain closed D74239: [Hexagon] v67+ HVX register pairs should support either direction.
Jun 3 2020, 8:12 AM · Restricted Project
bcain closed D69614: Fix pattern error for S2_tstbit_i instruction.
Jun 3 2020, 8:12 AM · Restricted Project
bcain closed D76958: [test-suite] Add support for Hexagon.
Jun 3 2020, 8:12 AM
bcain closed D79006: [Hexagon] Handle cases for subregisters..
Jun 3 2020, 8:12 AM · Restricted Project
bcain closed D77879: [ELF][Hexagon] Add duplex to R_HEX_GOT_16_X.
Jun 3 2020, 8:12 AM · Restricted Project
bcain closed D80073: [Hexagon] pX.new cannot be used with p3:0 as producer.
Jun 3 2020, 8:12 AM · Restricted Project
bcain added a comment to D81044: [llvm] Add build bots for ml-driven optimization policies..

Where can I learn more about the model itself and how it gets feedback? Does this mostly impact target dependent or target independent optimizations? (Sorry for hijacking the review)

Jun 3 2020, 7:38 AM

May 16 2020

bcain created D80073: [Hexagon] pX.new cannot be used with p3:0 as producer.
May 16 2020, 7:37 PM · Restricted Project

Apr 30 2020

bcain updated the diff for D79006: [Hexagon] Handle cases for subregisters..

simplified test case

Apr 30 2020, 10:08 AM · Restricted Project

Apr 28 2020

bcain updated the diff for D79006: [Hexagon] Handle cases for subregisters..

add -march=hexagon to test case

Apr 28 2020, 8:01 AM · Restricted Project
bcain created D79006: [Hexagon] Handle cases for subregisters..
Apr 28 2020, 8:01 AM · Restricted Project

Apr 27 2020

bcain added a comment to D77213: Handle part-word LL/SC in atomic expansion pass.

The main changes are:

  • Changed the PartwordMaskValue member functions to static non-members.
  • Added LL/SC expansion of partword RMW.

Applied clang-format.

Apr 27 2020, 3:07 PM · Restricted Project

Apr 25 2020

bcain added a comment to D77213: Handle part-word LL/SC in atomic expansion pass.

If I apply this patch I am still able to encounter this unreachable during a build. I can share repro details.

Apr 25 2020, 6:35 PM · Restricted Project
bcain added a comment to D77213: Handle part-word LL/SC in atomic expansion pass.

If I apply this patch I am still able to encounter this unreachable during a build. I can share repro details.

Apr 25 2020, 10:36 AM · Restricted Project

Apr 21 2020

bcain added inline comments to D77919: [MC][ELF] Add section flags to diagnostic.
Apr 21 2020, 8:04 AM · Restricted Project

Apr 20 2020

bcain accepted D78364: [MC][Bugfix] Remove redundant parameter for relaxInstruction.

LGTM. Tested with Hexagon.

Apr 20 2020, 6:28 PM · Restricted Project
bcain added a comment to D77919: [MC][ELF] Add section flags to diagnostic.

PIng.

Apr 20 2020, 6:28 PM · Restricted Project

Apr 16 2020

bcain updated the diff for D77919: [MC][ELF] Add section flags to diagnostic.

Fixed the expressions in getSectionFlagString() - strings instead of chars, the nulls were the wrong choice.

Apr 16 2020, 7:29 PM · Restricted Project

Apr 15 2020

bcain added a comment to D77213: Handle part-word LL/SC in atomic expansion pass.

Removed the phi optimization, updated tests to reflect the leftover phis.

Apr 15 2020, 8:44 AM · Restricted Project

Apr 13 2020

bcain added inline comments to D77919: [MC][ELF] Add section flags to diagnostic.
Apr 13 2020, 10:14 PM · Restricted Project
bcain updated the diff for D77919: [MC][ELF] Add section flags to diagnostic.

fix indentation in getSectionFlagString per git-clang-format

Apr 13 2020, 10:14 PM · Restricted Project
bcain updated the diff for D77919: [MC][ELF] Add section flags to diagnostic.

Added a getSectionFlagString() function.
Changed section name delimiters in diagnostic to single-quotes

Apr 13 2020, 10:14 PM · Restricted Project
bcain updated the diff for D77879: [ELF][Hexagon] Add duplex to R_HEX_GOT_16_X.

Fixed per review comments: removed superfluous parens around return expression, changed 0x0 to just 0.

Apr 13 2020, 5:31 PM · Restricted Project

Apr 10 2020

bcain added inline comments to D77919: [MC][ELF] Add section flags to diagnostic.
Apr 10 2020, 5:47 PM · Restricted Project
bcain created D77919: [MC][ELF] Add section flags to diagnostic.
Apr 10 2020, 4:09 PM · Restricted Project
bcain created D77879: [ELF][Hexagon] Add duplex to R_HEX_GOT_16_X.
Apr 10 2020, 8:53 AM · Restricted Project
bcain updated the diff for D77359: [libunwind] add hexagon support.

removed obsolete/commented-out getIP() implementation

Apr 10 2020, 2:40 AM · Restricted Project, Restricted Project

Apr 9 2020

bcain added inline comments to D77359: [libunwind] add hexagon support.
Apr 9 2020, 4:53 PM · Restricted Project, Restricted Project
bcain updated the diff for D77359: [libunwind] add hexagon support.

Fix WEAK_ALIAS() definition for hexagon

Apr 9 2020, 4:35 PM · Restricted Project, Restricted Project
bcain added inline comments to D77359: [libunwind] add hexagon support.
Apr 9 2020, 1:32 PM · Restricted Project, Restricted Project
bcain updated the diff for D77359: [libunwind] add hexagon support.
  • Corrected WEAK_ALIAS definition for hexagon
  • Removed .size directive from UnwindRegistersRestore.S
Apr 9 2020, 1:25 PM · Restricted Project, Restricted Project
bcain added inline comments to D77359: [libunwind] add hexagon support.
Apr 9 2020, 7:34 AM · Restricted Project, Restricted Project
bcain added inline comments to D77674: [WebAssembly][MC] Use StringRef over std::string pointer.
Apr 9 2020, 7:01 AM · Restricted Project

Apr 8 2020

bcain added a comment to D77359: [libunwind] add hexagon support.
  • Remove encoding == DW_EH_PE_omit guard from getEncodedP()
  • Remove hexagon changes from findFDE()
  • Fix hexagon unw_getcontext definition, declaration in UnwindRegistersSave.S
Apr 8 2020, 10:40 PM · Restricted Project, Restricted Project
bcain updated the diff for D77359: [libunwind] add hexagon support.
  • Remove encoding == DW_EH_PE_omit guard from getEncodedP()
  • Remove hexagon changes from findFDE()
  • Fix hexagon unw_getcontext definition, declaration in UnwindRegistersSave.S
Apr 8 2020, 10:40 PM · Restricted Project, Restricted Project
bcain accepted D77684: [Hexagon] Remove testcases that check for default linker..

LGTM

Apr 8 2020, 11:57 AM · Restricted Project
bcain added a reviewer for D76958: [test-suite] Add support for Hexagon: sidneym.
Apr 8 2020, 8:39 AM

Apr 7 2020

bcain added a comment to D77498: [Hexagon] Select lld as the default linker for linux-musl target.

Since this isn't something that can be always known in advance I think the testcase should just be removed.

Apr 7 2020, 3:49 PM · Restricted Project
bcain added a comment to D77498: [Hexagon] Select lld as the default linker for linux-musl target.

This does not take into account CLANG_DEFAULT_LINKER, resulting in a check-clang failure:

Apr 7 2020, 2:43 PM · Restricted Project
bcain accepted D77440: [Hexagon] Update include paths for linux/musl.
Apr 7 2020, 11:23 AM · Restricted Project
bcain added a comment to D77440: [Hexagon] Update include paths for linux/musl.

LGTM

Apr 7 2020, 7:01 AM · Restricted Project

Apr 6 2020

bcain added a reviewer for D77359: [libunwind] add hexagon support: sidneym.
Apr 6 2020, 2:10 PM · Restricted Project, Restricted Project
bcain added inline comments to D77359: [libunwind] add hexagon support.
Apr 6 2020, 2:10 PM · Restricted Project, Restricted Project
bcain added a comment to D76958: [test-suite] Add support for Hexagon.

Any general review disposition for the latest patch w/only changes to MultiSource/Benchmarks/CMakeLists.txt and cmake/modules/DetectArchitecture.c?

Any thoughts on the remainder of the current state of the patch? Anything that should prevent me from merging this as-is?

@lebedev.ri @luismarques

Apr 6 2020, 9:44 AM

Apr 2 2020

bcain created D77359: [libunwind] add hexagon support.
Apr 2 2020, 8:04 PM · Restricted Project, Restricted Project
bcain added a comment to D76958: [test-suite] Add support for Hexagon.

Any general review disposition for the latest patch w/only changes to MultiSource/Benchmarks/CMakeLists.txt and cmake/modules/DetectArchitecture.c?

Apr 2 2020, 7:00 PM
bcain added a comment to D76958: [test-suite] Add support for Hexagon.

Any general review disposition for the latest patch w/only changes to MultiSource/Benchmarks/CMakeLists.txt and cmake/modules/DetectArchitecture.c?

Apr 2 2020, 7:01 AM

Apr 1 2020

bcain updated the diff for D76958: [test-suite] Add support for Hexagon.

Omitted out-of-scope change to benchmark's cycleclock.h

Apr 1 2020, 9:46 PM
bcain reclaimed D76958: [test-suite] Add support for Hexagon.
Apr 1 2020, 9:46 PM
bcain added inline comments to D76958: [test-suite] Add support for Hexagon.
Apr 1 2020, 8:27 AM
bcain abandoned D76958: [test-suite] Add support for Hexagon.
Apr 1 2020, 8:27 AM

Mar 31 2020

bcain added reviewers for D76958: [test-suite] Add support for Hexagon: lebedev.ri, lenary.

This is my first change to the test-suite, let me know if I'm doing this right. :)

Mar 31 2020, 9:27 PM
bcain updated the diff for D76958: [test-suite] Add support for Hexagon.

Accidentally omitted context lines w/previous patch

Mar 31 2020, 9:27 PM

Mar 30 2020

bcain added a comment to D77098: Restrict test to x86-only.

What problem does this patch solve? llvm-readobj does not depend on lib/Target/* and should not need REQUIRES: x86-registered-target

Mar 30 2020, 4:57 PM · Restricted Project
bcain abandoned D77098: Restrict test to x86-only.
Mar 30 2020, 4:57 PM · Restricted Project
bcain created D77098: Restrict test to x86-only.
Mar 30 2020, 3:16 PM · Restricted Project

Mar 27 2020

bcain created D76958: [test-suite] Add support for Hexagon.
Mar 27 2020, 4:00 PM

Mar 26 2020

bcain accepted D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set..

LGTM

Mar 26 2020, 7:33 AM · Restricted Project

Mar 25 2020

bcain added a comment to D75638: [Hexagon] Support for Linux/Musl ABI..

@kparzysz do you have any thoughts about those review comments?

Mar 25 2020, 12:27 PM · Restricted Project

Mar 24 2020

bcain added a comment to D76582: [Hexagon] Don't clear libpath when target is linux-musl.

Seems like we might want a new test case for this?

Mar 24 2020, 8:34 AM · Restricted Project

Mar 23 2020

bcain added a comment to D76632: [libc++] Do not use futex if LIBCXX_HAS_MUSL_LIBC is ON.

The build actually fails because of "#include <linux/futex.h>". Musl does not have this header file and the build fails with a missing header file error.

Mar 23 2020, 2:43 PM · Restricted Project

Mar 18 2020

bcain added a comment to D76310: [Hexagon] Add linux #defines when linux triple is selected.

LGTM

Mar 18 2020, 10:20 AM · Restricted Project

Mar 13 2020

bcain added a comment to D76156: Initialize IsFast* values.

This change seemed inocent enough. Were the false values here the right defaults?

Mar 13 2020, 4:13 PM · Restricted Project
bcain added a reviewer for D76156: Initialize IsFast* values: kparzysz.
Mar 13 2020, 2:01 PM · Restricted Project
bcain created D76156: Initialize IsFast* values.
Mar 13 2020, 1:29 PM · Restricted Project

Mar 12 2020

bcain added a comment to D74443: [lld][Hexagon] convert call x@GDPLT to call __tls_get_addr.
Mar 12 2020, 6:20 PM · Restricted Project
bcain added inline comments to D76079: [Hexagon] Enable init_arrays when target is linux-musl.
Mar 12 2020, 11:23 AM · Restricted Project

Mar 11 2020

bcain added a comment to D75638: [Hexagon] Support for Linux/Musl ABI..

@kparzysz do you have any thoughts about those review comments?

Mar 11 2020, 11:21 AM · Restricted Project

Mar 9 2020

bcain added a comment to D75638: [Hexagon] Support for Linux/Musl ABI..

In general, I recommend qualifying metric and threshold values with their associated units: bits, bytes, pages, etc. That way it's easy to see where the unit conversions are happening and easy to see whether the logic is correct without reasoning about how the value changes among lines.

Mar 9 2020, 12:58 PM · Restricted Project

Mar 6 2020

bcain resigned from D53327: [Hexagon] Use -fuse-ld update checks..
Mar 6 2020, 8:13 AM · Restricted Project

Mar 5 2020

bcain added a comment to D74443: [lld][Hexagon] convert call x@GDPLT to call __tls_get_addr.

Ping @MaskRay and @sidneym -- anything left barring commit?

Mar 5 2020, 3:22 PM · Restricted Project

Feb 27 2020

bcain added a reviewer for D75085: Fix unused-variable warning: sidneym.
Feb 27 2020, 8:09 AM · Restricted Project
bcain accepted D75139: [hexagon] Pickup the default crt and libs when the musl target is selected.

LGTM

Feb 27 2020, 8:05 AM · Restricted Project

Feb 25 2020

bcain added a comment to D75085: Fix unused-variable warning.

I believe this test failure is unrelated to the change in question and brought it up on llvm-dev/libcxx-dev.

Feb 25 2020, 11:15 AM · Restricted Project
bcain added a reviewer for D75085: Fix unused-variable warning: kparzysz.
Feb 25 2020, 11:15 AM · Restricted Project
bcain added a comment to D74443: [lld][Hexagon] convert call x@GDPLT to call __tls_get_addr.

@MaskRay and @sidneym -- is this change ready to go or are there outstanding review items?

Feb 25 2020, 7:48 AM · Restricted Project

Feb 24 2020

bcain created D75085: Fix unused-variable warning.
Feb 24 2020, 2:57 PM · Restricted Project
bcain added inline comments to D74368: [TBLGEN] Fix subreg value overflow in DAGISelMatcher.
Feb 24 2020, 7:35 AM · Restricted Project

Feb 18 2020

bcain accepted D74776: [Hexagon] clang driver should consider --sysroot option when looking for includes.

LGTM

Feb 18 2020, 10:16 AM · Restricted Project

Feb 14 2020

bcain committed rGbf3b86bc2f10: [Hexagon] v67+ HVX register pairs should support either direction (authored by bcain).
[Hexagon] v67+ HVX register pairs should support either direction
Feb 14 2020, 10:49 AM
bcain updated the diff for D74239: [Hexagon] v67+ HVX register pairs should support either direction.

Add ## for the comments in the new test cases.

Feb 14 2020, 10:03 AM · Restricted Project

Feb 13 2020

bcain added a comment to D74239: [Hexagon] v67+ HVX register pairs should support either direction.

Ping - any questions/suggestions about this patch?

Feb 13 2020, 3:27 PM · Restricted Project
bcain added a comment to D74443: [lld][Hexagon] convert call x@GDPLT to call __tls_get_addr.

LGTM 👍

Feb 13 2020, 2:51 PM · Restricted Project
bcain added a reviewer for D74239: [Hexagon] v67+ HVX register pairs should support either direction: sidneym.
Feb 13 2020, 2:42 PM · Restricted Project

Feb 11 2020

bcain added inline comments to D74260: Change default relocation model for hexagon when triple includes musl.
Feb 11 2020, 7:41 AM · Restricted Project

Feb 7 2020

bcain updated the diff for D74239: [Hexagon] v67+ HVX register pairs should support either direction.

ran git-clang-format

Feb 7 2020, 11:03 AM · Restricted Project