This is committed by now, but I would still love to know if this would have been ok to just commit (and have post-commit review) :)
Sep 12 2021
Sep 11 2021
I guess this would have qualified for post-commit review, but since this would have been my first commit I made myself, I want to be careful ^^
Comments on this would be nice, if this would have been ok to just commit.
Jul 23 2021
@sbc100 thank you for committing this :)
Jul 22 2021
Thank you for looking at it again and approving it, @sbc100 :)
Jul 21 2021
hey @sbc100, do you have time to look at this again? Would be great to have this upstreamed :)
Jul 3 2021
Jun 28 2021
Removed the symlink to readobj since it's not required and might be confusing
llvm-readobj is llvm specific, but readelf is not and llvm-readobj is llvm's implementation of readelf (hence the already existing symlink to it)
Jun 27 2021
Got three buildbot failure mails with only me in the blamelist (thats a first), but they don't look like they are related to the change, but rather the build server having killed the compiler?
Jun 26 2021
Thanks for your review :)
Jun 25 2021
Change reviewer to author of file - might be the better option than code_owners
Apr 22 2021
Apr 11 2021
Removed the unnecessary check as requested.
Removed an unnecessary check as requested in review
Apr 7 2021
Adding @chandlerc as a reviewer since first entry in CODE_OWNERS for CMake ^^'
formatting was bad and somehow differential didn't show the endif() - added a trailing newline for that
Sep 14 2020
Is this review still relevant? If not, let's abandon it to clear up the review queue.
May 13 2020
We could lift the two macros that depend on _NEWLIB_VERSION into the headers that use them.
Then we'll avoid the include in config.
I am slightly concerned that this also introduces a bunch of declarations in __config, which is the most included file of the library. That would also be the first time we include unistd.h in the libc++ headers (as opposed to the sources used to build the dylib). That might not be an issue, but it's something to keep in mind.
Another way would be to include _newlib_version.h if it exists, would that be better? Would then be a newlib specific patch.
Since this include was deleted as "dead code" before, I added a comment why it is not dead
May 12 2020
May 7 2020
Cannot commit myself
May 4 2020
Also fix duplicated check in filesystem/operations.cpp
Do not include unistd.h on _WIN32, re-add __APPLE__ check and change _POSIX_TIMER check to check for > 0
Included unistd.h and removed the check for __APPLE__, since _POSIX_TIMERS should work there, too
LGTM generally speaking, but is this triggered by a specific failure you ran into? If so, on what configuration? We should have a way to test this change.