Page MenuHomePhabricator
Feed Advanced Search

Apr 11 2019

xingxue accepted D60551: [tests] Add host-byteorder-*-endian; update XFAILs of big-endian triples.

LGTM.

Apr 11 2019, 5:47 AM · Restricted Project

Apr 3 2019

xingxue accepted D60175: [Support] On AIX, Check ENOTSUP on posix_fallocate instead of EOPNOTSUPP.

LGTM.

Apr 3 2019, 5:53 AM · Restricted Project
xingxue accepted D60164: [AIX] SelectionDAGNodes.h: Pack bit-fields that are meant to be packed.

LGTM.

Apr 3 2019, 5:50 AM · Restricted Project

Mar 27 2019

xingxue accepted D59741: [lit] Set shlibpath_var on AIX.

LGTM. Thanks!

Mar 27 2019, 12:56 PM · Restricted Project

Mar 15 2019

xingxue accepted D58801: [Support] Implement is_local_impl with AIX mntctl.

LGTM. Thanks!

Mar 15 2019, 8:51 AM · Restricted Project
xingxue accepted D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library.

LGTM. Thanks!

Mar 15 2019, 8:41 AM · Restricted Project
xingxue updated the diff for D59228: Fix typos in compiler-rt/lib/builtins/atomic.c.

Address review comments:

  • Added a case for 1 byte to macro LOCK_FREE_CASES.
Mar 15 2019, 8:12 AM · Restricted Project, Restricted Project

Mar 13 2019

xingxue added inline comments to D59228: Fix typos in compiler-rt/lib/builtins/atomic.c.
Mar 13 2019, 12:19 PM · Restricted Project, Restricted Project

Mar 12 2019

xingxue created D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined.
Mar 12 2019, 7:12 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2019

xingxue created D59228: Fix typos in compiler-rt/lib/builtins/atomic.c.
Mar 11 2019, 12:50 PM · Restricted Project, Restricted Project
xingxue updated the diff for D58250: [AIX][CMake] Changes for building on AIX with XL and GCC.

Address review comments:

  • Check __GNUC__ for GCC instead of __GNU__ and exclude CLANG which also sets macro __GNUC__.
Mar 11 2019, 10:42 AM · Restricted Project

Mar 1 2019

xingxue updated the diff for D58250: [AIX][CMake] Changes for building on AIX with XL and GCC.

Address review comments:

  • Replaced 'STREQUAL "XL"' with 'MATCHES "XL"'.
Mar 1 2019, 3:17 PM · Restricted Project
xingxue accepted D58798: Use AIX version detection at LLVM run-time.

LGTM, thanks.

Mar 1 2019, 9:56 AM · Restricted Project

Feb 26 2019

xingxue updated the diff for D58250: [AIX][CMake] Changes for building on AIX with XL and GCC.

Address review comments:

Feb 26 2019, 2:13 PM · Restricted Project

Feb 14 2019

xingxue created D58250: [AIX][CMake] Changes for building on AIX with XL and GCC.
Feb 14 2019, 1:14 PM · Restricted Project