Page MenuHomePhabricator
Feed Advanced Search

Apr 15 2020

xingxue committed rG4578fa8a1cc3: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals (authored by xingxue).
[demangler] PPC and S390: Fix parsing of e-prefixed long double literals
Apr 15 2020, 7:07 AM
xingxue closed D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.
Apr 15 2020, 7:07 AM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2020

xingxue updated the diff for D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

Addressed comments:

  • Added a comment as suggested.
Apr 13 2020, 2:41 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.
Apr 13 2020, 12:25 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

Addressed comments:

  • Leave the existing handling of type code g unchanged as suggested.
Apr 13 2020, 12:25 PM · Restricted Project, Restricted Project, Restricted Project

Feb 25 2020

xingxue abandoned D75060: [test][go]Use -stdlib=libc++ to build GO binding test if LLVM is built with libc++.

Revision no longer needed now that the GO binding test code has been reverted. Thanks!

Feb 25 2020, 10:37 AM · Restricted Project
xingxue updated the diff for D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

Addressed comments:

Feb 25 2020, 8:44 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added a comment to D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

I'm still wondering about Intel. Can there ever be a literal encoded using 'g' on Intel? If yes, then treating it as "long double" would still be wrong, because 'g' encodes IEEE128 (__float128), while "long double" is the Intel extended (80-bit) format, right?

On the other hand, if 'g' encoded literals can never happen on Intel (or other platforms), maybe it would be better to have the code handling 'g' within a #ifdef section only active on powerpc and s390?

For X86, 'e' is used for 80-bit long double and 'g' is used for 128-bit long double. The following is the code in Clang.

clang/lib/Basic/Targets/X86.h
....
const char *getLongDoubleMangling() const override {
  return LongDoubleFormat == &llvm::APFloat::IEEEquad() ? "g" : "e";
}
...

But then this patch must be incorrect, given that it does

return getDerived().template parseFloatingLiteral<long double>();

for both the 'e' and 'g' cases on Intel. Now I guess it depends on how the file is compiled (with -mlong-double-80 or -mlong-double-128), but either way, one of the cases will be handled incorrectly.

Feb 25 2020, 8:26 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added a comment to D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

I'm still wondering about Intel. Can there ever be a literal encoded using 'g' on Intel? If yes, then treating it as "long double" would still be wrong, because 'g' encodes IEEE128 (__float128), while "long double" is the Intel extended (80-bit) format, right?

On the other hand, if 'g' encoded literals can never happen on Intel (or other platforms), maybe it would be better to have the code handling 'g' within a #ifdef section only active on powerpc and s390?

For X86, 'e' is used for 80-bit long double and 'g' is used for 128-bit long double. The following is the code in Clang.

clang/lib/Basic/Targets/X86.h
....
const char *getLongDoubleMangling() const override {
  return LongDoubleFormat == &llvm::APFloat::IEEEquad() ? "g" : "e";
}
...
Feb 25 2020, 7:42 AM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2020

xingxue added a comment to D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

Hi @uweigand, Thanks for your comments. Please see my explanations below.

Feb 24 2020, 2:20 PM · Restricted Project, Restricted Project, Restricted Project
xingxue created D75060: [test][go]Use -stdlib=libc++ to build GO binding test if LLVM is built with libc++.
Feb 24 2020, 9:08 AM · Restricted Project

Feb 21 2020

xingxue added a comment to D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

@uweigand, Hi, I've addressed your comments. Any further comments?

Feb 21 2020, 1:16 PM · Restricted Project, Restricted Project, Restricted Project

Feb 13 2020

xingxue accepted D72736: [AIX] Add improved interface for retrieving load module paths.

LGTM.

Feb 13 2020, 1:01 PM · Restricted Project, Restricted Project

Feb 7 2020

xingxue updated the diff for D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

Addressed comments:

Feb 7 2020, 10:44 AM · Restricted Project, Restricted Project, Restricted Project

Feb 6 2020

xingxue created D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.
Feb 6 2020, 1:38 PM · Restricted Project, Restricted Project, Restricted Project

Nov 20 2019

xingxue committed rG5665fc91fe93: [AIX][XCOFF] Add support for generating assembly code for one-byte mergable… (authored by xingxue).
[AIX][XCOFF] Add support for generating assembly code for one-byte mergable…
Nov 20 2019, 8:34 AM
xingxue closed D70310: [AIX][XCOFF] Add support for generating assembly code for one-byte mergable strings.
Nov 20 2019, 8:34 AM · Restricted Project

Nov 15 2019

xingxue created D70310: [AIX][XCOFF] Add support for generating assembly code for one-byte mergable strings.
Nov 15 2019, 6:58 AM · Restricted Project

Nov 8 2019

xingxue added a comment to D69528: [PowerPC][XCOFF] Add assembly support for zero initalized global values..

Test file aix-xcoff-data.ll needs a rebase.

Nov 8 2019, 9:12 AM · Restricted Project

Oct 28 2019

xingxue added inline comments to D67125: [PowerPC][AIX] Adds support for writing the data section in object files.
Oct 28 2019, 9:52 AM · Restricted Project
xingxue accepted D69447: [NFCI][XCOFF][AIX] Skip empty Section during object file generation.

LGTM.

Oct 28 2019, 7:12 AM · Restricted Project

Oct 25 2019

xingxue updated the diff for D67125: [PowerPC][AIX] Adds support for writing the data section in object files.

Revised based on changes in patch https://reviews.llvm.org/D69112.

Oct 25 2019, 8:52 AM · Restricted Project

Oct 2 2019

xingxue updated the diff for D67125: [PowerPC][AIX] Adds support for writing the data section in object files.

Addressed comments:

  • Changed variable name CSection -> Csect;
  • Added the checking of section headers in the object file.
Oct 2 2019, 2:29 AM · Restricted Project

Sep 30 2019

xingxue added inline comments to D67125: [PowerPC][AIX] Adds support for writing the data section in object files.
Sep 30 2019, 9:56 AM · Restricted Project

Sep 20 2019

xingxue added inline comments to D66969: Output XCOFF object text section header and symbol entry for program code.
Sep 20 2019, 1:56 PM · Restricted Project

Sep 11 2019

xingxue updated the diff for D67125: [PowerPC][AIX] Adds support for writing the data section in object files.

Changed from Data to Data.Index.

Sep 11 2019, 2:02 PM · Restricted Project

Sep 9 2019

xingxue added inline comments to D67125: [PowerPC][AIX] Adds support for writing the data section in object files.
Sep 9 2019, 2:14 PM · Restricted Project
xingxue updated the diff for D67125: [PowerPC][AIX] Adds support for writing the data section in object files.

Addressed comments:

  • use csects in comment.
  • use section storage class from CSection.
  • set the section start address as the address after the previous section.
Sep 9 2019, 2:13 PM · Restricted Project

Sep 3 2019

xingxue created D67125: [PowerPC][AIX] Adds support for writing the data section in object files.
Sep 3 2019, 12:58 PM · Restricted Project

Aug 30 2019

xingxue committed rL370539: Request commit access for xingxue.
Request commit access for xingxue
Aug 30 2019, 3:22 PM

Aug 27 2019

xingxue added inline comments to D66724: [AIX]Emit function descriptor csect in assembly.
Aug 27 2019, 5:59 AM · Restricted Project

Aug 26 2019

xingxue added a comment to D66724: [AIX]Emit function descriptor csect in assembly.

This patch needs a rebase.

Aug 26 2019, 4:05 AM · Restricted Project

Aug 25 2019

xingxue updated the diff for D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.

Merged with the master and fixed a typo.

Aug 25 2019, 8:44 AM · Restricted Project
xingxue committed rGef039a3ccdcd: [PowerPC][AIX] Adds support for writing the .data section in assembly files (authored by xingxue).
[PowerPC][AIX] Adds support for writing the .data section in assembly files
Aug 25 2019, 8:17 AM
xingxue committed rL369869: [PowerPC][AIX] Adds support for writing the .data section in assembly files.
[PowerPC][AIX] Adds support for writing the .data section in assembly files
Aug 25 2019, 8:17 AM
xingxue closed D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.
Aug 25 2019, 8:17 AM · Restricted Project

Aug 22 2019

xingxue updated the diff for D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.

Addressed comments:

Aug 22 2019, 6:29 PM · Restricted Project
xingxue added inline comments to D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.
Aug 22 2019, 12:31 PM · Restricted Project
xingxue updated the diff for D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.

Addressed comments:

Aug 22 2019, 12:31 PM · Restricted Project

Aug 21 2019

xingxue updated the diff for D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.
Aug 21 2019, 8:02 AM · Restricted Project

Aug 19 2019

xingxue added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Aug 19 2019, 8:03 AM · Restricted Project

Aug 15 2019

xingxue accepted D66256: [AIX] For XL, pick GCC-compatible std & default warning options.

LGTM.

Aug 15 2019, 6:04 AM · Restricted Project

Aug 13 2019

xingxue added a reviewer for D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files: Xiangling_L.
Aug 13 2019, 10:42 AM · Restricted Project
xingxue created D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.
Aug 13 2019, 10:42 AM · Restricted Project

Aug 12 2019

xingxue accepted D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

LGTM.

Aug 12 2019, 12:28 PM · Restricted Project

Jun 26 2019

xingxue committed rG600941e34fed: Print NULL as "(null)" in diagnostic message (authored by xingxue).
Print NULL as "(null)" in diagnostic message
Jun 26 2019, 12:29 PM
xingxue committed rL364462: Print NULL as "(null)" in diagnostic message.
Print NULL as "(null)" in diagnostic message
Jun 26 2019, 12:27 PM
xingxue closed D63786: Print NULL as "(null)" in diagnostic message.
Jun 26 2019, 12:27 PM · Restricted Project, Restricted Project

Jun 25 2019

xingxue committed rL364322: Improve zero-size allocation with safe_malloc, etc..
Improve zero-size allocation with safe_malloc, etc.
Jun 25 2019, 8:21 AM
xingxue committed rGece53d0ae50a: Improve zero-size allocation with safe_malloc, etc. (authored by xingxue).
Improve zero-size allocation with safe_malloc, etc.
Jun 25 2019, 8:15 AM
xingxue closed D63668: [Support] Improve zero-size allocation with safe_malloc, etc..
Jun 25 2019, 8:15 AM · Restricted Project

Jun 24 2019

xingxue accepted D63668: [Support] Improve zero-size allocation with safe_malloc, etc..

LGTM.

Jun 24 2019, 9:53 AM · Restricted Project
xingxue added a comment to D63668: [Support] Improve zero-size allocation with safe_malloc, etc..

malloc(0) can be used to allocate a zero-sized object. To avoid having a null pointer to the zero-sized object, implementations often change to allocate 1 byte instead. So this patch makes sense to me.

Jun 24 2019, 8:02 AM · Restricted Project

Jun 20 2019

xingxue committed rGab4bcd844ab9: AIX system headers need stdint.h and inttypes.h to be re-enterable (authored by xingxue).
AIX system headers need stdint.h and inttypes.h to be re-enterable
Jun 20 2019, 8:34 AM
xingxue committed rL363939: AIX system headers need stdint.h and inttypes.h to be re-enterable.
AIX system headers need stdint.h and inttypes.h to be re-enterable
Jun 20 2019, 8:33 AM
xingxue closed D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined.
Jun 20 2019, 8:33 AM · Restricted Project, Restricted Project, Restricted Project

Jun 19 2019

xingxue closed D62384: [libcxx][tests]Skip checking midpoint of adjacent values for PPC double-double.

Thanks to Marshall for committing the patch. Closing this revision.

Jun 19 2019, 6:46 AM · Restricted Project

Jun 11 2019

xingxue added a comment to D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined.

Hi @mclow.lists, Do you have any further comments?

Jun 11 2019, 6:40 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added a comment to D62384: [libcxx][tests]Skip checking midpoint of adjacent values for PPC double-double.

Hi @mclow.lists, Do you have any further comments?

Jun 11 2019, 6:37 AM · Restricted Project

Jun 10 2019

xingxue accepted D63041: [PlistSupport] Produce a newline to end plist output files.

LGTM.

Jun 10 2019, 10:21 AM · Restricted Project, Restricted Project

Jun 6 2019

xingxue added a comment to D62384: [libcxx][tests]Skip checking midpoint of adjacent values for PPC double-double.

Thanks Marshall and Hubert for your comments!

Jun 6 2019, 8:41 AM · Restricted Project
xingxue updated the diff for D62384: [libcxx][tests]Skip checking midpoint of adjacent values for PPC double-double.

Addressed comments:

  • Skip the test of midpoint of adjacent values for PPC double-double based on compile-time checking;
  • Use #if defined(__PPC__) instead of #if __PPC__ ;
  • Removed output to std::cerr.
Jun 6 2019, 8:30 AM · Restricted Project

Jun 3 2019

xingxue added inline comments to D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined.
Jun 3 2019, 9:10 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined.

Addressed comments:

  • Fixed typo _XOPEN_SOUECE->_XOPEN_SOURCE
Jun 3 2019, 9:10 AM · Restricted Project, Restricted Project, Restricted Project

May 28 2019

xingxue added inline comments to D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined.
May 28 2019, 1:39 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined.

Updated comments explaining the scenario of the changes.

May 28 2019, 1:02 PM · Restricted Project, Restricted Project, Restricted Project

May 27 2019

xingxue committed rG3860aad6e7f0: [MustExecute] Improve MustExecute to correctly handle loop nest (authored by xingxue).
[MustExecute] Improve MustExecute to correctly handle loop nest
May 27 2019, 6:55 AM
xingxue committed rL361762: [MustExecute] Improve MustExecute to correctly handle loop nest.
[MustExecute] Improve MustExecute to correctly handle loop nest
May 27 2019, 6:54 AM
xingxue closed D62418: [MustExecute] Improve MustExecute to correctly handle loop nest.
May 27 2019, 6:54 AM · Restricted Project

May 24 2019

xingxue created D62384: [libcxx][tests]Skip checking midpoint of adjacent values for PPC double-double.
May 24 2019, 6:09 AM · Restricted Project

May 23 2019

xingxue updated the diff for D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined.

Added test case stdint_h.sh.cpp.

May 23 2019, 7:13 AM · Restricted Project, Restricted Project, Restricted Project

May 22 2019

xingxue committed rG4246b7529579: Disable EHFrameSupport in JITLink/RuntimeDyld on AIX (authored by xingxue).
Disable EHFrameSupport in JITLink/RuntimeDyld on AIX
May 22 2019, 10:44 AM
xingxue committed rL361410: Disable EHFrameSupport in JITLink/RuntimeDyld on AIX.
Disable EHFrameSupport in JITLink/RuntimeDyld on AIX
May 22 2019, 10:39 AM
xingxue closed D62203: Disable EHFrameSupport in JITLink/RuntimeDyld on AIX .
May 22 2019, 10:39 AM · Restricted Project
xingxue accepted D62203: Disable EHFrameSupport in JITLink/RuntimeDyld on AIX .

LGTM.

May 22 2019, 6:51 AM · Restricted Project

May 16 2019

xingxue committed rG6dc363ecc13e: Add AIX Version Macros (authored by xingxue).
Add AIX Version Macros
May 16 2019, 7:21 AM
xingxue committed rC360900: Add AIX Version Macros.
Add AIX Version Macros
May 16 2019, 7:20 AM
xingxue committed rL360900: Add AIX Version Macros.
Add AIX Version Macros
May 16 2019, 7:20 AM
xingxue closed D61530: Add AIX Version Macros.
May 16 2019, 7:20 AM · Restricted Project
xingxue committed rG2dee094a08ff: Fixes for builds that require strict X/Open and POSIX compatiblity (authored by xingxue).
Fixes for builds that require strict X/Open and POSIX compatiblity
May 16 2019, 7:03 AM
xingxue committed rL360898: Fixes for builds that require strict X/Open and POSIX compatiblity.
Fixes for builds that require strict X/Open and POSIX compatiblity
May 16 2019, 6:59 AM
xingxue closed D61326: Fixes for builds that require strict X/Open and POSIX compatiblity.
May 16 2019, 6:59 AM · Restricted Project
xingxue committed rGaf8cda15deca: [tests][go]Add -stdlib=libc++ to build GO test if LLVM is built with libc++ (authored by xingxue).
[tests][go]Add -stdlib=libc++ to build GO test if LLVM is built with libc++
May 16 2019, 6:31 AM
xingxue committed rL360895: [tests][go]Add -stdlib=libc++ to build GO test if LLVM is built with libc++.
[tests][go]Add -stdlib=libc++ to build GO test if LLVM is built with libc++
May 16 2019, 6:30 AM
xingxue closed D61900: [tests][go]Add -stdlib=libc++ to build GO test if LLVM is built with libc++.
May 16 2019, 6:30 AM · Restricted Project

May 14 2019

xingxue added inline comments to D61900: [tests][go]Add -stdlib=libc++ to build GO test if LLVM is built with libc++.
May 14 2019, 1:54 PM · Restricted Project
xingxue updated the diff for D61900: [tests][go]Add -stdlib=libc++ to build GO test if LLVM is built with libc++.
May 14 2019, 1:51 PM · Restricted Project
xingxue created D61900: [tests][go]Add -stdlib=libc++ to build GO test if LLVM is built with libc++.
May 14 2019, 8:00 AM · Restricted Project
xingxue committed rGfe4f6d53c6e8: [lit][tests]Add feature libcxx-used and use it in llvm-*-fuzzer tests (authored by xingxue).
[lit][tests]Add feature libcxx-used and use it in llvm-*-fuzzer tests
May 14 2019, 6:53 AM
xingxue committed rL360672: [lit][tests]Add feature libcxx-used and use it in llvm-*-fuzzer tests.
[lit][tests]Add feature libcxx-used and use it in llvm-*-fuzzer tests
May 14 2019, 6:52 AM
xingxue closed D61265: [lit][tests]Add feature libcxx-used and use it in llvm-*-fuzzer tests.
May 14 2019, 6:52 AM · Restricted Project

May 6 2019

xingxue committed rCRT360060: Add libc++ to link XRay test cases if libc++ is used to build CLANG.
Add libc++ to link XRay test cases if libc++ is used to build CLANG
May 6 2019, 10:49 AM
xingxue committed rG865a39d328c2: Add libc++ to link XRay test cases if libc++ is used to build CLANG (authored by xingxue).
Add libc++ to link XRay test cases if libc++ is used to build CLANG
May 6 2019, 10:43 AM
xingxue committed rL360060: Add libc++ to link XRay test cases if libc++ is used to build CLANG.
Add libc++ to link XRay test cases if libc++ is used to build CLANG
May 6 2019, 10:43 AM
xingxue closed D61016: [lit][tests]Add libc++ to link XRay test cases if libc++ is used to build CLANG.
May 6 2019, 10:43 AM · Restricted Project

Apr 29 2019

xingxue created D61265: [lit][tests]Add feature libcxx-used and use it in llvm-*-fuzzer tests.
Apr 29 2019, 8:40 AM · Restricted Project

Apr 26 2019

xingxue added a comment to D61016: [lit][tests]Add libc++ to link XRay test cases if libc++ is used to build CLANG.

@hubert.reinterpretcast, @dberris, thanks for the review! I will commit once I get the permission.

Apr 26 2019, 11:49 AM · Restricted Project

Apr 23 2019

xingxue added a reviewer for D61016: [lit][tests]Add libc++ to link XRay test cases if libc++ is used to build CLANG: amyk.
Apr 23 2019, 9:53 AM · Restricted Project
xingxue created D61016: [lit][tests]Add libc++ to link XRay test cases if libc++ is used to build CLANG.
Apr 23 2019, 6:54 AM · Restricted Project

Apr 11 2019

xingxue accepted D60553: [lit][tests][AIX] Update expected form of diagnostic messages; use `not` to normalize non-zero exit values.

LGTM.

Apr 11 2019, 5:47 AM · Restricted Project