Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Feb 25 2023

Backl1ght added a comment to D141614: [libc++] nth_element change to partial sort when range is really small.

This is the benchmark result for BM_NthElement_string* after I changed length of each string to 8192.

Feb 25 2023, 8:38 PM · Restricted Project, Restricted Project
Backl1ght added a comment to D141614: [libc++] nth_element change to partial sort when range is really small.

This is the benchmark result.

Feb 25 2023, 10:28 AM · Restricted Project, Restricted Project
Backl1ght added inline comments to D141614: [libc++] nth_element change to partial sort when range is really small.
Feb 25 2023, 3:46 AM · Restricted Project, Restricted Project
Backl1ght updated the diff for D141614: [libc++] nth_element change to partial sort when range is really small.
Feb 25 2023, 3:46 AM · Restricted Project, Restricted Project

Feb 20 2023

Backl1ght updated the diff for D141614: [libc++] nth_element change to partial sort when range is really small.
Feb 20 2023, 9:50 AM · Restricted Project, Restricted Project

Feb 6 2023

Backl1ght committed rGc24cdd58a144: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine (authored by Backl1ght).
[clang-format] PackConstructorInitializers support PCIS_OnlyNextLine
Feb 6 2023, 4:06 AM · Restricted Project, Restricted Project
Backl1ght closed D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly.
Feb 6 2023, 4:05 AM · Restricted Project, Restricted Project, Restricted Project

Feb 5 2023

Backl1ght updated the diff for D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly.

fix typo and add release note

Feb 5 2023, 5:58 AM · Restricted Project, Restricted Project, Restricted Project

Feb 4 2023

Backl1ght retitled D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly from [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine to [clang-format] PackConstructorInitializers support PCIS_NextLineOnly.
Feb 4 2023, 6:49 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght updated the diff for D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly.

add more unittest

Feb 4 2023, 6:49 AM · Restricted Project, Restricted Project, Restricted Project

Feb 3 2023

Backl1ght added inline comments to D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly.
Feb 3 2023, 11:55 PM · Restricted Project, Restricted Project, Restricted Project

Feb 2 2023

Backl1ght added a comment to D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly.
In D143091#4097534, @HazardyKnusperkeks wrote:

An entry in the changelog would be nice.

Feb 2 2023, 6:15 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght updated the diff for D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly.

adapt suggestion

Feb 2 2023, 6:12 AM · Restricted Project, Restricted Project, Restricted Project

Feb 1 2023

Backl1ght retitled D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly from https://github.com/llvm/llvm-project/issues/60241 to [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine.
Feb 1 2023, 9:57 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght requested review of D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly.
Feb 1 2023, 9:57 AM · Restricted Project, Restricted Project, Restricted Project

Jan 29 2023

Backl1ght added a comment to D141614: [libc++] nth_element change to partial sort when range is really small.

ping?

Jan 29 2023, 7:10 AM · Restricted Project, Restricted Project

Jan 20 2023

Backl1ght added a reviewer for D141614: [libc++] nth_element change to partial sort when range is really small: Mordante.
Jan 20 2023, 7:01 AM · Restricted Project, Restricted Project
Backl1ght committed rG58751f943f2f: [clang-format] SortUsingDeclarations support lexicographic order (authored by Backl1ght).
[clang-format] SortUsingDeclarations support lexicographic order
Jan 20 2023, 5:47 AM · Restricted Project, Restricted Project
Backl1ght closed D141694: [clang-format] SortUsingDeclarations support lexicographic order.
Jan 20 2023, 5:46 AM · Restricted Project, Restricted Project, Restricted Project

Jan 17 2023

Backl1ght added a comment to D141694: [clang-format] SortUsingDeclarations support lexicographic order.

ping

Jan 17 2023, 4:20 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght added a comment to D141614: [libc++] nth_element change to partial sort when range is really small.

ping

Jan 17 2023, 4:20 AM · Restricted Project, Restricted Project

Jan 14 2023

Backl1ght updated the diff for D141614: [libc++] nth_element change to partial sort when range is really small.

fix build error by replace U+2212 with U+002d

Jan 14 2023, 7:34 AM · Restricted Project, Restricted Project
Backl1ght added a comment to D141614: [libc++] nth_element change to partial sort when range is really small.

It seems like the improvement is too small to make sense in benchmark. But from the output of code bellow we can tell that this reduce some calculations.

Jan 14 2023, 7:14 AM · Restricted Project, Restricted Project
Backl1ght updated the diff for D141614: [libc++] nth_element change to partial sort when range is really small.
Jan 14 2023, 6:27 AM · Restricted Project, Restricted Project
Backl1ght added a comment to D141614: [libc++] nth_element change to partial sort when range is really small.

For previous diff I just copy code of __selection_sort from sort.h and modify the terminate condition.

Jan 14 2023, 5:53 AM · Restricted Project, Restricted Project
Backl1ght updated the diff for D141614: [libc++] nth_element change to partial sort when range is really small.

refine code

Jan 14 2023, 5:42 AM · Restricted Project, Restricted Project

Jan 13 2023

Backl1ght updated the diff for D141694: [clang-format] SortUsingDeclarations support lexicographic order.
  1. Update example for SUD_Never
  2. Use capital letters for variables and arguments.
Jan 13 2023, 8:45 PM · Restricted Project, Restricted Project, Restricted Project
Backl1ght requested review of D141694: [clang-format] SortUsingDeclarations support lexicographic order.
Jan 13 2023, 7:38 AM · Restricted Project, Restricted Project, Restricted Project

Jan 12 2023

Backl1ght requested review of D141614: [libc++] nth_element change to partial sort when range is really small.
Jan 12 2023, 7:52 AM · Restricted Project, Restricted Project

Jan 9 2023

Backl1ght added inline comments to D141205: [libcxx] nth_element use introselect to avoid quadratic behavior.
Jan 9 2023, 5:21 AM · Restricted Project, Restricted Project

Jan 8 2023

Backl1ght added a comment to D141205: [libcxx] nth_element use introselect to avoid quadratic behavior.
In D141205#4033996, @philnik wrote:
In D141205#4033709, @Backl1ght wrote:

There are some other select algorithms outperform introselect, ie pdqselect, adqselect. But I think we could prevent quadratic behavior first, and then pursue extreme performance.

Do you plan to make a patch for one of them? If yes, it's probably easier to just go for it directly, since it's probably a re-implementation anyways?

Jan 8 2023, 3:09 AM · Restricted Project, Restricted Project

Jan 7 2023

Backl1ght updated the diff for D141205: [libcxx] nth_element use introselect to avoid quadratic behavior.

fix error: ADL lookup

Jan 7 2023, 8:28 PM · Restricted Project, Restricted Project
Backl1ght added a comment to D141205: [libcxx] nth_element use introselect to avoid quadratic behavior.

There are some other select algorithms outperform introselect, ie pdqselect, adqselect. But I think we could prevent quadratic behavior first, and then pursue extreme performance.

Jan 7 2023, 12:16 PM · Restricted Project, Restricted Project
Backl1ght added a comment to D141205: [libcxx] nth_element use introselect to avoid quadratic behavior.

Here is the benchmark result for this patch.

Jan 7 2023, 12:03 PM · Restricted Project, Restricted Project
Backl1ght requested review of D141205: [libcxx] nth_element use introselect to avoid quadratic behavior.
Jan 7 2023, 12:00 PM · Restricted Project, Restricted Project
Backl1ght committed rG1920c7947ab4: [libc++] remove weird empty line (authored by Backl1ght).
[libc++] remove weird empty line
Jan 7 2023, 2:22 AM · Restricted Project, Restricted Project
Backl1ght closed D141181: [libcxx] remove weird empty line.
Jan 7 2023, 2:22 AM · Restricted Project, Restricted Project

Jan 6 2023

Backl1ght requested review of D141181: [libcxx] remove weird empty line.
Jan 6 2023, 10:10 PM · Restricted Project, Restricted Project
Backl1ght committed rGb62906b0d10f: [clang-format] fix template closer followed by > (authored by Backl1ght).
[clang-format] fix template closer followed by >
Jan 6 2023, 6:53 AM · Restricted Project, Restricted Project
Backl1ght closed D140843: [clang-format] fix template closer followed by >.
Jan 6 2023, 6:53 AM · Restricted Project, Restricted Project, Restricted Project

Jan 4 2023

Backl1ght added inline comments to D140843: [clang-format] fix template closer followed by >.
Jan 4 2023, 5:45 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght updated the diff for D140843: [clang-format] fix template closer followed by >.
Jan 4 2023, 5:21 AM · Restricted Project, Restricted Project, Restricted Project

Jan 3 2023

Backl1ght added a comment to D140843: [clang-format] fix template closer followed by >.
In D140843#4022673, @MyDeveloperDay wrote:

I'm good with this but I'd be interesting in @owenpan and @HazardyKnusperkeks opinion.

Jan 3 2023, 4:22 AM · Restricted Project, Restricted Project, Restricted Project

Jan 2 2023

Backl1ght requested review of D140843: [clang-format] fix template closer followed by >.
Jan 2 2023, 7:23 AM · Restricted Project, Restricted Project, Restricted Project

Dec 16 2022

Backl1ght committed rG95c1a17433b9: [clang-format] add config parse test for short lambda (authored by Backl1ght).
[clang-format] add config parse test for short lambda
Dec 16 2022, 5:37 AM · Restricted Project, Restricted Project
Backl1ght closed D140105: [clang-format] add missing config parse test for short lambda.
Dec 16 2022, 5:37 AM · Restricted Project, Restricted Project, Restricted Project

Dec 15 2022

Backl1ght updated the summary of D140105: [clang-format] add missing config parse test for short lambda.
Dec 15 2022, 7:09 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght requested review of D140105: [clang-format] add missing config parse test for short lambda.
Dec 15 2022, 7:04 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght committed rG7b36538156b7: [clang-format] make doc for SLS_Inline more clearly (authored by Backl1ght).
[clang-format] make doc for SLS_Inline more clearly
Dec 15 2022, 5:09 AM · Restricted Project, Restricted Project
Backl1ght closed D139937: [clang-format] make doc for SLS_Inline more clearly.
Dec 15 2022, 5:09 AM · Restricted Project, Restricted Project, Restricted Project

Dec 14 2022

Backl1ght added a comment to D139937: [clang-format] make doc for SLS_Inline more clearly.
In D139937#3994044, @HazardyKnusperkeks wrote:
In D139937#3993641, @Backl1ght wrote:
In D139937#3992987, @HazardyKnusperkeks wrote:
In D139937#3992098, @Backl1ght wrote:

OMG! I just looked into git history and last edition of this line happened about 4 years ago. Am I doing it wrong?

Why? We have lambdas since C++11 so 11 years now.

Based on the git history, last edition of this line happened on a83e2db.

Let me rephrase it. Why should you think that you do it wrong?

Dec 14 2022, 4:44 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght added a comment to D139937: [clang-format] make doc for SLS_Inline more clearly.
In D139937#3994044, @HazardyKnusperkeks wrote:
In D139937#3993641, @Backl1ght wrote:
In D139937#3992987, @HazardyKnusperkeks wrote:
In D139937#3992098, @Backl1ght wrote:

OMG! I just looked into git history and last edition of this line happened about 4 years ago. Am I doing it wrong?

Why? We have lambdas since C++11 so 11 years now.

Based on the git history, last edition of this line happened on a83e2db.

Let me rephrase it. Why should you think that you do it wrong?

Dec 14 2022, 4:24 AM · Restricted Project, Restricted Project, Restricted Project

Dec 13 2022

Backl1ght added a comment to D139937: [clang-format] make doc for SLS_Inline more clearly.
In D139937#3992987, @HazardyKnusperkeks wrote:
In D139937#3992098, @Backl1ght wrote:

OMG! I just looked into git history and last edition of this line happened about 4 years ago. Am I doing it wrong?

Why? We have lambdas since C++11 so 11 years now.

Dec 13 2022, 5:19 PM · Restricted Project, Restricted Project, Restricted Project
Backl1ght updated the diff for D139937: [clang-format] make doc for SLS_Inline more clearly.
Dec 13 2022, 9:54 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght added a comment to D139937: [clang-format] make doc for SLS_Inline more clearly.

Seems like I have misunderstood it, after some test I'm sure that it means merge if its an argument of a function.

Dec 13 2022, 9:37 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght added a comment to D139937: [clang-format] make doc for SLS_Inline more clearly.

OMG! I just looked into git history and last edition of this line happened about 4 years ago. Am I doing it wrong?

Dec 13 2022, 8:16 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght requested review of D139937: [clang-format] make doc for SLS_Inline more clearly.
Dec 13 2022, 7:34 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght added inline comments to D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine.
Dec 13 2022, 7:06 AM · Restricted Project, Restricted Project, Restricted Project

Dec 12 2022

Backl1ght added a comment to D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine.

I just find out I miss one case like below

Dec 12 2022, 6:22 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght updated the summary of D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine.
Dec 12 2022, 6:11 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght requested review of D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine.
Dec 12 2022, 4:35 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght updated the diff for D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine.
Dec 12 2022, 3:51 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght updated the diff for D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine.
Dec 12 2022, 3:48 AM · Restricted Project, Restricted Project, Restricted Project

Dec 11 2022

Backl1ght updated the diff for D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine.
Dec 11 2022, 9:13 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght edited reviewers for D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine, added: MyDeveloperDay, owenpan; removed: • OwenCax.
Dec 11 2022, 8:02 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght updated the summary of D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine.
Dec 11 2022, 7:48 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght updated the summary of D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine.
Dec 11 2022, 7:45 AM · Restricted Project, Restricted Project, Restricted Project
Backl1ght requested review of D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine.
Dec 11 2022, 7:39 AM · Restricted Project, Restricted Project, Restricted Project