Page MenuHomePhabricator
Feed Advanced Search

Wed, Nov 30

psoni2628 committed rGe4e64eaade94: [MLIR][Transform] Consolidate the transform ops of get_parent_for and loop… (authored by kaitingwang).
[MLIR][Transform] Consolidate the transform ops of get_parent_for and loop…
Wed, Nov 30, 8:08 AM · Restricted Project, Restricted Project
psoni2628 closed D138980: [MLIR][Transform] Consolidate the transform ops of get_parent_for and loop unroll from affine and scf dialects..
Wed, Nov 30, 8:08 AM · Restricted Project, Restricted Project

Oct 20 2022

psoni2628 added a comment to D136217: [mlir][sparse] Fix breakage on older versions of cmake.

I am using CMake 3.18.0, so it's not extremely old.

After applying D136217, there is a different error message now, shown below.

-- LLVM host triple: x86_64-unknown-linux-gnu
-- LLVM default target triple: x86_64-unknown-linux-gnu
-- Building with -fPIC
-- Targeting X86
-- Clang version: 16.0.0
-- Not building amdgpu-arch: hsa-runtime64 not found
CMake Error at llvm-project/mlir/lib/Dialect/SparseTensor/IR/CMakeLists.txt:24 (set_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "CXX_STANDARD" is not allowed.

Maybe I should just upgrade my version of CMake. Which version of CMake are you using where it works?

I can't seem to find which version the phabricator buildbot is using, but locally I'm using 3.24.2. However, the LLVM project is supposed to work for any version >=3.13.4 (https://llvm.org/docs/GettingStarted.html#software), so it's definitely something I need to fix on our end.

I'm not sure which version changed things to allow setting the CXX_STANDARD property for INTERFACE libraries, so I'll just remove it for now and leave a comment about why. Can you try the new version of this differential?

Oct 20 2022, 7:14 AM · Restricted Project, Restricted Project

Oct 19 2022

psoni2628 added a comment to D136005: [mlir][sparse] Moving Enums.h into Dialect/SparseTensor/IR.

Hi @psoni2628,

I just posted D136217. Please comment there to let me know if it works for you.

Oct 19 2022, 7:30 AM · Restricted Project, Restricted Project

Oct 18 2022

psoni2628 added a comment to D136005: [mlir][sparse] Moving Enums.h into Dialect/SparseTensor/IR.

I am getting the following CMake error below.

Oct 18 2022, 3:32 PM · Restricted Project, Restricted Project
psoni2628 updated the diff for D135695: [OMPIRBuilder] Support depend clause for task construct.
  • Add doxygen comment for DependData struct
Oct 18 2022, 2:50 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 added inline comments to D135695: [OMPIRBuilder] Support depend clause for task construct.
Oct 18 2022, 8:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 updated the diff for D135695: [OMPIRBuilder] Support depend clause for task construct.
  • Set insertion point for DependInfo array alloca to the function entry block, then restore the original insertion point
Oct 18 2022, 8:28 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 14 2022

psoni2628 added inline comments to D135695: [OMPIRBuilder] Support depend clause for task construct.
Oct 14 2022, 9:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 added inline comments to D135695: [OMPIRBuilder] Support depend clause for task construct.
Oct 14 2022, 3:29 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 updated the diff for D135695: [OMPIRBuilder] Support depend clause for task construct.
  • Remove unnecessary llvm:: from OMPIRBuilder.cpp
  • Change the insertion point for DepArray alloca to be before the Then basic block for the if clause
  • Use only one enum RTLDependenceKindInfoTy to encode the kind of dependency; use this enum in Clang
Oct 14 2022, 3:29 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 13 2022

psoni2628 added inline comments to D135695: [OMPIRBuilder] Support depend clause for task construct.
Oct 13 2022, 8:16 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 12 2022

psoni2628 updated the diff for D135695: [OMPIRBuilder] Support depend clause for task construct.
  • Rebase, run clang-format
Oct 12 2022, 8:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 11 2022

psoni2628 updated the diff for D135695: [OMPIRBuilder] Support depend clause for task construct.
  • Use enum class instead of enum for OpenMPDependKind and OMPRTLDependenceKindTy
Oct 11 2022, 1:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 added inline comments to D135695: [OMPIRBuilder] Support depend clause for task construct.
Oct 11 2022, 10:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 requested review of D135695: [OMPIRBuilder] Support depend clause for task construct.
Oct 11 2022, 10:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 22 2022

psoni2628 added a comment to D134409: [utils][UpdateTestChecks] Add unnamed !noundef value support.

It looks like there was some issue with the Harbormaster build when you initially submitted this patch, but it seems to have been resolved since then. Can you rerun it?

Sep 22 2022, 6:23 PM · Restricted Project, Restricted Project

Aug 24 2022

psoni2628 committed rG457f1fe31af7: [Flang][OpenMP] Add support for safelen clause (authored by psoni2628).
[Flang][OpenMP] Add support for safelen clause
Aug 24 2022, 12:07 PM · Restricted Project, Restricted Project
psoni2628 closed D132574: [Flang][OpenMP] Add support for safelen clause.
Aug 24 2022, 12:06 PM · Restricted Project, Restricted Project
psoni2628 requested review of D132574: [Flang][OpenMP] Add support for safelen clause.
Aug 24 2022, 10:28 AM · Restricted Project, Restricted Project
psoni2628 committed rGb8055c511592: [MLIR][OpenMP] Add support for safelen clause (authored by psoni2628).
[MLIR][OpenMP] Add support for safelen clause
Aug 24 2022, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
psoni2628 closed D132245: [MLIR][OpenMP] Add support for safelen clause.
Aug 24 2022, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
psoni2628 added a reverting change for rG172fe1706d83: [MLIR][OpenMP] Add support for safelen clause: rG4fce38cde2fa: Revert "[MLIR][OpenMP] Add support for safelen clause".
Aug 24 2022, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
psoni2628 committed rG4fce38cde2fa: Revert "[MLIR][OpenMP] Add support for safelen clause" (authored by psoni2628).
Revert "[MLIR][OpenMP] Add support for safelen clause"
Aug 24 2022, 9:31 AM · Restricted Project, Restricted Project, Restricted Project
psoni2628 committed rG172fe1706d83: [MLIR][OpenMP] Add support for safelen clause (authored by psoni2628).
[MLIR][OpenMP] Add support for safelen clause
Aug 24 2022, 9:26 AM · Restricted Project, Restricted Project, Restricted Project
psoni2628 added a reverting change for rG3dd4d6a0cec8: Add support for safelen clause: rGcfef6561a782: Revert "Add support for safelen clause".
Aug 24 2022, 9:25 AM · Restricted Project, Restricted Project, Restricted Project
psoni2628 committed rGcfef6561a782: Revert "Add support for safelen clause" (authored by psoni2628).
Revert "Add support for safelen clause"
Aug 24 2022, 9:25 AM · Restricted Project, Restricted Project, Restricted Project
psoni2628 committed rG3dd4d6a0cec8: Add support for safelen clause (authored by psoni2628).
Add support for safelen clause
Aug 24 2022, 9:07 AM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2022

psoni2628 added a comment to D132245: [MLIR][OpenMP] Add support for safelen clause.

Can you split this in two patches? One for the flang side and one for the MLIR side.

Aug 19 2022, 1:44 PM · Restricted Project, Restricted Project, Restricted Project
psoni2628 updated the diff for D132245: [MLIR][OpenMP] Add support for safelen clause.
Aug 19 2022, 1:44 PM · Restricted Project, Restricted Project, Restricted Project
psoni2628 updated the diff for D132245: [MLIR][OpenMP] Add support for safelen clause.
  • Run clang-format
Aug 19 2022, 8:52 AM · Restricted Project, Restricted Project, Restricted Project
psoni2628 requested review of D132245: [MLIR][OpenMP] Add support for safelen clause.
Aug 19 2022, 8:49 AM · Restricted Project, Restricted Project, Restricted Project

Aug 18 2022

psoni2628 committed rGbce94ea551ae: [OMPIRBuilder] Add support for safelen clause (authored by psoni2628).
[OMPIRBuilder] Add support for safelen clause
Aug 18 2022, 12:44 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 closed D131526: [OMPIRBuilder] Add support for safelen clause.
Aug 18 2022, 12:44 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 updated the diff for D131526: [OMPIRBuilder] Add support for safelen clause.
  • Simplify expression based on reviewer comments
  • Rebase
Aug 18 2022, 11:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 14 2022

psoni2628 added inline comments to D131526: [OMPIRBuilder] Add support for safelen clause.
Aug 14 2022, 7:39 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 10 2022

psoni2628 updated the diff for D131526: [OMPIRBuilder] Add support for safelen clause.
  • Add LoopMDList
Aug 10 2022, 8:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 updated the diff for D131526: [OMPIRBuilder] Add support for safelen clause.
  • Add comments based on reviewer's feedback
  • Rebase
Aug 10 2022, 7:15 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 added inline comments to D131526: [OMPIRBuilder] Add support for safelen clause.
Aug 10 2022, 6:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 9 2022

psoni2628 added reviewers for D131526: [OMPIRBuilder] Add support for safelen clause: peixin, arnamoy10, domada, Meinersbur, kiranchandramohan, shraiysh, kiranktp.
Aug 9 2022, 3:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 requested review of D131526: [OMPIRBuilder] Add support for safelen clause.
Aug 9 2022, 2:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 28 2022

psoni2628 updated the summary of D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.
Jul 28 2022, 6:45 AM · Restricted Project, Restricted Project, Restricted Project

Jul 27 2022

psoni2628 added a comment to D130598: [Flang][Driver] Add support for AsmPrinter -mmlir options.
Jul 27 2022, 12:08 PM · Restricted Project, Restricted Project
psoni2628 updated the diff for D130598: [Flang][Driver] Add support for AsmPrinter -mmlir options.
  • Fix the previously added comment to make it more local
Jul 27 2022, 12:08 PM · Restricted Project, Restricted Project
psoni2628 added inline comments to D130598: [Flang][Driver] Add support for AsmPrinter -mmlir options.
Jul 27 2022, 11:51 AM · Restricted Project, Restricted Project
psoni2628 updated the diff for D130598: [Flang][Driver] Add support for AsmPrinter -mmlir options.
  • Add comment about which option comes from where
Jul 27 2022, 11:51 AM · Restricted Project, Restricted Project
psoni2628 added a comment to D130598: [Flang][Driver] Add support for AsmPrinter -mmlir options.

Thanks for doing this!

I think that at this point it would make sense to extend your test and to check for options from registerMLIRContextCLOptions and registerPassManagerCLOptions as well (one from each should be sufficient). Would you mind doing that? You'll need to rename the test file as well.

Jul 27 2022, 9:42 AM · Restricted Project, Restricted Project
psoni2628 updated the diff for D130598: [Flang][Driver] Add support for AsmPrinter -mmlir options.
  • Add registerPassManagerCLOptions and registerMLIRContextCLOptions options to the test
Jul 27 2022, 9:42 AM · Restricted Project, Restricted Project
psoni2628 added inline comments to D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.
Jul 27 2022, 8:49 AM · Restricted Project, Restricted Project, Restricted Project
psoni2628 added inline comments to D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.
Jul 27 2022, 7:49 AM · Restricted Project, Restricted Project, Restricted Project
psoni2628 updated the diff for D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.
  • Expand auto
  • Add expression Flang test case
  • Use IntegerAttr directly to avoid the need for a dyn_cast
  • Add mlir/test/Target/LLVMIR/openmp-llvm.mlir testcase
Jul 27 2022, 7:49 AM · Restricted Project, Restricted Project, Restricted Project

Jul 26 2022

psoni2628 added reviewers for D130598: [Flang][Driver] Add support for AsmPrinter -mmlir options: rovka, MatsPetersson.
Jul 26 2022, 2:13 PM · Restricted Project, Restricted Project
psoni2628 added a reviewer for D130598: [Flang][Driver] Add support for AsmPrinter -mmlir options: kiranchandramohan.
Jul 26 2022, 2:12 PM · Restricted Project, Restricted Project
psoni2628 updated the summary of D130598: [Flang][Driver] Add support for AsmPrinter -mmlir options.
Jul 26 2022, 2:12 PM · Restricted Project, Restricted Project
psoni2628 set the repository for D130598: [Flang][Driver] Add support for AsmPrinter -mmlir options to rG LLVM Github Monorepo.
Jul 26 2022, 2:12 PM · Restricted Project, Restricted Project
psoni2628 requested review of D130598: [Flang][Driver] Add support for AsmPrinter -mmlir options.
Jul 26 2022, 2:11 PM · Restricted Project, Restricted Project
psoni2628 updated the diff for D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.
  • Rebase so that the patch can be applied
Jul 26 2022, 12:06 PM · Restricted Project, Restricted Project, Restricted Project
psoni2628 updated the diff for D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.
  • Add invalid.mlir testcase
  • Add Flang test case with simdlen from a local parameter instead of a literal
Jul 26 2022, 9:11 AM · Restricted Project, Restricted Project, Restricted Project

Jul 20 2022

psoni2628 updated the diff for D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.
  • Use IntPositive to ensure that simdlen is a constant, positive integer
Jul 20 2022, 5:45 PM · Restricted Project, Restricted Project, Restricted Project
psoni2628 added a comment to D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.

Thanks for working on this patch. Can we add a verifier for
simdlen to error when the given value is negative? From the OpenMP standards "The parameter of the simdlen clause must be a constant positive integer expression."

Jul 20 2022, 2:17 PM · Restricted Project, Restricted Project, Restricted Project
psoni2628 requested review of D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.
Jul 20 2022, 12:13 PM · Restricted Project, Restricted Project, Restricted Project

Jul 11 2022

psoni2628 updated the diff for D129149: [OMPIRBuilder] Add support for simdlen clause.
  • Rebase, ensuring that build bot failures are gone
Jul 11 2022, 6:35 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 6 2022

psoni2628 updated the diff for D129149: [OMPIRBuilder] Add support for simdlen clause.
  • Remove applySimdlen and apply simdlen in applySimd
  • Remove unnecessary DebugLocation from applySimd in both OpenMPIRBuilder and Flang MLIR
  • Add llvm.access.group to llvm/utils/UpdateTestChecks/common.py
  • Fix test case by adding --check-globals
Jul 6 2022, 4:33 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 added inline comments to D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 6 2022, 11:06 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 updated the diff for D129149: [OMPIRBuilder] Add support for simdlen clause.
  • Autogenerate check lines for test case
  • Use isa instead of dyncast
  • Remove unused DebugLoc
  • Remove llvm:: from llvm::ConstantInt
Jul 6 2022, 11:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 added inline comments to D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 6 2022, 10:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 added inline comments to D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 6 2022, 8:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 added inline comments to D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 6 2022, 8:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 updated the diff for D129149: [OMPIRBuilder] Add support for simdlen clause.
  • Remove discouraged else after return
Jul 6 2022, 8:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 updated the summary of D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 6 2022, 8:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 updated the summary of D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 6 2022, 8:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 added a comment to D129149: [OMPIRBuilder] Add support for simdlen clause.

Nit: Also add to the summary that this patch uses the simdlen support in OpenMPIRBuilder when it is enabled in Clang.

Jul 6 2022, 8:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 added inline comments to D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 6 2022, 7:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 updated the diff for D129149: [OMPIRBuilder] Add support for simdlen clause.
  • Create new tests instead of modifying existing ones
  • Specialize isSupportedByOpenMPIRBuilder for OMPSimdDirective
Jul 6 2022, 6:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 added inline comments to D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 6 2022, 5:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 5 2022

psoni2628 added inline comments to D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 5 2022, 1:16 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 added inline comments to D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 5 2022, 1:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 added a reviewer for D129149: [OMPIRBuilder] Add support for simdlen clause: Dominik_A.
Jul 5 2022, 10:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 removed a project from D129149: [OMPIRBuilder] Add support for simdlen clause: Restricted Project.
Jul 5 2022, 9:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 removed a project from D129149: [OMPIRBuilder] Add support for simdlen clause: Restricted Project.
Jul 5 2022, 9:54 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 changed the repository for D129149: [OMPIRBuilder] Add support for simdlen clause from rC Clang to rG LLVM Github Monorepo.
Jul 5 2022, 9:52 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
psoni2628 requested review of D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 5 2022, 9:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project