Page MenuHomePhabricator
Feed Advanced Search

Jan 3 2021

MyDeveloperDay requested changes to D93938: [clang-format] Fixed AfterEnum handling.

I'm sorry, but now you are missing the files from the review, I think you diffing against your own commits and not commit that are in the repo. This makes the review very difficult to understand.

Jan 3 2021, 12:36 PM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 3 2021, 12:26 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93938: [clang-format] Fixed AfterEnum handling.

we don't commit with failing tests so lets understand why it fails.

Jan 3 2021, 12:20 PM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 3 2021, 9:30 AM · Restricted Project, Restricted Project
MyDeveloperDay added reviewers for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments: HazardyKnusperkeks, JakeMerdichAMD, klimek.
Jan 3 2021, 9:27 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

by and large, this looks pretty good to me..lets have some other comment

Jan 3 2021, 9:27 AM · Restricted Project, Restricted Project
MyDeveloperDay retitled D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments from [format] Add the possibility to align assignments spanning empty lines or comments to [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 3 2021, 9:22 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D93938: [clang-format] Fixed AfterEnum handling.
Jan 3 2021, 6:39 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93938: [clang-format] Fixed AfterEnum handling.

You need to have these conversations by adding new unit tests that prove your point, I highly doubt I'll personally be willing to accept any revision without more unit tests than this one line change

Jan 3 2021, 6:34 AM · Restricted Project, Restricted Project

Jan 2 2021

MyDeveloperDay added a comment to D93938: [clang-format] Fixed AfterEnum handling.

I think we are missing some clarity in this bug as to what the actual problem is, I do agree the test looks wrong,

Jan 2 2021, 3:09 AM · Restricted Project, Restricted Project

Jan 1 2021

MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Jan 1 2021, 10:15 AM · Restricted Project, Restricted Project

Dec 31 2020

MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Dec 31 2020, 7:11 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.

ok so this looks ok, but before we commit can we have a discussion about why you think it fails for the comment case?

Dec 31 2020, 7:05 AM · Restricted Project, Restricted Project
MyDeveloperDay requested changes to D93938: [clang-format] Fixed AfterEnum handling.
Dec 31 2020, 7:04 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93938: [clang-format] Fixed AfterEnum handling.

Take the following example:

Dec 31 2020, 7:04 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93938: [clang-format] Fixed AfterEnum handling.

I think if you think you have a bug that you log it in the bug tracker and we track it with this issue.

Dec 31 2020, 6:56 AM · Restricted Project, Restricted Project

Dec 30 2020

MyDeveloperDay updated the diff for D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates.

Address review comments

Dec 30 2020, 2:50 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Dec 30 2020, 2:34 AM · Restricted Project, Restricted Project

Dec 29 2020

MyDeveloperDay added a comment to rGc5c487f0d4c6: Revert "[clang-format] Add option to specify explicit config file" There were a….

@mitchell-stellar do you plan to bring this back?

Dec 29 2020, 2:50 PM
MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Dec 29 2020, 3:45 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93844: [clang-format] Add possibility to be based on parent directory.

I like what you are suggesting, do you think BasedOnStyle: File is the best terminology as the term File is used elsewhere to mean read from the .clang_format file, how about

Dec 29 2020, 3:42 AM · Restricted Project, Restricted Project

Dec 28 2020

MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Dec 28 2020, 9:25 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates.
Dec 28 2020, 7:29 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Dec 28 2020, 7:28 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates.

Addressing additional usecase found issues in C# tests too

Dec 28 2020, 6:44 AM · Restricted Project, Restricted Project

Dec 27 2020

MyDeveloperDay added a comment to D93844: [clang-format] Add possibility to be based on parent directory.

I'm a little confused why this is needed as clang-format always read up the directory tree until it see a .clang-format file, perhaps I don't quite understand the use case. Can't you just have a different .clang-format in the subdirectory?

Dec 27 2020, 2:21 PM · Restricted Project, Restricted Project
MyDeveloperDay retitled D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier from Add flag to suppress empty line insertion before access modifier to [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Dec 27 2020, 2:19 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.

Thank you for this patch, a few process issues.

Dec 27 2020, 2:17 PM · Restricted Project, Restricted Project
MyDeveloperDay added a reviewer for D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates: JohelEGP.
Dec 27 2020, 7:29 AM · Restricted Project, Restricted Project
MyDeveloperDay requested review of D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates.
Dec 27 2020, 7:29 AM · Restricted Project, Restricted Project

Dec 26 2020

MyDeveloperDay committed rGc7dcc4c72588: [clang-format] PR48569 clang-format fails to align case label with `switch`… (authored by MyDeveloperDay).
[clang-format] PR48569 clang-format fails to align case label with `switch`…
Dec 26 2020, 7:19 AM
MyDeveloperDay closed D93806: [clang-format] PR48569 clang-format fails to align case label with `switch` with Whitesmith Indentation.
Dec 26 2020, 7:19 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93806: [clang-format] PR48569 clang-format fails to align case label with `switch` with Whitesmith Indentation.

This is the closest I could find thus far http://bitsavers.informatik.uni-stuttgart.de/pdf/chromatics/CGC_7900_C_Programmers_Manual_Mar82.pdf

Dec 26 2020, 4:13 AM · Restricted Project, Restricted Project

Dec 24 2020

MyDeveloperDay requested review of D93806: [clang-format] PR48569 clang-format fails to align case label with `switch` with Whitesmith Indentation.
Dec 24 2020, 8:41 AM · Restricted Project, Restricted Project

Dec 23 2020

MyDeveloperDay accepted D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle.
Dec 23 2020, 9:50 AM · Restricted Project
MyDeveloperDay added a comment to D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle.

I don't have any major issues with this other than it makes Format.h a bit more ugly. (there are more ugly and harder to understand pieces of code than this change!)

Dec 23 2020, 8:07 AM · Restricted Project
MyDeveloperDay committed rG031743cb5b3c: [clang-format] PR48539 ReflowComments breaks Qt translation comments (authored by MyDeveloperDay).
[clang-format] PR48539 ReflowComments breaks Qt translation comments
Dec 23 2020, 6:46 AM
MyDeveloperDay committed rG5426b2f9ed9f: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style… (authored by MyDeveloperDay).
[clang-format] PR48535 clang-format Incorrectly Removes Space After C Style…
Dec 23 2020, 6:46 AM
MyDeveloperDay closed D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments.
Dec 23 2020, 6:45 AM · Restricted Project, Restricted Project
MyDeveloperDay closed D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer.
Dec 23 2020, 6:45 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle.

We should probably check the docs/tools/dump_format_style.py still works

Dec 23 2020, 6:02 AM · Restricted Project

Dec 22 2020

MyDeveloperDay accepted D93633: [format] Add overload to parseConfiguration that accept llvm::MemoryBufferRef.

LGTM

Dec 22 2020, 6:43 AM · Restricted Project
MyDeveloperDay added a comment to D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer.

LGTM now. I tried to find other cases where this change may change the behaviour but couldn't. Have you tried applying to some bigger repo and see what you get? The best would be a repo with SpaceAfterCStyleCast=true.

Dec 22 2020, 6:37 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rGc4fc8a21d1db: [clang-format] NFC keep the code clang-formatted (authored by MyDeveloperDay).
[clang-format] NFC keep the code clang-formatted
Dec 22 2020, 4:46 AM
MyDeveloperDay updated the diff for D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments.

remove = and ~ cases

Dec 22 2020, 4:44 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer.

remove unrelated change

Dec 22 2020, 4:36 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer.
Dec 22 2020, 4:35 AM · Restricted Project, Restricted Project

Dec 21 2020

MyDeveloperDay requested review of D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer.
Dec 21 2020, 3:48 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.
Dec 21 2020, 2:21 AM · Restricted Project, Restricted Project

Dec 19 2020

MyDeveloperDay accepted D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Thanks for making the changes, this LGTM

Dec 19 2020, 9:28 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D93240: [clang-format] Add SpaceBeforeCaseColon option.
Dec 19 2020, 6:03 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93528: [clang-format] Add basic support for formatting JSON.

With my maintainer-of-Support/JSON hat on, I don't like the idea of these features being shoehorned into the library to make clang-format an incrementally more featureful JSON formatter. They're likely to lead to a lot of conceptual+implementation+API complexity in a library that solves its primary use cases quite well and simply.

Dec 19 2020, 5:48 AM · Restricted Project, Restricted Project

Dec 18 2020

MyDeveloperDay added a comment to D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments.

Maybe @JVApen can help as they logged https://bugs.llvm.org/show_bug.cgi?id=48539

Dec 18 2020, 7:11 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93528: [clang-format] Add basic support for formatting JSON.

Why not using clang-format's support for JavaScript? It seems more complicated now, but it will probably allow to more easily change/add style options. WDYT?
And what happens when reformatting only a part of a JSON? Should there be some tests for that?

Dec 18 2020, 6:19 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the summary of D93528: [clang-format] Add basic support for formatting JSON.
Dec 18 2020, 3:34 AM · Restricted Project, Restricted Project
MyDeveloperDay requested review of D93528: [clang-format] Add basic support for formatting JSON.
Dec 18 2020, 2:32 AM · Restricted Project, Restricted Project

Dec 17 2020

MyDeveloperDay requested review of D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments.
Dec 17 2020, 1:20 PM · Restricted Project, Restricted Project
MyDeveloperDay accepted D93459: Fix -Wno-error= parsing in clang-format..

LGTM

Dec 17 2020, 12:19 PM · Restricted Project, Restricted Project
MyDeveloperDay committed rGdb41c0b357d5: [clang-format] PR35514 brace-init member initializers in function-try-blocks… (authored by MyDeveloperDay).
[clang-format] PR35514 brace-init member initializers in function-try-blocks…
Dec 17 2020, 1:40 AM
MyDeveloperDay closed D93296: [clang-format] PR35514 brace-init member initializers in function-try-blocks are not formatted correctly.
Dec 17 2020, 1:40 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D93296: [clang-format] PR35514 brace-init member initializers in function-try-blocks are not formatted correctly.

Add additional unit test

Dec 17 2020, 1:39 AM · Restricted Project, Restricted Project

Dec 16 2020

MyDeveloperDay added a comment to D93296: [clang-format] PR35514 brace-init member initializers in function-try-blocks are not formatted correctly.

I'd like to see a test with braces inside the try (intoducing scope), just to verify it doesn't break.

Dec 16 2020, 1:56 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93240: [clang-format] Add SpaceBeforeCaseColon option.

Nit: Please just separate your test from old test, apart from that I think its fine

Dec 16 2020, 12:46 AM · Restricted Project, Restricted Project

Dec 15 2020

MyDeveloperDay requested review of D93296: [clang-format] PR35514 brace-init member initializers in function-try-blocks are not formatted correctly.
Dec 15 2020, 6:31 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment.

I don't like seeing users having to use `// clang-format off```

Dec 15 2020, 4:19 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment.

not that rare it seems

Dec 15 2020, 4:18 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment.

Aside: Would you be prepared to take a look at D34225: [clang-format] Teach clang-format how to handle C++ coroutines which is pretty much been abandoned, and see if there is anything there that might help the co_routinues support?

Dec 15 2020, 3:34 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment.
Dec 15 2020, 3:31 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D93240: [clang-format] Add SpaceBeforeCaseColon option.
Dec 15 2020, 1:00 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93240: [clang-format] Add SpaceBeforeCaseColon option.

I generally don't have the same aversion to new options than others have, but can you point out a style guide that might want this option. (that is kind of the process)

Dec 15 2020, 12:57 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment.
Dec 15 2020, 12:55 AM · Restricted Project, Restricted Project

Dec 14 2020

MyDeveloperDay added inline comments to D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment.
Dec 14 2020, 7:33 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D92257: [clang-format] Add option to control the space at the front of a line comment.

This didn't really address the comments, what is the point of the maximum? what if the maximum is > the ColumnLimit?

Dec 14 2020, 7:29 AM · Restricted Project, Restricted Project

Dec 13 2020

MyDeveloperDay accepted D93170: [clang-format][NFC] Expand BreakBeforeBraces examples.

We should have the same examples added to the unit tests so we know they are correct (and stay correct)

Dec 13 2020, 4:46 AM · Restricted Project, Restricted Project

Dec 12 2020

MyDeveloperDay accepted D93163: [clang-format] Fix handling of ## comments in TextProto.
Dec 12 2020, 10:33 AM · Restricted Project, Restricted Project

Dec 10 2020

MyDeveloperDay committed rG95616a033c16: [clang-format] NFC Add release note for IndentPragmas (authored by MyDeveloperDay).
[clang-format] NFC Add release note for IndentPragmas
Dec 10 2020, 3:26 AM
MyDeveloperDay committed rGe9e6e3b34a8e: [clang-format] Add IndentPragma style to eliminate common clang-format off… (authored by MyDeveloperDay).
[clang-format] Add IndentPragma style to eliminate common clang-format off…
Dec 10 2020, 3:18 AM
MyDeveloperDay closed D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario.
Dec 10 2020, 3:18 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rG7b2d62fd7f7b: [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC… (authored by MyDeveloperDay).
[clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC…
Dec 10 2020, 3:14 AM
MyDeveloperDay closed D92922: [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC guess.
Dec 10 2020, 3:14 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rG254677e9ed4e: [clang-format] [NFC] Fix spelling and grammatical errors in IncludeBlocks text (authored by MyDeveloperDay).
[clang-format] [NFC] Fix spelling and grammatical errors in IncludeBlocks text
Dec 10 2020, 3:08 AM
MyDeveloperDay closed D92822: [clang-format] [NFC] Fix spelling and grammatical errors in IncludeBlocks text.
Dec 10 2020, 3:08 AM · Restricted Project, Restricted Project

Dec 9 2020

MyDeveloperDay updated the diff for D92922: [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC guess.

add support for additional _Pragma

Dec 9 2020, 7:12 AM · Restricted Project, Restricted Project
MyDeveloperDay requested review of D92922: [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC guess.
Dec 9 2020, 2:07 AM · Restricted Project, Restricted Project

Dec 8 2020

MyDeveloperDay added a comment to D92257: [clang-format] Add option to control the space at the front of a line comment.

And where do I do that? Also I did not think I would not have a chance of getting the access so early.

Dec 8 2020, 2:28 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario.
Dec 8 2020, 2:26 AM · Restricted Project, Restricted Project
MyDeveloperDay requested review of D92822: [clang-format] [NFC] Fix spelling and grammatical errors in IncludeBlocks text.
Dec 8 2020, 1:03 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario.
Dec 8 2020, 12:29 AM · Restricted Project, Restricted Project

Dec 7 2020

MyDeveloperDay requested changes to D92257: [clang-format] Add option to control the space at the front of a line comment.

Could we consider dropping the maximum?

Dec 7 2020, 11:17 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D92257: [clang-format] Add option to control the space at the front of a line comment.

Can I assume you need someone to land this for you?

Yes I do. But I have a question, my last change is commited in your name, that means git blame would blame it on you, right?

You can set me as author:
Björn Schäpers <bjoern@hazardy.de>
My Github Account is also called HazardyKnusperkeks.

The process is that you add (https://llvm.org/docs/Contributing.html)

Patch By: HazardyKnusperkeks

to the commit message if the user doesn't have commit access, if you want your name against the blame then I recommend applying for commit access yourself.

That is incorrect and does not represent the nowadays reality, i suggest that you look up the docs.

let me know if you still want me to land this

Dec 7 2020, 11:16 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484).

I'm a little confused between BestFit and Compact

Dec 7 2020, 10:56 AM · Restricted Project, Restricted Project
MyDeveloperDay retitled D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484) from Respond to review items and renew D14484 for merge possiblity to [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484).
Dec 7 2020, 10:47 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the summary of D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484).
Dec 7 2020, 10:46 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635).

@catskul I'm really sorry this disappeared into the ether because it was missing the project and any real reviewers, I tend to go back now and again and do a search for "Lost" clang format reviews and stumbled on this one, hopefully this will bring it to the fore if you are still interested

Dec 7 2020, 10:44 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635).

Looks almost there, just a few nits really

Dec 7 2020, 10:43 AM · Restricted Project, Restricted Project
MyDeveloperDay retitled D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635) from Update to D31635 to [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635).
Dec 7 2020, 10:37 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the summary of D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635).
Dec 7 2020, 10:36 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635).
Dec 7 2020, 10:36 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment.

What does the behavior goes wrong mean? why can't it be left aligned?

Dec 7 2020, 10:28 AM · Restricted Project, Restricted Project
MyDeveloperDay added a reviewer for D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment: MyDeveloperDay.
Dec 7 2020, 10:25 AM · Restricted Project, Restricted Project