Page MenuHomePhabricator
Feed Advanced Search

Yesterday

MyDeveloperDay added inline comments to D92168: [clang-format] Handle statement macro expressions in switch block.
Wed, Apr 21, 3:30 AM · Unknown Object (Project)
MyDeveloperDay added inline comments to D92168: [clang-format] Handle statement macro expressions in switch block.
Wed, Apr 21, 3:30 AM · Unknown Object (Project)
MyDeveloperDay added a comment to D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled.

I don't think we should change the LLVM style

Wed, Apr 21, 3:25 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay accepted D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch..

this LGTM

Wed, Apr 21, 3:21 AM · Unknown Object (Project)
MyDeveloperDay accepted D100778: [clang-format] Prevent extraneous space insertion in bitshift operators.
Wed, Apr 21, 1:53 AM · Unknown Object (Project)

Wed, Apr 14

MyDeveloperDay added reviewers for D92168: [clang-format] Handle statement macro expressions in switch block: HazardyKnusperkeks, curdeius.
Wed, Apr 14, 6:29 AM · Unknown Object (Project)
MyDeveloperDay added inline comments to D99503: [clang-format] Inconsistent behavior regarding line break before access modifier.
Wed, Apr 14, 5:26 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D99503: [clang-format] Inconsistent behavior regarding line break before access modifier.

can you clang-format so it passes the pre-merge checks

Wed, Apr 14, 5:25 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay retitled D99503: [clang-format] Inconsistent behavior regarding line break before access modifier from [clang-format] Fixes for bug 41870. to [clang-format] Inconsistent behavior regarding line break before access modifier.
Wed, Apr 14, 5:24 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added reviewers for D99503: [clang-format] Inconsistent behavior regarding line break before access modifier: HazardyKnusperkeks, curdeius.
Wed, Apr 14, 5:23 AM · Unknown Object (Project), Unknown Object (Project)

Tue, Apr 6

MyDeveloperDay added reviewers for D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled: MyDeveloperDay, HazardyKnusperkeks, curdeius.
Tue, Apr 6, 1:39 AM · Unknown Object (Project), Unknown Object (Project)

Wed, Mar 31

MyDeveloperDay accepted D98237: [clang-format] Option for empty lines after an access modifier..

LGTM thank you for trying where you could to use verifyFormat

Wed, Mar 31, 7:59 AM · Unknown Object (Project), Unknown Object (Project)

Mon, Mar 29

MyDeveloperDay accepted D99458: [clang-format] Fix east const pointer alignment of operators.

This LGTM, thank you.

Mon, Mar 29, 12:33 AM · Unknown Object (Project), Unknown Object (Project)

Wed, Mar 24

MyDeveloperDay accepted D99063: [clang-format] Fix ObjC method indent after f7f9f94b.
Wed, Mar 24, 10:30 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a project to D99063: [clang-format] Fix ObjC method indent after f7f9f94b: Unknown Object (Project).
Wed, Mar 24, 10:29 AM · Unknown Object (Project), Unknown Object (Project)

Mar 23 2021

MyDeveloperDay added a comment to D98237: [clang-format] Option for empty lines after an access modifier..

I'd be quite interested to understand what the impact (if any) would be on javascript and C# formatting

Mar 23 2021, 1:56 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration.

A quick search of github shows over 1 billion hits to the word struct, in a variety of flavours, I'm just not convinced we want a separate option for each and every case,

Mar 23 2021, 1:54 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set.

How about verifyFormat? Would that fail without your patch?

@HazardyKnusperkeks sorry, but not sure that I understand your point. Are you suggesting to use verifyFormat in my UT instead of EXPECT_EQ?

I'm pretty sure @MyDeveloperDay would ask for that. I would maybe use both. But what it really interesting for me if verifyFormat would fail, i.e. would clang-format misformat something previously correctly formatted.

Mar 23 2021, 1:42 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D98237: [clang-format] Option for empty lines after an access modifier..

If you follow people tweeting about clang-format (as I do) and you look through the bug tracking system, one major criticism of clang-format is that the second clang-format can be different from the first, sometimes an equilibrium can be found sometimes not.

Mar 23 2021, 1:40 AM · Unknown Object (Project), Unknown Object (Project)

Mar 19 2021

MyDeveloperDay added a comment to D93938: [clang-format] Fixed AfterEnum handling.

I've seen this before maybe with regard to something else, but can't quite recall. (maybe a bug in the bug tracker)

Mar 19 2021, 10:04 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D98237: [clang-format] Option for empty lines after an access modifier..
Mar 19 2021, 10:00 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D98237: [clang-format] Option for empty lines after an access modifier..

could you please mark your comments done when they are done.

Mar 19 2021, 9:54 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay requested changes to D98237: [clang-format] Option for empty lines after an access modifier..
Mar 19 2021, 9:54 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D98237: [clang-format] Option for empty lines after an access modifier..
Mar 19 2021, 9:49 AM · Unknown Object (Project), Unknown Object (Project)

Mar 10 2021

MyDeveloperDay added a comment to D98237: [clang-format] Option for empty lines after an access modifier..

Just out of interest and we are supposed to ask for this but can you point to public style guide that uses this style. (actually I don't mind if other formatting tools have this capability and you highlight it, like astyle or editorConfig etc)

Mar 10 2021, 3:04 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added reviewers for D98237: [clang-format] Option for empty lines after an access modifier.: curdeius, HazardyKnusperkeks.
Mar 10 2021, 2:57 AM · Unknown Object (Project), Unknown Object (Project)

Mar 8 2021

MyDeveloperDay updated subscribers of D93938: [clang-format] Fixed AfterEnum handling.

+1 we are not going to land this with a failing or removed test

Mar 8 2021, 11:31 PM · Unknown Object (Project), Unknown Object (Project)

Mar 4 2021

MyDeveloperDay accepted D96760: [clang-format] Suppress diagnostics on second parse.

LGTM

Mar 4 2021, 8:42 AM · Unknown Object (Project), Unknown Object (Project)

Feb 25 2021

MyDeveloperDay accepted D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers.

LGTM

Feb 25 2021, 1:53 PM · Unknown Object (Project), Unknown Object (Project)

Feb 21 2021

MyDeveloperDay added inline comments to D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers.
Feb 21 2021, 8:52 AM · Unknown Object (Project), Unknown Object (Project)

Feb 16 2021

MyDeveloperDay added a comment to D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix.

I think I'd be concern about the <string.h> case (lets ignore the fact that I should be including <string>

Feb 16 2021, 1:00 AM · Unknown Object (Project), Restricted Project, Unknown Object (Project)

Feb 13 2021

MyDeveloperDay accepted D95168: [clang-format] Add InsertBraces option.

LGTM, we need to run this on a large code base to ensure it doesn't make mistakes in real code, but I think this looks good.

Feb 13 2021, 7:09 AM · Unknown Object (Project)
MyDeveloperDay accepted D94661: [clang-format] [PR19056] Add support for access modifiers indentation.

the LGTM, please mark your comments as done when done.

Feb 13 2021, 5:28 AM · Unknown Object (Project), Unknown Object (Project)

Feb 5 2021

MyDeveloperDay added inline comments to D95168: [clang-format] Add InsertBraces option.
Feb 5 2021, 3:35 AM · Unknown Object (Project)

Feb 2 2021

MyDeveloperDay added a comment to D95168: [clang-format] Add InsertBraces option.

I'm just going to say this here, but LLVM doesn't like the use of braces on single lines (I don't actually like that myself, but I go with the convention when I remember),

Feb 2 2021, 8:32 AM · Unknown Object (Project)
MyDeveloperDay added inline comments to D95168: [clang-format] Add InsertBraces option.
Feb 2 2021, 8:27 AM · Unknown Object (Project)
MyDeveloperDay added inline comments to D95168: [clang-format] Add InsertBraces option.
Feb 2 2021, 8:24 AM · Unknown Object (Project)
MyDeveloperDay added a comment to D94955: [clang-format] Treat ForEachMacros as loops.

I guess I'm not making myself clear, I was just hoping you could be super explicit about what you are changing so anyone coming into this review would understand why the behaviour had changed (this is just pseudo code it may not be correct for all cases, but you should get the idea), We need to cover the SBS_Empty,SBS_Always,SBS_Never cases and the ShortLoops true/false

Feb 2 2021, 8:20 AM · Unknown Object (Project)
MyDeveloperDay requested changes to D94955: [clang-format] Treat ForEachMacros as loops.
Feb 2 2021, 2:57 AM · Unknown Object (Project)
MyDeveloperDay added a comment to D94955: [clang-format] Treat ForEachMacros as loops.

I'm never going to be the one to accept patches where people change tests without making it really clear why they are changing it. You have to prove you are not regressing behaviour, I work on the Beyonce rule, "if you liked it you should have put a test on it"

Feb 2 2021, 2:56 AM · Unknown Object (Project)
MyDeveloperDay accepted D93844: [clang-format] Add possibility to be based on parent directory.
Feb 2 2021, 1:32 AM · Unknown Object (Project), Unknown Object (Project)

Jan 31 2021

MyDeveloperDay added a comment to D95168: [clang-format] Add InsertBraces option.

If it's a drop in replacement (does everything clang-format does and more), what's the benefit for that cost?

Jan 31 2021, 3:56 AM · Unknown Object (Project)
MyDeveloperDay added a comment to D69764: [clang-format] Add East/West Const fixer capability.

What can be done to move this change along?

Jan 31 2021, 3:53 AM · Unknown Object (Project), Unknown Object (Project)

Jan 30 2021

MyDeveloperDay added inline comments to D94955: [clang-format] Treat ForEachMacros as loops.
Jan 30 2021, 8:48 AM · Unknown Object (Project)
MyDeveloperDay added a comment to D95168: [clang-format] Add InsertBraces option.

I wonder if we should consider suggesting a different type of tool for clang

Jan 30 2021, 8:37 AM · Unknown Object (Project)
MyDeveloperDay updated subscribers of D92257: [clang-format] Add option to control the space at the front of a line comment.

I have a script that runs clang-format -n on various directories in clang
that are clang format clean, polly is one of them because they have clang
format as a unit test

Jan 30 2021, 2:23 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

My advice leave it out of the release, the next release comes round pretty quickly. This gives us 6 months of people who use the snapshots to iron out any issues.

Jan 30 2021, 2:14 AM · Unknown Object (Project), Unknown Object (Project)

Jan 28 2021

MyDeveloperDay accepted D95017: [clang-format] Add case aware include sorting..

I like this much better LGTM

Jan 28 2021, 10:15 AM · Unknown Object (Project), Unknown Object (Project)

Jan 27 2021

MyDeveloperDay requested changes to D95538: [clang][Format] Evaluate FallbackStyle only if needed.

This needs a unit test, I personally don't understand what this is doing or why its needed, if its a bug can you reference a bug in bugzilla that explains the bug a little clearer please

Jan 27 2021, 2:54 PM · Unknown Object (Project)

Jan 26 2021

MyDeveloperDay accepted D95479: [clang-format] Avoid considering include directive as a template closer..

LGTM

Jan 26 2021, 2:23 PM · Unknown Object (Project)
MyDeveloperDay accepted D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

LGTM I think, it would be good to get input from other reviewers

Jan 26 2021, 10:17 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D95017: [clang-format] Add case aware include sorting..
Jan 26 2021, 9:25 AM · Unknown Object (Project), Unknown Object (Project)

Jan 25 2021

MyDeveloperDay added inline comments to D95017: [clang-format] Add case aware include sorting..
Jan 25 2021, 2:18 PM · Unknown Object (Project), Unknown Object (Project)

Jan 24 2021

MyDeveloperDay added inline comments to D95017: [clang-format] Add case aware include sorting..
Jan 24 2021, 2:43 PM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D94955: [clang-format] Treat ForEachMacros as loops.
Jan 24 2021, 2:40 PM · Unknown Object (Project)
MyDeveloperDay added inline comments to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Jan 24 2021, 2:40 PM · Unknown Object (Project), Unknown Object (Project)

Jan 22 2021

MyDeveloperDay added inline comments to D95168: [clang-format] Add InsertBraces option.
Jan 22 2021, 3:55 PM · Unknown Object (Project)
MyDeveloperDay updated subscribers of D95168: [clang-format] Add InsertBraces option.

I think this is one of those reviews that ultimately I think would be useful if we could ensure it works 100% correctly, but I think it goes against the original ethos of clang-format and I think if @djasper or @klimek the original authors were here they'd probably push back.

Jan 22 2021, 3:54 PM · Unknown Object (Project)

Jan 19 2021

MyDeveloperDay added a comment to D94891: [Coroutine] Remain alignment information when merging frame variables.

Thanks for explaining! I visited the his profile. It is really confusing.

Jan 19 2021, 1:36 AM · Restricted Project
MyDeveloperDay updated subscribers of D94891: [Coroutine] Remain alignment information when merging frame variables.
Jan 19 2021, 1:21 AM · Restricted Project
MyDeveloperDay updated subscribers of D94891: [Coroutine] Remain alignment information when merging frame variables.
Jan 19 2021, 1:20 AM · Restricted Project
MyDeveloperDay added a comment to D94891: [Coroutine] Remain alignment information when merging frame variables.

@231084fg may I ask why you remove the reviews for the patch?

Jan 19 2021, 1:18 AM · Restricted Project

Jan 18 2021

MyDeveloperDay planned changes to D93528: [clang-format] Add basic support for formatting JSON.
Jan 18 2021, 10:10 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay planned changes to D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario.
Jan 18 2021, 10:10 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay accepted D94906: [clang-format] Apply Allman style to lambdas.
Jan 18 2021, 10:09 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D94906: [clang-format] Apply Allman style to lambdas.

Similarly I see users having to define everything just to turn one thing off

Jan 18 2021, 10:08 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D94906: [clang-format] Apply Allman style to lambdas.

I think this is LGTM, however..

Jan 18 2021, 10:07 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93844: [clang-format] Add possibility to be based on parent directory.

What I can't easily tell from the tests is if you are overriding any styles defined in the parent with a local style.

Jan 18 2021, 2:38 AM · Unknown Object (Project), Unknown Object (Project)

Jan 17 2021

MyDeveloperDay requested changes to D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration.

I think the revision whilst it does what is needed to structs doesn't address the many other times this forms appear. I think we need something a little more extensive. It can't just be when a line starts with struct

Jan 17 2021, 3:22 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay accepted D92257: [clang-format] Add option to control the space at the front of a line comment.
Jan 17 2021, 3:20 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay requested changes to D91950: [clang-format] Add BreakBeforeInlineASMColon configuration.
Jan 17 2021, 3:18 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a reviewer for D94661: [clang-format] [PR19056] Add support for access modifiers indentation: curdeius.
Jan 17 2021, 3:17 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay requested changes to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Jan 17 2021, 3:17 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay accepted D93776: [clang-format] Add StatementAttributeLikeMacros option.

Please address the "not done" comment (regarding the sorting), but other than that its LGTM

Jan 17 2021, 3:16 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay committed rG00dc97f16708: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates (authored by MyDeveloperDay).
[clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates
Jan 17 2021, 3:15 AM
MyDeveloperDay closed D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates.
Jan 17 2021, 3:15 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario.

Sorry but due to the following issue raised by @RatTac , I'm reverting this prior to the LLVM 12 branch out so I can work on it further.

Jan 17 2021, 3:11 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a reverting change for rGe9e6e3b34a8e: [clang-format] Add IndentPragma style to eliminate common clang-format off…: rG9af03864df74: [clang-format] Revert e9e6e3b34a8e.
Jan 17 2021, 3:09 AM
MyDeveloperDay committed rG9af03864df74: [clang-format] Revert e9e6e3b34a8e (authored by MyDeveloperDay).
[clang-format] Revert e9e6e3b34a8e
Jan 17 2021, 3:09 AM
MyDeveloperDay added a reverting change for D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario: rG9af03864df74: [clang-format] Revert e9e6e3b34a8e.
Jan 17 2021, 3:09 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay accepted D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 17 2021, 3:00 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Thank you for changing the dump_style to make this clearer

Jan 17 2021, 2:58 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Thie LGTM, just to check a few nits

Jan 17 2021, 2:54 AM · Unknown Object (Project), Unknown Object (Project)

Jan 14 2021

MyDeveloperDay added inline comments to D94661: [clang-format] [PR19056] Add support for access modifiers indentation.
Jan 14 2021, 12:00 PM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D92257: [clang-format] Add option to control the space at the front of a line comment.

My assumption is that you want to stick with the minimum and maximum is that correct?

Jan 14 2021, 1:53 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Jan 14 2021, 1:48 AM · Unknown Object (Project), Unknown Object (Project)

Jan 13 2021

MyDeveloperDay added inline comments to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Jan 13 2021, 10:59 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a reviewer for D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser: curdeius.
Jan 13 2021, 10:55 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Jan 13 2021, 10:53 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

I think I would remove the code examples from the "AlignConsecutive style" to avoid confusion (that would be the first change)

Jan 13 2021, 4:30 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay accepted D93938: [clang-format] Fixed AfterEnum handling.

LGTM

Jan 13 2021, 1:18 AM · Unknown Object (Project), Unknown Object (Project)

Jan 10 2021

MyDeveloperDay accepted D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

This LGTM

Jan 10 2021, 8:04 AM · Unknown Object (Project), Unknown Object (Project)

Jan 7 2021

MyDeveloperDay added a comment to rGe9e6e3b34a8e: [clang-format] Add IndentPragma style to eliminate common clang-format off….

@RatTac Would you please consider copying the comment onto the review D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario and not the commit, I have a reply but don't want to write it here.

Jan 7 2021, 7:00 AM

Jan 5 2021

MyDeveloperDay added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 5 2021, 3:50 AM · Restricted Project, Unknown Object (Project)
MyDeveloperDay added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 5 2021, 2:34 AM · Unknown Object (Project), Restricted Project
MyDeveloperDay added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Thank you for submitting this patch?

Jan 5 2021, 2:32 AM · Unknown Object (Project), Restricted Project
MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Jan 5 2021, 1:27 AM · Unknown Object (Project), Restricted Project

Jan 4 2021

MyDeveloperDay accepted D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

This LGTM, I'm not sure if others have any further comments

Jan 4 2021, 8:31 AM · Unknown Object (Project), Restricted Project

Jan 3 2021

MyDeveloperDay added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 3 2021, 10:53 PM · Unknown Object (Project), Restricted Project
MyDeveloperDay added inline comments to D93938: [clang-format] Fixed AfterEnum handling.
Jan 3 2021, 1:27 PM · Unknown Object (Project), Restricted Project