Page MenuHomePhabricator
Feed Advanced Search

Today

MyDeveloperDay added a project to D83296: [clang-format] Add a MacroExpander.: Restricted Project.
Tue, Jul 7, 5:32 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

https://reviews.llvm.org/D79773#2131680 has something to do with your .clang-format file, the base LLVM style seems fine.

Tue, Jul 7, 12:48 AM · Restricted Project, Restricted Project

Yesterday

MyDeveloperDay added a comment to D82767: clang-format: Explicitly use python3.

We may not be consistent across all of LLVM

Mon, Jul 6, 6:12 AM · Restricted Project
MyDeveloperDay added a project to D82767: clang-format: Explicitly use python3: Restricted Project.
Mon, Jul 6, 6:09 AM · Restricted Project
MyDeveloperDay added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

Thank you @JohelEGP please keep them coming, I'll try and update the patch as soon as I have some fixes, I kind of feel like we are addressing what would have just been downstream bugs anyway. (some are quite bizarre!) so lets squish as many of them as we can before we land this.

Mon, Jul 6, 3:03 AM · Restricted Project, Restricted Project

Fri, Jul 3

MyDeveloperDay added a project to D52676: [clang-format] tweaked another case of lambda formatting: Restricted Project.
Fri, Jul 3, 12:24 PM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D82620: [clang-format] Preserve whitespace in selected macros.
Fri, Jul 3, 9:06 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D79773: [clang-format] Improve clang-formats handling of concepts.

Addressed review comments
Added one or two more tests

Fri, Jul 3, 4:49 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
Fri, Jul 3, 2:07 AM · Restricted Project, Restricted Project

Thu, Jul 2

MyDeveloperDay updated the diff for D79773: [clang-format] Improve clang-formats handling of concepts.

Still a work in progress but covers I think the case @JohelEGP found.

Thu, Jul 2, 1:31 PM · Restricted Project, Restricted Project

Wed, Jul 1

MyDeveloperDay added a comment to D82989: [flang][NFC] Get formatting in sync with latest clang-format.

I'd be interested to know if you felt any of those changes were an unwanted surprise

Wed, Jul 1, 12:59 PM · Restricted Project, Restricted Project
MyDeveloperDay updated subscribers of D82980: [NFC] Run clang-format on llvm-objcopy..
Wed, Jul 1, 12:26 PM · Restricted Project
MyDeveloperDay added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

Thank you I see now... super subtle but I'll take a look.

Wed, Jul 1, 12:26 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.
constexpr plane(const plane& other) noexcept(
    (detail::default_allocator_is_nothrow &&
     std::is_nothrow_copy_constructible_v<T>)) requires(std::copyable<T>)
  : plane{to1d(other), other.sz.w}
{
}

Without the parentheses in trailing requires-clauses, all code following the constructor initializer list is further indented.

Wed, Jul 1, 4:17 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
Wed, Jul 1, 4:17 AM · Restricted Project, Restricted Project

Tue, Jun 30

Folling awarded D69764: [clang-format] Add East/West Const fixer capability a Like token.
Tue, Jun 30, 2:02 PM · Restricted Project, Restricted Project

Mon, Jun 29

MyDeveloperDay added a comment to D82707: [clang][docs] Remove untracked files from formatted status.

The net result is an actual reduction in the overall %

Is that a bad thing?

Mon, Jun 29, 1:34 AM · Restricted Project, Restricted Project
MyDeveloperDay added a project to D82707: [clang][docs] Remove untracked files from formatted status: Restricted Project.
Mon, Jun 29, 1:34 AM · Restricted Project, Restricted Project

Sun, Jun 28

MyDeveloperDay added a comment to D82707: [clang][docs] Remove untracked files from formatted status.

The net result is an actual reduction in the overall %

Sun, Jun 28, 9:43 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D82707: [clang][docs] Remove untracked files from formatted status.

Thank you for this, I’m happy with this and can take a look at removing the os.walk I agree it might be better/quicker

Sun, Jun 28, 2:14 AM · Restricted Project, Restricted Project

Sat, Jun 27

MyDeveloperDay committed rGa43b99a1e38e: [clang-format] NFC 1% improvement in the overall clang-formatted status (authored by MyDeveloperDay).
[clang-format] NFC 1% improvement in the overall clang-formatted status
Sat, Jun 27, 4:18 AM
MyDeveloperDay closed D82016: [clang-format] [PR462254] fix indentation of default and break correctly in whitesmiths style.

closed by commit rGeb50838ba08d: [clang-format] [PR462254] fix indentation of default and break correctly in…

Sat, Jun 27, 4:17 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rGeb50838ba08d: [clang-format] [PR462254] fix indentation of default and break correctly in… (authored by MyDeveloperDay).
[clang-format] [PR462254] fix indentation of default and break correctly in…
Sat, Jun 27, 3:36 AM

Fri, Jun 26

MyDeveloperDay accepted D82620: [clang-format] Preserve whitespace in selected macros.

LGTM

Fri, Jun 26, 10:22 AM · Restricted Project, Restricted Project

Wed, Jun 24

MyDeveloperDay added a comment to D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right.

I confirm this is still an issue as of v11 (trunk) and it looks like D21279: [clang-format] Fix some issues in clang-format's AlignConsecutive modes was landed even though its not closed. (the code behind D21279 has been changed probably since it was committed, but the tests appear to be inplace for that issue)

Wed, Jun 24, 9:09 AM · Restricted Project, Restricted Project
MyDeveloperDay retitled D21279: [clang-format] Fix some issues in clang-format's AlignConsecutive modes from Fix some issues in clang-format's AlignConsecutive modes to [clang-format] Fix some issues in clang-format's AlignConsecutive modes.
Wed, Jun 24, 9:09 AM · Restricted Project, Restricted Project
MyDeveloperDay added projects to D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right: Restricted Project, Restricted Project.
Wed, Jun 24, 9:09 AM · Restricted Project, Restricted Project

Mon, Jun 22

MyDeveloperDay added a comment to D81808: [clang-format] [PR45338] AllowShortIfStatementsOnASingleLine: WithoutElse follows the documented behaviour.

I think we should add all the other cases to ensure we don't break them down the road

Mon, Jun 22, 1:01 AM · Restricted Project, Restricted Project

Wed, Jun 17

MyDeveloperDay committed rG7c1c2d977581: [clang-format] NFC 3% improvement in the overall clang-formatted status (authored by MyDeveloperDay).
[clang-format] NFC 3% improvement in the overall clang-formatted status
Wed, Jun 17, 3:40 PM
MyDeveloperDay created D82016: [clang-format] [PR462254] fix indentation of default and break correctly in whitesmiths style.
Wed, Jun 17, 8:03 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D81808: [clang-format] [PR45338] AllowShortIfStatementsOnASingleLine: WithoutElse follows the documented behaviour.

Are all the cases from the summary contained in the unit tests?

Wed, Jun 17, 3:12 AM · Restricted Project, Restricted Project

Mon, Jun 15

MyDeveloperDay added a comment to D81808: [clang-format] [PR45338] AllowShortIfStatementsOnASingleLine: WithoutElse follows the documented behaviour.
Mon, Jun 15, 2:08 AM · Restricted Project, Restricted Project

Sun, Jun 14

MyDeveloperDay added inline comments to D81808: [clang-format] [PR45338] AllowShortIfStatementsOnASingleLine: WithoutElse follows the documented behaviour.
Sun, Jun 14, 10:40 AM · Restricted Project, Restricted Project

Sat, Jun 13

MyDeveloperDay committed rG0487f6f19cda: [clang-format] Fix short block when braking after control statement (authored by MyDeveloperDay).
[clang-format] Fix short block when braking after control statement
Sat, Jun 13, 6:27 AM
MyDeveloperDay closed D71512: [clang-format] Fix short block when braking after control statement.
Sat, Jun 13, 6:27 AM · Restricted Project, Restricted Project

Jun 4 2020

MyDeveloperDay added a comment to D80950: [clang-format] [PR44542,38872] String << String always get a forced newline..

Just to add, I also think although because there are no tests to enforce it the primary reason is for when we see '\n', breaking the stream on endl but this is actually covered by another rule this also in mustBreak()

Jun 4 2020, 2:07 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D80950: [clang-format] [PR44542,38872] String << String always get a forced newline..

@sammccall in the example

Jun 4 2020, 1:34 AM · Restricted Project, Restricted Project

Jun 3 2020

MyDeveloperDay committed rG6de794e2074b: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator (authored by MyDeveloperDay).
[clang-format] [PR46157] Wrong spacing of negative literals with use of operator
Jun 3 2020, 1:14 PM
MyDeveloperDay committed rG6a0484f04b62: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name… (authored by MyDeveloperDay).
[clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name…
Jun 3 2020, 1:13 PM
MyDeveloperDay closed D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator.
Jun 3 2020, 1:13 PM · Restricted Project, Restricted Project
MyDeveloperDay closed D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases.
Jun 3 2020, 1:13 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases.

LGTM.

For a second, I thought that you could simplify the code by removing this @try condition (and calling the function FormatTokenLexer::tryTransformTryUsageForC() only if isCppOnly, but given that Objective is a superset of C, it's probably safer to keep it the way it's done now.

Jun 3 2020, 10:58 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D80950: [clang-format] [PR44542,38872] String << String always get a forced newline..

IMO this *is* actually a good heuristic: << between string literals indicates some intent to break, and when the stream is entirely literals the formatting is good.

Jun 3 2020, 10:58 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator.

Ensure no crash when CurrentToken is nullptr

Jun 3 2020, 6:33 AM · Restricted Project, Restricted Project
MyDeveloperDay planned changes to D80950: [clang-format] [PR44542,38872] String << String always get a forced newline..
Jun 3 2020, 6:33 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases.

Address review comments

Jun 3 2020, 6:33 AM · Restricted Project, Restricted Project
MyDeveloperDay added a reviewer for D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases: curdeius.
Jun 3 2020, 6:32 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases.

Out of curiosity, where does "@try" come from?

Jun 3 2020, 6:00 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D80950: [clang-format] [PR44542,38872] String << String always get a forced newline..

The change seems to me technically sound, but I'm not sure of the scope of its effects. There might be users that rely on this behavior. On the other hand, adding an option to keep the old behavior doesn't seem appropriate, and personally I consider the old behavior as a bug.

Jun 3 2020, 2:43 AM · Restricted Project, Restricted Project

Jun 1 2020

MyDeveloperDay created D80950: [clang-format] [PR44542,38872] String << String always get a forced newline..
Jun 1 2020, 2:05 PM · Restricted Project, Restricted Project
MyDeveloperDay created D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases.
Jun 1 2020, 11:18 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator.

That was a speedy patch! I can confirm that my non reduced testcase (git diff -U0 23ac16cf9bd4cc0bb434efcf6385baf083a2ff7b^ 23ac16cf9bd4cc0bb434efcf6385baf083a2ff7b | clang-format-diff.py -i -p1) is fixed with this patch. Thanks! I don't feel confident reviewing the code unfortunately.

Jun 1 2020, 10:45 AM · Restricted Project, Restricted Project
MyDeveloperDay created D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator.
Jun 1 2020, 9:06 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the summary of D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator.
Jun 1 2020, 9:06 AM · Restricted Project, Restricted Project
MyDeveloperDay added a reviewer for D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator: thopre.
Jun 1 2020, 9:06 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to rG2103e08b3f61: More fixes of implicit std::string conversions.
Jun 1 2020, 4:46 AM

May 30 2020

MyDeveloperDay committed rG50bdd6073113: [clang-format] [PR46130] When editing a file with unbalance {} the namespace… (authored by MyDeveloperDay).
[clang-format] [PR46130] When editing a file with unbalance {} the namespace…
May 30 2020, 5:17 AM
MyDeveloperDay closed D80830: [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace.
May 30 2020, 5:16 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D80830: [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace.

We don't really have any performance tests, but the following shows some analysis, all builds are release build:

May 30 2020, 5:16 AM · Restricted Project, Restricted Project

May 29 2020

MyDeveloperDay created D80830: [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace.
May 29 2020, 12:33 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D69764: [clang-format] Add East/West Const fixer capability.

@steveire Thanks for the additional test cases, I'm reworking how I handle the Macro case as I realized that I didn't actually even try to change the case @rsmith came up with in the first place. I made a decision previous that I couldn't handle any case without the *,& or && to determine that wasn't the case

May 29 2020, 12:02 PM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.
May 29 2020, 12:00 PM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

Addressed review comments
Ensure working with python3
Used improvements from @curdeius's version

May 29 2020, 9:47 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

Change % colors to help those with deuteranomaly
ensure consistent naming
validate for python3 and Windows
fix flake8 issues
switch to multi-line string templates rather than series of write() calls
add date and current commit hash of when the analysis was run

May 29 2020, 6:29 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

Would something like this be easier to read?

May 29 2020, 4:18 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

@MyDeveloperDay , I know it's a strange request, but could you change (or remove) the background color for 100% case.
I'm partially color-blind and having red and green background in the same table is really hard to distinguish. I guess I'm not alone.
I'd suggest using something like light blue, it doesn't need to stand out anyway.

May 29 2020, 2:40 AM · Restricted Project, Restricted Project

May 28 2020

MyDeveloperDay added inline comments to D69764: [clang-format] Add East/West Const fixer capability.
May 28 2020, 10:55 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

Great idea on this! I may borrow this idea and make something similar for some migrations I'm working on.

Sanity check: is this going to be run automatically when docs are generated or done offline with results committed? I don't have a preference, either has pros and cons, but I'm confused as to when this script will be run.

May 28 2020, 10:23 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D50078: clang-format: support aligned nested conditionals formatting.

I wondered if it was the < and [] causing issues

May 28 2020, 9:15 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D50078: clang-format: support aligned nested conditionals formatting.

@MyDeveloperDay , @Typz -- could you please take a look at these two issues and give your feedback? (E) looks pretty bad. I'm not familiar enough with this patch to judge how easy / hard would it be to mitigate these.

May 28 2020, 9:15 AM · Restricted Project, Restricted Project
MyDeveloperDay planned changes to D69764: [clang-format] Add East/West Const fixer capability.
May 28 2020, 8:07 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D69764: [clang-format] Add East/West Const fixer capability.

That's a rotate!

May 28 2020, 8:07 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D69764: [clang-format] Add East/West Const fixer capability.

One last thought, how about making the config a bit more future-proof and instead of ConstPlacement accept what was discussed some time ago:

QualifierStyle:
   -   const:     Right

and restrict it to const for the moment?
Maybe renaming to QualifierPlacement or something more appropriate.

May 28 2020, 8:07 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

fake8 the python
add a totals line at the bottom of the table

May 28 2020, 7:35 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

I'm adding a summary table which shows LLVM only 44% of all LLVM cpp/h files are clang-formatted. ;-(

May 28 2020, 7:34 AM · Restricted Project, Restricted Project
MyDeveloperDay planned changes to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

I'm running through flake8... almost every line is changing ;-) ...let me update before wasting any more of your time.

May 28 2020, 7:02 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D69764: [clang-format] Add East/West Const fixer capability.
May 28 2020, 4:18 AM · Restricted Project, Restricted Project
MyDeveloperDay planned changes to D69764: [clang-format] Add East/West Const fixer capability.
May 28 2020, 3:45 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D69764: [clang-format] Add East/West Const fixer capability.

Minor change for the simpler review comments before refactoring some of the more involved ones

May 28 2020, 3:45 AM · Restricted Project, Restricted Project
MyDeveloperDay planned changes to D69764: [clang-format] Add East/West Const fixer capability.
May 28 2020, 1:35 AM · Restricted Project, Restricted Project

May 27 2020

MyDeveloperDay added a comment to D69764: [clang-format] Add East/West Const fixer capability.

@rsmith, Thank you for your comments, I don't agree, but thank you anyway.

May 27 2020, 2:09 PM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D69764: [clang-format] Add East/West Const fixer capability.

Begin to cover the cases raised as potential code-breaking changes by ignoring potential MACRO usage
add support for more complex const unsigned long long cases (I believe I can simplify this to a more general pattern)

May 27 2020, 1:36 PM · Restricted Project, Restricted Project
MyDeveloperDay created D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.
May 27 2020, 6:27 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D69764: [clang-format] Add East/West Const fixer capability.

Fix crash whilst rechecking polly

May 27 2020, 2:39 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D50078: clang-format: support aligned nested conditionals formatting.
In D50078#2055227, @srj wrote:

And I also think it should be on by default instead of modifying many .clang-format files. So IMHO if we add an option, it should be opt-out.

I can live with it being opt-out. My big concern is that (as it currently stands) our project gets different 'canonical' clang-format results depending on whether people are using LLVM10 vs LLVM11 (and both are common and supported by our project), which is a headache. I just want a way to get consistent, predictable formatting regardless of the clang-format version.

Adding an option would be an issue there, I think: since clang-format is quite strict regarding options, the option would need to exist in both LLVM10 and LLVM11 if you need to support such use-case...

May 27 2020, 2:07 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D69764: [clang-format] Add East/West Const fixer capability.

@rsmith, firstly let me thank you for taking the time to review this, I didn't realize i'd invoke such a reaction that the big guns would start showing up.. fundamentally I agree with you, but let me defend my thesis to help explain my reasons why I still feel this has value.

May 27 2020, 1:02 AM · Restricted Project, Restricted Project

May 26 2020

MyDeveloperDay added inline comments to D69764: [clang-format] Add East/West Const fixer capability.
May 26 2020, 3:50 PM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D69764: [clang-format] Add East/West Const fixer capability.

rebase with master

May 26 2020, 3:50 PM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D69764: [clang-format] Add East/West Const fixer capability.

Fix issue when preprocessor #if/#else is present
Rename the config file name to ConstPlacement
change the command line option to be --const-placement
Add Left/Right into the documentation

May 26 2020, 3:50 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D69764: [clang-format] Add East/West Const fixer capability.

I really do appreciate the reviews and the comments especially regarding east/west/left/right/wrong ;-), I know there won't be 100% agreement, but I think most people who even considered cloning the LLVM repo know what we mean by East/West. As such I'm going to leave the internal code that way for now. (and the name of the TokenAnalyzer Files)

May 26 2020, 1:07 PM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D69764: [clang-format] Add East/West Const fixer capability.
May 26 2020, 1:05 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D80548: [Analyzer][NFC] Remove the SubEngine interface.

I think the buildbot might be failing http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3664

May 26 2020, 11:26 AM · Restricted Project
MyDeveloperDay committed rG8f1156a7d004: [clang-format] Fix an ObjC regression introduced with new [[likely]]… (authored by MyDeveloperDay).
[clang-format] Fix an ObjC regression introduced with new [[likely]]…
May 26 2020, 10:53 AM
MyDeveloperDay closed D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses.
May 26 2020, 10:53 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses.

Address nits

May 26 2020, 9:44 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses.
May 26 2020, 9:44 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses.

Add more tests and check if a ';' follows the final ]]

May 26 2020, 8:38 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses.

Handle more complex nested ObjC calls
Rename function to tryParseSimpleAttributes (not supporting full capability as yet)
Use RAII object to reset the TokenPosition
utilize the fact that Objective calls shouldn't end with "]]" I think... this should allow Attributes at least of the form [[identifier::identifier]]
I feel if this isn't a good enough perhaps we also check for the ; after the second ]

May 26 2020, 7:34 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses.

Check for null Tok
Fix up comments

May 26 2020, 6:27 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses.
May 26 2020, 6:27 AM · Restricted Project, Restricted Project