Page MenuHomePhabricator
Feed Advanced Search

Apr 16 2020

tnorth updated the diff for D72326: [clang-format] Rebased on master: Add option to specify explicit config file.
Apr 16 2020, 6:10 AM · Restricted Project, Restricted Project
tnorth updated the diff for D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

Sorry.

Apr 16 2020, 12:02 AM · Restricted Project, Restricted Project

Apr 6 2020

tnorth added a comment to D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

Ping?

Apr 6 2020, 2:08 AM · Restricted Project, Restricted Project

Mar 22 2020

tnorth added a comment to D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

Ping @MyDeveloperDay , any clue about what's going on here?

Mar 22 2020, 3:42 AM · Restricted Project, Restricted Project

Mar 11 2020

tnorth updated the diff for D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

Rebased on master (6d5603e2). Some refactoring was indeed needed.

Mar 11 2020, 7:24 AM · Restricted Project, Restricted Project

Mar 6 2020

tnorth added a comment to D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

Thanks @MyDeveloperDay . I guess more approvals are needed at this point?

Mar 6 2020, 7:09 AM · Restricted Project, Restricted Project

Feb 27 2020

tnorth added a comment to D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

Ping.

Feb 27 2020, 4:30 AM · Restricted Project, Restricted Project

Feb 20 2020

tnorth added inline comments to D72326: [clang-format] Rebased on master: Add option to specify explicit config file.
Feb 20 2020, 12:21 AM · Restricted Project, Restricted Project
tnorth updated the diff for D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

Fix comment to file:<configfile> instead of the incorrect file=<configfile>

Feb 20 2020, 12:21 AM · Restricted Project, Restricted Project

Feb 19 2020

tnorth added a comment to D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

Ping. I guess we need more approval to go forward?

Feb 19 2020, 6:51 AM · Restricted Project, Restricted Project

Feb 5 2020

tnorth added a comment to D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

Ping.

Feb 5 2020, 2:29 AM · Restricted Project, Restricted Project

Jan 29 2020

tnorth added a comment to D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

Nit: please add a release note and regenerate the ClangFormatStyleOptions.rst (if there are any changes because you modified Format.h).

Jan 29 2020, 7:21 AM · Restricted Project, Restricted Project
tnorth updated the diff for D72326: [clang-format] Rebased on master: Add option to specify explicit config file.
  • Add release notes
  • Update ClangFormat.rst and ClangFormatStyleOption.rst
Jan 29 2020, 7:21 AM · Restricted Project, Restricted Project

Jan 28 2020

tnorth added a comment to D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

This makes sense for command-line args, but if I understand correctly this patch will also allow BasedOnStyle: file:some/path. Is that the case?

Jan 28 2020, 7:47 AM · Restricted Project, Restricted Project
tnorth updated the diff for D72326: [clang-format] Rebased on master: Add option to specify explicit config file.
  • Add a unit-test loading a format and test file from temporary files.
Jan 28 2020, 7:45 AM · Restricted Project, Restricted Project

Jan 16 2020

tnorth updated the diff for D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

Thanks for your time and feedback.

Jan 16 2020, 8:47 AM · Restricted Project, Restricted Project

Jan 14 2020

tnorth added a comment to D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

Ping.

Jan 14 2020, 2:52 AM · Restricted Project, Restricted Project

Jan 7 2020

tnorth retitled D72326: [clang-format] Rebased on master: Add option to specify explicit config file from Rebased on master: Add option to specify explicit config file to [clang-format] Rebased on master: Add option to specify explicit config file.
Jan 7 2020, 5:42 AM · Restricted Project, Restricted Project
tnorth created D72326: [clang-format] Rebased on master: Add option to specify explicit config file.
Jan 7 2020, 5:41 AM · Restricted Project, Restricted Project