Page MenuHomePhabricator
Feed Advanced Search

Today

Herald added a project to D83266: [mlir] Convert function signatures before converting globals: Restricted Project.
Mon, Jul 6, 4:51 PM · Restricted Project

Fri, Jun 26

silvas accepted D82628: [MLIR][Shape] Add `shape.size_eq` to the shape dialect.

LGTM modulo incorporating our decision on the error case discussion from shape_eq.

Fri, Jun 26, 10:55 AM · Restricted Project
silvas accepted D82528: [MLIR][Shape] Add `shape.shape_eq` operation.

LGTM modulo getting feedback for others on how to define the error cases.

Fri, Jun 26, 10:55 AM · Restricted Project
silvas accepted D82666: [mlir] do not hardcode the name of the undefined function in the error message.

Thanks!

Fri, Jun 26, 10:55 AM · Restricted Project
silvas accepted D82667: [mlir] LLVM dialect: use addressof instead of constant to create function pointers.

It would be good to update https://mlir.llvm.org/docs/Dialects/LLVM/

Fri, Jun 26, 10:55 AM · Restricted Project

Thu, Jun 25

silvas added inline comments to D82528: [MLIR][Shape] Add `shape.shape_eq` operation.
Thu, Jun 25, 10:14 AM · Restricted Project
silvas accepted D82533: [MLIR][Shape] Fold `shape.shape_eq`.

LGTM, modulo splitting into two ops and a nit.

Thu, Jun 25, 10:14 AM · Restricted Project
silvas added a comment to D82528: [MLIR][Shape] Add `shape.shape_eq` operation.

(we could also use shape.eq to be the one for shapes, which is a bit shorter than shape.shape_eq; I personally like being a bit more explicit but it's up to you what feels best namingwise)

Thu, Jun 25, 10:13 AM · Restricted Project
silvas accepted D82531: [MLIR][Shape] Fold `shape.size_eq`.

LGTM modulo splitting into two separate ops.

Thu, Jun 25, 10:13 AM · Restricted Project
silvas added inline comments to D82528: [MLIR][Shape] Add `shape.shape_eq` operation.
Thu, Jun 25, 10:13 AM · Restricted Project
silvas requested changes to D82528: [MLIR][Shape] Add `shape.shape_eq` operation.
Thu, Jun 25, 10:13 AM · Restricted Project
silvas added inline comments to D82528: [MLIR][Shape] Add `shape.shape_eq` operation.
Thu, Jun 25, 10:13 AM · Restricted Project

Mon, Jun 22

silvas accepted D81871: [MLIR][Shape] Simplify `get_extent` when dependent on `shape_of`.
Mon, Jun 22, 11:49 AM · Restricted Project

Fri, Jun 19

silvas added inline comments to D81871: [MLIR][Shape] Simplify `get_extent` when dependent on `shape_of`.
Fri, Jun 19, 1:04 PM · Restricted Project
silvas added inline comments to D81871: [MLIR][Shape] Simplify `get_extent` when dependent on `shape_of`.
Fri, Jun 19, 12:32 PM · Restricted Project
silvas accepted D82028: [MLIR][Shape] Add `shape.rank` operation.
Fri, Jun 19, 12:32 PM · Restricted Project

Thu, Jun 18

silvas added inline comments to D81871: [MLIR][Shape] Simplify `get_extent` when dependent on `shape_of`.
Thu, Jun 18, 2:48 PM · Restricted Project
silvas accepted D82083: [MLIR][Shape] Canonicalize subsequent `size_to_index` and `index_to_size`.

Great! Thanks for these nicely factored patches!

Thu, Jun 18, 9:48 AM · Restricted Project
silvas accepted D82082: [MLIR][Shape] Canonicalize subsequent `index_to_size` and `size_to_index`.

Thanks!

Thu, Jun 18, 9:47 AM · Restricted Project
silvas accepted D82077: [MLIR][Shape] Add canonicalization pattern for `shape.rank`.

Awesome, thanks!

Thu, Jun 18, 9:46 AM · Restricted Project
silvas added inline comments to D82076: [MLIR][Shape] Add constant folding to `shape.rank`.
Thu, Jun 18, 9:45 AM · Restricted Project
silvas accepted D82076: [MLIR][Shape] Add constant folding to `shape.rank`.

LGTM modulo renaming of op (discussed in the dependent patch)

Thu, Jun 18, 9:45 AM · Restricted Project
silvas requested changes to D82028: [MLIR][Shape] Add `shape.rank` operation.
Thu, Jun 18, 9:45 AM · Restricted Project

Wed, Jun 17

silvas requested changes to D81871: [MLIR][Shape] Simplify `get_extent` when dependent on `shape_of`.
Wed, Jun 17, 11:52 AM · Restricted Project
silvas requested changes to D81560: [mlir] Add a pass to remove all shape.cstr_ and assuming_ ops..
Wed, Jun 17, 11:18 AM · Restricted Project
silvas requested changes to D82028: [MLIR][Shape] Add `shape.rank` operation.
Wed, Jun 17, 10:45 AM · Restricted Project

Tue, Jun 16

silvas requested changes to D81871: [MLIR][Shape] Simplify `get_extent` when dependent on `shape_of`.

As per discussion today, this pattern is going to "fight" with what we are doing with IREE (and also npcomp). Can we reserve this pattern for the shape to std-with-descriptors lowering?

Tue, Jun 16, 9:54 AM · Restricted Project

Fri, Jun 12

silvas added inline comments to D81694: [mlir][shape] Add a pattern to rewrite `shape.reduce` as `scf.for`..
Fri, Jun 12, 9:45 AM · Restricted Project

Thu, Jun 11

silvas added a comment to D81551: [MLIR][Standard] Make the `dim` operation index an operand..

Can you add documentation for what happens in the case where the dimension index is out of bounds? Are we allowed to assume that doesn't happen?

Thu, Jun 11, 4:00 PM · Restricted Project
silvas requested changes to D81694: [mlir][shape] Add a pattern to rewrite `shape.reduce` as `scf.for`..
Thu, Jun 11, 2:53 PM · Restricted Project

Wed, Jun 10

silvas requested changes to D81560: [mlir] Add a pass to remove all shape.cstr_ and assuming_ ops..

What is the invariant established by this pass that other passes can rely on? It seems that this pass is needed for correctness in many cases, not just optimization. So it needs to have a well-specified contract for later passes to rely on.

Wed, Jun 10, 10:31 AM · Restricted Project
silvas accepted D81531: Enable FileCheck -enable-var-scope by default in MLIR test.

Thanks! For some reason I was assuming we already had this, so seeing it turned on is great!

Wed, Jun 10, 9:58 AM · Restricted Project

Tue, Jun 9

silvas accepted D81158: [MLIR] Add missing traits and assembly format to `shape.from/to_extent_tensor`.
Tue, Jun 9, 9:19 AM · Restricted Project

Jun 6 2020

silvas accepted D81328: [mlir] Restructure Shape dialect's CMakeLists..

Thanks!!!

Jun 6 2020, 11:44 AM · Restricted Project

Jun 5 2020

silvas accepted D81279: [mlir] Lower shape.num_elements -> shape.reduce..
Jun 5 2020, 2:02 PM · Restricted Project
silvas added a comment to D81283: [mlir] Fix a build error and a warning in mlir.

mlir/Dialect/Vector/CMakeLists.txt doesn't seem to need this?

Jun 5 2020, 12:22 PM · Restricted Project
silvas added a comment to D81283: [mlir] Fix a build error and a warning in mlir.

@tpopp can you PTAL at this? Surely we aren't the first using DRR inside mlir core, and I didn't find evidence that this CMakeLists.txt annotation was needed for them. Wild guess, but perhaps we can put the ShapeCanonicalization.td in lib/ ?

Jun 5 2020, 12:22 PM · Restricted Project
silvas requested changes to D81283: [mlir] Fix a build error and a warning in mlir.
Jun 5 2020, 11:10 AM · Restricted Project
silvas accepted D81248: [MLIR][Shape] Make dimension an operand of `get_extent`.
Jun 5 2020, 11:10 AM · Restricted Project

Jun 4 2020

silvas accepted D81194: [Mlir] Add assembly format for `shape.mul`..
Jun 4 2020, 1:51 PM · Restricted Project
silvas accepted D81186: [Mlir] Implement printer, parser, verifier and builder for shape.reduce..

LGTM with one requested modification and a nit.

Jun 4 2020, 1:51 PM · Restricted Project
silvas accepted D80304: [mlir] Canonicalization of shape.cstr_broadcastable.

Looks great! Thanks!

Jun 4 2020, 12:42 PM · Restricted Project, Restricted Project
silvas accepted D81158: [MLIR] Add missing traits and assembly format to `shape.from/to_extent_tensor`.

Looks great! (modulo jacques' comments)

Jun 4 2020, 12:42 PM · Restricted Project

May 27 2020

silvas accepted D80667: [mlir] Use ValueRange instead of ArrayRef<Value> in adaptor.

Nice! I'm really looking forward to this line of work unifying the adaptors with the main flow :)

May 27 2020, 4:23 PM · Restricted Project
silvas committed rG25132b36a8b3: [mlir][shape] Use IndexElementsAttr in Shape dialect. (authored by silvas).
[mlir][shape] Use IndexElementsAttr in Shape dialect.
May 27 2020, 2:12 PM
silvas closed D80600: [mlir][shape] Use IndexElementsAttr in Shape dialect..
May 27 2020, 2:12 PM · Restricted Project
silvas committed rG9546d8b108dc: [mlir][core] Add IndexElementsAttr helpers. (authored by silvas).
[mlir][core] Add IndexElementsAttr helpers.
May 27 2020, 2:12 PM
silvas closed D80601: [mlir][core] Add IndexElementsAttr helpers..
May 27 2020, 2:11 PM · Restricted Project
silvas committed rGb27738231161: Remove error-prone mlir::ExecutionEngine::invoke overload. (authored by silvas).
Remove error-prone mlir::ExecutionEngine::invoke overload.
May 27 2020, 1:37 PM
silvas closed D80607: Remove error-prone mlir::ExecutionEngine::invoke overload..
May 27 2020, 1:37 PM · Restricted Project

May 26 2020

silvas created D80607: Remove error-prone mlir::ExecutionEngine::invoke overload..
May 26 2020, 8:42 PM · Restricted Project
silvas committed rGcf42b704391c: [mlir][shape] Add `shape.get_extent`. (authored by silvas).
[mlir][shape] Add `shape.get_extent`.
May 26 2020, 5:28 PM
silvas closed D80394: Add `shape.get_extent`..
May 26 2020, 5:28 PM · Restricted Project
silvas added inline comments to D80394: Add `shape.get_extent`..
May 26 2020, 5:28 PM · Restricted Project
silvas added reviewers for D80601: [mlir][core] Add IndexElementsAttr helpers.: mehdi_amini, ftynse.
May 26 2020, 5:28 PM · Restricted Project
silvas created D80601: [mlir][core] Add IndexElementsAttr helpers..
May 26 2020, 5:28 PM · Restricted Project
silvas created D80600: [mlir][shape] Use IndexElementsAttr in Shape dialect..
May 26 2020, 5:28 PM · Restricted Project
silvas accepted D80484: [mlir][ods] Add simple generator for return types.

Awesome! Thanks so much for doing this :)

May 26 2020, 3:50 PM · Restricted Project
silvas added a comment to D80484: [mlir][ods] Add simple generator for return types.

I feel like there must be some documentation somewhere that should be updated to describe this behavior?

May 26 2020, 3:50 PM · Restricted Project

May 21 2020

silvas committed rGbe88ba09d591: [NFC] Make assertion more informative. (authored by silvas).
[NFC] Make assertion more informative.
May 21 2020, 2:06 PM
silvas updated the diff for D80394: Add `shape.get_extent`..

Update commit message.

May 21 2020, 11:53 AM · Restricted Project
silvas created D80394: Add `shape.get_extent`..
May 21 2020, 11:53 AM · Restricted Project

May 20 2020

silvas resigned from D80189: [mlir] Add canonicalization for Cstr and Assuming Shape Ops..

Looks like this has been shraded into a couple other patches. Resigning from this master one as I reviewed the others.

May 20 2020, 7:20 PM · Restricted Project
silvas accepted D80306: [mlir] Canonicalization of shape.assuming_all.

LGTM, but let's look into using a fold for this (the good thing is that all the test cases will carry over :) )

May 20 2020, 12:02 PM · Restricted Project, Restricted Project
silvas accepted D80275: [MLIR] Add missing decorative comment line.
May 20 2020, 12:02 PM · Restricted Project
silvas accepted D80280: [MLIR] Add `index_to_size` and `size_to_index` to the shape dialect.

Awesome, thanks :)

May 20 2020, 12:02 PM · Restricted Project
silvas accepted D80307: [mlir] Add a shape op that always returns a successful witness.

See my comment in the other patch about using this in ShapeDialect::materializeConstant

May 20 2020, 12:02 PM · Restricted Project, Restricted Project
silvas accepted D80283: [MLIR] Fix operand type in `from_extent_tensor` in the shape dialect.

Thanks, this is a great cleanup! I happen to have added this before tensor<index> was allowed so I used i32, but now that doesn't make sense.

May 20 2020, 12:02 PM · Restricted Project
silvas accepted D80281: [MLIR] Add `num_elements` to the shape dialect.
May 20 2020, 12:02 PM · Restricted Project
silvas accepted D80305: [mlir] Add folding for shape.any.
May 20 2020, 12:02 PM · Restricted Project, Restricted Project
silvas accepted D80302: [mlir] Canonicalization of shape.assuming.
May 20 2020, 12:02 PM · Restricted Project, Restricted Project
silvas accepted D80303: [mlir] Canonicaliztion of shape.cstr_eq.

LGTM, but please look into making these be folds instead of canonicalization patterns. That should also make the code simpler since the folding infra will give you the folded attributes pre-canned without having to do as much getDefiningOp<ConstShapeOp>().

May 20 2020, 12:02 PM · Restricted Project, Restricted Project
silvas requested changes to D80304: [mlir] Canonicalization of shape.cstr_broadcastable.
May 20 2020, 12:02 PM · Restricted Project, Restricted Project

May 19 2020

silvas requested changes to D80004: [MLIR] Add `from_index`, `to_index`, and `num_elements` to the shape dialect.

For future reference, this patch should probably be multiple separate patches:

  1. moving ConcatOp
  2. adding size_to_index and size_from_index
  3. adding num_elements
  4. Tidying up docs of Shape_JoinOp and Shape_ReduceOp and Shape_ConstSizeOp
  5. the change to StandardTypes.h
May 19 2020, 8:21 PM · Restricted Project
silvas added inline comments to D80189: [mlir] Add canonicalization for Cstr and Assuming Shape Ops..
May 19 2020, 8:21 PM · Restricted Project
silvas committed rG21b0eff7738a: [mlir][shape] Add `shape.from_extents`. (authored by silvas).
[mlir][shape] Add `shape.from_extents`.
May 19 2020, 2:54 PM
silvas closed D79833: [mlir][shape] Add `shape.from_extents`..
May 19 2020, 2:54 PM · Restricted Project
silvas added inline comments to D79833: [mlir][shape] Add `shape.from_extents`..
May 19 2020, 2:53 PM · Restricted Project
silvas updated the diff for D79833: [mlir][shape] Add `shape.from_extents`..

Address comments.

May 19 2020, 2:53 PM · Restricted Project
silvas requested changes to D80180: [mlir] Add custom assembly formats to shape.witness ops..
May 19 2020, 9:50 AM · Restricted Project

May 18 2020

silvas added inline comments to D80004: [MLIR] Add `from_index`, `to_index`, and `num_elements` to the shape dialect.
May 18 2020, 12:26 PM · Restricted Project
silvas accepted D80111: [MLIR] Add helper functions for common integer types.

Thanks!

May 18 2020, 12:26 PM · Restricted Project

May 15 2020

silvas added inline comments to D80004: [MLIR] Add `from_index`, `to_index`, and `num_elements` to the shape dialect.
May 15 2020, 11:57 AM · Restricted Project
silvas added inline comments to D80004: [MLIR] Add `from_index`, `to_index`, and `num_elements` to the shape dialect.
May 15 2020, 11:57 AM · Restricted Project

May 13 2020

silvas committed rG0aa97ad5c8a6: [mlir] Change generate-test-checks.py to `%[[V:.*]]` style (authored by silvas).
[mlir] Change generate-test-checks.py to `%[[V:.*]]` style
May 13 2020, 3:18 PM
silvas closed D79836: [mlir] Change generate-test-checks.py to `%[[V:.*]]` style.
May 13 2020, 3:17 PM · Restricted Project

May 12 2020

silvas created D79836: [mlir] Change generate-test-checks.py to `%[[V:.*]]` style.
May 12 2020, 8:29 PM · Restricted Project
silvas created D79833: [mlir][shape] Add `shape.from_extents`..
May 12 2020, 6:52 PM · Restricted Project
silvas committed rG452e2fc409df: Revert of Revert of [mlir][shape] Tidy up shape.shape_of (authored by silvas).
Revert of Revert of [mlir][shape] Tidy up shape.shape_of
May 12 2020, 4:10 PM
silvas accepted D79717: [MLIR] Add shape.witness type and ops.
May 12 2020, 1:59 PM · Restricted Project

May 11 2020

silvas committed rGb6045448869a: [mlir][shape] Tidy up shape.shape_of (authored by silvas).
[mlir][shape] Tidy up shape.shape_of
May 11 2020, 12:57 PM
silvas committed rG98eead81868c: [mlir][Value] Add v.getDefiningOp<OpTy>() (authored by silvas).
[mlir][Value] Add v.getDefiningOp<OpTy>()
May 11 2020, 12:57 PM
silvas closed D79684: [mlir][shape] Tidy up shape.shape_of.
May 11 2020, 12:57 PM · Restricted Project
silvas closed D79681: [mlir][Value] Add v.getDefiningOp<OpTy>().
May 11 2020, 12:56 PM · Restricted Project

May 9 2020

silvas updated subscribers of D79684: [mlir][shape] Tidy up shape.shape_of.
May 9 2020, 7:40 PM · Restricted Project
silvas created D79684: [mlir][shape] Tidy up shape.shape_of.
May 9 2020, 7:40 PM · Restricted Project
silvas added a reviewer for D79683: [mlir] Add std.source and std.sink ops.: ftynse.
May 9 2020, 7:40 PM · Restricted Project
silvas updated the diff for D79683: [mlir] Add std.source and std.sink ops..

Make canonicalizer a bit easier to read.

May 9 2020, 7:40 PM · Restricted Project
silvas created D79683: [mlir] Add std.source and std.sink ops..
May 9 2020, 7:08 PM · Restricted Project
Herald added a reviewer for D79681: [mlir][Value] Add v.getDefiningOp<OpTy>(): herhut.
May 9 2020, 6:04 PM · Restricted Project