Page MenuHomePhabricator
Feed Advanced Search

Fri, Oct 23

ABataev added inline comments to D89994: [libomptarget][nvptx] Undef, internal shared variables.
Fri, Oct 23, 8:43 AM · Restricted Project
ABataev added inline comments to D89994: [libomptarget][nvptx] Undef, internal shared variables.
Fri, Oct 23, 6:23 AM · Restricted Project

Thu, Oct 22

ABataev added a comment to D89994: [libomptarget][nvptx] Undef, internal shared variables.

The nvptx back end accepts common + zero + shared, but not common + undef + shared. I think weak_odr is conceptually right here, but given the warning that nvlink doesn't support weak symbols, internal also seems fine. Can someone see an advantage to weak over internal? It could be arch specific at the risk of a lot of test duplication.

Thu, Oct 22, 4:29 PM · Restricted Project
ABataev added a comment to rG7b3eabdcd215: [OPENMP][NVPTX]Fix PR40893: Size doesn't match for….

I don't remeber already. Probably, common linkage is emitted as weak in NVPTX codegen.

Thu, Oct 22, 1:26 PM
ABataev added a comment to rG7b3eabdcd215: [OPENMP][NVPTX]Fix PR40893: Size doesn't match for….

Is this bug only for common linkage, or does it also affect weakanylinkage? If so, we should update setPropertyExecutionMode to use internal as well

Thu, Oct 22, 12:45 PM
ABataev added inline comments to D89969: [SLP] Consider alternatives for cost of select instructions..
Thu, Oct 22, 10:48 AM · Restricted Project
ABataev added inline comments to D89969: [SLP] Consider alternatives for cost of select instructions..
Thu, Oct 22, 9:36 AM · Restricted Project

Wed, Oct 21

ABataev added a comment to D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space.

I have no idea what from the commit message what this has to do with the OpenMP code gen but I saw this randomly while looking for something else so here we go:

@ABataev Sorry if I'm pulling you in without enough context/work on my end, but I wanted to ask how the Clang codegen for OpenMP locals works at a high level?

Is the idea that instead of an alloc the frontend can insert calls into the runtime in some cases, like __kmpc_alloc (e.g. for firstprivate as in https://reviews.llvm.org/D5140)?

Yes, right.

The frontend does *not* insert __kmpc_alloc calls for firstprivate, or almost anything else for that matter. Grep clang/lib and you can find 2 uses, both in very specialized cases not related to "regular" user allocations". alloca is used as with basically everything else: https://clang.godbolt.org/z/z8fEqG

Wed, Oct 21, 3:46 AM · Restricted Project

Tue, Oct 20

ABataev accepted D88735: [SLP] Also try to vectorize incoming values of PHIs ..

LG

Tue, Oct 20, 3:30 PM · Restricted Project
ABataev added inline comments to D88735: [SLP] Also try to vectorize incoming values of PHIs ..
Tue, Oct 20, 12:58 PM · Restricted Project
ABataev added inline comments to D88735: [SLP] Also try to vectorize incoming values of PHIs ..
Tue, Oct 20, 8:07 AM · Restricted Project

Wed, Oct 14

ABataev added a comment to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..

Thanks for working on this. Sorry to take so long to review. Before I try to digest the code, I have a few high-level questions.

Based on the test suite changes, TARGET_PARAM is disappearing from many cases. Can you explain a bit how that supports overlapping and reordering?

TARGET_PARAM is used only for marking the data that should be passed to the kernel function as an argument. We just generate it in many cases but the runtime actually does not use them. Thу patch relies on this thing, otherwise, we may pass an incorrect number of arguments to the kernel functions.

Is it reasonable to extract that change into a parent patch? That would at least make the test suite changes easier to follow.

Wed, Oct 14, 11:03 AM · Restricted Project, Restricted Project
ABataev added a comment to D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..

Thanks for working on this. Sorry to take so long to review. Before I try to digest the code, I have a few high-level questions.

Based on the test suite changes, TARGET_PARAM is disappearing from many cases. Can you explain a bit how that supports overlapping and reordering?

Wed, Oct 14, 9:18 AM · Restricted Project, Restricted Project
ABataev added a comment to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

reverse ping

Wed, Oct 14, 6:01 AM · Restricted Project

Mon, Oct 12

ABataev added a comment to D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space.

@ABataev Sorry if I'm pulling you in without enough context/work on my end, but I wanted to ask how the Clang codegen for OpenMP locals works at a high level?

Is the idea that instead of an alloc the frontend can insert calls into the runtime in some cases, like __kmpc_alloc (e.g. for firstprivate as in https://reviews.llvm.org/D5140)?

Mon, Oct 12, 1:33 PM · Restricted Project

Wed, Oct 7

ABataev added a comment to D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.

LG with a nit.

Wed, Oct 7, 1:16 PM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.
Wed, Oct 7, 12:04 PM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.
Wed, Oct 7, 11:48 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.
Wed, Oct 7, 11:32 AM · Restricted Project, Restricted Project, Restricted Project
ABataev added inline comments to D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.
Wed, Oct 7, 11:24 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Oct 6

ABataev added a comment to D88196: [DEBUGINFO, NVPTX] Removed Label Arithmetic from DWARF Pub Sections for NVPTX.

Did you check if ptxas can process it correctly? Are there any problems with it? I did not see that nvcc generates these sections at all.

Tue, Oct 6, 10:15 AM · Restricted Project

Sat, Oct 3

ABataev added a comment to D88196: [DEBUGINFO, NVPTX] Removed Label Arithmetic from DWARF Pub Sections for NVPTX.

If I do recall it correctly, NVPTX debug info does not support pub sections. You just need to tweak the frontend to disable emission of pub sections (need to add , nameTableKind: None to the DICompileUnit)

Sorry that I took so long to respond.
But I was able to find information on which dwarf sections ptx supports in the official documentation.
https://docs.nvidia.com/cuda/ptx-writers-guide-to-interoperability/index.html#debug-information
They also mention that they support the "debug_aranges" section which is currently disabled for only the NVPTX backend, but I could re-enable it if that's ok.

Sat, Oct 3, 10:58 AM · Restricted Project

Fri, Oct 2

ABataev added a comment to D74144: [OPENMP50]Add basic support for array-shaping operation..

@ABataev, the below test is extracted from Sollve test suite and Clang now emit:

test.c:17:35: error: subscripted value is not an array or pointer
    #pragma omp target update to( (([N][N])foo)[1:M] )
                                  ^~~~~~~~~~~~~
test.c:17:5: error: expected at least one 'to' clause or 'from' clause specified to '#pragma omp target update'
    #pragma omp target update to( (([N][N])foo)[1:M] )

This error message came from the ActOnOMPArraySectionExpr which is called inside ParsePostfixExpressionSuffix. The issue is that the base expression in ActOnOMPArraySectionExpr looks like:

ParenExpr 0x122859be0 '<OpenMP array shaping type>' lvalue
`-OMPArrayShapingExpr 0x122859b98 '<OpenMP array shaping type>' lvalue
  |-IntegerLiteral 0x122859b38 'int' 5
  |-IntegerLiteral 0x122859b58 'int' 5
  `-DeclRefExpr 0x122859b78 'int *' lvalue Var 0x1228599d0 'foo' 'int *'

which is not a base that we would expect in an array section expr. I've tried relaxing the base type check in ActOnOMPArraySectionExpr but not sure it's the way to go. (or should I just extract the DeclReExpr from ArrayShapingExpr before calling ActOnOMPArraySectionExpr?)

#define N 5
#define M 3

int main(void) {
    int tmp[N][N];
    for(int i=0; i<N; i++)
        for(int j=0; j<N; j++)
            tmp[i][j] = N*i + j;

    int *foo = &tmp[0][0];

    // This compiles just fine
    //#pragma omp target update to( ([N][N])foo )

    // This is rejected by the compiler
    #pragma omp target update to( (([N][N])foo)[1:M] )
}

I don't think it is allowed by the standard.

According to the standard, The shape-operator can appear only in clauses where it is explicitly allowed.
In this case, array shaping is used as a base expression of array section (or subscript) expression, which does not meet the standard. Tje array sjaping operation is not used in clause, instead it is used as a base subexpression of another expression.

In OpenMP 5.0 [2.12.6, target update construct, Restrictions, C/C++, p.1] The list items that appear in the to or from clauses may use shape-operators.
Also, in the array shaping section in https://github.com/OpenMP/Examples, the example is also illustrated with the same usage:

...
S-17 // update boundary points (two columns of 2D array) on the host
S-18 // pointer is shaped to 2D array using the shape-operator
S-19 #pragma omp target update from( (([nx][ny+2])a)[0:nx][1], (([nx][ny+2])a)[0:nx][ny] )
...
Fri, Oct 2, 9:30 AM · Restricted Project

Thu, Oct 1

ABataev added a comment to D74144: [OPENMP50]Add basic support for array-shaping operation..

@ABataev, the below test is extracted from Sollve test suite and Clang now emit:

test.c:17:35: error: subscripted value is not an array or pointer
    #pragma omp target update to( (([N][N])foo)[1:M] )
                                  ^~~~~~~~~~~~~
test.c:17:5: error: expected at least one 'to' clause or 'from' clause specified to '#pragma omp target update'
    #pragma omp target update to( (([N][N])foo)[1:M] )

This error message came from the ActOnOMPArraySectionExpr which is called inside ParsePostfixExpressionSuffix. The issue is that the base expression in ActOnOMPArraySectionExpr looks like:

ParenExpr 0x122859be0 '<OpenMP array shaping type>' lvalue
`-OMPArrayShapingExpr 0x122859b98 '<OpenMP array shaping type>' lvalue
  |-IntegerLiteral 0x122859b38 'int' 5
  |-IntegerLiteral 0x122859b58 'int' 5
  `-DeclRefExpr 0x122859b78 'int *' lvalue Var 0x1228599d0 'foo' 'int *'

which is not a base that we would expect in an array section expr. I've tried relaxing the base type check in ActOnOMPArraySectionExpr but not sure it's the way to go. (or should I just extract the DeclReExpr from ArrayShapingExpr before calling ActOnOMPArraySectionExpr?)

#define N 5
#define M 3

int main(void) {
    int tmp[N][N];
    for(int i=0; i<N; i++)
        for(int j=0; j<N; j++)
            tmp[i][j] = N*i + j;

    int *foo = &tmp[0][0];

    // This compiles just fine
    //#pragma omp target update to( ([N][N])foo )

    // This is rejected by the compiler
    #pragma omp target update to( (([N][N])foo)[1:M] )
}
Thu, Oct 1, 4:26 PM · Restricted Project

Sep 25 2020

ABataev updated the diff for D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..

Rebase.
This patch is an important part of 'default' mappers lookup for data members.

Sep 25 2020, 10:51 AM · Restricted Project, Restricted Project

Sep 24 2020

ABataev committed rG579c42225ac3: [OPENMP]Fix PR47621: Variable used by task inside a template function is not… (authored by ABataev).
[OPENMP]Fix PR47621: Variable used by task inside a template function is not…
Sep 24 2020, 1:23 PM
ABataev added a reverting change for rGd1419c9fdab1: [OPENMP]Fix PR47621: Variable used by task inside a template function is not…: rGcde7d90cc7c2: Revert "[OPENMP]Fix PR47621: Variable used by task inside a template function….
Sep 24 2020, 11:42 AM
ABataev committed rGcde7d90cc7c2: Revert "[OPENMP]Fix PR47621: Variable used by task inside a template function… (authored by ABataev).
Revert "[OPENMP]Fix PR47621: Variable used by task inside a template function…
Sep 24 2020, 11:42 AM
ABataev added a reverting change for D88240: [OPENMP]Fix PR47621: Variable used by task inside a template function is not made firstprivate by default: rGcde7d90cc7c2: Revert "[OPENMP]Fix PR47621: Variable used by task inside a template function….
Sep 24 2020, 11:42 AM · Restricted Project
ABataev committed rGd1419c9fdab1: [OPENMP]Fix PR47621: Variable used by task inside a template function is not… (authored by ABataev).
[OPENMP]Fix PR47621: Variable used by task inside a template function is not…
Sep 24 2020, 10:57 AM
ABataev closed D88240: [OPENMP]Fix PR47621: Variable used by task inside a template function is not made firstprivate by default.
Sep 24 2020, 10:57 AM · Restricted Project
ABataev committed rGa9fca98ee4f6: [OPENMP]PR47606: Do not update the lastprivate item if it was captured by… (authored by ABataev).
[OPENMP]PR47606: Do not update the lastprivate item if it was captured by…
Sep 24 2020, 10:23 AM
ABataev closed D88179: [OPENMP]PR47606: Do not update the lastprivate item if it was captured by reference as firstprivate data member..
Sep 24 2020, 10:22 AM · Restricted Project
ABataev requested review of D88240: [OPENMP]Fix PR47621: Variable used by task inside a template function is not made firstprivate by default.
Sep 24 2020, 9:39 AM · Restricted Project
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Sep 24 2020, 7:19 AM · Restricted Project
ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase + rename

Sep 24 2020, 6:33 AM · Restricted Project
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Sep 24 2020, 6:26 AM · Restricted Project
ABataev accepted D88193: [SLP] Remove LHS and RHS from OperationData..

LG

Sep 24 2020, 6:02 AM · Restricted Project
ABataev added a comment to D88196: [DEBUGINFO, NVPTX] Removed Label Arithmetic from DWARF Pub Sections for NVPTX.

If I do recall it correctly, NVPTX debug info does not support pub sections. You just need to tweak the frontend to disable emission of pub sections (need to add , nameTableKind: None to the DICompileUnit)

Sep 24 2020, 5:37 AM · Restricted Project

Sep 23 2020

ABataev requested review of D88179: [OPENMP]PR47606: Do not update the lastprivate item if it was captured by reference as firstprivate data member..
Sep 23 2020, 12:53 PM · Restricted Project
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Sep 23 2020, 6:31 AM · Restricted Project
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Sep 23 2020, 5:55 AM · Restricted Project
ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase + fix

Sep 23 2020, 5:30 AM · Restricted Project
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Sep 23 2020, 4:30 AM · Restricted Project

Sep 22 2020

ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase

Sep 22 2020, 3:12 PM · Restricted Project
ABataev committed rGd6ac649ccda2: [SLP]Fix coding style, NFC. (authored by ABataev).
[SLP]Fix coding style, NFC.
Sep 22 2020, 2:45 PM
ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase

Sep 22 2020, 8:57 AM · Restricted Project
ABataev added a comment to D76342: [OpenMP] Implement '#pragma omp tile'.

Rebase after D83261

Sep 22 2020, 5:06 AM · Restricted Project, Restricted Project

Sep 21 2020

ABataev committed rG3ff07fcd542e: [SLP] Allow reordering of vectorization trees with reused instructions. (authored by ABataev).
[SLP] Allow reordering of vectorization trees with reused instructions.
Sep 21 2020, 7:52 AM
ABataev updated the diff for D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..

Rebase

Sep 21 2020, 6:47 AM · Restricted Project, Restricted Project

Sep 18 2020

ABataev updated subscribers of D87841: [openmp][libomptarget] Include header from LLVM source tree.

I have no idea if this has been considered before or not, or if there is some technical/organizational difficulties against this option, but I think an option would be to create somewhere in the LLVM umbrella project for common Headers/Def.s between different LLVM subprojects (directory called "common" maybe?), which should help maintain independence between the projects without duplication, package maintainers will know to always include that in any package without having to worry about looking for shared files on a file by file bases, and users should always download that with whichever llvm package they are going to use.

FWIW.

Sep 18 2020, 10:35 AM · Restricted Project, Restricted Project
ABataev updated the diff for D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..

Rebase

Sep 18 2020, 8:44 AM · Restricted Project, Restricted Project
ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase + use std::distance instead of count_if

Sep 18 2020, 8:17 AM · Restricted Project
ABataev committed rG455ca0ebb692: [SLP] Allow reordering of vectorization trees with reused instructions. (authored by ABataev).
[SLP] Allow reordering of vectorization trees with reused instructions.
Sep 18 2020, 6:39 AM
ABataev closed D45263: [SLP] Allow reordering of vectorization trees with reused instructions..
Sep 18 2020, 6:38 AM · Restricted Project
ABataev added inline comments to D45263: [SLP] Allow reordering of vectorization trees with reused instructions..
Sep 18 2020, 6:23 AM · Restricted Project

Sep 17 2020

ABataev updated the diff for D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..

Rebase + fixes

Sep 17 2020, 2:35 PM · Restricted Project
ABataev added inline comments to D57059: [SLP] Initial support for the vectorization of the non-power-of-2 vectors..
Sep 17 2020, 2:28 PM · Restricted Project
ABataev updated the diff for D45263: [SLP] Allow reordering of vectorization trees with reused instructions..

Rebase + fixes

Sep 17 2020, 12:17 PM · Restricted Project
ABataev committed rGd5ce8233bfcf: [OpenMP 5.0] Fix user-defined mapper privatization in tasks (authored by ABataev).
[OpenMP 5.0] Fix user-defined mapper privatization in tasks
Sep 17 2020, 8:22 AM
ABataev closed D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks.
Sep 17 2020, 8:22 AM · Restricted Project
ABataev added a comment to D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks.

The latest patch applied cleanly to our downstream port.
builds fine, tests very nicely as well. All the failing SOLLVE task wait depend tests now pass.

Sep 17 2020, 6:19 AM · Restricted Project

Sep 16 2020

ABataev updated the diff for D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks.

Updated + added clang test.

Sep 16 2020, 1:32 PM · Restricted Project
ABataev commandeered D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks.
Sep 16 2020, 1:31 PM · Restricted Project
ABataev accepted D87772: [SLP] sort candidates to increase chance of optimal compare reduction.

LG

Sep 16 2020, 1:12 PM · Restricted Project
ABataev added inline comments to D87772: [SLP] sort candidates to increase chance of optimal compare reduction.
Sep 16 2020, 10:42 AM · Restricted Project
ABataev added inline comments to D87772: [SLP] sort candidates to increase chance of optimal compare reduction.
Sep 16 2020, 10:39 AM · Restricted Project
ABataev added inline comments to D87772: [SLP] sort candidates to increase chance of optimal compare reduction.
Sep 16 2020, 9:52 AM · Restricted Project
ABataev added inline comments to D87772: [SLP] sort candidates to increase chance of optimal compare reduction.
Sep 16 2020, 9:12 AM · Restricted Project
ABataev committed rG4341c6618dec: [OPENMP]Do not allow threadprivates as base for array-like reduction. (authored by ABataev).
[OPENMP]Do not allow threadprivates as base for array-like reduction.
Sep 16 2020, 6:32 AM
ABataev closed D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction..
Sep 16 2020, 6:32 AM · Restricted Project
ABataev abandoned D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..
Sep 16 2020, 5:13 AM · Restricted Project
ABataev abandoned D83130: [OPENMP]Fix test for ARM, NFC..
Sep 16 2020, 5:13 AM · Restricted Project
ABataev abandoned D82881: [DEBUGINFO]Fix debug info for packed bitfields..
Sep 16 2020, 5:11 AM · debug-info, Restricted Project

Sep 15 2020

ABataev committed rG9e3842d60351: [OPENMP]Fix codegen for is_device_ptr component, captured by reference. (authored by ABataev).
[OPENMP]Fix codegen for is_device_ptr component, captured by reference.
Sep 15 2020, 2:40 PM
ABataev closed D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference..
Sep 15 2020, 2:40 PM · Restricted Project
ABataev added a comment to D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks.

Hi Ron, hope to prepare it by the end of this week, maybe earlier, if everything goes well. I have some technical issues, but anyway will update the patch and the tests.

Sep 15 2020, 12:32 PM · Restricted Project
ABataev committed rG738bab743b5c: [OPENMP]Add support for allocate vars in untied tasks. (authored by ABataev).
[OPENMP]Add support for allocate vars in untied tasks.
Sep 15 2020, 11:01 AM
ABataev closed D86558: [OPENMP]Add support for allocate vars in untied tasks..
Sep 15 2020, 11:01 AM · Restricted Project
ABataev added a comment to D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

Please go ahead and commit.

Hi Hans, can you commit it yourself? I have some technical issues and not able to commit it. And I don't know when it is going to be resolved. :(

Sure! 4b23932e230dd48a7bfc6fadb461d0ef81aeba94

Sep 15 2020, 9:41 AM · Restricted Project
ABataev added inline comments to D57779: [SLP] Add support for throttling..
Sep 15 2020, 9:30 AM · Restricted Project
ABataev added inline comments to D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN.
Sep 15 2020, 7:44 AM · Restricted Project
ABataev added a comment to D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

Please go ahead and commit.

Sep 15 2020, 6:54 AM · Restricted Project

Sep 10 2020

ABataev added a comment to D57779: [SLP] Add support for throttling..

Good enough for initial implementation?

yes, For me, it looks like ready.

Sep 10 2020, 1:30 PM · Restricted Project

Sep 8 2020

ABataev added a comment to D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks.

I can update this patch in a week when I'm back from vacation.

Sep 8 2020, 10:39 AM · Restricted Project

Sep 1 2020

ABataev committed rG2114f71aaa8d: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl() (authored by nullptr.cpp).
[OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()
Sep 1 2020, 5:46 AM
ABataev closed D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().
Sep 1 2020, 5:46 AM · Restricted Project

Aug 31 2020

ABataev accepted D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl().

LG

Aug 31 2020, 9:24 AM · Restricted Project

Aug 29 2020

ABataev added inline comments to D86781: [LIBOMPTARGET]Do not try to optimize bases for the next parameters..
Aug 29 2020, 6:13 PM · Restricted Project

Aug 28 2020

ABataev updated the diff for D86558: [OPENMP]Add support for allocate vars in untied tasks..

Rebase

Aug 28 2020, 2:52 PM · Restricted Project
ABataev updated the diff for D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction..

Rebase

Aug 28 2020, 2:10 PM · Restricted Project
ABataev updated the diff for D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference..

Rebase

Aug 28 2020, 1:58 PM · Restricted Project
ABataev updated the diff for D86119: [OPENMP50]Allow overlapping mapping in target constrcuts..
  1. Generalized interface for all mapping operations.
  2. Fixed compatibility of declare mapper and other mapping operations with OpenMP 5.0 examples.
  3. Simplified declare mapper codegen.
Aug 28 2020, 1:29 PM · Restricted Project, Restricted Project
ABataev committed rG6aa7228a629d: [LIBOMPTARGET]Do not try to optimize bases for the next parameters. (authored by ABataev).
[LIBOMPTARGET]Do not try to optimize bases for the next parameters.
Aug 28 2020, 12:51 PM
ABataev closed D86781: [LIBOMPTARGET]Do not try to optimize bases for the next parameters..
Aug 28 2020, 12:50 PM · Restricted Project
ABataev accepted D86758: [OpenMP] Fixed wrong test command in the test private_mapping.c.

LG

Aug 28 2020, 8:14 AM · Restricted Project
ABataev requested review of D86781: [LIBOMPTARGET]Do not try to optimize bases for the next parameters..
Aug 28 2020, 5:57 AM · Restricted Project
ABataev added a comment to D86758: [OpenMP] Fixed wrong test command in the test private_mapping.c.

compilexx is for c++ tests, IIRC, try compile instead

Aug 28 2020, 3:14 AM · Restricted Project

Aug 27 2020

ABataev added inline comments to D86307: [OpenMP] Pack first-private arguments to improve efficiency of data transfer.
Aug 27 2020, 2:24 PM · Restricted Project
ABataev committed rGba1de5f2f7b0: [OPENMP]Do not crash for globals in inner regions with outer target (authored by ABataev).
[OPENMP]Do not crash for globals in inner regions with outer target
Aug 27 2020, 2:08 PM