Page MenuHomePhabricator
Feed Advanced Search

Thu, Jun 17

luke957 closed D104364: [RISCV] Don't enable Interleaved Access Vectorization.
Thu, Jun 17, 9:46 PM · Restricted Project
luke957 committed rGc2e97ba85e46: [RISCV] Don't enable Interleaved Access Vectorization (authored by luke957).
[RISCV] Don't enable Interleaved Access Vectorization
Thu, Jun 17, 9:39 PM

Wed, Jun 16

luke957 updated the summary of D104393: [RISCV] Update test case.
Wed, Jun 16, 8:56 AM · Restricted Project
luke957 added a reviewer for D104393: [RISCV] Update test case: jrtc27.
Wed, Jun 16, 8:55 AM · Restricted Project
luke957 requested review of D104393: [RISCV] Update test case.
Wed, Jun 16, 8:54 AM · Restricted Project
luke957 added inline comments to D101469: [RISCV] Enable interleaved vectorization for RVV.
Wed, Jun 16, 2:29 AM · Restricted Project
luke957 added inline comments to D101469: [RISCV] Enable interleaved vectorization for RVV.
Wed, Jun 16, 2:24 AM · Restricted Project
luke957 requested review of D104364: [RISCV] Don't enable Interleaved Access Vectorization.
Wed, Jun 16, 1:39 AM · Restricted Project
luke957 added inline comments to D101469: [RISCV] Enable interleaved vectorization for RVV.
Wed, Jun 16, 1:21 AM · Restricted Project

Mon, Jun 7

luke957 added a comment to D101469: [RISCV] Enable interleaved vectorization for RVV.

I just noticed that this enabled interleaving in the loop vectorizer even when the V extension isn't enabled. So we now generate interleaved scalar code in some cases. Was that intentional?

Thanks for reminding me. Sorry for my carelessness.

Mon, Jun 7, 7:33 PM · Restricted Project

Sun, Jun 6

luke957 accepted D103787: [RISCV] Don't enable loop vectorizer interleaving if the V extension isn't enabled..
Sun, Jun 6, 11:48 PM · Restricted Project
luke957 added a comment to D103787: [RISCV] Don't enable loop vectorizer interleaving if the V extension isn't enabled..

LGTM

Sun, Jun 6, 11:47 PM · Restricted Project
luke957 added a comment to D101469: [RISCV] Enable interleaved vectorization for RVV.

I just noticed that this enabled interleaving in the loop vectorizer even when the V extension isn't enabled. So we now generate interleaved scalar code in some cases. Was that intentional?

Sun, Jun 6, 11:45 PM · Restricted Project

Fri, May 28

luke957 committed rGc4c3869554a6: [RISCV] Enable interleaved vectorization for RVV (authored by luke957).
[RISCV] Enable interleaved vectorization for RVV
Fri, May 28, 8:29 PM
luke957 closed D101469: [RISCV] Enable interleaved vectorization for RVV.
Fri, May 28, 8:28 PM · Restricted Project
luke957 added a comment to D101469: [RISCV] Enable interleaved vectorization for RVV.

ping

Fri, May 28, 9:36 AM · Restricted Project

May 20 2021

luke957 added inline comments to D101469: [RISCV] Enable interleaved vectorization for RVV.
May 20 2021, 10:27 AM · Restricted Project
luke957 updated the diff for D101469: [RISCV] Enable interleaved vectorization for RVV.

Rebase and update.

May 20 2021, 10:15 AM · Restricted Project
luke957 committed rG1595994b2825: [RISCV] Add legality check for vectorizing reduction (authored by luke957).
[RISCV] Add legality check for vectorizing reduction
May 20 2021, 2:46 AM
luke957 closed D99509: [RISCV] Add legality check for vectoring reduction.
May 20 2021, 2:46 AM · Restricted Project

May 19 2021

luke957 updated the diff for D99509: [RISCV] Add legality check for vectoring reduction.

rebase

May 19 2021, 9:37 AM · Restricted Project

May 18 2021

luke957 added inline comments to D99509: [RISCV] Add legality check for vectoring reduction.
May 18 2021, 9:11 AM · Restricted Project
luke957 updated the diff for D99509: [RISCV] Add legality check for vectoring reduction.
May 18 2021, 9:02 AM · Restricted Project
luke957 added a comment to D101469: [RISCV] Enable interleaved vectorization for RVV.

Do you still need to update the diff to address the previous comments?

May 18 2021, 8:12 AM · Restricted Project
luke957 added a comment to D101469: [RISCV] Enable interleaved vectorization for RVV.

ping

May 18 2021, 7:05 AM · Restricted Project

Apr 29 2021

luke957 added inline comments to D101469: [RISCV] Enable interleaved vectorization for RVV.
Apr 29 2021, 9:06 AM · Restricted Project
luke957 updated the diff for D101469: [RISCV] Enable interleaved vectorization for RVV.
Apr 29 2021, 8:55 AM · Restricted Project

Apr 28 2021

luke957 added reviewers for D101469: [RISCV] Enable interleaved vectorization for RVV: craig.topper, frasercrmck, HsiangKai.
Apr 28 2021, 9:19 AM · Restricted Project
luke957 requested review of D101469: [RISCV] Enable interleaved vectorization for RVV.
Apr 28 2021, 9:17 AM · Restricted Project
luke957 added a comment to D99509: [RISCV] Add legality check for vectoring reduction.

ping

Apr 28 2021, 12:32 AM · Restricted Project

Apr 22 2021

luke957 added inline comments to D99509: [RISCV] Add legality check for vectoring reduction.
Apr 22 2021, 9:35 AM · Restricted Project
luke957 updated the diff for D99509: [RISCV] Add legality check for vectoring reduction.
Apr 22 2021, 8:58 AM · Restricted Project

Apr 15 2021

luke957 added a reviewer for D99509: [RISCV] Add legality check for vectoring reduction: dmgreen.
Apr 15 2021, 6:23 AM · Restricted Project
luke957 added a comment to D99509: [RISCV] Add legality check for vectoring reduction.

ping

Apr 15 2021, 3:17 AM · Restricted Project

Apr 13 2021

luke957 abandoned D99492: [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions.
Apr 13 2021, 7:59 PM · Restricted Project

Apr 8 2021

luke957 added inline comments to D99509: [RISCV] Add legality check for vectoring reduction.
Apr 8 2021, 1:36 AM · Restricted Project
luke957 updated the diff for D99509: [RISCV] Add legality check for vectoring reduction.
Apr 8 2021, 1:25 AM · Restricted Project

Apr 7 2021

luke957 added inline comments to D99509: [RISCV] Add legality check for vectoring reduction.
Apr 7 2021, 8:38 AM · Restricted Project
luke957 updated the diff for D99509: [RISCV] Add legality check for vectoring reduction.
Apr 7 2021, 8:34 AM · Restricted Project

Apr 5 2021

luke957 added inline comments to D99509: [RISCV] Add legality check for vectoring reduction.
Apr 5 2021, 9:32 AM · Restricted Project
luke957 added inline comments to D99509: [RISCV] Add legality check for vectoring reduction.
Apr 5 2021, 9:23 AM · Restricted Project

Mar 30 2021

luke957 added inline comments to D99492: [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions.
Mar 30 2021, 3:36 AM · Restricted Project
luke957 added a comment to D99492: [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions.

There is no such implication in the V specification. See https://github.com/riscv/riscv-v-spec/issues/608.

Mar 30 2021, 3:34 AM · Restricted Project

Mar 29 2021

luke957 requested review of D99509: [RISCV] Add legality check for vectoring reduction.
Mar 29 2021, 8:15 AM · Restricted Project
luke957 added reviewers for D99492: [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions: frasercrmck, HsiangKai, StephenFan.
Mar 29 2021, 3:48 AM · Restricted Project
luke957 retitled D99492: [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions from [RISCV] "V" Extention coming with "F" "D" "Zfh" to [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions.
Mar 29 2021, 3:44 AM · Restricted Project
luke957 requested review of D99492: [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions.
Mar 29 2021, 2:38 AM · Restricted Project

Mar 4 2021

luke957 committed rGd28297ff68ee: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector (authored by luke957).
[RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector
Mar 4 2021, 6:56 PM
luke957 closed D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Mar 4 2021, 6:56 PM · Restricted Project
luke957 added a comment to D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.

LGTM. I wouldn't say my last suggestion is a hard requirement.

Mar 4 2021, 4:57 AM · Restricted Project
luke957 added inline comments to D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Mar 4 2021, 4:26 AM · Restricted Project
luke957 updated the diff for D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Mar 4 2021, 4:23 AM · Restricted Project

Mar 3 2021

luke957 added inline comments to D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Mar 3 2021, 10:46 PM · Restricted Project
luke957 updated the diff for D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Mar 3 2021, 10:42 PM · Restricted Project

Mar 2 2021

luke957 added a comment to D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.

The changes LGTM, thanks for adding a test case.

However, I think the commit title/message could be expanded upon somewhat. For example, *how* does it improve LoopVectorizer support? Since we've got both fixed-length and scalable vectorization, I think it would be helpful to clarify that this relates to fixed-length vectorization. More specifically, doesn't this change *enable* fixed-length vectorization, not just improve upon it?

Mar 2 2021, 7:24 PM · Restricted Project
luke957 retitled D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector from [RISCV] Improve support of LoopVectorizer for RISC-V Vector to [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Mar 2 2021, 7:17 PM · Restricted Project

Mar 1 2021

luke957 added a comment to D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.

Test case?

Mar 1 2021, 7:37 PM · Restricted Project
luke957 updated the diff for D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.

Add test case riscv-unroll.ll

Mar 1 2021, 7:13 PM · Restricted Project

Feb 26 2021

luke957 added reviewers for D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector: HsiangKai, craig.topper.
Feb 26 2021, 6:21 AM · Restricted Project
luke957 requested review of D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Feb 26 2021, 6:03 AM · Restricted Project