Page MenuHomePhabricator
Feed Advanced Search

Jul 10 2019

ashi1 accepted D64364: [HIP] Add GPU arch gfx1010, gfx1011, and gfx1012.

LGTM!

Jul 10 2019, 2:51 PM · Restricted Project

Apr 10 2019

ashi1 accepted D60513: [HIP] Use -mlink-builtin-bitcode to link device library.

LGTM

Apr 10 2019, 10:56 AM · Restricted Project

Apr 3 2019

ashi1 added a comment to D60141: [HIP-Clang] Fat binary should not be produced for non GPU code.

Thank you, I submitted a clang-formatted fix for the if statement.

Apr 3 2019, 7:16 AM · Restricted Project, Restricted Project

Apr 2 2019

ashi1 committed rG6d37f326fc69: [HIP-Clang] Fat binary should not be produced for non GPU code (authored by ashi1).
[HIP-Clang] Fat binary should not be produced for non GPU code
Apr 2 2019, 2:55 PM
ashi1 added a comment to D60141: [HIP-Clang] Fat binary should not be produced for non GPU code.

Hi Artem, I had just committed the change. IS this change OK or should I revert it?

Apr 2 2019, 1:52 PM · Restricted Project, Restricted Project
ashi1 committed rG8129521318ac: [HIP-Clang] Fat binary should not be produced for non GPU code 2 (authored by ashi1).
[HIP-Clang] Fat binary should not be produced for non GPU code 2
Apr 2 2019, 1:48 PM
ashi1 committed rG13d8e929409f: [HIP-Clang] Fat binary should not be produced for non GPU code (authored by ashi1).
[HIP-Clang] Fat binary should not be produced for non GPU code
Apr 2 2019, 1:10 PM
ashi1 created D60141: [HIP-Clang] Fat binary should not be produced for non GPU code.
Apr 2 2019, 10:56 AM · Restricted Project, Restricted Project

Mar 15 2019

ashi1 committed rG04fddc9b27f1: [HIP-Clang] propagate -mllvm options to opt and llc (authored by ashi1).
[HIP-Clang] propagate -mllvm options to opt and llc
Mar 15 2019, 10:33 AM

Mar 13 2019

ashi1 updated subscribers of D59316: [HIP-Clang] propagate -mllvm options to opt and llc.
Mar 13 2019, 1:02 PM · Restricted Project
ashi1 added a comment to D59316: [HIP-Clang] propagate -mllvm options to opt and llc.

Hi Matt, that solution will need refactoring and testing. Currently, HIP-Clang is following the same link flow as HCC

Mar 13 2019, 1:01 PM · Restricted Project
ashi1 created D59316: [HIP-Clang] propagate -mllvm options to opt and llc.
Mar 13 2019, 12:43 PM · Restricted Project

Feb 19 2019

ashi1 added a comment to D57977: [HIP] compile option code-object-v3 propagate to llc.

This was submitted again with the fix. Thanks!

Feb 19 2019, 11:51 AM · Restricted Project

Feb 13 2019

ashi1 committed rG7084b56ee2e0: [HIP] Handle compile -m options and propagate into LLC (authored by ashi1).
[HIP] Handle compile -m options and propagate into LLC
Feb 13 2019, 8:12 AM

Feb 12 2019

ashi1 committed rGa1adb80ae7ad: [HIP] Fix hip-toolchain-rdc tests (authored by ashi1).
[HIP] Fix hip-toolchain-rdc tests
Feb 12 2019, 2:03 PM
ashi1 committed rG41bbc6e04cb1: [HIP] Handle compile -m options and propagate into LLC (authored by ashi1).
[HIP] Handle compile -m options and propagate into LLC
Feb 12 2019, 1:21 PM
ashi1 added a comment to D57977: [HIP] compile option code-object-v3 propagate to llc.

Yes, but it will need this PR: https://github.com/ROCm-Developer-Tools/HIP/pull/910
So that the default is set.

Feb 12 2019, 12:39 PM · Restricted Project
ashi1 updated subscribers of D57977: [HIP] compile option code-object-v3 propagate to llc.
Feb 12 2019, 12:36 PM · Restricted Project
ashi1 updated subscribers of D57977: [HIP] compile option code-object-v3 propagate to llc.
Feb 12 2019, 12:34 PM · Restricted Project
ashi1 updated the diff for D57977: [HIP] compile option code-object-v3 propagate to llc.

I've added a lit test to check for options such as -mxnack/-mno-xnack, -msram-ecc/-mno-sram-ecc, -mcode-object-v3/-mno-code-object-v3

Feb 12 2019, 12:22 PM · Restricted Project
ashi1 updated the diff for D57977: [HIP] compile option code-object-v3 propagate to llc.

Changed patch to us handleTargetFeatures, to consume all -m options passed into clang.

Feb 12 2019, 11:10 AM · Restricted Project

Feb 8 2019

ashi1 created D57977: [HIP] compile option code-object-v3 propagate to llc.
Feb 8 2019, 2:21 PM · Restricted Project

Jan 4 2019

ashi1 added a comment to D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types.

I've commit the changes, but forgot to tag the proper Diff link in the commit message. I just updated it.

Jan 4 2019, 11:19 AM
ashi1 updated the diff for D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types.
Jan 4 2019, 11:18 AM
ashi1 removed an edge from rL350426: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types: D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types.
Jan 4 2019, 11:17 AM
ashi1 removed 2 commit(s) for D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types: rC350426: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types, rL350426: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types.
Jan 4 2019, 11:17 AM
ashi1 removed an edge from rC350426: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types: D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types.
Jan 4 2019, 11:17 AM
ashi1 added an edge to rC350425: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types: D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types.
Jan 4 2019, 11:17 AM
ashi1 added an edge to rL350425: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types: D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types.
Jan 4 2019, 11:17 AM
ashi1 added 2 commit(s) for D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types: rC350425: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types, rL350425: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types.
Jan 4 2019, 11:17 AM
ashi1 updated subscribers of D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types.
Jan 4 2019, 8:41 AM
ashi1 created D56321: [HIP][DRIVER][OFFLOAD] Do not unbundle unsupported file types.
Jan 4 2019, 8:41 AM

Oct 9 2018

ashi1 updated the diff for D52673: [HIP] Remove disabled irif library.

I've moved the hip.amdgcn.bc to the top of the libs. Updated test as well.

Oct 9 2018, 12:07 PM
ashi1 updated the diff for D52673: [HIP] Remove disabled irif library.

The device libraries has been updated, and the hip.amdgcn.bc library is now available there.

Oct 9 2018, 11:07 AM

Oct 4 2018

ashi1 added a comment to D52673: [HIP] Remove disabled irif library.

I've added a hip.amdgcn.bc library for the fence functions that were originally in irif library.

Oct 4 2018, 2:42 PM
ashi1 updated the diff for D52673: [HIP] Remove disabled irif library.
Oct 4 2018, 2:41 PM

Oct 1 2018

ashi1 updated the diff for D52673: [HIP] Remove disabled irif library.

Added diff with full context. Also, I need to find replacements for few functions in HIP github before this can be submitted.

Oct 1 2018, 7:54 AM

Sep 28 2018

ashi1 created D52673: [HIP] Remove disabled irif library.
Sep 28 2018, 2:17 PM

Jun 27 2018

ashi1 updated the diff for D48667: [HIP] Fix ordering of device-lib linking.

Updated diff with a lit test.

Jun 27 2018, 12:35 PM · Unknown Object (Project), Restricted Project
ashi1 created D48667: [HIP] Fix ordering of device-lib linking.
Jun 27 2018, 12:16 PM · Unknown Object (Project), Restricted Project
ashi1 updated the diff for D48493: [HIP] Support flush denorms bitcode.

Merged checks for flush denorm on and off into single test hip-device-libs.hip

Jun 27 2018, 11:47 AM · Unknown Object (Project), Restricted Project
ashi1 updated the diff for D48493: [HIP] Support flush denorms bitcode.
Jun 27 2018, 11:29 AM · Unknown Object (Project), Restricted Project
ashi1 updated the diff for D48493: [HIP] Support flush denorms bitcode.

I've updated. Moved the bitcode files into hip_dev_lib and added test for both on and off flush denorms to zero option.

Jun 27 2018, 11:17 AM · Unknown Object (Project), Restricted Project
ashi1 updated the diff for D48493: [HIP] Support flush denorms bitcode.

Fix diff file

Jun 27 2018, 11:03 AM · Unknown Object (Project), Restricted Project
ashi1 updated the diff for D48493: [HIP] Support flush denorms bitcode.
Jun 27 2018, 10:54 AM · Unknown Object (Project), Restricted Project
ashi1 updated the diff for D48493: [HIP] Support flush denorms bitcode.

I've changed the string to a more meaningful name, and also added a lit test to check that oclc_daz_opt_on.amdgcn.bc is used.

Jun 27 2018, 10:36 AM · Unknown Object (Project), Restricted Project

Jun 22 2018

ashi1 created D48493: [HIP] Support flush denorms bitcode.
Jun 22 2018, 10:33 AM · Unknown Object (Project), Restricted Project

Jun 21 2018

ashi1 created D48455: Remove hip.amdgcn.bc hc.amdgcn.bc from HIP Toolchains.
Jun 21 2018, 2:21 PM · Unknown Object (Project), Restricted Project

Mar 22 2018

ashi1 added a comment to D39739: [HCC] Add flag to Import Weak Functions in Function Importer.

Is first one encountered a poor design?

Mar 22 2018, 7:57 AM

Nov 9 2017

ashi1 updated the diff for D39739: [HCC] Add flag to Import Weak Functions in Function Importer.

I've added the lit tests for this change, and also showing full context.

Nov 9 2017, 10:44 AM

Nov 7 2017

ashi1 updated subscribers of D39739: [HCC] Add flag to Import Weak Functions in Function Importer.
Nov 7 2017, 10:36 AM
ashi1 created D39739: [HCC] Add flag to Import Weak Functions in Function Importer.
Nov 7 2017, 9:10 AM

Aug 16 2016

ashi1 retitled D23573: [OpenCL] AMDGPU: add support of cl_khr_subgroups from [OpenCL] Add extension cl_khr_subgroups to clang to [OpenCL] AMDGPU: add support of cl_khr_subgroups.
Aug 16 2016, 12:58 PM
ashi1 retitled D23573: [OpenCL] AMDGPU: add support of cl_khr_subgroups from to [OpenCL] Add extension cl_khr_subgroups to clang.
Aug 16 2016, 11:06 AM

Aug 2 2016

ashi1 retitled D23086: [OpenCL] Generate concrete struct type for ndrange_t from to [OpenCL] Generate concrete struct type for ndrange_t.
Aug 2 2016, 2:10 PM
ashi1 retitled D23071: [OpenCL] Remove extra native_ functions from opencl-c.h from to [OpenCL] Remove extra native_ functions from opencl-c.h.
Aug 2 2016, 11:22 AM

Jul 29 2016

ashi1 retitled D22964: [OpenCL] Add missing tests for getOCLTypeName from to [OpenCL] Add missing tests for getOCLTypeName.
Jul 29 2016, 10:49 AM

Jul 27 2016

ashi1 updated the diff for D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang.

Removed indentation as per Anastasia's comments.

Jul 27 2016, 10:48 AM

Jul 26 2016

ashi1 updated the diff for D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang.

Revised based on Anastasia's comments. Restructured the if statements in test cases.

Jul 26 2016, 1:19 PM

Jul 25 2016

ashi1 added inline comments to D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang.
Jul 25 2016, 10:40 AM
ashi1 retitled D22767: [OpenCL] Added CLK_ABGR definition for get_image_channel_order return value from to [OpenCL] Added CLK_ABGR definition for get_image_channel_order return value.
Jul 25 2016, 10:32 AM

Jul 22 2016

ashi1 updated the diff for D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang.

Revised based on Sam's comments.

Jul 22 2016, 12:53 PM
ashi1 updated the diff for D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang.

Revised based on Sam's comments. Added to tests Misc\amdgcn.languageOptsOpenCL.cl and SemaOpenCL\extension-version.cl

Jul 22 2016, 11:48 AM

Jul 21 2016

ashi1 retitled D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang from to [OpenCL] Add extension cl_khr_mipmap_image to clang.
Jul 21 2016, 11:26 AM

Jul 20 2016

ashi1 updated the diff for D22523: [OpenCL] AMDGCN target will generate images in constant address space.

Removed excess semicolon by Anastasia's comments

Jul 20 2016, 10:10 AM

Jul 19 2016

ashi1 updated the diff for D22523: [OpenCL] AMDGCN target will generate images in constant address space.

Revised based on Sam's comments. Also updated test file to changes with using triple spir-unknown-unknown.

Jul 19 2016, 11:59 AM
ashi1 retitled D22523: [OpenCL] AMDGCN target will generate images in constant address space from to [OpenCL] AMDGCN target will generate images in constant address space.
Jul 19 2016, 11:11 AM
ashi1 updated the diff for D22424: [OpenCL] Fixes bug of missing OCL related metadata on the AMDGCN target.

Revised based on Anastasia's comments. Now using new function name appendOpenCLVersionMD(

Jul 19 2016, 9:27 AM

Jul 15 2016

ashi1 retitled D22424: [OpenCL] Fixes bug of missing OCL related metadata on the AMDGCN target from to [OpenCL] Fixes bug of missing OCL related metadata on the AMDGCN target.
Jul 15 2016, 2:07 PM

Jul 12 2016

ashi1 updated the diff for D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL.

Revised to Anastasia's comments. Removed opencl-blocks.cl, and created a generic opencl.cl inside test/Frontend folder.

Jul 12 2016, 1:09 PM

Jul 11 2016

ashi1 updated the diff for D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL.

Moved cl-strict-aliasing testing to a new file cl-strict-aliasing.cl

Jul 11 2016, 10:57 AM
ashi1 added inline comments to D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL.
Jul 11 2016, 10:14 AM

Jul 8 2016

ashi1 retitled D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL from to [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL.
Jul 8 2016, 2:05 PM

Jul 7 2016

ashi1 added inline comments to D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver.
Jul 7 2016, 2:54 PM
ashi1 updated the diff for D22067: [OpenCL] Add missing -cl-no-signed-zeros option into driver.

Revised base on Sam's comments.

Jul 7 2016, 2:47 PM

Jul 6 2016

ashi1 retitled D22067: [OpenCL] Add missing -cl-no-signed-zeros option into driver from to [OpenCL] Add missing -cl-no-signed-zeros option into driver.
Jul 6 2016, 1:24 PM

Jun 22 2016

ashi1 updated the diff for D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver.

Revised to Anastasia's comments.

Jun 22 2016, 10:54 AM

Jun 21 2016

ashi1 updated the diff for D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver.

Revised based on Anastasia's comments. Also clang-test run passes, the testcases should be working correctly.

Jun 21 2016, 12:25 PM

Jun 20 2016

ashi1 updated the diff for D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver.

Revised with Anastasia's comments. Please take a look at the diagnostic to see if it is what we want.

Jun 20 2016, 11:39 AM
ashi1 added a comment to D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver.
Jun 20 2016, 11:37 AM

Jun 6 2016

ashi1 retitled D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver from to [OpenCL] Allow -cl-std and other standard -cl- options in driver.
Jun 6 2016, 10:29 AM

May 17 2016

ashi1 added a comment to D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type.

Xiuli, are you OK with this patch?

May 17 2016, 11:50 AM

May 9 2016

ashi1 updated the diff for D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type.

Modified the testcase. Tested this diff on clang-test and it passes.

May 9 2016, 1:12 PM
ashi1 updated the diff for D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type.

Added changes for comments from majnemer.

May 9 2016, 11:07 AM
ashi1 added a comment to D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type.
May 9 2016, 11:03 AM

Feb 26 2016

ashi1 updated the diff for D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type.

Revised with Xiuli Pan's comments.

Feb 26 2016, 12:13 PM
ashi1 added a reviewer for D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type: joey.
Feb 26 2016, 8:50 AM
ashi1 removed a reviewer for D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type: Anastasia.
Feb 26 2016, 8:38 AM
ashi1 added a comment to D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type.

Joey Gouly or Joey Korkames?

Feb 26 2016, 8:37 AM

Feb 24 2016

ashi1 retitled D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type from to [OpenCL]Allowing explicit conversion of "0" to event_t type.
Feb 24 2016, 12:04 PM