# Fri, Jun 17

LGTM

Fri, Jun 17, 3:29 PM · Restricted Project, Restricted Project
NathanielMcVicar added inline comments to D128088: [mlir][nvgpu] fix MSVC warning regarding left shift.
Fri, Jun 17, 1:46 PM · Restricted Project, Restricted Project

Thanks, I can push a 1-line change to fix.

Fri, Jun 17, 10:47 AM · Restricted Project, Restricted Project

This has caused a break in the Windows MLIR bot:

```614.601 [639/64/2749] Building CXX object tools\mlir\lib\Dialect\NVGPU\Transforms\CMakeFiles\obj.MLIRNVGPUTransforms.dir\OptimizeSharedMemory.cpp.obj
FAILED: tools/mlir/lib/Dialect/NVGPU/Transforms/CMakeFiles/obj.MLIRNVGPUTransforms.dir/OptimizeSharedMemory.cpp.obj ...
C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\lib\Dialect\NVGPU\Transforms\OptimizeSharedMemory.cpp(194): error C2220: the following warning is treated as an error
C:\buildbot\mlir-x64-windows-ninja\llvm-project\mlir\lib\Dialect\NVGPU\Transforms\OptimizeSharedMemory.cpp(194): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)```
Fri, Jun 17, 10:01 AM · Restricted Project, Restricted Project

# Mon, Jun 13

Removing the default: on the switch in isSingleCondition broke the Windows bot, but unfortunately it was down so there was no timely notification. Sorry about that!
https://lab.llvm.org/buildbot/#/builders/13/builds/21881

Mon, Jun 13, 5:57 PM · Restricted Project, Restricted Project

# Tue, May 31

NathanielMcVicar updated the diff for D126575: [ccache] Add Windows support.

Fix merge base

Tue, May 31, 4:58 PM · Restricted Project, Restricted Project
NathanielMcVicar updated the diff for D126575: [ccache] Add Windows support.

Tue, May 31, 4:57 PM · Restricted Project, Restricted Project
Tue, May 31, 12:23 PM · Restricted Project, Restricted Project
NathanielMcVicar updated the diff for D126683: [windows] Remove unused pybind exception params.

clang-format

Tue, May 31, 9:27 AM · Restricted Project, Restricted Project
NathanielMcVicar updated the diff for D126683: [windows] Remove unused pybind exception params.

Fixed reference, I'm not clear why this isn't const, since unlike other pybind exceptions cast_error doesn't appear to be handled by Python.

Tue, May 31, 12:04 AM · Restricted Project, Restricted Project

# May 30 2022

NathanielMcVicar requested review of D126683: [windows] Remove unused pybind exception params.
May 30 2022, 10:58 PM · Restricted Project, Restricted Project

# May 27 2022

May 27 2022, 3:46 PM · Restricted Project, Restricted Project
NathanielMcVicar requested review of D126575: [ccache] Add Windows support.
May 27 2022, 3:44 PM · Restricted Project, Restricted Project
May 27 2022, 10:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

# Apr 15 2022

NathanielMcVicar added a comment to D122531: [MLIR] Fix operation clone.

I posted this on the commit, sorry! Meant to do it here.
This appears to have broken a number of tests on the Windows buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/19731

`LLVM ERROR: TypeID::get<`anonymous-namespace'::ClonePass>(): Using TypeID on a class with an anonymous namespace requires an explicit TypeID definition. The implicit fallback uses string name, which does not guarantee uniqueness in anonymous contexts. Define an explicit TypeID instantiation for this type using `MLIR_DECLARE_EXPLICIT_TYPE_ID`/`MLIR_DEFINE_EXPLICIT_TYPE_ID` or `DEFINE_EXPLICIT_PRIVATE_INLINE_TYPE_ID`.`
Apr 15 2022, 12:03 PM · Restricted Project, Restricted Project
NathanielMcVicar added a comment to rGed499ddcdaa6: [MLIR] Fix operation clone.

This appears to have broken a number of tests on the Windows buildbot: https://lab.llvm.org/buildbot/#/builders/13/builds/19731

`LLVM ERROR: TypeID::get<`anonymous-namespace'::ClonePass>(): Using TypeID on a class with an anonymous namespace requires an explicit TypeID definition. The implicit fallback uses string name, which does not guarantee uniqueness in anonymous contexts. Define an explicit TypeID instantiation for this type using `MLIR_DECLARE_EXPLICIT_TYPE_ID`/`MLIR_DEFINE_EXPLICIT_TYPE_ID` or `DEFINE_EXPLICIT_PRIVATE_INLINE_TYPE_ID`.`
Apr 15 2022, 12:02 PM · Restricted Project, Restricted Project

# Apr 13 2022

NathanielMcVicar added a comment to D123474: [mlir][pdll] Add extra-dirs for LSP includes..

This is causing failures on the Windows builbot: https://lab.llvm.org/buildbot/#/builders/13/builds/19626/steps/6/logs/stdio
I believe you simply need #include <string> to make MSVC happy.

Apr 13 2022, 10:21 AM · Restricted Project, Restricted Project

# Mar 23 2022

NathanielMcVicar updated the summary of D122333: [mlir][MemRef] Fix warning on unsigned comparison.
Mar 23 2022, 11:00 AM · Restricted Project, Restricted Project
NathanielMcVicar requested review of D122333: [mlir][MemRef] Fix warning on unsigned comparison.
Mar 23 2022, 10:48 AM · Restricted Project, Restricted Project

# Mar 22 2022

I believe this change produces a comparison warning with clang:

Mar 22 2022, 9:17 AM · Restricted Project, Restricted Project

# May 20 2021

That seems fairly ad-hoc as a fix: what are the conditions where this is a problem more precisely?

May 20 2021, 12:10 PM · Restricted Project

# May 19 2021

I believe this change causes the assert on the attribute SmallVector (for size >256) to hit when the size isn't specified on Windows debug builds.

May 19 2021, 2:46 PM · Restricted Project

# May 16 2021

Yes, the fix works! Thanks again.

May 16 2021, 9:29 PM · Restricted Project

# May 15 2021

Hi Lang,

May 15 2021, 10:12 PM · Restricted Project

# May 14 2021

I believe this change, or one of the subsequent ones (I can't find them on Differential, sorry), broke a test on the Windows Debug build.

May 14 2021, 6:24 PM · Restricted Project

# Apr 16 2021

NathanielMcVicar added a comment to D100657: [Support] Don't include <algorithm> in Hashing.h.

This broke the Windows MLIR buildbot, because algorithm is required for std::min in MSVC.
https://lab.llvm.org/buildbot/#/builders/13/builds/6985/steps/6/logs/stdio

Apr 16 2021, 9:14 AM · Restricted Project

# Mar 1 2021

It doesn't look like MSVC likes this use of type. Break in the buildbot here: https://lab.llvm.org/buildbot/#/builders/13/builds/5148. Thanks!

Mar 1 2021, 10:13 AM · Restricted Project

# Feb 9 2021

Could you please add #include<algorithm> for RunnerUtils.h? MSVC requires it for std::max/min, resulting in this http://lab.llvm.org:8011/#/builders/13/builds/4283/steps/6/logs/stdio failure. Thanks!

Feb 9 2021, 10:08 AM · Restricted Project

# Dec 1 2020

This appears to still be failing on VS2017 after the latest GCC5 fix (although builder is having some trouble, so I'll confirm). http://lab.llvm.org:8011/#/builders/13/builds/2128

Dec 1 2020, 6:05 PM · Restricted Project

# Oct 7 2020

I think there may be a small remaining issue on the llvmir-intrinsics.mlir test on Windows, as seen here: http://lab.llvm.org:8011/#/builders/82/builds/40/steps/7/logs/stdio

Oct 7 2020, 11:18 AM · Restricted Project, Restricted Project

# Jul 9 2020

(No need thanks, I setup a virtual environment)

Jul 9 2020, 9:21 AM · Restricted Project

# Jul 8 2020

Unfortunately, this still produces a cryptic error on VS2017:

Jul 8 2020, 2:31 PM · Restricted Project

# Jun 12 2020

Jun 12 2020, 4:34 PM · Restricted Project

# Jun 11 2020

The Windows failure and GCC failure look the same.

Jun 11 2020, 9:24 PM · Restricted Project

# Jun 10 2020

I believe this change may have broken the Windows buildbot, here: http://lab.llvm.org:8011/builders/mlir-windows/builds/3068

Jun 10 2020, 5:47 PM · Restricted Project

# May 29 2020

I believe this change broke the windows buildbot as well, just as an additional data point. http://lab.llvm.org:8011/builders/mlir-windows/builds/2485

```1025.187 [461/64/2346] Building CXX object tools\mlir\lib\Dialect\Linalg\Transforms\CMakeFiles\obj.MLIRLinalgTransforms.dir\Loops.cpp.obj
FAILED: tools/mlir/lib/Dialect/Linalg/Transforms/CMakeFiles/obj.MLIRLinalgTransforms.dir/Loops.cpp.obj
C:\PROGRA~2\MICROS~1\2017\COMMUN~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe  /nologo /TP -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=1 -DMLIR_ROCM_CONVERSIONS_ENABLED=1 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\mlir\lib\Dialect\Linalg\Transforms -IE:\build_slave\mlir-x64-windows-ninja\llvm-project\mlir\lib\Dialect\Linalg\Transforms -Iinclude -IE:\build_slave\mlir-x64-windows-ninja\llvm-project\llvm\include -IE:\build_slave\mlir-x64-windows-ninja\llvm-project\mlir\include -Itools\mlir\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2    /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Fotools\mlir\lib\Dialect\Linalg\Transforms\CMakeFiles\obj.MLIRLinalgTransforms.dir\Loops.cpp.obj /Fdtools\mlir\lib\Dialect\Linalg\Transforms\CMakeFiles\obj.MLIRLinalgTransforms.dir\ /FS -c E:\build_slave\mlir-x64-windows-ninja\llvm-project\mlir\lib\Dialect\Linalg\Transforms\Loops.cpp
E:\build_slave\mlir-x64-windows-ninja\llvm-project\mlir\include\mlir/IR/PatternMatch.h(192): error C2664: 'mlir::LogicalResult mlir::OpRewritePattern<mlir::vector::TransferWriteOp>::match(SourceOp) const': cannot convert argument 1 from 'SourceOp' to 'mlir::Operation *'
with
[
SourceOp=mlir::vector::TransferWriteOp
]
E:\build_slave\mlir-x64-windows-ninja\llvm-project\mlir\include\mlir/IR/PatternMatch.h(192): note: use of undefined type 'mlir::vector::TransferWriteOp'
E:\build_slave\mlir-x64-windows-ninja\llvm-project\mlir\include\mlir/Dialect/Linalg/Transforms/Transforms.h(20): note: see declaration of 'mlir::vector::TransferWriteOp'```
May 29 2020, 11:27 AM · Restricted Project

# May 19 2020

NathanielMcVicar added a comment to D80152: Added a TanOp to SPIR-V dialect GLSL ops.

I believe this change broke the build on the Windows VS2017 buildbot, http://lab.llvm.org:8011/builders/mlir-windows/builds/2042. It's not obvious to me why it would generate deeply nested code. Any thoughts? Thanks!

May 19 2020, 10:22 AM · Restricted Project

# Apr 17 2020

NathanielMcVicar added a comment to D73967: Implement _ExtInt as an extended int type specifier..

I didn't see that on any of the buildbots, where did you see it?

Apr 17 2020, 4:59 PM · Restricted Project
NathanielMcVicar added a comment to D73967: Implement _ExtInt as an extended int type specifier..

I believe this change pushes clang\lib\Sema\SemaTemplateDeduction.cpp over the 16-bit COFF section limit for Windows Debug builds. Could you please resolve it or add /bigobj to the CMakeFile file for MSVC (see clang\lib\CodeGen\CMakeLists.txt). ERROR C1128 Thanks!

Apr 17 2020, 3:11 PM · Restricted Project

# Mar 27 2020

Hey Brooks, do you have a public buildbot so I can try to fix it? What generator are you using?

Mar 27 2020, 3:59 PM · Restricted Project

# Mar 26 2020

Mar 26 2020, 10:17 AM · Restricted Project

This patch resolved the issue for our VS build. Thanks! Unfortunately, I don't have any way to test it for Xcode. Should I still accept the revision?

Mar 26 2020, 9:45 AM · Restricted Project

# Mar 16 2020

Mar 16 2020, 3:18 PM · Restricted Project

That changed the error to following. In cases like this is better to move the discussion to the latest update, or keep it here? Thanks!

Mar 16 2020, 1:07 PM · Restricted Project

I think part of this change may have broken the Windows build. Sorry for not being able to be more specific or catching it sooner. I'll be more on top of this once the buildbot moves over to the loud master.

Mar 16 2020, 12:01 PM · Restricted Project

# Mar 11 2020

The mlir-check target passes with MS C++ 19.24.28319 (except for the known failure). If there is another test that would be helpful on Windows let me know.

Mar 11 2020, 5:35 PM · Restricted Project

# Mar 6 2020

Let me know if that fixes it for you.

Mar 6 2020, 8:54 PM · Restricted Project

This appears to break the VisualStudio build for MSVC++ 14.16

Mar 6 2020, 6:12 PM · Restricted Project