Page MenuHomePhabricator
Feed Advanced Search

Wed, Jul 21

jeanPerier accepted D106294: [flang] Implement the runtime portion of the UNPACK intrinsic.

LGTM

Wed, Jul 21, 4:07 AM · Restricted Project, Restricted Project

Tue, Jul 20

jeanPerier accepted D106297: [flang] Run-time derived type initialization and destruction.

Looks great

Tue, Jul 20, 1:20 AM · Restricted Project, Restricted Project
jeanPerier added inline comments to D106294: [flang] Implement the runtime portion of the UNPACK intrinsic.
Tue, Jul 20, 1:14 AM · Restricted Project, Restricted Project
jeanPerier accepted D106292: [flang] Implement the runtime portion of the CSHIFT intrinsic.
Tue, Jul 20, 1:00 AM · Restricted Project, Restricted Project

Mon, Jul 19

jeanPerier accepted D106170: [flang] Runtime API for data pointers.

LGTM

Mon, Jul 19, 2:22 AM · Restricted Project, Restricted Project

Wed, Jul 7

jeanPerier added a comment to D105500: [flang] Prevent rewrite of shape inquiries to non constant explicit expr.

Are there any clients of these APIs that should have the new flag arguments set to "true"?

Wed, Jul 7, 1:00 PM · Restricted Project, Restricted Project
jeanPerier committed rGc2d4d6a1fde1: [flang] Create HostAssocDetails symbols when needed for mis-parsed ArrayRef (authored by jeanPerier).
[flang] Create HostAssocDetails symbols when needed for mis-parsed ArrayRef
Wed, Jul 7, 1:08 AM
jeanPerier closed D105464: [flang] Create HostAssocDetails symbols when needed for mis-parsed ArrayRef.
Wed, Jul 7, 1:08 AM · Restricted Project, Restricted Project
jeanPerier updated the diff for D105500: [flang] Prevent rewrite of shape inquiries to non constant explicit expr.

Fix typo in comments.

Wed, Jul 7, 12:45 AM · Restricted Project, Restricted Project

Tue, Jul 6

jeanPerier requested review of D105500: [flang] Prevent rewrite of shape inquiries to non constant explicit expr.
Tue, Jul 6, 10:12 AM · Restricted Project, Restricted Project
jeanPerier updated the diff for D105464: [flang] Create HostAssocDetails symbols when needed for mis-parsed ArrayRef.

Fix typo in comment.

Tue, Jul 6, 8:05 AM · Restricted Project, Restricted Project
jeanPerier requested review of D105464: [flang] Create HostAssocDetails symbols when needed for mis-parsed ArrayRef.
Tue, Jul 6, 1:05 AM · Restricted Project, Restricted Project

Mon, Jun 28

jeanPerier accepted D104930: [flang] Implement user-defined derived type runtime I/O.

Code looks great to me !

Mon, Jun 28, 1:34 AM · Restricted Project, Restricted Project

Jun 21 2021

jeanPerier accepted D104562: [flang] Fold more reduction intrinsic function calls.

Looks good

Jun 21 2021, 1:31 AM · Restricted Project, Restricted Project
jeanPerier added a comment to D104586: [flang] Update Reshape runtime library routine and its corresponding unit test.

Looks good to me.

Jun 21 2021, 1:19 AM · Restricted Project, Restricted Project

Jun 18 2021

jeanPerier accepted D104485: [flang] Runtime implementation for default derived type formatted I/O.

LGTM

Jun 18 2021, 5:27 AM · Restricted Project, Restricted Project

Jun 17 2021

jeanPerier committed rG1a4af2e45ee5: [flang] preserve symbol in DescriptorInquiry (authored by jeanPerier).
[flang] preserve symbol in DescriptorInquiry
Jun 17 2021, 3:42 AM
jeanPerier closed D104385: [flang] preserve symbol in DescriptorInquiry.
Jun 17 2021, 3:42 AM · Restricted Project, Restricted Project

Jun 16 2021

jeanPerier requested review of D104385: [flang] preserve symbol in DescriptorInquiry.
Jun 16 2021, 7:47 AM · Restricted Project, Restricted Project
jeanPerier accepted D104337: [flang] Fold MAXVAL & MINVAL.
Jun 16 2021, 2:46 AM · Restricted Project, Restricted Project
jeanPerier accepted D104339: [flang] Implement runtime for IALL & IANY.

LGTM

Jun 16 2021, 2:39 AM · Restricted Project, Restricted Project
jeanPerier accepted D104338: [flang] Use a "double-double" accumulator in SUM.

LGTM

Jun 16 2021, 2:33 AM · Restricted Project, Restricted Project
jeanPerier accepted D104336: [flang] Cope with errors with array constructors.

LGTM

Jun 16 2021, 2:31 AM · Restricted Project, Restricted Project

Jun 15 2021

jeanPerier accepted D104290: [flang] Check there's no dependency on C++ libs.

Looks like a good idea to me to have this test, thanks !

Jun 15 2021, 8:04 AM · Restricted Project, Restricted Project

Jun 14 2021

jeanPerier accepted D104100: [flang] Add clang-tidy check for braces around if.

tco, fir-opt and bbc tools are lowering tools, so they currently use llvm style.

Jun 14 2021, 7:25 AM · Restricted Project, Restricted Project

Jun 11 2021

jeanPerier accepted D104019: [flang] Add initial implementation for CPU_TIME.

LGTM, thanks !

Jun 11 2021, 1:28 AM · Restricted Project, Restricted Project

Jun 8 2021

jeanPerier accepted D103805: [flang] Define the runtime API for CPU_TIME.

LGTM

Jun 8 2021, 2:00 AM · Restricted Project, Restricted Project

Jun 4 2021

jeanPerier accepted D103654: [flang] CheckConformance: tristate-ify result.

LGTM

Jun 4 2021, 5:40 AM · Restricted Project, Restricted Project
jeanPerier committed rG1971960a6fed: [flang] Generate type info symbols outside of derived type scopes (authored by jeanPerier).
[flang] Generate type info symbols outside of derived type scopes
Jun 4 2021, 5:39 AM
jeanPerier closed D103621: [flang] Generate type info symbols outside of derived type scopes.
Jun 4 2021, 5:39 AM · Restricted Project, Restricted Project

Jun 3 2021

jeanPerier requested review of D103621: [flang] Generate type info symbols outside of derived type scopes.
Jun 3 2021, 8:31 AM · Restricted Project, Restricted Project
jeanPerier accepted D103580: [flang] Fix spurious "already declared" errors for interfaces.
Jun 3 2021, 6:04 AM · Restricted Project, Restricted Project
jeanPerier accepted D103571: [flang] Support known constant lengths in DynamicType.

Looks good to me

Jun 3 2021, 6:01 AM · Restricted Project, Restricted Project
jeanPerier accepted D103560: [flang] Check for duplicate definitions of defined input/output procedures.

Looks good to me

Jun 3 2021, 5:56 AM · Restricted Project, Restricted Project
jeanPerier accepted D103568: [flang] Fix folding of CMPLX.
Jun 3 2021, 5:49 AM · Restricted Project, Restricted Project

May 25 2021

jeanPerier accepted D103098: [flang] Fix recent regression (proc. dummy arg on ENTRY).

LGTM, thanks

May 25 2021, 9:32 AM · Restricted Project, Restricted Project

May 20 2021

jeanPerier committed rG943839870a0b: [flang] simplify derived type info table format (authored by jeanPerier).
[flang] simplify derived type info table format
May 20 2021, 9:28 AM
jeanPerier closed D102768: [flang] simplify derived type info table format.
May 20 2021, 9:28 AM · Restricted Project, Restricted Project
jeanPerier updated the diff for D102768: [flang] simplify derived type info table format.

DEREF only the false part of introduced ternary.

May 20 2021, 9:22 AM · Restricted Project, Restricted Project

May 19 2021

jeanPerier requested review of D102768: [flang] simplify derived type info table format.
May 19 2021, 6:25 AM · Restricted Project, Restricted Project

May 17 2021

jeanPerier accepted D102652: [flang] Implement MATMUL in the runtime.

LGTM

May 17 2021, 11:51 PM · Restricted Project, Restricted Project

May 13 2021

jeanPerier accepted D102351: [flang] Implement DOT_PRODUCT in the runtime.

LGTM

May 13 2021, 6:25 AM · Restricted Project, Restricted Project

May 11 2021

jeanPerier accepted D102210: [flang] Allow large and erroneous ac-implied-do's.
May 11 2021, 4:36 AM · Restricted Project, Restricted Project

May 6 2021

jeanPerier accepted D101928: [flang] Fix race condition in runtime.

The fix looks in line with the issue reported by @rogfer01 and what he suggested.

May 6 2021, 1:23 AM · Restricted Project, Restricted Project
jeanPerier accepted D101929: [flang] Runtime must defer formatted/unformatted determination.

LGTM

May 6 2021, 12:48 AM · Restricted Project, Restricted Project

Apr 19 2021

jeanPerier accepted D100599: [flang] Define missing & needed IEEE_ARITHMETIC symbols.

LGTM

Apr 19 2021, 8:36 AM · Restricted Project, Restricted Project

Apr 13 2021

jeanPerier accepted D100421: [flang] Handle END= situations better in runtime input.
Apr 13 2021, 11:58 PM · Restricted Project, Restricted Project
jeanPerier accepted D100419: [flang] Fix Boolean flag arguments.
Apr 13 2021, 11:53 PM · Restricted Project, Restricted Project

Apr 12 2021

jeanPerier accepted D100323: [flang] Correct TypeCode::IsLogical().

LGTM

Apr 12 2021, 10:52 AM · Restricted Project, Restricted Project

Apr 9 2021

jeanPerier accepted D100064: [flang] RANDOM_NUMBER, RANDOM_SEED, RANDOM_INIT in runtime.

LGTM

Apr 9 2021, 12:33 AM · Restricted Project, Restricted Project

Apr 8 2021

jeanPerier accepted D100067: [flang] Check for conflicting BIND(C) names.

LGTM

Apr 8 2021, 12:38 AM · Restricted Project, Restricted Project
jeanPerier accepted D100065: [flang] Enforce a limit on recursive PDT instantiations.

LGTM

Apr 8 2021, 12:12 AM · Restricted Project, Restricted Project

Apr 7 2021

jeanPerier accepted D99967: [Flang] Changes to mangling code.
Apr 7 2021, 2:21 AM · Restricted Project

Apr 1 2021

jeanPerier accepted D99666: [flang] Implement reductions in the runtime.

LGTM, thanks for implementing all these so fast !

Apr 1 2021, 1:40 AM · Restricted Project, Restricted Project

Mar 25 2021

jeanPerier committed rG27899112c698: [flang] fold LOGICAL intrinsic calls (authored by jeanPerier).
[flang] fold LOGICAL intrinsic calls
Mar 25 2021, 10:39 AM
jeanPerier closed D99346: [flang] fold LOGICAL intrinsic calls.
Mar 25 2021, 10:38 AM · Restricted Project, Restricted Project
jeanPerier requested review of D99346: [flang] fold LOGICAL intrinsic calls.
Mar 25 2021, 8:40 AM · Restricted Project, Restricted Project
jeanPerier committed rGffa455d4d451: [mlir] Translate global initializers after creating all LLVM IR globals (authored by jeanPerier).
[mlir] Translate global initializers after creating all LLVM IR globals
Mar 25 2021, 1:54 AM
jeanPerier closed D99246: [mlir] Translate global initializers after creating all LLVM IR globals.
Mar 25 2021, 1:54 AM · Restricted Project
jeanPerier added inline comments to D99246: [mlir] Translate global initializers after creating all LLVM IR globals.
Mar 25 2021, 1:39 AM · Restricted Project
jeanPerier updated the diff for D99246: [mlir] Translate global initializers after creating all LLVM IR globals.

Rename dropGlobalInitializer to shouldDropGlobalInitializer.

Mar 25 2021, 1:38 AM · Restricted Project
jeanPerier added a comment to D99296: [flang] Fix runtime crash on TRIM('').

Regarding CFI_establish, the Fortran standard says in 18.5.5.5 about elem_len :

Mar 25 2021, 1:19 AM · Restricted Project, Restricted Project

Mar 24 2021

jeanPerier requested review of D99246: [mlir] Translate global initializers after creating all LLVM IR globals.
Mar 24 2021, 2:04 AM · Restricted Project
jeanPerier accepted D99208: [flang] Save binding labels as strings.

LGTM, thanks that will make the lowering part cleaner.

Mar 24 2021, 1:33 AM · Restricted Project, Restricted Project

Mar 16 2021

jeanPerier committed rG92d27b969ae1: [flang] Save AllocateObject and PointerObject analyzed expression (authored by jeanPerier).
[flang] Save AllocateObject and PointerObject analyzed expression
Mar 16 2021, 2:30 AM
jeanPerier closed D98256: [flang] Save AllocateObject and PointerObject analyzed expression.
Mar 16 2021, 2:30 AM · Restricted Project, Restricted Project

Mar 15 2021

jeanPerier added inline comments to D98256: [flang] Save AllocateObject and PointerObject analyzed expression.
Mar 15 2021, 8:02 AM · Restricted Project, Restricted Project
jeanPerier accepted D98553: [flang] Runtime: implement INDEX intrinsic function.

LGTM

Mar 15 2021, 1:16 AM · Restricted Project, Restricted Project

Mar 11 2021

jeanPerier updated the summary of D98256: [flang] Save AllocateObject and PointerObject analyzed expression.
Mar 11 2021, 4:51 AM · Restricted Project, Restricted Project
jeanPerier updated the diff for D98256: [flang] Save AllocateObject and PointerObject analyzed expression.

Move the typedExpr setting in expression analysis. Update dump and unparse to use
the typed expression. Add a HasTypeExpr<T> helper to better share the logic when that
is possible and easy.

Mar 11 2021, 4:46 AM · Restricted Project, Restricted Project

Mar 10 2021

jeanPerier accepted D98283: [flang][fir] Upstream changes to the pre-FIR tree.

You may want to apply the clang-tidy hints about const auto ([llvm-qualified-auto]), otherwise LGTM and builds ok for me.

Mar 10 2021, 5:36 AM · Restricted Project, Restricted Project

Mar 9 2021

jeanPerier added a comment to D98256: [flang] Save AllocateObject and PointerObject analyzed expression.
Mar 9 2021, 9:58 AM · Restricted Project, Restricted Project
jeanPerier requested review of D98256: [flang] Save AllocateObject and PointerObject analyzed expression.
Mar 9 2021, 6:16 AM · Restricted Project, Restricted Project

Mar 4 2021

jeanPerier accepted D97996: [flang][fir] Add diagnostic tests for FIR ops verifier.

Thanks !

Mar 4 2021, 10:21 PM · Restricted Project

Mar 1 2021

jeanPerier accepted D97580: [flang] Runtime: SCAN and VERIFY.

Logic looks good to me. Please take care of the Pre-merge checks if they make sense.

Mar 1 2021, 12:40 AM · Restricted Project, Restricted Project

Feb 25 2021

jeanPerier accepted D97421: [flang][fir] Add array value operations..

Looks good to me.

Feb 25 2021, 12:13 PM · Restricted Project, Restricted Project

Feb 24 2021

jeanPerier committed rGb146dfe527ba: [flang] add attribute to trim runtime implementation establish call (authored by jeanPerier).
[flang] add attribute to trim runtime implementation establish call
Feb 24 2021, 9:55 AM
jeanPerier closed D97395: [flang] add attribute to trim runtime implementation establish call.
Feb 24 2021, 9:54 AM · Restricted Project, Restricted Project
jeanPerier requested review of D97395: [flang] add attribute to trim runtime implementation establish call.
Feb 24 2021, 8:47 AM · Restricted Project, Restricted Project
jeanPerier accepted D97331: [flang][fir] Add zero_bits operation..
Feb 24 2021, 12:44 AM · Restricted Project, Restricted Project

Feb 23 2021

jeanPerier abandoned D97189: [flang][NFC] Add source line to TODO message.

Duplicate of D97190.

Feb 23 2021, 12:07 AM · Restricted Project
jeanPerier committed rG36ea1cac1a42: [flang][NFC] Add source line to lowering TODO messages (authored by jeanPerier).
[flang][NFC] Add source line to lowering TODO messages
Feb 23 2021, 12:02 AM
jeanPerier closed D97190: [flang][NFC] Add source line to lowering TODO messages.
Feb 23 2021, 12:02 AM · Restricted Project, Restricted Project

Feb 22 2021

jeanPerier requested review of D97190: [flang][NFC] Add source line to lowering TODO messages.
Feb 22 2021, 5:36 AM · Restricted Project, Restricted Project
jeanPerier requested review of D97189: [flang][NFC] Add source line to TODO message.
Feb 22 2021, 5:17 AM · Restricted Project

Feb 19 2021

jeanPerier accepted D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.

Thanks for the refactoring. Looks good to me.

Feb 19 2021, 9:36 AM · Restricted Project

Feb 11 2021

jeanPerier accepted D96362: [flang][fir] Update the kind mapping class..
Feb 11 2021, 9:17 AM · Restricted Project, Restricted Project

Feb 9 2021

jeanPerier accepted D96172: [flang][fir] Add shape, shape_shift, and slice types..
Feb 9 2021, 1:26 AM · Restricted Project, Restricted Project

Feb 7 2021

jeanPerier accepted D96183: [flang][fir] Update FIR's character type..
Feb 7 2021, 11:23 PM · Restricted Project

Feb 2 2021

jeanPerier accepted D95828: [flang][NFC] Update #include and comment..
Feb 2 2021, 3:45 AM · Restricted Project, Restricted Project

Feb 1 2021

jeanPerier accepted D95751: [flang][NFC] Rename complex type..
Feb 1 2021, 4:05 AM · Restricted Project, Restricted Project

Jan 22 2021

jeanPerier accepted D94716: [flang] Correct shape analysis for transformational intrinsic functions.

Looks good to me.

Jan 22 2021, 9:42 AM · Restricted Project, Restricted Project

Jan 8 2021

jeanPerier accepted D94017: [flang] Fix bogus message on internal subprogram with alternate return.

Looks good to me, thanks Pete.

Jan 8 2021, 12:36 AM · Restricted Project, Restricted Project

Jan 7 2021

jeanPerier requested changes to D94017: [flang] Fix bogus message on internal subprogram with alternate return.

@schweitz, as I understand things, the current lowering code gets the value of alternate return labels from the parse tree. Do you plan to change that once their available in the values of the ActualArgument?

That would make sens IMHO.
Otherwise, the change you have should work OK with lowering, except for the ProcedureRef hasAlternateReturns that is now wrong and would make lowering fail (see inlined comment).

Jan 7 2021, 4:42 AM · Restricted Project, Restricted Project

Dec 16 2020

jeanPerier accepted D93321: [flang] Fix crash in folding (#48437).

Looks good to me

Dec 16 2020, 1:03 AM · Restricted Project, Restricted Project

Dec 8 2020

jeanPerier accepted D92802: [flang] Implement derived type description table encoding.
Dec 8 2020, 9:26 AM · Restricted Project, Restricted Project

Nov 16 2020

jeanPerier accepted D91443: [flang] Unsplit COMPLEX operations.

Looks good to me.

Nov 16 2020, 3:33 AM · Restricted Project, Restricted Project

Nov 12 2020

jeanPerier accepted D91215: [flang] Implement runtime support for basic ALLOCATE/DEALLOCATE.

Thanks, looks good to me.

Nov 12 2020, 10:12 AM · Restricted Project, Restricted Project
jeanPerier added inline comments to D91215: [flang] Implement runtime support for basic ALLOCATE/DEALLOCATE.
Nov 12 2020, 6:54 AM · Restricted Project, Restricted Project

Nov 10 2020

jeanPerier accepted D91213: [flang] Add isnan() extension intrinsic function, with folding.

Looks good to me

Nov 10 2020, 11:35 PM · Restricted Project, Restricted Project