Page MenuHomePhabricator
Feed Advanced Search

Yesterday

wmi created D66374: [SampleFDO] Add symbol whitelist in the profile and use it when profile-sample-accurate is enabled.
Fri, Aug 16, 4:56 PM · Restricted Project
wmi added inline comments to D66191: [AutoFDO] Make call targets order deterministic for sample profil.
Fri, Aug 16, 4:34 PM · Restricted Project

Thu, Aug 15

wmi added a comment to D66191: [AutoFDO] Make call targets order deterministic for sample profil.

Thanks for working on it.

Thu, Aug 15, 10:39 AM · Restricted Project

Tue, Aug 13

wmi added a comment to D66013: [X86] Emit correct unwind info for split-stack prologue.

I see. You already take the adjustment in insertCFIInstrs into consideration and assume the CFIs in the layout order will match CFIs in control flow in the end. In this way, .cfi_remember_state at the beginning of current BB is always assumed to remember the outgoing CFI information of its predecessor BB.

Tue, Aug 13, 3:29 PM · Restricted Project
wmi added inline comments to D66013: [X86] Emit correct unwind info for split-stack prologue.
Tue, Aug 13, 12:36 PM · Restricted Project
wmi added a comment to D66013: [X86] Emit correct unwind info for split-stack prologue.

I suspect there is some problem caused by interaction of .cfi_remember_state/.cfi_restore_state and CFIInstrInserter pass.

Tue, Aug 13, 11:53 AM · Restricted Project

Mon, Aug 12

wmi added a reviewer for D66013: [X86] Emit correct unwind info for split-stack prologue: djokov.
Mon, Aug 12, 10:07 AM · Restricted Project
wmi added a comment to D32201: [RALLOC] Increase CSR cost in RegAllocGreedy to favour splitting over CSR first use.

Should this good patch be rebased and continued to move on? @wmi
it'd be better to move on this work because D27366 is abandoned and D34608 is not updated for a long time, and those 3 patches are all trying to fix same issue and not landed successfully.
It would be great If it can land.

Mon, Aug 12, 9:34 AM · Restricted Project
wmi accepted D65848: [ThinLTO][AutoFDO] Fix memory corruption due to race condition from thin backends.

LGTM.

Mon, Aug 12, 8:40 AM · Restricted Project

Thu, Aug 8

wmi added a comment to D65848: [ThinLTO][AutoFDO] Fix memory corruption due to race condition from thin backends.

Thanks for the change.

Thu, Aug 8, 12:28 PM · Restricted Project
wmi added a comment to D65848: [ThinLTO][AutoFDO] Fix memory corruption due to race condition from thin backends.

Thanks for working on the issue.

Thu, Aug 8, 8:44 AM · Restricted Project

Wed, Jul 31

wmi committed rGf49c107f06c6: [DAGCombine] Limit the number of times for the same store and root nodes to… (authored by wmi).
[DAGCombine] Limit the number of times for the same store and root nodes to…
Wed, Jul 31, 1:00 PM
wmi committed rL367472: [DAGCombine] Limit the number of times for the same store and root nodes.
[DAGCombine] Limit the number of times for the same store and root nodes
Wed, Jul 31, 12:59 PM
wmi closed D65174: [DAGCombine] Limit the number of times for a store being considered for merging.
Wed, Jul 31, 12:59 PM · Restricted Project
wmi added a comment to D65174: [DAGCombine] Limit the number of times for a store being considered for merging.

Nirav, thanks for all the suggestions and quick responses!

Wed, Jul 31, 11:59 AM · Restricted Project
wmi updated the diff for D65174: [DAGCombine] Limit the number of times for a store being considered for merging.

Address Nirav's comment.

Wed, Jul 31, 11:32 AM · Restricted Project
wmi added inline comments to D65174: [DAGCombine] Limit the number of times for a store being considered for merging.
Wed, Jul 31, 11:32 AM · Restricted Project
wmi updated the diff for D65174: [DAGCombine] Limit the number of times for a store being considered for merging.

Address Nirav's comment.

Wed, Jul 31, 10:40 AM · Restricted Project
wmi added a comment to D65174: [DAGCombine] Limit the number of times for a store being considered for merging.

Thanks for the suggestions. I will update patch immediately. Please see if it matches what is in your mind.

Wed, Jul 31, 10:35 AM · Restricted Project

Tue, Jul 30

wmi updated the diff for D65174: [DAGCombine] Limit the number of times for a store being considered for merging.

Address Nirav's comment.

Tue, Jul 30, 8:43 PM · Restricted Project
wmi added a comment to D65174: [DAGCombine] Limit the number of times for a store being considered for merging.

Thanks Nirav. I update the patch. Please take a look.

Tue, Jul 30, 8:40 PM · Restricted Project
wmi committed rG888efda2808c: [DAGCombiner] Add an option to control whether or not to enable store merging. (authored by wmi).
[DAGCombiner] Add an option to control whether or not to enable store merging.
Tue, Jul 30, 4:16 PM
wmi committed rL367365: [DAGCombiner] Add an option to control whether or not to enable store merging..
[DAGCombiner] Add an option to control whether or not to enable store merging.
Tue, Jul 30, 4:16 PM
wmi closed D65482: [DAGCombiner] Add an option to control whether or not to enable store merging.
Tue, Jul 30, 4:15 PM · Restricted Project, Restricted Project
wmi created D65482: [DAGCombiner] Add an option to control whether or not to enable store merging.
Tue, Jul 30, 3:38 PM · Restricted Project, Restricted Project
wmi added a comment to D65174: [DAGCombine] Limit the number of times for a store being considered for merging.

It may not be easy for us to prune the searching space without missing some merging opportunity. I feel it is easier to achieve that goal by controlling how many times a {RootNode, StoreNode} pair appear in candidate set repeatedly. With the patch, no bit change in the binaries were found for clang and some large application. So the current patch is a safe change.

True. But my concern is that as we prune the search space, we will introduce burrs in the which will be extremely hard to find and notice. I agree that its' not worth it to solve it the ideal way, but if a quick to write but safe pruning of the search space happens to work we should go with that. If not, it's likely it'll be too hard to resolve better than a heuristics. The scheme here is fine modulo the following concerns:

  1. If it's really an issue with the candidate dependence check, we should move the RootStoreCountMap update be modified in the dependency search, not the candidate check. This shouldn't dramatically change the run time.
  2. The RootNode is effectively a function of the candidate store. We really should only have a single RootNode so it'd be better as a map from SDNode* to (SDNode*, int).
Tue, Jul 30, 9:45 AM · Restricted Project

Mon, Jul 29

wmi added a comment to D65174: [DAGCombine] Limit the number of times for a store being considered for merging.

Ah. That's a tricky one. It sounds like this isn't a case of the candidate stores not being mergable, but rather us giving up before we completely verify that.

I don't suppose the values in the indirect value operands to the candidate stores have a relatively short dependence on a node not too far from the RootNode. Right now, we only prune at the root node (and components through the TokenFactors). but we could also just mark further predecessors of the RootNode as not needing to be searched.

Mon, Jul 29, 2:47 PM · Restricted Project
wmi added a comment to D65174: [DAGCombine] Limit the number of times for a store being considered for merging.

Recently we run into a case with compile time problem (27 mins in O3 but a few seconds in O0). In that case, we have a huge block containing many stores. Each time a store is visited, dagcombiner will find a candidate set all chained by the same root node for the store, then try to merge the nodes in the candidate set into a wider store. This is a quadratic algorithm, because for the same candidate set, everytime a store inside of the set is visited, the same set will be considered for merging.

Could you share the test case? I looked into a similar issue and came up with some sort of caching for the lookup. I never shared the patch, because we addressed the issue with a limit. But it might be helpful for your case.

Mon, Jul 29, 12:49 PM · Restricted Project
wmi added a comment to D65174: [DAGCombine] Limit the number of times for a store being considered for merging.

I check and the reason the candidates cannot be merged isn't because of the legal size. It is that checkMergeStoreCandidatesForDependencies always returns false so https://reviews.llvm.org/D60133 doesn't help.

Ah! Interesting. I've only seen that dependence triggered from inlined memcpy.

What's the shape of the DAG here? There must be some non-standard data dependence between stores, which is not being checked. Maybe we can change the candidate search to avoid such candidates.

Mon, Jul 29, 12:45 PM · Restricted Project
wmi added a comment to D65174: [DAGCombine] Limit the number of times for a store being considered for merging.

Thanks for pointing me to D60133.

Mon, Jul 29, 11:23 AM · Restricted Project

Fri, Jul 26

wmi committed rG55a68a24003a: [JumpThreading] Stop searching predecessor when the current bb is in a… (authored by wmi).
[JumpThreading] Stop searching predecessor when the current bb is in a…
Fri, Jul 26, 2:03 PM
wmi committed rL367154: [JumpThreading] Stop searching predecessor when the current bb is in a.
[JumpThreading] Stop searching predecessor when the current bb is in a
Fri, Jul 26, 1:59 PM
wmi closed D65310: [JumpThreading] In updatePredecessorProfileMetadata, stop searching predecessor when the current bb is an unreachable single bb loop .
Fri, Jul 26, 1:59 PM · Restricted Project
wmi updated the diff for D65310: [JumpThreading] In updatePredecessorProfileMetadata, stop searching predecessor when the current bb is an unreachable single bb loop .

Address Eli's comment.

Fri, Jul 26, 12:15 PM · Restricted Project

Thu, Jul 25

wmi updated the diff for D65310: [JumpThreading] In updatePredecessorProfileMetadata, stop searching predecessor when the current bb is an unreachable single bb loop .

Address Eli's comment.

Thu, Jul 25, 7:18 PM · Restricted Project
wmi added a comment to D65310: [JumpThreading] In updatePredecessorProfileMetadata, stop searching predecessor when the current bb is an unreachable single bb loop .

Is there any reason to expect that unreachable loops have exactly one block?

Thu, Jul 25, 7:18 PM · Restricted Project
wmi created D65310: [JumpThreading] In updatePredecessorProfileMetadata, stop searching predecessor when the current bb is an unreachable single bb loop .
Thu, Jul 25, 5:03 PM · Restricted Project

Wed, Jul 24

wmi accepted D65162: [llvm-profdata] Profile dump for compact binary format.

LGTM. Thanks!

Wed, Jul 24, 1:52 PM · Restricted Project
wmi added a comment to D65162: [llvm-profdata] Profile dump for compact binary format.

Thanks for the patch.

Wed, Jul 24, 9:25 AM · Restricted Project

Tue, Jul 23

wmi created D65174: [DAGCombine] Limit the number of times for a store being considered for merging.
Tue, Jul 23, 4:59 PM · Restricted Project
wmi added a comment to D63671: [llvm-profdata] Avoid keeping reference to every files.

From my last reply "I assumed the input files are small since we want to have small testcase. If the input files are small, the buffer won't be allocated through mmap but through new (From getOpenFileImpl in lib/Support/MemoryBuffer.cpp)".

Tue, Jul 23, 11:54 AM · Restricted Project

Mon, Jul 22

wmi added a comment to D65099: [New Pass Manager] Invalidate ScalarEvolutionAnalysis at some time to reduce peak memory consumption.

This is not ready for review yet. I just upload the patch for some people's reference and discussion.

Mon, Jul 22, 9:27 AM · Restricted Project
wmi created D65099: [New Pass Manager] Invalidate ScalarEvolutionAnalysis at some time to reduce peak memory consumption.
Mon, Jul 22, 9:27 AM · Restricted Project

Jul 3 2019

wmi added a comment to D63671: [llvm-profdata] Avoid keeping reference to every files.
In D63671#1565126, @wmi wrote:
In D63671#1563092, @wmi wrote:

Add one test case.

Thanks. If we remove the code to replace string reference from file data buffer to FunctionNames set for call targets, will the test fail?

No, because this change is kind of a NFC, which implies that I want to keep the same behaviors as previously.
To actually have a test that fails if we remove this code, we would need to have a super heavy and time consuming test, which is, imo, not what we want for a test.

Do we really need to have a tests that fails if we remove this code ?

Is it possible to add an option to flush the file data buffer with 0 after the file is released? The option is only enabled for testing. With the option on, even with small test we can catch some difference in merge result if the patch is incorrect.

Jul 3 2019, 12:25 PM · Restricted Project

Jul 1 2019

wmi added a comment to D63671: [llvm-profdata] Avoid keeping reference to every files.
In D63671#1563092, @wmi wrote:

Add one test case.

Thanks. If we remove the code to replace string reference from file data buffer to FunctionNames set for call targets, will the test fail?

No, because this change is kind of a NFC, which implies that I want to keep the same behaviors as previously.
To actually have a test that fails if we remove this code, we would need to have a super heavy and time consuming test, which is, imo, not what we want for a test.

Do we really need to have a tests that fails if we remove this code ?

Jul 1 2019, 11:08 AM · Restricted Project

Jun 28 2019

wmi added a comment to D63671: [llvm-profdata] Avoid keeping reference to every files.

Add one test case.

Jun 28 2019, 3:45 PM · Restricted Project

Jun 21 2019

wmi added a comment to D63671: [llvm-profdata] Avoid keeping reference to every files.

We had better have a test for it. It is not a strict NFC and we best verify it works as we expect -- like if we miss any place which still uses StringRef refering to string in file data buffer, we may have dangling pointer after we free the buffer.

Jun 21 2019, 3:59 PM · Restricted Project

May 29 2019

wmi accepted D62535: [ThinLTO] Use original alias visibility when importing.

LGTM.

May 29 2019, 8:44 AM · Restricted Project

May 28 2019

wmi added a comment to D62540: [SampleFDO] For functions without profiles, provide an option to put them in a special text section.

Why is symbol remapping an issue? old MD5 --> input symbol name -> output symbol name --> mapped MD5sum ?

May 28 2019, 4:11 PM · Restricted Project
wmi added a comment to D62540: [SampleFDO] For functions without profiles, provide an option to put them in a special text section.

what is the main blocker for the longer term solution?

May 28 2019, 3:39 PM · Restricted Project
wmi added a comment to D62540: [SampleFDO] For functions without profiles, provide an option to put them in a special text section.

Longer term, the plan is to put a white list of the symbols into the profile data so that the compiler can decide if a function is newly created or simply cold.

Wei, if that is in place, is there a need for this patch?

May 28 2019, 2:59 PM · Restricted Project
wmi created D62540: [SampleFDO] For functions without profiles, provide an option to put them in a special text section.
May 28 2019, 11:41 AM · Restricted Project

May 22 2019

wmi accepted D62109: [RegisterCoalescer] fix potential use of undef value. NFC.

LGTM. Thanks for fixing that.

May 22 2019, 9:54 AM · Restricted Project

Apr 23 2019

wmi added a reviewer for D60088: [GlobalOpt][SampleFDO] Add an option to control whether to rename alias target: eraman.
Apr 23 2019, 10:26 AM · Restricted Project

Apr 22 2019

wmi committed rG01f8d556aa72: [PGO/SamplePGO][NFC] Move the function updateProfWeight from Instruction to… (authored by wmi).
[PGO/SamplePGO][NFC] Move the function updateProfWeight from Instruction to…
Apr 22 2019, 10:03 AM
wmi committed rL358900: [PGO/SamplePGO][NFC] Move the function updateProfWeight from Instruction.
[PGO/SamplePGO][NFC] Move the function updateProfWeight from Instruction
Apr 22 2019, 10:03 AM
wmi closed D60911: [PGO/SamplePGO][NFC] Move the function updateProfWeight from Instruction to CallInst.
Apr 22 2019, 10:02 AM · Restricted Project
wmi added a comment to D60911: [PGO/SamplePGO][NFC] Move the function updateProfWeight from Instruction to CallInst.

Run internal FDO testing and the speedup is within expected range.

Apr 22 2019, 8:30 AM · Restricted Project

Apr 19 2019

wmi created D60911: [PGO/SamplePGO][NFC] Move the function updateProfWeight from Instruction to CallInst.
Apr 19 2019, 11:57 AM · Restricted Project
wmi added a comment to D60903: [SampleFDO] Never set profile entry count to 0.

Looked at the Instruction::updateProfWeight() --- the part that update branch_weights seems bogus -- there is need need to scale branch weight at all.

VP data needs to be scaled of course, but if 'S' or 'T' is zero, just zero them out.

Apr 19 2019, 10:35 AM · Restricted Project
wmi added a comment to D60903: [SampleFDO] Never set profile entry count to 0.

Seems we did that all the time even before https://reviews.llvm.org/rL352001 (Since rL352001, we did the update even in sample profile loader pass, when we found cold inline instance was not inlined by sample profile loader). Here is the code snippet before the refactoring involved in rL352001.

Apr 19 2019, 10:19 AM · Restricted Project
wmi added a comment to D60903: [SampleFDO] Never set profile entry count to 0.

It is possible to for an entry with zero count -- as for instance in instrumentation PGO. Should it be fixed in place where the div by zero happens?

Apr 19 2019, 9:49 AM · Restricted Project
wmi created D60903: [SampleFDO] Never set profile entry count to 0.
Apr 19 2019, 9:10 AM · Restricted Project

Apr 3 2019

wmi added a comment to D57591: fix weights for promoted indirect calls.

No major improvement or regression was found in our test.

Apr 3 2019, 10:06 AM · Restricted Project
wmi accepted D59835: [ProfileSummary] Count callsite samples when computing total samples..

Did the test. No major improvement or regression was found. LGTM.

Apr 3 2019, 10:06 AM · Restricted Project

Apr 2 2019

wmi added a comment to D60086: [SampleProfile] Check entry count instead of total count to decide if inlined callsite is hot..

@wmi Thank you for the concrete example! I think what we need for your example is context-sensitive profiling and function specialization, not inlining. Admittedly we don't have an infrastructure in LLVM to support context-sensitive profiling for non-inlined case and we don't perform context sensitive function specialization...

Again, my bigger concern is with using PSI->isHotCount to check the function hotness. If we want to stay with the function total count based heuristic, wouldn't it make more sense if we have something like ProfileSummaryInfo::isFunctionHotInCallGraph, which actually checks the hotness of the function itself, and use it?

Apr 2 2019, 4:20 PM · Restricted Project
wmi added a comment to D60086: [SampleProfile] Check entry count instead of total count to decide if inlined callsite is hot..

I can understand the value of context-sensitive profile information, but wouldn't it be only valuable if the callsite is actually worth inlining?

Apr 2 2019, 3:12 PM · Restricted Project
wmi added a comment to D60086: [SampleProfile] Check entry count instead of total count to decide if inlined callsite is hot..

@wmi Thanks for the reply! I can totally understand that entry count is not as precise as total count, but still don't think current implementation is the right way to address the issue. As I mentioned in the summary it compares two different things (instruction level counter vs function level counter), opens up a possibility for optimizing against wrong function (e.g. long and cold function), and makes it hard to find the root cause of the performance issue.

If we can't have a precise entry count, the right way to address the issue would be not using PSI based heuristic but using a heuristic that actually considers a total count of the function.

Apr 2 2019, 10:20 AM · Restricted Project
wmi added a comment to D59835: [ProfileSummary] Count callsite samples when computing total samples..

That is a reasonable change to me. Thanks. However it probably needs some careful performance evaluation since some tuning may be needed for that change. I will do that in our benchmarks. How does this change on performance look like on your side?

Apr 2 2019, 9:44 AM · Restricted Project
wmi added a comment to D57591: fix weights for promoted indirect calls.

That is a good improvement. Thanks! I will evaluate how much impact it will have in our benchmarks.

Apr 2 2019, 9:29 AM · Restricted Project

Apr 1 2019

wmi added a comment to D60086: [SampleProfile] Check entry count instead of total count to decide if inlined callsite is hot..

Theorectically, as you said checking entry sample count rather than the total sample count makes more sense. However, the entry sample count of callsite is not as precise as function sample entry count, which is got from lbr directly. For callsite, it can get very wrong entry sample count because of missing debug information after optimization. That is why we chose total sample count instead of entry sample count when evaluating the hotness of callsite.

Apr 1 2019, 4:30 PM · Restricted Project
wmi accepted D59940: [SampleProfile] Repeat indirect call promotion only when the target is actually hot..

Thanks! The change makes a lot sense to me.

Apr 1 2019, 4:13 PM · Restricted Project
wmi accepted D59078: memcpy is not tailcalled.

LGTM.

Apr 1 2019, 2:50 PM
wmi created D60088: [GlobalOpt][SampleFDO] Add an option to control whether to rename alias target.
Apr 1 2019, 12:09 PM · Restricted Project

Mar 27 2019

wmi added a comment to D59869: [NewPM] Fix a nasty bug with analysis invalidation in the new PM..

Thanks for the detailed answer for how to make the choices!

Mar 27 2019, 4:05 PM · Restricted Project
wmi added a comment to D59869: [NewPM] Fix a nasty bug with analysis invalidation in the new PM..

Thanks for working on the patch which will fix several build failures found internally! I believe the patch is already after a lot of balancing, and here are just some questions out of curiousity.

Mar 27 2019, 2:27 PM · Restricted Project

Mar 11 2019

wmi accepted D58832: [SampleFDO] add suffix elision control for fcn names.

LGTM. Thanks for working on it!

Mar 11 2019, 2:34 PM · Restricted Project
wmi added inline comments to D58832: [SampleFDO] add suffix elision control for fcn names.
Mar 11 2019, 11:56 AM · Restricted Project

Mar 8 2019

wmi added a comment to D58832: [SampleFDO] add suffix elision control for fcn names.
In D58832#1422205, @wmi wrote:

We need function attribute only when we want to use different strategies for different functions. Do we need the function granularity control over the suffix elision policy?

We want to be able to eventually support ThinLTO in which you have a mix of C and Go functions (it is fairly common for Go programs to call out into C code). Without such a change we'd have to pick one policy or another and hope that it works for code generated by every front end.

Mar 8 2019, 4:16 PM · Restricted Project
wmi added inline comments to D59143: [RegisterCoalescer] Limit the number of joins for large live interval with many valnos. .
Mar 8 2019, 3:34 PM · Restricted Project
wmi committed rG98214347c4ac: Rename a local variable counter to Counter. (authored by wmi).
Rename a local variable counter to Counter.
Mar 8 2019, 3:32 PM
wmi committed rL355759: Rename a local variable counter to Counter..
Rename a local variable counter to Counter.
Mar 8 2019, 3:32 PM
wmi committed rGfb9693d1c9cc: [RegisterCoalescer][NFC] bind a DenseMap access to a reference to avoid… (authored by wmi).
[RegisterCoalescer][NFC] bind a DenseMap access to a reference to avoid…
Mar 8 2019, 3:29 PM
wmi committed rL355757: [RegisterCoalescer][NFC] bind a DenseMap access to a reference to avoid.
[RegisterCoalescer][NFC] bind a DenseMap access to a reference to avoid
Mar 8 2019, 3:29 PM
wmi committed rG72ec6801b5b2: [RegisterCoalescer] Limit the number of joins for large live interval with many… (authored by wmi).
[RegisterCoalescer] Limit the number of joins for large live interval with many…
Mar 8 2019, 11:27 AM
wmi committed rL355714: [RegisterCoalescer] Limit the number of joins for large live interval with.
[RegisterCoalescer] Limit the number of joins for large live interval with
Mar 8 2019, 11:25 AM
wmi closed D59143: [RegisterCoalescer] Limit the number of joins for large live interval with many valnos. .
Mar 8 2019, 11:25 AM · Restricted Project
wmi added a comment to D59143: [RegisterCoalescer] Limit the number of joins for large live interval with many valnos. .

Thanks for the fast response!

Mar 8 2019, 10:46 AM · Restricted Project
wmi created D59143: [RegisterCoalescer] Limit the number of joins for large live interval with many valnos. .
Mar 8 2019, 10:32 AM · Restricted Project

Mar 7 2019

wmi added a comment to D58832: [SampleFDO] add suffix elision control for fcn names.

We need function attribute only when we want to use different strategies for different functions. Do we need the function granularity control over the suffix elision policy?

Mar 7 2019, 3:27 PM · Restricted Project

Feb 28 2019

wmi accepted D58589: [ConstantHoisting] Call cleanup() in ConstantHoistingPass::runImpl to avoid dangling elements in ConstIntInfoVec for new PM.

LGTM

Feb 28 2019, 9:23 PM · Restricted Project

Feb 27 2019

wmi added inline comments to D58589: [ConstantHoisting] Call cleanup() in ConstantHoistingPass::runImpl to avoid dangling elements in ConstIntInfoVec for new PM.
Feb 27 2019, 2:51 PM · Restricted Project

Feb 20 2019

wmi committed rG500606f270ff: [Inliner] Pass nullptr for the ORE param of getInlineCost if RemarkEnabled is… (authored by wmi).
[Inliner] Pass nullptr for the ORE param of getInlineCost if RemarkEnabled is…
Feb 20 2019, 6:59 PM
wmi committed rL354542: [Inliner] Pass nullptr for the ORE param of getInlineCost if RemarkEnabled.
[Inliner] Pass nullptr for the ORE param of getInlineCost if RemarkEnabled
Feb 20 2019, 6:58 PM
wmi closed D58399: [Inliner] Don't initialize ComputeFullInlineCost to be always true because of ORE.
Feb 20 2019, 6:58 PM · Restricted Project
wmi added a comment to D58399: [Inliner] Don't initialize ComputeFullInlineCost to be always true because of ORE.

Thanks for the review!

Feb 20 2019, 6:45 PM · Restricted Project

Feb 19 2019

wmi updated the diff for D58399: [Inliner] Don't initialize ComputeFullInlineCost to be always true because of ORE.

Add a TODO comment.

Feb 19 2019, 6:44 PM · Restricted Project
wmi updated the diff for D58399: [Inliner] Don't initialize ComputeFullInlineCost to be always true because of ORE.

Address Chandler's comment.

Feb 19 2019, 6:39 PM · Restricted Project
wmi added inline comments to D58399: [Inliner] Don't initialize ComputeFullInlineCost to be always true because of ORE.
Feb 19 2019, 6:38 PM · Restricted Project
wmi updated the diff for D58399: [Inliner] Don't initialize ComputeFullInlineCost to be always true because of ORE.

Address Easwaran and Chandler's comments.

Feb 19 2019, 4:26 PM · Restricted Project