Page MenuHomePhabricator
Feed Advanced Search

Mar 8 2016

khemant added a comment to D17822: llvm-readobj: enable GNU style -g option.
Mar 8 2016, 10:42 AM
khemant updated the diff for D17822: llvm-readobj: enable GNU style -g option.

Suggestion by Rafael incorporated:
Changed auto to ArrayRef<Elf_Word>
Removed while() {} and used range based loops.

Mar 8 2016, 10:41 AM

Mar 4 2016

khemant added a comment to D17822: llvm-readobj: enable GNU style -g option.

Ping

Mar 4 2016, 1:27 PM

Mar 2 2016

khemant retitled D17822: llvm-readobj: enable GNU style -g option from to llvm-readobj: enable GNU style -g option.
Mar 2 2016, 11:03 AM

Mar 1 2016

khemant updated the diff for D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files.

Removed unneeded typedefs in base class and any to_string that was operand to << operator of raw_ostream.

Mar 1 2016, 3:06 PM
khemant added inline comments to D16820: Implement common symbol size calculation in llvm-size.
Mar 1 2016, 2:38 PM
khemant added inline comments to D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files.
Mar 1 2016, 2:35 PM
khemant added a comment to D16820: Implement common symbol size calculation in llvm-size.

Ping

Mar 1 2016, 1:37 PM
khemant added a comment to D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files.

Ping.

Mar 1 2016, 1:37 PM

Feb 26 2016

khemant updated the diff for D16820: Implement common symbol size calculation in llvm-size.

Changed test case.

Feb 26 2016, 3:21 PM
khemant updated the diff for D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files.

Updated to reflect changes requested by Bigcheese

Feb 26 2016, 1:34 PM

Feb 25 2016

khemant committed rL261927: Reverts change r261907 and r261918.
Reverts change r261907 and r261918
Feb 25 2016, 12:51 PM
khemant committed rL261918: Fix endianness issue on BE machines introduced by r261907.
Fix endianness issue on BE machines introduced by r261907
Feb 25 2016, 11:00 AM
khemant committed rL261907: [llvm-readobj] Enable GNU style sections and relocations printing.
[llvm-readobj] Enable GNU style sections and relocations printing
Feb 25 2016, 10:06 AM

Feb 23 2016

khemant added inline comments to D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files.
Feb 23 2016, 3:49 PM
khemant updated the diff for D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files.

Addressed comments noted in previous patch. Please re-accept this version.

Feb 23 2016, 3:47 PM
khemant added inline comments to D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files.
Feb 23 2016, 3:40 PM

Feb 22 2016

khemant retitled D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files from to llvm-readobj: enable GNU output style sections and relocations printing for ELF files.
Feb 22 2016, 2:42 PM

Feb 10 2016

khemant committed rL260484: Fix const confusion while lambda function usage.
Fix const confusion while lambda function usage
Feb 10 2016, 7:46 PM
khemant committed rL260471: Fix build failure caused in r260430.
Fix build failure caused in r260430
Feb 10 2016, 4:06 PM
khemant committed rL260464: Make llvm-nm test consistent with other tests.
Make llvm-nm test consistent with other tests
Feb 10 2016, 3:33 PM
khemant committed rL260430: [llvm-readobj] Option to emit readelf like output.
[llvm-readobj] Option to emit readelf like output
Feb 10 2016, 12:45 PM
khemant committed rL260397: Revert "[llvm-readobj] Option to emit readelf like output".
Revert "[llvm-readobj] Option to emit readelf like output"
Feb 10 2016, 10:25 AM
khemant added a comment to D16820: Implement common symbol size calculation in llvm-size.

This change needs update to test case after Rafael's rework on previous patch.

Feb 10 2016, 10:07 AM
khemant committed rL260392: [llvm-nm] Add -radix option.
[llvm-nm] Add -radix option
Feb 10 2016, 9:56 AM
khemant closed D16822: llvm-nm: Add -radix option by committing rL260392: [llvm-nm] Add -radix option.
Feb 10 2016, 9:56 AM
khemant committed rL260391: [llvm-readobj] Option to emit readelf like output.
[llvm-readobj] Option to emit readelf like output
Feb 10 2016, 9:55 AM
khemant closed D14128: Enable readobj to emit readelf like output. by committing rL260391: [llvm-readobj] Option to emit readelf like output.
Feb 10 2016, 9:55 AM

Feb 9 2016

khemant added a comment to D14128: Enable readobj to emit readelf like output..

Added enum

Feb 9 2016, 1:53 PM
khemant updated the diff for D14128: Enable readobj to emit readelf like output..

Add enum instead of a bool.

Feb 9 2016, 1:52 PM
khemant added inline comments to D14128: Enable readobj to emit readelf like output..
Feb 9 2016, 12:52 PM

Feb 8 2016

khemant added inline comments to D14128: Enable readobj to emit readelf like output..
Feb 8 2016, 3:08 PM
khemant updated the diff for D14128: Enable readobj to emit readelf like output..

Thank you echristo for comments. Modified as per your comments

Feb 8 2016, 3:08 PM

Feb 5 2016

khemant added a comment to D16822: llvm-nm: Add -radix option.

I will modify the test to have source instead of binary and assemble it.

Feb 5 2016, 2:00 PM

Feb 2 2016

khemant retitled D16822: llvm-nm: Add -radix option from Add -radix option to llvm-nm: Add -radix option.
Feb 2 2016, 2:02 PM
khemant retitled D16822: llvm-nm: Add -radix option from to Add -radix option.
Feb 2 2016, 2:02 PM
khemant closed D16816: Calculate correct section sizes for llvm-size.

Committed r259578

Feb 2 2016, 1:51 PM
khemant committed rL259578: Correct size calculations for ELF files.
Correct size calculations for ELF files
Feb 2 2016, 1:46 PM
khemant retitled D16820: Implement common symbol size calculation in llvm-size from to Implement common symbol size calculation in llvm-size.
Feb 2 2016, 1:19 PM
khemant added a comment to D16816: Calculate correct section sizes for llvm-size.
Feb 2 2016, 12:52 PM
khemant updated the diff for D16816: Calculate correct section sizes for llvm-size.
Feb 2 2016, 12:51 PM
khemant added a comment to D16816: Calculate correct section sizes for llvm-size.

Binutils size outputs similar to BSD. It discounts these sections as well

Feb 2 2016, 11:57 AM
khemant retitled D16816: Calculate correct section sizes for llvm-size from to Calculate correct section sizes for llvm-size.
Feb 2 2016, 11:23 AM
khemant added a comment to D14128: Enable readobj to emit readelf like output..

Ping!

Feb 2 2016, 11:11 AM

Jan 27 2016

khemant added inline comments to D14128: Enable readobj to emit readelf like output..
Jan 27 2016, 9:32 AM

Jan 26 2016

khemant committed rL258856: Fix comparison warning (r258845).
Fix comparison warning (r258845)
Jan 26 2016, 12:42 PM
khemant committed rL258854: Fixes build break introduced by r258845.
Fixes build break introduced by r258845
Jan 26 2016, 12:32 PM
khemant committed rL258845: [llvm-readobj] Add -elf-section-groups option.
[llvm-readobj] Add -elf-section-groups option
Jan 26 2016, 11:50 AM
khemant closed D16555: llvm-readobj: Display section group information in ELF files by committing rL258845: [llvm-readobj] Add -elf-section-groups option.
Jan 26 2016, 11:50 AM

Jan 25 2016

khemant updated the diff for D14128: Enable readobj to emit readelf like output..
Jan 25 2016, 1:58 PM
khemant retitled D16555: llvm-readobj: Display section group information in ELF files from to llvm-readobj: Display section group information in ELF files.
Jan 25 2016, 1:16 PM

Jan 14 2016

khemant added inline comments to D15740: [mips] Add SHF_MIPS_GPREL flag to the MIPS .sbss and .sdata sections.
Jan 14 2016, 11:24 AM

Jan 8 2016

khemant added a reviewer for D14128: Enable readobj to emit readelf like output.: ruiu.
Jan 8 2016, 2:48 PM

Jan 6 2016

khemant added a comment to D14128: Enable readobj to emit readelf like output..

Any comments/suggestions? Is this patch a good start for readelf like output format?

Jan 6 2016, 2:08 PM
khemant updated the diff for D14128: Enable readobj to emit readelf like output..

Updated to use Formatted stream. Adds the string used by readelf for enums.

Jan 6 2016, 11:16 AM

Jan 5 2016

khemant added inline comments to D14128: Enable readobj to emit readelf like output..
Jan 5 2016, 9:19 AM

Dec 22 2015

khemant set the repository for D14128: Enable readobj to emit readelf like output. to rL LLVM.
Dec 22 2015, 9:30 AM

Dec 21 2015

khemant updated the diff for D14128: Enable readobj to emit readelf like output..
Dec 21 2015, 2:39 PM

Dec 16 2015

khemant added a comment to D14128: Enable readobj to emit readelf like output..

Instead of conditionals I think you might just want to abstract out the dumping mechanism as well.

Can you explain this a bit more.

Dec 16 2015, 11:40 AM

Nov 11 2015

khemant committed rL252812: Fix docs build break for revision r252798.
Fix docs build break for revision r252798
Nov 11 2015, 2:17 PM
khemant committed rL252798: [Symbolizer]: Add -pretty-print option.
[Symbolizer]: Add -pretty-print option
Nov 11 2015, 12:44 PM
khemant closed D13671: Add -pretty-print option to llvm-symbolizer by committing rL252798: [Symbolizer]: Add -pretty-print option.
Nov 11 2015, 12:44 PM
khemant committed rL252779: Test commit after password reset.
Test commit after password reset
Nov 11 2015, 11:26 AM
khemant committed rL252760: [Symbolizer]: Add -pretty-print option.
[Symbolizer]: Add -pretty-print option
Nov 11 2015, 9:50 AM

Nov 10 2015

khemant updated the diff for D13671: Add -pretty-print option to llvm-symbolizer.
Nov 10 2015, 2:52 PM
khemant updated the diff for D13671: Add -pretty-print option to llvm-symbolizer.

Camelcased all variables.

Nov 10 2015, 12:24 PM

Nov 9 2015

khemant updated the diff for D13671: Add -pretty-print option to llvm-symbolizer.
Nov 9 2015, 9:49 AM
khemant added a comment to D13671: Add -pretty-print option to llvm-symbolizer.

Done with the changes.

Nov 9 2015, 9:44 AM
khemant updated the diff for D13671: Add -pretty-print option to llvm-symbolizer.
Nov 9 2015, 9:43 AM

Nov 5 2015

khemant updated the diff for D13671: Add -pretty-print option to llvm-symbolizer.

Did some clean up.

Nov 5 2015, 10:23 AM

Nov 4 2015

khemant updated the diff for D13671: Add -pretty-print option to llvm-symbolizer.

Changed for new design.

Nov 4 2015, 2:30 PM
khemant added a comment to D13671: Add -pretty-print option to llvm-symbolizer.

I was looking at it at this very moment.

Nov 4 2015, 11:43 AM

Oct 29 2015

khemant added a comment to D13671: Add -pretty-print option to llvm-symbolizer.

I can wait till you re-factor the code. When are you planning to merge the patch that has SymbolizableObjectFile ?

Oct 29 2015, 10:55 AM
khemant updated subscribers of D14099: [LLVMSymbolize] Move ModuleInfo into a separate class (SymbolizableModule)..
Oct 29 2015, 10:44 AM
khemant updated subscribers of D13671: Add -pretty-print option to llvm-symbolizer.
Oct 29 2015, 10:17 AM
khemant updated subscribers of D14128: Enable readobj to emit readelf like output..
Oct 29 2015, 10:17 AM
khemant added a comment to D14128: Enable readobj to emit readelf like output..

My browser submitted the comment before completion. Apologies.
Here is complete comment:
What I have noticed is all enums are made to string as is in the LLVM style. However, GNU has different naming conventions such as "W" instead of SHF_WRITE string as is. This will cause a lot of code bloat. An easy solution is to store GNU flavor of string with usual string inside

template<typename T>
struct EnumEntry {
  StringRef Name;
  T Value;
};

Any thoughts on this?

Oct 29 2015, 10:17 AM
khemant added a comment to D14128: Enable readobj to emit readelf like output..

What I have noticed is All enums are made to string as is in the LLVM style. However, GNU has different naming conventions such as "W" instead of SHF_WRITE string as is. This will cause a lot of code bloat. An easy solution is to store GNU flavor of string with usuale string inside

Oct 29 2015, 10:15 AM
khemant added a comment to D14128: Enable readobj to emit readelf like output..

Hello Davide,
The present format is good enough to convey the information. It is however not sufficient or sometimes difficult for present users of GNU tools (which are quite ubiquitous) to make a switch as it is complete redesign of the post processing tools they may have based on.

Oct 29 2015, 8:54 AM

Oct 27 2015

khemant retitled D14128: Enable readobj to emit readelf like output. from to Enable readobj to emit readelf like output..
Oct 27 2015, 12:15 PM

Oct 22 2015

khemant updated the diff for D13671: Add -pretty-print option to llvm-symbolizer.
Oct 22 2015, 10:01 AM

Oct 16 2015

khemant added a reviewer for D13671: Add -pretty-print option to llvm-symbolizer: rafael.
Oct 16 2015, 12:05 PM

Oct 15 2015

khemant added a comment to D13671: Add -pretty-print option to llvm-symbolizer.

Comments?

Oct 15 2015, 10:17 AM

Oct 12 2015

khemant abandoned D10221: Add addr2line aliases for symbolizer.
Oct 12 2015, 1:33 PM
khemant retitled D13671: Add -pretty-print option to llvm-symbolizer from to Add -pretty-print option to llvm-symbolizer.
Oct 12 2015, 1:31 PM
khemant committed rL250086: [llvm-symbolizer] Add -print-address option.
[llvm-symbolizer] Add -print-address option
Oct 12 2015, 12:28 PM
khemant closed D13518: Add -address option to symbolizer by committing rL250086: [llvm-symbolizer] Add -print-address option.
Oct 12 2015, 12:28 PM
khemant committed rL250067: [llvm-symbolizer] Add -print-address option.
[llvm-symbolizer] Add -print-address option
Oct 12 2015, 10:33 AM

Oct 9 2015

khemant updated the diff for D13518: Add -address option to symbolizer.

Option is handled inside main. Source is present as comment in test case.

Oct 9 2015, 12:58 PM
khemant added a comment to D13518: Add -address option to symbolizer.

You are right. I did not pay much attention to the driver.

Oct 9 2015, 12:50 PM

Oct 8 2015

khemant added a reviewer for D13518: Add -address option to symbolizer: emaste.
Oct 8 2015, 10:02 AM

Oct 7 2015

khemant added a reviewer for D13518: Add -address option to symbolizer: samsonov.
Oct 7 2015, 12:43 PM
khemant retitled D13518: Add -address option to symbolizer from to Add -address option to symbolizer.
Oct 7 2015, 10:23 AM

Jun 3 2015

khemant added a comment to D10221: Add addr2line aliases for symbolizer.

Sure. We could add them.

Jun 3 2015, 12:23 PM
khemant added a reviewer for D10221: Add addr2line aliases for symbolizer: rafael.
Jun 3 2015, 10:54 AM
khemant retitled D10221: Add addr2line aliases for symbolizer from to Add addr2line aliases for symbolizer.
Jun 3 2015, 10:50 AM