Page MenuHomePhabricator
Feed Advanced Search

Yesterday

luismarques added inline comments to D80690: [RISCV] Support libunwind for riscv32.
Sat, May 30, 4:12 AM · Restricted Project, Restricted Project

Thu, May 28

luismarques added inline comments to D80465: [RISCV-V] Provide muldi3 builtins for riscv.
Thu, May 28, 8:07 AM
luismarques accepted D80465: [RISCV-V] Provide muldi3 builtins for riscv.

LGTM. But please give it some time for other people to chime in before you merge, they may disagree with this .inc approach.
I'm approving this assuming the generic test is actually ran against this implementation. @kamleshbhalui did you verify that was the case?

Thu, May 28, 8:06 AM
luismarques added inline comments to D80690: [RISCV] Support libunwind for riscv32.
Thu, May 28, 1:02 AM · Restricted Project, Restricted Project

Wed, May 27

luismarques added a comment to D80465: [RISCV-V] Provide muldi3 builtins for riscv.

When I said earlier that you should provide a muldi3 test I was saying that under the impression that there wasn't one already. It seems that there is already a target-indepent test. Sorry about that. My point was that the test did NOT have to be RISC-V specific. The generic test is gated on librt_has_muldi3. For that to work with lit automatically, your implementation files have to have the correct name. See compiler-rt/test/builtins/CMakeLists.txt, specifically the comment saying "hexagon/udivsi3.S" => "udivsi3". Others can comment on what is the best/cleanest way forward:

Wed, May 27, 11:24 PM
luismarques requested changes to D80465: [RISCV-V] Provide muldi3 builtins for riscv.

I think it would make sense to merge this with the mulsi3 implementation, since it's the same sequence of instructions.
Like the mulsi3_test.c, you should provide a test for this. The mulsi3_test.c was provided as a RISC-V-specific test, but there doesn't seem to be anything RISC-V specific in the test, so it should probably just be a generic test (hat tip to Alex Bradbury for noticing that). Likewise, the same would go for your muldi3 test.

Wed, May 27, 9:11 AM

Wed, May 13

luismarques updated the diff for D79690: [RISCV] Fold ADDIs into load/stores with nonzero offsets.

Rebase. Now also handles the case of ConstantPoolSDNode.

Wed, May 13, 5:54 AM · Restricted Project

Tue, May 12

luismarques added inline comments to D79770: [RISCV] Fix passing two floating-point values in complex separately by two GPRs on RV64 .
Tue, May 12, 2:07 AM · Restricted Project
luismarques added inline comments to D79635: [RISCV] Split the pseudo instruction splitting pass.
Tue, May 12, 1:02 AM · Restricted Project

Mon, May 11

luismarques added inline comments to D79689: [RISCV][NFC] Add tests for folds of ADDIs into load/stores.
Mon, May 11, 1:28 PM · Restricted Project
luismarques retitled D79689: [RISCV][NFC] Add tests for folds of ADDIs into load/stores from [RISCV] Add tests for folds of ADDIs into load/stores to [RISCV][NFC] Add tests for folds of ADDIs into load/stores.
Mon, May 11, 1:28 PM · Restricted Project
luismarques added inline comments to D79690: [RISCV] Fold ADDIs into load/stores with nonzero offsets.
Mon, May 11, 3:43 AM · Restricted Project

Sun, May 10

luismarques added a parent revision for D79690: [RISCV] Fold ADDIs into load/stores with nonzero offsets: D79689: [RISCV][NFC] Add tests for folds of ADDIs into load/stores.
Sun, May 10, 11:42 AM · Restricted Project
luismarques created D79690: [RISCV] Fold ADDIs into load/stores with nonzero offsets.
Sun, May 10, 11:42 AM · Restricted Project
luismarques added a child revision for D79689: [RISCV][NFC] Add tests for folds of ADDIs into load/stores: D79690: [RISCV] Fold ADDIs into load/stores with nonzero offsets.
Sun, May 10, 11:42 AM · Restricted Project
luismarques created D79689: [RISCV][NFC] Add tests for folds of ADDIs into load/stores.
Sun, May 10, 11:10 AM · Restricted Project

Fri, May 8

luismarques created D79635: [RISCV] Split the pseudo instruction splitting pass.
Fri, May 8, 10:10 AM · Restricted Project

Thu, May 7

luismarques added a comment to D79268: [RISCV] Implement Hooks to avoid chaining SELECT.

It might be a good idea to add more targetted tests for this. See llvm/test/CodeGen/PowerPC/no-pref-jumps.ll and some of the tests added in 940ab934d42.

Thu, May 7, 7:20 AM · Restricted Project
luismarques added a comment to D79492: [RISCV] Improve constant materialization.
In D79492#2024394, @asb wrote:
  1. I don't want to unreasonably expand the scope of this patch, but I do note that at least the srli transformation may be beneficial on RV32 as well for code size (still two instructions, but more compressible). Did you consider adding this or look at other RVC considerations?
  2. Although it has the advantage that mistakes in edge cases etc won't lead to regressions in terms of longer instruction sequences, I'm slightly wary of the "generate and see if it's shorter" approach. Though perhaps this is going to come way down the list on any compile-time profiling vs all the other analyses+transformations being done. Any thoughts on this?
Thu, May 7, 3:21 AM · Restricted Project

Wed, May 6

luismarques accepted D79523: [RISCV] Support Constant Pools in Load/Store Peephole.

LGTM. Nice to see this extraneous addi go!

Wed, May 6, 3:19 PM · Restricted Project
luismarques abandoned D68060: [RISCV] Materialization of 64-bit mask immediate.

This is superseded by D79492, which subsumes this special case with more general optimizations.

Wed, May 6, 12:25 PM · Restricted Project
luismarques committed rGa3e6e624c71d: [RISCV][NFC] Add more constant materialization tests (authored by luismarques).
[RISCV][NFC] Add more constant materialization tests
Wed, May 6, 8:36 AM
luismarques closed D79453: [RISCV][NFC] Add more constant materialization tests.
Wed, May 6, 8:35 AM · Restricted Project
luismarques created D79492: [RISCV] Improve constant materialization.
Wed, May 6, 8:02 AM · Restricted Project
luismarques updated the diff for D79453: [RISCV][NFC] Add more constant materialization tests.

Add one more test case.

Wed, May 6, 8:02 AM · Restricted Project
luismarques added inline comments to D78545: [RISCV] Make CanLowerReturn protected for downstream maintenance.
Wed, May 6, 7:29 AM · Restricted Project

Tue, May 5

luismarques created D79453: [RISCV][NFC] Add more constant materialization tests.
Tue, May 5, 4:12 PM · Restricted Project

May 1 2020

luismarques accepted D79267: [RISCV][NFC] Add Test for (select (or B1, B2), X, Y).
May 1 2020, 5:13 PM · Restricted Project
luismarques added a comment to D79267: [RISCV][NFC] Add Test for (select (or B1, B2), X, Y).

LGTM.

May 1 2020, 5:13 PM · Restricted Project
luismarques accepted D78908: [RISCV] Add patterns for checking isnan.

LGTM

May 1 2020, 5:12 PM · Restricted Project
luismarques accepted D78907: [RISCV][NFC] Add tests for checking isnan patterns.

LGTM. I would prefer a hardfloat ABI to make the test slightly cleaner.

May 1 2020, 5:12 PM · Restricted Project
luismarques accepted D79259: [RISCV][NFC] Tests for (select (const), (const)).

LGTM.

May 1 2020, 5:11 PM · Restricted Project
luismarques accepted D79260: [RISCV] Implement convertSelectOfConstantsToMath.

LGTM.

May 1 2020, 5:11 PM · Restricted Project

Apr 25 2020

luismarques closed D78456: [RISCV][PowerPC] Fix google/benchmark benchmark::cycleclock::Now.
Apr 25 2020, 7:56 AM

Apr 19 2020

luismarques created D78456: [RISCV][PowerPC] Fix google/benchmark benchmark::cycleclock::Now.
Apr 19 2020, 9:37 AM

Apr 18 2020

luismarques committed rGa348de480d34: [CMake][NFC] Clean up CheckAtomic.cmake (authored by luismarques).
[CMake][NFC] Clean up CheckAtomic.cmake
Apr 18 2020, 5:23 AM
luismarques closed D74767: [CMake][NFC] Clean up CheckAtomic.cmake.
Apr 18 2020, 5:23 AM · Restricted Project
luismarques added inline comments to D78364: [MC][Bugfix] Remove redundant parameter for relaxInstruction.
Apr 18 2020, 4:18 AM · Restricted Project
luismarques added inline comments to D78364: [MC][Bugfix] Remove redundant parameter for relaxInstruction.
Apr 18 2020, 3:45 AM · Restricted Project
luismarques committed rG60ce987bf31d: [RISCV][PowerPC] Fix google/benchmark benchmark::cycleclock::Now (authored by luismarques).
[RISCV][PowerPC] Fix google/benchmark benchmark::cycleclock::Now
Apr 18 2020, 1:36 AM
luismarques closed D78084: [RISCV][PowerPC] Fix google/benchmark benchmark::cycleclock::Now.
Apr 18 2020, 1:35 AM · Restricted Project

Apr 17 2020

luismarques updated the diff for D74767: [CMake][NFC] Clean up CheckAtomic.cmake.

Fix whitespace.

Apr 17 2020, 2:37 PM · Restricted Project
luismarques updated the diff for D78084: [RISCV][PowerPC] Fix google/benchmark benchmark::cycleclock::Now.

Merged the */README.LLVM change entries, as having separate entries for a single LLVM commit could be confusing.

Apr 17 2020, 2:04 PM · Restricted Project
luismarques updated the diff for D78084: [RISCV][PowerPC] Fix google/benchmark benchmark::cycleclock::Now.
  • Also apply a cherrypick that minimizes LLVM lint formatting issues;
  • List the cherrypicks in benchmark*/README.LLVM;
  • Update summary accordingly.
Apr 17 2020, 1:32 PM · Restricted Project

Apr 13 2020

luismarques created D78084: [RISCV][PowerPC] Fix google/benchmark benchmark::cycleclock::Now.
Apr 13 2020, 11:57 PM · Restricted Project
luismarques added a comment to D77912: [builtins] Make __umodsi3/__udivdi3/__umoddi3 standalone (shift and subtract).

OK. I benchmarked __udivsi3. That version is actually slightly faster than D77744. I moved that function to int_div_impl.inc

Apr 13 2020, 1:34 PM · Restricted Project
luismarques added a comment to D78021: [RISCV]: Adjust riscv64 GCC detector to also check for existence of crtbegin.o in the default multilib dir, like most other ports..

I think this makes sense and is correctly implemented but I would like other people to look at this.
It would also benefit from adding tests, rejecting the "minimally installed" scenario and accepting the proper install.

Apr 13 2020, 12:59 PM

Apr 4 2020

luismarques added a comment to D77443: [RISCV] Fix RISCVInstrInfo::getInstSizeInBytes for atomics pseudos.

Thanks for the fix Jessica.
Looking at, say, doAtomicBinOpExpansion it's not immediately obvious why some of those values are correct. Can you please provide more info, ideally in the code?
Is there really no way to provide tests for these?

Apr 4 2020, 1:49 PM · Restricted Project

Apr 2 2020

luismarques added a comment to D77018: [MC][RISCV] Make .reloc support arbitrary relocation types.

I think this looks good. I'll let @lenary have another look.

Apr 2 2020, 10:50 AM · Restricted Project

Mar 31 2020

luismarques added a comment to D77117: [RISCV] Split RISCVISelDAGToDAG.cpp to RISCVISelDAGToDAG.h and RISCVISelDAGToDAG.cpp.

For the downstream RISCV maintenance, it would be easier to inherent the RISCVISelDAGToDAG and only override the method need to customize for the custom provider ISA extension without touching RISCVISelDAGToDAG.cpp which may cause conflict when upgrading the downstream LLVM version.
I think it could be helpful for other RISCV downstream maintenance. Could it be the sufficient reason to split out the header?

Mar 31 2020, 10:33 AM · Restricted Project

Mar 26 2020

luismarques committed rGad1466f8cbc5: [sanitizer][RISCV] Implement SignalContext::GetWriteFlag for RISC-V (authored by luismarques).
[sanitizer][RISCV] Implement SignalContext::GetWriteFlag for RISC-V
Mar 26 2020, 1:03 PM
luismarques closed D75168: [sanitizer][RISCV] Implement SignalContext::GetWriteFlag for RISC-V.
Mar 26 2020, 1:03 PM · Restricted Project, Restricted Project
luismarques added inline comments to D76828: [RISC-V] Support __builtin_thread_pointer .
Mar 26 2020, 7:00 AM · Restricted Project
luismarques accepted D76828: [RISC-V] Support __builtin_thread_pointer .

LGTM. Thanks!

Mar 26 2020, 6:28 AM · Restricted Project
luismarques requested changes to D76828: [RISC-V] Support __builtin_thread_pointer .

Please add tests.

Mar 26 2020, 4:50 AM · Restricted Project

Mar 23 2020

luismarques updated the diff for D75168: [sanitizer][RISCV] Implement SignalContext::GetWriteFlag for RISC-V.

Fix copy paste issue in the updated patch.

Mar 23 2020, 8:08 AM · Restricted Project, Restricted Project
luismarques updated the diff for D75168: [sanitizer][RISCV] Implement SignalContext::GetWriteFlag for RISC-V.

Properly handle compressed reserved instructions.

Mar 23 2020, 7:36 AM · Restricted Project, Restricted Project
luismarques added a comment to D74767: [CMake][NFC] Clean up CheckAtomic.cmake.

Ping.

Mar 23 2020, 5:58 AM · Restricted Project

Mar 19 2020

luismarques added a comment to D74453: [LegalizeTypes][RISCV] Correctly sign-extend comparison for ATOMIC_CMP_XCHG.

Hey @jrtc27 . Is there anything blocking this patch being committed?

Mar 19 2020, 6:59 AM · Restricted Project

Mar 17 2020

luismarques accepted D75729: [RISCV] Select +0.0 immediate using fmv.{w,d}.x / fcvt.d.w.

LGTM!

Mar 17 2020, 11:16 AM · Restricted Project

Mar 11 2020

luismarques added a comment to D75729: [RISCV] Select +0.0 immediate using fmv.{w,d}.x / fcvt.d.w.

Unless you fast-path register zero (or the value itself being zero), a naive implementation is going to have to do a full integer->float conversion, which is more likely to be a multi-cycle operation, regardless of rounding mode. Contrast that with an fmv, which is a special case of fsgnj, but the generic case is still just bit selection and concatenation, so it should always be single-cycle. Having said that, the Rocket schedule (and reading the code) indicates that both are 2-cycle operations, and for the Bluespec Piccolo/Flute cores both are 1-cycle operations, but the GCC schedule for the 7 series SiFive cores claims that fmv will be in the A pipe (address, i.e. loads/stores, but also any FP<->int given that already needs to be present on the load/store paths), and fcvt will be in the B pipe (branches, but also mul/div and and any other FP ops).

Actually I got confused, fmv.x.?and fmv.?.x aren't special cases of fsgnj (that's only true for the FP<->FP fmv's), but their own instructions outright. The rest of what I said still applies though.

Mar 11 2020, 2:07 PM · Restricted Project
luismarques added a comment to D75729: [RISCV] Select +0.0 immediate using fmv.{w,d}.x / fcvt.d.w.

I'm happy to use those fmv.{s,d}.x instead.

Mar 11 2020, 12:29 PM · Restricted Project
luismarques added a comment to D75729: [RISCV] Select +0.0 immediate using fmv.{w,d}.x / fcvt.d.w.

Perhaps these are slightly better than just fcvt everywhere because they avoid the rounding mode required by fcvt.s.w / fcvt.s.l / fcvt.d.l?

Mar 11 2020, 5:08 AM · Restricted Project

Mar 6 2020

luismarques accepted D75728: [NFC][RISCV] Test for 0.0 fp immediate.

LGTM.

Mar 6 2020, 3:18 AM · Restricted Project
luismarques added a comment to D75729: [RISCV] Select +0.0 immediate using fmv.{w,d}.x / fcvt.d.w.

GCC seems to use fmv.s.x / fmv.d.x (the former of which now should be called fmv.w.x? ) instead of fcvt, not sure why. A quick Googling returned:

Mar 6 2020, 3:18 AM · Restricted Project
luismarques added a comment to D75168: [sanitizer][RISCV] Implement SignalContext::GetWriteFlag for RISC-V.
In D75168#1907941, @asb wrote:

There are some cases where you need to perform more checking in order to be future proof for possible new standard extensions. Specifically, review the RVC Instruction Set Listings in the RISC-V spec and check for where an encoding is marked as "RES" (reserved). e.g. C.LWSP is valid only if rd!=0, and the version with rd=0 is a reserved encoding. Similar with C.LDSP. I think it's just those two.

Mar 6 2020, 1:39 AM · Restricted Project, Restricted Project

Mar 5 2020

luismarques closed D75522: [compiler-rt][builtins][RISCV] Port __clear_cache to RISC-V Linux.

Closing revision.
(My commit message clean-up went overboard and accidentally deleted the Differential Revision line).

Mar 5 2020, 11:32 AM · Restricted Project, Restricted Project
luismarques committed rG99a8cc2b7d89: [compiler-rt][builtins][RISCV] Port __clear_cache to RISC-V Linux (authored by luismarques).
[compiler-rt][builtins][RISCV] Port __clear_cache to RISC-V Linux
Mar 5 2020, 8:46 AM

Mar 3 2020

luismarques created D75522: [compiler-rt][builtins][RISCV] Port __clear_cache to RISC-V Linux.
Mar 3 2020, 7:12 AM · Restricted Project, Restricted Project

Feb 27 2020

luismarques accepted D73339: [RISCV] Compress instructions based on function features.

LGTM.

Feb 27 2020, 9:20 AM · Restricted Project

Feb 26 2020

luismarques updated the diff for D75168: [sanitizer][RISCV] Implement SignalContext::GetWriteFlag for RISC-V.

Fix preprocessor conditional compilation block conditions.

Feb 26 2020, 6:33 AM · Restricted Project, Restricted Project
luismarques created D75168: [sanitizer][RISCV] Implement SignalContext::GetWriteFlag for RISC-V.
Feb 26 2020, 5:08 AM · Restricted Project, Restricted Project

Feb 25 2020

luismarques committed rG91f7f0d8e3ef: [RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC (authored by luismarques).
[RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC
Feb 25 2020, 6:19 AM
luismarques closed D75061: [RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC.
Feb 25 2020, 6:19 AM · Restricted Project

Feb 24 2020

luismarques created D75061: [RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC.
Feb 24 2020, 9:17 AM · Restricted Project

Feb 21 2020

luismarques committed rG0781e93a6eaa: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V (authored by luismarques).
[CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V
Feb 21 2020, 11:36 AM
luismarques closed D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V.
Feb 21 2020, 11:36 AM · Restricted Project
luismarques updated the diff for D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V.

As suggested by @efriedma, the patch was reworked to have one target with native atomics, and one without. No RUN run with a default target remains.

Feb 21 2020, 9:00 AM · Restricted Project
luismarques added a comment to D66870: [Sanitizers] Add support for RISC-V 64-bit.

Hello,Can you tell me the resaon why it wasn't support for risc-v before ? Why not add the support for rv32 this time?

Feb 21 2020, 1:35 AM · Restricted Project, Restricted Project

Feb 20 2020

luismarques added a comment to D68964: cmake/modules/CheckAtomic.cmake: catch false positives in RISC-V.
In D68964#1884694, @asb wrote:

It's unfortunate, but as Hans says this series of patches is likely too much at this stage in the release process. If there's a 10.0.1, perhaps it makes sense there. They benefit the RISC-V community, but there's a risk of regressing somewhere else in a way that's probably not fair to other targets and their release testers.

Feb 20 2020, 8:03 AM · Restricted Project
luismarques added a comment to D68964: cmake/modules/CheckAtomic.cmake: catch false positives in RISC-V.

Oh I see. I've backed it out again in d75ce45777d9802d43b555993fde8ed6562fb368, this is too much stuff to land so late. I think it can wait until the 11 release.

Feb 20 2020, 7:53 AM · Restricted Project
luismarques added a comment to D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V.

I'm not really a big fan of running tests with the host target triple, anyway; it seems to create work with almost no benefit. I'd be happy to just run the test with one target that has native atomics, and one target that doesn't. (The relevant code is all target-independent, aside from the atomic widths, so we aren't really gaining anything by testing more targets.)

Feb 20 2020, 7:44 AM · Restricted Project
luismarques added a comment to D68964: cmake/modules/CheckAtomic.cmake: catch false positives in RISC-V.
In D68964#1882946, @asb wrote:

The backport request seems ok to me, assuming you're happy taking a patch like this at this stage in the release process.

Feb 20 2020, 6:31 AM · Restricted Project
luismarques committed rG689f1e85ba68: [compiler-rt] [builtins] Fix logb / logbl tests (authored by luismarques).
[compiler-rt] [builtins] Fix logb / logbl tests
Feb 20 2020, 2:17 AM
luismarques closed D74826: [compiler-rt] [builtins] Fix logb / logbl tests.
Feb 20 2020, 2:17 AM · Restricted Project, Restricted Project

Feb 19 2020

luismarques created D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V.
Feb 19 2020, 9:31 AM · Restricted Project
luismarques updated the summary of D74826: [compiler-rt] [builtins] Fix logb / logbl tests.
Feb 19 2020, 5:34 AM · Restricted Project, Restricted Project
luismarques created D74826: [compiler-rt] [builtins] Fix logb / logbl tests.
Feb 19 2020, 5:19 AM · Restricted Project, Restricted Project

Feb 18 2020

luismarques created D74767: [CMake][NFC] Clean up CheckAtomic.cmake.
Feb 18 2020, 6:52 AM · Restricted Project

Feb 17 2020

luismarques committed rGd4a4a32cd94e: [Support] Check for atomics64 when deciding if '-latomic' is needed (authored by gokturk).
[Support] Check for atomics64 when deciding if '-latomic' is needed
Feb 17 2020, 11:57 PM
luismarques closed D69444: [Support] Check for atomics64 when deciding if '-latomic' is needed.
Feb 17 2020, 11:57 PM · Restricted Project
luismarques committed rG09856feb3cc1: [dsymutil] Explicitly link against libatomic when necessary (authored by gokturk).
[dsymutil] Explicitly link against libatomic when necessary
Feb 17 2020, 2:36 PM
luismarques closed D69003: [dsymutil] Explicitly link against libatomic when necessary.
Feb 17 2020, 2:36 PM · Restricted Project
luismarques committed rGcef85193b2cc: [CMake] CheckAtomic.cmake: catch false positives in RISC-V (authored by gokturk).
[CMake] CheckAtomic.cmake: catch false positives in RISC-V
Feb 17 2020, 10:58 AM
luismarques closed D68964: cmake/modules/CheckAtomic.cmake: catch false positives in RISC-V.
Feb 17 2020, 10:58 AM · Restricted Project
luismarques committed rG351ed50dcb2a: Reland "[clang-tools-extra] fix the check for if '-latomic' is necessary"" (authored by gokturk).
Reland "[clang-tools-extra] fix the check for if '-latomic' is necessary""
Feb 17 2020, 8:56 AM
luismarques committed rGf128f442a3d2: [CMake] Fix setting result of libatomic check for MSVC (authored by luismarques).
[CMake] Fix setting result of libatomic check for MSVC
Feb 17 2020, 7:38 AM

Feb 14 2020

luismarques added a comment to D68899: llvm/cmake/config.guess: add support for riscv32 and riscv64.

Thanks for the insight @Meinersbur .
This patch broke some ARM builds, I'll re-land it after solving that.

Feb 14 2020, 3:16 PM · Restricted Project
luismarques added a reverting change for rG1d40c4150630: [clang-tools-extra] fix the check for if '-latomic' is necessary: rG13700c383fdb: Revert "[clang-tools-extra] fix the check for if '-latomic' is necessary".
Feb 14 2020, 7:10 AM
luismarques committed rG13700c383fdb: Revert "[clang-tools-extra] fix the check for if '-latomic' is necessary" (authored by luismarques).
Revert "[clang-tools-extra] fix the check for if '-latomic' is necessary"
Feb 14 2020, 7:10 AM