This was merged as 31263211c6a4ef454216f2edbf9b2083a4c1474d, but the magic words to close the revision were missing.

I forgot to add llvm-commits as a subscriber here (I guess simply setting the repository field correctly is not enough), so it's been stuck on accepted for a while. I think this still applies cleanly though.

Can someone commit this? It should be good to go and I don't have commit access (long term I will probably be requesting commit access)

• correct a few more comments

• correct instruction encodings
• prevent clang-format from wrapping some lines

• move the macro to the end of the file.
• clang-format

• merge the memcpy and memmove tests
• clang-format

• Make memcpy and memmove tests unsupported on mingw

In D149769#4337197, @alvinhochun wrote:

Thanks for adding me in the loop. The change itself looks fine, though I haven't tried it on MinGW-w64 target yet. Some comments on the tests:

• It seems the two tests memcpy_sanity.cpp and memmove_sanity.cpp does the same thing for the most part. Can they be merged into one single test file and switch between testing memmove and memcpy by checking argc/argv?
• These tests will not work on MinGW-w64 as is because of the use of clang-cl command line flags. I have been fixing the asan tests to work on MinGW-w64 targets (see for example D150269) and there are now nightly builds that run asan tests. Please add // UNSUPPORTED: target={{.*-windows-gnu}} to disable the new tests for now. (It would be nice if you can make the test compatible with MinGW-w64, but that might be asking for too much.)

• revert changes to INIT_MEMCPY as they are redundant
• clang format

remove the changes to strdup from this diff.

@Paul-C-Anagnostopoulos Since you are the code-owner for TableGen... Is there anything else I need to do in order for this to be merged? It looks like header reorganization has made things no-longer break, but this fix will still make things more robust.

I've removed the global qualification on ::llvm::format

llvm::format should also suffice, although it's slightly less specific (possibly matching llvm::llvm::format or similar). It won't trigger adl though.

It appears to run ninja check-llvm which seems to have passed on windows at least.

In D119213#3304640, @Paul-C-Anagnostopoulos wrote:

Did you run all the TableGen tests?