- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Feb 8 2022
Feb 4 2022
Feb 3 2022
Fixed unit test failing in debug. Issue was genGetCommandArgument requires the
length and status parameters to be memory references (as we convert to ensure
result type).
Feb 2 2022
Feb 1 2022
Addressed awarzynski comments.
Jan 31 2022
Addressed nit comments.
Jan 26 2022
Addressed awarzynski comments.
Jan 25 2022
Jan 21 2022
Fixed comment in CommandTest.cpp
Nov 4 2021
- Fixed issues reported from review comments.
- Extended '-d' argument to be able to take a list of semicolon seperated directory paths to search for '.yaml' files in.
Nov 3 2021
Updated phabricator summary.
Updated phabricator summary.
Updated commit message.
Nov 1 2021
@NimishMishra Thanks for the help. Looks like the patch fixes the issue I was having on my end.
Oct 29 2021
@NimishMishra I believe this patch is causing a false semantic error with SNAP. The error being:
error: Semantic errors in inner.f90 ./inner.f90:152:7: error: CYCLE to construct outside of PARALLEL DO construct is not allowed IF ( g == 0 ) CYCLE
The code in snap it is erroring at in inner.f90 is:
!$OMP PARALLEL DO NUM_THREADS(nnstd_used) IF(nnstd_used>1) & !$OMP& SCHEDULE(STATIC,1) DEFAULT(SHARED) PRIVATE(n,g) & !$OMP& PROC_BIND(CLOSE) DO n = 1, ng_per_thrd g = grp_act(n,t) IF ( g == 0 ) CYCLE CALL inner_df_calc ( inno, iits(g), flux0pi(:,:,:,g), & flux0(:,:,:,g), dfmxi(g) ) END DO !$OMP END PARALLEL DO
AFAIK this should be valid code, and I know that @Leporacanthicus is also experiencing this issue (although it looks like there could be a secondary issue as well).
I've tried reverting this patch, and managed to stop getting this error when using the flang-omp-report plugin.
- Fixed issues reported from review comments.
- Added type hints where appropriate to arguments of functions.
- Removed the default arguments from functions where it was not neccesary, and added default arguments to parsed arguments.
Oct 27 2021
- Removed try...except check for importing ruamel.yaml. This also includes removing the yaml_module_not_found function.
- Added requirements.txt.
- Refactored code to include functions; main, parse_arguments, create_arg_parser.
Oct 26 2021
Refactored code.
I will now be taking over this patch from Ivan.
Removed unnecessary comments in 'omp-nowait.f90'.
Oct 21 2021
Manually ran clang-format of flang-omp-report-visistor.cpp as git-clang-format
not correctly formatting the code.
Oct 19 2021
@DavidTruby & @clementval Just to let you know, got the map and string patches up for review now :)