Page MenuHomePhabricator
Feed Advanced Search

Aug 16 2020

sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.
  • Add AAICVTrackerCallSite
  • Move manifest to AAICVTrackerCallSite
  • Only register callsite AAs for getters.
Aug 16 2020, 3:40 PM · Restricted Project

Aug 15 2020

sstefan1 added inline comments to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..
Aug 15 2020, 4:06 PM · Restricted Project, Restricted Project
sstefan1 requested review of D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..
Aug 15 2020, 10:28 AM · Restricted Project, Restricted Project

Aug 14 2020

sstefan1 updated the diff for D85932: [UpdateTestChecks] Match 'attributes #' at the end.

actually make it work when multiple check prefixes are provided

Aug 14 2020, 7:15 AM · Restricted Project

Aug 13 2020

sstefan1 added inline comments to D85932: [UpdateTestChecks] Match 'attributes #' at the end.
Aug 13 2020, 1:51 PM · Restricted Project
sstefan1 requested review of D85932: [UpdateTestChecks] Match 'attributes #' at the end.
Aug 13 2020, 1:49 PM · Restricted Project

Aug 12 2020

sstefan1 closed D80051: [OpenMPOpt] Test case 1 - Latency Hiding for Host to Device Memory Transfers.

Closed with: https://github.com/llvm/llvm-project/commit/6f0d99d2b9b3b8ae96dd91c8988cc067b9c9afb9

Aug 12 2020, 1:50 PM · Restricted Project, Restricted Project
sstefan1 added inline comments to D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.
Aug 12 2020, 11:23 AM · Restricted Project
sstefan1 added a comment to D80051: [OpenMPOpt] Test case 1 - Latency Hiding for Host to Device Memory Transfers.

This can be closed, right?

Aug 12 2020, 11:14 AM · Restricted Project, Restricted Project
sstefan1 added a comment to D85840: [OpenMPOpt][SplitMemTransfer] Is it possible/worth it to split the runtime call?.

Can you add parent revisions for this and maybe other related patches? It will be easier to know the order.

Aug 12 2020, 11:12 AM · Restricted Project
sstefan1 updated the summary of D85544: [OpenMPOpt] ICV tracking for calls.
Aug 12 2020, 10:02 AM · Restricted Project
sstefan1 abandoned D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.

Good parts of this are merged in D85544.

Aug 12 2020, 10:01 AM · Restricted Project
sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.

Introduce 2 new AAs
Merge good parts of D85052

Aug 12 2020, 9:56 AM · Restricted Project
sstefan1 added a comment to D85544: [OpenMPOpt] ICV tracking for calls.

At first, I thought it wouldn't be very useful to have AAs for multiple positions since we only interact with the function one.
Now that I actually tried to make it work, turns out it is quiet a nice clean up and makes much more sense.

Aug 12 2020, 8:41 AM · Restricted Project

Aug 11 2020

sstefan1 accepted D85700: [Attributor][NFC] Reformat tests after D85099.

LGTM

Aug 11 2020, 4:18 PM · Restricted Project
sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.

don't track values in weak functions

Aug 11 2020, 4:17 PM · Restricted Project
sstefan1 added a comment to D85544: [OpenMPOpt] ICV tracking for calls.

Unclear if we still want D85052 to go in before this, since most of the login is replaced with this patch.

Aug 11 2020, 1:16 PM · Restricted Project
sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.
  • worklist approach
  • don't use MBEC explorer
  • more tests
Aug 11 2020, 1:11 PM · Restricted Project

Aug 10 2020

sstefan1 added a comment to D85639: [Attributor] Fix bug in operator of PotentialValuesState.

IMHO, these few lines don't make much of a difference wrt the size of the patch. Maybe just merge them?

Aug 10 2020, 6:18 AM · Restricted Project

Aug 8 2020

sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.

adding more tests

Aug 8 2020, 8:19 AM · Restricted Project

Aug 7 2020

sstefan1 updated the summary of D85544: [OpenMPOpt] ICV tracking for calls.
Aug 7 2020, 2:09 PM · Restricted Project
sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.

Better commit message.
Will add more tests tomorrow.

Aug 7 2020, 2:08 PM · Restricted Project
sstefan1 added a comment to D85544: [OpenMPOpt] ICV tracking for calls.

Note: I've added D85052 as a parent revision. However this can also be considered as a slight change in approach. If needed, those 2 can be merged together.

Aug 7 2020, 12:18 PM · Restricted Project
sstefan1 requested review of D85544: [OpenMPOpt] ICV tracking for calls.
Aug 7 2020, 12:12 PM · Restricted Project

Aug 3 2020

sstefan1 added a comment to D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+".

lgtm, apart from clang tests. Someone else should take a look as well, though.

Aug 3 2020, 2:38 PM · Restricted Project, Restricted Project
sstefan1 updated the diff for D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.

cover "maybe written" by another unkown call case and add test for that.

Aug 3 2020, 12:01 PM · Restricted Project
sstefan1 added inline comments to D83283: [Attributor] AAPotentialValues Interface.
Aug 3 2020, 12:58 AM · Restricted Project

Aug 2 2020

sstefan1 added inline comments to D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.
Aug 2 2020, 1:41 PM · Restricted Project
sstefan1 updated the diff for D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.

addressing comments

Aug 2 2020, 1:31 PM · Restricted Project

Aug 1 2020

sstefan1 added a comment to D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.

This is still "intra-procedural", correct? Or can it replace across function boundaries too?

We are now able to check if call changes an ICV through function attribute. Follow up should make it possible to get an ICV value for a call.

Aug 1 2020, 1:36 PM · Restricted Project

Jul 31 2020

sstefan1 requested review of D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.
Jul 31 2020, 3:17 PM · Restricted Project

Jul 19 2020

sstefan1 committed rGe3d646c699f1: [Attributor][NFC] applying update_test_checks with --check-attributes (authored by sstefan1).
[Attributor][NFC] applying update_test_checks with --check-attributes
Jul 19 2020, 11:19 PM
sstefan1 closed D84130: [Attributor][NFC] applying update_test_checks with --check-attributes.
Jul 19 2020, 11:19 PM · Restricted Project
sstefan1 resigned from D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.
Jul 19 2020, 1:10 PM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D84130: [Attributor][NFC] applying update_test_checks with --check-attributes: Restricted Project.
Jul 19 2020, 12:58 PM · Restricted Project
sstefan1 committed rGcf1105069648: [Utils][Fix] remove unnecessary ; at the end (authored by sstefan1).
[Utils][Fix] remove unnecessary ; at the end
Jul 19 2020, 11:49 AM
sstefan1 committed rG937bad3594e7: [Utils] Check function attributes in update_test_checks (authored by sstefan1).
[Utils] Check function attributes in update_test_checks
Jul 19 2020, 11:22 AM
sstefan1 closed D83629: [Utils] Check function attributes in update_test_checks.
Jul 19 2020, 11:22 AM · Restricted Project, Restricted Project
sstefan1 added inline comments to D83629: [Utils] Check function attributes in update_test_checks.
Jul 19 2020, 4:21 AM · Restricted Project, Restricted Project
sstefan1 updated subscribers of D83629: [Utils] Check function attributes in update_test_checks.
Jul 19 2020, 3:48 AM · Restricted Project, Restricted Project
sstefan1 added a comment to D78861: [Attributor] Track AA dependency using dependency graph.

I see you reverted this twice. Just curious what happened?

Jul 19 2020, 3:09 AM · Restricted Project

Jul 18 2020

sstefan1 added inline comments to D83635: [OpenMPOpt] Merge parallel regions.
Jul 18 2020, 12:41 PM · Restricted Project

Jul 17 2020

sstefan1 added a comment to D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def.

Just in case you haven't seen already, clang/test/OpenMP/barrier_codegen.cpp needs to be updated as well.

Jul 17 2020, 3:33 PM · Restricted Project, Restricted Project, Restricted Project

Jul 16 2020

sstefan1 added a comment to D83744: [Attributor] Attributor call site specific AAValueConstantRange.

I inspected the output that opt generates and it makes sense.
also the script's output (included in the patch) also makes sense the.

I will double check everything but this is weird.
File check fails to match the first check line.

I am not sure we can help you much without the actual failure output.

Jul 16 2020, 2:17 AM · Restricted Project
sstefan1 resigned from D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.
Jul 16 2020, 12:01 AM · Restricted Project, Restricted Project, Restricted Project

Jul 15 2020

sstefan1 added a comment to D83744: [Attributor] Attributor call site specific AAValueConstantRange.

merge with D83299
add positive and negative tests.

@jdoerfert I have a problem with this patch even though I auto generate tests, llvm-lit fails.
Is this a bug with the update_test_checks.py script ?

Jul 15 2020, 1:42 PM · Restricted Project
sstefan1 updated the diff for D83629: [Utils] Check function attributes in update_test_checks.

add a test

Jul 15 2020, 1:36 PM · Restricted Project, Restricted Project

Jul 12 2020

sstefan1 added a comment to D82861: [Attributor] Add AAValueSimplifyCallSiteArgument::manifest.

Can you merge this?

Do I have a right to merge this by myself? I did arc patch and tried to git push https://github.com/llvm/llvm-project.git HEAD:master according to the document, but I failed to do that.

Jul 12 2020, 4:06 AM · Restricted Project

Jul 11 2020

sstefan1 updated the diff for D83629: [Utils] Check function attributes in update_test_checks.

remove unnecessary flag, fix update_cc_test_checks

Jul 11 2020, 2:51 PM · Restricted Project, Restricted Project
Herald added a project to D83629: [Utils] Check function attributes in update_test_checks: Restricted Project.
Jul 11 2020, 12:58 PM · Restricted Project, Restricted Project
sstefan1 committed rG850b150cff3d: [Attributor][NFC] Add more debug output for deleted functions (authored by sstefan1).
[Attributor][NFC] Add more debug output for deleted functions
Jul 11 2020, 5:36 AM

Jul 10 2020

sstefan1 added a reverting change for rG1d542f0ca83f: Revert "[OpenMPOpt] ICV Tracking": rGb8235d2bd871: Reland "[OpenMPOpt] ICV Tracking".
Jul 10 2020, 5:27 PM
sstefan1 committed rGb8235d2bd871: Reland "[OpenMPOpt] ICV Tracking" (authored by sstefan1).
Reland "[OpenMPOpt] ICV Tracking"
Jul 10 2020, 5:27 PM
sstefan1 closed D81788: [OpenMPOpt] ICV Tracking.
Jul 10 2020, 5:27 PM · Restricted Project
sstefan1 updated the diff for D81788: [OpenMPOpt] ICV Tracking.

fixing the issue with dead uses.

Jul 10 2020, 4:23 PM · Restricted Project
sstefan1 accepted D83583: [openmp] Remove OMPConstants.cpp and replace it by OMP.cpp generated by tablegen.

Thanks for figuring this out!

Jul 10 2020, 3:39 PM · Restricted Project
sstefan1 accepted D83270: [OpenMP] Compute a proper module slice for the CGSCCC pass.

LGTM

Jul 10 2020, 3:36 PM · Restricted Project

Jul 8 2020

sstefan1 added inline comments to D83297: [Attributor][WIP] Attribute scheduling visualization..
Jul 8 2020, 10:34 AM · Restricted Project
sstefan1 committed rG6aab27ba851f: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder. (authored by sstefan1).
[OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.
Jul 8 2020, 8:26 AM
sstefan1 closed D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder..
Jul 8 2020, 8:25 AM · Restricted Project, Restricted Project

Jul 6 2020

sstefan1 abandoned D65377: [FunctionAttrs] Annotate intrinsics with nosync.
Jul 6 2020, 4:55 AM · Restricted Project
sstefan1 added a comment to D83185: [Attributor] Introduce Attribute seed allow list..

Can you add a test using this option?

Jul 6 2020, 2:30 AM · Restricted Project

Jul 5 2020

sstefan1 updated the diff for D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder..

small fix

Jul 5 2020, 7:58 AM · Restricted Project, Restricted Project
sstefan1 updated subscribers of D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder..

Since this is not a small change, I think it would be good if @hoyFB could test if this resolves the issue.

Jul 5 2020, 7:58 AM · Restricted Project, Restricted Project
sstefan1 created D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder..
Jul 5 2020, 7:26 AM · Restricted Project, Restricted Project
sstefan1 added a comment to D83172: [Attributor] Create getter function for the ID of the abstract attribute.
In D83172#2131779, @bbn wrote:

Attributes are going to be decleared outside of the Attributor soon.

Do you mean that there might be other abstract attributes defined outside the AttributorAttributes.cpp ?

As of yesterday, there is an AA outside of AttributorAttributes :). You should rebase.

Jul 5 2020, 5:19 AM · Restricted Project

Jul 4 2020

sstefan1 committed rG6c4a5e9257ba: [OpenMPOpt] ICV Tracking (authored by sstefan1).
[OpenMPOpt] ICV Tracking
Jul 4 2020, 3:02 PM
sstefan1 closed D81788: [OpenMPOpt] ICV Tracking.
Jul 4 2020, 3:02 PM · Restricted Project
sstefan1 added a comment to D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.

I think you should split this in 2 patches. One being the refactoring. (this happened to me with the ICV patch)

Jul 4 2020, 12:53 PM · Restricted Project, Restricted Project

Jul 3 2020

sstefan1 added inline comments to D78861: [Attributor] Track AA dependency using dependency graph.
Jul 3 2020, 12:29 AM · Restricted Project

Jul 2 2020

sstefan1 accepted D83109: [Attributor] Create getName() method for abstract attribute.

LGTM

Jul 2 2020, 11:57 PM · Restricted Project
sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jul 2 2020, 2:03 PM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..

small fix

Jul 2 2020, 12:57 PM · Restricted Project
sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

@sstefan1 could u update the patch? We then send another email out with the list of 5 attributes we will make opt-out for intrinsics. A week or so later, assuming no one objected too much, we'll land it. In the meantime we need to update the target independent ones to opt-out appropriately. I guess my nosync list will catch almost all of them already but we'll have to give it another go as the patch is updated. WDYT?

I was under the impression that the attributes will be made default in another patch. Right now we don't opt out of the default attributes, but none are set to be default yet.
If it is better to do this in this patch, no problem. I can send an email, on Monday maybe?

Jul 2 2020, 12:25 PM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..

DisableDefaultAttributes flag instead of opt-out list

Jul 2 2020, 12:25 PM · Restricted Project
sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jul 2 2020, 11:51 AM · Restricted Project
sstefan1 committed rG61238d2690a6: [OpenMPOpt][Fix] Remove double initialization of omp::types. (authored by sstefan1).
[OpenMPOpt][Fix] Remove double initialization of omp::types.
Jul 2 2020, 11:20 AM
sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jul 2 2020, 12:29 AM · Restricted Project

Jun 30 2020

sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

On a related note, we might want to consider doing something for pointer/memory handling as well, since that's currently pretty awkward. Most pointer arguments should be nocapture/nofree, but we don't really mark that consistently.

Jun 30 2020, 1:35 PM · Restricted Project
sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

One way to avoid some of the complexity would be to opt-out of everything with a single bit. So if this is set, you don't get any default attributes. Otherwise you get all.

Agreed, that could be another way to go about this. By now, I'm not really sure what is the best out of all the options. What do others think?

Jun 30 2020, 5:23 AM · Restricted Project
sstefan1 committed rGaa93d84db934: [IR] NoFree IntrinsicProperty. (authored by sstefan1).
[IR] NoFree IntrinsicProperty.
Jun 30 2020, 2:41 AM
sstefan1 closed D82587: [IR] NoFree IntrinsicProperty..
Jun 30 2020, 2:41 AM · Restricted Project

Jun 29 2020

sstefan1 updated the diff for D81788: [OpenMPOpt] ICV Tracking.

addressing comments

Jun 29 2020, 3:18 PM · Restricted Project
sstefan1 added inline comments to D81788: [OpenMPOpt] ICV Tracking.
Jun 29 2020, 3:18 PM · Restricted Project
sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

For now I've only set IntrNoSync to be default and changed memset to opt-out of IntrNoSync just as an example. Maybe the part where attributes are actually made default should be done in another patch?

Jun 29 2020, 7:31 AM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..

Introduction of IsDefault field in IntrinsicProperty as suggested by @nhaehnle.

Jun 29 2020, 7:31 AM · Restricted Project
sstefan1 added a comment to D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.

One more thing, looks like you included only the last change, not the complete diff.

Jun 29 2020, 1:02 AM · Restricted Project, Restricted Project

Jun 28 2020

sstefan1 added inline comments to D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.
Jun 28 2020, 9:43 AM · Restricted Project, Restricted Project

Jun 26 2020

sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jun 26 2020, 9:17 AM · Restricted Project
sstefan1 committed rG951e43f357ec: [OpenMPOpt][NFC] Change ICV macros for initial value (authored by sstefan1).
[OpenMPOpt][NFC] Change ICV macros for initial value
Jun 26 2020, 8:45 AM
sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jun 26 2020, 4:18 AM · Restricted Project
sstefan1 accepted D82625: [Attributor][NFC] Replace call site with call base..

Personally, callsite still sounds more natural in some places, but LGTM.

Jun 26 2020, 2:08 AM · Restricted Project

Jun 25 2020

sstefan1 created D82587: [IR] NoFree IntrinsicProperty..
Jun 25 2020, 11:20 AM · Restricted Project
sstefan1 added a reviewer for D70365: intrinsics attribute opt-out list proposal.: nhaehnle.
Jun 25 2020, 10:46 AM · Restricted Project
sstefan1 added inline comments to D81788: [OpenMPOpt] ICV Tracking.
Jun 25 2020, 3:36 AM · Restricted Project

Jun 24 2020

sstefan1 added inline comments to D70365: intrinsics attribute opt-out list proposal..
Jun 24 2020, 8:36 AM · Restricted Project
sstefan1 committed rG0f426935bb5f: [OpenMPOpt] ICV macro definitions (authored by sstefan1).
[OpenMPOpt] ICV macro definitions
Jun 24 2020, 4:50 AM
sstefan1 closed D82193: [OpenMPOpt] ICV macro definitions.
Jun 24 2020, 4:50 AM · Restricted Project

Jun 23 2020

sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

Sorry this took so long.

Jun 23 2020, 1:59 PM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..
  • revisit this patch with different implementation
Jun 23 2020, 1:59 PM · Restricted Project