Page MenuHomePhabricator
Feed Advanced Search

Yesterday

sstefan1 accepted D92050: [OpenMP] Use assumptions during ICV tracking.

Cool :)

Tue, Nov 24, 12:36 PM · Restricted Project

Mon, Nov 23

sstefan1 added inline comments to D90103: Add OpenMP for optimization.
Mon, Nov 23, 3:42 AM · Restricted Project, Restricted Project
sstefan1 added a comment to D90103: Add OpenMP for optimization.

The tests should be in llvm-project/llvm/test/Transforms/OpenMP.

Mon, Nov 23, 2:11 AM · Restricted Project, Restricted Project

Sat, Nov 21

sstefan1 added a comment to D90103: Add OpenMP for optimization.

On the first look, you should at least clang-format this as it is not very readable right now.

Sat, Nov 21, 2:02 AM · Restricted Project, Restricted Project

Thu, Oct 29

sstefan1 added a comment to D89826: [FunctionAttrs][NPM] Fix handling of convergent.

Oh, and on the change itself: I'm not familiar enough with the attributor framework to judge the implementation, but the described reasoning (being able to make deductions from indirect calls) is sound.

Thu, Oct 29, 1:22 AM · Restricted Project

Oct 20 2020

sstefan1 closed D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Commited in rGfbfb1c790982.

Oct 20 2020, 3:24 AM · Restricted Project, Restricted Project
sstefan1 committed rGfbfb1c790982: [IR] Make nosync, nofree and willreturn default for intrinsics. (authored by sstefan1).
[IR] Make nosync, nofree and willreturn default for intrinsics.
Oct 20 2020, 3:00 AM

Oct 15 2020

sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Switch to opt-in approach. Intrinsic class now has the same meaning as bofore.
To get default attributes we now use DefaultAttrsIntrinsic.

Oct 15 2020, 4:09 AM · Restricted Project, Restricted Project

Oct 14 2020

sstefan1 committed rGce16be253c4d: [Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor (authored by sstefan1).
[Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor
Oct 14 2020, 1:10 AM
sstefan1 closed D89342: [Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor.
Oct 14 2020, 1:10 AM · Restricted Project
sstefan1 added a comment to D75384: OpenMP for loop fusion.

I have been trying to update my patch by following the steps on:

https://llvm.org/docs/Contributing.html#how-to-submit-a-patch

However, I always end up loading nothing.

Oct 14 2020, 12:36 AM · Restricted Project

Oct 13 2020

sstefan1 updated the diff for D89342: [Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor.

Only move the declaration

Oct 13 2020, 2:28 PM · Restricted Project
sstefan1 added inline comments to D89342: [Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor.
Oct 13 2020, 2:20 PM · Restricted Project
sstefan1 requested review of D89342: [Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor.
Oct 13 2020, 2:06 PM · Restricted Project

Oct 12 2020

sstefan1 committed rGa64e8583dafe: [IR][FIX] Intrinsics - don't apply default willreturn if IntrNoReturn is… (authored by sstefan1).
[IR][FIX] Intrinsics - don't apply default willreturn if IntrNoReturn is…
Oct 12 2020, 2:30 AM
sstefan1 closed D88644: [IR][FIX] Intrinsics - don't apply default willreturn if IntrNoReturn is specified.
Oct 12 2020, 2:30 AM · Restricted Project

Oct 2 2020

sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

@nikic do you have a preference on any of the suggested names?

Oct 2 2020, 5:03 PM · Restricted Project, Restricted Project

Oct 1 2020

sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

opt-out of few more intrinsics
add comment for DefaultIntrinsic class

Oct 1 2020, 2:59 AM · Restricted Project, Restricted Project
sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

update clang tests

Oct 1 2020, 2:48 AM · Restricted Project, Restricted Project
sstefan1 updated the summary of D88644: [IR][FIX] Intrinsics - don't apply default willreturn if IntrNoReturn is specified.
Oct 1 2020, 2:40 AM · Restricted Project
sstefan1 requested review of D88644: [IR][FIX] Intrinsics - don't apply default willreturn if IntrNoReturn is specified.
Oct 1 2020, 2:35 AM · Restricted Project

Sep 30 2020

sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

I find the naming here confusing: Looking at this patch my expectation was that DefaultIntrinsic is used for intrinsics with default attributes, based on the name. Took me a while to understand it's actually the other way around. Shouldn't the Intrinsic <-> DefaultIntrinsic naming be inverted?

Sep 30 2020, 7:20 AM · Restricted Project, Restricted Project
sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Opt-out of default attributes for llvm.coro.* intrinsics.

Sep 30 2020, 6:38 AM · Restricted Project, Restricted Project
sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Actually coro intrinsics had default attributes, completelly missed that. Sorry for the confusion.
I'll update the patch shortly.

Sep 30 2020, 4:59 AM · Restricted Project, Restricted Project
sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

We probably shouldn't be messing with the attributes on llvm.coro.* intrinsics. The rules for transforms around coroutine intrinsics aren't completely settled (see also https://reviews.llvm.org/D87817), but at least some of them can run arbitrary code.

Sep 30 2020, 12:26 AM · Restricted Project, Restricted Project

Sep 29 2020

sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

precommit (local) coro test changes with update_test_checks

Sep 29 2020, 12:43 PM · Restricted Project, Restricted Project
sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Adding @rjmccall as a reviewer as I'm unsure about some coroutine changes that appeared after rebase.

Sep 29 2020, 12:10 PM · Restricted Project, Restricted Project
sstefan1 added a reviewer for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics.: rjmccall.
Sep 29 2020, 12:07 PM · Restricted Project, Restricted Project
sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Rebase

Sep 29 2020, 12:06 PM · Restricted Project, Restricted Project
sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Its been more than a month now. Are there any additional concern about this?

Sep 29 2020, 7:57 AM · Restricted Project, Restricted Project
sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

group default properties together

Sep 29 2020, 7:56 AM · Restricted Project, Restricted Project
sstefan1 abandoned D86650: [Attributor][NFC] Run update_test_checks.py to check for attributes at the end..
Sep 29 2020, 7:30 AM · Restricted Project
sstefan1 committed rGcb9cfa0d2fdd: [OpenMPOpt][Fix] Only initialize ICV initial values once. (authored by sstefan1).
[OpenMPOpt][Fix] Only initialize ICV initial values once.
Sep 29 2020, 3:24 AM
sstefan1 closed D88441: [OpenMPOpt][Fix] Only initialize ICV initial values once..
Sep 29 2020, 3:24 AM · Restricted Project

Sep 28 2020

sstefan1 requested review of D88441: [OpenMPOpt][Fix] Only initialize ICV initial values once..
Sep 28 2020, 12:39 PM · Restricted Project
sstefan1 added inline comments to D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def.
Sep 28 2020, 12:28 PM · Restricted Project, Restricted Project, Restricted Project
sstefan1 added inline comments to D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def.
Sep 28 2020, 12:12 PM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2020

sstefan1 abandoned D85932: [UpdateTestChecks] Match 'attributes #' at the end.

Switched to D88096.

Sep 22 2020, 7:24 AM · Restricted Project
sstefan1 accepted D88096: [UpdateTestChecks] Match 'attributes #' at the end.

Now I see where the problem was. Thanks for taking a look.

Sep 22 2020, 7:24 AM · Restricted Project
sstefan1 accepted D88095: [UpdateTestChecks] Allow extra spaces in command line note.

LGTM

Sep 22 2020, 7:12 AM · Restricted Project

Sep 19 2020

sstefan1 added a comment to D87975: [IR] MaxObjSize Attribute.

I think you should split this in two patches. One that introduces the IR attribite and one for attributor deduction.

Sep 19 2020, 3:11 PM · Restricted Project

Sep 9 2020

sstefan1 added a comment to D86127: [Attributor] Make AAMemoryLocationCallSite behavior sane.

Sorry for the delay.

Sep 9 2020, 11:58 PM · Restricted Project
sstefan1 accepted D87432: [Attributor] Disable the MustBeExecutedContext by default.

Looks like parallel_deletion.ll needs to be updated as well.

Sep 9 2020, 11:50 PM · Restricted Project
sstefan1 added a comment to D87266: [Attributor] Re-enable a run line in noalias.ll.

Looks same as the failures before. I may be able to do a windows build next week and try to see what is going on.

Sep 9 2020, 8:54 AM · Restricted Project

Sep 7 2020

sstefan1 accepted D87266: [Attributor] Re-enable a run line in noalias.ll.

Actually windows tests passed, I was looking at the wrong place.

Sep 7 2020, 11:56 PM · Restricted Project
sstefan1 added a comment to D87266: [Attributor] Re-enable a run line in noalias.ll.

I remember this being windows only issue. I was able to always reproduce it on windows, but never had the chance to look into it.

Sep 7 2020, 11:52 PM · Restricted Project

Sep 3 2020

sstefan1 accepted D87104: [OpenMPOpt] Assume indirect call always changes ICV.

LGTM, thanks!

Sep 3 2020, 11:01 PM · Restricted Project

Aug 31 2020

sstefan1 added inline comments to D86474: [OpenMPOpt][SplitMemTransfer] Grouping the setup instructions for the runtime call..
Aug 31 2020, 11:39 PM · Restricted Project

Aug 30 2020

sstefan1 committed rG5dfd7cc46c8d: Reland [OpenMPOpt] ICV tracking for calls (authored by sstefan1).
Reland [OpenMPOpt] ICV tracking for calls
Aug 30 2020, 2:30 AM
sstefan1 closed D85544: [OpenMPOpt] ICV tracking for calls.
Aug 30 2020, 2:30 AM · Restricted Project
sstefan1 committed rG8d8ce85b235c: [Attributor] Introduce module slice. (authored by sstefan1).
[Attributor] Introduce module slice.
Aug 30 2020, 1:59 AM
sstefan1 closed D86319: [Attributor] Introduce module slice..
Aug 30 2020, 1:59 AM · Restricted Project
sstefan1 committed rGef018236945f: [OpenMPOpt][NFC] add reproducer for problem found in D85544 (authored by sstefan1).
[OpenMPOpt][NFC] add reproducer for problem found in D85544
Aug 30 2020, 1:01 AM

Aug 29 2020

sstefan1 committed rG6ce5b74b82ab: [Attributor][NFC] rerun update_test_checks without --scrub-attributes (authored by sstefan1).
[Attributor][NFC] rerun update_test_checks without --scrub-attributes
Aug 29 2020, 10:36 AM
sstefan1 committed rGb5dd2cd27f62: [UpdateTestChecks] Don't skip attributes when comparing functions (authored by sstefan1).
[UpdateTestChecks] Don't skip attributes when comparing functions
Aug 29 2020, 6:38 AM

Aug 28 2020

sstefan1 committed rG7128e647063d: [UpdateTestChecks] include { in function signature check line (authored by sstefan1).
[UpdateTestChecks] include { in function signature check line
Aug 28 2020, 2:45 PM
sstefan1 closed D86769: [UpdateTestChecks] include { in function signature check line.
Aug 28 2020, 2:45 PM · Restricted Project, Restricted Project
sstefan1 added inline comments to D86319: [Attributor] Introduce module slice..
Aug 28 2020, 7:47 AM · Restricted Project
sstefan1 updated the diff for D86319: [Attributor] Introduce module slice..

Rebasing after recent changes to AANoUndef

Aug 28 2020, 7:46 AM · Restricted Project
sstefan1 updated the summary of D86769: [UpdateTestChecks] include { in function signature check line.
Aug 28 2020, 1:27 AM · Restricted Project, Restricted Project
sstefan1 updated the summary of D86769: [UpdateTestChecks] include { in function signature check line.
Aug 28 2020, 1:26 AM · Restricted Project, Restricted Project
sstefan1 requested review of D86769: [UpdateTestChecks] include { in function signature check line.
Aug 28 2020, 1:25 AM · Restricted Project, Restricted Project

Aug 26 2020

sstefan1 updated the diff for D85932: [UpdateTestChecks] Match 'attributes #' at the end.

Don't skip ;\n comments

Aug 26 2020, 12:21 PM · Restricted Project
sstefan1 requested review of D86650: [Attributor][NFC] Run update_test_checks.py to check for attributes at the end..
Aug 26 2020, 12:11 PM · Restricted Project
sstefan1 updated the diff for D85932: [UpdateTestChecks] Match 'attributes #' at the end.

Sorry for the delay on this.

Aug 26 2020, 11:57 AM · Restricted Project
sstefan1 added a comment to D86565: [Attributor] Do not manifest noundef for dead positions.

Are you going to move the AAIsDead query to the update?

Aug 26 2020, 6:15 AM · Restricted Project
sstefan1 committed rG99d18f79646c: Reland [IR] Intrinsics default attributes and opt-out flag (authored by sstefan1).
Reland [IR] Intrinsics default attributes and opt-out flag
Aug 26 2020, 2:41 AM
sstefan1 closed D70365: intrinsics attribute opt-out list proposal..
Aug 26 2020, 2:41 AM · Restricted Project
sstefan1 added a comment to D86587: [WIP][Attributor] Per function iteration and memory tracking..

Thanks for the explanation. Since the patch is not small and it is a WIP, can you add some more information about the failing tests? Maybe some specific examples?

Aug 26 2020, 1:48 AM · Restricted Project

Aug 25 2020

sstefan1 added a comment to D86565: [Attributor] Do not manifest noundef for dead positions.

LGTM, one minor note. The test will be part of the module slice patch, I'm fairly certain this cannot be tested right now but it makes sense.

Aug 25 2020, 2:12 PM · Restricted Project

Aug 24 2020

sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

What should be the next step here? There was no response on the RFC update.

Aug 24 2020, 3:04 PM · Restricted Project, Restricted Project
sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

Does the fix for the performance issue seem ok?

Aug 24 2020, 3:04 PM · Restricted Project

Aug 22 2020

sstefan1 accepted D86396: [Attributor] Change AANoUndef not to deduce noundef for dead returned positions.

LGTM, thanks!

Aug 22 2020, 7:41 AM · Restricted Project

Aug 21 2020

sstefan1 added inline comments to D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays.
Aug 21 2020, 2:56 AM · Restricted Project, Restricted Project
sstefan1 committed rG90e0a0212916: [Attributor][NFC] run update_test_checks with --check-attributes. (authored by sstefan1).
[Attributor][NFC] run update_test_checks with --check-attributes.
Aug 21 2020, 2:14 AM
sstefan1 accepted D86129: [Attributor] Function seed allow list.

LGTM.

Aug 21 2020, 1:25 AM · Restricted Project
sstefan1 added a comment to D86319: [Attributor] Introduce module slice..

This is interesting, I thought you couldn't change the IR outside of the current SCC.

We can't delete functions outside of the SCC, the rest should be fine.

Aug 21 2020, 1:19 AM · Restricted Project

Aug 20 2020

sstefan1 requested review of D86319: [Attributor] Introduce module slice..
Aug 20 2020, 3:25 PM · Restricted Project
sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

After this patch, llvm-tblgen in debug mode is 10x slower:
Before:

$ time bin/llvm-tblgen -gen-global-isel -I ../llvm/test/TableGen/../../include -I ..//llvm/test/TableGen/Common -optimize-match-table=true ../llvm/test/TableGen/GlobalISelEmitter.td -o /tmp/test.cpp

real	0m1.238s
user	0m0.970s
sys	0m0.274s

After:

$ time bin/llvm-tblgen -gen-global-isel -I ../llvm/test/TableGen/../../include -I ..//llvm/test/TableGen/Common -optimize-match-table=true ../llvm/test/TableGen/GlobalISelEmitter.td -o /tmp/test.cpp

real	0m11.671s
user	0m11.607s
sys	0m0.067s

Thanks for reporting this.
Numbers are similar in the release mode as well. The problem was that we go through all IntrProperties for every Intrinsic in search for ones that are default. However that can be done only once.

Aug 20 2020, 12:56 AM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..

fix slowdown issue

Aug 20 2020, 12:56 AM · Restricted Project

Aug 19 2020

sstefan1 committed rGb0b32e649011: [OpenMPOpt] ICV tracking for calls (authored by sstefan1).
[OpenMPOpt] ICV tracking for calls
Aug 19 2020, 2:45 AM
sstefan1 closed D85544: [OpenMPOpt] ICV tracking for calls.
Aug 19 2020, 2:44 AM · Restricted Project
sstefan1 committed rGeedf18fc1f5f: [IR] Intrinsics default attributes and opt-out flag (authored by sstefan1).
[IR] Intrinsics default attributes and opt-out flag
Aug 19 2020, 1:53 AM
sstefan1 closed D70365: intrinsics attribute opt-out list proposal..
Aug 19 2020, 1:53 AM · Restricted Project
sstefan1 added inline comments to D86155: [OpenMPOpt][SplitMemTransfer] Moving the "wait" down.
Aug 19 2020, 12:30 AM · Restricted Project
sstefan1 added inline comments to D86155: [OpenMPOpt][SplitMemTransfer] Moving the "wait" down.
Aug 19 2020, 12:28 AM · Restricted Project

Aug 18 2020

sstefan1 added a comment to D86129: [Attributor] Function seed allow list.

Maybe the commit message could be a bit more descriptive?

Aug 18 2020, 1:40 AM · Restricted Project

Aug 17 2020

sstefan1 added inline comments to D85544: [OpenMPOpt] ICV tracking for calls.
Aug 17 2020, 2:14 PM · Restricted Project
sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.

addressing comments

Aug 17 2020, 2:14 PM · Restricted Project
sstefan1 added inline comments to D85932: [UpdateTestChecks] Match 'attributes #' at the end.
Aug 17 2020, 1:42 PM · Restricted Project
sstefan1 updated the diff for D85932: [UpdateTestChecks] Match 'attributes #' at the end.

addressing comments

Aug 17 2020, 1:42 PM · Restricted Project
sstefan1 updated the summary of D70365: intrinsics attribute opt-out list proposal..
Aug 17 2020, 11:24 AM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..

update affected tests.

Aug 17 2020, 11:21 AM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..

add comment for DisableDefaultAttributes flag.

Aug 17 2020, 10:46 AM · Restricted Project
sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

Ping.
Can we move forward with this approach?

Aug 17 2020, 9:33 AM · Restricted Project
sstefan1 added inline comments to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..
Aug 17 2020, 1:58 AM · Restricted Project, Restricted Project
sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

update gc intrinsics to DefaultIntrinsic

Aug 17 2020, 1:57 AM · Restricted Project, Restricted Project

Aug 16 2020

sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Add DefaultIntrinsic class with default attributes disabled.

Aug 16 2020, 4:48 PM · Restricted Project, Restricted Project
sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.
  • Remove hasTrackedValue()
Aug 16 2020, 3:41 PM · Restricted Project
sstefan1 added inline comments to D85544: [OpenMPOpt] ICV tracking for calls.
Aug 16 2020, 3:40 PM · Restricted Project