Page MenuHomePhabricator
Feed Advanced Search

Jan 3 2019

michaelplatings accepted D56262: Python compat - isinstance(x, long).

LGTM

Jan 3 2019, 4:48 AM
michaelplatings accepted D55989: Modernize Python script.

LGTM

Jan 3 2019, 4:42 AM

Jan 2 2019

michaelplatings requested changes to D55196: Python2/3 compatibility - StringIO.
Jan 2 2019, 9:50 AM
michaelplatings accepted D55829: LLVM Test suite Python 2/3 compatibility.

LGTM

Jan 2 2019, 9:26 AM
michaelplatings requested changes to D55989: Modernize Python script.
Jan 2 2019, 9:25 AM

Dec 19 2018

michaelplatings accepted D55199: Python2/3 compat - urllib.

LGTM

Dec 19 2018, 1:20 AM

Dec 18 2018

michaelplatings requested changes to D55196: Python2/3 compatibility - StringIO.
Dec 18 2018, 9:32 AM
michaelplatings requested changes to D55829: LLVM Test suite Python 2/3 compatibility.

From looking briefly it seems that these are sensible changes, but many of them aren't necessary for Python 3 compatility. I suggest separating the Python 3 compatibility changes and other cleanups into different patches.

Dec 18 2018, 9:31 AM
michaelplatings requested changes to D55199: Python2/3 compat - urllib.
Dec 18 2018, 9:28 AM
michaelplatings accepted D55197: Python 2/3 compatibility - iterable.

LGTM

Dec 18 2018, 2:22 AM
michaelplatings accepted D55208: Python 2/3 compat - import __future__.

LGTM

Dec 18 2018, 2:12 AM
michaelplatings added inline comments to D55199: Python2/3 compat - urllib.
Dec 18 2018, 2:12 AM
michaelplatings accepted D55205: Python 2/3 compat - commands.

LGTM

Dec 18 2018, 2:04 AM

Dec 13 2018

michaelplatings added inline comments to D55196: Python2/3 compatibility - StringIO.
Dec 13 2018, 2:42 AM
michaelplatings accepted D55200: Python 2/3 compat - config parser.

LGTM

Dec 13 2018, 2:36 AM
michaelplatings accepted D55193: Python2/3 compatibility - ranges.

LGTM

Dec 13 2018, 2:35 AM
michaelplatings added inline comments to D55197: Python 2/3 compatibility - iterable.
Dec 13 2018, 2:33 AM
michaelplatings accepted D55213: Python2/3 compat - print.

LGTM

Dec 13 2018, 2:24 AM
michaelplatings accepted D55194: Python2/3 compatiility - has_key.

LGTM

Dec 13 2018, 2:13 AM
michaelplatings added inline comments to D55199: Python2/3 compat - urllib.
Dec 13 2018, 2:13 AM
michaelplatings accepted D55204: Python 2/3 compat - div.

LGTM

Dec 13 2018, 2:04 AM
michaelplatings added inline comments to D55205: Python 2/3 compat - commands.
Dec 13 2018, 2:02 AM

Dec 12 2018

michaelplatings added inline comments to D55200: Python 2/3 compat - config parser.
Dec 12 2018, 9:38 AM
michaelplatings accepted D55259: Python 2/3 compat - threading.

LGTM

Dec 12 2018, 9:38 AM
michaelplatings accepted D55202: Python 2/3 compat - Queue.

LGTM

Dec 12 2018, 9:33 AM
michaelplatings added inline comments to D55213: Python2/3 compat - print.
Dec 12 2018, 9:31 AM

Dec 3 2018

michaelplatings added inline comments to D55204: Python 2/3 compat - div.
Dec 3 2018, 9:01 AM
michaelplatings accepted D55203: Python 2/3 compat - http server.

LGTM

Dec 3 2018, 8:52 AM
michaelplatings added inline comments to D55202: Python 2/3 compat - Queue.
Dec 3 2018, 8:51 AM
michaelplatings accepted D55201: Python2/3 compat - repr.

LGTM

Dec 3 2018, 8:48 AM
michaelplatings added inline comments to D55193: Python2/3 compatibility - ranges.
Dec 3 2018, 8:46 AM
michaelplatings accepted D55121: Make several Python scripts portable across Python2 and Python 3.

LGTM

Dec 3 2018, 4:04 AM
michaelplatings added a comment to D55196: Python2/3 compatibility - StringIO.

Can you comment on whether the differences between StringIO and io.StringIO might be significant? https://stackoverflow.com/a/49795277

Dec 3 2018, 3:52 AM

Nov 30 2018

michaelplatings added a comment to D55121: Make several Python scripts portable across Python2 and Python 3.

In general LGTM, as someone who's done a 2-3 conversion of similar scale before.

Nov 30 2018, 7:58 AM

Nov 29 2018

michaelplatings added a comment to D55001: [CMake] Fix build with -DLLVM_TOOL_LLVM_{MCA/EXEGESIS}_BUILD=OFF.

Out of interest, how are you disabling tools?

Nov 29 2018, 2:32 AM · Restricted Project
michaelplatings added a comment to D54439: CMake: Make most target symbols hidden by default.

"LLVM_EXPORT" seems like an overly generic name. Maybe a variation on "LLVM_LIBRARY_VISIBILITY" would be more fitting?

Nov 29 2018, 2:03 AM · Restricted Project

Nov 28 2018

michaelplatings committed rL347764: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS….
Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS…
Nov 28 2018, 7:22 AM
michaelplatings closed D54701: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON.
Nov 28 2018, 7:22 AM

Nov 27 2018

michaelplatings added a comment to D54701: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON.

@marsupial if you can show me an instance where this patch significantly changes the build's behaviour then I can change the patch to mitigate that.

Nov 27 2018, 1:35 AM

Nov 26 2018

michaelplatings updated the diff for D54701: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON.

(moved closing parenthesis to new line)

Nov 26 2018, 7:07 AM

Nov 23 2018

michaelplatings added a comment to D54701: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON.

@marsupial that's odd. I'm using ninja also and libDynamicLibraryLib.a ends up in lib for me. Reproducer:

svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm
mkdir build && cd build
cmake -G Ninja ../llvm
ninja DynamicLibraryLib
ls lib/libDynamicLibraryLib.a
Nov 23 2018, 1:39 AM

Nov 22 2018

michaelplatings added a comment to D54701: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON.

@marsupial ping?

Nov 22 2018, 4:13 AM

Nov 20 2018

michaelplatings added a comment to D54701: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON.

Thanks for the review Frederich.

Nov 20 2018, 5:08 AM

Nov 19 2018

michaelplatings created D54701: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON.
Nov 19 2018, 8:05 AM
michaelplatings abandoned D54587: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON.

Thanks very much Reid for the speedy review. Unfortunately, due the the use of absolute paths, this patch causes long command lines to be generated which Visual Studio 2015 can't handle. So I have to abandon this patch.

Nov 19 2018, 7:42 AM
michaelplatings committed rL347194: Test commit - delete trailing space..
Test commit - delete trailing space.
Nov 19 2018, 4:18 AM
michaelplatings committed rC347194: Test commit - delete trailing space..
Test commit - delete trailing space.
Nov 19 2018, 4:18 AM
michaelplatings committed rL347193: Test commit - delete a trailing space..
Test commit - delete a trailing space.
Nov 19 2018, 4:13 AM

Nov 15 2018

michaelplatings created D54587: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON.
Nov 15 2018, 10:15 AM