Page MenuHomePhabricator
Feed Advanced Search

Apr 27 2021

yuanboli233 added a comment to D98218: [LSR] fix a issue that LoopStrengthReduction drop debug location unnecessarily.

@jmorse Thanks for your help!

Apr 27 2021, 10:35 AM · Restricted Project

Apr 19 2021

yuanboli233 updated the diff for D98218: [LSR] fix a issue that LoopStrengthReduction drop debug location unnecessarily.

update comment format and remove function attribute #0 in the test case

Apr 19 2021, 4:10 AM · Restricted Project
yuanboli233 updated the diff for D100270: [debug-info] MemCpyOpt should merge the debug location when replace multiple block-local instruction with a new memset.

Thanks for the suggestion from @djtodoro, updated the diff

Apr 19 2021, 3:46 AM · Restricted Project, debug-info

Apr 16 2021

yuanboli233 updated the diff for D100270: [debug-info] MemCpyOpt should merge the debug location when replace multiple block-local instruction with a new memset.

Updated the test case to include both the preserving case and the merge case.

Apr 16 2021, 2:38 AM · Restricted Project, debug-info

Apr 15 2021

yuanboli233 added a comment to D98218: [LSR] fix a issue that LoopStrengthReduction drop debug location unnecessarily.

Can you help me to commit the changes as well. I don't have commit access. Thanks, @jmorse

Apr 15 2021, 1:42 PM · Restricted Project
yuanboli233 updated the diff for D100165: [GVNHoist] fix a bug where GVNHoist preserves the debug location when it should be dropped.

Thank @jmorse for the suggestions, I have updated the diff to address them.

Apr 15 2021, 1:39 PM · Restricted Project

Apr 14 2021

yuanboli233 updated the diff for D98218: [LSR] fix a issue that LoopStrengthReduction drop debug location unnecessarily.

Thanks for the feedback @jmorse, here I have the updated test.

Apr 14 2021, 8:52 PM · Restricted Project
yuanboli233 added a comment to D100371: [debug-info] SCCP should preserve the debug location for an one-to-one instruction replacement.

Yes, @djtodoro, it is in the starting phase, and we plan to improve it and make it an open-source project.

Apr 14 2021, 8:30 AM · Restricted Project, debug-info

Apr 13 2021

yuanboli233 added a reviewer for D100371: [debug-info] SCCP should preserve the debug location for an one-to-one instruction replacement: Orlando.
Apr 13 2021, 12:38 PM · Restricted Project, debug-info
yuanboli233 updated the diff for D100371: [debug-info] SCCP should preserve the debug location for an one-to-one instruction replacement.

Thanks for the suggestion, @Orlando.

Apr 13 2021, 12:38 PM · Restricted Project, debug-info
yuanboli233 updated the diff for D100371: [debug-info] SCCP should preserve the debug location for an one-to-one instruction replacement.

Updated with the simplified test case suggested by @Orlando.

Apr 13 2021, 4:12 AM · Restricted Project, debug-info
yuanboli233 added a comment to D100371: [debug-info] SCCP should preserve the debug location for an one-to-one instruction replacement.

@Orlando, thanks for pointing out the debugify usage for me. I indeed use debugify to generate the test cases. I will update test case soon.

Apr 13 2021, 3:57 AM · Restricted Project, debug-info
yuanboli233 requested review of D100371: [debug-info] SCCP should preserve the debug location for an one-to-one instruction replacement.
Apr 13 2021, 2:04 AM · Restricted Project, debug-info

Apr 12 2021

yuanboli233 updated the diff for D100165: [GVNHoist] fix a bug where GVNHoist preserves the debug location when it should be dropped.

I thought the previous CHECK will discard store instructions with debug location. Thanks for pointing it out @aprantl, I have added the comment and changed the CHECK. I have tested that the test case can now distinguish the versions before and after the proposed patch.

Apr 12 2021, 12:13 PM · Restricted Project
yuanboli233 updated the diff for D100270: [debug-info] MemCpyOpt should merge the debug location when replace multiple block-local instruction with a new memset.

Thanks for pointing it out, I have made it to one line.

Apr 12 2021, 1:47 AM · Restricted Project, debug-info
yuanboli233 updated the diff for D100270: [debug-info] MemCpyOpt should merge the debug location when replace multiple block-local instruction with a new memset.

Thanks for the suggestions from @djtodoro! Format revised and changed to SmallVector.

Apr 12 2021, 1:12 AM · Restricted Project, debug-info

Apr 11 2021

yuanboli233 added a comment to D100270: [debug-info] MemCpyOpt should merge the debug location when replace multiple block-local instruction with a new memset.

Sorry for failing the tests, will check the problem and revise to pass the unit tests, it is not happening in my local machine.

Apr 11 2021, 2:04 PM · Restricted Project, debug-info
yuanboli233 added a comment to D98218: [LSR] fix a issue that LoopStrengthReduction drop debug location unnecessarily.

@jmorse @vsk ping

Apr 11 2021, 1:27 PM · Restricted Project
yuanboli233 requested review of D100270: [debug-info] MemCpyOpt should merge the debug location when replace multiple block-local instruction with a new memset.
Apr 11 2021, 12:29 PM · Restricted Project, debug-info

Apr 9 2021

yuanboli233 updated the diff for D100165: [GVNHoist] fix a bug where GVNHoist preserves the debug location when it should be dropped.

First updated to the version which simply drops the debug location, we may wait for other people's ideas.

Apr 9 2021, 2:49 AM · Restricted Project
yuanboli233 added a comment to D100165: [GVNHoist] fix a bug where GVNHoist preserves the debug location when it should be dropped.

Thanks for your feedback @Orlando! I checked the code again, and I agree with your opinion, it seems that removing the if guard will be a conservative solution for this case.

Apr 9 2021, 2:36 AM · Restricted Project
yuanboli233 updated the diff for D100165: [GVNHoist] fix a bug where GVNHoist preserves the debug location when it should be dropped.

updated with git-clang-format

Apr 9 2021, 1:31 AM · Restricted Project
yuanboli233 requested review of D100165: [GVNHoist] fix a bug where GVNHoist preserves the debug location when it should be dropped.
Apr 9 2021, 12:40 AM · Restricted Project

Apr 8 2021

yuanboli233 updated the diff for D98218: [LSR] fix a issue that LoopStrengthReduction drop debug location unnecessarily.

Sorry, the original format was OK, I just copy-paste and didn't check the final format. I have just fixed the format.

Apr 8 2021, 8:51 PM · Restricted Project
yuanboli233 updated the diff for D98218: [LSR] fix a issue that LoopStrengthReduction drop debug location unnecessarily.

add the test case requested.

Apr 8 2021, 7:15 PM · Restricted Project

Mar 29 2021

yuanboli233 added a comment to D98218: [LSR] fix a issue that LoopStrengthReduction drop debug location unnecessarily.

Thanks a lot for the feedback!

Mar 29 2021, 1:59 AM · Restricted Project

Mar 22 2021

yuanboli233 added a comment to D98218: [LSR] fix a issue that LoopStrengthReduction drop debug location unnecessarily.

Do you think this example above can serve as a test case? If so, I can post the complete example here.

Mar 22 2021, 8:40 AM · Restricted Project

Mar 18 2021

yuanboli233 added a comment to D98218: [LSR] fix a issue that LoopStrengthReduction drop debug location unnecessarily.

As @jmorse pointed out, OptimizeLoopTermCond might move the newly created instruction around. I was working on an example to trigger an instruction move and the replacement of the conditional. Here I have an example, I show part of the code here:

Mar 18 2021, 3:53 PM · Restricted Project

Mar 8 2021

yuanboli233 requested review of D98218: [LSR] fix a issue that LoopStrengthReduction drop debug location unnecessarily.
Mar 8 2021, 2:03 PM · Restricted Project