Page MenuHomePhabricator
Feed Advanced Search

Jun 12 2020

andreyknvl accepted D81367: [ASan][NFC] Refactor redzone size calculation.

LGTM

Jun 12 2020, 5:53 AM · Restricted Project

May 29 2020

andreyknvl added a comment to D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel.

The change looks good to me.

May 29 2020, 12:33 PM · Restricted Project, Restricted Project

Oct 11 2019

andreyknvl committed rL374546: Add andreyknvl to github-usernames.
Add andreyknvl to github-usernames
Oct 11 2019, 5:54 AM

Apr 13 2018

andreyknvl committed rL330044: hwasan: add -fsanitize=kernel-hwaddress flag.
hwasan: add -fsanitize=kernel-hwaddress flag
Apr 13 2018, 11:08 AM
andreyknvl committed rC330044: hwasan: add -fsanitize=kernel-hwaddress flag.
hwasan: add -fsanitize=kernel-hwaddress flag
Apr 13 2018, 11:08 AM
andreyknvl closed D45046: hwasan: add -fsanitize=kernel-hwaddress.
Apr 13 2018, 11:08 AM

Apr 12 2018

andreyknvl updated the diff for D45046: hwasan: add -fsanitize=kernel-hwaddress.

Fixed the assert. PTAL.

Apr 12 2018, 9:06 AM

Apr 10 2018

andreyknvl updated the diff for D45046: hwasan: add -fsanitize=kernel-hwaddress.

Hm, I don't see this failure. Just in case I rebased onto the latest tip.

Apr 10 2018, 7:22 AM

Apr 9 2018

andreyknvl added a comment to D44981: asan: kernel: make no_sanitize("address") attribute work with -fsanitize=kernel-address.

Thanks! Could you commit this?

Apr 9 2018, 7:48 AM
andreyknvl added a comment to D45046: hwasan: add -fsanitize=kernel-hwaddress.

Thanks! Could you commit this as well?

Apr 9 2018, 7:48 AM

Apr 6 2018

andreyknvl updated the diff for D45046: hwasan: add -fsanitize=kernel-hwaddress.

Added a test.

Apr 6 2018, 10:09 AM
andreyknvl updated the summary of D45046: hwasan: add -fsanitize=kernel-hwaddress.
Apr 6 2018, 6:36 AM
andreyknvl updated the diff for D45046: hwasan: add -fsanitize=kernel-hwaddress.

PTAL. Added AlwaysRecoverable to SanitizerArgs.cpp. Right now recovery is disallowed for both KASan and KHWASan, but all the appropriate flags seem to be passed properly to the instrumentation pass, so we can easily allow it in the future in we want.

Apr 6 2018, 6:36 AM
andreyknvl added a comment to D45046: hwasan: add -fsanitize=kernel-hwaddress.

Also rebased onto the latest tip.

Apr 6 2018, 6:36 AM
andreyknvl added a comment to D44981: asan: kernel: make no_sanitize("address") attribute work with -fsanitize=kernel-address.

I don't have any preference between -fsanitize=kernel-address and -fsanitize=address -mllvm asan-kernel=1. GCC uses -fsanitize=kernel-address and I think it looked quite logical to use the same in Clang.

Apr 6 2018, 5:22 AM

Apr 4 2018

andreyknvl added inline comments to D45046: hwasan: add -fsanitize=kernel-hwaddress.
Apr 4 2018, 9:10 AM
andreyknvl updated the diff for D45046: hwasan: add -fsanitize=kernel-hwaddress.

Check ClEnableK[hw]asan.getNumOccurrences().

Apr 4 2018, 9:02 AM
andreyknvl added a comment to D44827: hwasan: add -hwasan-match-all-tag flag.

Could you commit this?

Apr 4 2018, 8:47 AM
andreyknvl added a comment to D44981: asan: kernel: make no_sanitize("address") attribute work with -fsanitize=kernel-address.

The -fsanitize=kernel-address flag is used by the kernel and we should leave it. The no_sanitize("kernel-address") attribute is not used in the kernel, so it's totally OK to get rid of it. What kind of changes would that require? AFAIU clang/include/clang/Basic/Sanitizers.def is used to generate both, the flag and the no_sanitize attribute.

Apr 4 2018, 5:09 AM

Apr 3 2018

andreyknvl added inline comments to D45046: hwasan: add -fsanitize=kernel-hwaddress.
Apr 3 2018, 7:17 AM
andreyknvl updated the diff for D45046: hwasan: add -fsanitize=kernel-hwaddress.
Apr 3 2018, 7:16 AM
andreyknvl updated the diff for D45046: hwasan: add -fsanitize=kernel-hwaddress.

Addressed @eugenis comments.

Apr 3 2018, 7:07 AM
andreyknvl added a comment to D44981: asan: kernel: make no_sanitize("address") attribute work with -fsanitize=kernel-address.

I don't see an easy way to fix this in SemaDeclAttr.cpp. The way that I see is to change std::vector<StringRef> Sanitizers to something like std::set, then .insert("kernel-address") when we see "address" and vice versa, and then convert back to vector before passing to D->addAttr. What do you think?

Apr 3 2018, 6:20 AM

Mar 29 2018

andreyknvl updated the diff for D45046: hwasan: add -fsanitize=kernel-hwaddress.

Rebased onto https://reviews.llvm.org/D44699

Mar 29 2018, 10:56 AM
andreyknvl added a comment to D45046: hwasan: add -fsanitize=kernel-hwaddress.

Note: goes on top of https://reviews.llvm.org/D44827 and https://reviews.llvm.org/D44981

Mar 29 2018, 7:37 AM
andreyknvl added reviewers for D45046: hwasan: add -fsanitize=kernel-hwaddress: glider, dvyukov, kcc, eugenis.
Mar 29 2018, 7:37 AM
andreyknvl created D45046: hwasan: add -fsanitize=kernel-hwaddress.
Mar 29 2018, 7:37 AM
andreyknvl added a comment to D44981: asan: kernel: make no_sanitize("address") attribute work with -fsanitize=kernel-address.

I think it makes sense to make both no_sanitize("address") and no_sanitize("kernel-address") work. Done that.

Mar 29 2018, 6:17 AM
andreyknvl updated the diff for D44981: asan: kernel: make no_sanitize("address") attribute work with -fsanitize=kernel-address.
Mar 29 2018, 6:16 AM

Mar 28 2018

andreyknvl updated the diff for D44981: asan: kernel: make no_sanitize("address") attribute work with -fsanitize=kernel-address.
Mar 28 2018, 9:03 AM
andreyknvl updated the summary of D44981: asan: kernel: make no_sanitize("address") attribute work with -fsanitize=kernel-address.
Mar 28 2018, 8:58 AM
andreyknvl created D44981: asan: kernel: make no_sanitize("address") attribute work with -fsanitize=kernel-address.
Mar 28 2018, 8:57 AM
andreyknvl added a comment to D44827: hwasan: add -hwasan-match-all-tag flag.

Done, PTAL

Mar 28 2018, 7:20 AM
andreyknvl updated the diff for D44827: hwasan: add -hwasan-match-all-tag flag.
Mar 28 2018, 7:20 AM

Mar 27 2018

andreyknvl added a comment to D44827: hwasan: add -hwasan-match-all-tag flag.

What do you mean by "(0 .. 0xFF, -1)"? Should it accept a list of tag values in some format?

Mar 27 2018, 5:19 AM

Mar 23 2018

andreyknvl created D44827: hwasan: add -hwasan-match-all-tag flag.
Mar 23 2018, 6:49 AM

Feb 21 2018

andreyknvl added a comment to D43135: hwasan: fix inline instrumentation.

If to land means to commit, then yes, please :)

Feb 21 2018, 11:34 AM
andreyknvl added a comment to D43135: hwasan: fix inline instrumentation.

PTAL

Feb 21 2018, 11:21 AM
andreyknvl updated the diff for D43135: hwasan: fix inline instrumentation.

Try harder to install SIGTRAP handler.

Feb 21 2018, 11:21 AM
andreyknvl added a comment to D43135: hwasan: fix inline instrumentation.

PTAL

Feb 21 2018, 10:41 AM
andreyknvl updated the diff for D43135: hwasan: fix inline instrumentation.

Install SIGTRAP handler.

Feb 21 2018, 10:41 AM
andreyknvl added a comment to D43135: hwasan: fix inline instrumentation.

Done, PTAL

Feb 21 2018, 9:52 AM
andreyknvl updated the diff for D43135: hwasan: fix inline instrumentation.

Use 0x900 instead of 0x100 for brk immediate (0x100 - 0x800 are unavailable in the kernel).

Feb 21 2018, 9:52 AM
andreyknvl added a comment to D43135: hwasan: fix inline instrumentation.

It seems that hwasan_linux.cc is in a different repo (compiler-rt) and is not picked up by svn diff. Do I need to submit that change as a separate patch?

Feb 21 2018, 8:26 AM
andreyknvl added a comment to D42473: asan: add kernel inline instrumentation test.

This is still not committed AFAICT.

Feb 21 2018, 4:58 AM
andreyknvl updated the diff for D42473: asan: add kernel inline instrumentation test.

Renamed kernel_inline.ll to kernel-inline.ll

Feb 21 2018, 4:57 AM
andreyknvl added a comment to D43135: hwasan: fix inline instrumentation.

PTAL

Feb 21 2018, 4:52 AM
andreyknvl retitled D43135: hwasan: fix inline instrumentation from hwasan: fix kernel inline instrumentation to hwasan: fix inline instrumentation.
Feb 21 2018, 4:52 AM
andreyknvl updated the diff for D43135: hwasan: fix inline instrumentation.

Switched user space hwasan to brk.
Fixed and added tests.

Feb 21 2018, 4:52 AM

Feb 9 2018

andreyknvl created D43135: hwasan: fix inline instrumentation.
Feb 9 2018, 11:10 AM

Feb 7 2018

andreyknvl added a comment to D42941: [hwasan] Fix kernel instrumentation of stack..

I'll send my patch with more khwasan related changes, once this is committed.

Feb 7 2018, 10:49 AM

Feb 6 2018

andreyknvl accepted D42941: [hwasan] Fix kernel instrumentation of stack..

Thanks!

Feb 6 2018, 9:02 AM

Jan 26 2018

andreyknvl added a comment to D42473: asan: add kernel inline instrumentation test.

Sorry, it was supposed to go on top of https://reviews.llvm.org/D42423 (which is committed now).
Anyway, I noticed an issue in naming ("loadN" is actually supposed to be "load_n") and another issue with asan flags (need "-asan-recover=1" and "noabort" suffixes).
Could you try again?

Jan 26 2018, 5:26 AM
andreyknvl updated the diff for D42473: asan: add kernel inline instrumentation test.

Fixed "_n" vs "N" naming and added "-asan-recover=1" flag, which is always enabled for the kernel.

Jan 26 2018, 5:24 AM

Jan 25 2018

andreyknvl added a comment to D42423: asan: fix kernel callback naming in instrumentation module.

Could you commit this?

Jan 25 2018, 8:44 AM
andreyknvl added a comment to D42473: asan: add kernel inline instrumentation test.

Yes, that would be great if you commit this.

Jan 25 2018, 8:43 AM

Jan 24 2018

andreyknvl added a comment to D42384: asan: allow inline instrumentation for the kernel.

Sent https://reviews.llvm.org/D42473

Jan 24 2018, 5:50 AM
andreyknvl created D42473: asan: add kernel inline instrumentation test.
Jan 24 2018, 5:50 AM

Jan 23 2018

andreyknvl added a comment to D42423: asan: fix kernel callback naming in instrumentation module.

It is strange indeed.

Jan 23 2018, 10:54 AM
andreyknvl added a comment to D42423: asan: fix kernel callback naming in instrumentation module.

Asan uses "asan_loadN" and "asan_storeN" and hwasan now has "hwasan_loadN" and "hwasan_storeN", so both use "N" and this is consistent as is.

Jan 23 2018, 10:43 AM
andreyknvl added a comment to D42423: asan: fix kernel callback naming in instrumentation module.

Please fix hwasan as well.

Jan 23 2018, 10:25 AM
andreyknvl created D42423: asan: fix kernel callback naming in instrumentation module.
Jan 23 2018, 7:33 AM

Jan 22 2018

andreyknvl created D42384: asan: allow inline instrumentation for the kernel.
Jan 22 2018, 10:37 AM