Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Mar 10 2023

florianhumblot added a comment to D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases..
In D145778#4184611, @PiotrZSL wrote:

What should I put as commit author ?
I'm asking because this is diff, and commit author looks to be attached to it.

Mar 10 2023, 5:47 AM · Restricted Project, Restricted Project
florianhumblot added a comment to D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases..
In D145778#4184530, @PiotrZSL wrote:

LGTM

Mar 10 2023, 5:12 AM · Restricted Project, Restricted Project
florianhumblot updated the diff for D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases..

Generate diff with full context and updated the example to use the default settings of the readabiliy-magic-numbers checker

Mar 10 2023, 4:39 AM · Restricted Project, Restricted Project
florianhumblot abandoned D145780: [clang-tidy] Introduce option to allow magic numbers in type aliases.

Accidentally opened this one with arcanist. The changes have been moved to https://reviews.llvm.org/D145778

Mar 10 2023, 4:24 AM · Restricted Project, Restricted Project
florianhumblot updated the diff for D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases..

Made it so that the proposed change doesn't change the default behavior of the check.
Introduce an option to allow enabling the exclusion.

Mar 10 2023, 4:06 AM · Restricted Project, Restricted Project
florianhumblot requested review of D145780: [clang-tidy] Introduce option to allow magic numbers in type aliases.
Mar 10 2023, 3:28 AM · Restricted Project, Restricted Project
florianhumblot requested review of D145778: [clang-tidy] Change readability-magic-numbers to allow numbers in type aliases..
Mar 10 2023, 2:31 AM · Restricted Project, Restricted Project